[jira] [Updated] (CB-11810) [iOS-3.9.1] unable to load index page from frameworkpath

2016-09-05 Thread saurabh dwivedi (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

saurabh dwivedi updated CB-11810:
-
Attachment: SampleApp.zip

Attaching:-
1. sample app
2. framework project

Console Logs:
2016-09-06 10:23:18.780 HelloWorld[808:124847] DiskCookieStorage changing 
policy from 2 to 0, cookie file: 
file:///private/var/mobile/Containers/Data/Application/DCD91F49-9D06-4FC7-84A3-29F2BA990358/Library/Cookies/Cookies.binarycookies
2016-09-06 10:23:18.829 HelloWorld[808:124847] Apache Cordova native platform 
version 3.9.2 is starting.
2016-09-06 10:23:18.830 HelloWorld[808:124847] Multi-tasking -> Device: YES, 
App: YES
2016-09-06 10:23:18.833 HelloWorld[808:124847] Unlimited access to network 
resources
2016-09-06 10:23:18.841 HelloWorld[808:124847] 

Started backup to iCloud! Please be careful.
Your application might be rejected by Apple if you store too much data.
For more information please read "iOS Data Storage Guidelines" at:
https://developer.apple.com/icloud/documentation/data-storage/
To disable web storage backup to iCloud, set the BackupWebStorage preference to 
"local" in the Cordova config.xml file

2016-09-06 10:23:18.896 HelloWorld[808:124847] ERROR: Start Page at 
'/var/containers/Bundle/Application/0B5D975E-A230-4154-ABCA-519E448355C3/HelloWorld.app/Frameworks/testFw.framework/www/index_test.html'
 was not found.
2016-09-06 10:23:19.144 HelloWorld[808:124847] Resetting plugins due to page 
load.
2016-09-06 10:23:19.200 HelloWorld[808:124847] Finished load of: about:blank




> [iOS-3.9.1] unable to load index page from frameworkpath
> 
>
> Key: CB-11810
> URL: https://issues.apache.org/jira/browse/CB-11810
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Affects Versions: 3.9.0
> Environment: ios 9.3.4 generic all ios devices
>Reporter: saurabh dwivedi
>Priority: Blocker
> Attachments: SampleApp.zip
>
>
> Unable to load index page from custom framework path.
> Steps to reproduce
> Create a sample app using command line.
> Create a sample framework project with index page as assets
> Add frame work in cordova sample app.
> Change wwwFolderName and startPage.
> Launch the app error is coming index page is not loaded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11810) [iOS-3.9.1] unable to load index page from frameworkpath

2016-09-05 Thread saurabh dwivedi (JIRA) 
saurabh dwivedi created CB-11810:


 Summary: [iOS-3.9.1] unable to load index page from frameworkpath
 Key: CB-11810
 URL: https://issues.apache.org/jira/browse/CB-11810
 Project: Apache Cordova
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: iOS
Affects Versions: 3.9.0
 Environment: ios 9.3.4 generic all ios devices
Reporter: saurabh dwivedi
Priority: Blocker


Unable to load index page from custom framework path.
Steps to reproduce
Create a sample app using command line.
Create a sample framework project with index page as assets
Add frame work in cordova sample app.
Change wwwFolderName and startPage.
Launch the app error is coming index page is not loaded.






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6708) iOS does not preserve GPS metadata from images picked from the Photo Gallery

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466357#comment-15466357
 ] 

ASF GitHub Bot commented on CB-6708:


Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/230
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/230/commits/f5589e1a1204b0230a498a1c88425b36267d0cf6)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/82//PLATFORM=android/artifact/)
 |
 



> iOS does not preserve GPS metadata from images picked from the Photo Gallery
> 
>
> Key: CB-6708
> URL: https://issues.apache.org/jira/browse/CB-6708
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Reporter: Ryan Murphy
>Priority: Minor
>  Labels: Triaged, camera, gps, ios
>
> Images picked from the gallery do not preserve metadata when saved to tmp. 
> Particularly they lose GPS metadata.
> This extra metadata is available in asset.defaultRepresentation.metadata. 
> I have a solution that works for my purpose. But currently only saving with 
> asset.defaultRepresentation.fullResolutionImage.
> Approach to get the asset: https://github.com/foundry/UIImageMetadata
> Approach to save the asset: http://stackoverflow.com/a/15398387/618412 
> (answer from Andrew Theis).
> Thanks for consideration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10140) Use application id instead of package name when running

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466348#comment-15466348
 ] 

ASF GitHub Bot commented on CB-10140:
-

Github user fredgalvao commented on the issue:

https://github.com/apache/cordova-android/pull/244
  
@infil00p This issue still exists. For anyone changin applicationId on 
android, to use flavours or whitelabel-like solutions, running cordova will 
always try to launch the base package name. It should definitely launch the 
applicationId instead. I mistakenly created [another 
issue](https://issues.apache.org/jira/browse/CB-11374) a while ago for this, 
and I just now discovered this issue because of the mailing list notifications.

I'd love to see this topic being fixed/improved. There are a few other 
comments in [this issue](https://issues.apache.org/jira/browse/CB-11373) as 
well, regarding this subject.


> Use application id instead of package name when running
> ---
>
> Key: CB-10140
> URL: https://issues.apache.org/jira/browse/CB-10140
> Project: Apache Cordova
>  Issue Type: Improvement
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Android, CLI
>Reporter: Christian Cook
>Priority: Minor
>
> I've been working on a new plugin for Cordova which will allow you to easily 
> deploy different build types in a system lifecycle e.g. alpha, beta and 
> store. This will allow multiple instances of the same app on your device in 
> different states. Currently I've hit a bit of an interesting bug/issue when 
> using this in conjunction with the run command. When the plugin operates it 
> dynamically changes the application id depending on the state so com.test.app 
> becomes com.test.app.alpha and so son. Because of this, when running the app 
> from the CLI it then starts using the incorrect ID (it uses the packageName 
> from the Android Manifest and tries to run nothing or the wrong instance). 
> EDIT: See the PR for a suggested fix, and if you wish to try and replicate 
> this issue the plugin is now available here: 
> https://github.com/CookieCookson/cordova-plugin-lifecycle



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6708) iOS does not preserve GPS metadata from images picked from the Photo Gallery

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466303#comment-15466303
 ] 

ASF GitHub Bot commented on CB-6708:


Github user lxbyes commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/230
  
ICLA has been signed and re submitted to secret...@apache.org.


> iOS does not preserve GPS metadata from images picked from the Photo Gallery
> 
>
> Key: CB-6708
> URL: https://issues.apache.org/jira/browse/CB-6708
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Reporter: Ryan Murphy
>Priority: Minor
>  Labels: Triaged, camera, gps, ios
>
> Images picked from the gallery do not preserve metadata when saved to tmp. 
> Particularly they lose GPS metadata.
> This extra metadata is available in asset.defaultRepresentation.metadata. 
> I have a solution that works for my purpose. But currently only saving with 
> asset.defaultRepresentation.fullResolutionImage.
> Approach to get the asset: https://github.com/foundry/UIImageMetadata
> Approach to save the asset: http://stackoverflow.com/a/15398387/618412 
> (answer from Andrew Theis).
> Thanks for consideration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6708) iOS does not preserve GPS metadata from images picked from the Photo Gallery

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15466301#comment-15466301
 ] 

ASF GitHub Bot commented on CB-6708:


Github user lxbyes commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-camera/pull/230#discussion_r77570045
  
--- Diff: src/ios/CDVCamera.m ---
@@ -240,13 +240,9 @@ - (void)alertView:(UIAlertView *)alertView 
clickedButtonAtIndex:(NSInteger)butto
 
 - (void)repositionPopover:(CDVInvokedUrlCommand*)command
 {
-if (([[self pickerController] pickerPopoverController] != nil) && 
[[[self pickerController] pickerPopoverController] isPopoverVisible]) {
+NSDictionary* options = [command argumentAtIndex:0 withDefault:nil];
--- End diff --

Hi.
  I have sync code to my forks.


> iOS does not preserve GPS metadata from images picked from the Photo Gallery
> 
>
> Key: CB-6708
> URL: https://issues.apache.org/jira/browse/CB-6708
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Reporter: Ryan Murphy
>Priority: Minor
>  Labels: Triaged, camera, gps, ios
>
> Images picked from the gallery do not preserve metadata when saved to tmp. 
> Particularly they lose GPS metadata.
> This extra metadata is available in asset.defaultRepresentation.metadata. 
> I have a solution that works for my purpose. But currently only saving with 
> asset.defaultRepresentation.fullResolutionImage.
> Approach to get the asset: https://github.com/foundry/UIImageMetadata
> Approach to save the asset: http://stackoverflow.com/a/15398387/618412 
> (answer from Andrew Theis).
> Thanks for consideration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11809) Tutorial from the main page doesn't work

2016-09-05 Thread JIRA 
Cássio Hideki Kanashiro Oseki created CB-11809:
--

 Summary: Tutorial from the main page doesn't work
 Key: CB-11809
 URL: https://issues.apache.org/jira/browse/CB-11809
 Project: Apache Cordova
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: Browser, CLI
Affects Versions: 6.3.1
Reporter: Cássio Hideki Kanashiro Oseki


cordova run needs a very specific browser to run, and does nothing if this very 
specific browser doesn't exist the expected places

[empjustine@artemis conservo]$ ~/node_modules/.bin/cordova run browser
Running command: /home/empjustine/conservo/platforms/browser/cordova/build 
Cleaning Browser project
Running command: /home/empjustine/conservo/platforms/browser/cordova/run 
--nobuild
Static file server running @ http://localhost:8000/index.html
CTRL + C to shut down
Error executing "google-chrome 
--user-data-dir=/tmp/temp_chrome_user_data_dir_for_cordova 
http://localhost:8000/index.html": /bin/sh: google-chrome: command not found
[empjustine@artemis conservo]$ 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-3232) "cordova platform add blackberry" fails on 2.7.1-rc.1

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465858#comment-15465858
 ] 

ASF GitHub Bot commented on CB-3232:


GitHub user lucatorella opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17

Avoid retain cycle caused by WKUserContentController retaining its message 
handler

### Platforms affected
iOS

### What does this PR do?
This PR breaks the retain cycle caused by WKUserContentController retaining 
its message handler. This retain cycle would cause apps that create different 
CDVViewController instances to leak memory. For instance if you have a 
navigation controller, and you push a CDVViewController instance and then you 
go back, the view controller just pulled out of the stack is not deallocated.

### What testing has been done on this change?
I tested that the message from javascript are still passed. I think it's 
enough.

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

…er, to break it we cannot pass directly CDVWKWebViewEngine's instance

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lucatorella/cordova-plugin-wkwebview-engine 
feature/avoid-addScriptMessageHandler-leak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit 1d135e8ffd1556dd6fee49e820fca902bfb59a6a
Author: Luca Torella 
Date:   2016-09-05T21:53:17Z

Avoid retain cycle: WKUserContentController retains its message handler, to 
break it we cannot pass directly CDVWKWebViewEngine's instance




> "cordova platform add blackberry" fails on 2.7.1-rc.1
> -
>
> Key: CB-3232
> URL: https://issues.apache.org/jira/browse/CB-3232
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: BlackBerry, CLI
>Affects Versions: 2.7.0
>Reporter: Michael Brooks
>Assignee: Michael Brooks
> Fix For: 2.7.0
>
>
> The following error is thrown when running {{$ cordova platform add 
> blackberry}}:
> {code}
> [Error: An error occured during creation of blackberry sub-project. Creating 
> BlackBerry project...
> Updating config.xml ...
> sed: 
> /Users/mwbrooks/Dropbox/Development/sandbox/myapp/platforms/blackberry/www/config.xml:
>  No such file or directory
> Cleaning up ...
> Remember to update the project.properties file inside your application 
> directory!
> ]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11808) cordova prepare generates build files with invalid gradle dependencies

2016-09-05 Thread JIRA 
Cássio Hideki Kanashiro Oseki created CB-11808:
--

 Summary: cordova prepare generates build files with invalid gradle 
dependencies
 Key: CB-11808
 URL: https://issues.apache.org/jira/browse/CB-11808
 Project: Apache Cordova
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: CLI
Affects Versions: 6.3.1
 Environment: $ uname -a
Linux artemis 4.6.7-300.fc24.x86_64 #1 SMP Wed Aug 17 18:48:43 UTC 2016 x86_64 
x86_64 x86_64 GNU/Linux
Fedora 24 
$ cordova --version
6.3.1
Reporter: Cássio Hideki Kanashiro Oseki


Following the tutorial provided on the main Apache Cordova landing page, with 
"android" as platform, results in an unsupported Gradle version not running 
because of incomplete dependency resolution.

[empjustine@artemis conservo]$ ANDROID_HOME=$HOME/Android/Sdk/ 
$HOME/node_modules/.bin/cordova build
ANDROID_HOME=/home/empjustine/Android/Sdk/
JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-1.8.0.102-1.b14.fc24.x86_64

FAILURE: Build failed with an exception.

* Where:
Build file '/home/empjustine/conservo/platforms/android/build.gradle' line: 20

* What went wrong:
A problem occurred evaluating root project 'android'.
> Failed to apply plugin [id 'com.android.application']
   > Minimum supported Gradle version is 2.14.1.  Current version is 2.13. If 
using the gradle wrapper, try editing the distributionUrl in 
/home/empjustine/conservo/gradle/wrapper/gradle-wrapper.properties to 
gradle-2.14.1-all.zip

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

BUILD FAILED

Total time: 6.412 secs
Error: /home/empjustine/conservo/platforms/android/gradlew: Command failed with 
exit code 1 Error output:
FAILURE: Build failed with an exception.

* Where:
Build file '/home/empjustine/conservo/platforms/android/build.gradle' line: 20

* What went wrong:
A problem occurred evaluating root project 'android'.
> Failed to apply plugin [id 'com.android.application']
   > Minimum supported Gradle version is 2.14.1.  Current version is 2.13. If 
using the gradle wrapper, try editing the distributionUrl in 
/home/empjustine/conservo/gradle/wrapper/gradle-wrapper.properties to 
gradle-2.14.1-all.zip

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.

[empjustine@artemis conservo]$ head 
/home/empjustine/conservo/gradle/wrapper/gradle-wrapper.properties
head: cannot open 
'/home/empjustine/conservo/gradle/wrapper/gradle-wrapper.properties' for 
reading: No such file or directory




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465692#comment-15465692
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user jacquesdev commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
@jcesarmobile - please let me know if you need anything else from me to get 
this merged.


> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465402#comment-15465402
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/236/commits/24874e972a4ad6f3736d86b18a737ac4bcb1e615)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/81//PLATFORM=android/artifact/)
 |
 



> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465317#comment-15465317
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/236/commits/24874e972a4ad6f3736d86b18a737ac4bcb1e615)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/80//PLATFORM=android/artifact/)
 |
 



> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465182#comment-15465182
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
Let there be tests


> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465160#comment-15465160
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-camera/pull/236/commits/2fa78680af444e837ced3b6374c5f3dc6acef53b)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/79//PLATFORM=android/artifact/)
 |
 



> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465031#comment-15465031
 ] 

ASF GitHub Bot commented on CB-11661:
-

Github user kristiyandobrev commented on the issue:

https://github.com/apache/cordova-plugin-camera/pull/236
  
By the way if trying to shoot a video on `iOS` it crashes because it needs 
a permission for the Microphone  or `NSMicrophoneUsageDescription` in the plist 
 


> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11807) Project is not building for folder name contains '&' character

2016-09-05 Thread Aminul Islam (JIRA) 
Aminul Islam created CB-11807:
-

 Summary: Project is not building for folder name contains '&' 
character
 Key: CB-11807
 URL: https://issues.apache.org/jira/browse/CB-11807
 Project: Apache Cordova
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
  Components: Android, CLI
Reporter: Aminul Islam


Project (i.e.android platform) is not building if we keep the project in a 
folder whose name contains '&' character (i.e. "R")



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11566) SplashScreen.java uses or overrides a deprecated API

2016-09-05 Thread Adil Shaikh (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464844#comment-15464844
 ] 

Adil Shaikh commented on CB-11566:
--

Been a while. Are there any updates on the issue?

> SplashScreen.java uses or overrides a deprecated API
> 
>
> Key: CB-11566
> URL: https://issues.apache.org/jira/browse/CB-11566
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin SplashScreen
>Affects Versions: 6.2.0
> Environment: jdk 1.8. 
> Cordova 6.2.0
> Android Device Version - 5.1.1
>Reporter: Adil Shaikh
>Priority: Minor
>  Labels: android, easyfix, reproduced, triaged
>
> Creating a new project with cordova.
> Run it on android device.
> Launches successfully with warning:
> :CordovaLib:compileDebugJavaWithJavacNote: Some input files use or override a 
> deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Remove android platform from the project.
> I add plugin cordova-plugin-splashscreen to my project.
> Add android platform back to the project.
> Launch in android device.
> Launches successfully with a new warning along with the one above:
> :compileDebugJavaWithJavacNote: E:\a 
> Templates\cordovatemplate\platforms\android\src\org\apache\cordova\splashscreen\SplashScreen.java
>  uses or overrides a deprecated API.
> Note: Recompile with -Xlint:deprecation for details.
> Similar Issue I have reported to ionic which redirected me here:
> https://github.com/driftyco/ionic/issues/7057



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11661) Camera plugin crashes on iOS 10

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464557#comment-15464557
 ] 

ASF GitHub Bot commented on CB-11661:
-

GitHub user jacquesdev opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/236

CB-11661: (ios) Add mandatory iOS 10 privacy description



### Platforms affected
iOS

### What does this PR do?
Ensures the plugin enables users to select photos from the photoalbum in 
iOS10.

### What testing has been done on this change?
It was a bug in my app before, and after this change, I am now able to 
successfully add photos to the photoalbum

### Checklist
- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

Add support for photoalbum description

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OLIOEX/cordova-plugin-camera master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/236.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #236


commit 2fa78680af444e837ced3b6374c5f3dc6acef53b
Author: Jacques de Villiers 
Date:   2016-09-05T08:38:16Z

CB-11661: (ios) Add mandatory iOS 10 privacy description

Add support for photoalbum description




> Camera plugin crashes on iOS 10
> ---
>
> Key: CB-11661
> URL: https://issues.apache.org/jira/browse/CB-11661
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Plugin Camera
>Affects Versions: 3.5.0
> Environment: iOS 10
>Reporter: jcesarmobile
>
> We need to add a privacy description to the plist. Since iOS 6 Apple provided 
> a way to show the user why a certain permission is required. In iOS 10 this 
> becomes mandatory, so any app not specifying the key will crash at runtime 
> when a permissions is requested.
> This plugin requests the Camera permission, so at the very least we need to 
> add NSCameraUsageDescription and NSPhotoLibraryUsageDescription to the 
> `plist`.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-11806) Don'

2016-09-05 Thread Shazron Abdullah (JIRA) 
Shazron Abdullah created CB-11806:
-

 Summary: Don'
 Key: CB-11806
 URL: https://issues.apache.org/jira/browse/CB-11806
 Project: Apache Cordova
  Issue Type: Bug
  Security Level: Public (Anyone can view this level - this is the default.)
Reporter: Shazron Abdullah






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11806) Don't need to escape < > in XML attributes

2016-09-05 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-11806:
--
Component/s: Docs

> Don't need to escape < > in XML attributes
> --
>
> Key: CB-11806
> URL: https://issues.apache.org/jira/browse/CB-11806
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Docs
>Reporter: Shazron Abdullah
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11806) Don't need to escape < > in XML attributes

2016-09-05 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-11806:
--
Summary: Don't need to escape < > in XML attributes  (was: Don')

> Don't need to escape < > in XML attributes
> --
>
> Key: CB-11806
> URL: https://issues.apache.org/jira/browse/CB-11806
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Docs
>Reporter: Shazron Abdullah
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-11806) Don't need to escape < > in XML attributes

2016-09-05 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-11806:
--
Description: 
http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine

The examples are wrong.

> Don't need to escape < > in XML attributes
> --
>
> Key: CB-11806
> URL: https://issues.apache.org/jira/browse/CB-11806
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Docs
>Reporter: Shazron Abdullah
>
> http://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#engines-and-engine
> The examples are wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-11787) Fixes for cocoapods plugin support

2016-09-05 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah resolved CB-11787.
---
Resolution: Fixed

> Fixes for cocoapods plugin support
> --
>
> Key: CB-11787
> URL: https://issues.apache.org/jira/browse/CB-11787
> Project: Apache Cordova
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Affects Versions: 4.2.1
> Environment: cordova-ios nightly, cordova-cli nightly
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>  Labels: triaged
>
> Umbrella issue
> Test using: https://github.com/phonegap/phonegap-plugin-push/pull/1183



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11790) Check that Cocoapods is installed by checking `pod install` return code, show help text

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464233#comment-15464233
 ] 

ASF GitHub Bot commented on CB-11790:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-ios/pull/253


>  Check that Cocoapods is installed by checking `pod install` return code, 
> show help text
> 
>
> Key: CB-11790
> URL: https://issues.apache.org/jira/browse/CB-11790
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> Line: 
> https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. 
> Currently, it just silently fails (pod install is called, but its error code 
> is not checked). 
> We need to decide what to do with the user experience issue if pod install is 
> first run -- this triggers a Cocoapods repo clone, which at the time I write 
> this is 475MB. The time to download this repo is non-trivial, and the size of 
> the repo increases linearly each day. We should add a notice to the output 
> that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the 
> Github API like this Chrome Extension: 
> https://github.com/harshjv/github-repo-size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11790) Check that Cocoapods is installed by checking `pod install` return code, show help text

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464229#comment-15464229
 ] 

ASF GitHub Bot commented on CB-11790:
-

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-ios/pull/253
  
## [Current 
coverage](https://codecov.io/gh/apache/cordova-ios/pull/253?src=pr) is 56.90% 
(diff: 64.38%)
> Merging [#253](https://codecov.io/gh/apache/cordova-ios/pull/253?src=pr) 
into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) 
will increase coverage by **0.95%**

```diff
@@ master   #253   diff @@
==
  Files11 12 +1   
  Lines  1017   1086+69   
  Methods 147169+22   
  Messages  0  0  
  Branches171174 +3   
==
+ Hits569618+49   
- Misses  448468+20   
  Partials  0  0  
```

> Powered by [Codecov](https://codecov.io?src=pr). Last update 
[aa28508...1673350](https://codecov.io/gh/apache/cordova-ios/compare/aa28508d1e31e3b8c210494b73a906372d31daa3...1673350afd24d919658c66c1b779fd7395558d87?src=pr)


>  Check that Cocoapods is installed by checking `pod install` return code, 
> show help text
> 
>
> Key: CB-11790
> URL: https://issues.apache.org/jira/browse/CB-11790
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> Line: 
> https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. 
> Currently, it just silently fails (pod install is called, but its error code 
> is not checked). 
> We need to decide what to do with the user experience issue if pod install is 
> first run -- this triggers a Cocoapods repo clone, which at the time I write 
> this is 475MB. The time to download this repo is non-trivial, and the size of 
> the repo increases linearly each day. We should add a notice to the output 
> that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the 
> Github API like this Chrome Extension: 
> https://github.com/harshjv/github-repo-size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Assigned] (CB-11790) Check that Cocoapods is installed by checking `pod install` return code, show help text

2016-09-05 Thread Shazron Abdullah (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah reassigned CB-11790:
-

Assignee: Shazron Abdullah

>  Check that Cocoapods is installed by checking `pod install` return code, 
> show help text
> 
>
> Key: CB-11790
> URL: https://issues.apache.org/jira/browse/CB-11790
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>
> Line: 
> https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. 
> Currently, it just silently fails (pod install is called, but its error code 
> is not checked). 
> We need to decide what to do with the user experience issue if pod install is 
> first run -- this triggers a Cocoapods repo clone, which at the time I write 
> this is 475MB. The time to download this repo is non-trivial, and the size of 
> the repo increases linearly each day. We should add a notice to the output 
> that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the 
> Github API like this Chrome Extension: 
> https://github.com/harshjv/github-repo-size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11790) Check that Cocoapods is installed by checking `pod install` return code, show help text

2016-09-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15464219#comment-15464219
 ] 

ASF GitHub Bot commented on CB-11790:
-

GitHub user shazron opened a pull request:

https://github.com/apache/cordova-ios/pull/253

CB-11790 - Check that Cocoapods is installed by checking `pod install` 
return code, show help text

Re-factored code to be modular - Podfile and PodsJson are abstractions for 
the files themselves, and include unit-tests.
The addPlugin/removePlugin code in Api.js uses the two files above now, 
resulting in cleaner and more maintainable code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shazron/cordova-ios CB-11790

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-ios/pull/253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #253


commit 1673350afd24d919658c66c1b779fd7395558d87
Author: Shazron Abdullah 
Date:   2016-09-02T01:08:18Z

CB-11790 - Check that Cocoapods is installed by checking `pod install` 
return code, show help text

Re-factored code to be modular - Podfile and PodsJson are abstractions for 
the files themselves, and include unit-tests.
The addPlugin/removePlugin code in Api.js uses the two files above now, 
resulting in cleaner and more maintainable code.




>  Check that Cocoapods is installed by checking `pod install` return code, 
> show help text
> 
>
> Key: CB-11790
> URL: https://issues.apache.org/jira/browse/CB-11790
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: iOS
>Reporter: Shazron Abdullah
>
> Line: 
> https://github.com/apache/cordova-ios/blob/826db773df6b0297a9d0b2e7889b9a028a80fe5f/bin/templates/scripts/cordova/lib/podMod.js#L59
> If it is not installed, we must error out and warn the user what to do. 
> Currently, it just silently fails (pod install is called, but its error code 
> is not checked). 
> We need to decide what to do with the user experience issue if pod install is 
> first run -- this triggers a Cocoapods repo clone, which at the time I write 
> this is 475MB. The time to download this repo is non-trivial, and the size of 
> the repo increases linearly each day. We should add a notice to the output 
> that it might take a long time.
> Additionally, we could report the size of the Cocoapods repo by using the 
> Github API like this Chrome Extension: 
> https://github.com/harshjv/github-repo-size



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org