[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517793#comment-16517793 ] ASF GitHub Bot commented on CB-14091: - purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398621808 my song is really just 8 bars repeating for 60 seconds ... the word 'song' may be a bit of stretch ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517791#comment-16517791 ] ASF GitHub Bot commented on CB-14091: - knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398621259 Thanks shazron and purplecabbage, I have updated the tests code to use BlueZedEx.mp3 file for each test. Sorry, I can not make song. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517765#comment-16517765 ] ASF GitHub Bot commented on CB-14091: - purplecabbage edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398614641 Why you not like song? Is it rock too hard? jk . I can change the format if that is the issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517762#comment-16517762 ] ASF GitHub Bot commented on CB-14091: - purplecabbage commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398614641 Why you no like song? Is it rock too hard? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517761#comment-16517761 ] ASF GitHub Bot commented on CB-14091: - shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398613643 Sorry to be a stickler on this -- just because something is in the Wayback Machine, does not mean that it lacks copyright. Until we can assert what license the file is in (like any code contribution), we can't add it to Apache. For example, BlueZed.mp3 was an original creation by @purplecabbage, a Cordova Committer and PMC member and assigned to Apache. In any case, I'm sure we can find a public domain/Apache-2.0 licensed music sample somewhere. For example, any of the clips here are public domain: https://musopen.org/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12849) Media Plugin: Saves file not in indicated directory
[
https://issues.apache.org/jira/browse/CB-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517708#comment-16517708
]
ASF GitHub Bot commented on CB-12849:
-
knight opened a new pull request #168: CB-12849: check state in destroy and
move file by stream
URL: https://github.com/apache/cordova-plugin-media/pull/168
### Platforms affected
android
### What does this PR do?
Resolving recording audio issue.
1. File.renameTo method used in AudioPlayer.java can not move file across
partitions.
Then I developed copying the file by using i/o stream when renameTo failing.
2. media.stopRecord() in JS calls stopRecording in Java,
However media.release() in JS also calls stopRecording in Java via destroy
method.
The second call of stopRecording overrides the audio file with empty.
This PR prevents the duplicated call of stopRecording.
### What testing has been done on this change?
sample code is
```
var fileName = "test.aac";
var myMedia = {};
var myStatus = null;
function recordMedia(){
myMedia = new Media(cordova.file.dataDirectory + fileName, function
(msg) {
console.log("Success:", msg);
}, function (e) {
console.error("Error:", e);
myMedia.release();
myStatus = Media.MEDIA_NONE;
}, function (status) {
console.info("Status:", status);
myStatus = status;
if (status == Media.MEDIA_STOPPED) {
myMedia.release();
myStatus = Media.MEDIA_NONE;
}
});
myMedia.startRecord();
}
function stopMedia () {
if (myStatus != Media.MEDIA_NONE) {
if (myStatus != Media.MEDIA_STOPPED) {
myMedia.stopRecord();
}
}
}
```
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Media Plugin: Saves file not in indicated directory
> ---
>
> Key: CB-12849
> URL: https://issues.apache.org/jira/browse/CB-12849
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-plugin-media
>Affects Versions: 6.5.0
> Environment: Device model: Nexus 5X
> Android version of device: 8.1.0
> Platform version: 7.1.0
> Cordova version: 8.0.0
> Cordova plugin media version: 5.0.1
>Reporter: Florian Pechwitz
>Priority: Major
> Labels: cordova-plugin-media
>
> I tried to build an application which records, stops the recording and then
> plays the recorded audio.
> The recording works fine but if I try to play the recorded audio I get error
> code 1. I found out that the recorded audio file was not in the directory but
> in a totally different directory
> (/storage/emulated/0/(tmprecording-1495618229386.3gp) with a different file
> name (tmprecording-1495618229386.3gp) and a different media type (video/3gpp)
> as indicated.
> I created a repo with a example application for this issue:
> https://github.com/Durzan666/cordova-plugin-media-demo
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517669#comment-16517669 ] ASF GitHub Bot commented on CB-14091: - knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org. (https://web.archive.org/web/20170205201205if_/http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3) I put this mp3 file on my repository and used it to test. `https://cordova-develop.github.io/cordova-plugin-media/res/ch_classic_128.mp3` I removed previous streaming test mp3 file `https://cordova-develop.github.io/cordova-plugin-media/res/mozart_serenade4_01.mp3`. If you can copy the original mp3 file ch_classic_128.mp3 to the cordova official site (For example, https://cordova.apache.org/downloads/), please copy it to use in testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517668#comment-16517668 ] ASF GitHub Bot commented on CB-14091: - knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org. (https://web.archive.org/web/20170205201205if_/http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3) I put this mp3 file on my repository and used it to test. I removed previous streaming test mp3 file `https://cordova-develop.github.io/cordova-plugin-media/res/mozart_serenade4_01.mp3`. If you can copy the original mp3 file ch_classic_128.mp3 to the cordova official site (For example, https://cordova.apache.org/downloads/), please copy it to use in testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517667#comment-16517667 ] ASF GitHub Bot commented on CB-14091: - knight edited a comment on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org. (https://web.archive.org/web/20170205201205if_/http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3) I put this mp3 file on my repository and used it to test. I removed previous streaming test mp3 file `https://cordova-develop.github.io/cordova-plugin-media/res/mozart_serenade4_01.mp3`. If you can copy the original mp3 file ch_classic_128.mp3 to the cordova official site (For example, https://cordova.apache.org/downloads/) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517665#comment-16517665 ] ASF GitHub Bot commented on CB-14091: - knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398590691 I found the original testing mp3 file ch_classic_128.mp3 from web.archive.org. (https://web.archive.org/web/20170205201205if_/http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3) I put this mp3 file on my repository and used it to test. I removed previous streaming test mp3 file `https://cordova-develop.github.io/cordova-plugin-media/res/mozart_serenade4_01.mp3`. If you can copy this file to the cordova official site (For example, https://cordova.apache.org/downloads/) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517664#comment-16517664 ] ASF GitHub Bot commented on CB-14091: - knight opened a new pull request #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166 ### Platforms affected Tests code only Browser (test) iOS (test) ### What does this PR do? Removing Browser's play audio tests. (which fails) Change test streaming mp3 file's url in iOS tests. ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[
https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517663#comment-16517663
]
ASF GitHub Bot commented on CB-14091:
-
knight closed pull request #166: CB-14091: fix tests code for stream url
and remove browser
URL: https://github.com/apache/cordova-plugin-media/pull/166
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 9e7438f0..f39fe518 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,35 +5,35 @@ addons:
env:
global:
- SAUCE_USERNAME=snay
- - TRAVIS_NODE_VERSION="4.2"
+ - TRAVIS_NODE_VERSION="6.14.2"
matrix:
include:
- env: PLATFORM=browser-chrome
os: linux
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=browser-firefox
os: linux
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=browser-safari
os: linux
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=browser-edge
os: linux
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=ios-9.3
os: osx
osx_image: xcode7.3
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=ios-10.0
os: osx
osx_image: xcode7.3
language: node_js
-node_js: '4.2'
+node_js: '6.14.2'
- env: PLATFORM=android-4.4
os: linux
language: android
diff --git a/tests/tests.js b/tests/tests.js
index 218f2a95..f9a12517 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -27,7 +27,7 @@
var ACTUAL_PLAYBACK_TEST_TIMEOUT = 2 * 60 * 1000;
var WEB_MP3_FILE = 'https://cordova.apache.org/downloads/BlueZedEx.mp3';
-var WEB_MP3_STREAM =
'http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3';
+var WEB_MP3_STREAM =
'https://cordova-develop.github.io/cordova-plugin-media/res/ch_classic_128.mp3';
var isWindows = cordova.platformId === 'windows8' || cordova.platformId ===
'windows';
var isBrowser = cordova.platformId === 'browser';
@@ -37,6 +37,8 @@ var isBrowser = cordova.platformId === 'browser';
var isAudioSupported = isWindows ?
!!Windows.Media.Devices.MediaDevice.getDefaultAudioRenderId(Windows.Media.Devices.AudioDeviceRole.default)
:
cordova.platformId === 'ios' ? !window.SAUCELABS_ENV : true;
+var isKitKat = cordova.platformId === 'android' &&
/Android\s4\.4/.test(window.navigator.userAgent);
+
exports.defineAutoTests = function () {
var failed = function (done, msg, context) {
if (context && context.done) return;
@@ -233,7 +235,7 @@ exports.defineAutoTests = function () {
it("media.spec.19 position should be set properly", function
(done) {
// no audio hardware available
-if (!isAudioSupported) {
+if (!isAudioSupported || isBrowser || isKitKat) {
pending();
}
@@ -262,7 +264,7 @@ exports.defineAutoTests = function () {
}, ACTUAL_PLAYBACK_TEST_TIMEOUT);
it("media.spec.20 duration should be set properly", function
(done) {
-if (!isAudioSupported || cordova.platformId ===
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10'
|| isBrowser || isKitKat) {
pending();
}
@@ -291,7 +293,7 @@ exports.defineAutoTests = function () {
}, ACTUAL_PLAYBACK_TEST_TIMEOUT);
it("media.spec.21 should be able to resume playback after pause",
function (done) {
-if (!isAudioSupported || cordova.platformId ===
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10'
|| isKitKat) {
pending();
}
@@ -335,7 +337,7 @@ exports.defineAutoTests = function () {
}, ACTUAL_PLAYBACK_TEST_TIMEOUT);
it("media.spec.22 should be able to seek through file", function
(done) {
-if (!isAudioSupported || cordova.platformId ===
'blackberry10') {
+if (!isAudioSupported || cordova.platformId === 'blackberry10'
|| isKitKat) {
pending();
}
@@ -421,7 +423,7 @@ exports.defineAutoTests = function () {
it("media.spec.25 should be able to play an audio stream", function
(done) {
// no audio hardware available, OR
// O_o Safari can't play the stream, so we're skipping this test
on all browsers o_O
-if (!isAudioSupported || isBrowser) {
+if (!isAudioSupported || isBrowser || isKitKat) {
pending();
}
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[
https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517631#comment-16517631
]
Raphael commented on CB-13695:
--
Since there were major changes to cordova-fetch lately, could you please test
if the issue persists on cordova@nightly?
When you do so, delete your node_modules, run with --verbose and make sure you
actually see output like the following:
{code:java}
fetch: Installing cordova-android@^7.0.0 to /tmp/tmp.4VQKXXz8Q2/cb-13797
Running command: npm install cordova-android@^7.0.0 --production --no-save
{code}
Otherwise cordova-fetch might be reusing already installed versions of your
dependencies.
> cordova-fetch: ignores npm registry
> ---
>
> Key: CB-13695
> URL: https://issues.apache.org/jira/browse/CB-13695
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch
>Affects Versions: cordova@8.0.0
>Reporter: Heiko
>Priority: Critical
>
> My situation:
> a build server that has no access to the internet.
> By to a local npm mirror.
> If i do at my build job:
> npm config set registry "http://my.local.server/repository/mirror.npm;
> npm install
> npm install cordova ionic npm --no-save
> cordova platform add ios --no-update-notifier
> i get:
> Using cordova-fetch for cordova-ios@4.5.3
> (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection
> (rejection id: 1): Error: Cannot find module './index'
> (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are
> deprecated. In the future, promise rejections that are not handled will
> terminate the Node.js process with a non-zero exit code.
> My work around for cordova 7 was to use: --nofetch
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517611#comment-16517611
]
ASF GitHub Bot commented on CB-14145:
-
brodybits closed pull request #173: CB-14145: package.json updates to resolve
npm audit warnings
URL: https://github.com/apache/cordova-coho/pull/173
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.json b/package.json
index ef87857..d86979f 100644
--- a/package.json
+++ b/package.json
@@ -35,14 +35,14 @@
"eslint-plugin-node": "^5.0.0",
"eslint-plugin-promise": "^3.5.0",
"eslint-plugin-standard": "^3.0.1",
-"nsp": ">=2.0.1",
"tap-dot": "^1.0.0",
-"tap-spec": "^4.0.0",
+"tap-spec": "^5.0.0",
"tape": "^4.0.0",
"tape-runner": "^0.3.0"
},
"scripts": {
-"test": "npm run eslint",
+"test": "npm run eslint && npm run jasmine && npm run tape-test",
+"tape-test": "node test/test.js | tap-spec",
"cover": "istanbul cover --root src --print detail jasmine",
"jasmine": "jasmine",
"eslint": "eslint test && eslint src"
diff --git a/spec/flagutil.spec.js b/spec/flagutil.spec.js
index be266dd..476353f 100644
--- a/spec/flagutil.spec.js
+++ b/spec/flagutil.spec.js
@@ -18,9 +18,11 @@ under the License.
*/
var path = require('path');
+
var apputil = require('../src/apputil');
var repoutil = require('../src/repoutil');
var flagutil = require('../src/flagutil');
+
var TIMEOUT = 6;
describe("flagutil unit tests", function () {
@@ -36,11 +38,12 @@ describe("flagutil unit tests", function () {
it("Test#002 : computeReposFromFlag returns correct repo (platform)
info", function () {
var repo = flagutil.computeReposFromFlag('android');
expect(repo).toEqual(
- [ Object({
- title: 'Android',
- id: 'android',
- repoName: 'cordova-android',
- jiraComponentName: 'Android',
+ [ Object({
+ title: 'Android',
+ versions: [ '4.4', '5.0', '5.1', '6.0', '7.0', '7.1' ],
+ id: 'android',
+ repoName: 'cordova-android',
+ jiraComponentName: 'cordova-android',
cordovaJsPaths: [
'bin/templates/project/assets/www/cordova.js' ] }) ]
);
},TIMEOUT);
@@ -51,7 +54,7 @@ describe("flagutil unit tests", function () {
[ { title: 'Plugin - Camera',
id: 'plugin-camera',
repoName: 'cordova-plugin-camera',
- jiraComponentName: 'Plugin Camera' } ]
+ jiraComponentName: 'cordova-plugin-camera' } ]
);
},TIMEOUT);
@@ -61,7 +64,7 @@ describe("flagutil unit tests", function () {
[ { title: 'Docs',
id: 'docs',
repoName: 'cordova-docs',
- jiraComponentName: 'Docs' } ]
+ jiraComponentName: 'cordova-docs' } ]
);
},TIMEOUT);
diff --git a/spec/gitutil.spec.js b/spec/gitutil.spec.js
index fbdb199..1bc09d0 100644
--- a/spec/gitutil.spec.js
+++ b/spec/gitutil.spec.js
@@ -47,12 +47,14 @@ describe("gitutil unit tests", function () {
expect(executil.ARGS.calls.argsFor(0)[0]).toEqual("git tag
--list 6.3.0");
},TIMEOUT);
+ /* XXX TBD LOOKS BROKEN:
it("Test#002 : validate remote branch", function* () {
var gitutilRemoteBranch = yield
gitutilJS.remoteBranchExists('android', 'name');
expect(executil.execHelper.calls.count()).toEqual(1);
expect(executil.ARGS.calls.count()).toEqual(1);
expect(executil.ARGS.calls.argsFor(0)[0]).toEqual("git branch
-r --list undefined/name");
},TIMEOUT);
+ // */
it("Test#003 : validate pending changes", function* () {
var gitutilPendingChanges = yield
gitutilJS.pendingChangesExist();
@@ -74,4 +76,4 @@ describe("gitutil unit tests", function () {
expect(executil.ARGS.calls.count()).toEqual(1);
expect(executil.ARGS.calls.argsFor(0)[0]).toEqual("git clean -d
-f");
},TIMEOUT);
-});
\ No newline at end of file
+});
diff --git a/spec/repoutil.spec.js b/spec/repoutil.spec.js
index fce8e82..7a0b464 100644
--- a/spec/repoutil.spec.js
+++ b/spec/repoutil.spec.js
@@ -18,18 +18,24 @@ under the License.
*/
var jasmine_co = require('jasmine-co').install();
+
var fs = require('fs');
var path = require('path');
+
var shelljs = require('shelljs');
+
var
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517610#comment-16517610
]
ASF GitHub Bot commented on CB-14145:
-
brodybits opened a new pull request #173: CB-14145: package.json updates to
resolve npm audit warnings
URL: https://github.com/apache/cordova-coho/pull/173
### Platforms affected
All
### What does this PR do?
- tests working again
- package.json updates to resolve npm audit warnings
### What testing has been done on this change?
- `npm test` passes in my local workares
- fixes originally part of #172 (1.0.1 update) pass on AppVeyor CI & Travis
CI
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14148) cordova platform ls shows nonsense www ^3.12.0 platform
Chris Brody created CB-14148:
Summary: cordova platform ls shows nonsense www ^3.12.0 platform
Key: CB-14148
URL: https://issues.apache.org/jira/browse/CB-14148
Project: Apache Cordova
Issue Type: Bug
Components: cordova-cli, cordova-common, cordova-lib
Reporter: Chris Brody
Assignee: Chris Brody
As I already reported in
[apache/cordova-discuss#86|https://github.com/apache/cordova-discuss/issues/86]
and saw someone else report in Slack:
{code:bash}
$ cordova --version
8.0.0
{code}
{code:bash}
$ cordova platform ls
Installed platforms:
Available platforms:
android ~7.0.0
browser ~5.0.1
ios ~4.5.4
osx ~4.0.1
windows ~5.0.0
www ^3.12.0
{code}
If I would do {{cordova platform add www}}:
{code:bash}
$ cordova platform add www
(node:10383) UnhandledPromiseRejectionWarning: CordovaError: Error: npm:
Command failed with exit code 1 Error output:
npm ERR! code ENOLOCAL
npm ERR! Could not install from "www" as it does not contain a package.json
file.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/brodybits/.npm/_logs/2018-01-04T04_21_59_700Z-debug.log
at
/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/cordova-fetch/index.js:104:29
at _rejected
(/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:864:24)
at
/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:890:30
at Promise.when
(/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:1142:31)
at Promise.promise.promiseDispatch
(/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:808:41)
at
/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:624:44
at runSingle
(/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:137:13)
at flush
(/Users/brodybits/.nvs/node/9.3.0/x64/lib/node_modules/cordova/node_modules/q/q.js:125:13)
at process._tickCallback (internal/process/next_tick.js:150:11)
(node:10383) UnhandledPromiseRejectionWarning: Unhandled promise rejection.
This error originated either by throwing inside of an async function without a
catch block, or by rejecting a promise which was not handled with .catch().
(rejection id: 1)
(node:10383) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517600#comment-16517600
]
Raphael commented on CB-13767:
--
A sample repo together with some use cases with really bad performance would
surely help us to better tackle this.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517598#comment-16517598
]
Darryl Pogue commented on CB-13767:
---
{quote}I think it would help to know what cordova-fetch does, why it’s
necessary, and why the performance is affected vs. how installation was done
before.
{quote}
Previously, cordova didn't use npm as a registry, it used its own registry and
had its own code to handle retrieving packages and resolving dependencies.
We decided years ago to move to using npm, since it didn't require running our
own registry, and so that we could take advantage of all the work being done by
the npm team on their tooling without additional maintenance burden from our
side.
In the short term (aka, the past few years) cordova-lib contained a mix of
ancient cordova-registry code and support for npm packages via an old bundled
version of npm 2. This caused numerous problems for people, because it meant
that cordova projects that were using npm for managing their project got
unpredictable behaviour due to some commands sometimes using npm2 instead of
the system-wide npm version. In particular, it made it totally impossible to
use npm shrinkwrap with a Cordova project, because npm2 is not shrinkwrappable
by newer version of npm.
cordova-fetch made the decision to offload all the dependency fetching,
installing, and caching to the system installed version of npm. We literally
shell out to npm and tell it to install dependencies for us.
The additional challenge for Cordova is that we need to do steps after the
dependency is installed, and we need to do extra verification around the
version of a dependency that is installed because you can't have the same
plugin installed with different versions at different levels of the
node_modules folder. The current released version of cordova-fetch prints out
the list of all installed modules before/after each operation and compares them
to find out what changed. This is very slow, and leads to all sorts of other
hard-to-diagnose errors.
These changes use the version information reported back from the npm command to
determine the version, which is much faster.
The other change here is to check ahead of time if a dependency is already
installed with the version that we need. Unfortunately, this isn't possible to
do with git dependencies.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517588#comment-16517588
]
jcesarmobile commented on CB-14144:
---
Yes, I just copy/pasted your code into a new Cordova project and created the
onBackButton function that just logs a message.
You can check it here
https://github.com/jcesarmobile/backButtonTest
> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5...
> all exhibit this behaviour.
> Quasar Framework is building my project a long with webpack but I've no
> reason to suspect Quasar as the cause, they only register a single
> eventListener for backbutton and I've manually gone in and edited the source
> code for this listener and it never fires leading me to believe the problem
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Major
>
> App exits immediately on back button press without ever firing the
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running
> Android at these versions. The app is completely killed with every tap of the
> back button (new launches of the app cold boot with splashscreen) making it
> impossible to properly navigate the app: closing modals, moving backwards in
> operations, etc...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517582#comment-16517582
]
Raphael edited comment on CB-13767 at 6/19/18 10:07 PM:
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because cordova-fetch is
called by cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
was (Author: raphinesse):
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because it's called by
cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517582#comment-16517582
]
Raphael commented on CB-13767:
--
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because it's called by
cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517571#comment-16517571
]
Andrew Crites commented on CB-13767:
I think it would help to know what cordova-fetch does, why it’s necessary, and
why the performance is affected vs. how installation was done before.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517569#comment-16517569
]
ASF GitHub Bot commented on CB-14145:
-
codecov-io edited a comment on issue #451: CB-14145: update to
cordova-common@2.2.4 to resolve npm audit issues in patch release
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1)
Report
> Merging
[#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=desc)
into
[7.1.x](https://codecov.io/gh/apache/cordova-android/commit/0bd3309323612bc9d4e8bac474bbb185ab93e1a0?src=pr=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=tree)
```diff
@@ Coverage Diff @@
##7.1.x #451 +/- ##
===
Coverage 43.95% 43.95%
===
Files 17 17
Lines1711 1711
Branches 318 318
===
Hits 752 752
Misses959 959
```
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=footer).
Last update
[0bd3309...6bcb604](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517564#comment-16517564
]
Raphael edited comment on CB-13767 at 6/19/18 9:46 PM:
---
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with a _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their free time.
was (Author: raphinesse):
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with a _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their time.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian
[jira] [Comment Edited] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517564#comment-16517564
]
Raphael edited comment on CB-13767 at 6/19/18 9:45 PM:
---
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with a _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their time.
was (Author: raphinesse):
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with the _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their time.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517564#comment-16517564
]
Raphael commented on CB-13767:
--
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with the _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their time.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14147) loading time improvement
[
https://issues.apache.org/jira/browse/CB-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated CB-14147:
---
Description:
I have raised issue against capacitor
([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
speed between capacitor and cordova.
Log is the capacitor log (i cannot share the cordova one because of security
reason), but it's quite similar to the cordova log. Spotted one major in-house,
and two chrome related bug, which cause major delays.
Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
was:
I have raised issue against capacitor
([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
speed between capacitor and cordova.
Log is the capacitor log, but it's quite similar to the cordova log. Spotted
one major in-house, and two chrome related bug, which cause major delays.
Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
> loading time improvement
>
>
> Key: CB-14147
> URL: https://issues.apache.org/jira/browse/CB-14147
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: cordova-android-7.0.0
>Reporter: Peter
>Priority: Major
> Attachments: mobile.log
>
>
> I have raised issue against capacitor
> ([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
> speed between capacitor and cordova.
> Log is the capacitor log (i cannot share the cordova one because of security
> reason), but it's quite similar to the cordova log. Spotted one major
> in-house, and two chrome related bug, which cause major delays.
> Both has been affected by the following issues:
> 1) Multidex issue or layout problem probably - appears on cordova also
> {{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}})
> .../system/bin/dex2oat
> 2) Just right after CrashFileManager, sometimes the following chromium error
> happens
> {{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
> [ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
> (656ms)}}
> 3) Why chrome would like to start "devtool"?
> E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server
> for devtools. Stop devtools.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14147) speed improvement
[
https://issues.apache.org/jira/browse/CB-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated CB-14147:
---
Description:
I have raised issue against capacitor
([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
speed between capacitor and cordova.
Log is the capacitor log, but it's quite similar to the cordova log. Spotted
one major in-house, and two chrome related bug, which cause major delays.
Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
was:
I have raised issue against capacitor, while i compared the speed between
capacitor and cordova. Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
Log can be seen under [https://github.com/ionic-team/capacitor/issues/587]
> speed improvement
> -
>
> Key: CB-14147
> URL: https://issues.apache.org/jira/browse/CB-14147
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: cordova-android-7.0.0
>Reporter: Peter
>Priority: Major
> Attachments: mobile.log
>
>
> I have raised issue against capacitor
> ([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
> speed between capacitor and cordova.
> Log is the capacitor log, but it's quite similar to the cordova log. Spotted
> one major in-house, and two chrome related bug, which cause major delays.
> Both has been affected by the following issues:
> 1) Multidex issue or layout problem probably - appears on cordova also
> {{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}})
> .../system/bin/dex2oat
> 2) Just right after CrashFileManager, sometimes the following chromium error
> happens
> {{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
> [ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
> (656ms)}}
> 3) Why chrome would like to start "devtool"?
> E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server
> for devtools. Stop devtools.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14147) loading time improvement
[
https://issues.apache.org/jira/browse/CB-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated CB-14147:
---
Summary: loading time improvement (was: speed improvement)
> loading time improvement
>
>
> Key: CB-14147
> URL: https://issues.apache.org/jira/browse/CB-14147
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: cordova-android-7.0.0
>Reporter: Peter
>Priority: Major
> Attachments: mobile.log
>
>
> I have raised issue against capacitor
> ([https://github.com/ionic-team/capacitor/issues/587]), while i compared the
> speed between capacitor and cordova.
> Log is the capacitor log, but it's quite similar to the cordova log. Spotted
> one major in-house, and two chrome related bug, which cause major delays.
> Both has been affected by the following issues:
> 1) Multidex issue or layout problem probably - appears on cordova also
> {{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}})
> .../system/bin/dex2oat
> 2) Just right after CrashFileManager, sometimes the following chromium error
> happens
> {{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
> [ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
> (656ms)}}
> 3) Why chrome would like to start "devtool"?
> E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server
> for devtools. Stop devtools.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14147) speed improvement
[
https://issues.apache.org/jira/browse/CB-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated CB-14147:
---
Attachment: mobile.log
> speed improvement
> -
>
> Key: CB-14147
> URL: https://issues.apache.org/jira/browse/CB-14147
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: cordova-android-7.0.0
>Reporter: Peter
>Priority: Major
> Attachments: mobile.log
>
>
> I have raised issue against capacitor, while i compared the speed between
> capacitor and cordova. Both has been affected by the following issues:
> 1) Multidex issue or layout problem probably - appears on cordova also
> {{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}})
> .../system/bin/dex2oat
> 2) Just right after CrashFileManager, sometimes the following chromium error
> happens
> {{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
> [ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
> (656ms)}}
> 3) Why chrome would like to start "devtool"?
> E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server
> for devtools. Stop devtools.
> Log can be seen under [https://github.com/ionic-team/capacitor/issues/587]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14147) speed improvement
[
https://issues.apache.org/jira/browse/CB-14147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter updated CB-14147:
---
Description:
I have raised issue against capacitor, while i compared the speed between
capacitor and cordova. Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
Log can be seen under [https://github.com/ionic-team/capacitor/issues/587]
was:
I have raised issue against capacitor, while i compared the speed between
capacitor and cordova. Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
Log can be seen under:
https://github.com/ionic-team/capacitor/issues/587
> speed improvement
> -
>
> Key: CB-14147
> URL: https://issues.apache.org/jira/browse/CB-14147
> Project: Apache Cordova
> Issue Type: Bug
>Affects Versions: cordova-android-7.0.0
>Reporter: Peter
>Priority: Major
>
> I have raised issue against capacitor, while i compared the speed between
> capacitor and cordova. Both has been affected by the following issues:
> 1) Multidex issue or layout problem probably - appears on cordova also
> {{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}})
> .../system/bin/dex2oat
> 2) Just right after CrashFileManager, sometimes the following chromium error
> happens
> {{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
> [ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
> (656ms)}}
> 3) Why chrome would like to start "devtool"?
> E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server
> for devtools. Stop devtools.
> Log can be seen under [https://github.com/ionic-team/capacitor/issues/587]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14147) speed improvement
Peter created CB-14147:
--
Summary: speed improvement
Key: CB-14147
URL: https://issues.apache.org/jira/browse/CB-14147
Project: Apache Cordova
Issue Type: Bug
Affects Versions: cordova-android-7.0.0
Reporter: Peter
I have raised issue against capacitor, while i compared the speed between
capacitor and cordova. Both has been affected by the following issues:
1) Multidex issue or layout problem probably - appears on cordova also
{{06-19 02:35:05.705 - 06-19 02:35:06.482}} ({{777ms}}) .../system/bin/dex2oat
2) Just right after CrashFileManager, sometimes the following chromium error
happens
{{06-19 02:37:36.780 20005-20224/com.raxim.myscoutee E/chromium:
[ERROR:budget_service.cc(160)] Unable to connect to the Mojo BudgetService.
(656ms)}}
3) Why chrome would like to start "devtool"?
E/chromium: [ERROR:devtools_http_handler.cc(292)] Cannot start http server for
devtools. Stop devtools.
Log can be seen under:
https://github.com/ionic-team/capacitor/issues/587
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517473#comment-16517473
]
Jon Rista commented on CB-13767:
We have one git dependency...it's the only way to get that particular plugin in
a form that works, as far as we know (there are many forks, most have bugs.)
Why is it that git dependencies take so long?
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517412#comment-16517412
]
altShiftDev edited comment on CB-14144 at 6/19/18 6:38 PM:
---
[~jcesarmobile] I loaded up an SDK21 and can confirm it happens here too. I
need to go to at least 24 to prevent backbutton issues.
Can you confirm you're using an eventListener to capture the backbutton and you
can prevent the app from closing?
Can you confirm your settings for me?
Here's my setup:
*cordova requirements*
Android Studio project detected
Requirements check results for android:
Java JDK: installed 1.8.0
Android SDK: installed true
Android target: installed
android-28,android-27,android-26,android-25,android-24,android-23,android-22,android-21,android-19
Gradle: installed /usr/local/Cellar/gradle/4.8/bin/gradle
*cordova --v*
8.0.0
*cordova platform*
Installed platforms:
android 7.0.0
Available platforms:
browser ~5.0.1
ios ~4.5.4
osx ~4.0.1
windows ~5.0.0
www ^3.12.0
My android studio version is 3.1.3 (build June 4th).
was (Author: altshiftdev):
[~jcesarmobile] I loaded up an SDK21 and can confirm it happens here too. I
need to go to at least 24 to prevent backbutton issues.
Can you confirm you're using an eventListener to capture the backbutton and you
can prevent the app from closing?
Can you confirm your settings for me?
Here's my setup:
*cordova requirements*
Android Studio project detected
Requirements check results for android:
Java JDK: installed 1.8.0
Android SDK: installed true
Android target: installed
android-28,android-27,android-26,android-25,android-24,android-23,android-22,android-21,android-19
Gradle: installed /usr/local/Cellar/gradle/4.8/bin/gradle
*cordova --v*
8.0.0
*cordova platform*
Installed platforms:
android 7.0.0
Available platforms:
browser ~5.0.1
ios ~4.5.4
osx ~4.0.1
windows ~5.0.0
www ^3.12.0
> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5...
> all exhibit this behaviour.
> Quasar Framework is building my project a long with webpack but I've no
> reason to suspect Quasar as the cause, they only register a single
> eventListener for backbutton and I've manually gone in and edited the source
> code for this listener and it never fires leading me to believe the problem
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Major
>
> App exits immediately on back button press without ever firing the
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running
> Android at these versions. The app is completely killed with every tap of the
> back button (new launches of the app cold boot with splashscreen) making it
> impossible to properly navigate the app: closing modals, moving backwards in
> operations, etc...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517412#comment-16517412
]
altShiftDev commented on CB-14144:
--
[~jcesarmobile] I loaded up an SDK21 and can confirm it happens here too. I
need to go to at least 24 to prevent backbutton issues.
Can you confirm you're using an eventListener to capture the backbutton and you
can prevent the app from closing?
Can you confirm your settings for me?
Here's my setup:
*cordova requirements*
Android Studio project detected
Requirements check results for android:
Java JDK: installed 1.8.0
Android SDK: installed true
Android target: installed
android-28,android-27,android-26,android-25,android-24,android-23,android-22,android-21,android-19
Gradle: installed /usr/local/Cellar/gradle/4.8/bin/gradle
*cordova --v*
8.0.0
*cordova platform*
Installed platforms:
android 7.0.0
Available platforms:
browser ~5.0.1
ios ~4.5.4
osx ~4.0.1
windows ~5.0.0
www ^3.12.0
> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5...
> all exhibit this behaviour.
> Quasar Framework is building my project a long with webpack but I've no
> reason to suspect Quasar as the cause, they only register a single
> eventListener for backbutton and I've manually gone in and edited the source
> code for this listener and it never fires leading me to believe the problem
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Major
>
> App exits immediately on back button press without ever firing the
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running
> Android at these versions. The app is completely killed with every tap of the
> back button (new launches of the app cold boot with splashscreen) making it
> impossible to properly navigate the app: closing modals, moving backwards in
> operations, etc...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517379#comment-16517379
]
ASF GitHub Bot commented on CB-14145:
-
codecov-io edited a comment on issue #451: CB-14145: update to
cordova-common@2.2.4 to resolve npm audit issues in patch release
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1)
Report
> Merging
[#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=desc)
into
[7.1.x](https://codecov.io/gh/apache/cordova-android/commit/f7d122bd8eae21747ebd4b2e0f569f2b9aa919ca?src=pr=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=tree)
```diff
@@ Coverage Diff @@
##7.1.x #451 +/- ##
===
Coverage 43.95% 43.95%
===
Files 17 17
Lines1711 1711
Branches 318 318
===
Hits 752 752
Misses959 959
```
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=footer).
Last update
[f7d122b...087b3af](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517327#comment-16517327
]
ASF GitHub Bot commented on CB-14145:
-
codecov-io edited a comment on issue #451: CB-14145: Minor release with
cordova-common@2.2.x update, etc. WIP
URL: https://github.com/apache/cordova-android/pull/451#issuecomment-397028390
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=h1)
Report
> Merging
[#451](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=desc)
into
[7.1.x](https://codecov.io/gh/apache/cordova-android/commit/f7d122bd8eae21747ebd4b2e0f569f2b9aa919ca?src=pr=desc)
will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=tree)
```diff
@@ Coverage Diff @@
##7.1.x #451 +/- ##
===
Coverage 43.95% 43.95%
===
Files 17 17
Lines1711 1711
Branches 318 318
===
Hits 752 752
Misses959 959
```
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=footer).
Last update
[f7d122b...b697b7a](https://codecov.io/gh/apache/cordova-android/pull/451?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14138) cordova-common patch release June 2018
[ https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517323#comment-16517323 ] ASF GitHub Bot commented on CB-14138: - brodybits closed pull request #832: CB-14138: add cordova-common@2.2.4 blog post URL: https://github.com/apache/cordova-docs/pull/832 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/www/_posts/2018-06-19-common-release-2.2.4.md b/www/_posts/2018-06-19-common-release-2.2.4.md new file mode 100644 index 0..ec4c35566 --- /dev/null +++ b/www/_posts/2018-06-19-common-release-2.2.4.md @@ -0,0 +1,22 @@ +--- +layout: post +author: +name: Chris Brody +url: https://twitter.com/brodybits +title: "Cordova-Common Release" +categories: news +tags: release tools +--- + +We are happy to announce that `cordova-common 2.2.4` has been released. This is one of the libraries used behind-the-scenes by nearly all of the Cordova tooling and provides utilities for dealing with things like config.xml parsing. + +## Release Highlights + +The purpose of this release is to resolve issues with dependencies on cordova-ios@4. Here are the major changes: + +* Revert change to use strip-bom package to strip BOM +* Revert change to update dependencies in package.json (needed to resolve issues with cordova-ios@4) but keep using plist@^3.0.1 to avoid `npm audit` issue + +## Deprecation Note + +As NodeJS 4.x support ended on April 30th, 2018, we are proceeding with our [previously announced](http://cordova.apache.org/news/2016/10/01/0.x-4.x-deprecation-timeline.html) deprecation timeline. This is probably the last release that will support NodeJS 4.x. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common patch release June 2018 > -- > > Key: CB-14138 > URL: https://issues.apache.org/jira/browse/CB-14138 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > A new cordova-common patch release is needed to deliver a single > cordova-common package version with updated plist@3 dep, working on > cordova-ios as well as cordova-android, cordova-windows, cordova-osx, > cordova-lib, cordova-cli, etc. > More detailed discussion will be in the GH pull request. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > (with some minor adjustments) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-10967) IndexedDB API not properly exposed?
[
https://issues.apache.org/jira/browse/CB-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517308#comment-16517308
]
jcesarmobile commented on CB-10967:
---
We still support iOS 9, and I confirm IndexedDB API is not available on
UIWebView and broken on WKWebView without a web server.
Won't reopen as we can't do anything about it, but just in case somebody thinks
is fixed for all iOS versions Cordova supports. Apple fixed it on iOS 10+.
> IndexedDB API not properly exposed?
> ---
>
> Key: CB-10967
> URL: https://issues.apache.org/jira/browse/CB-10967
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-wkwebview-engine
>Affects Versions: 4.0.0
> Environment: Cordova CLI 6.x.x, Cordova-iOS 4.x.x
>Reporter: Brent Allen
>Priority: Major
> Labels: triaged, wkwebview-known-issues
>
> So before cordova-ios 4.0.0 I was using
> https://github.com/Telerik-Verified-Plugins/WKWebView.git as a workaround to
> get the extra webkit apis/performance.
> Clearly not an ideal workaround since it requires a localhost origin. Making
> several CORS and iFrame operations a major headache.
> So I need to update to the latest frameworks. And I was successful in doing
> so with one catch.
> The webkit api for IndexDB is not exposed anymore. I am a little confused as
> to how this could be since it was expose when using the workaround. The only
> diff that I can find that seems to relate to webkit is this:
> From 'plugins/com.telerik.plugins.wkwebview/www/wkwebview.js'
> ```
> var origNativeFetchMessages = exec.nativeFetchMessages;
> exec.nativeFetchMessages = function() {
> var cmds = origNativeFetchMessages();
> cmds = JSON.parse(cmds);
> for(var i=0;i var cmd = cmds[i];
> if(cmd[1]==='WKWebView') continue;
>
> window.webkit.messageHandlers.cordova.postMessage(cmd);
> }
> return '';
> };
> ```
> Which was also still available in cordova-ios@3.9.2(I think)
> I can't help but wonder if this has something to do with exposing the open
> versions of the api(s). And if so was this supposed to be re-implemented
> using the latest patterns?
> I am using mWater/minimongo which relies on this api. I already opened an
> issue on that repo. But I am not optimistic that it will be addressed there
> since the api hasn't technically changed as far as I can tell. It is just
> being hidden by the webview and the cordova platform is no longer exposing it
> manually.
> Any advice would be greatly appreciated. I am hoping to avoid cloning the
> minimongo repo. Since I am not even sure the apples implementation will work
> as I have yet to find any documentation on it.
> I am also concerned that this may have implications for other webkit apis
> that I have yet to discover as broken in this context.
> Thanks in advance for any help.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14138) cordova-common patch release June 2018
[ https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517296#comment-16517296 ] ASF GitHub Bot commented on CB-14138: - brodybits commented on issue #27: CB-14138: cordova-common 2.2.4 update for CB-14145: npm audit issues URL: https://github.com/apache/cordova-common/pull/27#issuecomment-398467380 Marked this PR as part of CB-14145 (npm audit issues) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common patch release June 2018 > -- > > Key: CB-14138 > URL: https://issues.apache.org/jira/browse/CB-14138 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > A new cordova-common patch release is needed to deliver a single > cordova-common package version with updated plist@3 dep, working on > cordova-ios as well as cordova-android, cordova-windows, cordova-osx, > cordova-lib, cordova-cli, etc. > More detailed discussion will be in the GH pull request. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > (with some minor adjustments) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14138) cordova-common patch release June 2018
[ https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517291#comment-16517291 ] ASF GitHub Bot commented on CB-14138: - codecov-io edited a comment on issue #27: CB-14138: cordova-common 2.2.4 update URL: https://github.com/apache/cordova-common/pull/27#issuecomment-397536525 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=h1) Report > Merging [#27](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=desc) into [2.2.x](https://codecov.io/gh/apache/cordova-common/commit/6530ce7fd48777e91332754019f516ebc232da1d?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=tree) ```diff @@Coverage Diff @@ ##2.2.x #27 +/- ## == + Coverage 85.51% 85.52% +<.01% == Files 19 19 Lines1761 1762 +1 Branches 371 372 +1 == + Hits 1506 1507 +1 Misses255 255 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/superspawn.js](https://codecov.io/gh/apache/cordova-common/pull/27/diff?src=pr=tree#diff-c3JjL3N1cGVyc3Bhd24uanM=) | `69.41% <0%> (ø)` | :arrow_up: | | [src/util/xml-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/27/diff?src=pr=tree#diff-c3JjL3V0aWwveG1sLWhlbHBlcnMuanM=) | `94.97% <100%> (+0.02%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=footer). Last update [6530ce7...6f87e63](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common patch release June 2018 > -- > > Key: CB-14138 > URL: https://issues.apache.org/jira/browse/CB-14138 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > A new cordova-common patch release is needed to deliver a single > cordova-common package version with updated plist@3 dep, working on > cordova-ios as well as cordova-android, cordova-windows, cordova-osx, > cordova-lib, cordova-cli, etc. > More detailed discussion will be in the GH pull request. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > (with some minor adjustments) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14138) cordova-common patch release June 2018
[ https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517290#comment-16517290 ] ASF GitHub Bot commented on CB-14138: - codecov-io edited a comment on issue #27: CB-14138: cordova-common 2.2.4 update URL: https://github.com/apache/cordova-common/pull/27#issuecomment-397536525 # [Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=h1) Report > Merging [#27](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=desc) into [2.2.x](https://codecov.io/gh/apache/cordova-common/commit/6530ce7fd48777e91332754019f516ebc232da1d?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `75%`. [](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=tree) ```diff @@Coverage Diff @@ ##2.2.x #27 +/- ## == + Coverage 85.51% 85.52% +<.01% == Files 19 19 Lines1761 1762 +1 Branches 371 372 +1 == + Hits 1506 1507 +1 Misses255 255 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=tree) | Coverage Δ | | |---|---|---| | [src/superspawn.js](https://codecov.io/gh/apache/cordova-common/pull/27/diff?src=pr=tree#diff-c3JjL3N1cGVyc3Bhd24uanM=) | `69.41% <0%> (ø)` | :arrow_up: | | [src/util/xml-helpers.js](https://codecov.io/gh/apache/cordova-common/pull/27/diff?src=pr=tree#diff-c3JjL3V0aWwveG1sLWhlbHBlcnMuanM=) | `94.97% <100%> (+0.02%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=footer). Last update [6530ce7...6f87e63](https://codecov.io/gh/apache/cordova-common/pull/27?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common patch release June 2018 > -- > > Key: CB-14138 > URL: https://issues.apache.org/jira/browse/CB-14138 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > A new cordova-common patch release is needed to deliver a single > cordova-common package version with updated plist@3 dep, working on > cordova-ios as well as cordova-android, cordova-windows, cordova-osx, > cordova-lib, cordova-cli, etc. > More detailed discussion will be in the GH pull request. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > (with some minor adjustments) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14146) Cannot play media from https urls (SSL) on Android 4.4 KitKat
[
https://issues.apache.org/jira/browse/CB-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517276#comment-16517276
]
Shazron Abdullah commented on CB-14146:
---
Yes we should. Filed it here so it will be searchable
> Cannot play media from https urls (SSL) on Android 4.4 KitKat
> -
>
> Key: CB-14146
> URL: https://issues.apache.org/jira/browse/CB-14146
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Reporter: Shazron Abdullah
>Priority: Major
> Labels: known_issue
>
> From Ken Naito:
> {code:java}
> I have investigated the test failure for Android 4.4. For
> cordova-plugin-media, the cause of the failure may be the SSL handshake.
> The MediaPlayer in Android 4.4 can not connect to a modern SSL server.
> For example:
> https://cordova.apache.org/downloads/BlueZedEx.mp3
> https://cordova-develop.github.io/cordova-plugin-media/res/BlueZedEx.mp3
> On the other hand, the MediaPlayer can connect to a standard SSL server
> like:
> https://www.asial.co.jp/data_knaito/BlueZedEx.mp3
> I have checked the packet, and the available cipher suites of Android
> 4.4 are as follows:
> ECDHE-RSA-AES256-CBC-SHA
> ECDHE-ECDSA-AES256-CBC-SHA
> SRP-SHA-DSS-AES256-CBC-SHA
> SRP-SHA-RSA-AES256-CBC-SHA
> DHE-RSA-AES256-CBC-SHA
> DHE-DSS-AES256-CBC-SHA
> ECDH-RSA-AES256-CBC-SHA
> ECDH-ECDSA-AES256-CBC-SHA
> RSA-AES256-CBC-SHA
> ECDHE-RSA-3DES-EDE-CBC-SHA
> ECDHE-ECDSA-3DES-EDE-CBC-SHA
> SRP-SHA-DSS-3DES-EDE-CBC-SHA
> SRP-SHA-RSA-3DES-EDE-CBC-SHA
> DHE-RSA-3DES-EDE-CBC-SHA
> DHE-DSS-3DES-EDE-CBC-SHA
> ECDH-RSA-3DES-EDE-CBC-SHA
> ECDH-ECDSA-3DES-EDE-CBC-SHA
> RSA-3DES-EDE-CBC-SHA
> ECDHE-RSA-AES128-CBC-SHA
> ECDHE-ECDSA-AES128-CBC-SHA
> SRP-SHA-DSS-AES128-CBC-SHA
> SRP-SHA-RSA-AES128-CBC-SHA
> DHE-RSA-AES128-CBC-SHA
> DHE-DSS-AES128-CBC-SHA
> ECDH-RSA-AES128-CBC-SHA
> ECDH-ECDSA-AES128-CBC-SHA
> RSA-AES128-CBC-SHA
> ECDHE-RSA-RC4-SHA
> ECDHE-ECDSA-RC4-SHA
> ECDH-RSA-RC4-SHA
> ECDH-ECDSA-RC4-SHA
> RSA-RC4-SHA
> RSA-RC4-MD5
> Modern SSL servers may refuse these cipher suites.
> In order to resolve this issue, the mp3 file should be downloaded in
> another way and then be played by MediaPlayer.
> One way of downloading is using the okhttp library with a custom ssl
> socket factory.
> However, the okhttp library is not included in the latest
> cordova-android, and cordova-plugin-okhttp
> (https://github.com/MobileChromeApps/cordova-plugin-okhttp) is too old
> and not maintained.
> I think that a new okhttp plugin should be created, and
> cordova-plugin-media should depend on the new okhttp plugin in order to
> connect to a modern SSL server.
> Or, a more simple option is to specify that the MediaPlayer can not
> connect modern SSL servers for Android 4.4, and remove the test of
> playing streams for Android 4.4.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14146) Cannot play media from https urls (SSL) on Android 4.4 KitKat
[
https://issues.apache.org/jira/browse/CB-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517275#comment-16517275
]
jcesarmobile commented on CB-14146:
---
I think we should probably document it as a quirk on the plugin's readme
> Cannot play media from https urls (SSL) on Android 4.4 KitKat
> -
>
> Key: CB-14146
> URL: https://issues.apache.org/jira/browse/CB-14146
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Reporter: Shazron Abdullah
>Priority: Major
> Labels: known_issue
>
> From Ken Naito:
> {code:java}
> I have investigated the test failure for Android 4.4. For
> cordova-plugin-media, the cause of the failure may be the SSL handshake.
> The MediaPlayer in Android 4.4 can not connect to a modern SSL server.
> For example:
> https://cordova.apache.org/downloads/BlueZedEx.mp3
> https://cordova-develop.github.io/cordova-plugin-media/res/BlueZedEx.mp3
> On the other hand, the MediaPlayer can connect to a standard SSL server
> like:
> https://www.asial.co.jp/data_knaito/BlueZedEx.mp3
> I have checked the packet, and the available cipher suites of Android
> 4.4 are as follows:
> ECDHE-RSA-AES256-CBC-SHA
> ECDHE-ECDSA-AES256-CBC-SHA
> SRP-SHA-DSS-AES256-CBC-SHA
> SRP-SHA-RSA-AES256-CBC-SHA
> DHE-RSA-AES256-CBC-SHA
> DHE-DSS-AES256-CBC-SHA
> ECDH-RSA-AES256-CBC-SHA
> ECDH-ECDSA-AES256-CBC-SHA
> RSA-AES256-CBC-SHA
> ECDHE-RSA-3DES-EDE-CBC-SHA
> ECDHE-ECDSA-3DES-EDE-CBC-SHA
> SRP-SHA-DSS-3DES-EDE-CBC-SHA
> SRP-SHA-RSA-3DES-EDE-CBC-SHA
> DHE-RSA-3DES-EDE-CBC-SHA
> DHE-DSS-3DES-EDE-CBC-SHA
> ECDH-RSA-3DES-EDE-CBC-SHA
> ECDH-ECDSA-3DES-EDE-CBC-SHA
> RSA-3DES-EDE-CBC-SHA
> ECDHE-RSA-AES128-CBC-SHA
> ECDHE-ECDSA-AES128-CBC-SHA
> SRP-SHA-DSS-AES128-CBC-SHA
> SRP-SHA-RSA-AES128-CBC-SHA
> DHE-RSA-AES128-CBC-SHA
> DHE-DSS-AES128-CBC-SHA
> ECDH-RSA-AES128-CBC-SHA
> ECDH-ECDSA-AES128-CBC-SHA
> RSA-AES128-CBC-SHA
> ECDHE-RSA-RC4-SHA
> ECDHE-ECDSA-RC4-SHA
> ECDH-RSA-RC4-SHA
> ECDH-ECDSA-RC4-SHA
> RSA-RC4-SHA
> RSA-RC4-MD5
> Modern SSL servers may refuse these cipher suites.
> In order to resolve this issue, the mp3 file should be downloaded in
> another way and then be played by MediaPlayer.
> One way of downloading is using the okhttp library with a custom ssl
> socket factory.
> However, the okhttp library is not included in the latest
> cordova-android, and cordova-plugin-okhttp
> (https://github.com/MobileChromeApps/cordova-plugin-okhttp) is too old
> and not maintained.
> I think that a new okhttp plugin should be created, and
> cordova-plugin-media should depend on the new okhttp plugin in order to
> connect to a modern SSL server.
> Or, a more simple option is to specify that the MediaPlayer can not
> connect modern SSL servers for Android 4.4, and remove the test of
> playing streams for Android 4.4.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14146) Cannot play media from https urls (SSL) on Android 4.4 KitKat
Shazron Abdullah created CB-14146:
-
Summary: Cannot play media from https urls (SSL) on Android 4.4
KitKat
Key: CB-14146
URL: https://issues.apache.org/jira/browse/CB-14146
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-media
Reporter: Shazron Abdullah
>From Ken Naito:
{code:java}
I have investigated the test failure for Android 4.4. For
cordova-plugin-media, the cause of the failure may be the SSL handshake.
The MediaPlayer in Android 4.4 can not connect to a modern SSL server.
For example:
https://cordova.apache.org/downloads/BlueZedEx.mp3
https://cordova-develop.github.io/cordova-plugin-media/res/BlueZedEx.mp3
On the other hand, the MediaPlayer can connect to a standard SSL server
like:
https://www.asial.co.jp/data_knaito/BlueZedEx.mp3
I have checked the packet, and the available cipher suites of Android
4.4 are as follows:
ECDHE-RSA-AES256-CBC-SHA
ECDHE-ECDSA-AES256-CBC-SHA
SRP-SHA-DSS-AES256-CBC-SHA
SRP-SHA-RSA-AES256-CBC-SHA
DHE-RSA-AES256-CBC-SHA
DHE-DSS-AES256-CBC-SHA
ECDH-RSA-AES256-CBC-SHA
ECDH-ECDSA-AES256-CBC-SHA
RSA-AES256-CBC-SHA
ECDHE-RSA-3DES-EDE-CBC-SHA
ECDHE-ECDSA-3DES-EDE-CBC-SHA
SRP-SHA-DSS-3DES-EDE-CBC-SHA
SRP-SHA-RSA-3DES-EDE-CBC-SHA
DHE-RSA-3DES-EDE-CBC-SHA
DHE-DSS-3DES-EDE-CBC-SHA
ECDH-RSA-3DES-EDE-CBC-SHA
ECDH-ECDSA-3DES-EDE-CBC-SHA
RSA-3DES-EDE-CBC-SHA
ECDHE-RSA-AES128-CBC-SHA
ECDHE-ECDSA-AES128-CBC-SHA
SRP-SHA-DSS-AES128-CBC-SHA
SRP-SHA-RSA-AES128-CBC-SHA
DHE-RSA-AES128-CBC-SHA
DHE-DSS-AES128-CBC-SHA
ECDH-RSA-AES128-CBC-SHA
ECDH-ECDSA-AES128-CBC-SHA
RSA-AES128-CBC-SHA
ECDHE-RSA-RC4-SHA
ECDHE-ECDSA-RC4-SHA
ECDH-RSA-RC4-SHA
ECDH-ECDSA-RC4-SHA
RSA-RC4-SHA
RSA-RC4-MD5
Modern SSL servers may refuse these cipher suites.
In order to resolve this issue, the mp3 file should be downloaded in
another way and then be played by MediaPlayer.
One way of downloading is using the okhttp library with a custom ssl
socket factory.
However, the okhttp library is not included in the latest
cordova-android, and cordova-plugin-okhttp
(https://github.com/MobileChromeApps/cordova-plugin-okhttp) is too old
and not maintained.
I think that a new okhttp plugin should be created, and
cordova-plugin-media should depend on the new okhttp plugin in order to
connect to a modern SSL server.
Or, a more simple option is to specify that the MediaPlayer can not
connect modern SSL servers for Android 4.4, and remove the test of
playing streams for Android 4.4.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-14146) Cannot play media from https urls (SSL) on Android 4.4 KitKat
[
https://issues.apache.org/jira/browse/CB-14146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shazron Abdullah resolved CB-14146.
---
Resolution: Won't Fix
This is a known issue with Android 4.4 KitKat and is out of our control
> Cannot play media from https urls (SSL) on Android 4.4 KitKat
> -
>
> Key: CB-14146
> URL: https://issues.apache.org/jira/browse/CB-14146
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
>Reporter: Shazron Abdullah
>Priority: Major
> Labels: known_issue
>
> From Ken Naito:
> {code:java}
> I have investigated the test failure for Android 4.4. For
> cordova-plugin-media, the cause of the failure may be the SSL handshake.
> The MediaPlayer in Android 4.4 can not connect to a modern SSL server.
> For example:
> https://cordova.apache.org/downloads/BlueZedEx.mp3
> https://cordova-develop.github.io/cordova-plugin-media/res/BlueZedEx.mp3
> On the other hand, the MediaPlayer can connect to a standard SSL server
> like:
> https://www.asial.co.jp/data_knaito/BlueZedEx.mp3
> I have checked the packet, and the available cipher suites of Android
> 4.4 are as follows:
> ECDHE-RSA-AES256-CBC-SHA
> ECDHE-ECDSA-AES256-CBC-SHA
> SRP-SHA-DSS-AES256-CBC-SHA
> SRP-SHA-RSA-AES256-CBC-SHA
> DHE-RSA-AES256-CBC-SHA
> DHE-DSS-AES256-CBC-SHA
> ECDH-RSA-AES256-CBC-SHA
> ECDH-ECDSA-AES256-CBC-SHA
> RSA-AES256-CBC-SHA
> ECDHE-RSA-3DES-EDE-CBC-SHA
> ECDHE-ECDSA-3DES-EDE-CBC-SHA
> SRP-SHA-DSS-3DES-EDE-CBC-SHA
> SRP-SHA-RSA-3DES-EDE-CBC-SHA
> DHE-RSA-3DES-EDE-CBC-SHA
> DHE-DSS-3DES-EDE-CBC-SHA
> ECDH-RSA-3DES-EDE-CBC-SHA
> ECDH-ECDSA-3DES-EDE-CBC-SHA
> RSA-3DES-EDE-CBC-SHA
> ECDHE-RSA-AES128-CBC-SHA
> ECDHE-ECDSA-AES128-CBC-SHA
> SRP-SHA-DSS-AES128-CBC-SHA
> SRP-SHA-RSA-AES128-CBC-SHA
> DHE-RSA-AES128-CBC-SHA
> DHE-DSS-AES128-CBC-SHA
> ECDH-RSA-AES128-CBC-SHA
> ECDH-ECDSA-AES128-CBC-SHA
> RSA-AES128-CBC-SHA
> ECDHE-RSA-RC4-SHA
> ECDHE-ECDSA-RC4-SHA
> ECDH-RSA-RC4-SHA
> ECDH-ECDSA-RC4-SHA
> RSA-RC4-SHA
> RSA-RC4-MD5
> Modern SSL servers may refuse these cipher suites.
> In order to resolve this issue, the mp3 file should be downloaded in
> another way and then be played by MediaPlayer.
> One way of downloading is using the okhttp library with a custom ssl
> socket factory.
> However, the okhttp library is not included in the latest
> cordova-android, and cordova-plugin-okhttp
> (https://github.com/MobileChromeApps/cordova-plugin-okhttp) is too old
> and not maintained.
> I think that a new okhttp plugin should be created, and
> cordova-plugin-media should depend on the new okhttp plugin in order to
> connect to a modern SSL server.
> Or, a more simple option is to specify that the MediaPlayer can not
> connect modern SSL servers for Android 4.4, and remove the test of
> playing streams for Android 4.4.{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14138) cordova-common patch release June 2018
[ https://issues.apache.org/jira/browse/CB-14138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517244#comment-16517244 ] ASF GitHub Bot commented on CB-14138: - brodybits commented on issue #832: CB-14138: add cordova-common@2.2.4 blog post URL: https://github.com/apache/cordova-docs/pull/832#issuecomment-398447331 I just pushed an update with some rewording (with updated _post filename) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-common patch release June 2018 > -- > > Key: CB-14138 > URL: https://issues.apache.org/jira/browse/CB-14138 > Project: Apache Cordova > Issue Type: Task > Components: cordova-common >Reporter: Chris Brody >Assignee: Chris Brody >Priority: Major > > A new cordova-common patch release is needed to deliver a single > cordova-common package version with updated plist@3 dep, working on > cordova-ios as well as cordova-android, cordova-windows, cordova-osx, > cordova-lib, cordova-cli, etc. > More detailed discussion will be in the GH pull request. > Following steps at > https://github.com/apache/cordova-coho/blob/master/docs/tools-release-process.md > (with some minor adjustments) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517213#comment-16517213 ] ASF GitHub Bot commented on CB-14091: - shazron commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398434930 I'm not sure we have the copyright, any files we put on Apache need to have the right license (Apache 2.0 or one of the approved licenses). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517165#comment-16517165
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398418225
Having given this a little more thought, my stance is that **failing our CI
tests on a failed audit would be a bad idea**. The reasons being:
- We are basically polling for changes, and only so if someone files a PR or
commits to master. Thus:
- We are not notified ASAP
- PRs might seem to fail the tests when they did not actually cause the
problem
- Our tests might be stuck failing for some time without us being able to
fix it. Because:
- Either there's not a fix to the vulnerability yet
- Or the vulnerability is in a transitive dependency, while our direct
dependency (or someone in the chain) hasn't yet updated (Right now, `node-sass`
users might be able to relate)
So I'd say: leave it out of our normal CI and use a dedicated service
instead. Snyk seems to be made for this, the GitHub Security Alerts might work
fine too. In both cases we have to see how compatible the workflow is with how
INFRA works.
PS: Even though not security focused, it might still be nice to have
GreenKeeper.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517164#comment-16517164
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398418225
Having given this a little more thought, my stance is that **failing our CI
tests on a failed audit would be a bad idea**. The reasons being:
- We are basically polling for changes, and only so if someone files a PR or
commits to master. Thus:
- We are not notified ASAP
- PRs might seem to fail the tests when they did not actually cause the
problem
- Our tests might be stuck failing for some time without us being able to
fix it. Because:
- Either there's not a fix to the vulnerability yet
- Or the vulnerability is in a transitive dependency, while our direct
dependency (or someone in the chain) hasn't yet updated (Right now, `node-sass`
users might be able to relate)
So my stance is: leave it out of our normal CI and use a dedicated service
instead. Snyk seems to be made for this, the GitHub Security Alerts might work
fine too. In both cases we have to see how compatible the workflow is with how
INFRA works.
PS: Even though not security focused, it might still be nice to have
GreenKeeper.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517163#comment-16517163
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398418225
Having given this a little more thought, my stance is that **failing our CI
tests on a failed audit would be a bad idea**. The reasons being:
- We are basically polling for changes, and only so if someone files a PR or
commits to master. Thus:
- We are not notified ASAP
- PRs might seem to fail the tests when they did not actually cause the
problem
- Our tests might be stuck failing for some time without us being able to
fix it. Because:
- Either there's not a fix to the vulnerability yet
- Or the vulnerability is in a transitive dependency, while our direct
dependency (or someone in the chain) hasn't yet updated (Right now, `node-sass`
users might be able to relate)
So my stance is: leave it out of our normal CI and use a dedicated service
instead. Snyk seems to be made for this, the GitHub Security Alerts might work
fine too. In both cases we have to see how compatible the workflow is with how
INFRA works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517159#comment-16517159
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse commented on issue #30: [CB-14145] npm audit in CI TEST WIP - DO NOT
MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398418225
Having given this a little more thought, my stance is that failing our
CI-Build on a failed audit, would be a bad idea. The reasons being:
- We are basically polling for changes, and only so if someone files a PR or
commits to master. Thus:
- We are not notified ASAP
- PRs might seem to fail the tests when they did not actually cause the
problem
- Our tests might be stuck failing for some time without us being able to
fix it. Because:
- Either there's not a fix to the vulnerability yet
- Or the vulnerability is in a transitive dependency, while our direct
dependency (or someone in the chain) hasn't yet updated (Right now, `node-sass`
users might be able to relate)
So my stance is: leave it out of our normal CI and use a dedicated service
instead. Snyk seems to be made for this, the GitHub Security Alerts might work
fine too. In both cases we have to see how compatible the workflow is with how
INFRA works.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517111#comment-16517111
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398406332
- https://blog.github.com/2017-11-16-introducing-security-alerts-on-github/
- https://github.com/marketplace/category/security
- Snyk looks good
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517113#comment-16517113
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398406332
- https://blog.github.com/2017-11-16-introducing-security-alerts-on-github/
- https://github.com/marketplace/category/security
- [Snyk](https://github.com/marketplace/snyk) looks good
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517103#comment-16517103
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse edited a comment on issue #30: [CB-14145] npm audit in CI TEST WIP -
DO NOT MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398406332
- https://blog.github.com/2017-11-16-introducing-security-alerts-on-github/
- https://github.com/marketplace/category/security
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517099#comment-16517099
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse commented on issue #30: [CB-14145] npm audit in CI TEST WIP - DO NOT
MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398406332
https://blog.github.com/2017-11-16-introducing-security-alerts-on-github/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517044#comment-16517044
]
ASF GitHub Bot commented on CB-14145:
-
brodybits commented on issue #30: [CB-14145] npm audit in CI TEST WIP - DO NOT
MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398391044
> Greenkeeper, David DM or maybe auditing in our nightly builds.
+1 (+100)
I can take a look sometime next month, wouldn't mind if someone can look
into these options more quickly.
While I would agree with the concern that CI build may be broken by a PR
that is not responsible for it, I would personally favor the idea that we
resolve any `npm audit` issues before reviewing and integrating any other
changes in the future.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14124) Access-Control-Allow-Headers
[
https://issues.apache.org/jira/browse/CB-14124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517042#comment-16517042
]
jcesarmobile commented on CB-14124:
---
Android uses file:// protocol so it's not affected by CORS, that doesn't mean
your server is ok, just that Android ignores that problem. But the problem is
definitely in your server.
Also try changing header('Access-Control-Allow-Methods: *'); by replacing the *
by actual methods like GET/POST
> Access-Control-Allow-Headers
>
>
> Key: CB-14124
> URL: https://issues.apache.org/jira/browse/CB-14124
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios, cordova-plugin-wkwebview-engine
>Affects Versions: cordova-ios@4.5.4, 8.0.0
>Reporter: Alejandro
>Assignee: Suraj Pindoria
>Priority: Major
> Labels: CORS, WKWebView, ajax, cordova, cordova-8.0.0,
> cordova-ios, ios
>
> Hello,
> I have one app with:
> Cordova version: 8.0.0
> cordova-ios version: 4.5.4
> I had to install the plugin
> "[cordova-plugin-wkwebview-engine|https://github.com/apache/cordova-plugin-wkwebview-engine];
> to solve a problem with the interface.
> In android everything works correctly.
> But in IOS when I make AJAX requests to my API I have the error:
>
> XMLHttpRequest cannot load ... Request header field Authorization is not
> allowed by Access-Control-Allow-Headers
>
> In the API I have the following in place to allow CORS connections:
> {code:java}
> header('Access-Control-Allow-Headers: *');
> header('Access-Control-Allow-Origin: *');
> header('Access-Control-Allow-Methods: *');
> {code}
> In the config.xml I have this:
> {code:java}
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
> {code}
> and my AJAX requests are:
> {code:java}
> $.ajax({
> url: url,
> data: formData,
> type: 'post',
> dataType: "json",
> contentType: false,
> processData: false,
> success: function (respuesta) {
> }
> });
> {code}
> And I have this meta:
> {code:java}
>
> {code}
> The strange thing is that without the
> plugin([cordova-plugin-wkwebview-engine|https://github.com/apache/cordova-plugin-wkwebview-engine])
> it works fine, but I need the plugin obligatorily.
> I am desperate and I do not know what to do anymore.
> any solution?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14114) InAppBrowser - Problem in ios 11.3.1
[ https://issues.apache.org/jira/browse/CB-14114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517027#comment-16517027 ] Bertus van de Poll commented on CB-14114: - Thanks. I couldn't get the wkwebview browser to work at all. For now we are using the hack and it works fine. > InAppBrowser - Problem in ios 11.3.1 > > > Key: CB-14114 > URL: https://issues.apache.org/jira/browse/CB-14114 > Project: Apache Cordova > Issue Type: Bug >Affects Versions: 3.0.0 > Environment: iphone 5s, ios 11.3.1 > iphone 7+ ios 11.3.1 > >Reporter: Nishanth >Priority: Major > > Strange behaviour after the upgrade from 11.2 to 11.3 The user is not able to > login to the identity provider using InAppBrowser. The server rejects the > request and throws a 'http *service 1.1. unavailable'* after the user submits > username and password > > I was hoping that it was an ios bug but I am able to login with wkwebview > browser > [https://github.com/dpa99c/cordova-plugin-inappbrowser-wkwebview] > The usage of WKWebview browser was to just confirm the issue. > Any help on this would be much appreciated. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516980#comment-16516980
]
ASF GitHub Bot commented on CB-13685:
-
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1)
Report
> Merging
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/393dad6349d8df55d8fca7d3e5014f36dfa4610c?src=pr=desc)
will **decrease** coverage by `0.42%`.
> The diff coverage is `66.92%`.
[](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree)
```diff
@@Coverage Diff @@
## master #448 +/- ##
==
- Coverage 44.27% 43.84% -0.43%
==
Files 17 18 +1
Lines1694 2023 +329
Branches 311 383 +72
==
+ Hits 750 887 +137
- Misses944 1136 +192
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
| `35.44% <40%> (+0.3%)` | :arrow_up: |
|
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
| `41.66% <68%> (ø)` | |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=footer).
Last update
[393dad6...d4cd4c6](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516974#comment-16516974
]
ASF GitHub Bot commented on CB-13685:
-
erisu commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398370194
@raphinesse Thank you for pointing out improvements to my test spec. I have
updated the test and reduced the line count. I also removed the `done()` calls
as you pointed out because they were not needed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jcesarmobile updated CB-14144:
--
Priority: Major (was: Blocker)
> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5...
> all exhibit this behaviour.
> Quasar Framework is building my project a long with webpack but I've no
> reason to suspect Quasar as the cause, they only register a single
> eventListener for backbutton and I've manually gone in and edited the source
> code for this listener and it never fires leading me to believe the problem
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Major
>
> App exits immediately on back button press without ever firing the
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running
> Android at these versions. The app is completely killed with every tap of the
> back button (new launches of the app cold boot with splashscreen) making it
> impossible to properly navigate the app: closing modals, moving backwards in
> operations, etc...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14144) BackButton Event Listeners do not fire on Android API 23 or below
[
https://issues.apache.org/jira/browse/CB-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516942#comment-16516942
]
jcesarmobile commented on CB-14144:
---
Working fine on my Android 5.0.2 device (SDK 21)
> BackButton Event Listeners do not fire on Android API 23 or below
> -
>
> Key: CB-14144
> URL: https://issues.apache.org/jira/browse/CB-14144
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: Using Android Studio emulators Galaxy, Pixel, Nexus 5...
> all exhibit this behaviour.
> Quasar Framework is building my project a long with webpack but I've no
> reason to suspect Quasar as the cause, they only register a single
> eventListener for backbutton and I've manually gone in and edited the source
> code for this listener and it never fires leading me to believe the problem
> is with Cordova.
>Reporter: altShiftDev
>Assignee: Joe Bowser
>Priority: Blocker
>
> App exits immediately on back button press without ever firing the
> eventListener designed to capture and reroute it.
> There is nothing wrong with my eventListener code, it's been tested on Api 25
> and higher and is very stable:
> `document.addEventListener('backbutton', this.onBackButton, false)`
> I have not yet tested to confirm if API 24 has this bug or not.
> This affects many of my users, including myself as I've got a phone running
> Android at these versions. The app is completely killed with every tap of the
> back button (new launches of the app cold boot with splashscreen) making it
> impossible to properly navigate the app: closing modals, moving backwards in
> operations, etc...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516939#comment-16516939
]
ASF GitHub Bot commented on CB-13685:
-
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1)
Report
> Merging
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/393dad6349d8df55d8fca7d3e5014f36dfa4610c?src=pr=desc)
will **decrease** coverage by `0.42%`.
> The diff coverage is `66.92%`.
[](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree)
```diff
@@Coverage Diff @@
## master #448 +/- ##
==
- Coverage 44.27% 43.84% -0.43%
==
Files 17 18 +1
Lines1694 2023 +329
Branches 311 383 +72
==
+ Hits 750 887 +137
- Misses944 1136 +192
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
| `35.44% <40%> (+0.3%)` | :arrow_up: |
|
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
| `41.66% <68%> (ø)` | |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=footer).
Last update
[393dad6...a6fe2df](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516937#comment-16516937
]
ASF GitHub Bot commented on CB-13685:
-
codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon
Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1)
Report
> Merging
[#448](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=desc)
into
[master](https://codecov.io/gh/apache/cordova-android/commit/393dad6349d8df55d8fca7d3e5014f36dfa4610c?src=pr=desc)
will **decrease** coverage by `0.42%`.
> The diff coverage is `66.92%`.
[](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree)
```diff
@@Coverage Diff @@
## master #448 +/- ##
==
- Coverage 44.27% 43.84% -0.43%
==
Files 17 18 +1
Lines1694 2023 +329
Branches 311 383 +72
==
+ Hits 750 887 +137
- Misses944 1136 +192
```
| [Impacted
Files](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=tree) |
Coverage Δ | |
|---|---|---|
|
[bin/templates/cordova/lib/AndroidManifest.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BbmRyb2lkTWFuaWZlc3QuanM=)
| `35.44% <40%> (+0.3%)` | :arrow_up: |
|
[bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/448/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz)
| `41.66% <68%> (ø)` | |
--
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=footer).
Last update
[393dad6...a6fe2df](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[ https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516889#comment-16516889 ] Raphael commented on CB-13695: -- @Heiko What solves the problem? Global config? > cordova-fetch: ignores npm registry > --- > > Key: CB-13695 > URL: https://issues.apache.org/jira/browse/CB-13695 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@8.0.0 >Reporter: Heiko >Priority: Critical > > My situation: > a build server that has no access to the internet. > By to a local npm mirror. > If i do at my build job: > npm config set registry "http://my.local.server/repository/mirror.npm; > npm install > npm install cordova ionic npm --no-save > cordova platform add ios --no-update-notifier > i get: > Using cordova-fetch for cordova-ios@4.5.3 > (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection > (rejection id: 1): Error: Cannot find module './index' > (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > My work around for cordova 7 was to use: --nofetch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516885#comment-16516885
]
Raphael commented on CB-13767:
--
I guess it's still slower than Cordova 6. But I would really appreciate if you
could give it a try and report your build times for different versions here.
As a note: Git dependencies will absolutely kill performance
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[ https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516870#comment-16516870 ] Heiko commented on CB-13695: [~raphinesse] yes this solve the problem > cordova-fetch: ignores npm registry > --- > > Key: CB-13695 > URL: https://issues.apache.org/jira/browse/CB-13695 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@8.0.0 >Reporter: Heiko >Priority: Critical > > My situation: > a build server that has no access to the internet. > By to a local npm mirror. > If i do at my build job: > npm config set registry "http://my.local.server/repository/mirror.npm; > npm install > npm install cordova ionic npm --no-save > cordova platform add ios --no-update-notifier > i get: > Using cordova-fetch for cordova-ios@4.5.3 > (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection > (rejection id: 1): Error: Cannot find module './index' > (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > My work around for cordova 7 was to use: --nofetch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14091) Fails Streaming test for iOS and Browser
[ https://issues.apache.org/jira/browse/CB-14091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516859#comment-16516859 ] ASF GitHub Bot commented on CB-14091: - knight commented on issue #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166#issuecomment-398335725 I have removed tests of streaming for Android 4.4. Remark that I have used one test mp3 file `WEB_MP3_STREAM = 'https://cordova-develop.github.io/cordova-plugin-media/res/mozart_serenade4_01.mp3'`. This is because that the old mp3 file `WEB_MP3_STREAM = 'http://c22033-l.i.core.cdn.streamfarm.net/22033mdr/live/3087mdr_figaro/ch_classic_128.mp3'` is not available now. If someone can copy the above mp3 file to the official site https://cordova.apache.org, please copy it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fails Streaming test for iOS and Browser > > > Key: CB-14091 > URL: https://issues.apache.org/jira/browse/CB-14091 > Project: Apache Cordova > Issue Type: Test > Components: cordova-plugin-media >Affects Versions: 8.0.0 >Reporter: Ken Naito >Priority: Trivial > Fix For: 8.0.0 > > > tests/tests.js fails. > spec.19 and spec.20 for Browser > spec.25 for iOS > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516849#comment-16516849
]
Jon Rista commented on CB-13767:
What kind of performance increase are we really talking about here? With
installs that take 12-15 minutes, even if you doubled or tripled performance,
it would still be too slow. We ended up moving back to the previous version of
Cordova because of the severity of this issue...and it seems to install plugins
in just a few seconds. It's several hundred times faster...
If this patch can get close to that kind of performance, then we could give it
a try. We do so many builds per day, though, if it still takes minutes to
install plugins, we'll have to hold off.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14145) Resolve npm audit issues
[
https://issues.apache.org/jira/browse/CB-14145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516840#comment-16516840
]
ASF GitHub Bot commented on CB-14145:
-
raphinesse commented on issue #30: [CB-14145] npm audit in CI TEST WIP - DO NOT
MERGE
URL: https://github.com/apache/cordova-common/pull/30#issuecomment-398330253
Great idea :+1:
I see one problem though. Builds might be broken by a PR that is not
responsible for it. Just because a new security issue has been discovered in
the meantime. So maybe we actually want something that pushes us for any
issues. Greenkeeper, David DM or maybe auditing in our nightly builds.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Resolve npm audit issues
>
>
> Key: CB-14145
> URL: https://issues.apache.org/jira/browse/CB-14145
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android, cordova-app-hello-world,
> cordova-browser, cordova-cli, cordova-coho, cordova-common, cordova-fetch,
> cordova-ios, cordova-js, cordova-lib, cordova-osx, cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Major
>
> From private discussions I discovered that running {{npm audit}} on a number
> of components would report dependencies with security issues. While we could
> not see any {{npm audit}} issues that may affect applications built using
> Cordova I think it is extremely important to resolve these issues as soon as
> possible. Most affect devDependencies used for testing of Cordova itself; a
> minority seem to affect Cordova scripts that may be run by Cordova
> application developers. Better safe than sorry!
> I would like to resolve this issue as follows:
> * patch release of common library components such as {{cordova-common}},
> {{cordova-lib}}, etc. (fixed in minor release branch)
> * patch or minor release of other affected components such as CLI, Cordova
> platform implementations, major plugins, etc. (expected to be fixed in minor
> release branch; do not want to pollute the master branch with extra reverts,
> updated node_modules committed, etc.)
> * {{npm audit}} issues resolved in master branch for next major release,
> which should NOT be shipped with any {{npm audit}} issues lurking
> * {{npm audit}} step added to CI for both patch release and next major release
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[ https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516816#comment-16516816 ] Raphael commented on CB-13695: -- Might be a possible fix, but we first have to confirm that this is actually what's going wrong. Does it work with global settings? > cordova-fetch: ignores npm registry > --- > > Key: CB-13695 > URL: https://issues.apache.org/jira/browse/CB-13695 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@8.0.0 >Reporter: Heiko >Priority: Critical > > My situation: > a build server that has no access to the internet. > By to a local npm mirror. > If i do at my build job: > npm config set registry "http://my.local.server/repository/mirror.npm; > npm install > npm install cordova ionic npm --no-save > cordova platform add ios --no-update-notifier > i get: > Using cordova-fetch for cordova-ios@4.5.3 > (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection > (rejection id: 1): Error: Cannot find module './index' > (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > My work around for cordova 7 was to use: --nofetch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[ https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516811#comment-16516811 ] Alwin commented on CB-13695: [~raphinesse] Would it be possible to copy the `.npmrc` file from the local project to the new working directory to make the install adhere the project's npm (registry) settings? > cordova-fetch: ignores npm registry > --- > > Key: CB-13695 > URL: https://issues.apache.org/jira/browse/CB-13695 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@8.0.0 >Reporter: Heiko >Priority: Critical > > My situation: > a build server that has no access to the internet. > By to a local npm mirror. > If i do at my build job: > npm config set registry "http://my.local.server/repository/mirror.npm; > npm install > npm install cordova ionic npm --no-save > cordova platform add ios --no-update-notifier > i get: > Using cordova-fetch for cordova-ios@4.5.3 > (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection > (rejection id: 1): Error: Cannot find module './index' > (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > My work around for cordova 7 was to use: --nofetch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13695) cordova-fetch: ignores npm registry
[ https://issues.apache.org/jira/browse/CB-13695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516807#comment-16516807 ] Raphael commented on CB-13695: -- @dpogue yes, we just shell out. Local config might be ignored because we change cwd. But I don't know why global config should be ignored. > cordova-fetch: ignores npm registry > --- > > Key: CB-13695 > URL: https://issues.apache.org/jira/browse/CB-13695 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-fetch >Affects Versions: cordova@8.0.0 >Reporter: Heiko >Priority: Critical > > My situation: > a build server that has no access to the internet. > By to a local npm mirror. > If i do at my build job: > npm config set registry "http://my.local.server/repository/mirror.npm; > npm install > npm install cordova ionic npm --no-save > cordova platform add ios --no-update-notifier > i get: > Using cordova-fetch for cordova-ios@4.5.3 > (node:391) UnhandledPromiseRejectionWarning: Unhandled promise rejection > (rejection id: 1): Error: Cannot find module './index' > (node:391) [DEP0018] DeprecationWarning: Unhandled promise rejections are > deprecated. In the future, promise rejections that are not handled will > terminate the Node.js process with a non-zero exit code. > My work around for cordova 7 was to use: --nofetch -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516785#comment-16516785
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on a change in pull request #448: CB-13685 android:
Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#discussion_r196332233
##
File path: spec/unit/prepare.spec.js
##
@@ -0,0 +1,935 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+'License'); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var rewire = require('rewire');
+var path = require('path');
+var CordovaError = require('cordova-common').CordovaError;
+
+const PATH_RESOURCE = path.join('platforms', 'android', 'app', 'src', 'main',
'res');
+
+/**
+ * Creates blank resource map object, used for testing.
+ *
+ * @param {String} target specific resource item
+ */
+function createResourceMap (target) {
+let resources = {};
+
+[
+'mipmap-ldpi',
+'mipmap-mdpi',
+'mipmap-hdpi',
+'mipmap-xhdpi',
+'mipmap-xxhdpi',
+'mipmap-xxxhdpi',
+'mipmap-ldpi-v26',
+'mipmap-mdpi-v26',
+'mipmap-hdpi-v26',
+'mipmap-xhdpi-v26',
+'mipmap-xxhdpi-v26',
+'mipmap-xxxhdpi-v26'
+].forEach((mipmap) => {
+if (!target || target === 'ic_launcher.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher.png')] = null;
+if (!target || target === 'ic_launcher_foreground.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_foreground.png')] =
null;
+if (!target || target === 'ic_launcher_background.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_background.png')] =
null;
+if (!target || target === 'ic_launcher_foreground.xml')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_foreground.xml')] =
null;
+if (!target || target === 'ic_launcher_background.xml')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_background.xml')] =
null;
+
+if (
+!mipmap.includes('-v26') &&
+(!target || target === 'ic_launcher.xml')
+) {
+resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher.xml')] =
null;
+}
+});
+
+return resources;
+}
+
+describe('updateIcons method', function () {
+// Rewire
+let prepare;
+
+// Spies
+let updateIconResourceForAdaptiveSpy;
+let updateIconResourceForLegacySpy;
+let emitSpy;
+let updatePathsSpy;
+
+// Mock Data
+let cordovaProject;
+let platformResourcesDir;
+
+beforeEach(function () {
+prepare = rewire('../../bin/templates/cordova/lib/prepare');
+
+cordovaProject = {
+root: '/mock',
+projectConfig: {
+path: '/mock/config.xml',
+cdvNamespacePrefix: 'cdv'
+},
+locations: {
+plugins: '/mock/plugins',
+www: '/mock/www'
+}
+};
+platformResourcesDir = PATH_RESOURCE;
+
+emitSpy = jasmine.createSpy('emit');
+prepare.__set__('events', {
+emit: emitSpy
+});
+
+updatePathsSpy = jasmine.createSpy('updatePaths');
+prepare.__set__('FileUpdater', {
+updatePaths: updatePathsSpy
+});
+
+// mocking initial responses for mapImageResources
+prepare.__set__('mapImageResources', function (rootDir, subDir, type,
resourceName) {
+if (resourceName.includes('ic_launcher.png')) {
+return createResourceMap('ic_launcher.png');
+} else if (resourceName.includes('ic_launcher_foreground.png')) {
+return createResourceMap('ic_launcher_foreground.png');
+} else if (resourceName.includes('ic_launcher_background.png')) {
+return createResourceMap('ic_launcher_background.png');
+} else if (resourceName.includes('ic_launcher_foreground.xml')) {
+return createResourceMap('ic_launcher_foreground.xml');
+} else if (resourceName.includes('ic_launcher_background.xml')) {
+return
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516784#comment-16516784
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on a change in pull request #448: CB-13685 android:
Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#discussion_r196332956
##
File path: spec/unit/prepare.spec.js
##
@@ -0,0 +1,935 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+'License'); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+'AS IS' BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+var rewire = require('rewire');
+var path = require('path');
+var CordovaError = require('cordova-common').CordovaError;
+
+const PATH_RESOURCE = path.join('platforms', 'android', 'app', 'src', 'main',
'res');
+
+/**
+ * Creates blank resource map object, used for testing.
+ *
+ * @param {String} target specific resource item
+ */
+function createResourceMap (target) {
+let resources = {};
+
+[
+'mipmap-ldpi',
+'mipmap-mdpi',
+'mipmap-hdpi',
+'mipmap-xhdpi',
+'mipmap-xxhdpi',
+'mipmap-xxxhdpi',
+'mipmap-ldpi-v26',
+'mipmap-mdpi-v26',
+'mipmap-hdpi-v26',
+'mipmap-xhdpi-v26',
+'mipmap-xxhdpi-v26',
+'mipmap-xxxhdpi-v26'
+].forEach((mipmap) => {
+if (!target || target === 'ic_launcher.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher.png')] = null;
+if (!target || target === 'ic_launcher_foreground.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_foreground.png')] =
null;
+if (!target || target === 'ic_launcher_background.png')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_background.png')] =
null;
+if (!target || target === 'ic_launcher_foreground.xml')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_foreground.xml')] =
null;
+if (!target || target === 'ic_launcher_background.xml')
resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher_background.xml')] =
null;
+
+if (
+!mipmap.includes('-v26') &&
+(!target || target === 'ic_launcher.xml')
+) {
+resources[path.join(PATH_RESOURCE, mipmap, 'ic_launcher.xml')] =
null;
+}
+});
+
+return resources;
+}
+
+describe('updateIcons method', function () {
+// Rewire
+let prepare;
+
+// Spies
+let updateIconResourceForAdaptiveSpy;
+let updateIconResourceForLegacySpy;
+let emitSpy;
+let updatePathsSpy;
+
+// Mock Data
+let cordovaProject;
+let platformResourcesDir;
+
+beforeEach(function () {
+prepare = rewire('../../bin/templates/cordova/lib/prepare');
+
+cordovaProject = {
+root: '/mock',
+projectConfig: {
+path: '/mock/config.xml',
+cdvNamespacePrefix: 'cdv'
+},
+locations: {
+plugins: '/mock/plugins',
+www: '/mock/www'
+}
+};
+platformResourcesDir = PATH_RESOURCE;
+
+emitSpy = jasmine.createSpy('emit');
+prepare.__set__('events', {
+emit: emitSpy
+});
+
+updatePathsSpy = jasmine.createSpy('updatePaths');
+prepare.__set__('FileUpdater', {
+updatePaths: updatePathsSpy
+});
+
+// mocking initial responses for mapImageResources
+prepare.__set__('mapImageResources', function (rootDir, subDir, type,
resourceName) {
+if (resourceName.includes('ic_launcher.png')) {
+return createResourceMap('ic_launcher.png');
+} else if (resourceName.includes('ic_launcher_foreground.png')) {
+return createResourceMap('ic_launcher_foreground.png');
+} else if (resourceName.includes('ic_launcher_background.png')) {
+return createResourceMap('ic_launcher_background.png');
+} else if (resourceName.includes('ic_launcher_foreground.xml')) {
+return createResourceMap('ic_launcher_foreground.xml');
+} else if (resourceName.includes('ic_launcher_background.xml')) {
+return
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516776#comment-16516776
]
ASF GitHub Bot commented on CB-13685:
-
raphinesse commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398313362
Sorry, I know very little about the Android build, so I can't really review
this. Maybe @dpogue or @infiloop.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14124) Access-Control-Allow-Headers
[
https://issues.apache.org/jira/browse/CB-14124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516740#comment-16516740
]
Alejandro commented on CB-14124:
I've changed it and it's still the same, what I find strange is that in android
it works perfectly and in IOS it does not work /:
> Access-Control-Allow-Headers
>
>
> Key: CB-14124
> URL: https://issues.apache.org/jira/browse/CB-14124
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios, cordova-plugin-wkwebview-engine
>Affects Versions: cordova-ios@4.5.4, 8.0.0
>Reporter: Alejandro
>Assignee: Suraj Pindoria
>Priority: Major
> Labels: CORS, WKWebView, ajax, cordova, cordova-8.0.0,
> cordova-ios, ios
>
> Hello,
> I have one app with:
> Cordova version: 8.0.0
> cordova-ios version: 4.5.4
> I had to install the plugin
> "[cordova-plugin-wkwebview-engine|https://github.com/apache/cordova-plugin-wkwebview-engine];
> to solve a problem with the interface.
> In android everything works correctly.
> But in IOS when I make AJAX requests to my API I have the error:
>
> XMLHttpRequest cannot load ... Request header field Authorization is not
> allowed by Access-Control-Allow-Headers
>
> In the API I have the following in place to allow CORS connections:
> {code:java}
> header('Access-Control-Allow-Headers: *');
> header('Access-Control-Allow-Origin: *');
> header('Access-Control-Allow-Methods: *');
> {code}
> In the config.xml I have this:
> {code:java}
>
> http://*/*; />
> https://*/*; />
>
>
> mailto:*; />
>
>
>
>
> {code}
> and my AJAX requests are:
> {code:java}
> $.ajax({
> url: url,
> data: formData,
> type: 'post',
> dataType: "json",
> contentType: false,
> processData: false,
> success: function (respuesta) {
> }
> });
> {code}
> And I have this meta:
> {code:java}
>
> {code}
> The strange thing is that without the
> plugin([cordova-plugin-wkwebview-engine|https://github.com/apache/cordova-plugin-wkwebview-engine])
> it works fine, but I need the plugin obligatorily.
> I am desperate and I do not know what to do anymore.
> any solution?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13685) Android Adaptive Icons
[
https://issues.apache.org/jira/browse/CB-13685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516728#comment-16516728
]
ASF GitHub Bot commented on CB-13685:
-
erisu commented on issue #448: CB-13685 android: Adaptive Icon Support
URL: https://github.com/apache/cordova-android/pull/448#issuecomment-398297321
@raphinesse I rebased with the latest master now that the #442 PR has been
merged. Do you think this is ready to merge?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Android Adaptive Icons
> --
>
> Key: CB-13685
> URL: https://issues.apache.org/jira/browse/CB-13685
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-android
> Environment: All
>Reporter: Josef Brandl
>Assignee: Joe Bowser
>Priority: Minor
>
> Starting with Android 8 Oreo (API level 26) Android allows developers to
> create app icons using a background and a foreground image file. This feature
> is called "adaptive icons". One major change that goes with this feature is
> that icons get now clipped into a shape by the system. This leads to a very
> uniform and clean design like on iOS where all icons are a rounded rectangle.
> The other advantage is that visual effects can be applied to the icon by the
> system due to the separation between foreground an background.
> Android Studio greatly assists the developer at the creation of the app icon
> resources because it creates backwards compatible icons for older devices
> that don't support the adaptive icons feature.
> https://developer.android.com/studio/write/image-asset-studio.html
> The following resources are created.
> {code}
> res
> ├── drawable
> │ ├── ic_launcher_background.xml
> │ └── ic_launcher_foreground.xml
> ├── mipmap-anydpi-v26
> │ ├── ic_launcher.xml
> │ └── ic_launcher_round.xml
> ├── mipmap-hdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-mdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> ├── mipmap-xxhdpi
> │ ├── ic_launcher.png
> │ └── ic_launcher_round.png
> └── mipmap-xxxhdpi
> ├── ic_launcher.png
> └── ic_launcher_round.png
> {code}
> It is currently not clear how these files can be used inside a cordova
> project.
> - res/mipmap-anydpi-v26/ic_launcher.xml points to other image resources
> (foreground, background)
> - The foreground and background can be vector graphics (-> xml files in
> res/drawable)
> - The documentation needs to be updated
> (I've never reported an issue using JIRA before - I'm only used to github.
> So, please guide me if I'm doing something incorrect)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
