[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097015#comment-15097015 ] ASF GitHub Bot commented on DRILL-4270: --- GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/322 DRILL-4270: Create a separate WindowFramer that supports the FRAME cl… …ause separate DefaultFrameTemplate into 2 implementations: one that supports custom frames (aggregations, first_value, last_value) and one that doesn't You can merge this pull request into a Git repository by running: $ git pull https://github.com/adeneche/incubator-drill DRILL-4270 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/322.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #322 commit 8bcde155d23550d6733f4dcb18868bdc3fb3b119 Author: adeneche Date: 2016-01-11T22:47:32Z DRILL-4270: Create a separate WindowFramer that supports the FRAME clause separate DefaultFrameTemplate into 2 implementations: one that supports custom frames (aggregations, first_value, last_value) and one that doesn't > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Deneche A. Hakim > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15097266#comment-15097266 ] ASF GitHub Bot commented on DRILL-4270: --- Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/322#issuecomment-171470081 The purpose of this PR is to separate the functions that support the FRAME clause in CustomFrameTemplate from the ones that don't in DefaultFrameTemplate. Work still needs to be done to make the refactoring complete (like making sure code is not duplicated between the templates), but I decided to leave it after I make the necessary changes to support the FRAME clause. @amansinha100 can you please review ? > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Aman Sinha > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102208#comment-15102208 ] ASF GitHub Bot commented on DRILL-4270: --- Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/322#issuecomment-172038682 Overall refactoring looks ok. One thing that needs some clarity: Is the definition of default frame 'between unbounded preceding and current row' ? If the user explicitly specifies this frame in the query, will it be treated as default or custom frame (as opposed to not specifying anything frame) ? > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Aman Sinha > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102217#comment-15102217 ] ASF GitHub Bot commented on DRILL-4270: --- Github user adeneche commented on the pull request: https://github.com/apache/drill/pull/322#issuecomment-172040219 According to the SQL specification you can have a FRAME clause with FIRST_VALUE, LAST_VALUE or aggregate functions. Custom frame template will be used for those functions regardless of the presence/absence of the FRAME clause. > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Aman Sinha > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105630#comment-15105630 ] ASF GitHub Bot commented on DRILL-4270: --- Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/322#issuecomment-172619347 Renaming sounds fine to avoid misinterpretation. +1. > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Aman Sinha > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (DRILL-4270) Create a separate WindowFramer that supports the FRAME clause
[ https://issues.apache.org/jira/browse/DRILL-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111253#comment-15111253 ] ASF GitHub Bot commented on DRILL-4270: --- Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/322 > Create a separate WindowFramer that supports the FRAME clause > - > > Key: DRILL-4270 > URL: https://issues.apache.org/jira/browse/DRILL-4270 > Project: Apache Drill > Issue Type: Sub-task > Components: Execution - Relational Operators >Affects Versions: 1.5.0 >Reporter: Deneche A. Hakim >Assignee: Deneche A. Hakim > Fix For: Future > > > Currently most the window functions logic is handled by DefaultFrameTemplate. > Create a separate CustomFrameTemplate that handles the FRAME clause, this > should make the code in both classes more focused and will make it easier for > us to add support for the FRAME clause. > Aggregations, FIRST_VALUE and LAST_VALUE will be handled by > CustomFrameTemplate, and all remaining window functions (Ranking, ROW_NUMBER, > LEAD and LAG) will be handled by DefaultFrameTemplate. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
