[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …
dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803594934
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+while (mailboxExecutor.tryYield()) {}
Review comment:
I'm not saying there is an issue. I just don't feel comfortable saying
there is not, and if Piotr is not comfortable with that on the first sight as
well, it's worth giving it a closer look. Unfortunately I don't have enough
context in this area to provide more insight myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …
dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803594934
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+while (mailboxExecutor.tryYield()) {}
Review comment:
I'm not saying there is an issue. I just don't feel comfortable saying
there is not, and if Piotr is not comfortable with that on the first sight as
well, it's worth giving closer look. Unfortunately I don't have enough context
in this area to provide more insight myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …
dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803587452
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+while (mailboxExecutor.tryYield()) {}
Review comment:
Maybe to rephrase that a bit, so it doesn't come out wrong: we shouldn't
rush things that require more context from people that are busy with other
efforts, just for sake of getting something merged before the feature freeze
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …
dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803580523
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+while (mailboxExecutor.tryYield()) {}
Review comment:
@dannycranmer It sounds fishy and doesn't align with the quality
standards we require for Flink contributions. If you're concerned about the
feature freeze, this can still be merged after that as the current
implementation is broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …
dmvk commented on a change in pull request #18651:
URL: https://github.com/apache/flink/pull/18651#discussion_r803439528
##
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##
@@ -267,18 +267,31 @@ private void registerCallback() {
@Override
public void write(InputT element, Context context) throws IOException,
InterruptedException {
+while (mailboxExecutor.tryYield()) {}
Review comment:
This seems weird 樂 If I understand it correctly in means something along
the lines of ... don't write results until we have anything else to do, so for
example if user has a super frequent checkpointing (edge case), we can not make
progress?
@pnowojski Can you please verify?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
