Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

1996fanrui merged PR #24089:
URL: https://github.com/apache/flink/pull/24089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

1996fanrui commented on PR #24089:
URL: https://github.com/apache/flink/pull/24089#issuecomment-1899822924

   The CI is green, merging~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

1996fanrui commented on PR #24089:
URL: https://github.com/apache/flink/pull/24089#issuecomment-1899531748

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

Sxnan commented on PR #24089:
URL: https://github.com/apache/flink/pull/24089#issuecomment-1897598262

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

Sxnan commented on code in PR #24089:
URL: https://github.com/apache/flink/pull/24089#discussion_r1454983956


##
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
##
@@ -496,7 +503,12 @@ public final class ConfigConstants {
  */
 @Deprecated public static final String YARN_TASK_MANAGER_ENV_PREFIX = 
"yarn.taskmanager.env.";
 
-/** Template for the YARN container start invocation. */
+/**
+ * Template for the YARN container start invocation.
+ *
+ * @deprecated in favor of {@code 
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.

Review Comment:
   I tried before, but it doesn't work. The reason is that flink-core module 
doesn't depend on flink-yarn module, so we cannot link to 
`YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE`, which is defined in 
flink-yarn module. 
   
   YARN_APPLICATION_MASTER_PORT has the same problem, so it uses `@code` as 
weel.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

1996fanrui commented on code in PR #24089:
URL: https://github.com/apache/flink/pull/24089#discussion_r1454809594


##
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##
@@ -808,6 +808,31 @@ public class TaskManagerOptions {
 
code(TaskManagerLoadBalanceMode.NONE.name(
 .build());
 
+@Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+@Documentation.OverrideDefault("System.getProperty(\"log.file\")")
+public static final ConfigOption TASK_MANAGER_LOG_PATH =
+ConfigOptions.key("taskmanager.log.path")
+.stringType()
+.defaultValue(System.getProperty("log.file"))
+.withDescription("The path to the log file of the task 
manager.");
+
+@Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+public static final ConfigOption FS_STREAM_OPENING_TIME_OUT =
+ConfigOptions.key("taskmanager.runtime.fs-timeout")
+.durationType()
+.defaultValue(Duration.ZERO)
+.withDeprecatedKeys("taskmanager.runtime.fs_timeout")
+.withDescription(
+"The timeout for filesystem stream opening. A 
value of 0 indicates infinite waiting.");
+
+@Documentation.Section(Documentation.Sections.ALL_TASK_MANAGER)
+public static final ConfigOption LOCAL_NUMBER_TASK_MANAGER =

Review Comment:
   nit: how about?

   ```suggestion
   public static final ConfigOption 
MINI_CLUSTER_NUMBER_TASK_MANAGER =
   ```



##
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java:
##
@@ -496,7 +503,12 @@ public final class ConfigConstants {
  */
 @Deprecated public static final String YARN_TASK_MANAGER_ENV_PREFIX = 
"yarn.taskmanager.env.";
 
-/** Template for the YARN container start invocation. */
+/**
+ * Template for the YARN container start invocation.
+ *
+ * @deprecated in favor of {@code 
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.

Review Comment:
   ```suggestion
* @deprecated in favor of {@link 
YarnConfigOptions#YARN_CONTAINER_START_COMMAND_TEMPLATE}.
   ```
   
   nit: `@link` is easy to forward in IDEA.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

Sxnan commented on PR #24089:
URL: https://github.com/apache/flink/pull/24089#issuecomment-1895226571

   @1996fanrui @xintongsong Could you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

flinkbot commented on PR #24089:
URL: https://github.com/apache/flink/pull/24089#issuecomment-1891540555

   
   ## CI report:
   
   * d143bfa73830c502047f51b2c4328337aa37ce06 UNKNOWN
   
   
   Bot commands
 The @flinkbot bot supports the following commands:
   
- `@flinkbot run azure` re-run the last Azure build
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] [FLINK-34083][config] Deprecate string configuration keys and unused constants in ConfigConstants [flink]

[via GitHub]

Sxnan opened a new pull request, #24089:
URL: https://github.com/apache/flink/pull/24089

   ## What is the purpose of the change
   
   
   This PR updates ConfigConstants.java to deprecate and replace string 
configuration keys and marks unused constants in ConfigConstants.java as 
deprecated.
   
   
   ## Brief change log
   
   - Move BootstrapTools#getTaskManagerShellCommand to flink-yarn Utils
   - Deprecate string configuration keys and unused constants in ConfigConstants
   
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
 - Dependencies (does it add or upgrade a dependency): no
 - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: yes
 - The serializers: no
 - The runtime per-record code paths (performance sensitive): no
 - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper:no
 - The S3 file system connector: no
   
   ## Documentation
   
 - Does this pull request introduce a new feature? no
 - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org