[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[ https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871523#comment-17871523 ] ASF GitHub Bot commented on GEODE-10291: moleske closed pull request #972: GEODE-10291: Use clang 12 in all dockerfiles URL: https://github.com/apache/geode-native/pull/972 > Support Jammy (ubuntu 22.04) > > > Key: GEODE-10291 > URL: https://issues.apache.org/jira/browse/GEODE-10291 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > Fix For: 1.15.1, 1.16.0 > > > Native client should compile on the latest (ubuntu 22.04) operating system. > Consider including a new pipeline as part of this -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[ https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871522#comment-17871522 ] ASF GitHub Bot commented on GEODE-10291: moleske closed pull request #968: GEODE-10291: Add ubuntu 22.04 (jammy) to CI URL: https://github.com/apache/geode-native/pull/968 > Support Jammy (ubuntu 22.04) > > > Key: GEODE-10291 > URL: https://issues.apache.org/jira/browse/GEODE-10291 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > Fix For: 1.15.1, 1.16.0 > > > Native client should compile on the latest (ubuntu 22.04) operating system. > Consider including a new pipeline as part of this -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10454) Update to Develocity Gradle Plugin
[ https://issues.apache.org/jira/browse/GEODE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10454: --- Labels: pull-request-available (was: ) > Update to Develocity Gradle Plugin > -- > > Key: GEODE-10454 > URL: https://issues.apache.org/jira/browse/GEODE-10454 > Project: Geode > Issue Type: Improvement >Reporter: Clay Johnson >Priority: Major > Labels: pull-request-available > > Currently, Fineract publishes build scans to the Develocity instance at > ge.apache.org. To accomplish this, the Gradle Enterprise Gradle Plugin is > applied. > As of Develocity 2024.3, expected later this year, the Gradle Enterprise > Gradle Plugin will no longer be supported. Migration to the Develocity Gradle > Plugin will be necessary. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10400) Function execution triggering internal exception
[ https://issues.apache.org/jira/browse/GEODE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787318#comment-17787318 ] ASF GitHub Bot commented on GEODE-10400: gaussianrecurrence commented on PR #982: URL: https://github.com/apache/geode-native/pull/982#issuecomment-1816770813 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. > Function execution triggering internal exception > > > Key: GEODE-10400 > URL: https://issues.apache.org/jira/browse/GEODE-10400 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* a cluster with at least 3 members > *AND* a partitioned region with 1 redundant-copy > *AND* a server function called *JustAFunction* with isHA=false, > hasResult=true, optimizeForWrite=true > *AND* a native client configured to connect to the above cluster with a pool > using PR-Single-Hop=true > *WHEN* *JustAFunction* is executed with onRegion and no filters > *IF* the client has partial metadata due to the cluster starting up or a > rebalance occurring > *THEN* and exception of type > *"org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException: > Multiple target nodes found for single hop operation"* is thrown by one of > the servers > --- > *Additional information.* Currently, in geode-native whenever the metadata > information is incomplete, and the user tries to execute the server function > with onRegion and no filters, a request of type > EXECUTE_REGION_FUNCTION_SINGLE_HOP is sent to each node. > But the issue is that bucket partition used by the client is incorrect, > leading consequently to the mentioned exception. > *Potential solution.* The potential solution would be to detect that the > metadata is incomplete before actually executing the function and send a > EXECUTE_REGION_FUNCTION request to one of the cluster nodes instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10400) Function execution triggering internal exception
[ https://issues.apache.org/jira/browse/GEODE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787317#comment-17787317 ] ASF GitHub Bot commented on GEODE-10400: gaussianrecurrence closed pull request #982: GEODE-10400: Fix metadata completion detection URL: https://github.com/apache/geode-native/pull/982 > Function execution triggering internal exception > > > Key: GEODE-10400 > URL: https://issues.apache.org/jira/browse/GEODE-10400 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* a cluster with at least 3 members > *AND* a partitioned region with 1 redundant-copy > *AND* a server function called *JustAFunction* with isHA=false, > hasResult=true, optimizeForWrite=true > *AND* a native client configured to connect to the above cluster with a pool > using PR-Single-Hop=true > *WHEN* *JustAFunction* is executed with onRegion and no filters > *IF* the client has partial metadata due to the cluster starting up or a > rebalance occurring > *THEN* and exception of type > *"org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException: > Multiple target nodes found for single hop operation"* is thrown by one of > the servers > --- > *Additional information.* Currently, in geode-native whenever the metadata > information is incomplete, and the user tries to execute the server function > with onRegion and no filters, a request of type > EXECUTE_REGION_FUNCTION_SINGLE_HOP is sent to each node. > But the issue is that bucket partition used by the client is incorrect, > leading consequently to the mentioned exception. > *Potential solution.* The potential solution would be to detect that the > metadata is incomplete before actually executing the function and send a > EXECUTE_REGION_FUNCTION request to one of the cluster nodes instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10414) Add putIfAbsent method to region interfaces
[ https://issues.apache.org/jira/browse/GEODE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787319#comment-17787319 ] ASF GitHub Bot commented on GEODE-10414: gaussianrecurrence closed pull request #984: GEODE-10414: Implement Region::putIfAbsent method URL: https://github.com/apache/geode-native/pull/984 > Add putIfAbsent method to region interfaces > --- > > Key: GEODE-10414 > URL: https://issues.apache.org/jira/browse/GEODE-10414 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* have putIfAbsent region method implemented > *SO THAT* I can atomically put entries only if they don't previously, exist > and also, to align it with the Java API. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10276) Refactor PDX (de)serialziation code to align it with Java client
[ https://issues.apache.org/jira/browse/GEODE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787312#comment-17787312 ] ASF GitHub Bot commented on GEODE-10276: gaussianrecurrence commented on PR #969: URL: https://github.com/apache/geode-native/pull/969#issuecomment-1816770033 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. > Refactor PDX (de)serialziation code to align it with Java client > > > Key: GEODE-10276 > URL: https://issues.apache.org/jira/browse/GEODE-10276 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > Currently there are the following open issues regarding PDX (de)serialization: > * [GEODE-9968 - Fix deserialization for new fields in PdxSerializable > class|https://issues.apache.org/jira/browse/GEODE-9968] > * [GEODE-9753 - Coredump during PdxSerializable object > serialization|https://issues.apache.org/jira/browse/GEODE-9753] > * [GEODE-10220 - Coredump while initializing PdxType > remoteToLocal|https://issues.apache.org/jira/browse/GEODE-10220] > * [GEODE-10255 - PdxSerializable not working correctly for multiple versions > of the same class|https://issues.apache.org/jira/browse/GEODE-10255] > Also, the implementation on this ticket ([GEODE-8212: Reduce connections to > server to get type id|https://issues.apache.org/jira/browse/GEODE-8212]) > poses some issues with PDX entries which fields are a permutation. Thing is > that PdxTypes which fields are a permutation might use the wrong offsets, > leading to a corrupt serialization. This is something that was not taken into > account at the time of getting this PR merged. > So this ticket should be reverted and possibly an alternative solution > proposed. > In order to tackle these issues, a code refactoring is needed to introduce > the following implementations: > * Single type of PdxWriter > * An implementation PdxReader that tracks unread data, and other that don't. > * An implementation for PdxInstances that guarantees that fields are > actually written in alphabetical order, independently of the writeFields call > order. This should tackle the issue described above regarding GEODE-8212. > * Also, it'd be ideal to make it so PDX code is cleaner and easier to > understand, though that's a complex matter, and also, subjective. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10396) IllegalStateException wrapped within FunctionException triggers endpoint disconnection
[ https://issues.apache.org/jira/browse/GEODE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787316#comment-17787316 ] ASF GitHub Bot commented on GEODE-10396: gaussianrecurrence commented on PR #977: URL: https://github.com/apache/geode-native/pull/977#issuecomment-1816770656 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. > IllegalStateException wrapped within FunctionException triggers endpoint > disconnection > -- > > Key: GEODE-10396 > URL: https://issues.apache.org/jira/browse/GEODE-10396 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* A cluster of 3 servers and a client with a pool pointing to those 3 > servers >*AND* configured with PR-Singl-Hop = true > *WHEN* A server function is executed with onRegion and with a filter >*AND* it throws an IllegalServerException wrapped within a > FunctionExceution in the body > *THEN* the native client thinks there is an isue with the node and closes all > the endpoint's connections. > --- > *IT IS TO BE EXPECTED* That given that the exception is wrapped inside a > FunctionException this should be ignored by the endpoint failure detection > mechanism that native client has into place. > *AS ADDITIONAL INFO* Currently, the exception chain relationship info is not > read by the native client, as it's serialized using Java serialization format. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10396) IllegalStateException wrapped within FunctionException triggers endpoint disconnection
[ https://issues.apache.org/jira/browse/GEODE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787315#comment-17787315 ] ASF GitHub Bot commented on GEODE-10396: gaussianrecurrence closed pull request #977: GEODE-10396: Avoid endpoint closure upon exception URL: https://github.com/apache/geode-native/pull/977 > IllegalStateException wrapped within FunctionException triggers endpoint > disconnection > -- > > Key: GEODE-10396 > URL: https://issues.apache.org/jira/browse/GEODE-10396 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* A cluster of 3 servers and a client with a pool pointing to those 3 > servers >*AND* configured with PR-Singl-Hop = true > *WHEN* A server function is executed with onRegion and with a filter >*AND* it throws an IllegalServerException wrapped within a > FunctionExceution in the body > *THEN* the native client thinks there is an isue with the node and closes all > the endpoint's connections. > --- > *IT IS TO BE EXPECTED* That given that the exception is wrapped inside a > FunctionException this should be ignored by the endpoint failure detection > mechanism that native client has into place. > *AS ADDITIONAL INFO* Currently, the exception chain relationship info is not > read by the native client, as it's serialized using Java serialization format. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10276) Refactor PDX (de)serialziation code to align it with Java client
[ https://issues.apache.org/jira/browse/GEODE-10276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787313#comment-17787313 ] ASF GitHub Bot commented on GEODE-10276: gaussianrecurrence closed pull request #969: GEODE-10276: Refactor PDX (de)serialization code URL: https://github.com/apache/geode-native/pull/969 > Refactor PDX (de)serialziation code to align it with Java client > > > Key: GEODE-10276 > URL: https://issues.apache.org/jira/browse/GEODE-10276 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > Currently there are the following open issues regarding PDX (de)serialization: > * [GEODE-9968 - Fix deserialization for new fields in PdxSerializable > class|https://issues.apache.org/jira/browse/GEODE-9968] > * [GEODE-9753 - Coredump during PdxSerializable object > serialization|https://issues.apache.org/jira/browse/GEODE-9753] > * [GEODE-10220 - Coredump while initializing PdxType > remoteToLocal|https://issues.apache.org/jira/browse/GEODE-10220] > * [GEODE-10255 - PdxSerializable not working correctly for multiple versions > of the same class|https://issues.apache.org/jira/browse/GEODE-10255] > Also, the implementation on this ticket ([GEODE-8212: Reduce connections to > server to get type id|https://issues.apache.org/jira/browse/GEODE-8212]) > poses some issues with PDX entries which fields are a permutation. Thing is > that PdxTypes which fields are a permutation might use the wrong offsets, > leading to a corrupt serialization. This is something that was not taken into > account at the time of getting this PR merged. > So this ticket should be reverted and possibly an alternative solution > proposed. > In order to tackle these issues, a code refactoring is needed to introduce > the following implementations: > * Single type of PdxWriter > * An implementation PdxReader that tracks unread data, and other that don't. > * An implementation for PdxInstances that guarantees that fields are > actually written in alphabetical order, independently of the writeFields call > order. This should tackle the issue described above regarding GEODE-8212. > * Also, it'd be ideal to make it so PDX code is cleaner and easier to > understand, though that's a complex matter, and also, subjective. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10414) Add putIfAbsent method to region interfaces
[ https://issues.apache.org/jira/browse/GEODE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787320#comment-17787320 ] ASF GitHub Bot commented on GEODE-10414: gaussianrecurrence commented on PR #984: URL: https://github.com/apache/geode-native/pull/984#issuecomment-1816770978 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. > Add putIfAbsent method to region interfaces > --- > > Key: GEODE-10414 > URL: https://issues.apache.org/jira/browse/GEODE-10414 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* have putIfAbsent region method implemented > *SO THAT* I can atomically put entries only if they don't previously, exist > and also, to align it with the Java API. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10044) Allow for FunctionAttributes to be updated
[ https://issues.apache.org/jira/browse/GEODE-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787310#comment-17787310 ] ASF GitHub Bot commented on GEODE-10044: gaussianrecurrence commented on PR #930: URL: https://github.com/apache/geode-native/pull/930#issuecomment-1816768908 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. > Allow for FunctionAttributes to be updated > --- > > Key: GEODE-10044 > URL: https://issues.apache.org/jira/browse/GEODE-10044 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Minor > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* to reset function attributes on-the-fly whenever a function > attributes mismatch is detected on the client > *SO THAT* FunctionAttributes can be changed during an upgrade scenario > > *Additional information.* Currently there is no exception being thrown from > the server whenever a function attributes missmatch is detected. Instead, a > function execution error is send to the client. So it remains to be tackled > how the mismatch is going to be detected on the client side. > *Also, for additional context,* this feature is designed in order to fulfill > the following upgrade scenario: > # A server function called ExampleFunction is deployed inside a cluster. > This server function is defined with isHA=false > # Function is executed several times from the client. > # After some time, a new version of ExampleFunction jar is deployed. The new > version of the server function is defined with isHA=true > # After updating the server function, executions for this function inside > the client should fail at most once, and after that, execute smoothly with > the new function attributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10044) Allow for FunctionAttributes to be updated
[ https://issues.apache.org/jira/browse/GEODE-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787311#comment-17787311 ] ASF GitHub Bot commented on GEODE-10044: gaussianrecurrence closed pull request #930: GEODE-10044: Allow FunctionAttributes update URL: https://github.com/apache/geode-native/pull/930 > Allow for FunctionAttributes to be updated > --- > > Key: GEODE-10044 > URL: https://issues.apache.org/jira/browse/GEODE-10044 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Minor > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* to reset function attributes on-the-fly whenever a function > attributes mismatch is detected on the client > *SO THAT* FunctionAttributes can be changed during an upgrade scenario > > *Additional information.* Currently there is no exception being thrown from > the server whenever a function attributes missmatch is detected. Instead, a > function execution error is send to the client. So it remains to be tackled > how the mismatch is going to be detected on the client side. > *Also, for additional context,* this feature is designed in order to fulfill > the following upgrade scenario: > # A server function called ExampleFunction is deployed inside a cluster. > This server function is defined with isHA=false > # Function is executed several times from the client. > # After some time, a new version of ExampleFunction jar is deployed. The new > version of the server function is defined with isHA=true > # After updating the server function, executions for this function inside > the client should fail at most once, and after that, execute smoothly with > the new function attributes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10012) Avoid retries for non-HA function execution
[
https://issues.apache.org/jira/browse/GEODE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787309#comment-17787309
]
ASF GitHub Bot commented on GEODE-10012:
gaussianrecurrence commented on PR #920:
URL: https://github.com/apache/geode-native/pull/920#issuecomment-1816767907
I haven't had the time to work on this for a long time or I think I'll have
the opportunity to in the near future, hence I am closing this PR, if anyone
wants to tackle this issue can take it up from its latest state.
> Avoid retries for non-HA function execution
> ---
>
> Key: GEODE-10012
> URL: https://issues.apache.org/jira/browse/GEODE-10012
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *GIVEN* a cluster with 3 servers and 1 locator
> *AND* a PartitionedRegion with redundant-copies="1"
> *AND* a user-defined Function with isHA=false
> *AND* a geode-native client with a pool with single-hop enabled and retry
> attempts set to 2
> *WHEN* execution fails due to a connectivity issue/connection
> timeout/internal cluster error
> *THEN* function is retried twice
>
> *Additional information.* The function is retried at the network code layer,
> and given whenever there is a timeout/connectivity error, the BSL is removed
> from the ClientMetadataService, whenever retries happen, you might get a
> *InternalFunctionInvocationTargetException* exception thrown indicating:
> {code:java}
> Multiple target nodes found for single hop operation {code}
> Also, have into account that Java client API behaviour never retries a
> Function Execution if isHA=false for that function, and whenever isHA=true,
> the function is retried but on the function execution logic and not at the
> networking layer.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10012) Avoid retries for non-HA function execution
[
https://issues.apache.org/jira/browse/GEODE-10012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787308#comment-17787308
]
ASF GitHub Bot commented on GEODE-10012:
gaussianrecurrence closed pull request #920: GEODE-10012: Avoid non-HA
function retries
URL: https://github.com/apache/geode-native/pull/920
> Avoid retries for non-HA function execution
> ---
>
> Key: GEODE-10012
> URL: https://issues.apache.org/jira/browse/GEODE-10012
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *GIVEN* a cluster with 3 servers and 1 locator
> *AND* a PartitionedRegion with redundant-copies="1"
> *AND* a user-defined Function with isHA=false
> *AND* a geode-native client with a pool with single-hop enabled and retry
> attempts set to 2
> *WHEN* execution fails due to a connectivity issue/connection
> timeout/internal cluster error
> *THEN* function is retried twice
>
> *Additional information.* The function is retried at the network code layer,
> and given whenever there is a timeout/connectivity error, the BSL is removed
> from the ClientMetadataService, whenever retries happen, you might get a
> *InternalFunctionInvocationTargetException* exception thrown indicating:
> {code:java}
> Multiple target nodes found for single hop operation {code}
> Also, have into account that Java client API behaviour never retries a
> Function Execution if isHA=false for that function, and whenever isHA=true,
> the function is retried but on the function execution logic and not at the
> networking layer.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10017) Fix new ITs unstability for TCs that involve members restart
[
https://issues.apache.org/jira/browse/GEODE-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787307#comment-17787307
]
ASF GitHub Bot commented on GEODE-10017:
gaussianrecurrence commented on PR #919:
URL: https://github.com/apache/geode-native/pull/919#issuecomment-1816767172
I haven't had the time to work on this for a long time or I think I'll have
the opportunity to in the near future, hence I am closing this PR, if anyone
wants to tackle this issue can take it up from its latest state.
> Fix new ITs unstability for TCs that involve members restart
>
>
> Key: GEODE-10017
> URL: https://issues.apache.org/jira/browse/GEODE-10017
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *GIVEN* an integration TC on which a server restart needs to be restarted
> *WHEN* the server is starting up again
> *THEN* +{color:#172b4d}it might{color}+{color:#172b4d} happen that the TC
> gets stuck{color}
>
> *Additional information.* This issue does not always happens, and I've seen
> it happening more frequently with the latest version of Geode server (1.15.0)
> Some examples of this TC are:
> * RegisterKeysTest.RegisterKeySetAndClusterRestart
> * PartitionRegionWithRedundancyTest.putgetWithSingleHop
> * ···
> Also, this is normally the exec flow for the TCs that get stuck:
> # Setup cluster
> # Do TC specific ops
> # Stop server(s)/Cluster shutdown
> # Start server(s)
> In all cases, the server gets stuck at step 4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10017) Fix new ITs unstability for TCs that involve members restart
[
https://issues.apache.org/jira/browse/GEODE-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787306#comment-17787306
]
ASF GitHub Bot commented on GEODE-10017:
gaussianrecurrence closed pull request #919: GEODE-10017: Fix servers restart
within new ITs
URL: https://github.com/apache/geode-native/pull/919
> Fix new ITs unstability for TCs that involve members restart
>
>
> Key: GEODE-10017
> URL: https://issues.apache.org/jira/browse/GEODE-10017
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
>
> *GIVEN* an integration TC on which a server restart needs to be restarted
> *WHEN* the server is starting up again
> *THEN* +{color:#172b4d}it might{color}+{color:#172b4d} happen that the TC
> gets stuck{color}
>
> *Additional information.* This issue does not always happens, and I've seen
> it happening more frequently with the latest version of Geode server (1.15.0)
> Some examples of this TC are:
> * RegisterKeysTest.RegisterKeySetAndClusterRestart
> * PartitionRegionWithRedundancyTest.putgetWithSingleHop
> * ···
> Also, this is normally the exec flow for the TCs that get stuck:
> # Setup cluster
> # Do TC specific ops
> # Stop server(s)/Cluster shutdown
> # Start server(s)
> In all cases, the server gets stuck at step 4
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10447) Support JDK11 for Geode
[ https://issues.apache.org/jira/browse/GEODE-10447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10447: --- Labels: pull-request-available (was: ) > Support JDK11 for Geode > --- > > Key: GEODE-10447 > URL: https://issues.apache.org/jira/browse/GEODE-10447 > Project: Geode > Issue Type: Improvement >Reporter: Jie Wen >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10443) Update shiro-core to version 1.11.0 for CVE-2022-40664
[ https://issues.apache.org/jira/browse/GEODE-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10443: --- Labels: needsTriage pull-request-available (was: needsTriage) > Update shiro-core to version 1.11.0 for CVE-2022-40664 > -- > > Key: GEODE-10443 > URL: https://issues.apache.org/jira/browse/GEODE-10443 > Project: Geode > Issue Type: Bug >Affects Versions: 1.15.1 >Reporter: Ankush Mittal >Priority: Major > Labels: needsTriage, pull-request-available > > As per [https://nvd.nist.gov/vuln/detail/CVE-2022-40664] , > _"Apache Shiro before 1.10.0, Authentication Bypass Vulnerability in Shiro > when forwarding or including via RequestDispatcher."_ > Geode 1.15.1 bundles version 1.9.1 of shiro-core jar which is vulnerable as > per the CVE. > Also although the CVE doesn't include "1.10.0", but since more latest version > "1.11.0" is available, logged ticket to bundle the same. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10446) Capture build scans on ge.apache.org to benefit from deep build insights
[ https://issues.apache.org/jira/browse/GEODE-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10446: --- Labels: pull-request-available (was: ) > Capture build scans on ge.apache.org to benefit from deep build insights > -- > > Key: GEODE-10446 > URL: https://issues.apache.org/jira/browse/GEODE-10446 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Clay Johnson >Priority: Major > Labels: pull-request-available > > This improvement will enhance the functionality of the Geode build by > publishing build scans to [ge.apache.org|https://ge.apache.org/], hosted by > the Apache Software Foundation and run in partnership between the ASF and > Gradle. This Gradle Enterprise instance has all features and extensions > enabled and is freely available for use by the Apache Geode project and all > other Apache projects. > On this Gradle Enterprise instance, Apache Geode will have access not only to > all of the published build scans but other aggregate data features such as: > * Dashboards to view all historical build scans, along with performance > trends over time > * Build failure analytics for enhanced investigation and diagnosis of build > failures > * Test failure analytics to better understand trends and causes around slow, > failing, and flaky tests > If interested in exploring a fully populated Gradle Enterprise instance, > please explore the Maven builds already connected to > [ge.apache.org|https://ge.apache.org/], the [Spring project’s > instance|https://ge.spring.io/scans?search.relativeStartTime=P28D&search.timeZoneId=Europe/Zurich], > or any number of other [OSS > projects|https://gradle.com/enterprise-customers/oss-projects/] for which we > sponsor instances of Gradle Enterprise. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10445) [Geode Main] Migrate distributedTest to GHA
[ https://issues.apache.org/jira/browse/GEODE-10445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10445: --- Labels: pull-request-available (was: ) > [Geode Main] Migrate distributedTest to GHA > --- > > Key: GEODE-10445 > URL: https://issues.apache.org/jira/browse/GEODE-10445 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10442) [Geode Main] Migrate acceptanceTest to GHA
[ https://issues.apache.org/jira/browse/GEODE-10442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10442: --- Labels: pull-request-available (was: ) > [Geode Main] Migrate acceptanceTest to GHA > -- > > Key: GEODE-10442 > URL: https://issues.apache.org/jira/browse/GEODE-10442 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10441) [Geode Main] Migrate integrationTest to GHA
[ https://issues.apache.org/jira/browse/GEODE-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10441: --- Labels: pull-request-available (was: ) > [Geode Main] Migrate integrationTest to GHA > --- > > Key: GEODE-10441 > URL: https://issues.apache.org/jira/browse/GEODE-10441 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10433) Migrate to new CI
[ https://issues.apache.org/jira/browse/GEODE-10433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10433: --- Labels: pull-request-available (was: ) > Migrate to new CI > - > > Key: GEODE-10433 > URL: https://issues.apache.org/jira/browse/GEODE-10433 > Project: Geode > Issue Type: New Feature > Components: build, ci >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > > Migrating Geode CI onto Apache Infra Jenkins from sponsored Concourse infra. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10434) [Geode Main] Migrate to GH Action build & unit-test pipeline
[ https://issues.apache.org/jira/browse/GEODE-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10434: --- Labels: pull-request-available (was: ) > [Geode Main] Migrate to GH Action build & unit-test pipeline > > > Key: GEODE-10434 > URL: https://issues.apache.org/jira/browse/GEODE-10434 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10438) [Geode Benchmarks] Migrate to GH Actions
[ https://issues.apache.org/jira/browse/GEODE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679674#comment-17679674 ] ASF GitHub Bot commented on GEODE-10438: sboorlagadda merged PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170 > [Geode Benchmarks] Migrate to GH Actions > > > Key: GEODE-10438 > URL: https://issues.apache.org/jira/browse/GEODE-10438 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10438) [Geode Benchmarks] Migrate to GH Actions
[ https://issues.apache.org/jira/browse/GEODE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679370#comment-17679370 ] ASF GitHub Bot commented on GEODE-10438: sboorlagadda commented on PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170#issuecomment-1399101806 @scmbuildguy Thanks Mark for checking on this. The build passed now. Would you mind approving this PR? > [Geode Benchmarks] Migrate to GH Actions > > > Key: GEODE-10438 > URL: https://issues.apache.org/jira/browse/GEODE-10438 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Assignee: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10438) [Geode Benchmarks] Migrate to GH Actions
[ https://issues.apache.org/jira/browse/GEODE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679267#comment-17679267 ] ASF GitHub Bot commented on GEODE-10438: scmbuildguy commented on PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170#issuecomment-1398791331 Looks like the build failed in Task :harness:test task with SSH issues. I see the line for the SSH key file changed, most likely related to the test failures? > [Geode Benchmarks] Migrate to GH Actions > > > Key: GEODE-10438 > URL: https://issues.apache.org/jira/browse/GEODE-10438 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10438) [Geode Benchmarks] Migrate to GH Actions
[ https://issues.apache.org/jira/browse/GEODE-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10438: --- Labels: pull-request-available (was: ) > [Geode Benchmarks] Migrate to GH Actions > > > Key: GEODE-10438 > URL: https://issues.apache.org/jira/browse/GEODE-10438 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10437) [Geode Site] Migrate to GH Action
[ https://issues.apache.org/jira/browse/GEODE-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10437: --- Labels: pull-request-available (was: ) > [Geode Site] Migrate to GH Action > - > > Key: GEODE-10437 > URL: https://issues.apache.org/jira/browse/GEODE-10437 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10437) [Geode Site] Migrate to GH Action
[ https://issues.apache.org/jira/browse/GEODE-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678970#comment-17678970 ] ASF GitHub Bot commented on GEODE-10437: sboorlagadda merged PR #21: URL: https://github.com/apache/geode-site/pull/21 > [Geode Site] Migrate to GH Action > - > > Key: GEODE-10437 > URL: https://issues.apache.org/jira/browse/GEODE-10437 > Project: Geode > Issue Type: Sub-task >Reporter: Sai Boorlagadda >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10429) Setup up GH actions as CI solution
[ https://issues.apache.org/jira/browse/GEODE-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17619730#comment-17619730 ] ASF GitHub Bot commented on GEODE-10429: gaussianrecurrence closed pull request #987: [WIP] GEODE-10429: Setup GitHub actions URL: https://github.com/apache/geode-native/pull/987 > Setup up GH actions as CI solution > -- > > Key: GEODE-10429 > URL: https://issues.apache.org/jira/browse/GEODE-10429 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* setup the CI solution within GH actions > *SO THAT* contributions can be verified -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10429) Setup up GH actions as CI solution
[ https://issues.apache.org/jira/browse/GEODE-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616959#comment-17616959 ] ASF GitHub Bot commented on GEODE-10429: gaussianrecurrence opened a new pull request, #987: URL: https://github.com/apache/geode-native/pull/987 - Testing GHCR container packages > Setup up GH actions as CI solution > -- > > Key: GEODE-10429 > URL: https://issues.apache.org/jira/browse/GEODE-10429 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > > *AS A* geode-native contributor > *I WANT TO* setup the CI solution within GH actions > *SO THAT* contributions can be verified -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10429) Setup up GH actions as CI solution
[ https://issues.apache.org/jira/browse/GEODE-10429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10429: --- Labels: pull-request-available (was: ) > Setup up GH actions as CI solution > -- > > Key: GEODE-10429 > URL: https://issues.apache.org/jira/browse/GEODE-10429 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* setup the CI solution within GH actions > *SO THAT* contributions can be verified -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10401) Oplog recovery takes too long due to fault in fastutil library
[
https://issues.apache.org/jira/browse/GEODE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615335#comment-17615335
]
ASF GitHub Bot commented on GEODE-10401:
onichols-pivotal opened a new pull request, #986:
URL: https://github.com/apache/geode-native/pull/986
Native client hardcodes Geode version to test with in several places. Update
those variables to latest-and-greatest apache-geode 1.15.1
> Oplog recovery takes too long due to fault in fastutil library
> --
>
> Key: GEODE-10401
> URL: https://issues.apache.org/jira/browse/GEODE-10401
> Project: Geode
> Issue Type: Bug
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.1, 1.16.0
>
>
> {color:#0e101a}As we already know, the .drf file delete operations only
> contain OplogEntryID. During recovery, the server reads (byte by byte) each
> OplogEntryID and stores it in a HashSet to use later when recovering .crf
> files. There are two types of HashSets: IntOpenHashSet and LongOpenHashSet.
> The OplogEntryID of type
> {color}_{color:#0e101a}integer{color}_{color:#0e101a} will be stored in
> IntOpenHashSet, and {color}_{color:#0e101a}long
> integer{color}_{color:#0e101a} in LongOpenHashSet, probably due to memory
> optimization and performance factors. OplogEntryID starts with a zero and
> increments throughout time.
> {color}
> {color:#0e101a}We have observed in logs that between exception (There is a
> large number of deleted entries) and the previous log have passed more than 4
> minutes (sometimes even more).{color}
> {code:java}
> {"timestamp":"2022-06-14T21:41:43.772+08:00","severity":"info","message":"Recovering
> oplog#271 /opt/dbservice/data/datastore/BACKUPdataDiskStore_271.drf for disk
> store dataDiskStore.","metadata":
> {"timestamp":"2022-06-14T21:46:02.152+08:00","severity":"warning","message":"There
> is a large number of deleted entries within the disk-store, please execute
> an offline
> compaction.","metadata":
> {code}
> {color:#0e101a}When the above exception occurs, that means that the limit of
> {color}_{color:#0e101a}805306401{color}_{color:#0e101a} entries in
> IntOpenHashSet has been reached. In that case, the server rolls to the new
> IntOpenHashSet, where an exception and the delay could happen again.{color}
> {color:#0e101a}The problem is that due to the fault in FastUtil dependency
> (IntOpenHashSet and LongOpenHashSet), the unnecessary rehashing happens
> multiple times before the max size is reached. The{color}
> _{color:#0e101a}rehashing starts from{color}_ {color:#0e101a}805306368
> onwards for each new entry until the max size. This rehashing adds several
> minutes to .drf Oplog recovery, but does nothing as max is already
> reached.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10426) Make documentation generation optional
[ https://issues.apache.org/jira/browse/GEODE-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613185#comment-17613185 ] ASF GitHub Bot commented on GEODE-10426: albertogpz merged PR #985: URL: https://github.com/apache/geode-native/pull/985 > Make documentation generation optional > -- > > Key: GEODE-10426 > URL: https://issues.apache.org/jira/browse/GEODE-10426 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.16.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* native client contributor > *I WANT TO* have documentation conditionally generated > *AND* be generated by default > *SO THAT* compilation time is reduced > *AND* users do not need doxygen as dependency just to compile the library -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10426) Make documentation generation optional
[ https://issues.apache.org/jira/browse/GEODE-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613179#comment-17613179 ] ASF GitHub Bot commented on GEODE-10426: gaussianrecurrence opened a new pull request, #985: URL: https://github.com/apache/geode-native/pull/985 - Added a option in the CMake project to enable documentation generation. - In order to maintain backward compatibility, by default documentation generation is enabled. > Make documentation generation optional > -- > > Key: GEODE-10426 > URL: https://issues.apache.org/jira/browse/GEODE-10426 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.16.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > > *AS A* native client contributor > *I WANT TO* have documentation conditionally generated > *AND* be generated by default > *SO THAT* compilation time is reduced > *AND* users do not need doxygen as dependency just to compile the library -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10426) Make documentation generation optional
[ https://issues.apache.org/jira/browse/GEODE-10426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10426: --- Labels: pull-request-available (was: ) > Make documentation generation optional > -- > > Key: GEODE-10426 > URL: https://issues.apache.org/jira/browse/GEODE-10426 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.16.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* native client contributor > *I WANT TO* have documentation conditionally generated > *AND* be generated by default > *SO THAT* compilation time is reduced > *AND* users do not need doxygen as dependency just to compile the library -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[ https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613165#comment-17613165 ] ASF GitHub Bot commented on GEODE-10291: gaussianrecurrence commented on PR #968: URL: https://github.com/apache/geode-native/pull/968#issuecomment-1265076566 Hi @moleske & @pivotal-jbarrett, it seems to me that @moleke addressed all the comments, so I am not sure is this can be merged already? > Support Jammy (ubuntu 22.04) > > > Key: GEODE-10291 > URL: https://issues.apache.org/jira/browse/GEODE-10291 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > Fix For: 1.15.1, 1.16.0 > > > Native client should compile on the latest (ubuntu 22.04) operating system. > Consider including a new pipeline as part of this -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10425) Add option to suppress Krf file creation
[ https://issues.apache.org/jira/browse/GEODE-10425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10425: --- Labels: pull-request-available (was: ) > Add option to suppress Krf file creation > > > Key: GEODE-10425 > URL: https://issues.apache.org/jira/browse/GEODE-10425 > Project: Geode > Issue Type: Improvement > Components: persistence >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Add option to not create Krf file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10424) Improve parallel gateway sender logic
[ https://issues.apache.org/jira/browse/GEODE-10424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10424: --- Labels: pull-request-available (was: ) > Improve parallel gateway sender logic > - > > Key: GEODE-10424 > URL: https://issues.apache.org/jira/browse/GEODE-10424 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Improve logic of putting events in queue, for parallel gateway sender > connected to region with redundancy. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10416) Update to Boost 1.80.0
[ https://issues.apache.org/jira/browse/GEODE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10416: --- Labels: pull-request-available (was: ) > Update to Boost 1.80.0 > -- > > Key: GEODE-10416 > URL: https://issues.apache.org/jira/browse/GEODE-10416 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Weiyi Luo >Assignee: Weiyi Luo >Priority: Major > Labels: pull-request-available > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10416) Update to Boost 1.80.0
[ https://issues.apache.org/jira/browse/GEODE-10416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17608252#comment-17608252 ] ASF GitHub Bot commented on GEODE-10416: gaussianrecurrence commented on PR #983: URL: https://github.com/apache/geode-native/pull/983#issuecomment-1254954586 I think the issue you are facing for Windows compilation is the same as faced while trying to upgrade to Boost 1.79.0 in this PR #967 So, after looking into it, turns out, @moleske was in the right path, the issue has to do with _WIN32_WINNT and some issue with Boost&MSVC. Thing is boost_log was being compiled with **_WIN32_WINNT=0x0600**, even if your compilation target is >=0x0A00 (Windows 10, Windows 2016, Windows 2017, Windows 2019), and on the other side, geode-native modules using boost_log had _WIN32_WINNT defined as 0x0602 (which is a mistake btw, as, _WIN32_WINNT should fit in 16 bits, being 8 first for the major version and the 8 remaining for the minor version), causing boost_log to use **boost::log::v2s_mt_nt62** namespace, but since boost_log was compiled with **_WIN32_WINNT=0x0600**, the only available symbols in libboost_log.lib are the ones pointing to **boost::log::v2s_mt_nt6** namespace. I've tested the fix with GH actions and seems to be working: https://github.com/Nordix/geode-native/commit/0aa3d709cbcfcf915373f589e213f796cade616a#diff-3971f6cd87e6fed8494466300f14922d1869759f063ffc6170da0542d386180c In order to ensure that boost_log was compiled with _WIN32_WINNT it's needed to define **BOOST_USE_WINAPI_VERSION=0x0602** And also, right now, we haven't seen any issue because of having set _WIN32_WINNT to the wrong value to the Boost lib interface, but it'd be good to have it set to the right value, **_WIN32_WINNT=0x0602** > Update to Boost 1.80.0 > -- > > Key: GEODE-10416 > URL: https://issues.apache.org/jira/browse/GEODE-10416 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Weiyi Luo >Assignee: Weiyi Luo >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10414) Add putIfAbsent method to region interfaces
[
https://issues.apache.org/jira/browse/GEODE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606478#comment-17606478
]
ASF GitHub Bot commented on GEODE-10414:
albertogpz commented on code in PR #984:
URL: https://github.com/apache/geode-native/pull/984#discussion_r973963090
##
cppcache/integration/test/RegionPutTest.cpp:
##
@@ -0,0 +1,294 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+#include "CacheRegionHelper.hpp"
+#include "framework/Cluster.h"
+#include "framework/Framework.h"
+#include "framework/Gfsh.h"
+
+namespace {
+
+using apache::geode::client::Cache;
+using apache::geode::client::Cacheable;
+using apache::geode::client::CacheableKey;
+using apache::geode::client::CacheableString;
+using apache::geode::client::CommitConflictException;
+using apache::geode::client::Pool;
+using apache::geode::client::Region;
+using apache::geode::client::RegionShortcut;
+
+using std::chrono::minutes;
+
+using ::testing::Eq;
+using ::testing::IsNull;
+using ::testing::NotNull;
+
+Cache createCache() {
+ using apache::geode::client::CacheFactory;
+
+ auto cache = CacheFactory()
+ .set("log-level", "debug")
+ .set("statistic-sampling-enabled", "false")
+ .create();
+
+ return cache;
+}
+
+std::shared_ptr createPool(Cluster& cluster, Cache& cache) {
+ auto poolFactory = cache.getPoolManager().createFactory();
+ cluster.applyLocators(poolFactory);
+ return poolFactory.create("default");
+}
+
+std::shared_ptr setupRegion(Cache& cache,
+const std::shared_ptr& pool) {
+ auto region = cache.createRegionFactory(RegionShortcut::PROXY)
+.setPoolName(pool->getName())
+.create("region");
+
+ return region;
+}
+
+std::shared_ptr setupCachingRegion(Cache& cache,
+ const std::shared_ptr& pool) {
+ auto region = cache.createRegionFactory(RegionShortcut::CACHING_PROXY)
+.setPoolName(pool->getName())
+.create("region");
+
+ return region;
+}
+
+TEST(RegionPutTest, testPutIfAbsentNotExistingEntry) {
+ Cluster cluster{LocatorCount{1}, ServerCount{1}};
+
+ cluster.start();
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("region")
+ .withType("REPLICATE")
+ .execute();
+
+ auto cache = createCache();
+ auto pool = createPool(cluster, cache);
+ auto region = setupRegion(cache, pool);
+ auto key = CacheableKey::create("key-1");
+ auto value = CacheableString::create("value");
+
+ EXPECT_THAT(region->putIfAbsent(key, value), IsNull());
+
+ auto retrieved = region->get(key);
+ EXPECT_THAT(retrieved, NotNull());
+
+ auto converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->toString(), Eq(value->toString()));
+}
+
+TEST(RegionPutTest, testPutIfAbsentNotExistingEntryWithCaching) {
+ Cluster cluster{LocatorCount{1}, ServerCount{1}};
+
+ cluster.start();
+
+ cluster.getGfsh()
+ .create()
+ .region()
+ .withName("region")
+ .withType("REPLICATE")
+ .execute();
+
+ auto cache = createCache();
+ auto pool = createPool(cluster, cache);
+ auto region = setupCachingRegion(cache, pool);
+ auto key = CacheableKey::create("key-1");
+ auto value = CacheableString::create("value");
+
+ EXPECT_THAT(region->putIfAbsent(key, value), IsNull());
+
+ auto retrieved = region->get(key);
+ EXPECT_THAT(retrieved, NotNull());
+
+ auto converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->toString(), Eq(value->toString()));
+
+ // Verify cached value matches expected
+ auto entry = region->getEntry(key);
+ EXPECT_THAT(entry, NotNull());
+
+ retrieved = entry->getValue();
+ EXPECT_THAT(converted, NotNull());
+
+ converted = std::dynamic_pointer_cast(retrieved);
+ EXPECT_THAT(converted, NotNull());
+ EXPECT_THAT(converted->to
[jira] [Updated] (GEODE-10423) Document the system property “ON_DISCONNECT_CLEAR_PDXTYPEIDS“
[ https://issues.apache.org/jira/browse/GEODE-10423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10423: --- Labels: pull-request-available (was: ) > Document the system property “ON_DISCONNECT_CLEAR_PDXTYPEIDS“ > - > > Key: GEODE-10423 > URL: https://issues.apache.org/jira/browse/GEODE-10423 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Tim Zhang >Priority: Major > Labels: pull-request-available > > Document the java system property “ON_DISCONNECT_CLEAR_PDXTYPEIDS“, this > property is used by Java client. add instructions for using this property. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[
https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605444#comment-17605444
]
ASF GitHub Bot commented on GEODE-10291:
moleske commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r972202959
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
ah joys of forgetting about prs for months on end, can bump it
> Support Jammy (ubuntu 22.04)
>
>
> Key: GEODE-10291
> URL: https://issues.apache.org/jira/browse/GEODE-10291
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Oleske
>Priority: Major
> Labels: pull-request-available
>
> Native client should compile on the latest (ubuntu 22.04) operating system.
> Consider including a new pipeline as part of this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[ https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605438#comment-17605438 ] ASF GitHub Bot commented on GEODE-10291: moleske merged PR #966: URL: https://github.com/apache/geode-native/pull/966 > Support Jammy (ubuntu 22.04) > > > Key: GEODE-10291 > URL: https://issues.apache.org/jira/browse/GEODE-10291 > Project: Geode > Issue Type: Task > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Native client should compile on the latest (ubuntu 22.04) operating system. > Consider including a new pipeline as part of this -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605351#comment-17605351 ] ASF GitHub Bot commented on GEODE-9896: --- pivotal-jbarrett closed pull request #899: GEODE-9896: Upgrades dependencies. URL: https://github.com/apache/geode-native/pull/899 > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-9896) Upgrade dependencies
[ https://issues.apache.org/jira/browse/GEODE-9896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605299#comment-17605299 ] ASF GitHub Bot commented on GEODE-9896: --- gaussianrecurrence commented on PR #899: URL: https://github.com/apache/geode-native/pull/899#issuecomment-1248021514 Considering geode-native is not using ACE anymore and SQLite was already updated, and also there is another PR to update Boost, maybe this can be closed @pivotal-jbarrett ? > Upgrade dependencies > > > Key: GEODE-9896 > URL: https://issues.apache.org/jira/browse/GEODE-9896 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > * ACE 7.0.5 > * Boost 1.78.0 > * SQLite 3.37 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10291) Support Jammy (ubuntu 22.04)
[
https://issues.apache.org/jira/browse/GEODE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605283#comment-17605283
]
ASF GitHub Bot commented on GEODE-10291:
gaussianrecurrence commented on code in PR #968:
URL: https://github.com/apache/geode-native/pull/968#discussion_r971864236
##
docker/ubuntu-22.04/Dockerfile:
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+FROM ubuntu:22.04
+LABEL maintainer Apache Geode
+
+USER root
+WORKDIR /
+
+ENV DEBIAN_FRONTEND noninteractive
+RUN apt update && \
+apt -yq full-upgrade && \
+apt-get -y install \
+apt-transport-https \
+ca-certificates \
+curl \
+gnupg2 \
+software-properties-common && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+RUN . /etc/os-release && \
+curl -s https://download.bell-sw.com/pki/GPG-KEY-bellsoft | apt-key add -
&& \
+apt-add-repository "deb http://apt.bell-sw.com/ stable main"
+
+RUN apt update && apt -yq full-upgrade && apt-get -y install \
+build-essential \
+libc++-dev \
+libc++abi-dev \
+zlib1g-dev \
+libssl-dev \
+bellsoft-java11 \
+git \
+doxygen \
+graphviz \
+clang-format-12 && \
+apt-get -y autoremove && \
+apt-get autoclean
+
+# Get latest release of CMake ignoring pre-releases
+RUN installer=$(mktemp) \
+&& curl -o ${installer} -L $(curl -s
https://api.github.com/repos/Kitware/CMake/releases \
+| grep -P -i
'browser_download_url.*cmake-\d+\.\d+\.\d+-linux-x86_64\.sh' \
+| head -n 1 \
+| cut -d : -f 2,3 \
+| tr -d '"') \
+&& bash ${installer} --skip-license --prefix=/usr/local \
+&& rm ${installer}
+
+ARG GEODE_VERSION=1.14.4
Review Comment:
Considering latest version is 1.15.0, maybe this needs to be updated
> Support Jammy (ubuntu 22.04)
>
>
> Key: GEODE-10291
> URL: https://issues.apache.org/jira/browse/GEODE-10291
> Project: Geode
> Issue Type: Task
> Components: native client
>Reporter: Michael Oleske
>Priority: Major
> Labels: pull-request-available
>
> Native client should compile on the latest (ubuntu 22.04) operating system.
> Consider including a new pipeline as part of this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10422) Add doc for using parallel recovery disk store
[ https://issues.apache.org/jira/browse/GEODE-10422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10422: --- Labels: pull-request-available (was: ) > Add doc for using parallel recovery disk store > -- > > Key: GEODE-10422 > URL: https://issues.apache.org/jira/browse/GEODE-10422 > Project: Geode > Issue Type: Improvement > Components: docs >Affects Versions: 1.14.0, 1.15.0 >Reporter: Mario Kevo >Assignee: Mario Kevo >Priority: Major > Labels: pull-request-available > > There are missing part for parallel recovery of disk stores. > It isn't specified that in case the user use the same disk store for the pdx > and the region, disk store recovery will go in the sequential mode. So in > case you want to use parallel disk store recovery it should be different disk > stores for the pdx and the disk store. Otherwise, it will go sequentially, > despite of default behavior to run in the parallel mode. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10410) Rebalance Guard Prevent Lost Bucket Recovery
[ https://issues.apache.org/jira/browse/GEODE-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10410: --- Labels: needsTriage pull-request-available (was: needsTriage) > Rebalance Guard Prevent Lost Bucket Recovery > > > Key: GEODE-10410 > URL: https://issues.apache.org/jira/browse/GEODE-10410 > Project: Geode > Issue Type: Bug >Reporter: Weijie Xu >Assignee: Weijie Xu >Priority: Major > Labels: needsTriage, pull-request-available > Attachments: server2.log, test.tar.gz > > > Following steps reproduce the issue: > Run the start.gfsh in the attached example, which configures a geode system > with a partitioned region and a gateway sender. So there are two regions, the > manually created region, and the queue region. > Then run the example code, which will source ~400M data and 5 times amount of > events into the system. All data are sourced into the system, no bucket lost, > and no out of memory. > Then stop one of the server, and revoke the disk file of the server. > Then start the server, which will trigger a bucket recovery. After that, > there will be part of secondary bucket lost. > gfsh>show metrics --region=/example-region > | numBucketsWithoutRedundancy | 63 > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10421) Enhancment of start gw sender with clean-queue
[ https://issues.apache.org/jira/browse/GEODE-10421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10421: --- Labels: pull-request-available (was: ) > Enhancment of start gw sender with clean-queue > -- > > Key: GEODE-10421 > URL: https://issues.apache.org/jira/browse/GEODE-10421 > Project: Geode > Issue Type: Improvement > Components: gfsh, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Reject command if gateway sender is not stopped on all servers. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10402) Fix FunctionException handling
[ https://issues.apache.org/jira/browse/GEODE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603521#comment-17603521 ] ASF GitHub Bot commented on GEODE-10402: albertogpz merged PR #981: URL: https://github.com/apache/geode-native/pull/981 > Fix FunctionException handling > -- > > Key: GEODE-10402 > URL: https://issues.apache.org/jira/browse/GEODE-10402 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* a ServerFunction throwing a FunctionException > *WHEN* its executed > *THEN* a CacheServerException is thrown rather FunctionException > > *Additional info.* FunctionException seems not to be handled, that's why the > default handling exception is thrown by the native API, CacheServerException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10415) CVEs detected in latest geode
[
https://issues.apache.org/jira/browse/GEODE-10415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10415:
---
Labels: needsTriage pull-request-available (was: needsTriage)
> CVEs detected in latest geode
> -
>
> Key: GEODE-10415
> URL: https://issues.apache.org/jira/browse/GEODE-10415
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.15.0
>Reporter: Shruti
>Assignee: Mario Kevo
>Priority: Blocker
> Labels: needsTriage, pull-request-available
>
> We are detecting the following CVEs with geode
> 💥 High or critical vulnerabilities: 21
> The spring-core is likely Not Affected. But we would like to know about the
> rest of these listed CVEs. Any info is appreciated
> {{ }}
> {{NAME INSTALLED FIXED-IN TYPE
> VULNERABILITY SEVERITY}}
> {{jetty-security 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-server 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-servlet 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-util 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-util-ajax 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-webapp 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-xml 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jgroups 3.6.14.Final 4.0.0
> java-archive GHSA-rc7h-x6cq-988q Critical}}
> {{shiro-cache 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-config-core 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-config-ogdl 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-core 1.9.0 1.9.1
> java-archive GHSA-4cf5-xmhp-3xj7 Critical}}
> {{shiro-core 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-crypto-cipher 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-crypto-core 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-crypto-hash 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-event 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{shiro-lang 1.9.0
> java-archive CVE-2022-32532 Critical}}
> {{spring-core 5.3.20
> java-archive CVE-2016-127 Critical}}
> {{jetty-http 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
> {{jetty-io 9.4.46.v20220331
> java-archive CVE-2022-2048 High}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10414) Add putIfAbsent method to region interfaces
[ https://issues.apache.org/jira/browse/GEODE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603015#comment-17603015 ] ASF GitHub Bot commented on GEODE-10414: gaussianrecurrence opened a new pull request, #984: URL: https://github.com/apache/geode-native/pull/984 - Moved PUT actions from LocalRegion into its own modules. - Added PutIfAbsent action. - Added the necessary scaffolding for put requests to return a value. - Moved TcrMessagePut implementation into its own file. Now this message type accepts an operation as input. - Moved TcrMessageDestroy implementation into its own file. Now this message accepts an operation as input. - Also, updated TcrMessageDestroy operation format so it uses a byte part instead of an object. - Added putIfAbsent method to the Region interface and its implementations both for LocalRegion and ThinClientRegion. - Modified LocalRegion and ThinClientRegion to comply with the above code changes. - Modified PUT's old value parsing to handle null pointer. - Also replaced Cacheable type by Serializable in some places in order in order to take advantage of fast-forward definition. > Add putIfAbsent method to region interfaces > --- > > Key: GEODE-10414 > URL: https://issues.apache.org/jira/browse/GEODE-10414 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > > *AS A* geode-native contributor > *I WANT TO* have putIfAbsent region method implemented > *SO THAT* I can atomically put entries only if they don't previously, exist > and also, to align it with the Java API. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10414) Add putIfAbsent method to region interfaces
[ https://issues.apache.org/jira/browse/GEODE-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10414: --- Labels: pull-request-available (was: ) > Add putIfAbsent method to region interfaces > --- > > Key: GEODE-10414 > URL: https://issues.apache.org/jira/browse/GEODE-10414 > Project: Geode > Issue Type: New Feature > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > *AS A* geode-native contributor > *I WANT TO* have putIfAbsent region method implemented > *SO THAT* I can atomically put entries only if they don't previously, exist > and also, to align it with the Java API. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10420) Handle WAN event when interrupted
[ https://issues.apache.org/jira/browse/GEODE-10420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10420: --- Labels: needsTriage pull-request-available (was: needsTriage) > Handle WAN event when interrupted > - > > Key: GEODE-10420 > URL: https://issues.apache.org/jira/browse/GEODE-10420 > Project: Geode > Issue Type: Bug >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > It is possible that an event of which a gateway sender is to be notified is > lost if during the process the thread is interrupted. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10419) Enhancment of backup disk-store command
[ https://issues.apache.org/jira/browse/GEODE-10419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10419: --- Labels: pull-request-available (was: ) > Enhancment of backup disk-store command > --- > > Key: GEODE-10419 > URL: https://issues.apache.org/jira/browse/GEODE-10419 > Project: Geode > Issue Type: Improvement > Components: gfsh, persistence >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > Add additional option to perform backup only for specified disk-store(s). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10331) DistributionImpl.destroyMember keeps cache alive for some number of seconds
[ https://issues.apache.org/jira/browse/GEODE-10331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10331: --- Labels: blocks-1.16.0 pull-request-available (was: blocks-1.16.0) > DistributionImpl.destroyMember keeps cache alive for some number of seconds > --- > > Key: GEODE-10331 > URL: https://issues.apache.org/jira/browse/GEODE-10331 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Darrel Schneider >Assignee: Mario Ivanac >Priority: Major > Labels: blocks-1.16.0, pull-request-available > > org.apache.geode.distributed.internal.DistributionImpl.destroyMember creates > a thread that will hold onto the DIstributesSystem/Cache through the > DirectChannel it has for 3 seconds by default. It could be even longer if > p2p.disconnectDelay is set to a value > 3000. > This can be a problem if the JVM is trying to reconnect since this old cache > uses memory. > Instead of creating a new thread for every call of destroyMember, we should > just have a single ScheduledExecutor that we schedule the background > "closeEndpoint" with. > Also since all this code interacts with the DirectChannel all the logic about > the executor and scheduling it should belong to DirectChannel, not the > DistributionImpl. > When the DirectChannel has disconnect called on it, then it should get rid of > all the tasks scheduled in the executor since they are no longer needed. > I think this issue has been around for a long time because the creation of > the thread refers to fixing "Bug 37944" which is on old bug system that is > not longer used for geode. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10395) TXLockIdImpl memory leak after CommitConflictException from another node
[
https://issues.apache.org/jira/browse/GEODE-10395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10395:
---
Labels: pull-request-available (was: )
> TXLockIdImpl memory leak after CommitConflictException from another node
>
>
> Key: GEODE-10395
> URL: https://issues.apache.org/jira/browse/GEODE-10395
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.14.0, 1.15.0
>Reporter: Eugene Nedzvetsky
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> org.apache.geode.internal.cache.locks.TXLockServiceImpl#txLock:120 adds
> TXLockIdImpl objects to TXLockServiceImpl#txLockIdList.
> {code:java}
> synchronized (txLockIdList) {
> txLockId = new TXLockIdImpl(dlock.getDistributionManager().getId());
> txLockIdList.add(txLockId);
> }
> {code}
> These objects will not be removed from this list if dlock.acquireTryLocks
> returned false.
> {code:java}
> gotLocks = dlock.acquireTryLocks(batch, TIMEOUT_MILLIS, LEASE_MILLIS,
> keyIfFail);
> if (gotLocks) { // ...otherwise race can occur between tryLocks and
> readLock
> acquireRecoveryReadLock();
> } else if (keyIfFail[0] != null) {
> throw new CommitConflictException(
> String.format("Concurrent transaction commit detected %s",
> keyIfFail[0]));
> } else {
> throw new CommitConflictException(
> String.format("Failed to request try locks from grantor: %s",
> dlock.getLockGrantorId()));
> }
> {code}
> It throws CommitConflictException and after that system doesn't have a
> txLockId reference and this txLockId will be never removed from this list.
> It produces critical performance degradation. txLockIdList has a few hundred
> thousand txLocks after a few weeks and TXLockServiceImpl#release iterates
> this list 2 times on every tx commit and the same time "synchronized
> (txLockIdList)" locks other threads.
> TXLockIdImpl#equals works really slow because it checks bunch of variables in
> memberId.equals(that.memberId).
> {code:java}
> public void release(TXLockId txLockId) {
> synchronized (txLockIdList) {
> if (!txLockIdList.contains(txLockId)) {
> // TXLockService.destroyServices can be invoked in cache.close().
> // Other P2P threads could process message such as TXCommitMessage
> afterwards,
> // and invoke TXLockService.createDTLS(). It could create a new
> TXLockService
> // which will have a new empty list (txLockIdList) and it will not
> // contain the originally added txLockId
> throw new IllegalArgumentException(
> String.format("Invalid txLockId not found: %s",
> txLockId));
> }
> dlock.releaseTryLocks(txLockId, () -> {
> return recovering;
> });
> txLockIdList.remove(txLockId);
> releaseRecoveryReadLock();
> }
> }
> {code}
> I think TXLockServiceImpl#txLock should remove this txLockId from
> TXLockServiceImpl#txLockIdList in case of CommitConflictException:
> {code:java}
> if (gotLocks) { // ...otherwise race can occur between tryLocks and readLock
> acquireRecoveryReadLock();
> } else if (keyIfFail[0] != null) {
> synchronized (this.txLockIdList) {
> this.txLockIdList.remove(txLockId);
> }
> throw new CommitConflictException(
> String.format("Concurrent transaction commit detected
> %s",
> keyIfFail[0]));
> } else {
> synchronized (this.txLockIdList) {
> this.txLockIdList.remove(txLockId);
> }
> throw new CommitConflictException(
> String.format("Failed to request try locks from
> grantor: %s",
> this.dlock.getLockGrantorId()));
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10417) Fix NullPointerException when getting events from the gw sender queue to complete transactions
[ https://issues.apache.org/jira/browse/GEODE-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10417: --- Labels: needsTriage pull-request-available (was: needsTriage) > Fix NullPointerException when getting events from the gw sender queue to > complete transactions > -- > > Key: GEODE-10417 > URL: https://issues.apache.org/jira/browse/GEODE-10417 > Project: Geode > Issue Type: Bug > Components: wan >Affects Versions: 1.13.8, 1.14.4, 1.15.0 >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: needsTriage, pull-request-available > > When the WAN group-transaction-events feature is enabled in a parallel > gateway sender, it is possible to get a NullPointerException when retrieving > events from the queue to complete a transaction if the event in the queue is > null. > If this situation is reached then the gateway sender dispatcher will not > dispatch queue events anymore and therefore the WAN replication will not > progress. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10335) TXManagerImpl.close does not remove itself from the static singeton
[ https://issues.apache.org/jira/browse/GEODE-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10335: --- Labels: blocks-1.16.0 pull-request-available (was: blocks-1.16.0) > TXManagerImpl.close does not remove itself from the static singeton > --- > > Key: GEODE-10335 > URL: https://issues.apache.org/jira/browse/GEODE-10335 > Project: Geode > Issue Type: Bug > Components: transactions >Reporter: Darrel Schneider >Assignee: Mario Ivanac >Priority: Major > Labels: blocks-1.16.0, pull-request-available > > TXManagerImpl.close does not remove itself from the static singleton. This > causes it to keep the GemFireCacheImpl alive after it has been closed. > The simple fix is to add "currentInstance = null" at the end of the close > method. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10336) ConnectionTable.close does not null out its static lastInstance field
[ https://issues.apache.org/jira/browse/GEODE-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10336: --- Labels: blocks-1.16.0 pull-request-available (was: blocks-1.16.0) > ConnectionTable.close does not null out its static lastInstance field > - > > Key: GEODE-10336 > URL: https://issues.apache.org/jira/browse/GEODE-10336 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Darrel Schneider >Assignee: Mario Ivanac >Priority: Major > Labels: blocks-1.16.0, pull-request-available > > The ConnectionTable.close method does a bunch of work but it does not null > out the static "lastInstance" atomic. This causes it to keep the > ConnectionTable alive which ends up keeping the InternalDistributedSystem > alive. > The easiest fix is to do this at the end of close: "emergencyClose();". The > emergencyClose correctly set the lastInstance atomic to null. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10337) SocketCreatorFactory does not null out instance static
[
https://issues.apache.org/jira/browse/GEODE-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10337:
---
Labels: blocks-1.16.0 pull-request-available (was: blocks-1.16.0)
> SocketCreatorFactory does not null out instance static
> --
>
> Key: GEODE-10337
> URL: https://issues.apache.org/jira/browse/GEODE-10337
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Darrel Schneider
>Assignee: Mario Ivanac
>Priority: Major
> Labels: blocks-1.16.0, pull-request-available
>
> The SocketCreatorFactory has a static "instance" field that keeps the
> singleton factory. The factory has a reference in "distributionConfig" that
> ends up keeping the InternalDistributedSystem alive after disconnect.
> It also has a static close method but the product never calls it.
> To fix this leak do the following:
> On InternalDistributedSystem.disconnect add to the end of it:
> {code:java}
> if (!attemptingToReconnect) {
> SocketCreatorFactory.close();
> }
> {code}
> Also I think it would be good to change SocketCreatorFactory.getInstance to
> null out the static when close it called like so:
> {code:java}
> private static synchronized SocketCreatorFactory getInstance(boolean
> closing) {
> SocketCreatorFactory result = instance;
> if (result == null && !closing) {
> result = new SocketCreatorFactory();
> instance = result;
> } else if (result != null && closing) {
> instance = null;
> }
> return result;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10339) The server fails to start because the .crf or the .drf file is missing
[
https://issues.apache.org/jira/browse/GEODE-10339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10339:
---
Labels: pull-request-available (was: )
> The server fails to start because the .crf or the .drf file is missing
> --
>
> Key: GEODE-10339
> URL: https://issues.apache.org/jira/browse/GEODE-10339
> Project: Geode
> Issue Type: Bug
>Reporter: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
>
> {color:#0e101a}The server fails with following:{color}
> {code:java}
> {"timestamp":"2022-05-16T08:25:35.708Z","severity":"error","message":"Cache
> initialization for GemFireCache[id = 776315735; isClosing = false;
> isShutDownAll = false; created = Mon May 16 08:25:33 UTC 2022; server =
> false; copyOnRead = false; lockLease = 120; lockTimeout = 60] failed because:
> java.lang.IllegalStateException: The following required files could not be
> found: *.crf files with these ids:
> [33].","metadata":{"function":"KVDB"},"version":"1.1.0","service_id":"eric-udr-kvdb-ag","extra_data":{"thread_info":{"thread_name":"main","thread_id":"1"},"e":{"exception":""}}}
> {code}
>
> {color:#0e101a}As a last compaction step, the server deletes the compacted
> .crf file. The deletion is done in the following way:{color}
> # {color:#0e101a}Write delete operation (delete ".crf" file) in the ".if"
> file. {color}
> # {color:#0e101a}Delete .crf file{color}
> {color:#0e101a}The problem with server startup happens in the following
> scenario:{color}
> # {color:#0e101a}The server writes the delete operation (for .crf file) in
> the ".if" file. The write is not immediately flushed to the ".if" file, but
> it goes to the async write buffer.{color}
> # {color:#0e101a}The server deletes the ".crf" file.{color}
> # {color:#0e101a}The forceful restart (of the machine where the server
> resides) happens before the async write buffer is flushed to the ".if" file.
> This scenario leaves the ".if" file not updated, and therefore server startup
> fails later on from the persisted region data.{color}
>
> {color:#0e101a}To avoid the above issue, we can use the existing parameter in
> a geode that forces the server to write synchronously to the ".if"
> file:{color}
> {code:java}
> --J=-Dgemfire.syncMetaDataWrites=true
> {code}
> {color:#0e101a}This parameter is not mentioned anywhere in the documentation.
> So it would be good to add it to the following document:{color}
> {color:#0e101a}[https://geode.apache.org/docs/guide/114/managing/disk_storage/managing_disk_buffer_flushes.html]{color}
>
> {color:#0e101a}Changing this parameter's default value to true would also be
> good. {color}{color:#0e101a}This parameter should not affect performance as
> the ".if" file is not updated frequently.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10412) Destry region command doesn't clear the region related expired tombstones
[
https://issues.apache.org/jira/browse/GEODE-10412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10412:
---
Labels: pull-request-available (was: )
> Destry region command doesn't clear the region related expired tombstones
> -
>
> Key: GEODE-10412
> URL: https://issues.apache.org/jira/browse/GEODE-10412
> Project: Geode
> Issue Type: Bug
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
>
> Tombstones in geode are kept on two maps: expiredTombstones and tombstones
> (non-expired ones). When a region is destroyed, it must clear all the related
> expired and non-expired tombstones from memory. Due to the below code bug,
> expired tombstones aren't cleared when non-expired tombstones are available
> during the region destruction:
> {code:java}
> private boolean removeIf(Predicate predicate) {
> return removeUnexpiredIf(predicate) || removeExpiredIf(predicate);
> }
> {code}
> Because of the above, non-expired tombstones are never removed from memory,
> preventing other tombstones from being cleared. Since other tombstones never
> expire, the compaction is not done, and therefore the disk is filled, causing
> the issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10409) Rebalance Model Missing Collocated Regions At Server Startup
[ https://issues.apache.org/jira/browse/GEODE-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10409: --- Labels: needsTriage pull-request-available (was: needsTriage) > Rebalance Model Missing Collocated Regions At Server Startup > > > Key: GEODE-10409 > URL: https://issues.apache.org/jira/browse/GEODE-10409 > Project: Geode > Issue Type: Bug >Reporter: Weijie Xu >Priority: Major > Labels: needsTriage, pull-request-available > Attachments: server2.log, test.tar.gz > > > Following steps reproduce the issue: > Run the start.gfsh in the attached example, which configures a geode system > with a partitioned region, a gateway sender and a collocated region with the > partitioned region. So there are three regions totally, the leader region, > the collcated region and the queue region. > Then run the example code, which will source ~400M data and 5 times amount of > events into the system. > Then stop one of the server, and revoke the disk file of the server. > Then start the server, which will trigger a bucket recovery. > From the attached log line596, line598 and line5958, we can see that the > queue region is not included in the rebalance model, either in the data size > colum nor in the max size colum. > Then do a manual rebalance after the server is up, this time log shows the > queue region is added to the model.(line6010, line6012, lin6014 and line6028) > > The inconsistent behavior will lead to 2 negative results: > 1) Different result of rebalance between server startup phase and manual > trigger, startup rebalance tells everything is OK, rebalance finished, but > manual trigger rebalance tells space not enough since it included the queue > region into the model which has 5 times data size as the leader region. > 2) A dismatch between the rebalance model and the actual data being > rebalanced(Actually the queue region data is rebalanced although the region > is not included in the model at server startup phase). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10411) XSS vulnerabiltiy in Pulse data browser
[ https://issues.apache.org/jira/browse/GEODE-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10411: --- Labels: needsTriage pull-request-available (was: needsTriage) > XSS vulnerabiltiy in Pulse data browser > --- > > Key: GEODE-10411 > URL: https://issues.apache.org/jira/browse/GEODE-10411 > Project: Geode > Issue Type: Bug > Components: pulse >Affects Versions: 1.12.9, 1.12.10, 1.14.4, 1.14.5, 1.15.0, 1.15.1, 1.16.0 >Reporter: Joris Melchior >Assignee: Joris Melchior >Priority: Major > Labels: needsTriage, pull-request-available > > # Description: > Stored XSS via data injection into Geode database, the injected > payload eventually gets executed on Pulse web application when the > admin querying data from Geode. > # PoC: > Step 1: With Geode up and running, run gfsh command to get into > interactive mode: > shell$ gfsh > Step 2: In gfsh console, execute the following command to insert a > data entry into regionA (assume that regionA is created before). Note > that the value of this data entry contains JavaScript code: > gfsh> put --region=regionA --key="test" --value="alert(1)" > Step 3: Open browser to query editor of Pulse web application at > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2F192.168.93.153%3A7070%2Fpulse%2FdataBrowser.html&data=05%7C01%7Cbakera%40vmware.com%7Cc06e6de8d92c4519303708da54fa7d03%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637915732081233095%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ykaOkxe1hlaE7xl8XQNgBQz2%2Ful1QPxrUChoBkuaeyY%3D&reserved=0 > (assume that already > logged in as admin), execute the following query: > SELECT * FROM /regionA > Step 4: Data from regionA will be retrieved, the XSS payload > eventually get executed > # Why this is an issue? > Developer maybe saves user-controlled data to Geode database, users > maybe submit data via an arbitrary client application (for example, a > web application), the use of gfsh console just simplifies the PoC. > # IMPACT: > Exploiting this XSS vulnerability, an attacker can steal the admin's > session cookie, therefore take over the admin account. > # CVSS: 7.6 HIGH > (https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.first.org%2Fcvss%2Fcalculator%2F3.0%23CVSS%3A3.0%2FAV%3AN%2FAC%3AL%2FPR%3AN%2FUI%3AR%2FS%3AU%2FC%3AH%2FI%3AL%2FA%3AL&data=05%7C01%7Cbakera%40vmware.com%7Cc06e6de8d92c4519303708da54fa7d03%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637915732081233095%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=W5dDA8kMdT1IVeUVX6mhWHhZ2HnAZbXErEB%2F0Tjs5hg%3D&reserved=0 > ) > (re-calculate if not correct) > # Fix: > The Pulse web application must URL encode data retrieved from Geode database. > # Credit: > The issue is found by Nguyen Thai Hung (@nth347), Viettel Cyber Security. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10400) Function execution triggering internal exception
[ https://issues.apache.org/jira/browse/GEODE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10400: --- Labels: needsTriage pull-request-available (was: needsTriage) > Function execution triggering internal exception > > > Key: GEODE-10400 > URL: https://issues.apache.org/jira/browse/GEODE-10400 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* a cluster with at least 3 members > *AND* a partitioned region with 1 redundant-copy > *AND* a server function called *JustAFunction* with isHA=false, > hasResult=true, optimizeForWrite=true > *AND* a native client configured to connect to the above cluster with a pool > using PR-Single-Hop=true > *WHEN* *JustAFunction* is executed with onRegion and no filters > *IF* the client has partial metadata due to the cluster starting up or a > rebalance occurring > *THEN* and exception of type > *"org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException: > Multiple target nodes found for single hop operation"* is thrown by one of > the servers > --- > *Additional information.* Currently, in geode-native whenever the metadata > information is incomplete, and the user tries to execute the server function > with onRegion and no filters, a request of type > EXECUTE_REGION_FUNCTION_SINGLE_HOP is sent to each node. > But the issue is that bucket partition used by the client is incorrect, > leading consequently to the mentioned exception. > *Potential solution.* The potential solution would be to detect that the > metadata is incomplete before actually executing the function and send a > EXECUTE_REGION_FUNCTION request to one of the cluster nodes instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10400) Function execution triggering internal exception
[ https://issues.apache.org/jira/browse/GEODE-10400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583483#comment-17583483 ] ASF GitHub Bot commented on GEODE-10400: gaussianrecurrence opened a new pull request, #982: URL: https://github.com/apache/geode-native/pull/982 - Whenever execution server functions with isHA=false, hasResult=true and optimizeForWrite=true, if the metadata is incomplete a request of type EXECUTE_REGION_FUNCTION_SINGLE_HOP is sent with an invalid bucket set partition. This causes an InternalFunctionInvocationTargetException exception - In order to solve this issue, now, whenever calling groupByServerToBuckets, if there isn't a valid location for one of the buckets, it returns nullptr, triggering the fallback mechanism which would be sending EXECUTE_REGION_FUNCTION to one of the nodes instead. > Function execution triggering internal exception > > > Key: GEODE-10400 > URL: https://issues.apache.org/jira/browse/GEODE-10400 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage > > *GIVEN* a cluster with at least 3 members > *AND* a partitioned region with 1 redundant-copy > *AND* a server function called *JustAFunction* with isHA=false, > hasResult=true, optimizeForWrite=true > *AND* a native client configured to connect to the above cluster with a pool > using PR-Single-Hop=true > *WHEN* *JustAFunction* is executed with onRegion and no filters > *IF* the client has partial metadata due to the cluster starting up or a > rebalance occurring > *THEN* and exception of type > *"org.apache.geode.internal.cache.execute.InternalFunctionInvocationTargetException: > Multiple target nodes found for single hop operation"* is thrown by one of > the servers > --- > *Additional information.* Currently, in geode-native whenever the metadata > information is incomplete, and the user tries to execute the server function > with onRegion and no filters, a request of type > EXECUTE_REGION_FUNCTION_SINGLE_HOP is sent to each node. > But the issue is that bucket partition used by the client is incorrect, > leading consequently to the mentioned exception. > *Potential solution.* The potential solution would be to detect that the > metadata is incomplete before actually executing the function and send a > EXECUTE_REGION_FUNCTION request to one of the cluster nodes instead. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10402) Fix FunctionException handling
[ https://issues.apache.org/jira/browse/GEODE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10402: --- Labels: needsTriage pull-request-available (was: needsTriage) > Fix FunctionException handling > -- > > Key: GEODE-10402 > URL: https://issues.apache.org/jira/browse/GEODE-10402 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* a ServerFunction throwing a FunctionException > *WHEN* its executed > *THEN* a CacheServerException is thrown rather FunctionException > > *Additional info.* FunctionException seems not to be handled, that's why the > default handling exception is thrown by the native API, CacheServerException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10402) Fix FunctionException handling
[ https://issues.apache.org/jira/browse/GEODE-10402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17583458#comment-17583458 ] ASF GitHub Bot commented on GEODE-10402: gaussianrecurrence opened a new pull request, #981: URL: https://github.com/apache/geode-native/pull/981 - Fixed handling for FunctionException. - Added InternalFunctionInvocationTargetException and replaced GF_FUNCTION_EXCEPTION by GF_INTERNAL_FUNCTION_INVOCATION_TARGET_EXCEPTION, so function exceptions are properly handled. - Code modified to adapt to the above changes. > Fix FunctionException handling > -- > > Key: GEODE-10402 > URL: https://issues.apache.org/jira/browse/GEODE-10402 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage > > *GIVEN* a ServerFunction throwing a FunctionException > *WHEN* its executed > *THEN* a CacheServerException is thrown rather FunctionException > > *Additional info.* FunctionException seems not to be handled, that's why the > default handling exception is thrown by the native API, CacheServerException -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[ https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581203#comment-17581203 ] ASF GitHub Bot commented on GEODE-10300: albertogpz merged PR #970: URL: https://github.com/apache/geode-native/pull/970 > C++ Native client messages coming from the locator cannot be longer than 3000 > bytes > --- > > Key: GEODE-10300 > URL: https://issues.apache.org/jira/browse/GEODE-10300 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > If a locator sends a response to the C++ native client that is longer than > 3000 bytes the C++ native client library will only read the first 3000 bytes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580904#comment-17580904
]
ASF GitHub Bot commented on GEODE-10300:
albertogpz commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r948236611
##
cppcache/src/StreamDataInput.cpp:
##
@@ -60,9 +58,7 @@ void StreamDataInput::readDataIfNotAvailable(size_t size) {
.c_str(),
std::chrono::duration_cast(timeSpent)
.count(),
-std::chrono::duration_cast(
-remainingTimeBeforeTimeout_)
-.count());
+remainingTimeBeforeTimeout_.count());
if (remainingTimeBeforeTimeout_ <= std::chrono::milliseconds ::zero()) {
Review Comment:
Weird...
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580897#comment-17580897
]
ASF GitHub Bot commented on GEODE-10300:
pivotal-jbarrett commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r948230496
##
cppcache/src/StreamDataInput.cpp:
##
@@ -60,9 +58,7 @@ void StreamDataInput::readDataIfNotAvailable(size_t size) {
.c_str(),
std::chrono::duration_cast(timeSpent)
.count(),
-std::chrono::duration_cast(
-remainingTimeBeforeTimeout_)
-.count());
+remainingTimeBeforeTimeout_.count());
if (remainingTimeBeforeTimeout_ <= std::chrono::milliseconds ::zero()) {
Review Comment:
Surprised the formatter didn't catch this but what's with the space between
milliseconds and zero?
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580847#comment-17580847
]
ASF GitHub Bot commented on GEODE-10300:
pivotal-jbarrett commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r948127352
##
cppcache/src/StreamDataInput.cpp:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "StreamDataInput.hpp"
+
+#include
+
+#include "Utils.hpp"
+#include "util/Log.hpp"
+
+namespace apache {
+namespace geode {
+namespace client {
+
+const size_t kBufferSize = 3000;
+
+StreamDataInput::StreamDataInput(std::chrono::milliseconds timeout,
+ std::unique_ptr connector,
+ const CacheImpl* cache, Pool* pool)
+: DataInput(nullptr, 0, cache, pool),
+ connector_(std::move(connector)),
+ remainingTimeBeforeTimeout_(timeout) {}
+
+void StreamDataInput::readDataIfNotAvailable(size_t size) {
+ char buff[kBufferSize];
+ while (getBytesRemaining() < size) {
+const auto start = std::chrono::system_clock::now();
+
+const auto receivedLength = connector_->receive_nothrowiftimeout(
+buff, kBufferSize,
+std::chrono::duration_cast(
+remainingTimeBeforeTimeout_));
Review Comment:
The duration cast can go away now that all time is milliseconds.
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10404) Fix compilation for Java 11
[
https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580615#comment-17580615
]
ASF GitHub Bot commented on GEODE-10404:
albertogpz merged PR #980:
URL: https://github.com/apache/geode-native/pull/980
> Fix compilation for Java 11
> ---
>
> Key: GEODE-10404
> URL: https://issues.apache.org/jira/browse/GEODE-10404
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: needsTriage, pull-request-available
>
> It seems that after merging
> [#973|https://github.com/apache/geode-native/pull/973], compilation with
> Geode Native Docker build image for version 1.15.0 is broken. This is the
> compilation error:
> {noformat}
> tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable
> character (0xAC) for encoding US-ASCII
> pdxInstanceFactory.writeString("utfHugeField", longString + "???");
> {noformat}
> As it seems, the latest docker image is using Java 11, which handles UTF-8
> strings in a different way to Java 8, so that's why compilation is working
> with packer images and not with Docker build image.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10408) Improvre data incosistency after failed offline compaction
[ https://issues.apache.org/jira/browse/GEODE-10408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10408: --- Labels: pull-request-available (was: ) > Improvre data incosistency after failed offline compaction > -- > > Key: GEODE-10408 > URL: https://issues.apache.org/jira/browse/GEODE-10408 > Project: Geode > Issue Type: Improvement > Components: persistence, regions >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > We have cluster with 3 servers and configured partitioned persistent > redundant region. Region if filled with data. We stop one server, and perform > offline compaction. While compaction is ongoing, that process is interrupted. > When that server is started, data incosistency is observed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10292) Upgrade boost to 1.79.0
[ https://issues.apache.org/jira/browse/GEODE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579518#comment-17579518 ] ASF GitHub Bot commented on GEODE-10292: moleske commented on PR #967: URL: https://github.com/apache/geode-native/pull/967#issuecomment-1214594738 Probably not anytime soon as I haven't made time to to figure out this problem. Will close the PR since I'm not making progress on it > Upgrade boost to 1.79.0 > --- > > Key: GEODE-10292 > URL: https://issues.apache.org/jira/browse/GEODE-10292 > Project: Geode > Issue Type: Task >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Upgrade boost to 1.79.0 as first step in supporting visual studio 2022 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10292) Upgrade boost to 1.79.0
[ https://issues.apache.org/jira/browse/GEODE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579519#comment-17579519 ] ASF GitHub Bot commented on GEODE-10292: moleske closed pull request #967: GEODE-10292: Bump to boost 1.79.0 URL: https://github.com/apache/geode-native/pull/967 > Upgrade boost to 1.79.0 > --- > > Key: GEODE-10292 > URL: https://issues.apache.org/jira/browse/GEODE-10292 > Project: Geode > Issue Type: Task >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Upgrade boost to 1.79.0 as first step in supporting visual studio 2022 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10292) Upgrade boost to 1.79.0
[ https://issues.apache.org/jira/browse/GEODE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17579509#comment-17579509 ] ASF GitHub Bot commented on GEODE-10292: ebluo commented on PR #967: URL: https://github.com/apache/geode-native/pull/967#issuecomment-1214578619 Hello Michael, Any plan when this will be merged? Thanks! > Upgrade boost to 1.79.0 > --- > > Key: GEODE-10292 > URL: https://issues.apache.org/jira/browse/GEODE-10292 > Project: Geode > Issue Type: Task >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Upgrade boost to 1.79.0 as first step in supporting visual studio 2022 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10407) java.lang.LinkageError: loader org.apache.geode.internal.DeployJarChildFirstClassLoader @2b0a05b0 attempted duplicate class definition for org.apache.kafka.common.KafkaE
[ https://issues.apache.org/jira/browse/GEODE-10407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10407: --- Labels: needsTriage pull-request-available (was: needsTriage) > java.lang.LinkageError: loader > org.apache.geode.internal.DeployJarChildFirstClassLoader @2b0a05b0 attempted > duplicate class definition for org.apache.kafka.common.KafkaException > - > > Key: GEODE-10407 > URL: https://issues.apache.org/jira/browse/GEODE-10407 > Project: Geode > Issue Type: Bug > Components: configuration, gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: needsTriage, pull-request-available > > When creating region with CacheListener, LinkageError error is detected -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10405) Offline server want start if gateway senders were restarted with clean queue option
[ https://issues.apache.org/jira/browse/GEODE-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10405: --- Labels: pull-request-available (was: ) > Offline server want start if gateway senders were restarted with clean queue > option > --- > > Key: GEODE-10405 > URL: https://issues.apache.org/jira/browse/GEODE-10405 > Project: Geode > Issue Type: Improvement > Components: persistence, regions, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > In case gateway senders were restarted with "clean queue" option, while > server was offline, if we want to start offline server, it will fail. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10404) Fix compilation for Java 11
[
https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17574170#comment-17574170
]
ASF GitHub Bot commented on GEODE-10404:
gaussianrecurrence opened a new pull request, #980:
URL: https://github.com/apache/geode-native/pull/980
- After merging #973, javaobject compilation was broken for Java 11.
The build passed since packer images uses Java 8, but as docker build
images uses Java 11, compilation is failing there.
- Root cause of the compilation issue is the difference in UTF-8 string
handling between Java 8 and Java 11.
- So, the issue was fixed by using unicode hexcode codepoint
characters, rather than the actual codepoint.
> Fix compilation for Java 11
> ---
>
> Key: GEODE-10404
> URL: https://issues.apache.org/jira/browse/GEODE-10404
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: needsTriage
>
> It seems that after merging
> [#973|https://github.com/apache/geode-native/pull/973], compilation with
> Geode Native Docker build image for version 1.15.0 is broken. This is the
> compilation error:
> {noformat}
> tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable
> character (0xAC) for encoding US-ASCII
> pdxInstanceFactory.writeString("utfHugeField", longString + "???");
> {noformat}
> As it seems, the latest docker image is using Java 11, which handles UTF-8
> strings in a different way to Java 8, so that's why compilation is working
> with packer images and not with Docker build image.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10404) Fix compilation for Java 11
[
https://issues.apache.org/jira/browse/GEODE-10404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10404:
---
Labels: needsTriage pull-request-available (was: needsTriage)
> Fix compilation for Java 11
> ---
>
> Key: GEODE-10404
> URL: https://issues.apache.org/jira/browse/GEODE-10404
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: needsTriage, pull-request-available
>
> It seems that after merging
> [#973|https://github.com/apache/geode-native/pull/973], compilation with
> Geode Native Docker build image for version 1.15.0 is broken. This is the
> compilation error:
> {noformat}
> tests/javaobject/ComparePdxInstanceFunction.java:42: error: unmappable
> character (0xAC) for encoding US-ASCII
> pdxInstanceFactory.writeString("utfHugeField", longString + "???");
> {noformat}
> As it seems, the latest docker image is using Java 11, which handles UTF-8
> strings in a different way to Java 8, so that's why compilation is working
> with packer images and not with Docker build image.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (GEODE-10403) Distributed deadlock when stopping gateway sender
[
https://issues.apache.org/jira/browse/GEODE-10403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10403:
---
Labels: needsTriage pull-request-available (was: needsTriage)
> Distributed deadlock when stopping gateway sender
> -
>
> Key: GEODE-10403
> URL: https://issues.apache.org/jira/browse/GEODE-10403
> Project: Geode
> Issue Type: Bug
> Components: wan
>Affects Versions: 1.12.9, 1.13.8, 1.14.4, 1.15.0
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: needsTriage, pull-request-available
>
> A distributed deadlock has been found during some tests of a Geode system
> with WAN replication when stopping the gateway sender while sending a fair
> amount of operations to the servers.
> The distributed deadlock manifests in the gateway sender stop command hanging
> forever and by all normal Geode operations from clients (gets, puts,...) not
> being responded.
> The situation is provoked by the Gateway sender stop command that first takes
> the lifecycle lock and then, at a given point, tries to retrieve the size of
> the gateway sender. This operation, that requires communication with the
> other peers never finishes, probably because the response from one of the
> peers is never received.
> Another thread is blocked when trying to acquire the lifecycle lock in
> AbstractGatewaySender.distribute().
> Finally many threads handling Geode operations (get, put...) get blocked in
> the DistributedCacheOperation._distribute() call waiting for a response from
> another peer.
> Thread dump section from blocked gateway sender stop command in call to get
> size of queue:
> {{"ConcurrentParallelGatewaySenderEventProcessor Stopper Thread1" #1316
> daemon prio=10 os_prio=0 cpu=45.55ms elapsed=4152.76s tid=0x7f92bc1c2000
> nid=0x2154 waiting on condition [0x7f9179cd2000]}}
> {{ java.lang.Thread.State: TIMED_WAITING (parking)}}
> {{ at jdk.internal.misc.Unsafe.park(java.base@11.0.11/Native Method)}}
> {{ - parking to wait for <0x00031ca2be50> (a
> java.util.concurrent.CountDownLatch$Sync)}}
> {{ at
> java.util.concurrent.locks.LockSupport.parkNanos(java.base@11.0.11/LockSupport.java:234)}}
> {{ at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.doAcquireSharedNanos(java.base@11.0.11/AbstractQueuedSynchronizer.java:1079)}}
> {{ at
> java.util.concurrent.locks.AbstractQueuedSynchronizer.tryAcquireSharedNanos(java.base@11.0.11/AbstractQueuedSynchronizer.java:1369)}}
> {{ at
> java.util.concurrent.CountDownLatch.await(java.base@11.0.11/CountDownLatch.java:278)}}
> {{ at
> org.apache.geode.internal.util.concurrent.StoppableCountDownLatch.await(StoppableCountDownLatch.java:72)}}
> {{ at
> org.apache.geode.distributed.internal.ReplyProcessor21.basicWait(ReplyProcessor21.java:731)}}
> {{ at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:802)}}
> {{ at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:779)}}
> {{ at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:865)}}
> {{ at
> org.apache.geode.internal.cache.partitioned.SizeMessage$SizeResponse.waitBucketSizes(SizeMessage.java:344)}}
> {{ at
> org.apache.geode.internal.cache.PartitionedRegion.getSizeRemotely(PartitionedRegion.java:6758)}}
> {{ at
> org.apache.geode.internal.cache.PartitionedRegion.entryCount(PartitionedRegion.java:6709)}}
> {{ at
> org.apache.geode.internal.cache.PartitionedRegion.entryCount(PartitionedRegion.java:6691)}}
> {{ at
> org.apache.geode.internal.cache.PartitionedRegion.getRegionSize(PartitionedRegion.java:6663)}}
> {{ at
> org.apache.geode.internal.cache.LocalRegionDataView.entryCount(LocalRegionDataView.java:99)}}
> {{ at
> org.apache.geode.internal.cache.LocalRegion.entryCount(LocalRegion.java:2078)}}
> {{ at
> org.apache.geode.internal.cache.LocalRegion.size(LocalRegion.java:8301)}}
> {{ at
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.size(ParallelGatewaySenderQueue.java:1670)}}
> {{ at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.closeProcessor(AbstractGatewaySenderEventProcessor.java:1259)}}
> {{ at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.stopProcessing(AbstractGatewaySenderEventProcessor.java:1247)}}
> {{ at
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor$SenderStopperCallable.call(AbstractGatewaySenderEventProcessor.java:1399)}}
> {{ at
> org.ap
[jira] [Updated] (GEODE-10401) Oplog recovery takes too long due to fault in fastutil library
[
https://issues.apache.org/jira/browse/GEODE-10401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-10401:
---
Labels: pull-request-available (was: )
> Oplog recovery takes too long due to fault in fastutil library
> --
>
> Key: GEODE-10401
> URL: https://issues.apache.org/jira/browse/GEODE-10401
> Project: Geode
> Issue Type: Bug
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
>
> {color:#0e101a}As we already know, the .drf file delete operations only
> contain OplogEntryID. During recovery, the server reads (byte by byte) each
> OplogEntryID and stores it in a HashSet to use later when recovering .crf
> files. There are two types of HashSets: IntOpenHashSet and LongOpenHashSet.
> The OplogEntryID of type
> {color}_{color:#0e101a}integer{color}_{color:#0e101a} will be stored in
> IntOpenHashSet, and {color}_{color:#0e101a}long
> integer{color}_{color:#0e101a} in LongOpenHashSet, probably due to memory
> optimization and performance factors. OplogEntryID starts with a zero and
> increments throughout time.
> {color}
> {color:#0e101a}We have observed in logs that between exception (There is a
> large number of deleted entries) and the previous log have passed more than 4
> minutes (sometimes even more).{color}
> {code:java}
> {"timestamp":"2022-06-14T21:41:43.772+08:00","severity":"info","message":"Recovering
> oplog#271 /opt/dbservice/data/datastore/BACKUPdataDiskStore_271.drf for disk
> store dataDiskStore.","metadata":
> {"timestamp":"2022-06-14T21:46:02.152+08:00","severity":"warning","message":"There
> is a large number of deleted entries within the disk-store, please execute
> an offline
> compaction.","metadata":
> {code}
> {color:#0e101a}When the above exception occurs, that means that the limit of
> {color}_{color:#0e101a}805306401{color}_{color:#0e101a} entries in
> IntOpenHashSet has been reached. In that case, the server rolls to the new
> IntOpenHashSet, where an exception and the delay could happen again.{color}
> {color:#0e101a}The problem is that due to the fault in FastUtil dependency
> (IntOpenHashSet and LongOpenHashSet), the unnecessary rehashing happens
> multiple times before the max size is reached. The{color}
> _{color:#0e101a}rehashing starts from{color}_ {color:#0e101a}805306368
> onwards for each new entry until the max size. This rehashing adds several
> minutes to .drf Oplog recovery, but does nothing as max is already
> reached.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564899#comment-17564899
]
ASF GitHub Bot commented on GEODE-10300:
albertogpz commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r917731818
##
cppcache/src/StreamDataInput.cpp:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "StreamDataInput.hpp"
+
+#include
+
+#include "Utils.hpp"
+#include "util/Log.hpp"
+
+namespace apache {
+namespace geode {
+namespace client {
+
+const size_t kBufferSize = 3000;
+
+StreamDataInput::StreamDataInput(std::chrono::milliseconds timeout,
+ std::unique_ptr connector,
+ const CacheImpl* cache, Pool* pool)
+: DataInput(nullptr, 0, cache, pool),
+ connector_(std::move(connector)),
+ remainingTimeBeforeTimeout_(timeout) {}
+
+void StreamDataInput::readDataIfNotAvailable(size_t size) {
+ char buff[kBufferSize];
+ while (getBytesRemaining() < size) {
+const auto start = std::chrono::system_clock::now();
+
+const auto receivedLength = connector_->receive_nothrowiftimeout(
+buff, kBufferSize,
+std::chrono::duration_cast(
+remainingTimeBeforeTimeout_));
Review Comment:
Probably not. I will change it to milliseconds.
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564825#comment-17564825
]
ASF GitHub Bot commented on GEODE-10300:
albertogpz commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r917628356
##
cppcache/include/geode/DataInput.hpp:
##
@@ -502,21 +502,21 @@ class APACHE_GEODE_EXPORT DataInput {
inline char readPdxChar() { return static_cast(readInt16()); }
- inline void _checkBufferSize(size_t size, int32_t line) {
-if ((m_bufLength - (m_buf - m_bufHead)) < size) {
+ virtual void _checkBufferSize(size_t size, int32_t line) {
Review Comment:
I am afraid it is necessary for the solution. But given that this will go in
a minor release I do not think it is an issue.
Is there a log file in place where I could add this change as proposed in:
https://lists.apache.org/thread/0v2r5trv926oj8qrgfp00467y3rycsvw
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564826#comment-17564826
]
ASF GitHub Bot commented on GEODE-10300:
albertogpz commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r917628778
##
cppcache/include/geode/DataInput.hpp:
##
@@ -452,19 +452,19 @@ class APACHE_GEODE_EXPORT DataInput {
DataInput& operator=(DataInput&&) = default;
protected:
Review Comment:
Not sure. Anyhow, this fix should go in a minor release so should not be an
issue.
> C++ Native client messages coming from the locator cannot be longer than 3000
> bytes
> ---
>
> Key: GEODE-10300
> URL: https://issues.apache.org/jira/browse/GEODE-10300
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Alberto Gomez
>Assignee: Alberto Gomez
>Priority: Major
> Labels: pull-request-available
>
> If a locator sends a response to the C++ native client that is longer than
> 3000 bytes the C++ native client library will only read the first 3000 bytes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (GEODE-10300) C++ Native client messages coming from the locator cannot be longer than 3000 bytes
[
https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564394#comment-17564394
]
ASF GitHub Bot commented on GEODE-10300:
pivotal-jbarrett commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r917042197
##
cppcache/src/GetAllServersResponse.cpp:
##
@@ -21,10 +21,10 @@ namespace geode {
namespace client {
void GetAllServersResponse::toData(DataOutput& output) const {
- int32_t numServers = static_cast(m_servers.size());
+ int32_t numServers = static_cast(servers_.size());
Review Comment:
`auto`
##
cppcache/include/geode/DataInput.hpp:
##
@@ -502,21 +502,21 @@ class APACHE_GEODE_EXPORT DataInput {
inline char readPdxChar() { return static_cast(readInt16()); }
- inline void _checkBufferSize(size_t size, int32_t line) {
-if ((m_bufLength - (m_buf - m_bufHead)) < size) {
+ virtual void _checkBufferSize(size_t size, int32_t line) {
Review Comment:
This is a breaking ABI change. This should only occur at a minor release.
Are we sure this needs to change?
##
cppcache/src/StreamDataInput.cpp:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "StreamDataInput.hpp"
+
+#include
+
+#include "Utils.hpp"
+#include "util/Log.hpp"
+
+namespace apache {
+namespace geode {
+namespace client {
+
+const size_t kBufferSize = 3000;
Review Comment:
`constexpr`
##
cppcache/test/StreamDataInputTest.cpp:
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+
+#include
+
+#include "CacheImpl.hpp"
+#include "Connector.hpp"
+#include "GetAllServersResponse.hpp"
+#include "ServerLocation.hpp"
+#include "StreamDataInput.hpp"
+#include "geode/DataOutput.hpp"
+#include "mock/ConnectorMock.hpp"
+
+namespace {
+
+using apache::geode::client::CacheImpl;
+using apache::geode::client::Connector;
+using apache::geode::client::ConnectorMock;
+using apache::geode::client::DataOutput;
+using apache::geode::client::GetAllServersResponse;
+using apache::geode::client::Serializable;
+using apache::geode::client::ServerLocation;
+using apache::geode::client::StreamDataInput;
+using apache::geode::client::TimeoutException;
+
+using ::testing::_;
+using ::testing::DoAll;
+using ::testing::Eq;
+using ::testing::Return;
+using ::testing::SetArrayArgument;
+using ::testing::SizeIs;
+
+const size_t kReadBuffSize = 3000;
Review Comment:
`constexpr`
##
cppcache/include/geode/DataInput.hpp:
##
@@ -452,19 +452,19 @@ class APACHE_GEODE_EXPORT DataInput {
DataInput& operator=(DataInput&&) = default;
protected:
+ const uint8_t* buf_;
Review Comment:
Love the update to the current naming convention but please also update to
full words too.
##
cppcache/src/StreamDataInput.cpp:
##
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org
[jira] [Updated] (GEODE-10398) TotalBucketCount are not updated after restart
[ https://issues.apache.org/jira/browse/GEODE-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10398: --- Labels: needsTriage pull-request-available (was: needsTriage) > TotalBucketCount are not updated after restart > -- > > Key: GEODE-10398 > URL: https://issues.apache.org/jira/browse/GEODE-10398 > Project: Geode > Issue Type: Bug > Components: statistics >Affects Versions: 1.13.8, 1.14.4, 1.15.0 >Reporter: Mario Kevo >Priority: Major > Labels: needsTriage, pull-request-available > > Steps to reproduce the issue: > # start locator and 4 servers(static sampling enabled) > # create disk stores for gw sender and region > # create parallel gw sender with disk store > # create the region with gw sender and disk store > # initialize buckets > # shutdown servers > # get up all servers > # check the member stats > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10076) Fix string codepoint detection
[ https://issues.apache.org/jira/browse/GEODE-10076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564170#comment-17564170 ] ASF GitHub Bot commented on GEODE-10076: albertogpz merged PR #973: URL: https://github.com/apache/geode-native/pull/973 > Fix string codepoint detection > -- > > Key: GEODE-10076 > URL: https://issues.apache.org/jira/browse/GEODE-10076 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > *GIVEN* a PdxSerializable implementation with a string field > *WHEN* an ASCII string is written > *THEN* the string is serialized with the DSCode CacheableString > > *Additional information.* In the Java client, whenever writing an string, the > string is parsed and the DSCode is assigned depending on the string > codification. In the native client, it's always set to CacheableString, > whenever for example in the case of an ASCII string should be > CacheableASCIIString > Also I've noticed the following scenario requires to fix the codepoint > detection: > # From a native client, I create an object using a PdxSerializable > implementation, which has an String field. > # After that, we are reading this object from a java client which cache has > readPdxSerialized=true and comparing it with a PdxInstance created locally > inside the Java client. > # As PdxInstanceImpl.equals method uses rawBytes for strings, if the string > is serialized using different DSCodes, the comparison will fail, even if the > length and content are the same. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10371) C++ Native client: Improve dispersion on connections expiration
[ https://issues.apache.org/jira/browse/GEODE-10371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562995#comment-17562995 ] ASF GitHub Bot commented on GEODE-10371: albertogpz merged PR #974: URL: https://github.com/apache/geode-native/pull/974 > C++ Native client: Improve dispersion on connections expiration > --- > > Key: GEODE-10371 > URL: https://issues.apache.org/jira/browse/GEODE-10371 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > The dispersion on connections expirations in the C++ native client works in > such a way that it adds a dispersion (variance) between -9% and 9% over the > time for a connection to expire due to load-conditioning so that, in the > event of having many connections being created at the same, they do not > expire at the right exact time. > Nevertheless, the current implementation has two problems: > - The randomness of the variance depends on the current time in seconds. As a > result, for connections created in the same second, the variance will be the > same and, therefore, the expiration time too. > - The randomness is created using the C standard's library "rand()" function > which is considered not secure. > It is recommended to change the library used to generate the random variance > to a secure one and also to make sure that for the time in seconds it does > not return the same variance. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10396) IllegalStateException wrapped within FunctionException triggers endpoint disconnection
[ https://issues.apache.org/jira/browse/GEODE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562504#comment-17562504 ] ASF GitHub Bot commented on GEODE-10396: gaussianrecurrence opened a new pull request, #977: URL: https://github.com/apache/geode-native/pull/977 - Currently whenever a server function is executed on a region with no filter, if an IllegalStateException wrapped within a FunctionException is thrown inside the server fuction body, then the endpoint's connections are closed, given the client considers the endpoint is failing. - In order to solve this, now it's checked if the exception is wrapped into a FunctionException before triggering the endpoint disconnection mechanism. - A new IT has been added to verify the behavior. > IllegalStateException wrapped within FunctionException triggers endpoint > disconnection > -- > > Key: GEODE-10396 > URL: https://issues.apache.org/jira/browse/GEODE-10396 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage > > *GIVEN* A cluster of 3 servers and a client with a pool pointing to those 3 > servers >*AND* configured with PR-Singl-Hop = true > *WHEN* A server function is executed with onRegion and with a filter >*AND* it throws an IllegalServerException wrapped within a > FunctionExceution in the body > *THEN* the native client thinks there is an isue with the node and closes all > the endpoint's connections. > --- > *IT IS TO BE EXPECTED* That given that the exception is wrapped inside a > FunctionException this should be ignored by the endpoint failure detection > mechanism that native client has into place. > *AS ADDITIONAL INFO* Currently, the exception chain relationship info is not > read by the native client, as it's serialized using Java serialization format. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10396) IllegalStateException wrapped within FunctionException triggers endpoint disconnection
[ https://issues.apache.org/jira/browse/GEODE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10396: --- Labels: needsTriage pull-request-available (was: needsTriage) > IllegalStateException wrapped within FunctionException triggers endpoint > disconnection > -- > > Key: GEODE-10396 > URL: https://issues.apache.org/jira/browse/GEODE-10396 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: needsTriage, pull-request-available > > *GIVEN* A cluster of 3 servers and a client with a pool pointing to those 3 > servers >*AND* configured with PR-Singl-Hop = true > *WHEN* A server function is executed with onRegion and with a filter >*AND* it throws an IllegalServerException wrapped within a > FunctionExceution in the body > *THEN* the native client thinks there is an isue with the node and closes all > the endpoint's connections. > --- > *IT IS TO BE EXPECTED* That given that the exception is wrapped inside a > FunctionException this should be ignored by the endpoint failure detection > mechanism that native client has into place. > *AS ADDITIONAL INFO* Currently, the exception chain relationship info is not > read by the native client, as it's serialized using Java serialization format. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10089) release 1.15.0
[ https://issues.apache.org/jira/browse/GEODE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562455#comment-17562455 ] ASF GitHub Bot commented on GEODE-10089: onichols-pivotal merged PR #976: URL: https://github.com/apache/geode-native/pull/976 > release 1.15.0 > -- > > Key: GEODE-10089 > URL: https://issues.apache.org/jira/browse/GEODE-10089 > Project: Geode > Issue Type: Task > Components: release >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Labels: pull-request-available > > As per [Jan 25 dev list > discussion|https://lists.apache.org/thread/s9mpd207h40crcr76fpdfmohdchgdqog], > support/1.15 was cut with the intention of stabilizing and releasing a new > Geode minor. > UPDATE: As per [Mar 16 dev list > discussion|https://lists.apache.org/thread/twlwzcvmx2kqw15whpmxkh2h8bmrok21], > support/1.15 was retracted. Work will continue on develop with an eye toward > re-cutting support/1.15 in ~June > UPDATE: support/1.15 was re-cut on May 9 with an eye toward shipping in mid > to late June (2022). > Release status information is also updated in the Geode [Release > Schedule|https://cwiki.apache.org/confluence/display/GEODE/Release+Schedule]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (GEODE-10089) release 1.15.0
[ https://issues.apache.org/jira/browse/GEODE-10089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17562451#comment-17562451 ] ASF GitHub Bot commented on GEODE-10089: gaussianrecurrence commented on PR #976: URL: https://github.com/apache/geode-native/pull/976#issuecomment-1174754568 Hi :) Is there any plans to get this merged? I thought this needed to be merged before releasing 1.15.0 :S > release 1.15.0 > -- > > Key: GEODE-10089 > URL: https://issues.apache.org/jira/browse/GEODE-10089 > Project: Geode > Issue Type: Task > Components: release >Reporter: Owen Nichols >Assignee: Owen Nichols >Priority: Major > Labels: pull-request-available > > As per [Jan 25 dev list > discussion|https://lists.apache.org/thread/s9mpd207h40crcr76fpdfmohdchgdqog], > support/1.15 was cut with the intention of stabilizing and releasing a new > Geode minor. > UPDATE: As per [Mar 16 dev list > discussion|https://lists.apache.org/thread/twlwzcvmx2kqw15whpmxkh2h8bmrok21], > support/1.15 was retracted. Work will continue on develop with an eye toward > re-cutting support/1.15 in ~June > UPDATE: support/1.15 was re-cut on May 9 with an eye toward shipping in mid > to late June (2022). > Release status information is also updated in the Geode [Release > Schedule|https://cwiki.apache.org/confluence/display/GEODE/Release+Schedule]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (GEODE-10344) Send alert when thread stuck for longer than configured time
[ https://issues.apache.org/jira/browse/GEODE-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-10344: --- Labels: pull-request-available (was: ) > Send alert when thread stuck for longer than configured time > > > Key: GEODE-10344 > URL: https://issues.apache.org/jira/browse/GEODE-10344 > Project: Geode > Issue Type: New Feature > Components: management >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > As per RFC > [https://cwiki.apache.org/confluence/display/GEODE/Management+of+threads+stuck+for+a+long+time+in+Geode], > it is proposed to send an alert when a thread in a member has been stuck for > a maximum configurable value. > -- This message was sent by Atlassian Jira (v8.20.10#820010)
