[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user paul-guo- commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 OK, so +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 They are all generated by 'pg_config', they should not be relative PATH. # Extension makefiles should set PG_CONFIG, but older ones might not ifndef PG_CONFIG PG_CONFIG = pg_config endif bindir := $(shell $(PG_CONFIG) --bindir) datadir := $(shell $(PG_CONFIG) --sharedir) sysconfdir := $(shell $(PG_CONFIG) --sysconfdir) libdir := $(shell $(PG_CONFIG) --libdir) pkglibdir := $(shell $(PG_CONFIG) --pkglibdir) includedir := $(shell $(PG_CONFIG) --includedir) pkgincludedir := $(shell $(PG_CONFIG) --pkgincludedir) mandir := $(shell $(PG_CONFIG) --mandir) docdir := $(shell $(PG_CONFIG) --docdir) localedir := $(shell $(PG_CONFIG) --localedir) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
If you can make sure all of the later paths are absolute path, it will be
fine, e.g.
${DESTDIR}${docdir}
${DESTDIR}$(bindir)
${DESTDIR}${libdir}
$(DESTDIR)${sysconfdir}
I'm just a bit worried about the could be a bug in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 @paul-guo- I don't think the --prefix option can set a relative path, so there is definitely no need to add a '/' between DESTDIR and PREFIX-DIR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1184
Cool work! I just have one concern.
I saw a lot of fix like this, however is is possible the later one is a
relative path while DESTDIR has not a tailing / and this could lead to a bug,
so maybe you could add / between them to prevent this, besides: 1) This will
make code easier to read 2) even there is // in your path, it is not a problem
also. How do you think?
$(DESTDIR)${sysconfdir}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user huor commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 Great to have the fix for build. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hawq issue #1184: HAWQ-1401. Fix HAWQ make install with DESTDIR.
Github user radarwave commented on the issue: https://github.com/apache/incubator-hawq/pull/1184 @edespino @paul-guo- @huor @xunzhang Please help to review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
