[jira] [Commented] (HBASE-5816) Balancer and ServerShutdownHandler concurrently reassigning the same region

[Maryann Xue (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258055#comment-13258055
 ] 

Maryann Xue commented on HBASE-5816:


@stack, @ramkrishna Should be able to reproduce problem 2 in trunk in unit test 
by initiating concurrent assign() from two threads.

> Balancer and ServerShutdownHandler concurrently reassigning the same region
> ---
>
> Key: HBASE-5816
> URL: https://issues.apache.org/jira/browse/HBASE-5816
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 0.90.6
>Reporter: Maryann Xue
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Attachments: HBASE-5816.patch
>
>
> The first assign thread exits with success after updating the RegionState to 
> PENDING_OPEN, while the second assign follows immediately into "assign" and 
> fails the RegionState check in setOfflineInZooKeeper(). This causes the 
> master to abort.
> In the below case, the two concurrent assigns occurred when AM tried to 
> assign a region to a dying/dead RS, and meanwhile the ShutdownServerHandler 
> tried to assign this region (from the region plan) spontaneously.
> 2012-04-17 05:44:57,648 INFO org.apache.hadoop.hbase.master.HMaster: balance 
> hri=TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b., 
> src=hadoop05.sh.intel.com,60020,1334544902186, 
> dest=xmlqa-clv16.sh.intel.com,60020,1334612497253
> 2012-04-17 05:44:57,648 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Starting unassignment of 
> region TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b. 
> (offlining)
> 2012-04-17 05:44:57,648 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Sent CLOSE to 
> serverName=hadoop05.sh.intel.com,60020,1334544902186, load=(requests=0, 
> regions=0, usedHeap=0, maxHeap=0) for region 
> TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b.
> 2012-04-17 05:44:57,666 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Handling new unassigned 
> node: /hbase/unassigned/fe38fe31caf40b6e607a3e6bbed6404b 
> (region=TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b.,
>  server=hadoop05.sh.intel.com,60020,1334544902186, state=RS_ZK_REGION_CLOSING)
> 2012-04-17 05:52:58,984 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Forcing OFFLINE; 
> was=TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b. 
> state=CLOSED, ts=1334612697672, 
> server=hadoop05.sh.intel.com,60020,1334544902186
> 2012-04-17 05:52:58,984 DEBUG org.apache.hadoop.hbase.zookeeper.ZKAssign: 
> master:6-0x236b912e9b3000e Creating (or updating) unassigned node for 
> fe38fe31caf40b6e607a3e6bbed6404b with OFFLINE state
> 2012-04-17 05:52:59,096 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Using pre-existing plan for 
> region TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b.; 
> plan=hri=TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b.,
>  src=hadoop05.sh.intel.com,60020,1334544902186, 
> dest=xmlqa-clv16.sh.intel.com,60020,1334612497253
> 2012-04-17 05:52:59,096 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Assigning region 
> TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b. to 
> xmlqa-clv16.sh.intel.com,60020,1334612497253
> 2012-04-17 05:54:19,159 DEBUG 
> org.apache.hadoop.hbase.master.AssignmentManager: Forcing OFFLINE; 
> was=TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b. 
> state=PENDING_OPEN, ts=1334613179096, 
> server=xmlqa-clv16.sh.intel.com,60020,1334612497253
> 2012-04-17 05:54:59,033 WARN 
> org.apache.hadoop.hbase.master.AssignmentManager: Failed assignment of 
> TABLE_ORDER_CUSTOMER,,1334017820846.fe38fe31caf40b6e607a3e6bbed6404b. to 
> serverName=xmlqa-clv16.sh.intel.com,60020,1334612497253, load=(requests=0, 
> regions=0, usedHeap=0, maxHeap=0), trying to assign elsewhere instead; retry=0
> java.net.SocketTimeoutException: Call to /10.239.47.87:60020 failed on socket 
> timeout exception: java.net.SocketTimeoutException: 12 millis timeout 
> while waiting for channel to be ready for read. ch : 
> java.nio.channels.SocketChannel[connected local=/10.239.47.89:41302 
> remote=/10.239.47.87:60020]
> at 
> org.apache.hadoop.hbase.ipc.HBaseClient.wrapException(HBaseClient.java:805)
> at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:778)
> at 
> org.apache.hadoop.hbase.ipc.HBaseRPC$Invoker.invoke(HBaseRPC.java:283)
> at $Proxy7.openRegion(Unknown Source)
> at 
> org.apache.hadoop.hbase.master.ServerManager.sendRegionOpen(ServerManager.java:573)
> at 
> org.apache.hadoop.hbase.master.AssignmentManager.assign(Assig

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Open  (was: Patch Available)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Attachment: 5831.remove.all.mapreduce.txt

Retry.  See if can get clean build again w/ all tests passing.  Last test had a 
fail.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Patch Available  (was: Open)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5839) Backup master not starting up due to Bind Exception while starting HttpServer

[Uma Maheswara Rao G (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258044#comment-13258044
 ] 

Uma Maheswara Rao G commented on HBASE-5839:


bq. Even before that the Data Xceviers threads (IPC handlers) are started and 
they are started at random port.

DataXceiver server will listen on fixed port, 50010.

Clients only will bind to random ports for short term. Even I have seen this 
situations some times in my clusters. 

We followed to set the fixed ports of servers at range of ~65000. It may just 
reduce the probability of clients to binding on the same ports. As per our 
observations, that random ports did not reach to this level. Not sure, is there 
any specific range for random ports.

This problem may be unavoidable problem. Restart servers only the option. Let's 
see if anyone has some better idea to avoid this situation.

> Backup master not starting up due to Bind Exception while starting HttpServer
> -
>
> Key: HBASE-5839
> URL: https://issues.apache.org/jira/browse/HBASE-5839
> Project: HBase
>  Issue Type: Bug
>Reporter: ramkrishna.s.vasudevan
> Fix For: 0.96.0, 0.94.1
>
>
> Backup master tries to bind to the info port 60010.
> This is done once the back up master becomes active.  Even before that the 
> Data Xceviers threads (IPC handlers) are started and they are started at 
> random port.  If already 60010 is used then when standby master comes up then 
> it fails due to bind exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258035#comment-13258035
 ] 

Hadoop QA commented on HBASE-5831:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523450/5831.remove.all.mapreduce.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 26 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestColumnSeeking

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1590//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1590//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1590//console

This message is automatically generated.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5839) Backup master not starting up due to Bind Exception while starting HttpServer

[ramkrishna.s.vasudevan (Created) (JIRA)]

Backup master not starting up due to Bind Exception while starting HttpServer
-

 Key: HBASE-5839
 URL: https://issues.apache.org/jira/browse/HBASE-5839
 Project: HBase
  Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0, 0.94.1


Backup master tries to bind to the info port 60010.
This is done once the back up master becomes active.  Even before that the Data 
Xceviers threads (IPC handlers) are started and they are started at random 
port.  If already 60010 is used then when standby master comes up then it fails 
due to bind exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Patch Available  (was: Open)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Attachment: 5831.remove.all.mapreduce.txt

Try again.  Last patch passed all tests.  See if can do again.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Open  (was: Patch Available)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258026#comment-13258026
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328030)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


> Incorrect handling of null value in Coprocessor aggregation function min()
> --
>
> Key: HBASE-5821
> URL: https://issues.apache.org/jira/browse/HBASE-5821
> Project: HBase
>  Issue Type: Bug
>  Components: coprocessors
>Affects Versions: 0.92.1
>Reporter: Maryann Xue
>Assignee: Maryann Xue
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5821.patch
>
>
> Both in AggregateImplementation and AggregationClient, the evaluation of the 
> current minimum value is like:
> min = (min == null || ci.compare(result, min) < 0) ? result : min;
> The LongColumnInterpreter takes null value is treated as the least value, 
> while the above expression takes min as the greater value when it is null. 
> Thus, the real minimum value gets discarded if a null value comes later.
> max() could also be wrong if a different ColumnInterpreter other than 
> LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5737) Minor Improvements related to balancer.

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258025#comment-13258025
 ] 

Hudson commented on HBASE-5737:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5737 Minor Improvements related to balancer. (Ram) (Revision 1328057)

 Result = FAILURE
ramkrishna : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java


> Minor Improvements related to balancer.
> ---
>
> Key: HBASE-5737
> URL: https://issues.apache.org/jira/browse/HBASE-5737
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
>Priority: Minor
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5737.patch, HBASE-5737_1.patch, 
> HBASE-5737_2.patch, HBASE-5737_3.patch
>
>
> Currently in Am.getAssignmentByTable()  we use a result map which is currenly 
> a hashmap.  It could be better if we have a treeMap.  Even in 
> MetaReader.fullScan we have the treeMap only so that we have the naming order 
> maintained. I felt this change could be very useful in cases where we are 
> extending the DefaultLoadBalancer.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258024#comment-13258024
 ] 

Hudson commented on HBASE-5824:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5824 addendum fixes coprocessor tests (Jimmy) (Revision 1328166)
HBASE-5824 HRegion.incrementColumnValue is not used in trunk (Revision 1328142)

 Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java

stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258023#comment-13258023
 ] 

Hudson commented on HBASE-5794:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5794 Jenkins builds timing out; undo setting 
hbase.client.retries.number to 100 (Revision 1328152)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/test/resources/hbase-site.xml


> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258022#comment-13258022
 ] 

Hudson commented on HBASE-3614:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-3614 Expose per-region request rate metrics (Revision 1328140)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java


> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5809) Avoid move api to take the destination server same as the source server.

[Uma Maheswara Rao G (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258021#comment-13258021
 ] 

Uma Maheswara Rao G commented on HBASE-5809:


Thanks Ram.

> Avoid move api to take the destination server same as the source server.
> 
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: ramkrishna.s.vasudevan
>Priority: Minor
>  Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is 
> same as the source we still do unassign and assign.  Here we can have 
> problems due to RegionAlreadyInTransitionException and thus hanging the 
> region in RIT for long time.  We can avoid this scenario by not allowing the 
> move to happen in this scenario.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4464) Make region balancing parallel with balancer.balanceCluster()

[Uma Maheswara Rao G (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258020#comment-13258020
 ] 

Uma Maheswara Rao G commented on HBASE-4464:


One idea is, Balancer can populate the Region plans into Queue from 
LoadBalancer.
HMaster can initiate one thread to process the balancer plans queque. So, 
whenever balancer finalize one plan object, it will put into that queue. 
BalancerQueueProcessor(thread) can pick the plans from queue and process. But 
the current LoadBalancer interface does not take any queue. It will just return 
List of plans from balanceCluster api. Changing interface may be difficult, as 
the LoadBalancer is exposed one. Any alternatives without changing interface?

> Make region balancing parallel with balancer.balanceCluster()
> -
>
> Key: HBASE-4464
> URL: https://issues.apache.org/jira/browse/HBASE-4464
> Project: HBase
>  Issue Type: Improvement
>Reporter: Ted Yu
>
> balancer.balanceCluster() generates RegionPlans for HMaster.balance() to 
> execute.
> We don't retract any RegionPlan in balancer.balanceCluster().
> In the near future, more complex algorithm would be introduced to try 
> achieving maximum block location affinity for the regions to be moved. This 
> means balancer.balanceCluster() would take longer to return.
> This JIRA makes region balancing parallel with balancer.balanceCluster()
> Meaning region balancing would be performed when balancer.balanceCluster() is 
> still running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258019#comment-13258019
 ] 

Hadoop QA commented on HBASE-5831:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523435/5831.remove.all.mapreduce.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 26 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1589//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1589//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1589//console

This message is automatically generated.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5809) Avoid move api to take the destination server same as the source server.

[ramkrishna.s.vasudevan (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258015#comment-13258015
 ] 

ramkrishna.s.vasudevan commented on HBASE-5809:
---

@Uma
I will change this while commit.  Thanks.

> Avoid move api to take the destination server same as the source server.
> 
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.1
>Reporter: ramkrishna.s.vasudevan
>Priority: Minor
>  Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is 
> same as the source we still do unassign and assign.  Here we can have 
> problems due to RegionAlreadyInTransitionException and thus hanging the 
> region in RIT for long time.  We can avoid this scenario by not allowing the 
> move to happen in this scenario.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Todd Lipcon (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258013#comment-13258013
 ] 

Todd Lipcon commented on HBASE-3614:


Gotcha. Apologies for my cluelessness :) Seems fine. Though I think Shaneal's 
percentile stuff would be a nice improvement, what we've got now is at least 
useful.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258011#comment-13258011
 ] 

stack commented on HBASE-3614:
--

@Todd This issue just exposes metrics that were already being collected per 
region.  I believe its over the metrics reporting period (5 seconds?).  Want 
that changed?  Metrics could do w/ a revamp/edit for sure.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Patch Available  (was: Open)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258008#comment-13258008
 ] 

stack commented on HBASE-5831:
--

@Jon Hmm.. yes.  You are right.  Both times it passed.  It was worth committing 
hbase-5794 then.  Now to find the other hanging tests...

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258006#comment-13258006
 ] 

stack commented on HBASE-5833:
--

Eh, Ted, builds.apache.org is a public web site.  I do not need your echoing 
whats there in here.

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Jonathan Hsieh (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257991#comment-13257991
 ] 

Jonathan Hsieh commented on HBASE-5831:
---

@Stack, it seems from the HBASE-5794 patch the mapreduce tests, including 
TestLoadIncrementalHFilesSplitRecovery, were passing. 

https://builds.apache.org/job/PreCommit-HBASE-Build/1587//testReport/org.apache.hadoop.hbase.mapreduce/

The other failures on HBASE-5794 seem somewhat odd however.




> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257989#comment-13257989
 ] 

Hudson commented on HBASE-5824:
---

Integrated in HBase-TRUNK #2790 (See 
[https://builds.apache.org/job/HBase-TRUNK/2790/])
HBASE-5824 addendum fixes coprocessor tests (Jimmy) (Revision 1328166)

 Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorExceptionWithRemove.java


> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5838) Add an LZ4 compression option to HFile

[Andrew Purtell (Created) (JIRA)]

Add an LZ4 compression option to HFile
--

 Key: HBASE-5838
 URL: https://issues.apache.org/jira/browse/HBASE-5838
 Project: HBase
  Issue Type: Improvement
Reporter: Andrew Purtell
Priority: Minor


HADOOP-7657 adds support for LZ4 compression to Hadoop core. As with Snappy, we 
should add reflection based support for this alternative to HFile.Compression. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5803) [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server enhancements from trunk

[Phabricator (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HBASE-5803:
---

Attachment: D2811.5.patch

mbautin updated the revision "[jira] [HBASE-5803] [89-fb] Upgrade hbase 0.89-fb 
to Thrift 0.8.0 and bring Thrift server enhancements from trunk".
Reviewers: sc, nspiegelberg, Kannan, Liyin, JIRA

  Using separate configuration key "namespaces" for Thrift proxy and embedded 
Thrift server: "hbase.thrift." and "hbase.regionserver.thrift." Also using 
different ports by default (9090 for proxy and 9091 for embedded Thrift server).

REVISION DETAIL
  https://reviews.facebook.net/D2811

AFFECTED FILES
  pom.xml
  src/main/java/org/apache/hadoop/hbase/HConstants.java
  src/main/java/org/apache/hadoop/hbase/filter/ParseFilter.java
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
  src/main/java/org/apache/hadoop/hbase/thrift/HThreadedSelectorServerArgs.java
  src/main/java/org/apache/hadoop/hbase/thrift/TBoundedThreadPoolServer.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftMetrics.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
  src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/AlreadyExists.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/ColumnDescriptor.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/IOError.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/IllegalArgument.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/TCell.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/TRegionInfo.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
  src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
  src/main/java/org/apache/hadoop/hbase/util/Bytes.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestCallQueue.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestHsHaServerCmdLine.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestNonblockingServerCmdLine.java
  
src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerFramedCmdLine.java
  
src/test/java/org/apache/hadoop/hbase/thrift/TestThreadPoolServerUnframedCmdLine.java
  
src/test/java/org/apache/hadoop/hbase/thrift/TestThreadedSelectorServerCmdLine.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
  src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
  src/test/java/org/apache/hadoop/hbase/thrift/ThriftServerCmdLineTestBase.java


> [89-fb] Upgrade hbase 0.89-fb to Thrift 0.8.0 and bring Thrift server 
> enhancements from trunk
> -
>
> Key: HBASE-5803
> URL: https://issues.apache.org/jira/browse/HBASE-5803
> Project: HBase
>  Issue Type: Improvement
>Reporter: Mikhail Bautin
>Assignee: Mikhail Bautin
> Attachments: D2811.1.patch, D2811.2.patch, D2811.3.patch, 
> D2811.4.patch, D2811.5.patch
>
>
> TBoundedThreadPoolServer has been a problem for us when there is a large 
> number of clients. We need to migrate to 0.8.0. in 89-fb and bring the 
> relevant improvements from trunk, including supporting 
> TThreadedSelectorServer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Todd Lipcon (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257978#comment-13257978
 ] 

Todd Lipcon commented on HBASE-3614:


Just getting to this after it's committed.. but: what's the time scale of 
"avgtime" on these metrics? Averages that are since boot are kind of useless. 
We should either track the sum of the time, or do a time-biased metric like 
Shaneal added recently in other places.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257971#comment-13257971
 ] 

Zhihong Yu commented on HBASE-5833:
---

In build #380, TestMasterFailover hung again:
{code}
Running org.apache.hadoop.hbase.master.TestMasterFailover
Running org.apache.hadoop.hbase.master.TestClockSkewDetection
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.241 sec
{code}

> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257965#comment-13257965
 ] 

Hadoop QA commented on HBASE-5824:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523437/hbase_5824.addendum
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1588//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1588//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1588//console

This message is automatically generated.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257963#comment-13257963
 ] 

Zhihong Yu commented on HBASE-5824:
---

Integrated addendum to TRUNK.

Thanks for the quick turn around, Jimmy.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257961#comment-13257961
 ] 

Zhihong Yu commented on HBASE-5824:
---

+1 on Addendum.
The two tests pass with addendum:
{code}
  542  mt -Dtest=TestConstraint
  543  mt -Dtest=TestRegionServerCoprocessorExceptionWithRemove
{code}

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257960#comment-13257960
 ] 

Hudson commented on HBASE-5794:
---

Integrated in HBase-TRUNK #2789 (See 
[https://builds.apache.org/job/HBase-TRUNK/2789/])
HBASE-5794 Jenkins builds timing out; undo setting 
hbase.client.retries.number to 100 (Revision 1328152)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/test/resources/hbase-site.xml


> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257946#comment-13257946
 ] 

Hadoop QA commented on HBASE-5794:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523433/5794-v2.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.constraint.TestConstraint
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
  org.apache.hadoop.hbase.regionserver.TestStore

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1587//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1587//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1587//console

This message is automatically generated.

> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257947#comment-13257947
 ] 

Hadoop QA commented on HBASE-5621:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523432/hbase-5621_v3.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 42 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestAtomicOperation
  org.apache.hadoop.hbase.constraint.TestConstraint
  org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
  org.apache.hadoop.hbase.util.TestHBaseFsck
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1586//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1586//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1586//console

This message is automatically generated.

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Status: Patch Available  (was: Reopened)

Fixed the unit tests. Sorry for that.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Attachment: hbase_5824.addendum

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch, 
> hbase_5824.addendum
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5833) 0.92 build has been failing pretty consistently on TestMasterFailover....

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257932#comment-13257932
 ] 

Hudson commented on HBASE-5833:
---

Integrated in HBase-0.92 #380 (See 
[https://builds.apache.org/job/HBase-0.92/380/])
HBASE-5833 0.92 build has been failing pretty consistently on 
TestMasterFailover (Revision 1328098)

 Result = FAILURE
stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java


> 0.92 build has been failing pretty consistently on TestMasterFailover
> -
>
> Key: HBASE-5833
> URL: https://issues.apache.org/jira/browse/HBASE-5833
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.92.2
>
> Attachments: 5833.txt
>
>
> Trunk seems fine but 0.92 fails on this test pretty regularly.  Running it 
> local it seems to hang for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257929#comment-13257929
 ] 

stack commented on HBASE-5794:
--

@Ted v2 does nothing.  It makes the test hbase-site.xml same as the default 
value.

> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257928#comment-13257928
 ] 

Hudson commented on HBASE-5824:
---

Integrated in HBase-TRUNK #2788 (See 
[https://builds.apache.org/job/HBase-TRUNK/2788/])
HBASE-5824 HRegion.incrementColumnValue is not used in trunk (Revision 
1328142)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Attachment: 5831.remove.all.mapreduce.txt

Retry.  Previous run obscured by test failures.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Open  (was: Patch Available)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Hudson (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257927#comment-13257927
 ] 

Hudson commented on HBASE-3614:
---

Integrated in HBase-TRUNK #2788 (See 
[https://builds.apache.org/job/HBase-TRUNK/2788/])
HBASE-3614 Expose per-region request rate metrics (Revision 1328140)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/OperationMetrics.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java


> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257925#comment-13257925
 ] 

stack commented on HBASE-5831:
--

Thanks Jon.  I tried it over in HBASE-5794, setting it back down again, but it 
didn't seen to matter.  I committed the patch there which undoes the 100 
anyways since Mikhail said the change was good for some 0.89fb tests, he wasn't 
sure about trunk.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt, 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5794:
-

   Resolution: Fixed
Fix Version/s: 0.96.0
   Status: Resolved  (was: Patch Available)

Committed.  Mikhail said that upping to 100 helped w/ 0.89fb but wasn't sure 
about trunk.  Putting it back to what it was until we determine we need it up 
this high.

> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5794) Jenkins builds timing out; undo setting hbase.client.retries.number to 100

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5794:
-

Assignee: stack
 Summary: Jenkins builds timing out; undo setting 
hbase.client.retries.number to 100  (was: Jenkins builds timing out)

Change subject to be more pointed.

> Jenkins builds timing out; undo setting hbase.client.retries.number to 100
> --
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5794) Jenkins builds timing out

[Zhihong Yu (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu updated HBASE-5794:
--

Attachment: 5794-v2.txt

> Jenkins builds timing out
> -
>
> Key: HBASE-5794
> URL: https://issues.apache.org/jira/browse/HBASE-5794
> Project: HBase
>  Issue Type: Bug
>Reporter: stack
> Attachments: 5794-v2.txt, 5794.txt, 5794.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5621:
---

Attachment: hbase-5621_v3.patch

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5621:
---

Hadoop Flags: Reviewed
  Status: Patch Available  (was: Open)

@Stack,  thanks a lot for reviewing it.

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5621_v3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Jonathan Hsieh (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257916#comment-13257916
 ] 

Jonathan Hsieh commented on HBASE-5831:
---

I tried the tested in question on trunk and it passes in eclipse.  It fails in 
mvn.  I've encountered this kind of problem previously as well with HBASE-5793 
-- my eclipse setup differs from mvn by not using 
./src/test/resources/hbase-site.xml in the resources dir.

Since the test expects and error, my guess is this may have to do with the 
client retry number getting bumped up to 100 in the resource hbase-site.xml 
file in HBASE-5747.

When I edited that file back down client retries to 10 it passes in about 2 
minutes.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257914#comment-13257914
 ] 

stack commented on HBASE-5621:
--

Want to put your patch up here Jimmy and run it by hadoopqa? Thanks.

> Convert admin protocol of HRegionInterface to PB
> 
>
> Key: HBASE-5621
> URL: https://issues.apache.org/jira/browse/HBASE-5621
> Project: HBase
>  Issue Type: Sub-task
>  Components: ipc, master, migration, regionserver
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257911#comment-13257911
 ] 

Hadoop QA commented on HBASE-5831:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523418/5831.remove.all.mapreduce.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 26 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 7 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.constraint.TestConstraint
  org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1585//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1585//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1585//console

This message is automatically generated.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257912#comment-13257912
 ] 

jirapos...@reviews.apache.org commented on HBASE-5621:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7051
---

Ship it!


I'm good w/ this patch.  Good stuff Jimmy


src/main/java/org/apache/hadoop/hbase/client/HConnection.java


Please file an issue to address this recursion (an AdminProtocol 'has' a 
HConnection but you get the AdminProtocol from an HConnection).



src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java


This is a noop


- Michael


On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4714/
bq.  ---
bq.  
bq.  (Updated 2012-04-19 17:46:17)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the admin part of HBase-5443.  AdminProtocol part.
bq.  
bq.  
bq.  This addresses bug HBASE-5621.
bq.  https://issues.apache.org/jira/browse/HBASE-5621
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 
408db79 
bq.src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 
820e2a9 
bq.src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50 
bq.src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb 
bq.src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15 
bq.src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443 
bq.src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d 
bq.src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8 
bq.
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 
d0570b9 
bq.src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
7239c5a 
bq.src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 
422e865 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 
3d6a23a 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 
a912cc3 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java 
ecaf9fe 
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java 
e78e56d 
bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
61a5988 
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 
759633d 
bq.src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 
7c59995 
bq.
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
 04fe8b6 
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2 
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c 
bq.src/main/protobuf/Admin.proto 132c5dd 
bq.src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 
d6ae0e2 
bq.
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
 3cfc02b 
bq.
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 
8af0f91 
bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b 
bq.src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java 
7dd60de 
bq.src/test/java/org/apache/hadoop/hbase/client/TestHTableUtil.java 24f878e 
bq.
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
 301ee27 
bq.src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java 
a59e152 
bq.src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java 
7ffd6bd 
bq.src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
cedf31e 
bq.src/test/java/org/apache/hadoop/hbase/master/TestMaster.java 3122b15 
bq.src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 
c0ac12c 
bq.
src/test/java/org/apache/hadoop/hbase/r

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257904#comment-13257904
 ] 

Jimmy Xiang commented on HBASE-5824:


I am looking into it.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HBASE-4232) [hbck] Fix should be able to fill info:regioninfo if matching region in fs

[Jonathan Hsieh (Resolved) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-4232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jonathan Hsieh resolved HBASE-4232.
---

Resolution: Duplicate
  Assignee: Jonathan Hsieh

This is the -fixMeta option in the HBASE-5128 hbck improvements.

> [hbck] Fix should be able to fill info:regioninfo if matching region in fs
> --
>
> Key: HBASE-4232
> URL: https://issues.apache.org/jira/browse/HBASE-4232
> Project: HBase
>  Issue Type: Improvement
>Reporter: stack
>Assignee: Jonathan Hsieh
> Attachments: addregion.rb, addregion.rb
>
>
> On Mozilla cluster, hbck reported empty info:regioninfo but then also that 
> there were regions in fs that were not deployed.  At least one of these 
> regions w/ an empty info:regioninfo matches to the region in fs that is not 
> in the .META.  hbck should be able to pick up the region from ms and fix the 
> .META. entry on --fix.
> {code}
> Version: 0.90.1-cdh3u0
> ...
> Number of Tables: 14
> Number of live region servers: 29
> Number of dead region servers: 27
> ..Number of empty REGIONINFO_QUALIFIER rows in .META.: 10
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/10111f37472811e5e86534790bb10e3c
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/1bcaf00897a749ea6a0d0bf1ce709116
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/375913d5c0f5ed4180c0d4506c53fd1d
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/5a1fa81ddf4bac6c7f6483d803d5cc30
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/6240f00ac370c186e44d189d0a52c8e7
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/6bd89ea69b8a4886fed3dfe93ab5e5aa
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/716695118671df66d9d1b883f1aeae56
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/805ce44ef7e6aa7fa1603c422f808a3a
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/8ed41d06b2c8e937cf460ce5e41ecbf9
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/8faa71d5e90aa82570df036515f752e4
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/938f334ca6399ce5a17d33dc1a045d8d
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> ERROR: Region 
> hdfs://hp-admin01.phx1.mozilla.com:8020/hbase/crash_reports/cd673fbac6f8f88f87c81f3bdd3a1ed8
>  on HDFS, b
> ut not listed in META or deployed on any region server.
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Zhihong Yu (Reopened) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhihong Yu reopened HBASE-5824:
---


I can reproduce one of the test failures reported by Hadoop QA:
{code}
testConstraintFails(org.apache.hadoop.hbase.constraint.TestConstraint)  Time 
elapsed: 3.174 sec  <<< ERROR!
org.apache.hadoop.hbase.constraint.ConstraintException: 
org.apache.hadoop.hbase.constraint.ConstraintException: AllFailConstraint fails 
for all puts
...
Caused by: org.apache.hadoop.ipc.RemoteException: 
org.apache.hadoop.hbase.constraint.ConstraintException: AllFailConstraint fails 
for all puts
  at 
org.apache.hadoop.hbase.constraint.AllFailConstraint.check(AllFailConstraint.java:29)
  at 
org.apache.hadoop.hbase.constraint.ConstraintProcessor.prePut(ConstraintProcessor.java:87)
  at 
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.prePut(RegionCoprocessorHost.java:656)
  at org.apache.hadoop.hbase.regionserver.HRegion.internalPut(HRegion.java:2434)
  at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1891)
  at org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:1857)
  at 
org.apache.hadoop.hbase.regionserver.RegionServer.mutate(RegionServer.java:523)
{code}

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257893#comment-13257893
 ] 

Hadoop QA commented on HBASE-5824:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523412/hbase-5824_v2.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.constraint.TestConstraint
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1584//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1584//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1584//console

This message is automatically generated.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5837) hbase shell deleteall to .META. allows insertion of malformed rowkey.

[Jonathan Hsieh (Created) (JIRA)]

hbase shell deleteall to .META. allows insertion of malformed rowkey.
-

 Key: HBASE-5837
 URL: https://issues.apache.org/jira/browse/HBASE-5837
 Project: HBase
  Issue Type: Bug
  Components: master, shell
Affects Versions: 0.90.6
Reporter: Jonathan Hsieh


When using the hbase shell to manipulate meta entries, one is allowed to 
'delete' malformed rows (entries with less than 2 ascii 44 ',' chars).  When 
this happens HBase servers may go down and the cluster will not be restartable 
without manual intervention.  

The delete results in a durable malformed rowkey in .META.'s memstore, .META.'s 
HLog, and eventually .META.'s HFiles.  Subsequent scans to meta (such as when a 
HMaster starts) fail in the scanner because the comparator fails.  In the case 
of an HMaster startup, it causes an abort that kills the HMaster process.


{code}
12/04/18 22:07:34 FATAL master.HMaster: Unhandled exception. Starting shutdown.
org.apache.hadoop.ipc.RemoteException: java.io.IOException: 
java.lang.IllegalArgumentException: No 44 in 
, length=47, offset=54
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.convertThrowableToIOE(HRegionServer.java:990)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.convertThrowableToIOE(HRegionServer.java:979)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.next(HRegionServer.java:1894)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.next(HRegionServer.java:1834)
at sun.reflect.GeneratedMethodAccessor31.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:570)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1039)
Caused by: java.lang.IllegalArgumentException: No 44 in 
, length=47, offset=54
at 
org.apache.hadoop.hbase.KeyValue.getRequiredDelimiterInReverse(KeyValue.java:1300)
at 
org.apache.hadoop.hbase.KeyValue$MetaKeyComparator.compareRows(KeyValue.java:1846)
at 
org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.match(ScanQueryMatcher.java:130)
at org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:257)
at org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:114)
at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.nextInternal(HRegion.java:2435)
at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.next(HRegion.java:2391)
at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScanner.next(HRegion.java:2408)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.next(HRegionServer.java:1870)
... 6 more

at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:771)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Invoker.invoke(HBaseRPC.java:257)
at $Proxy9.next(Unknown Source)
at org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:264)
at org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:237)
at 
org.apache.hadoop.hbase.catalog.MetaReader.fullScanOfResults(MetaReader.java:220)
at 
org.apache.hadoop.hbase.master.AssignmentManager.rebuildUserRegions(AssignmentManager.java:1580)
at 
org.apache.hadoop.hbase.master.AssignmentManager.processFailover(AssignmentManager.java:221)
at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:422)
at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:295)
12/04/18 22:07:34 INFO master.HMaster: Aborting 
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Open  (was: Patch Available)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Patch Available  (was: Open)

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Attachment: 5831.remove.all.mapreduce.txt

Last patch is inconclusive.  The first pass looks to have been a fluke.  Going 
brute force now.  This patch removes all mr tests.  Lets see how many I have to 
remove to get it not hanging anymore.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.all.mapreduce.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5836) Backport per region metrics from HBASE-3614 to 0.94.1

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257886#comment-13257886
 ] 

stack commented on HBASE-5836:
--

+1

> Backport per region metrics from HBASE-3614 to 0.94.1
> -
>
> Key: HBASE-5836
> URL: https://issues.apache.org/jira/browse/HBASE-5836
> Project: HBase
>  Issue Type: Task
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 0.94.1
>
>
> This would be good to have in 0.94.  Can go into 0.94.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257881#comment-13257881
 ] 

Hadoop QA commented on HBASE-5824:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523410/hbase-5824.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.constraint.TestConstraint
  org.apache.hadoop.hbase.replication.TestReplication
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1583//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1583//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1583//console

This message is automatically generated.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5836) Backport per region metrics from HBASE-3614 to 0.94.1

[Elliott Clark (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257882#comment-13257882
 ] 

Elliott Clark commented on HBASE-5836:
--

This will also need HBASE-5788 to keep it as close to trunk as possible.

> Backport per region metrics from HBASE-3614 to 0.94.1
> -
>
> Key: HBASE-5836
> URL: https://issues.apache.org/jira/browse/HBASE-5836
> Project: HBase
>  Issue Type: Task
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 0.94.1
>
>
> This would be good to have in 0.94.  Can go into 0.94.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HBASE-5836) Backport per region metrics from HBASE-3614 to 0.94.1

[Elliott Clark (Assigned) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark reassigned HBASE-5836:


Assignee: Elliott Clark

> Backport per region metrics from HBASE-3614 to 0.94.1
> -
>
> Key: HBASE-5836
> URL: https://issues.apache.org/jira/browse/HBASE-5836
> Project: HBase
>  Issue Type: Task
>Reporter: stack
>Assignee: Elliott Clark
> Fix For: 0.94.1
>
>
> This would be good to have in 0.94.  Can go into 0.94.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5824:
-

   Resolution: Fixed
Fix Version/s: 0.96.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to trunk.  Thanks for patch Jimmy.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5835) [hbck] Catch and handle NotServingRegionException when close region attempt fails

[Jonathan Hsieh (Created) (JIRA)]

[hbck] Catch and handle NotServingRegionException when close region attempt 
fails
-

 Key: HBASE-5835
 URL: https://issues.apache.org/jira/browse/HBASE-5835
 Project: HBase
  Issue Type: Bug
  Components: hbck
Affects Versions: 0.90.7, 0.92.2, 0.94.0, 0.96.0
Reporter: Jonathan Hsieh


Currently, if hbck attempts to close a region and catches a 
NotServerRegionException, hbck may hang outputting a stack trace.  Since the 
goal is to close the region at a particular server, and since it is not serving 
the region, the region is closed, and we should just warn and eat this 
exception.

{code}
Exception in thread "main" org.apache.hadoop.ipc.RemoteException: 
org.apache.hadoop.hbase.NotServingRegionException: Received close for 
 but we are not serving it
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.closeRegion(HRegionServer.java:2162)
at sun.reflect.GeneratedMethodAccessor36.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Server.call(HBaseRPC.java:570)
at org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1039)

at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:771)
at org.apache.hadoop.hbase.ipc.HBaseRPC$Invoker.invoke(HBaseRPC.java:257)
at $Proxy5.closeRegion(Unknown Source)
at 
org.apache.hadoop.hbase.util.HBaseFsckRepair.closeRegionSilentlyAndWait(HBaseFsckRepair.java:165)
at org.apache.hadoop.hbase.util.HBaseFsck.closeRegion(HBaseFsck.java:1185)
at 
org.apache.hadoop.hbase.util.HBaseFsck.checkRegionConsistency(HBaseFsck.java:1302)
at 
org.apache.hadoop.hbase.util.HBaseFsck.checkAndFixConsistency(HBaseFsck.java:1065)
at 
org.apache.hadoop.hbase.util.HBaseFsck.onlineConsistencyRepair(HBaseFsck.java:351)
at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:370)
at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3001)
{code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5836) Backport per region metrics from HBASE-3614 to 0.94.1

[stack (Created) (JIRA)]

Backport per region metrics from HBASE-3614 to 0.94.1
-

 Key: HBASE-5836
 URL: https://issues.apache.org/jira/browse/HBASE-5836
 Project: HBase
  Issue Type: Task
Reporter: stack
 Fix For: 0.94.1


This would be good to have in 0.94.  Can go into 0.94.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3614) Expose per-region request rate metrics

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-3614:
-

   Resolution: Fixed
Fix Version/s: 0.96.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed to trunk (936 tests passed, about same as in previous hangs).  Thanks 
for the patch Elliott.  Let me open an issue against 0.94.1 for backporting to 
see if we can get it in there.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Created] (HBASE-5834) CopyTable usage is incorrect

[Zhihong Yu (Created) (JIRA)]

CopyTable usage is incorrect


 Key: HBASE-5834
 URL: https://issues.apache.org/jira/browse/HBASE-5834
 Project: HBase
  Issue Type: Bug
Reporter: Zhihong Yu


The example given here is outdated:
http://hbase.apache.org/book/ops_mgt.html#copytable

The classes for rs.class and rs.impl don't exist.

Example in Java code needs to be updated as well.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257874#comment-13257874
 ] 

Zhihong Yu commented on HBASE-5824:
---

Minor comment:
The line below exceeds 100 characters.
{code}
+// we need to periodically see if the writebuffer is full instead of 
waiting until the end of the List
{code}

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3614) Expose per-region request rate metrics

[Elliott Clark (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-3614:
-

Attachment: HBASE-3614-9.patch

Address the findbugs warning in HRegion.  Not really a concern as that 
constructor is only used in unit tests.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, HBASE-3614-9.patch, Screen Shot 2012-04-17 at 2.41.27 
> PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5654) [findbugs] Address dodgy bugs

[Jonathan Hsieh (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257871#comment-13257871
 ] 

Jonathan Hsieh commented on HBASE-5654:
---

@stack.  Got it.  Thanks.  

> [findbugs] Address dodgy bugs
> -
>
> Key: HBASE-5654
> URL: https://issues.apache.org/jira/browse/HBASE-5654
> Project: HBase
>  Issue Type: Sub-task
>  Components: scripts
>Affects Versions: 0.96.0
>Reporter: Jonathan Hsieh
>Assignee: Ashutosh Jindal
>  Labels: patch
> Fix For: 0.96.0
>
> Attachments: Hbase 5654_v3.patch, Hbase-5654.patch, 
> Hbase_5654_V2.patch
>
>
> See 
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_STYLE
> This may be broken down further.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5635) If getTaskList() returns null splitlogWorker is down. It wont serve any requests.

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257869#comment-13257869
 ] 

Zhihong Yu commented on HBASE-5635:
---

@Anoop:
"hbase.splitlog.zk.retries" is used by SplitLogManager

Does anyone have comment about latest patch ?

> If getTaskList() returns null splitlogWorker is down. It wont serve any 
> requests. 
> --
>
> Key: HBASE-5635
> URL: https://issues.apache.org/jira/browse/HBASE-5635
> Project: HBase
>  Issue Type: Bug
>  Components: wal
>Affects Versions: 0.92.1
>Reporter: Kristam Subba Swathi
> Attachments: HBASE-5635.1.patch, HBASE-5635.2.patch, HBASE-5635.patch
>
>
> During the hlog split operation if all the zookeepers are down ,then the 
> paths will be returned as null and the splitworker thread wil be exited
> Now this regionserver wil not be able to acquire any other tasks since the 
> splitworker thread is exited
> Please find the attached code for more details
> {code}
> private List getTaskList() {
> for (int i = 0; i < zkretries; i++) {
>   try {
> return (ZKUtil.listChildrenAndWatchForNewChildren(this.watcher,
> this.watcher.splitLogZNode));
>   } catch (KeeperException e) {
> LOG.warn("Could not get children of znode " +
> this.watcher.splitLogZNode, e);
> try {
>   Thread.sleep(1000);
> } catch (InterruptedException e1) {
>   LOG.warn("Interrupted while trying to get task list ...", e1);
>   Thread.currentThread().interrupt();
>   return null;
> }
>   }
> }
> {code}
> in the org.apache.hadoop.hbase.regionserver.SplitLogWorker 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257865#comment-13257865
 ] 

Jimmy Xiang commented on HBASE-5824:


If autoFlush is not enabled, Puts are most likely batched.  It is not very 
efficient to check if a batch contains only one Put, which is kind of duplicate 
some of the multiput logic.

You can say the patch is not strictly for single put.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Zhihong Yu (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257859#comment-13257859
 ] 

Zhihong Yu commented on HBASE-5824:
---

{code}
+if (autoFlush && puts.size() == 1) {
{code}
How is autoFlush related to single put ?

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Status: Patch Available  (was: Open)

I added a deprecation annotation to HRegion#incrementColumnValue

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Attachment: hbase-5824_v2.patch

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Status: Open  (was: Patch Available)

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch, hbase-5824_v2.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257849#comment-13257849
 ] 

stack commented on HBASE-5824:
--

+1 on the Jimmy patch.

@Elliott At least add a deprecate pointing to preferred code I'd say?

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Elliott Clark (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257848#comment-13257848
 ] 

Elliott Clark commented on HBASE-5824:
--

Looking through it everything seems to be good.  I can't see anything that ICV 
does that increment doesn't.

Should the old code get removed then ?

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257847#comment-13257847
 ] 

Hadoop QA commented on HBASE-3614:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523401/HBASE-3614-8.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1582//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1582//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1582//console

This message is automatically generated.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, Screen Shot 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Status: Patch Available  (was: Open)

This patch is to enhance single puts to use mutate directly instead of multiput.

For HRegion#incrementColumnValue, I think it is ok not to use it.

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5824) HRegion.incrementColumnValue is not used in trunk

[Jimmy Xiang (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jimmy Xiang updated HBASE-5824:
---

Attachment: hbase-5824.patch

> HRegion.incrementColumnValue is not used in trunk
> -
>
> Key: HBASE-5824
> URL: https://issues.apache.org/jira/browse/HBASE-5824
> Project: HBase
>  Issue Type: Bug
>Reporter: Elliott Clark
>Assignee: Jimmy Xiang
> Attachments: hbase-5824.patch
>
>
> on 0.94 a call to client.HTable#incrementColumnValue will cause 
> HRegion#incrementColumnValue.  On trunk all calls to 
> HTable.incrementColumnValue got to HRegion#increment.
> My guess is that HTable#incrementColumnValue and HTable#increment serialize 
> to the same thing over the wire so that the remote HRegionServer no longer 
> knows which htable method was called.
> To repro I checked out trunk and put a break point in 
> HRegion#incrementColumnValue and then ran TestFromClientSide.  The breakpoint 
> wasn't hit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257837#comment-13257837
 ] 

jirapos...@reviews.apache.org commented on HBASE-5621:
--



bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  >

I did a rebase. So it picked up some other changes if you diff 2 from 3.


bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  > security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java, 
line 50
bq.  > 
bq.  >
bq.  > There are a bunch of import changes here.  Are they all needed?

It must be from other patch.  This patch doesn't touch this file.


bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  > security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java, 
line 187
bq.  > 
bq.  >
bq.  > Why can we get away w/ removing the try/catch?  Because the caller 
handles it?

That change in diff2 is already checked in as part of 5443 addendum.  That's 
why it shows some change here.  This patch doesn't change this file.


bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, 
line 411
bq.  > 

bq.  >
bq.  > Does this belong in this patch?  Is it part of another patch?

bq. From another patch due to rebasing.


bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java, 
line 2220
bq.  > 

bq.  >
bq.  > Yeah, this stuff is from another patch?  Why you adding it?

bq. From another patch due to rebasing.


bq.  On 2012-04-19 20:43:31, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java, 
line 2214
bq.  > 

bq.  >
bq.  > Are these from Elliotts' patch?
bq.  > 
bq.  > Maybe its reviewboard that is messing up?  I'm only looking at diff 
between your v2 and v3 patch.

bq. From another patch due to rebasing.


- Jimmy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7046
---


On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4714/
bq.  ---
bq.  
bq.  (Updated 2012-04-19 17:46:17)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the admin part of HBase-5443.  AdminProtocol part.
bq.  
bq.  
bq.  This addresses bug HBASE-5621.
bq.  https://issues.apache.org/jira/browse/HBASE-5621
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 
408db79 
bq.src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 
820e2a9 
bq.src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50 
bq.src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb 
bq.src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15 
bq.src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443 
bq.src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d 
bq.src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8 
bq.
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 
d0570b9 
bq.src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
7239c5a 
bq.src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 
422e865 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 
3d6a23a 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 
a912cc3 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java 
ecaf9fe 
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java 
e78e56d 
bq.src/main/java/org/a

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in "backup mode"

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257834#comment-13257834
 ] 

Jesse Yates commented on HBASE-5547:


bq. Maybe checking existence is cheaper than reading znode content though?

I don't think it would be appreciable. It still has to to go memory to check 
existence, so the only loss is the time to write the content over the wire 
(negligible in our case when we have around a 1KB of configuration info).

bq. If we had a Configuration or Table znode, it could read the content

Certainly. But then there is the work to finish that code (HBASE-3909 if I'm 
not mistaken), which still seems a long way off. 

This may all (except for the table config stuff, which would be an arguably 
'better' version) be moot as I do have a version working now that does 
synchronous checking to make sure that all necessary RS received the update 
have updated zk that they have received the notification. Avoids the problem of 
splits/merges per region as its all on the RS level. There is still a bit of 
cleanup I need to do on the patch before posting the another review, but the 
core of the functionality is there.


> Don't delete HFiles when in "backup mode"
> -
>
> Key: HBASE-5547
> URL: https://issues.apache.org/jira/browse/HBASE-5547
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Jesse Yates
>
> This came up in a discussion I had with Stack.
> It would be nice if HBase could be notified that a backup is in progress (via 
> a znode for example) and in that case either:
> 1. rename HFiles to be delete to .bck
> 2. rename the HFiles into a special directory
> 3. rename them to a general trash directory (which would not need to be tied 
> to backup mode).
> That way it should be able to get a consistent backup based on HFiles (HDFS 
> snapshots or hard links would be better options here, but we do not have 
> those).
> #1 makes cleanup a bit harder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5548) Add ability to get a table in the shell

[Jesse Yates (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257829#comment-13257829
 ] 

Jesse Yates commented on HBASE-5548:


bq. Seems like an issue?

yeah, I think so. Odd that I missed that, though I may have made some changes 
and not done all the testing I should have. I'll take a look.

bq. Also in the help, talks about a table reference without explaining what it 
is (there is no mention of what this is in the general help either it seems). 
It could be confusing talking about a 't' w/o saying where it came from?

Yeah, that can be confusing. I'll clean it up a bit.

bq. In the rest of the shell columns are a combo of family and qualifier 
delimited by the ':'. You are changing that w/ the above.

Fair enough, though I would argue this is cleaner, but I switch it over for 
this patch.

Thanks for giving it a spin stack!

> Add ability to get a table in the shell
> ---
>
> Key: HBASE-5548
> URL: https://issues.apache.org/jira/browse/HBASE-5548
> Project: HBase
>  Issue Type: Improvement
>  Components: shell
>Reporter: Jesse Yates
>Assignee: Jesse Yates
> Fix For: 0.96.0, 0.94.1
>
> Attachments: ruby_HBASE-5528-v0.patch, ruby_HBASE-5548-v1.patch, 
> ruby_HBASE-5548-v2.patch, ruby_HBASE-5548-v3.patch
>
>
> Currently, all the commands that operate on a table in the shell first have 
> to take the table as name as input. 
> There are two main considerations:
> * It is annoying to have to write the table name every time, when you should 
> just be able to get a reference to a table
> * the current implementation is very wasteful - it creates a new HTable for 
> each call (but reuses the connection since it uses the same configuration)
> We should be able to get a handle to a single HTable and then operate on that.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[Hadoop QA (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257826#comment-13257826
 ] 

Hadoop QA commented on HBASE-5831:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12523399/5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 2 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1581//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1581//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1581//console

This message is automatically generated.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in "backup mode"

[Lars Hofhansl (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257818#comment-13257818
 ] 

Lars Hofhansl commented on HBASE-5547:
--

For this I was actually thinking a single cluster-wide setting ("This HBase 
cluster is now in backup mode"), which would affect all tables would be 
sufficient.

But could do per table as well as Jesse has done and it definitely does not 
need to be a custom znode, checking a value is fine.


> Don't delete HFiles when in "backup mode"
> -
>
> Key: HBASE-5547
> URL: https://issues.apache.org/jira/browse/HBASE-5547
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Jesse Yates
>
> This came up in a discussion I had with Stack.
> It would be nice if HBase could be notified that a backup is in progress (via 
> a znode for example) and in that case either:
> 1. rename HFiles to be delete to .bck
> 2. rename the HFiles into a special directory
> 3. rename them to a general trash directory (which would not need to be tied 
> to backup mode).
> That way it should be able to get a consistent backup based on HFiles (HDFS 
> snapshots or hard links would be better options here, but we do not have 
> those).
> #1 makes cleanup a bit harder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5547) Don't delete HFiles when in "backup mode"

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257810#comment-13257810
 ] 

stack commented on HBASE-5547:
--

bq. To get a guaranteed consistent snapshot the RegionServers need to check for 
the znode's value synchronously in the delete path (or at least I see no other 
way).  Otherwise there are times when the RegionServers do not agree and some 
files will be deleted and some will be backed up with no possibility for the 
client to know exactly as of when the backup would be consistent.

This would make for the narrowest possible window regards whether backup is on 
or off.

Does it have to be a custom znode?  If we had a Configuration or Table znode, 
it could read the content?  Maybe checking existence is cheaper than reading 
znode content though?



> Don't delete HFiles when in "backup mode"
> -
>
> Key: HBASE-5547
> URL: https://issues.apache.org/jira/browse/HBASE-5547
> Project: HBase
>  Issue Type: New Feature
>Reporter: Lars Hofhansl
>Assignee: Jesse Yates
>
> This came up in a discussion I had with Stack.
> It would be nice if HBase could be notified that a backup is in progress (via 
> a znode for example) and in that case either:
> 1. rename HFiles to be delete to .bck
> 2. rename the HFiles into a special directory
> 3. rename them to a general trash directory (which would not need to be tied 
> to backup mode).
> That way it should be able to get a consistent backup based on HFiles (HDFS 
> snapshots or hard links would be better options here, but we do not have 
> those).
> #1 makes cleanup a bit harder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3614) Expose per-region request rate metrics

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-3614:
-

Status: Patch Available  (was: Open)

Trying against hadoopqa

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, Screen Shot 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[Elliott Clark (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257797#comment-13257797
 ] 

Elliott Clark commented on HBASE-3614:
--

And I beat you to the rename :-)  is opMetrics alright.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, Screen Shot 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5621) Convert admin protocol of HRegionInterface to PB

[jirapos...@reviews.apache.org (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257796#comment-13257796
 ] 

jirapos...@reviews.apache.org commented on HBASE-5621:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4714/#review7046
---



security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java


There are a bunch of import changes here.  Are they all needed?



security/src/main/java/org/apache/hadoop/hbase/ipc/SecureRpcEngine.java


Why can we get away w/ removing the try/catch?  Because the caller handles 
it?



src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java


good



src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


Does this belong in this patch?  Is it part of another patch?



src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


Yeah, this stuff is from another patch?  Why you adding it?



src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java


Are these from Elliotts' patch?

Maybe its reviewboard that is messing up?  I'm only looking at diff between 
your v2 and v3 patch.


- Michael


On 2012-04-19 17:46:17, Jimmy Xiang wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4714/
bq.  ---
bq.  
bq.  (Updated 2012-04-19 17:46:17)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  This is the admin part of HBase-5443.  AdminProtocol part.
bq.  
bq.  
bq.  This addresses bug HBASE-5621.
bq.  https://issues.apache.org/jira/browse/HBASE-5621
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 
408db79 
bq.src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java 
PRE-CREATION 
bq.src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java ee16e72 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnection.java 23f8e5a 
bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java 
820e2a9 
bq.src/main/java/org/apache/hadoop/hbase/client/HTable.java 2c87d50 
bq.src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java cd4cccb 
bq.src/main/java/org/apache/hadoop/hbase/ipc/ExecRPCInvoker.java 2fc4a15 
bq.src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 57c9443 
bq.src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 52d179d 
bq.src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 09601b8 
bq.
src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java 
d0570b9 
bq.src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
7239c5a 
bq.src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 70901fe 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/AdminProtocol.java 
422e865 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ClientProtocol.java 
3d6a23a 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java b056830 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java 
a912cc3 
bq.src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java 
ecaf9fe 
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java 
e78e56d 
bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
61a5988 
bq.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java 
759633d 
bq.src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java 
7c59995 
bq.
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
 04fe8b6 
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 66156c2 
bq.src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 83a165c 
bq.src/main/protobuf/Admin.proto 132c5dd 
bq.src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 
d6ae0e2 
bq.
src/test/java/org/apache/hadoop/hbase/catalog/TestMetaReaderEditorNoCluster.java
 3cfc02b 
bq.
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java 
8af0f91 
bq.src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java aa7f51b 
bq.src/test/java

[jira] [Updated] (HBASE-3614) Expose per-region request rate metrics

[Elliott Clark (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-3614:
-

Attachment: HBASE-3614-8.patch

Fixed the spelling.

The null is there because we can get a multi put where each of the puts is for 
different cf's.  Since we only time the total operation we're not sure which cf 
to assign the operation time to.  It was put in __unknown previously.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, 
> HBASE-3614-8.patch, Screen Shot 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-3614) Expose per-region request rate metrics

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257787#comment-13257787
 ] 

stack commented on HBASE-3614:
--

Since you renamed RegionOperationMetrics, is this right now:

{code}
+  private final OperationMetrics regionMetrics;
{code}

Should it be named metrics or operationMetrics?

Whats 'unknown' in the following? +  //null will be treated as unknown.

We are updating metrics w/o attributing them to a cf?

Fix misspell 'Inctement' in hbase-site change

Patch is good to go after addressing above.  Good stuff.







> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, Screen Shot 
> 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-3614) Expose per-region request rate metrics

[Elliott Clark (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-3614:
-

Attachment: HBASE-3614-7.patch

Rename the field in HRegion to mirror the new class name.

> Expose per-region request rate metrics
> --
>
> Key: HBASE-3614
> URL: https://issues.apache.org/jira/browse/HBASE-3614
> Project: HBase
>  Issue Type: Improvement
>  Components: metrics, regionserver
>Reporter: Gary Helmling
>Assignee: Elliott Clark
>Priority: Minor
> Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, 
> HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, 
> HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, Screen Shot 
> 2012-04-17 at 2.41.27 PM.png
>
>
> We currently export metrics on request rates for each region server, and this 
> can help with identifying uneven load at a high level. But once you see a 
> given server under high load, you're forced to extrapolate based on your 
> application patterns and the data it's serving what the likely culprit is.  
> This can and should be much easier if we just exported request rate metrics 
> per-region on each server.
> Dynamically updating the metrics keys based on assigned regions may pose some 
> minor challenges, but this seems a very valuable diagnostic tool to have 
> available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Status: Patch Available  (was: Open)

Trying again for a clean, non-hanging build

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5831) hadoopqa builds not completing

[stack (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257773#comment-13257773
 ] 

stack commented on HBASE-5831:
--

@Todd That'd be nice (smile)

This test run did 936 tests which is more than normal.  Let me try again.

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-5831) hadoopqa builds not completing

[stack (Updated) (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5831:
-

Attachment: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt

> hadoopqa builds not completing
> --
>
> Key: HBASE-5831
> URL: https://issues.apache.org/jira/browse/HBASE-5831
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Reporter: stack
>Assignee: stack
>Priority: Blocker
> Attachments: 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt, 
> 5831.remove.TestLoadIncrementalHFilesSplitRecovery.txt
>
>
> No test failures but build complains it has failed.  trunk build seems to 
> have the same affliction:
> {code}
> Results :
> Tests run: 909, Failures: 0, Errors: 0, Skipped: 9
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time: 41:19.273s
> [INFO] Finished at: Wed Apr 18 21:54:31 UTC 2012
> [INFO] Final Memory: 59M/451M
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.12-TRUNK-HBASE-2:test 
> (secondPartTestsExecution) on project hbase: Failure or timeout -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> -1 overall.  Here are the results of testing the latest attachment 
>   http://issues.apache.org/jira/secure/attachment/12523250/5811+%281%29.txt
>   against trunk revision .
> +1 @author.  The patch does not contain any @author tags.
> +1 tests included.  The patch appears to include 3 new or modified tests.
> +1 javadoc.  The javadoc tool did not generate any warning messages.
> +1 javac.  The applied patch does not increase the total number of javac 
> compiler warnings.
> -1 findbugs.  The patch appears to introduce 6 new Findbugs (version 
> 1.3.9) warnings.
> +1 release audit.  The applied patch does not increase the total number 
> of release audit warnings.
>  -1 core tests.  The patch failed these unit tests:
> {code}
> Its not apparent that any particular test is not finishing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira