[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904868#comment-16904868
]
Hudson commented on HBASE-22725:
Results for branch branch-2.0
[build #1853 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1853/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1853//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1853//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1853//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904867#comment-16904867
]
Hudson commented on HBASE-22725:
Results for branch branch-1.3
[build #913 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/913/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/913//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/913//JDK7_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.3/913//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520305714 > IIRC, `gracefully_stop.sh` will turn balancer off, move regions, stop/restart RS, then turn balancer on. > > And there's one script `rolling_restart.sh` relying on `gracefully_stop.sh`, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level. > > One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty. > > I incline to keep it still, and so, leave my -0. graceful_stop.sh turns on balancer at the end conditionally. If -nob arg is provided, it won't: [here](https://github.com/apache/hbase/blob/master/bin/graceful_stop.sh#L178) rolling_restart.sh provides that arg [here](https://github.com/apache/hbase/blob/master/bin/rolling-restart.sh#L218) rolling_restart itself taking care of turning the balancer on/off makes sense rather than gracefu_stop taking care of it for rolling_restart. Even if it didn't, it could still run into the possibility of running balancer in between rolling restart of RegionServers, which should not happen provided we move regions back and forth anyways [here](https://github.com/apache/hbase/blob/e9382154f32d7b552eb42e262a22bc44f57a7f1b/bin/graceful_stop.sh#L170). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-520302491 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 199 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 393 | master passed | | +1 | compile | 101 | master passed | | +1 | checkstyle | 139 | master passed | | +1 | shadedjars | 348 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 70 | master passed | | 0 | spotbugs | 325 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 407 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 404 | the patch passed | | +1 | compile | 101 | the patch passed | | +1 | javac | 101 | the patch passed | | +1 | checkstyle | 125 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 342 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1286 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 71 | the patch passed | | +1 | findbugs | 420 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 128 | hbase-client in the patch passed. | | -1 | unit | 17472 | hbase-server in the patch failed. | | +1 | asflicense | 53 | The patch does not generate ASF License warnings. | | | | 22633 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.tool.TestBulkLoadHFiles | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 39836e5964e2 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/2/testReport/ | | Max. process+thread count | 5129 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-520302143 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 63 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 320 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 114 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 245 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 315 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 310 | the patch passed | | +1 | compile | 78 | the patch passed | | +1 | javac | 78 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 1 | The patch has no whitespace issues. | | +1 | shadedjars | 276 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 961 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 319 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 114 | hbase-client in the patch passed. | | -1 | unit | 18476 | hbase-server in the patch failed. | | +1 | asflicense | 58 | The patch does not generate ASF License warnings. | | | | 22417 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.namespace.TestNamespaceAuditor | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/90/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux dc59cf545888 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/90/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/90/testReport/ | | Max. process+thread count | 4879 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/90/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-520301769 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 106 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 346 | master passed | | +1 | compile | 71 | master passed | | +1 | checkstyle | 75 | master passed | | +1 | shadedjars | 320 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 42 | master passed | | 0 | spotbugs | 251 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 248 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 331 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 283 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1015 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 262 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 18521 | hbase-server in the patch failed. | | +1 | asflicense | 22 | The patch does not generate ASF License warnings. | | | | 22199 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.replication.TestReplicationSmallTests | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/34/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 467d2059e449 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446@2/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/34/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/34/testReport/ | | Max. process+thread count | 4967 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/34/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal
Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal URL: https://github.com/apache/hbase/pull/471#issuecomment-520300142 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 56 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 352 | master passed | | +1 | compile | 59 | master passed | | +1 | checkstyle | 83 | master passed | | +1 | shadedjars | 315 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 251 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 249 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 300 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 269 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1014 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 44 | the patch passed | | +1 | findbugs | 263 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17724 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 21363 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestSnapshotTemporaryDirectory | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/471 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux b7ef5a345a08 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-471/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/3/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/3/testReport/ | | Max. process+thread count | 5005 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-520300061 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 266 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 588 | master passed | | +1 | compile | 110 | master passed | | +1 | checkstyle | 113 | master passed | | +1 | shadedjars | 321 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 78 | master passed | | 0 | spotbugs | 235 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 324 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 333 | the patch passed | | +1 | compile | 103 | the patch passed | | +1 | javac | 103 | the patch passed | | -1 | checkstyle | 70 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 1 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 900 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 75 | the patch passed | | -1 | findbugs | 58 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 181 | hbase-common in the patch passed. | | -1 | unit | 16084 | hbase-server in the patch failed. | | +1 | unit | 515 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 76 | The patch does not generate ASF License warnings. | | | | 21290 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicas | | | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 0bc3017cf497 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/artifact/out/new-findbugs-hbase-common.html | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/testReport/ | | Max. process+thread count | 4690 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/36/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[
https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904848#comment-16904848
]
Hudson commented on HBASE-22725:
Results for branch branch-1.4
[build #952 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/952/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/952//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/952//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/952//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Remove all remaining javadoc warnings
> --
>
> Key: HBASE-22725
> URL: https://issues.apache.org/jira/browse/HBASE-22725
> Project: HBase
> Issue Type: Test
> Components: test
>Affects Versions: 3.0.0
>Reporter: Murtaza Hassan
>Assignee: Murtaza Hassan
>Priority: Trivial
> Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (HBASE-22012) SpaceQuota DisableTableViolationPolicy will cause cycles of enable/disable table
[ https://issues.apache.org/jira/browse/HBASE-22012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shardul Singh reassigned HBASE-22012: - Assignee: Shardul Singh (was: Nihal Jain) > SpaceQuota DisableTableViolationPolicy will cause cycles of enable/disable > table > > > Key: HBASE-22012 > URL: https://issues.apache.org/jira/browse/HBASE-22012 > Project: HBase > Issue Type: Bug >Affects Versions: 3.0.0, 2.2.1 >Reporter: Ajeet Rai >Assignee: Shardul Singh >Priority: Major > Labels: Quota, Space > > Space Quota: Policy state is getting changed from disable to Observance after > sometime automatically. > Steps: > 1: Create a table with space quota policy as Disable > 2: Put some data so that table state is in space quota violation > 3: So observe that table state is in violation > 4: Now wait for some time > 5: Observe that after some time table state is changing to to Observance > however table is still disabled > edit (elserj): The table is automatically moved back from the violation state > because of the code added that tried to ride over RITs. When a Region is not > online (whether normally or abnormally), the RegionSizeReports are not sent > from RS to Master. Eventually, enough Regions are not reported which dips > below the acceptable threshold and we automatically move the table back to > the "acceptable" space quota state (not in violation). We could skip this > failsafe when we're checking for a quota that has the DisableTable violation > policy. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] chenxu14 commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
chenxu14 commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312779366
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -502,8 +504,10 @@ public Cacheable getBlock(BlockCacheKey key, boolean
caching, boolean repeat,
// block will use the refCnt of bucketEntry, which means if two
HFileBlock mapping to
// the same BucketEntry, then all of the three will share the same
refCnt.
Cacheable cachedBlock = ioEngine.read(bucketEntry);
- // RPC start to reference, so retain here.
- cachedBlock.retain();
+ if (ioEngine.usesSharedMemory()) {
Review comment:
The eviction policy will compare BucketEntry with it’s accessCounter, so
this will not violate the LRU?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #472: HBASE-22829 Removed deprecated methods from SnapshotDescription
Apache-HBase commented on issue #472: HBASE-22829 Removed deprecated methods from SnapshotDescription URL: https://github.com/apache/hbase/pull/472#issuecomment-520295328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 145 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 49 | Maven dependency ordering for branch | | +1 | mvninstall | 488 | master passed | | +1 | compile | 102 | master passed | | +1 | checkstyle | 127 | master passed | | +1 | shadedjars | 335 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 69 | master passed | | 0 | spotbugs | 286 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 364 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 18 | Maven dependency ordering for patch | | +1 | mvninstall | 413 | the patch passed | | +1 | compile | 102 | the patch passed | | +1 | javac | 102 | the patch passed | | +1 | checkstyle | 133 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 337 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1286 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 68 | the patch passed | | +1 | findbugs | 396 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 115 | hbase-client in the patch passed. | | +1 | unit | 13668 | hbase-server in the patch passed. | | +1 | asflicense | 46 | The patch does not generate ASF License warnings. | | | | 18751 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/472 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a7f8081f4bfc 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-472@2/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/testReport/ | | Max. process+thread count | 4788 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#issuecomment-520293593 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 65 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 339 | master passed | | +1 | compile | 80 | master passed | | +1 | checkstyle | 117 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 55 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 288 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 79 | the patch passed | | +1 | javac | 79 | the patch passed | | +1 | checkstyle | 112 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 298 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1011 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 327 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 176 | hbase-common in the patch passed. | | -1 | unit | 13548 | hbase-server in the patch failed. | | +1 | asflicense | 56 | The patch does not generate ASF License warnings. | | | | 17690 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/467 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux a949804a27ce 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-467/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/10/testReport/ | | Max. process+thread count | 4711 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd edited a comment on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Reidd edited a comment on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520290804 IIRC, `gracefully_stop.sh` will turn balancer off, move regions, stop/restart RS, then turn balancer on. And there's one script `rolling_restart.sh` relying on `gracefully_stop.sh`, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level. One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty. I incline to keep it still, and so, leave my -0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Reidddddd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Reidd commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520290804 IIRC, `gracefully_stop.sh` will turn balancer off, move regions, then turn balancer on. And there's one script `rolling_restart.sh` relying on `gracefully_stop.sh`, will repeat the mentioned process. If the RS number in rolling restart is large which is often the case in production env---hundreds at least, the master inside will cancel and remove task then construct a new task back and forth, at JVM level. One step back, current impl brings no harm to master nor good, but the new impl looks like may bring a new uncertainty. I incline to keep it still, and so, leave my -0. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation
Apache-HBase commented on issue #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478#issuecomment-520290767 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 71 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 337 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 121 | master passed | | +1 | shadedjars | 301 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 61 | master passed | | 0 | spotbugs | 276 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 348 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 338 | the patch passed | | +1 | compile | 85 | the patch passed | | +1 | javac | 85 | the patch passed | | +1 | checkstyle | 124 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1057 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 59 | the patch passed | | +1 | findbugs | 372 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 106 | hbase-client in the patch passed. | | -1 | unit | 14156 | hbase-server in the patch failed. | | +1 | asflicense | 50 | The patch does not generate ASF License warnings. | | | | 18451 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/478 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 9830db2de720 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-478/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/1/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/1/testReport/ | | Max. process+thread count | 5030 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-478/1/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-520289561 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | 0 | shelldocs | 1 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 38 | Maven dependency ordering for branch | | +1 | mvninstall | 342 | master passed | | +1 | compile | 190 | master passed | | +1 | checkstyle | 158 | master passed | | +1 | shadedjars | 287 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 184 | master passed | | 0 | spotbugs | 31 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 30 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 318 | the patch passed | | +1 | compile | 190 | the patch passed | | +1 | javac | 190 | the patch passed | | +1 | checkstyle | 148 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 4 | The patch has no ill-formed XML file. | | +1 | shadedjars | 296 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1014 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 196 | the patch passed | | 0 | findbugs | 30 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | -1 | unit | 9434 | root in the patch failed. | | +1 | asflicense | 65 | The patch does not generate ASF License warnings. | | | | 15294 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.replication.TestSyncReplicationStandbyKillRS | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux da0f1a6f86b6 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476@2/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/3/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/3/testReport/ | | Max. process+thread count | 5026 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/3/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520285306 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 90 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 340 | master passed | | +1 | compile | 55 | master passed | | +1 | checkstyle | 78 | master passed | | +1 | shadedjars | 274 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 267 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 265 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 55 | the patch passed | | +1 | javac | 55 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 271 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 931 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 39 | the patch passed | | +1 | findbugs | 259 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8990 | hbase-server in the patch passed. | | +1 | asflicense | 23 | The patch does not generate ASF License warnings. | | | | 12452 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 72d2c3357bee 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/testReport/ | | Max. process+thread count | 4731 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/11/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zheng Hu resolved HBASE-22833.
--
Resolution: Won't Fix
Mark it as Won't fix now. Feel free to reopen this issue if any question,
[~titsuki], Thanks.
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Priority: Minor
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
[
https://issues.apache.org/jira/browse/HBASE-22833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904800#comment-16904800
]
Zheng Hu commented on HBASE-22833:
--
I think we did not expand the MultiRowRangeFilter as multiple start/stop
ranges because the MultiRowRangeFilter can combined with other filters by
FilterList (while the start/stop ranges couldn't ) ? the performance should
have no difference. We have a post about this before
:http://openinx.github.io/2019/07/02/blog-for-filter-list , (Maybe need some
google translation for you) it may help for you.
> MultiRowRangeFilter should provide a method for creating a filter which is
> functionally equivalent to multiple prefix filters
> -
>
> Key: HBASE-22833
> URL: https://issues.apache.org/jira/browse/HBASE-22833
> Project: HBase
> Issue Type: Wish
> Components: Client
>Affects Versions: 3.0.0
>Reporter: Itsuki Toyota
>Priority: Minor
>
> HI,
> I think current formal way to make multiple prefix filters is to create a
> _FilterList_ and add _PrefixFilter_ instances to the list:
> {code:java}
> FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
> allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
> scan.setFilter(allFilters);
> {code}
> (c.f.,
> https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
> )
> However, in the case of creating a single prefix filter, HBase provides
> _scan.setRowPrefixFilter_ method.
> This method creates a range filter by setting a start row and a stop row.
> The value of a stop row is decided by calling
> _calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
> )
> _MultiRowRangeFilter_ could leverage a list of start row and stop row pairs
> and _calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
> corresponding to given start row (i.e., a prefix).
> I think this kind of filter (a filter which is functionally equivalent to
> multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and
> it's better than the current formal way.
> Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-520283931 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 72 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 321 | master passed | | +1 | compile | 54 | master passed | | +1 | checkstyle | 72 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 35 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 239 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 288 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | -1 | checkstyle | 69 | hbase-server: The patch generated 2 new + 64 unchanged - 0 fixed = 66 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 259 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 890 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 38 | the patch passed | | +1 | findbugs | 246 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8352 | hbase-server in the patch passed. | | +1 | asflicense | 31 | The patch does not generate ASF License warnings. | | | | 11646 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/41/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux aaddbfc34e32 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/41/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/41/testReport/ | | Max. process+thread count | 4865 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/41/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312767807
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -502,8 +504,10 @@ public Cacheable getBlock(BlockCacheKey key, boolean
caching, boolean repeat,
// block will use the refCnt of bucketEntry, which means if two
HFileBlock mapping to
// the same BucketEntry, then all of the three will share the same
refCnt.
Cacheable cachedBlock = ioEngine.read(bucketEntry);
- // RPC start to reference, so retain here.
- cachedBlock.retain();
+ if (ioEngine.usesSharedMemory()) {
Review comment:
One big concern here: now for exclusive memory IOEngine, the refCnt value
of all bucketEntry will be 1, means the reference from BucketCache, no RPC
reference. Then I think the BucketCache's eviction policy would always evict
those blocks despite that the RPC is still using the block, not say the memory
leak issue , but the eviction policy is evicting those RPC referring blocks
(violate the LRU ? )
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312767928
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketEntry.java
##
@@ -194,7 +194,10 @@ boolean isRpcRef() {
}
Cacheable wrapAsCacheable(ByteBuffer[] buffers) throws IOException {
-ByteBuff buf = ByteBuff.wrap(buffers, this.refCnt);
+return wrapAsCacheable(ByteBuff.wrap(buffers, this.refCnt));
+ }
+
+ Cacheable wrapAsCacheable(ByteBuff buf) throws IOException {
Review comment:
That's a good thing, make the wrapAsCacheable into two methods. the
SharedIOEngine use the former one, and the ExclusiveIOEngine use the later
one.Good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312765622
##
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java
##
@@ -475,6 +486,32 @@ public static int channelRead(ReadableByteChannel
channel, ByteBuffer buf) throw
return (nBytes > 0) ? nBytes : ret;
}
+ public static int fileRead(FileChannel channel, ByteBuffer buf, long offset)
+ throws IOException {
+if (buf.remaining() <= NIO_BUFFER_LIMIT) {
+ return channel.read(buf, offset);
+}
+int originalLimit = buf.limit();
+int initialRemaining = buf.remaining();
+int ret = 0;
+
+while (buf.remaining() > 0) {
+ try {
+int ioSize = Math.min(buf.remaining(), NIO_BUFFER_LIMIT);
+buf.limit(buf.position() + ioSize);
+offset += ret;
+ret = channel.read(buf, offset);
+if (ret < ioSize) {
+ break;
+}
+ } finally {
+buf.limit(originalLimit);
Review comment:
Only reset the limit ? should we also reset the position ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#discussion_r312765494 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/nio/ByteBuff.java ## @@ -475,6 +486,32 @@ public static int channelRead(ReadableByteChannel channel, ByteBuffer buf) throw return (nBytes > 0) ? nBytes : ret; } + public static int fileRead(FileChannel channel, ByteBuffer buf, long offset) Review comment: Looks like we could make some abstraction between the existed channelRead(...) and the newly introduced fileRead (...) ? Similar with the ByteBufferArray#read & ByteBufferArray#write.. Please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312765952
##
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/nio/MultiByteBuff.java
##
@@ -1086,6 +1087,48 @@ public int read(ReadableByteChannel channel) throws
IOException {
return total;
}
+ @Override
+ public int read(FileChannel channel, long offset) throws IOException {
Review comment:
Should also make the abstraction between MultiByteBuff#read and
MultiByteBuff#write ? As said above.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] openinx commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
openinx commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312766046
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -429,7 +429,9 @@ private void cacheBlockWithWaitInternal(BlockCacheKey
cacheKey, Cacheable cached
if (!cacheEnabled) {
return;
}
-LOG.trace("Caching key={}, item={}", cacheKey, cachedItem);
+if (LOG.isTraceEnabled()) {
Review comment:
Correct
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520281627 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 431 | master passed | | +1 | compile | 70 | master passed | | +1 | checkstyle | 98 | master passed | | +1 | shadedjars | 373 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 47 | master passed | | 0 | spotbugs | 329 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 325 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 397 | the patch passed | | +1 | compile | 70 | the patch passed | | +1 | javac | 70 | the patch passed | | +1 | checkstyle | 89 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 343 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1229 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 43 | the patch passed | | +1 | findbugs | 343 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17703 | hbase-server in the patch failed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 22161 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.procedure.TestSCPWithReplicasWithoutZKCoordinated | | | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.replication.TestReplicationKillSlaveRS | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f93d590517b9 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/testReport/ | | Max. process+thread count | 4853 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/10/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-21745) Make HBCK2 be able to fix issues other than region assignment
[ https://issues.apache.org/jira/browse/HBASE-21745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904783#comment-16904783 ] Guanghao Zhang commented on HBASE-21745: bq. I do not follow what you are saying above. I was fine till I go to "and there are overlap regions on meta." We found some orphan regions on our test cluster. The regions dir is empty. And no region holes in meta. For this case, the orphan region dir shouled be remove directly. bq. I was thinking we'd add an 'adopt' API to hbck Service. You'd pass it one or more 'orphan' directories. The Master would read the directory and figure where to put the hfiles doing the right thing. The Master would be running an 'adoption service'. The 'adoption service' is not easy to handle all cases... HBCK2 tool only provide basic function and user can combine them to generate powerful functions now. I thought we can do this at HBCK tool (client-side). But should not add 'adopt' API to hbck Service now (master-side). > Make HBCK2 be able to fix issues other than region assignment > - > > Key: HBASE-21745 > URL: https://issues.apache.org/jira/browse/HBASE-21745 > Project: HBase > Issue Type: Umbrella > Components: hbase-operator-tools, hbck2 >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > > This is what [~apurtell] posted on mailing-list, HBCK2 should support > * -Rebuild meta from region metadata in the filesystem, aka offline meta > rebuild.- > * -Fix assignment errors (undeployed regions, double assignments (yes, > should not be possible), etc)- (See > https://issues.apache.org/jira/browse/HBASE-21745?focusedCommentId=16888302=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16888302) > * Fix region holes, overlaps, and other errors in the region chain > * Fix failed split and merge transactions that have failed to roll back due > to some bug (related to previous) > * -Enumerate store files to determine file level corruption and sideline > corrupt files- > * -Fix hfile link problems (dangling / broken)- -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes…
Apache-HBase commented on issue #446: HBASE-22781 optimize the test case TestStoreScanner.testScanSameTimes… URL: https://github.com/apache/hbase/pull/446#issuecomment-520279917 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 61 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 327 | master passed | | +1 | compile | 53 | master passed | | +1 | checkstyle | 76 | master passed | | +1 | shadedjars | 270 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 36 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 245 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 296 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 74 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 268 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 916 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 250 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 17552 | hbase-server in the patch failed. | | +1 | asflicense | 64 | The patch does not generate ASF License warnings. | | | | 20963 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi2 | | | hadoop.hbase.tool.TestSecureBulkLoadHFiles | | | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.tool.TestBulkLoadHFiles | | | hadoop.hbase.replication.TestReplicationDisableInactivePeer | | | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/33/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/446 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f1e33c815586 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-446/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/33/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/33/testReport/ | | Max. process+thread count | 4970 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-446/33/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312764258
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/ModeStrategy.java
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.mode;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.util.List;
+import org.apache.hadoop.hbase.ClusterMetrics;
+import org.apache.hadoop.hbase.hbtop.Record;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldInfo;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * An interface for strategy logic for {@link Mode}.
+ */
+@InterfaceAudience.Private
+interface ModeStrategy {
+ List getFieldInfos();
+ Field getDefaultSortField();
+ List getRecords(ClusterMetrics clusterMetrics);
+ @Nullable DrillDownInfo drillDown(Record selectedRecord);
+}
Review comment:
Not sure there is a lib we can use here. Do you have any pointers?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien…
Apache-HBase commented on issue #361: HBase-22027: Split non-MR related parts of TokenUtil off into a Clien… URL: https://github.com/apache/hbase/pull/361#issuecomment-520277330 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 64 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 340 | master passed | | +1 | compile | 81 | master passed | | +1 | checkstyle | 123 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 57 | master passed | | 0 | spotbugs | 265 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 332 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 325 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 130 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 322 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1067 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 56 | the patch passed | | +1 | findbugs | 395 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 121 | hbase-client in the patch passed. | | -1 | unit | 14928 | hbase-server in the patch failed. | | +1 | asflicense | 48 | The patch does not generate ASF License warnings. | | | | 19226 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.master.TestAssignmentManagerMetrics | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/89/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/361 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c77d46f46fc6 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-361/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/89/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/89/testReport/ | | Max. process+thread count | 4959 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-361/89/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-11062) hbtop
[ https://issues.apache.org/jira/browse/HBASE-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904776#comment-16904776 ] Toshihiro Suzuki commented on HBASE-11062: -- I removed the dependency for Lanterna to remove the license problem. And I created a new PR: https://github.com/apache/hbase/pull/476 > hbtop > - > > Key: HBASE-11062 > URL: https://issues.apache.org/jira/browse/HBASE-11062 > Project: HBase > Issue Type: New Feature > Components: hbtop >Reporter: Andrew Purtell >Assignee: Toshihiro Suzuki >Priority: Major > > A top-like monitor could be useful for testing, debugging, operations of > clusters of moderate size, and possibly for diagnosing issues in large > clusters. > Consider a curses interface like the one presented by atop > (http://www.atoptool.nl/images/screenshots/genericw.png) - with aggregate > metrics collected over a monitoring interval in the upper portion of the > pane, and a listing of discrete measurements sorted and filtered by various > criteria in the bottom part of the pane. One might imagine a cluster overview > with cluster aggregate metrics above and a list of regionservers sorted by > utilization below; and a regionserver view with process metrics above and a > list of metrics by operation type below, or a list of client connections, or > a list of threads, sorted by utilization, throughput, or latency. > Generically 'htop' is taken but would be distinctive in the HBase context, a > utility org.apache.hadoop.hbase.HTop > No need necessarily for a curses interface. Could be an external monitor with > a web front end as has been discussed before. I do like the idea of a process > that runs in a terminal because I interact with dev and test HBase clusters > exclusively by SSH. > UPDATE: > The tool name is changed from htop to hbtop. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #476: HBASE-11062 hbtop
Apache-HBase commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-520276605 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 36 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 2 | No case conflicting files found. | | 0 | shelldocs | 2 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 22 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 34 | Maven dependency ordering for branch | | +1 | mvninstall | 316 | master passed | | +1 | compile | 172 | master passed | | +1 | checkstyle | 148 | master passed | | +1 | shadedjars | 273 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 178 | master passed | | 0 | spotbugs | 27 | Used deprecated FindBugs config; considering switching to SpotBugs. | | 0 | findbugs | 27 | branch/hbase-assembly no findbugs output file (findbugsXml.xml) | ||| _ Patch Compile Tests _ | | 0 | mvndep | 15 | Maven dependency ordering for patch | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 173 | the patch passed | | +1 | javac | 173 | the patch passed | | +1 | checkstyle | 144 | the patch passed | | +1 | shellcheck | 2 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | xml | 5 | The patch has no ill-formed XML file. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 197 | the patch passed | | 0 | findbugs | 29 | hbase-assembly has no data from findbugs | ||| _ Other Tests _ | | +1 | unit | 13223 | root in the patch passed. | | +1 | asflicense | 91 | The patch does not generate ASF License warnings. | | | | 18738 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/476 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit shadedjars hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle | | uname | Linux e95fb5030e4e 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-476/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/2/testReport/ | | Max. process+thread count | 5542 (vs. ulimit of 1) | | modules | C: hbase-hbtop . hbase-assembly U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-476/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] brfrn169 commented on issue #476: HBASE-11062 hbtop
brfrn169 commented on issue #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#issuecomment-520276091 Thank you for reviewing! @saintstack > Put some images up in the JIRA so we can see how it looks. Sure, will update the Jira. > How did you come up with this body of work. Have you done terminal UI in the past? I have never done terminal UI in the past actually. And I thought about using Lanterna (https://github.com/mabe02/lanterna) to build the terminal UI, but I faced the license problem (Lanterna is LGPL License that's incompatible with Apache License. See https://github.com/mabe02/lanterna/issues/415 for the details). So I decided not to use Lanterna and to make the terminal UI by myself. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #472: HBASE-22829 Removed deprecated methods from SnapshotDescription
Apache-HBase commented on issue #472: HBASE-22829 Removed deprecated methods from SnapshotDescription URL: https://github.com/apache/hbase/pull/472#issuecomment-520275858 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 99 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | 0 | mvndep | 35 | Maven dependency ordering for branch | | +1 | mvninstall | 361 | master passed | | +1 | compile | 83 | master passed | | +1 | checkstyle | 116 | master passed | | +1 | shadedjars | 286 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 59 | master passed | | 0 | spotbugs | 283 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 354 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 16 | Maven dependency ordering for patch | | +1 | mvninstall | 312 | the patch passed | | +1 | compile | 80 | the patch passed | | +1 | javac | 80 | the patch passed | | +1 | checkstyle | 114 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 274 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 983 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 53 | the patch passed | | +1 | findbugs | 332 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 100 | hbase-client in the patch passed. | | -1 | unit | 14017 | hbase-server in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 18123 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.security.access.TestSnapshotScannerHDFSAclController | | | hadoop.hbase.quotas.TestQuotaAdmin | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/472 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 07089a6ea55d 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-472/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/testReport/ | | Max. process+thread count | 4619 (vs. ulimit of 1) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-472/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split
Apache-HBase commented on issue #460: HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split URL: https://github.com/apache/hbase/pull/460#issuecomment-520275574 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 1211 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ branch-1 Compile Tests _ | | +1 | mvninstall | 510 | branch-1 passed | | +1 | compile | 52 | branch-1 passed with JDK v1.8.0_222 | | +1 | compile | 54 | branch-1 passed with JDK v1.7.0_232 | | +1 | checkstyle | 120 | branch-1 passed | | +1 | shadedjars | 202 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 43 | branch-1 passed with JDK v1.8.0_222 | | +1 | javadoc | 50 | branch-1 passed with JDK v1.7.0_232 | | 0 | spotbugs | 205 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 202 | branch-1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 129 | the patch passed | | +1 | compile | 50 | the patch passed with JDK v1.8.0_222 | | +1 | javac | 50 | the patch passed | | +1 | compile | 54 | the patch passed with JDK v1.7.0_232 | | +1 | javac | 54 | the patch passed | | +1 | checkstyle | 102 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 193 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 331 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | +1 | javadoc | 36 | the patch passed with JDK v1.8.0_222 | | +1 | javadoc | 48 | the patch passed with JDK v1.7.0_232 | | +1 | findbugs | 212 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9226 | hbase-server in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 13087 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/460 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 1cab1d424e41 4.4.0-154-generic #181-Ubuntu SMP Tue Jun 25 05:29:03 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-460/out/precommit/personality/provided.sh | | git revision | branch-1 / 2d9d405 | | Default Java | 1.7.0_232 | | Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_222 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/testReport/ | | Max. process+thread count | 4059 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-460/6/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312762492
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/field/FieldScreenView.java
##
@@ -0,0 +1,185 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.screen.field;
+
+import java.util.EnumMap;
+import java.util.List;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.screen.AbstractScreenView;
+import org.apache.hadoop.hbase.hbtop.screen.Screen;
+import org.apache.hadoop.hbase.hbtop.screen.ScreenView;
+import org.apache.hadoop.hbase.hbtop.terminal.KeyPress;
+import org.apache.hadoop.hbase.hbtop.terminal.Terminal;
+import org.apache.hadoop.hbase.hbtop.terminal.TerminalPrinter;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * The screen where we can change the displayed fields, the sort key and the
order of the fields.
+ */
+@InterfaceAudience.Private
+public class FieldScreenView extends AbstractScreenView {
+
+ private static final int SCREEN_DESCRIPTION_START_ROW = 0;
+ private static final int FIELD_START_ROW = 5;
+
+ private final FieldScreenPresenter fieldScreenPresenter;
+
+ public FieldScreenView(Screen screen, Terminal terminal, Field sortField,
List fields,
+EnumMap fieldDisplayMap,
FieldScreenPresenter.ResultListener resultListener,
+ScreenView nextScreenView) {
+super(screen, terminal);
+this.fieldScreenPresenter = new FieldScreenPresenter(this, sortField,
fields, fieldDisplayMap,
+ resultListener, nextScreenView);
+ }
+
+ @Override
+ public void init() {
+fieldScreenPresenter.init();
+ }
+
+ @Override
+ public ScreenView handleKeyPress(KeyPress keyPress) {
+switch (keyPress.getType()) {
+ case Escape:
+return fieldScreenPresenter.transitionToNextScreen();
+
+ case ArrowUp:
+fieldScreenPresenter.arrowUp();
+return this;
+
+ case ArrowDown:
+fieldScreenPresenter.arrowDown();
+return this;
+
+ case PageUp:
+ case Home:
+fieldScreenPresenter.pageUp();
+return this;
+
+ case PageDown:
+ case End:
+fieldScreenPresenter.pageDown();
+return this;
+
+ case ArrowRight:
+fieldScreenPresenter.turnOnMoveMode();
+return this;
+
+ case ArrowLeft:
+ case Enter:
+fieldScreenPresenter.turnOffMoveMode();
+return this;
+}
+
+if (keyPress.getType() != KeyPress.Type.Character) {
+ return this;
+}
+
+assert keyPress.getCharacter() != null;
+switch (keyPress.getCharacter()) {
+ case 'd':
+ case ' ':
+fieldScreenPresenter.switchFieldDisplay();
+break;
+
+ case 's':
+fieldScreenPresenter.setSortField();
+break;
+
+ case 'q':
+return fieldScreenPresenter.transitionToNextScreen();
+}
+
+return this;
+ }
+
+ public void showFieldScreen(String sortFieldHeader, List fields,
+EnumMap fieldDisplayMap, int currentPosition, int
headerMaxLength,
+int descriptionMaxLength, boolean moveMode) {
+showScreenDescription(sortFieldHeader);
+
+for (int i = 0; i < fields.size(); i ++) {
+ Field field = fields.get(i);
+ showField(i, field, fieldDisplayMap.get(field), i == currentPosition,
headerMaxLength,
+descriptionMaxLength, moveMode);
+}
+ }
+
+ public void showScreenDescription(String sortKeyHeader) {
+TerminalPrinter printer = getTerminalPrinter(SCREEN_DESCRIPTION_START_ROW);
+printer.startBold().print("Fields Management").stopBold().endOfLine();
+printer.print("Current Sort Field:
").startBold().print(sortKeyHeader).stopBold().endOfLine();
+printer.print("Navigate with up/down, Right selects for move then
or Left commits,")
+ .endOfLine();
+printer.print("'d' or toggles display, 's' sets sort. Use 'q' or
to end!")
+ .endOfLine();
+ }
+
+ public void showField(int pos, Field field, boolean display, boolean
selected,
+int fieldHeaderMaxLength, int fieldDescriptionMaxLength, boolean moveMode)
{
+
+String fieldHeader =
[GitHub] [hbase] brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312762260
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RegionModeStrategy.java
##
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.mode;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.commons.lang3.time.FastDateFormat;
+import org.apache.hadoop.hbase.ClusterMetrics;
+import org.apache.hadoop.hbase.RegionMetrics;
+import org.apache.hadoop.hbase.ServerMetrics;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.hbtop.Record;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldInfo;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Implementation for {@link ModeStrategy} for Region Mode.
+ */
+@InterfaceAudience.Private
+public final class RegionModeStrategy implements ModeStrategy {
+
+ private final List fieldInfos = Arrays.asList(
+new FieldInfo(Field.REGION_NAME, 0, false),
+new FieldInfo(Field.NAMESPACE, 0, true),
+new FieldInfo(Field.TABLE, 0, true),
+new FieldInfo(Field.START_CODE, 13, false),
+new FieldInfo(Field.REPLICA_ID, 5, false),
+new FieldInfo(Field.REGION, 32, true),
+new FieldInfo(Field.REGION_SERVER, 0, true),
+new FieldInfo(Field.LONG_REGION_SERVER, 0, false),
+new FieldInfo(Field.REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.READ_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.FILTERED_READ_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.WRITE_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.STORE_FILE_SIZE, 10, true),
+new FieldInfo(Field.UNCOMPRESSED_STORE_FILE_SIZE, 12, false),
+new FieldInfo(Field.NUM_STORE_FILES,4, true),
+new FieldInfo(Field.MEM_STORE_SIZE, 8, true),
+new FieldInfo(Field.LOCALITY, 8, true),
+new FieldInfo(Field.START_KEY, 0, false),
+new FieldInfo(Field.COMPACTING_CELL_COUNT, 12, false),
+new FieldInfo(Field.COMPACTED_CELL_COUNT, 12, false),
+new FieldInfo(Field.COMPACTION_PROGRESS, 7, false),
+new FieldInfo(Field.LAST_MAJOR_COMPACTION_TIME, 19, false)
+ );
+
+ private final Map requestCountPerSecondMap =
new HashMap<>();
+
+ RegionModeStrategy() {
+ }
+
+ @Override
+ public List getFieldInfos() {
+return fieldInfos;
+ }
+
+ @Override
+ public Field getDefaultSortField() {
+return Field.REQUEST_COUNT_PER_SECOND;
+ }
+
+ @Override
+ public List getRecords(ClusterMetrics clusterMetrics) {
+List ret = new ArrayList<>();
+for (ServerMetrics sm : clusterMetrics.getLiveServerMetrics().values()) {
+ long lastReportTimestamp = sm.getLastReportTimestamp();
+ for (RegionMetrics rm : sm.getRegionMetrics().values()) {
+ret.add(createRecord(sm, rm, lastReportTimestamp));
+ }
+}
+return ret;
+ }
+
+ private Record createRecord(ServerMetrics serverMetrics, RegionMetrics
regionMetrics,
+long lastReportTimestamp) {
+
+Record ret = new Record();
+
+String regionName = regionMetrics.getNameAsString();
+ret.put(Field.REGION_NAME, regionName);
+
+String namespaceName = "";
+String tableName = "";
+String region = "";
+String startKey = "";
+String startCode = "";
+String replicaId = "";
+try {
+ byte[][] elements =
RegionInfo.parseRegionName(regionMetrics.getRegionName());
+ TableName tn = TableName.valueOf(elements[0]);
+ namespaceName = tn.getNamespaceAsString();
+ tableName = tn.getQualifierAsString();
+ startKey = Bytes.toStringBinary(elements[1]);
+ startCode = Bytes.toString(elements[2]);
+ replicaId = elements.length == 4 ?
+Integer.valueOf(Bytes.toString(elements[3])).toString() : "";
+ region =
[GitHub] [hbase] brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r312761940 ## File path: hbase-hbtop/pom.xml ## @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + 4.0.0 + +hbase +org.apache.hbase +3.0.0-SNAPSHOT + + hbase-hbtop + Apache HBase - HBTop + A real-time monitoring tool for HBase like Unix top command Review comment: > s/like Unix/like the Unix/ or like Unix's top... Thank you, will modify that. > One thought is that maybe this belongs in the hbase-operator-tools repo? I thought so actually. However, considering to backport this to branch-1 after committing it to branch-2+, I think it's better to put this into the hbase project because managing the compatibilities is much easier. Also, I'm thinking about adding more metrics to ClusterMetrics to add more metrics to hbtop as hbtop gets the metrics from ClusterMetrics. And this will need server side modifications. In this case, I think it's better to have hbtop in the hbase project too because of the compatibility reason. What do you think? @saintstack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop
brfrn169 commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r312761555 ## File path: hbase-assembly/pom.xml ## @@ -309,6 +309,10 @@ org.apache.hbase hbase-zookeeper + + org.apache.hbase + hbase-hbtop + Review comment: Yes, I made a separate module. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-520272169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 200 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 360 | master passed | | +1 | compile | 29 | master passed | | +1 | checkstyle | 33 | master passed | | +1 | shadedjars | 292 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 24 | master passed | | 0 | spotbugs | 76 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 74 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 321 | the patch passed | | +1 | compile | 24 | the patch passed | | +1 | javac | 24 | the patch passed | | +1 | checkstyle | 29 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 286 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 968 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 26 | the patch passed | | +1 | findbugs | 78 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 108 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3259 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/43/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 2113b87775eb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/43/testReport/ | | Max. process+thread count | 292 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/43/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-520271908 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 339 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 260 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 20 | master passed | | 0 | spotbugs | 44 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 43 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 291 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 256 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 901 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 49 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 339 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 3027 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/80/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 4b8d792ea28d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / e9382154f3 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/80/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/80/testReport/ | | Max. process+thread count | 4398 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/80/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again
Apache-HBase commented on issue #456: HBASE-22631 assign failed may make gced parent region appear again URL: https://github.com/apache/hbase/pull/456#issuecomment-520270455 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 100 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 301 | branch-2.1 passed | | +1 | compile | 51 | branch-2.1 passed | | +1 | checkstyle | 73 | branch-2.1 passed | | +1 | shadedjars | 236 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 34 | branch-2.1 passed | | 0 | spotbugs | 162 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 160 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 276 | the patch passed | | +1 | compile | 52 | the patch passed | | +1 | javac | 52 | the patch passed | | +1 | checkstyle | 72 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 235 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1174 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 32 | the patch passed | | +1 | findbugs | 166 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 7809 | hbase-server in the patch passed. | | +1 | asflicense | 26 | The patch does not generate ASF License warnings. | | | | 11161 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/18/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/456 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 799f6702af35 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-456/out/precommit/personality/provided.sh | | git revision | branch-2.1 / c9d02f9535 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/18/testReport/ | | Max. process+thread count | 4574 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-456/18/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment
Apache-HBase commented on issue #439: HBASE-22618 Provide a way to have Heterogeneous deployment URL: https://github.com/apache/hbase/pull/439#issuecomment-520270344 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 365 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 93 | master passed | | +1 | shadedjars | 306 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 297 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 295 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 335 | the patch passed | | +1 | compile | 61 | the patch passed | | +1 | javac | 61 | the patch passed | | -1 | checkstyle | 92 | hbase-server: The patch generated 2 new + 64 unchanged - 0 fixed = 66 total (was 64) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 297 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1046 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 282 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9623 | hbase-server in the patch passed. | | +1 | asflicense | 30 | The patch does not generate ASF License warnings. | | | | 13413 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/40/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/439 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 653c616659d4 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-439/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/40/artifact/out/diff-checkstyle-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/40/testReport/ | | Max. process+thread count | 4670 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-439/40/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve…
Apache-HBase commented on issue #435: HBASE-22767 System table RIT STUCK if their RSGroup has no highest ve… URL: https://github.com/apache/hbase/pull/435#issuecomment-520270058 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 40 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | 0 | shelldocs | 0 | Shelldocs was not available. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 38 | Maven dependency ordering for branch | | +1 | mvninstall | 324 | master passed | | +1 | compile | 104 | master passed | | +1 | checkstyle | 115 | master passed | | +1 | shadedjars | 272 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 78 | master passed | | 0 | spotbugs | 238 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 326 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 17 | Maven dependency ordering for patch | | +1 | mvninstall | 305 | the patch passed | | +1 | compile | 101 | the patch passed | | +1 | javac | 101 | the patch passed | | -1 | checkstyle | 75 | hbase-server: The patch generated 1 new + 9 unchanged - 0 fixed = 10 total (was 9) | | +1 | shellcheck | 0 | There were no new shellcheck issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 273 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 925 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 76 | the patch passed | | -1 | findbugs | 54 | hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | +1 | unit | 187 | hbase-common in the patch passed. | | +1 | unit | 8617 | hbase-server in the patch passed. | | +1 | unit | 353 | hbase-rsgroup in the patch passed. | | +1 | asflicense | 90 | The patch does not generate ASF License warnings. | | | | 13106 | | | Reason | Tests | |---:|:--| | FindBugs | module:hbase-common | | | org.apache.hadoop.hbase.Version.() invokes inefficient new String(String) constructor At Version.java:inefficient new String(String) constructor At Version.java:[line 10] | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/35/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/435 | | Optional Tests | dupname asflicense shellcheck shelldocs javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3387a76e6058 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-435/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/35/artifact/out/diff-checkstyle-hbase-server.txt | | findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/35/artifact/out/new-findbugs-hbase-common.html | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/35/testReport/ | | Max. process+thread count | 4704 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server hbase-rsgroup U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-435/35/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) shellcheck=0.4.4 findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal
Apache-HBase commented on issue #471: HBASE-22828 Log a region close journal URL: https://github.com/apache/hbase/pull/471#issuecomment-520269869 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 34 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 399 | master passed | | +1 | compile | 57 | master passed | | +1 | checkstyle | 92 | master passed | | +1 | shadedjars | 295 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 37 | master passed | | 0 | spotbugs | 242 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 239 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 317 | the patch passed | | +1 | compile | 57 | the patch passed | | +1 | javac | 57 | the patch passed | | +1 | checkstyle | 92 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 292 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1013 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 41 | the patch passed | | +1 | findbugs | 311 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 9197 | hbase-server in the patch passed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 12938 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/471 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c3ba0babd0fe 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-471/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/2/testReport/ | | Max. process+thread count | 4511 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-471/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
Apache-HBase commented on issue #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read URL: https://github.com/apache/hbase/pull/467#issuecomment-520269181 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 41 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | 0 | mvndep | 36 | Maven dependency ordering for branch | | +1 | mvninstall | 309 | master passed | | +1 | compile | 76 | master passed | | +1 | checkstyle | 102 | master passed | | +1 | shadedjars | 267 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 56 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 286 | master passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 299 | the patch passed | | +1 | compile | 77 | the patch passed | | +1 | javac | 77 | the patch passed | | +1 | checkstyle | 100 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 935 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 55 | the patch passed | | +1 | findbugs | 313 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 184 | hbase-common in the patch passed. | | +1 | unit | 8383 | hbase-server in the patch passed. | | +1 | asflicense | 51 | The patch does not generate ASF License warnings. | | | | 12239 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/467 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d8653ea606f0 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-467/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/9/testReport/ | | Max. process+thread count | 4600 (vs. ulimit of 1) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-467/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22830) Remove deprecated method from StoreFile
[
https://issues.apache.org/jira/browse/HBASE-22830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22830.
---
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
Fix Version/s: 3.0.0
> Remove deprecated method from StoreFile
> ---
>
> Key: HBASE-22830
> URL: https://issues.apache.org/jira/browse/HBASE-22830
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{getModificationTimeStamp}} in {{StoreFile}} is deprecated and should be
> removed in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] HorizonNet commented on issue #473: HBASE-22830 Removed deprecated method from StoreFile
HorizonNet commented on issue #473: HBASE-22830 Removed deprecated method from StoreFile URL: https://github.com/apache/hbase/pull/473#issuecomment-520268749 According to latest QA the unit test failure seems not to be related. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #473: HBASE-22830 Removed deprecated method from StoreFile
HorizonNet merged pull request #473: HBASE-22830 Removed deprecated method from StoreFile URL: https://github.com/apache/hbase/pull/473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #473: HBASE-22830 Removed deprecated method from StoreFile
Apache-HBase commented on issue #473: HBASE-22830 Removed deprecated method from StoreFile URL: https://github.com/apache/hbase/pull/473#issuecomment-520268652 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 42 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 318 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 70 | master passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 32 | master passed | | 0 | spotbugs | 240 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 237 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 283 | the patch passed | | +1 | compile | 53 | the patch passed | | +1 | javac | 53 | the patch passed | | +1 | checkstyle | 69 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 887 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 34 | the patch passed | | +1 | findbugs | 253 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 8381 | hbase-server in the patch passed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 11650 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-473/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/473 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 016cb1e9e635 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-473/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-473/2/testReport/ | | Max. process+thread count | 4881 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-473/2/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
Apache-HBase commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520268555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 210 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 2 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 337 | master passed | | +1 | compile | 52 | master passed | | +1 | checkstyle | 76 | master passed | | +1 | shadedjars | 306 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 39 | master passed | | 0 | spotbugs | 247 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 244 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 346 | the patch passed | | +1 | compile | 60 | the patch passed | | +1 | javac | 60 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 272 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 942 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 37 | the patch passed | | +1 | findbugs | 252 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 16227 | hbase-server in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 19943 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.client.TestFromClientSide | | | hadoop.hbase.master.TestAssignmentManagerMetrics | | | hadoop.hbase.client.TestAdmin1 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/468 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 252369174a0e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-468/out/precommit/personality/provided.sh | | git revision | master / c8f57bf678 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/artifact/out/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/testReport/ | | Max. process+thread count | 5064 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-468/9/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22725) Remove all remaining javadoc warnings
[ https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904754#comment-16904754 ] Hudson commented on HBASE-22725: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #614 (See [https://builds.apache.org/job/HBase-1.3-IT/614/]) HBASE-22725 Remove all remaining Javadoc warnings (jan.hentschel: rev 9b1298c45b8a8395312968db0b36a9eefc2857e1) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Batch.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Table.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > Remove all remaining javadoc warnings > -- > > Key: HBASE-22725 > URL: https://issues.apache.org/jira/browse/HBASE-22725 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] HorizonNet opened a new pull request #478: HBASE-22755 Removed deprecated methods from Mutation
HorizonNet opened a new pull request #478: HBASE-22755 Removed deprecated methods from Mutation URL: https://github.com/apache/hbase/pull/478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator
Apache-HBase commented on issue #343: HBASE-22634 : Improve performance of BufferedMutator URL: https://github.com/apache/hbase/pull/343#issuecomment-520262398 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 74 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-2.1 Compile Tests _ | | +1 | mvninstall | 333 | branch-2.1 passed | | +1 | compile | 24 | branch-2.1 passed | | +1 | checkstyle | 40 | branch-2.1 passed | | +1 | shadedjars | 264 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 30 | branch-2.1 passed | | 0 | spotbugs | 89 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 87 | branch-2.1 passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 365 | the patch passed | | +1 | compile | 26 | the patch passed | | +1 | javac | 26 | the patch passed | | +1 | checkstyle | 37 | hbase-client: The patch generated 0 new + 56 unchanged - 4 fixed = 56 total (was 60) | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 261 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 1343 | Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. | | +1 | javadoc | 24 | the patch passed | | +1 | findbugs | 83 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 199 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3637 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/343 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 3eee6571095d 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-343/out/precommit/personality/provided.sh | | git revision | branch-2.1 / c9d02f9535 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/testReport/ | | Max. process+thread count | 267 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-343/55/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22725) Remove all remaining javadoc warnings
[ https://issues.apache.org/jira/browse/HBASE-22725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel resolved HBASE-22725. --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.4.11 1.3.6 2.1.6 2.2.1 2.0.6 2.3.0 1.5.0 3.0.0 > Remove all remaining javadoc warnings > -- > > Key: HBASE-22725 > URL: https://issues.apache.org/jira/browse/HBASE-22725 > Project: HBase > Issue Type: Test > Components: test >Affects Versions: 3.0.0 >Reporter: Murtaza Hassan >Assignee: Murtaza Hassan >Priority: Trivial > Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.3.6, 1.4.11 > > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [hbase] Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException
Apache-HBase commented on issue #436: HBASE-22699 refactor isMetaClearingException URL: https://github.com/apache/hbase/pull/436#issuecomment-520258757 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 97 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -0 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 | mvninstall | 337 | master passed | | +1 | compile | 24 | master passed | | +1 | checkstyle | 32 | master passed | | +1 | shadedjars | 281 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 26 | master passed | | 0 | spotbugs | 74 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 72 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 313 | the patch passed | | +1 | compile | 27 | the patch passed | | +1 | javac | 27 | the patch passed | | +1 | checkstyle | 35 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 299 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 961 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 24 | the patch passed | | +1 | findbugs | 83 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 105 | hbase-client in the patch passed. | | +1 | asflicense | 12 | The patch does not generate ASF License warnings. | | | | 3125 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/42/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/436 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux f687c317c723 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-436/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/42/testReport/ | | Max. process+thread count | 259 (vs. ulimit of 1) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-436/42/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent
Apache-HBase commented on issue #387: HBASE-22642 Make move operations of RSGroup idempotent URL: https://github.com/apache/hbase/pull/387#issuecomment-520258597 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 37 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | hbaseanti | 0 | Patch does not have any anti-patterns. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 | mvninstall | 310 | master passed | | +1 | compile | 25 | master passed | | +1 | checkstyle | 12 | master passed | | +1 | shadedjars | 255 | branch has no errors when building our shaded downstream artifacts. | | +1 | javadoc | 19 | master passed | | 0 | spotbugs | 47 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 45 | master passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 295 | the patch passed | | +1 | compile | 25 | the patch passed | | +1 | javac | 25 | the patch passed | | +1 | checkstyle | 10 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedjars | 258 | patch has no errors when building our shaded downstream artifacts. | | +1 | hadoopcheck | 911 | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | +1 | javadoc | 18 | the patch passed | | +1 | findbugs | 48 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 342 | hbase-rsgroup in the patch failed. | | +1 | asflicense | 11 | The patch does not generate ASF License warnings. | | | | 2974 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hbase.rsgroup.TestRSGroupsAdmin2 | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/79/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/387 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux d158de6abe88 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-387/out/precommit/personality/provided.sh | | git revision | master / 15c903b3f8 | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/79/artifact/out/patch-unit-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/79/testReport/ | | Max. process+thread count | 4382 (vs. ulimit of 1) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-387/79/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22728) Upgrade jackson dependencies in branch-1
[
https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904734#comment-16904734
]
HBase QA commented on HBASE-22728:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 12 new or modified test
files. {color} |
|| || || || {color:brown} branch-1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
53s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
50s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m
57s{color} | {color:green} branch-1 passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 0m
11s{color} | {color:red} branch has 10 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
19s{color} | {color:green} branch-1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
23s{color} | {color:green} The patch passed checkstyle in hbase-common {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-procedure
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
29s{color} | {color:green} The patch passed checkstyle in hbase-client {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-metrics-api
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-metrics {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-hadoop2-compat
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-prefix-tree
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
32s{color} | {color:green} hbase-server: The patch generated 0 new + 260
unchanged - 3 fixed = 260 total (was 263) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
7s{color} | {color:green} The patch passed checkstyle in hbase-testing-util
{color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
27s{color} | {color:green} The patch passed checkstyle in hbase-thrift {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} hbase-rest: The patch generated 0 new + 66 unchanged
- 7 fixed = 66 total (was 73) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch passed checkstyle in hbase-rsgroup {color}
|
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch passed checkstyle in hbase-shell {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s{color} | {color:green} The
[GitHub] [hbase] HorizonNet merged pull request #463: HBASE-22725 Remove all remaining javadoc warnings
HorizonNet merged pull request #463: HBASE-22725 Remove all remaining javadoc warnings URL: https://github.com/apache/hbase/pull/463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #463: HBASE-22725 Remove all remaining javadoc warnings
HorizonNet commented on a change in pull request #463: HBASE-22725 Remove all
remaining javadoc warnings
URL: https://github.com/apache/hbase/pull/463#discussion_r312751973
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
##
@@ -205,10 +205,11 @@ int getThenIncrement() {
}
/**
- * Use this method filling the backing data source used by {@link
#get(RpcController, GetRequest)}
- * @param regionName
- * @param row
- * @param r
Review comment:
You mean inside test code, right?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Resolved] (HBASE-22832) Remove deprecated method in HFileOutputFormat2
[
https://issues.apache.org/jira/browse/HBASE-22832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22832.
---
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
Fix Version/s: 3.0.0
> Remove deprecated method in HFileOutputFormat2
> --
>
> Key: HBASE-22832
> URL: https://issues.apache.org/jira/browse/HBASE-22832
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> The method {{getHTableDescriptor}} was deprecated in {{HFileOutputFormat2}}
> and should be removed for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] HorizonNet merged pull request #475: HBASE-22832 Removed deprecated method from HFileOutputFormat2
HorizonNet merged pull request #475: HBASE-22832 Removed deprecated method from HFileOutputFormat2 URL: https://github.com/apache/hbase/pull/475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (HBASE-22831) Remove deprecated constructor from TableRecordWriter
[
https://issues.apache.org/jira/browse/HBASE-22831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel resolved HBASE-22831.
---
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
Fix Version/s: 3.0.0
> Remove deprecated constructor from TableRecordWriter
>
>
> Key: HBASE-22831
> URL: https://issues.apache.org/jira/browse/HBASE-22831
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Trivial
> Fix For: 3.0.0
>
>
> {{TableRecordWriter}} has a deprecated constructor, which should be removed
> in 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] HorizonNet merged pull request #474: HBASE-22831 Removed deprecated constructor from TableRecordWriter
HorizonNet merged pull request #474: HBASE-22831 Removed deprecated constructor from TableRecordWriter URL: https://github.com/apache/hbase/pull/474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] HorizonNet opened a new pull request #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility
HorizonNet opened a new pull request #477: HBASE-22834 Removed deprecated methods from HBaseTestingUtility URL: https://github.com/apache/hbase/pull/477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-22834) Remove deprecated methods from HBaseTestingUtility
Jan Hentschel created HBASE-22834:
-
Summary: Remove deprecated methods from HBaseTestingUtility
Key: HBASE-22834
URL: https://issues.apache.org/jira/browse/HBASE-22834
Project: HBase
Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: Jan Hentschel
Assignee: Jan Hentschel
{{HBaseTestingUtility}} has some deprecated methods, which should be removed
for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work started] (HBASE-22834) Remove deprecated methods from HBaseTestingUtility
[
https://issues.apache.org/jira/browse/HBASE-22834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on HBASE-22834 started by Jan Hentschel.
-
> Remove deprecated methods from HBaseTestingUtility
> --
>
> Key: HBASE-22834
> URL: https://issues.apache.org/jira/browse/HBASE-22834
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> {{HBaseTestingUtility}} has some deprecated methods, which should be removed
> for 3.0.0.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [hbase] saintstack commented on a change in pull request #463: HBASE-22725 Remove all remaining javadoc warnings
saintstack commented on a change in pull request #463: HBASE-22725 Remove all
remaining javadoc warnings
URL: https://github.com/apache/hbase/pull/463#discussion_r312747820
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
##
@@ -205,10 +205,11 @@ int getThenIncrement() {
}
/**
- * Use this method filling the backing data source used by {@link
#get(RpcController, GetRequest)}
- * @param regionName
- * @param row
- * @param r
Review comment:
In future, could just purge params that do not have description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #467: HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read
saintstack commented on a change in pull request #467: HBASE-22802 Avoid temp
ByteBuffer allocation in FileIOEngine#read
URL: https://github.com/apache/hbase/pull/467#discussion_r312747165
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
##
@@ -429,7 +429,9 @@ private void cacheBlockWithWaitInternal(BlockCacheKey
cacheKey, Cacheable cached
if (!cacheEnabled) {
return;
}
-LOG.trace("Caching key={}, item={}", cacheKey, cachedItem);
+if (LOG.isTraceEnabled()) {
Review comment:
Don't need this if LOG.isTraceEnabled when using this logging form with the
'{}' (Internally it does this test).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
saintstack commented on a change in pull request #468: HBASE-22822 :
Un/Re-schedule balancer chore with balance_switch
URL: https://github.com/apache/hbase/pull/468#discussion_r312747039
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##
@@ -1673,6 +1675,29 @@ private void balanceThrottling(long
nextBalanceStartTime, int maxRegionsInTransi
if (interrupted) Thread.currentThread().interrupt();
}
+ /**
+ * Turn the balancer on/off
+ *
+ * @param on boolean value indicates whether to turn the balancer on
+ */
+ void turnBalancer(boolean on) {
Review comment:
s/turnBalancer/switchBalancer/ ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312746003
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/RecordFilter.java
##
@@ -0,0 +1,336 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a filter that's filtering the metric {@link Record}s.
+ */
+@InterfaceAudience.Private
+public final class RecordFilter {
+
+ private enum Operator {
+EQUAL("="),
+DOUBLE_EQUALS("=="),
+GREATER(">"),
+GREATER_OR_EQUAL(">="),
+LESS("<"),
+LESS_OR_EQUAL("<=");
+
+private final String operator;
+
+Operator(String operator) {
+ this.operator = operator;
+}
+
+@Override
+public String toString() {
+ return operator;
+}
+ }
Review comment:
CompareFilter#CompareOp is like this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r312745809 ## File path: hbase-hbtop/pom.xml ## @@ -0,0 +1,59 @@ + +http://maven.apache.org/POM/4.0.0; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + + 4.0.0 + +hbase +org.apache.hbase +3.0.0-SNAPSHOT + + hbase-hbtop + Apache HBase - HBTop + A real-time monitoring tool for HBase like Unix top command Review comment: s/like Unix/like the Unix/ or like Unix's top... Nice that you put it in its own module. One thought is that maybe this belongs in the hbase-operator-tools repo? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312746562
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/field/FieldScreenView.java
##
@@ -0,0 +1,185 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.screen.field;
+
+import java.util.EnumMap;
+import java.util.List;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.screen.AbstractScreenView;
+import org.apache.hadoop.hbase.hbtop.screen.Screen;
+import org.apache.hadoop.hbase.hbtop.screen.ScreenView;
+import org.apache.hadoop.hbase.hbtop.terminal.KeyPress;
+import org.apache.hadoop.hbase.hbtop.terminal.Terminal;
+import org.apache.hadoop.hbase.hbtop.terminal.TerminalPrinter;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * The screen where we can change the displayed fields, the sort key and the
order of the fields.
+ */
+@InterfaceAudience.Private
+public class FieldScreenView extends AbstractScreenView {
+
+ private static final int SCREEN_DESCRIPTION_START_ROW = 0;
+ private static final int FIELD_START_ROW = 5;
+
+ private final FieldScreenPresenter fieldScreenPresenter;
+
+ public FieldScreenView(Screen screen, Terminal terminal, Field sortField,
List fields,
+EnumMap fieldDisplayMap,
FieldScreenPresenter.ResultListener resultListener,
+ScreenView nextScreenView) {
+super(screen, terminal);
+this.fieldScreenPresenter = new FieldScreenPresenter(this, sortField,
fields, fieldDisplayMap,
+ resultListener, nextScreenView);
+ }
+
+ @Override
+ public void init() {
+fieldScreenPresenter.init();
+ }
+
+ @Override
+ public ScreenView handleKeyPress(KeyPress keyPress) {
+switch (keyPress.getType()) {
+ case Escape:
+return fieldScreenPresenter.transitionToNextScreen();
+
+ case ArrowUp:
+fieldScreenPresenter.arrowUp();
+return this;
+
+ case ArrowDown:
+fieldScreenPresenter.arrowDown();
+return this;
+
+ case PageUp:
+ case Home:
+fieldScreenPresenter.pageUp();
+return this;
+
+ case PageDown:
+ case End:
+fieldScreenPresenter.pageDown();
+return this;
+
+ case ArrowRight:
+fieldScreenPresenter.turnOnMoveMode();
+return this;
+
+ case ArrowLeft:
+ case Enter:
+fieldScreenPresenter.turnOffMoveMode();
+return this;
+}
+
+if (keyPress.getType() != KeyPress.Type.Character) {
+ return this;
+}
+
+assert keyPress.getCharacter() != null;
+switch (keyPress.getCharacter()) {
+ case 'd':
+ case ' ':
+fieldScreenPresenter.switchFieldDisplay();
+break;
+
+ case 's':
+fieldScreenPresenter.setSortField();
+break;
+
+ case 'q':
+return fieldScreenPresenter.transitionToNextScreen();
+}
+
+return this;
+ }
+
+ public void showFieldScreen(String sortFieldHeader, List fields,
+EnumMap fieldDisplayMap, int currentPosition, int
headerMaxLength,
+int descriptionMaxLength, boolean moveMode) {
+showScreenDescription(sortFieldHeader);
+
+for (int i = 0; i < fields.size(); i ++) {
+ Field field = fields.get(i);
+ showField(i, field, fieldDisplayMap.get(field), i == currentPosition,
headerMaxLength,
+descriptionMaxLength, moveMode);
+}
+ }
+
+ public void showScreenDescription(String sortKeyHeader) {
+TerminalPrinter printer = getTerminalPrinter(SCREEN_DESCRIPTION_START_ROW);
+printer.startBold().print("Fields Management").stopBold().endOfLine();
+printer.print("Current Sort Field:
").startBold().print(sortKeyHeader).stopBold().endOfLine();
+printer.print("Navigate with up/down, Right selects for move then
or Left commits,")
+ .endOfLine();
+printer.print("'d' or toggles display, 's' sets sort. Use 'q' or
to end!")
+ .endOfLine();
+ }
+
+ public void showField(int pos, Field field, boolean display, boolean
selected,
+int fieldHeaderMaxLength, int fieldDescriptionMaxLength, boolean moveMode)
{
+
+String fieldHeader =
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312745950
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/Record.java
##
@@ -0,0 +1,180 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.util.Collection;
+import java.util.Collections;
+import java.util.EnumMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.stream.Stream;
+import javax.validation.constraints.NotNull;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldValue;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Represents a record of the metrics in the top screen.
+ */
+@InterfaceAudience.Private
+public class Record implements Map {
+
+ private Map values;
+
+ public static final class Entry implements Map.Entry {
+private final Field key;
+private FieldValue value;
+
+private Entry(Field key, FieldValue value) {
+ this.key = Objects.requireNonNull(key);
+ this.value = Objects.requireNonNull(value);
+}
+
+@Override
+public Field getKey() {
+ return key;
+}
+
+@Override
+public FieldValue getValue() {
+ return value;
+}
+
+@Override
+public FieldValue setValue(FieldValue value) {
+ FieldValue oldValue = this.value;
+ this.value = value;
+ return oldValue;
+}
+ }
+
+ public static Entry entry(Field field, Object value) {
+return new Entry(field, field.newValue(value));
+ }
+
+ public static Entry entry(Field field, FieldValue value) {
+return new Entry(field, value);
+ }
+
+ public static Record ofEntries(List entries) {
+return ofEntries(entries.stream());
+ }
+
+ public static Record ofEntries(Entry... entries) {
+return ofEntries(Stream.of(entries));
+ }
+
+ public static Record ofEntries(Stream entries) {
+return entries
+ .collect(Record::new, (r, e) -> r.put(e.getKey(), e.getValue()), (r1,
r2) -> {});
+ }
+
+ public Record() {
+this(new EnumMap<>(Field.class));
+ }
+
+ private Record(Map values) {
+this.values = values;
+ }
+
+ @Override
+ public int size() {
+return values.size();
+ }
+
+ @Override
+ public boolean isEmpty() {
+return values.isEmpty();
+ }
+
+ @Override
+ public boolean containsKey(Object key) {
+return values.containsKey(key);
+ }
+
+ @Override
+ public boolean containsValue(Object value) {
+return values.containsValue(value);
+ }
+
+ @Override
+ public FieldValue get(Object key) {
+return values.get(key);
+ }
+
+ @Override
+ public FieldValue put(Field key, FieldValue value) {
+return values.put(key, value);
+ }
+
+ public FieldValue put(Field key, Object value) {
+return values.put(key, key.newValue(value));
+ }
+
+ @Override
+ public FieldValue remove(Object key) {
+return values.remove(key);
+ }
+
+ @Override
+ public void putAll(@NotNull Map m) {
+values.putAll(m);
+ }
+
+ @Override
+ public void clear() {
+values.clear();
+ }
+
+ @Override
+ @NotNull
+ public Set keySet() {
+return values.keySet();
+ }
+
+ @Override
+ @NotNull
+ public Collection values() {
+return values.values();
+ }
+
+ @Override
+ @NotNull
+ public Set> entrySet() {
+return values.entrySet();
+ }
+
+ public Record combine(Record o) {
+return ofEntries(values.keySet().stream()
+ .map(k -> {
+switch (k.getFieldValueType()) {
+ case STRING:
+return entry(k, values.get(k));
+ default:
+return entry(k, values.get(k).plus(o.values.get(k)));
+}
+ }));
+ }
+
+ public Record toImmutable() {
+return new Record(Collections.unmodifiableMap(values));
+ }
+}
Review comment:
Nice. Clean. Generic. Is there a lib that has this already I wonder?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312746354
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/RegionModeStrategy.java
##
@@ -0,0 +1,183 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.mode;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import org.apache.commons.lang3.time.FastDateFormat;
+import org.apache.hadoop.hbase.ClusterMetrics;
+import org.apache.hadoop.hbase.RegionMetrics;
+import org.apache.hadoop.hbase.ServerMetrics;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.RegionInfo;
+import org.apache.hadoop.hbase.hbtop.Record;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldInfo;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * Implementation for {@link ModeStrategy} for Region Mode.
+ */
+@InterfaceAudience.Private
+public final class RegionModeStrategy implements ModeStrategy {
+
+ private final List fieldInfos = Arrays.asList(
+new FieldInfo(Field.REGION_NAME, 0, false),
+new FieldInfo(Field.NAMESPACE, 0, true),
+new FieldInfo(Field.TABLE, 0, true),
+new FieldInfo(Field.START_CODE, 13, false),
+new FieldInfo(Field.REPLICA_ID, 5, false),
+new FieldInfo(Field.REGION, 32, true),
+new FieldInfo(Field.REGION_SERVER, 0, true),
+new FieldInfo(Field.LONG_REGION_SERVER, 0, false),
+new FieldInfo(Field.REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.READ_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.FILTERED_READ_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.WRITE_REQUEST_COUNT_PER_SECOND, 8, true),
+new FieldInfo(Field.STORE_FILE_SIZE, 10, true),
+new FieldInfo(Field.UNCOMPRESSED_STORE_FILE_SIZE, 12, false),
+new FieldInfo(Field.NUM_STORE_FILES,4, true),
+new FieldInfo(Field.MEM_STORE_SIZE, 8, true),
+new FieldInfo(Field.LOCALITY, 8, true),
+new FieldInfo(Field.START_KEY, 0, false),
+new FieldInfo(Field.COMPACTING_CELL_COUNT, 12, false),
+new FieldInfo(Field.COMPACTED_CELL_COUNT, 12, false),
+new FieldInfo(Field.COMPACTION_PROGRESS, 7, false),
+new FieldInfo(Field.LAST_MAJOR_COMPACTION_TIME, 19, false)
+ );
+
+ private final Map requestCountPerSecondMap =
new HashMap<>();
+
+ RegionModeStrategy() {
+ }
+
+ @Override
+ public List getFieldInfos() {
+return fieldInfos;
+ }
+
+ @Override
+ public Field getDefaultSortField() {
+return Field.REQUEST_COUNT_PER_SECOND;
+ }
+
+ @Override
+ public List getRecords(ClusterMetrics clusterMetrics) {
+List ret = new ArrayList<>();
+for (ServerMetrics sm : clusterMetrics.getLiveServerMetrics().values()) {
+ long lastReportTimestamp = sm.getLastReportTimestamp();
+ for (RegionMetrics rm : sm.getRegionMetrics().values()) {
+ret.add(createRecord(sm, rm, lastReportTimestamp));
+ }
+}
+return ret;
+ }
+
+ private Record createRecord(ServerMetrics serverMetrics, RegionMetrics
regionMetrics,
+long lastReportTimestamp) {
+
+Record ret = new Record();
+
+String regionName = regionMetrics.getNameAsString();
+ret.put(Field.REGION_NAME, regionName);
+
+String namespaceName = "";
+String tableName = "";
+String region = "";
+String startKey = "";
+String startCode = "";
+String replicaId = "";
+try {
+ byte[][] elements =
RegionInfo.parseRegionName(regionMetrics.getRegionName());
+ TableName tn = TableName.valueOf(elements[0]);
+ namespaceName = tn.getNamespaceAsString();
+ tableName = tn.getQualifierAsString();
+ startKey = Bytes.toStringBinary(elements[1]);
+ startCode = Bytes.toString(elements[2]);
+ replicaId = elements.length == 4 ?
+Integer.valueOf(Bytes.toString(elements[3])).toString() : "";
+ region =
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop URL: https://github.com/apache/hbase/pull/476#discussion_r312745771 ## File path: hbase-assembly/pom.xml ## @@ -309,6 +309,10 @@ org.apache.hbase hbase-zookeeper + + org.apache.hbase + hbase-hbtop + Review comment: You made a separate module for it? If so, thats great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312746293
##
File path:
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/mode/ModeStrategy.java
##
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop.mode;
+
+import edu.umd.cs.findbugs.annotations.Nullable;
+import java.util.List;
+import org.apache.hadoop.hbase.ClusterMetrics;
+import org.apache.hadoop.hbase.hbtop.Record;
+import org.apache.hadoop.hbase.hbtop.field.Field;
+import org.apache.hadoop.hbase.hbtop.field.FieldInfo;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+/**
+ * An interface for strategy logic for {@link Mode}.
+ */
+@InterfaceAudience.Private
+interface ModeStrategy {
+ List getFieldInfos();
+ Field getDefaultSortField();
+ List getRecords(ClusterMetrics clusterMetrics);
+ @Nullable DrillDownInfo drillDown(Record selectedRecord);
+}
Review comment:
How did you come up w/ this model? It looks nice. Makes me wonder though if
we couldn't use a lib given much seems generic. But looks great.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #476: HBASE-11062 hbtop
saintstack commented on a change in pull request #476: HBASE-11062 hbtop
URL: https://github.com/apache/hbase/pull/476#discussion_r312745906
##
File path: hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/HBTop.java
##
@@ -0,0 +1,141 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.hbtop;
+
+import java.io.InputStream;
+import java.util.Objects;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
+import org.apache.hadoop.hbase.HBaseConfiguration;
+import org.apache.hadoop.hbase.hbtop.mode.Mode;
+import org.apache.hadoop.hbase.hbtop.screen.Screen;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
+import org.apache.log4j.PropertyConfigurator;
+import org.apache.yetus.audience.InterfaceAudience;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hbase.thirdparty.org.apache.commons.cli.CommandLine;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.DefaultParser;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.HelpFormatter;
+import org.apache.hbase.thirdparty.org.apache.commons.cli.Options;
+
+
+/**
+ * A real-time monitoring tool for HBase like Unix top command.
+ */
+@InterfaceAudience.Private
+public class HBTop extends Configured implements Tool {
+
+ private static final Logger LOGGER = LoggerFactory.getLogger(HBTop.class);
+
+ public HBTop() {
+this(HBaseConfiguration.create());
+ }
+
+ public HBTop(Configuration conf) {
+super(Objects.requireNonNull(conf));
+ }
+
+ @Override
+ public int run(String[] args) throws Exception {
+// In order to change the log level forcibly, read a custom log4j
configuration file
+InputStream log4jConfigInputStream = this.getClass().getClassLoader()
+ .getResourceAsStream("log4j-hbtop.properties");
+PropertyConfigurator.configure(log4jConfigInputStream);
+
+long initialRefreshDelay = 3 * 1000;
+Mode initialMode = Mode.REGION;
+try {
+ // Command line options
+ Options opts = new Options();
+ opts.addOption("help", false,
+"Print usage; for help while the tool is running press 'h'");
+ opts.addOption("delay", true,
+"The refresh delay (in seconds); default is 3 seconds");
+ opts.addOption("mode", true,
+"The mode; n (Namespace)|t (Table)|r (Region)|s (RegionServer)"
Review comment:
Nice.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch
virajjasani commented on issue #468: HBASE-22822 : Un/Re-schedule balancer chore with balance_switch URL: https://github.com/apache/hbase/pull/468#issuecomment-520240474 Please review @apurtell @Reidd @anoopsjohn This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-22728) Upgrade jackson dependencies in branch-1
[ https://issues.apache.org/jira/browse/HBASE-22728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22728: - Attachment: HBASE-22728.branch-1.15.patch > Upgrade jackson dependencies in branch-1 > > > Key: HBASE-22728 > URL: https://issues.apache.org/jira/browse/HBASE-22728 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.4.10, 1.3.5 >Reporter: Andrew Purtell >Assignee: Viraj Jasani >Priority: Major > Fix For: 1.5.0, 1.3.6, 1.4.11 > > Attachments: HBASE-22728-addendum.patch, HBASE-22728-addendum.patch, > HBASE-22728.branch-1.01.patch, HBASE-22728.branch-1.02.patch, > HBASE-22728.branch-1.04.patch, HBASE-22728.branch-1.06.patch, > HBASE-22728.branch-1.10.patch, HBASE-22728.branch-1.11.patch, > HBASE-22728.branch-1.12.patch, HBASE-22728.branch-1.14.patch, > HBASE-22728.branch-1.15.patch > > > Avoid Jackson versions and dependencies with known CVEs -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-21879) Read HFile's block to ByteBuffer directly instead of to byte for reducing young gc purpose
[
https://issues.apache.org/jira/browse/HBASE-21879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904668#comment-16904668
]
Hudson commented on HBASE-21879:
Results for branch HBASE-21879
[build #205 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/205/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/205//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/205//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-21879/205//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Read HFile's block to ByteBuffer directly instead of to byte for reducing
> young gc purpose
> --
>
> Key: HBASE-21879
> URL: https://issues.apache.org/jira/browse/HBASE-21879
> Project: HBase
> Issue Type: Improvement
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-21879.v1.patch, HBASE-21879.v1.patch,
> QPS-latencies-before-HBASE-21879.png, gc-data-before-HBASE-21879.png
>
>
> In HFileBlock#readBlockDataInternal, we have the following:
> {code}
> @VisibleForTesting
> protected HFileBlock readBlockDataInternal(FSDataInputStream is, long offset,
> long onDiskSizeWithHeaderL, boolean pread, boolean verifyChecksum,
> boolean updateMetrics)
> throws IOException {
> // .
> // TODO: Make this ByteBuffer-based. Will make it easier to go to HDFS with
> BBPool (offheap).
> byte [] onDiskBlock = new byte[onDiskSizeWithHeader + hdrSize];
> int nextBlockOnDiskSize = readAtOffset(is, onDiskBlock, preReadHeaderSize,
> onDiskSizeWithHeader - preReadHeaderSize, true, offset +
> preReadHeaderSize, pread);
> if (headerBuf != null) {
> // ...
> }
> // ...
> }
> {code}
> In the read path, we still read the block from hfile to on-heap byte[], then
> copy the on-heap byte[] to offheap bucket cache asynchronously, and in my
> 100% get performance test, I also observed some frequent young gc, The
> largest memory footprint in the young gen should be the on-heap block byte[].
> In fact, we can read HFile's block to ByteBuffer directly instead of to
> byte[] for reducing young gc purpose. we did not implement this before,
> because no ByteBuffer reading interface in the older HDFS client, but 2.7+
> has supported this now, so we can fix this now. I think.
> Will provide an patch and some perf-comparison for this.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (HBASE-22833) MultiRowRangeFilter should provide a method for creating a filter which is functionally equivalent to multiple prefix filters
Itsuki Toyota created HBASE-22833:
-
Summary: MultiRowRangeFilter should provide a method for creating
a filter which is functionally equivalent to multiple prefix filters
Key: HBASE-22833
URL: https://issues.apache.org/jira/browse/HBASE-22833
Project: HBase
Issue Type: Wish
Components: Client
Affects Versions: 3.0.0
Reporter: Itsuki Toyota
HI,
I think current formal way to make multiple prefix filters is to create a
_FilterList_ and add _PrefixFilter_ instances to the list:
{code:java}
FilterList allFilters = new FilterList(FilterList.Operator.MUST_PASS_ONE);
allFilters.addFilter(new PrefixFilter(Bytes.toBytes("123")));
allFilters.addFilter(new PrefixFilter(Bytes.toBytes("456")));
allFilters.addFilter(new PrefixFilter(Bytes.toBytes("678")));
scan.setFilter(allFilters);
{code}
(c.f.,
https://stackoverflow.com/questions/41074213/hbase-how-to-specify-multiple-prefix-filters-in-a-single-scan-operation
)
However, in the case of creating a single prefix filter, HBase provides
_scan.setRowPrefixFilter_ method.
This method creates a range filter by setting a start row and a stop row.
The value of a stop row is decided by calling
_calculateTheClosestNextRowKeyForPrefix_ ( c.f.,
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java#L574-L597
)
_MultiRowRangeFilter_ could leverage a list of start row and stop row pairs and
_calculateTheClosestNextRowKeyForPrefix_ could compute the stop row value
corresponding to given start row (i.e., a prefix).
I think this kind of filter (a filter which is functionally equivalent to
multiple prefix filters) should be creatable by _MultiRowRangeFilter_ and it's
better than the current formal way.
Cheers,
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase
[
https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904571#comment-16904571
]
Hudson commented on HBASE-22514:
Results for branch HBASE-22514
[build #55 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/55/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/55//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/55//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-22514/55//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Move rsgroup feature into core of HBase
> ---
>
> Key: HBASE-22514
> URL: https://issues.apache.org/jira/browse/HBASE-22514
> Project: HBase
> Issue Type: Umbrella
> Components: Admin, Client, rsgroup
>Reporter: Yechao Chen
>Assignee: Duo Zhang
>Priority: Major
> Attachments: HBASE-22514.master.001.patch,
> image-2019-05-31-18-25-38-217.png
>
>
> The class RSGroupAdminClient is not public
> we need to use java api RSGroupAdminClient to manager RSG
> so RSGroupAdminClient should be public
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
