[jira] [Comment Edited] (HBASE-24215) [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
[
https://issues.apache.org/jira/browse/HBASE-24215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086733#comment-17086733
]
Michael Stack edited comment on HBASE-24215 at 4/19/20, 3:43 AM:
-
Same issue? The linked HBASE-20495. It has a patch that adds jersey-core as
explicit dependency. https://github.com/FaKod/neo4j-scala/issues/33 suggests
jersey-core. Let me dig...
was (Author: stack):
Same issue?
> [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
>
>
> Key: HBASE-24215
> URL: https://issues.apache.org/jira/browse/HBASE-24215
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> Happened in two builds... 2.3 and 2:
> jdk8 hadoop3 nightly just now
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2.3/44/
> {code}
> [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.01
> s <<< ERROR!
> java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> Caused by: java.lang.ClassNotFoundException:
> com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> {code}
> Then again in branch2
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2/2619/
> {code}
> [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed:
> 0.017 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> Caused by: java.lang.ClassNotFoundException:
> com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24212) HMaster UI hangs when rsgorup is enabled and meta-region is not available
[ https://issues.apache.org/jira/browse/HBASE-24212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Arshad updated HBASE-24212: Description: HMaster UI hangs when rsgroup is enabled and meta-region is not available. Steps to reproduce: # Cluster: 1 Master, 3 RS # Create rsgroup r1 and r2 # Move rs1 to r1 and rs2 to r2 then all the regions are online on rs3 # Stop rs3 # Now access URL hmaster:Host:infoPort/master-status The page will not open. was: HMaster UI hangs when rsgroup is enabled and meta-region is not available. Steps to reproduce: # Cluster: 1 Master, 3 RS # Create rsgroup r1 and r2 # Move rs1 to r1 and rs2 to r2 then all the regions are online on rs3 # Stop rs3 # Now access URL hmaster:Host:infoPort/master-status The page will not open. I think when meta region is not available, we should take the rsgroup information from ZooKeeper and proceed > HMaster UI hangs when rsgorup is enabled and meta-region is not available > - > > Key: HBASE-24212 > URL: https://issues.apache.org/jira/browse/HBASE-24212 > Project: HBase > Issue Type: Bug > Components: rsgroup >Affects Versions: master, 2.2.4 >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Major > > HMaster UI hangs when rsgroup is enabled and meta-region is not available. > Steps to reproduce: > # Cluster: 1 Master, 3 RS > # Create rsgroup r1 and r2 > # Move rs1 to r1 and rs2 to r2 then all the regions are online on rs3 > # Stop rs3 > # Now access URL hmaster:Host:infoPort/master-status The page will not open. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24215) [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
[
https://issues.apache.org/jira/browse/HBASE-24215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086733#comment-17086733
]
Michael Stack commented on HBASE-24215:
---
Same issue?
> [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
>
>
> Key: HBASE-24215
> URL: https://issues.apache.org/jira/browse/HBASE-24215
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> Happened in two builds... 2.3 and 2:
> jdk8 hadoop3 nightly just now
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2.3/44/
> {code}
> [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.01
> s <<< ERROR!
> java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> Caused by: java.lang.ClassNotFoundException:
> com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> {code}
> Then again in branch2
> https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2/2619/
> {code}
> [ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed:
> 0.017 s <<< ERROR!
> java.lang.NoClassDefFoundError:
> com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> Caused by: java.lang.ClassNotFoundException:
> com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
> at
> org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (HBASE-24215) [Flakey Tests] [ERROR] TestSecureRESTServer java.lang.NoClassDefFoundError: com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
Michael Stack created HBASE-24215:
-
Summary: [Flakey Tests] [ERROR] TestSecureRESTServer
java.lang.NoClassDefFoundError:
com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
Key: HBASE-24215
URL: https://issues.apache.org/jira/browse/HBASE-24215
Project: HBase
Issue Type: Bug
Reporter: Michael Stack
Happened in two builds... 2.3 and 2:
jdk8 hadoop3 nightly just now
https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2.3/44/
{code}
[ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.01 s
<<< ERROR!
java.lang.NoClassDefFoundError:
com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
at
org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
Caused by: java.lang.ClassNotFoundException:
com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
at
org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
{code}
Then again in branch2
https://builds.apache.org/view/H-L/view/HBase/job/HBase%20Nightly/job/branch-2/2619/
{code}
[ERROR] org.apache.hadoop.hbase.rest.TestSecureRESTServer Time elapsed: 0.017
s <<< ERROR!
java.lang.NoClassDefFoundError:
com/sun/jersey/core/spi/factory/AbstractRuntimeDelegate
at
org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
Caused by: java.lang.ClassNotFoundException:
com.sun.jersey.core.spi.factory.AbstractRuntimeDelegate
at
org.apache.hadoop.hbase.rest.TestSecureRESTServer.setupServer(TestSecureRESTServer.java:202)
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24123) [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine)
[
https://issues.apache.org/jira/browse/HBASE-24123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086731#comment-17086731
]
Michael Stack commented on HBASE-24123:
---
Another. Most of these are on laptop. This is branch-2.
{code}
[ERROR] Failures:
[ERROR] TestThriftSpnegoHttpServer.testRunThriftServerWithHeaderBufferLength
Expected: (an instance of org.apache.thrift.transport.TTransportException and
exception with message a string containing "HTTP Response code: 431")
but: an instance of org.apache.thrift.transport.TTransportException
is a java.lang.InterruptedException
Stacktrace was: java.lang.InterruptedException
at java.lang.Object.wait(Native Method)
at java.lang.Thread.join(Thread.java:1252)
at java.lang.Thread.join(Thread.java:1326)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.stopHttpServerThread(TestThriftHttpServer.java:247)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.runThriftServer(TestThriftHttpServer.java:183)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength(TestThriftHttpServer.java:147)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
[ERROR] Errors:
[ERROR] org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpServer.null
[ERROR] Run 1:
TestThriftSpnegoHttpServer>TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength:147->TestThriftHttpServer.runThriftServer:183->TestThriftHttpServer.stopHttpServerThread:247->Object.wait:-2
» TestTimedOut
[ERROR] Run 2: TestThriftSpnegoHttpServer » Appears to be stuck in thread
Thread-0
[INFO]
[ERROR]
TestThrift2ServerCmdLine>TestThriftServerCmdLine.testRunThriftServer:316 »
or...
[INFO]
[ERROR] Tests run: 152, Failures: 1, Errors: 2, Skipped: 1
{code}
> [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine)
> --
>
> Key: HBASE-24123
> URL: https://issues.apache.org/jira/browse/HBASE-24123
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail
> frequently in local runs for myriad reasons: protocol failures, wrong answers
> on query, connection resets, etc. Each test runs 40 different combinations of
> config.
> This is after work done to try and stabilize by fixing port clash issues.
> Let me list in here the ways in which it fails. I will disable after I get a
> good list. Will also try and do some more stabilization too in sub-issues.
> Lets see which prevails; stabilization or disabling.
> For starters, this morning I got this:
> {code}
>
> ---
> Test set:
[jira] [Resolved] (HBASE-24101) Correct snapshot handling
[ https://issues.apache.org/jira/browse/HBASE-24101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov resolved HBASE-24101. --- Resolution: Not A Problem > Correct snapshot handling > - > > Key: HBASE-24101 > URL: https://issues.apache.org/jira/browse/HBASE-24101 > Project: HBase > Issue Type: Sub-task > Components: mob, snapshots >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > > Reopening this umbrella to address correct snapshot handling. Particularly, > the following scenario must be verified: > # load data to a table > # take snapshot > # major compact table > # run mob file cleaner chore > # load data to table > # restore table from snapshot into another table > # verify data integrity > # restore table from snapshot into original table > # verify data integrity -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-22749) Distributed MOB compactions
[ https://issues.apache.org/jira/browse/HBASE-22749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Rodionov resolved HBASE-22749. --- Resolution: Fixed > Distributed MOB compactions > > > Key: HBASE-22749 > URL: https://issues.apache.org/jira/browse/HBASE-22749 > Project: HBase > Issue Type: New Feature > Components: mob >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-22749-branch-2.2-v4.patch, > HBASE-22749-master-v1.patch, HBASE-22749-master-v2.patch, > HBASE-22749-master-v3.patch, HBASE-22749-master-v4.patch, > HBASE-22749_nightly_Unit_Test_Results.csv, > HBASE-22749_nightly_unit_test_analyzer.pdf, HBase-MOB-2.0-v3.0.pdf > > > There are several drawbacks in the original MOB 1.0 (Moderate Object > Storage) implementation, which can limit the adoption of the MOB feature: > # MOB compactions are executed in a Master as a chore, which limits > scalability because all I/O goes through a single HBase Master server. > # Yarn/Mapreduce framework is required to run MOB compactions in a scalable > way, but this won’t work in a stand-alone HBase cluster. > # Two separate compactors for MOB and for regular store files and their > interactions can result in a data loss (see HBASE-22075) > The design goals for MOB 2.0 were to provide 100% MOB 1.0 - compatible > implementation, which is free of the above drawbacks and can be used as a > drop in replacement in existing MOB deployments. So, these are design goals > of a MOB 2.0: > # Make MOB compactions scalable without relying on Yarn/Mapreduce framework > # Provide unified compactor for both MOB and regular store files > # Make it more robust especially w.r.t. to data losses. > # Simplify and reduce the overall MOB code. > # Provide 100% compatible implementation with MOB 1.0. > # No migration of data should be required between MOB 1.0 and MOB 2.0 - just > software upgrade. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24101) Correct snapshot handling
[ https://issues.apache.org/jira/browse/HBASE-24101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086728#comment-17086728 ] Vladimir Rodionov commented on HBASE-24101: --- Verified, not the issue. > Correct snapshot handling > - > > Key: HBASE-24101 > URL: https://issues.apache.org/jira/browse/HBASE-24101 > Project: HBase > Issue Type: Sub-task > Components: mob, snapshots >Reporter: Vladimir Rodionov >Assignee: Vladimir Rodionov >Priority: Critical > > Reopening this umbrella to address correct snapshot handling. Particularly, > the following scenario must be verified: > # load data to a table > # take snapshot > # major compact table > # run mob file cleaner chore > # load data to table > # restore table from snapshot into another table > # verify data integrity > # restore table from snapshot into original table > # verify data integrity -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API
Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1549#issuecomment-616012969 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 36s | master passed | | +1 :green_heart: | compile | 1m 9s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 1m 7s | the patch passed | | +1 :green_heart: | javac | 1m 7s | the patch passed | | +1 :green_heart: | shadedjars | 5m 35s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 179m 45s | hbase-server in the patch failed. | | | | 206m 12s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1549 | | JIRA Issue | HBASE-24025 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3b077ef5a8f0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/testReport/ | | Max. process+thread count | 3364 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API
Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1549#issuecomment-616012600 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 1s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 0m 57s | the patch passed | | +1 :green_heart: | javac | 0m 57s | the patch passed | | +1 :green_heart: | shadedjars | 5m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 178m 40s | hbase-server in the patch failed. | | | | 203m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1549 | | JIRA Issue | HBASE-24025 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 21ba6c65ad1f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/testReport/ | | Max. process+thread count | 3709 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[
https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086703#comment-17086703
]
Hudson commented on HBASE-24174:
Results for branch branch-2.2
[build #843 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix findbugs warning on ServiceAuthorizationManager
> ---
>
> Key: HBASE-24174
> URL: https://issues.apache.org/jira/browse/HBASE-24174
> Project: HBase
> Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5
>
>
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time.
> It is introduced by HBASE-24121, let me fix it. It haven't got released yet.
> Looks affect branch-1 so far.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24166) Duplicate implementation for acquireLock between CreateTableProcedure and its parent class
[
https://issues.apache.org/jira/browse/HBASE-24166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086702#comment-17086702
]
Hudson commented on HBASE-24166:
Results for branch branch-2.2
[build #843 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/843//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Duplicate implementation for acquireLock between CreateTableProcedure and its
> parent class
> --
>
> Key: HBASE-24166
> URL: https://issues.apache.org/jira/browse/HBASE-24166
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
>Affects Versions: 3.0.0, 2.2.4
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> The override method _acquireLock_ in _CreateTableProcedure_ and
> _InitMetaProcedure_ is the same as the implementation in its parent class
> _AbstractStateMachineTableProcedure_. So delete the override method in
> subclass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API
Apache-HBase commented on issue #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1549#issuecomment-615982250 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 13s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 18s | the patch passed | | -0 :warning: | checkstyle | 1m 4s | hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 32s | Patch does not cause any errors with Hadoop 3.1.2. | | +1 :green_heart: | spotbugs | 2m 24s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 27m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1549 | | JIRA Issue | HBASE-24025 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 2b5a3ff0010c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1549/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-22769) Runtime Error on join (with filter) when using hbase-spark connector
[
https://issues.apache.org/jira/browse/HBASE-22769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086689#comment-17086689
]
Ani commented on HBASE-22769:
-
Any update on this issue?
> Runtime Error on join (with filter) when using hbase-spark connector
>
>
> Key: HBASE-22769
> URL: https://issues.apache.org/jira/browse/HBASE-22769
> Project: HBase
> Issue Type: Bug
> Components: hbase-connectors
>Affects Versions: connector-1.0.0
> Environment: Built using maven scala plugin on intellij IDEA with
> Maven 3.3.9. Ran on Azure HDInsight Spark cluster using Yarn.
> Spark version: 2.4.0
> Scala version: 2.11.12
> hbase-spark version: 1.0.0
>Reporter: Noah Banholzer
>Priority: Blocker
>
> I am attempting to do a left outer join (though any join with a push down
> filter causes this issue) between a Spark Structured Streaming DataFrame and
> a DataFrame read from HBase. I get the following stack trace when running a
> simple spark app that reads from a streaming source and attempts to left
> outer join with a dataframe read from HBase:
> {{19/07/30 18:30:25 INFO DAGScheduler: ShuffleMapStage 1 (start at
> SparkAppTest.scala:88) failed in 3.575 s due to Job aborted due to stage
> failure: Task 0 in stage 1.0 failed 4 times, most recent failure: Lost task
> 0.3 in stage 1.0 (TID 10,
> wn5-edpspa.hnyo2upsdeau1bffc34wwrkgwc.ex.internal.cloudapp.net, executor 2):
> org.apache.hadoop.hbase.DoNotRetryIOException:
> org.apache.hadoop.hbase.DoNotRetryIOException:
> java.lang.reflect.InvocationTargetException at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toFilter(ProtobufUtil.java:1609)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toScan(ProtobufUtil.java:1154)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.newRegionScanner(RSRpcServices.java:2967)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:3301)
> at
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:42002)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:413) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:131) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:324) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:304)
> Caused by: java.lang.reflect.InvocationTargetException at
> sun.reflect.GeneratedMethodAccessor15461.invoke(Unknown Source) at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.toFilter(ProtobufUtil.java:1605)
> }}
> {{... 8 more }}
> {{Caused by: java.lang.NoClassDefFoundError:
> org/apache/hadoop/hbase/spark/datasources/JavaBytesEncoder$ at
> org.apache.hadoop.hbase.spark.datasources.JavaBytesEncoder.create(JavaBytesEncoder.scala)
> at
> org.apache.hadoop.hbase.spark.SparkSQLPushDownFilter.parseFrom(SparkSQLPushDownFilter.java:196)
> }}
> {{... 12 more }}
> {{at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.instantiateException(RemoteWithExtrasException.java:100)
> at
> org.apache.hadoop.hbase.ipc.RemoteWithExtrasException.unwrapRemoteException(RemoteWithExtrasException.java:90)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.makeIOExceptionOfException(ProtobufUtil.java:359)
> at
> org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil.handleRemoteException(ProtobufUtil.java:347)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.openScanner(ScannerCallable.java:344)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:242)
> at
> org.apache.hadoop.hbase.client.ScannerCallable.rpcCall(ScannerCallable.java:58)
> at
> org.apache.hadoop.hbase.client.RegionServerCallable.call(RegionServerCallable.java:127)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithoutRetries(RpcRetryingCallerImpl.java:192)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:387)
> at
> org.apache.hadoop.hbase.client.ScannerCallableWithReplicas$RetryingRPC.call(ScannerCallableWithReplicas.java:361)
> at
> org.apache.hadoop.hbase.client.RpcRetryingCallerImpl.callWithRetries(RpcRetryingCallerImpl.java:107)
> at
>
[jira] [Commented] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[
https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086685#comment-17086685
]
Hudson commented on HBASE-24174:
Results for branch branch-2
[build #2618 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix findbugs warning on ServiceAuthorizationManager
> ---
>
> Key: HBASE-24174
> URL: https://issues.apache.org/jira/browse/HBASE-24174
> Project: HBase
> Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5
>
>
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time.
> It is introduced by HBASE-24121, let me fix it. It haven't got released yet.
> Looks affect branch-1 so far.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24166) Duplicate implementation for acquireLock between CreateTableProcedure and its parent class
[
https://issues.apache.org/jira/browse/HBASE-24166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086684#comment-17086684
]
Hudson commented on HBASE-24166:
Results for branch branch-2
[build #2618 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2618/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Duplicate implementation for acquireLock between CreateTableProcedure and its
> parent class
> --
>
> Key: HBASE-24166
> URL: https://issues.apache.org/jira/browse/HBASE-24166
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
>Affects Versions: 3.0.0, 2.2.4
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> The override method _acquireLock_ in _CreateTableProcedure_ and
> _InitMetaProcedure_ is the same as the implementation in its parent class
> _AbstractStateMachineTableProcedure_. So delete the override method in
> subclass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] arshadmohammad commented on issue #1321: HBASE-24025: Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API
arshadmohammad commented on issue #1321: HBASE-24025: Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1321#issuecomment-615975253 This PR has to be updated, will update after changes are merged in master branch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] arshadmohammad opened a new pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API
arshadmohammad opened a new pull request #1549: HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1549 HBASE-24025: Improve performance of move_servers_rsgroup by using async region move API This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] arshadmohammad commented on issue #1321: HBASE-24025: Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API
arshadmohammad commented on issue #1321: HBASE-24025: Improve performance of move_servers_rsgroup and move_tables_rsgroup by using async region move API URL: https://github.com/apache/hbase/pull/1321#issuecomment-615974514 Create PR for master branch. https://github.com/apache/hbase/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24207) Wrong input argument order in TestCompactorMemLeak#assertMajorCompactionOK
[
https://issues.apache.org/jira/browse/HBASE-24207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ctest updated HBASE-24207:
--
Summary: Wrong input argument order in
TestCompactorMemLeak#assertMajorCompactionOK (was: Wrong argument input order
in TestCompactorMemLeak#assertMajorCompactionOK)
> Wrong input argument order in TestCompactorMemLeak#assertMajorCompactionOK
> --
>
> Key: HBASE-24207
> URL: https://issues.apache.org/jira/browse/HBASE-24207
> Project: HBase
> Issue Type: Bug
> Components: Compaction, regionserver, test
>Affects Versions: 2.2.4
>Reporter: Ctest
>Priority: Minor
> Labels: compaction, regionserver, test
> Attachments: HBASE-24207.000.patch
>
>
> In TestCompactorMemLeak#assertMajorCompactionOK, the input argument order for
> Assert.assertEquals(long expected, long actual) is wrong. This produced
> confusion when the test failed.
>
> Below is the original code:
> {code:java}
> Assert.assertEquals(regions.size(), 1);
> HRegion region = regions.get(0);
> Assert.assertEquals(region.getStores().size(), 1);
> HStore store = region.getStore(FAMILY);
> Assert.assertEquals(store.getStorefilesCount(), 1);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled. URL: https://github.com/apache/hbase/pull/1546#issuecomment-615923761 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 34s | master passed | | +1 :green_heart: | compile | 1m 28s | master passed | | +1 :green_heart: | shadedjars | 5m 38s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 19s | the patch passed | | +1 :green_heart: | compile | 1m 27s | the patch passed | | +1 :green_heart: | javac | 1m 27s | the patch passed | | +1 :green_heart: | shadedjars | 5m 42s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 44s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 201m 0s | hbase-server in the patch failed. | | | | 230m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1546 | | JIRA Issue | HBASE-24211 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 975641db6815 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-zookeeper.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/testReport/ | | Max. process+thread count | 3361 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24123) [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine)
[
https://issues.apache.org/jira/browse/HBASE-24123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack updated HBASE-24123:
--
Summary: [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine) (was:
[Flakey Tests] TestThrift?ServerCmdLine)
> [Flakey Tests] Thrift tests (TestThrift?ServerCmdLine)
> --
>
> Key: HBASE-24123
> URL: https://issues.apache.org/jira/browse/HBASE-24123
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail
> frequently in local runs for myriad reasons: protocol failures, wrong answers
> on query, connection resets, etc. Each test runs 40 different combinations of
> config.
> This is after work done to try and stabilize by fixing port clash issues.
> Let me list in here the ways in which it fails. I will disable after I get a
> good list. Will also try and do some more stabilization too in sub-issues.
> Lets see which prevails; stabilization or disabling.
> For starters, this morning I got this:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> ---
> Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.301 s
> <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.testRunThriftServer[29]
> Time elapsed: 0.964 s <<< ERROR!
> java.lang.Exception: org.apache.thrift.transport.TTransportException:
> java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> Caused by: java.net.SocketException: Connection reset
>at
> org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine.talkToThriftServer(TestThrift2ServerCmdLine.java:92)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24123) [Flakey Tests] TestThrift?ServerCmdLine
[
https://issues.apache.org/jira/browse/HBASE-24123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086550#comment-17086550
]
Michael Stack commented on HBASE-24123:
---
This is w/ the 0.13 thrift:
{code}
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.869
s - in org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestThrift2HttpServer.testRunThriftServerWithHeaderBufferLength
Expected: (an instance of org.apache.thrift.transport.TTransportException and
exception with message a string containing "HTTP Response code: 431")
but: an instance of org.apache.thrift.transport.TTransportException
but was:<405>> is a
java.lang.AssertionError
Stacktrace was: java.lang.AssertionError: expected:<403> but was:<405>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.checkHttpMethods(TestThriftHttpServer.java:210)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.runThriftServer(TestThriftHttpServer.java:178)
at
org.apache.hadoop.hbase.thrift.TestThriftHttpServer.testRunThriftServerWithHeaderBufferLength(TestThriftHttpServer.java:147)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at
org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:288)
at
org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:282)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.lang.Thread.run(Thread.java:748)
{code}
> [Flakey Tests] TestThrift?ServerCmdLine
> ---
>
> Key: HBASE-24123
> URL: https://issues.apache.org/jira/browse/HBASE-24123
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Priority: Major
>
> TestThrift2ServerCmdLine and TestThriftServerCmdLine are flakey. They fail
> frequently in local runs for myriad reasons: protocol failures, wrong answers
> on query, connection resets, etc. Each test runs 40 different combinations of
> config.
> This is after work done to try and stabilize by fixing port clash issues.
> Let me list in here the ways in which it fails. I will disable after I get a
> good list. Will also try and do some more stabilization too in sub-issues.
> Lets see which prevails; stabilization or disabling.
> For starters, this morning I got this:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
> ---
> Tests run: 32, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 126.301 s
> <<< FAILURE! - in org.apache.hadoop.hbase.thrift2.TestThrift2ServerCmdLine
>
>
[GitHub] [hbase] Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled. URL: https://github.com/apache/hbase/pull/1546#issuecomment-615908833 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 37s | master passed | | +1 :green_heart: | compile | 1m 14s | master passed | | +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 52s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | compile | 1m 13s | the patch passed | | +1 :green_heart: | javac | 1m 13s | the patch passed | | +1 :green_heart: | shadedjars | 4m 54s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 51s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 0m 41s | hbase-zookeeper in the patch passed. | | -1 :x: | unit | 136m 51s | hbase-server in the patch failed. | | | | 162m 17s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1546 | | JIRA Issue | HBASE-24211 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 542cd2bcd94d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/testReport/ | | Max. process+thread count | 5320 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410716897
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List newNodes = new ArrayList<>();
for (String node : nodes) {
+if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
Review comment:
getChildDataAndWatchForNewChildren is called from many places, but it is
interrupted from ZKPermissionWatcher#nodeChildrenChanged() by calling
childrenChangedFuture.cancel. Here cancel/interrupt indicates that we have
more updated data, no need to proceed with the old data. Returning empty is for
graceful exit of the processing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410716369
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List newNodes = new ArrayList<>();
for (String node : nodes) {
+if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
Review comment:
For branch-1.3.x this is an issue, the reason I have explained in the issue
description.
For master and branch-2, this PR change is for improvement as these branches
do not use zk based region assignment.
Code change is same, for branch-1.3.x it is for the fix for other branches
it is just improvement.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
Apache-HBase commented on issue #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled. URL: https://github.com/apache/hbase/pull/1546#issuecomment-615888787 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 36s | master passed | | +1 :green_heart: | checkstyle | 1m 22s | master passed | | +1 :green_heart: | spotbugs | 2m 33s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 29s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 1s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 5m 25s | Patch does not cause any errors with Hadoop 3.1.2. | | +1 :green_heart: | spotbugs | 3m 46s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 31m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1546 | | JIRA Issue | HBASE-24211 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 3c9157af6265 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2846ea4700 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-zookeeper hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1546/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
virajjasani commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410710605
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List newNodes = new ArrayList<>();
for (String node : nodes) {
+if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
Review comment:
@arshadmohammad have you seen this issue being the cause for create table
being slow or this is an improvement over preempting any existing
nodeChildrenChanged event processing (done in ZKPermissionWatcher)?
Basically, when thread is interrupted and we return empty list, what could
be the catch? Some incorrect decision could be taken by HMaster?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410707488
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List newNodes = new ArrayList<>();
for (String node : nodes) {
+if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
+ return new ArrayList<>();
Review comment:
done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410707472
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
##
@@ -185,25 +185,27 @@ public void run() {
public void nodeChildrenChanged(final String path) {
waitUntilStarted();
if (path.equals(aclZNode)) {
- try {
-final List nodeList =
-ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
-// preempt any existing nodeChildrenChanged event processing
-if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
- boolean cancelled = childrenChangedFuture.cancel(true);
- if (!cancelled) {
-// task may have finished between our check and attempted cancel,
this is fine.
-if (! childrenChangedFuture.isDone()) {
- LOG.warn("Could not cancel processing node children changed
event, " +
- "please file a JIRA and attach logs if possible.");
-}
+ // preempt any existing nodeChildrenChanged event processing
+ if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
+boolean cancelled = childrenChangedFuture.cancel(true);
+if (!cancelled) {
+ // task may have finished between our check and attempted cancel,
this is fine.
+ if (!childrenChangedFuture.isDone()) {
+LOG.warn("Could not cancel processing node children changed event,
"
+ + "please file a JIRA and attach logs if possible.");
}
}
-childrenChangedFuture = asyncProcessNodeUpdate(() ->
refreshNodes(nodeList));
- } catch (KeeperException ke) {
-LOG.error("Error reading data from zookeeper for path "+path, ke);
-watcher.abort("ZooKeeper error get node children for path "+path, ke);
}
+ childrenChangedFuture = asyncProcessNodeUpdate(() -> {
+try {
+ final List nodeList =
+ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
+ refreshNodes(nodeList);
+} catch (KeeperException ke) {
+ LOG.error("Error reading data from zookeeper for path " + path, ke);
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic
Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#issuecomment-615878182 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/1069 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1069 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1069/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic
Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#issuecomment-615878207 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/1069 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1069 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1069/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic
Apache-HBase commented on issue #1069: HBASE-23708 Support metrics for region traffic URL: https://github.com/apache/hbase/pull/1069#issuecomment-615878206 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | patch | 0m 3s | https://github.com/apache/hbase/pull/1069 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1069 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1069/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (HBASE-24166) Duplicate implementation for acquireLock between CreateTableProcedure and its parent class
[
https://issues.apache.org/jira/browse/HBASE-24166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086457#comment-17086457
]
Hudson commented on HBASE-24166:
Results for branch master
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1702/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Duplicate implementation for acquireLock between CreateTableProcedure and its
> parent class
> --
>
> Key: HBASE-24166
> URL: https://issues.apache.org/jira/browse/HBASE-24166
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
>Affects Versions: 3.0.0, 2.2.4
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> The override method _acquireLock_ in _CreateTableProcedure_ and
> _InitMetaProcedure_ is the same as the implementation in its parent class
> _AbstractStateMachineTableProcedure_. So delete the override method in
> subclass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-23800) Add documentation about the CECPs changes
[
https://issues.apache.org/jira/browse/HBASE-23800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086456#comment-17086456
]
Hudson commented on HBASE-23800:
Results for branch master
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1702/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Add documentation about the CECPs changes
> -
>
> Key: HBASE-23800
> URL: https://issues.apache.org/jira/browse/HBASE-23800
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24198) Skip hadoop2 check for master branch
[
https://issues.apache.org/jira/browse/HBASE-24198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086458#comment-17086458
]
Hudson commented on HBASE-24198:
Results for branch master
[build #1704 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1702/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1704/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Skip hadoop2 check for master branch
>
>
> Key: HBASE-24198
> URL: https://issues.apache.org/jira/browse/HBASE-24198
> Project: HBase
> Issue Type: Sub-task
> Components: hadoop2, hadoop3, pom, scripts
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> Now we will run hadoop2 check on jdk8 and hadoop3 check on jdk11, since the
> support of hadoop2 has been dropped, let's make jdk8 check also on hadoop3.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[
https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086446#comment-17086446
]
Hudson commented on HBASE-24174:
Results for branch branch-2.3
[build #43 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/43/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/43/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/43/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/43/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/43/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix findbugs warning on ServiceAuthorizationManager
> ---
>
> Key: HBASE-24174
> URL: https://issues.apache.org/jira/browse/HBASE-24174
> Project: HBase
> Issue Type: Bug
>Reporter: Reid Chan
>Assignee: Reid Chan
>Priority: Major
> Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5
>
>
> Inconsistent synchronization of
> org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time.
> It is introduced by HBASE-24121, let me fix it. It haven't got released yet.
> Looks affect branch-1 so far.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
virajjasani commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410693331
##
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List newNodes = new ArrayList<>();
for (String node : nodes) {
+if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
+ return new ArrayList<>();
Review comment:
returning `Collections.emptyList()` would be better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
virajjasani commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410693444
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
##
@@ -185,25 +185,27 @@ public void run() {
public void nodeChildrenChanged(final String path) {
waitUntilStarted();
if (path.equals(aclZNode)) {
- try {
-final List nodeList =
-ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
-// preempt any existing nodeChildrenChanged event processing
-if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
- boolean cancelled = childrenChangedFuture.cancel(true);
- if (!cancelled) {
-// task may have finished between our check and attempted cancel,
this is fine.
-if (! childrenChangedFuture.isDone()) {
- LOG.warn("Could not cancel processing node children changed
event, " +
- "please file a JIRA and attach logs if possible.");
-}
+ // preempt any existing nodeChildrenChanged event processing
+ if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
+boolean cancelled = childrenChangedFuture.cancel(true);
+if (!cancelled) {
+ // task may have finished between our check and attempted cancel,
this is fine.
+ if (!childrenChangedFuture.isDone()) {
+LOG.warn("Could not cancel processing node children changed event,
"
+ + "please file a JIRA and attach logs if possible.");
}
}
-childrenChangedFuture = asyncProcessNodeUpdate(() ->
refreshNodes(nodeList));
- } catch (KeeperException ke) {
-LOG.error("Error reading data from zookeeper for path "+path, ke);
-watcher.abort("ZooKeeper error get node children for path "+path, ke);
}
+ childrenChangedFuture = asyncProcessNodeUpdate(() -> {
+try {
+ final List nodeList =
+ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
+ refreshNodes(nodeList);
+} catch (KeeperException ke) {
+ LOG.error("Error reading data from zookeeper for path " + path, ke);
Review comment:
Please user `{}` for LOG param `path`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1546: HBASE-24211: Create table is slow in large cluster when AccessController is enabled.
virajjasani commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410693565
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
##
@@ -185,25 +185,27 @@ public void run() {
public void nodeChildrenChanged(final String path) {
waitUntilStarted();
if (path.equals(aclZNode)) {
- try {
-final List nodeList =
-ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
-// preempt any existing nodeChildrenChanged event processing
-if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
- boolean cancelled = childrenChangedFuture.cancel(true);
- if (!cancelled) {
-// task may have finished between our check and attempted cancel,
this is fine.
-if (! childrenChangedFuture.isDone()) {
- LOG.warn("Could not cancel processing node children changed
event, " +
- "please file a JIRA and attach logs if possible.");
-}
+ // preempt any existing nodeChildrenChanged event processing
+ if (childrenChangedFuture != null && !childrenChangedFuture.isDone()) {
+boolean cancelled = childrenChangedFuture.cancel(true);
+if (!cancelled) {
+ // task may have finished between our check and attempted cancel,
this is fine.
+ if (!childrenChangedFuture.isDone()) {
+LOG.warn("Could not cancel processing node children changed event,
"
+ + "please file a JIRA and attach logs if possible.");
}
}
-childrenChangedFuture = asyncProcessNodeUpdate(() ->
refreshNodes(nodeList));
- } catch (KeeperException ke) {
-LOG.error("Error reading data from zookeeper for path "+path, ke);
-watcher.abort("ZooKeeper error get node children for path "+path, ke);
}
+ childrenChangedFuture = asyncProcessNodeUpdate(() -> {
+try {
+ final List nodeList =
+ZKUtil.getChildDataAndWatchForNewChildren(watcher, aclZNode);
+ refreshNodes(nodeList);
+} catch (KeeperException ke) {
+ LOG.error("Error reading data from zookeeper for path " + path, ke);
Review comment:
Or better create a string variable and use it for both LOG.error and abort
message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1541: HBASE-24206 Unsupported rollback should not be logged as CODE-BUG
Apache9 commented on issue #1541: HBASE-24206 Unsupported rollback should not be logged as CODE-BUG URL: https://github.com/apache/hbase/pull/1541#issuecomment-615862618 Could you please show some examples where we could reach here and it is not a code bug? In general, I think rollback a procedure which does not support rollback is a bug... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [hbase] virajjasani commented on a change in pull request #1541: HBASE-24206 Unsupported rollback should not be logged as CODE-BUG
virajjasani commented on a change in pull request #1541: HBASE-24206
Unsupported rollback should not be logged as CODE-BUG
URL: https://github.com/apache/hbase/pull/1541#discussion_r410689606
##
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
##
@@ -1596,9 +1596,11 @@ private LockState
executeRollback(Procedure proc) {
} catch (InterruptedException e) {
handleInterruptedException(proc, e);
return LockState.LOCK_YIELD_WAIT;
+} catch (UnsupportedOperationException e) {
+ LOG.debug("Rollback is not supported for {}", proc);
Review comment:
Or maybe we can check for `UnsupportedOperationException`'s cause to verify
this is rollback only and not something else? Anyways, I don't have any strong
case here, just trying to understand it better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (HBASE-24214) Update Apache POM to version 23 for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-24214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Hentschel updated HBASE-24214: -- Status: Patch Available (was: In Progress) > Update Apache POM to version 23 for hbase-thirdparty > > > Key: HBASE-24214 > URL: https://issues.apache.org/jira/browse/HBASE-24214 > Project: HBase > Issue Type: Task > Components: thirdparty >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Version 23 for the Apache parent POM has been released. We should update the > hbase-thirdparty to use this one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase-thirdparty] HorizonNet opened a new pull request #17: HBASE-24214 Updated Apache POM to version 23
HorizonNet opened a new pull request #17: HBASE-24214 Updated Apache POM to version 23 URL: https://github.com/apache/hbase-thirdparty/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (HBASE-24214) Update Apache POM to version 23 for hbase-thirdparty
Jan Hentschel created HBASE-24214: - Summary: Update Apache POM to version 23 for hbase-thirdparty Key: HBASE-24214 URL: https://issues.apache.org/jira/browse/HBASE-24214 Project: HBase Issue Type: Task Components: thirdparty Reporter: Jan Hentschel Assignee: Jan Hentschel Version 23 for the Apache parent POM has been released. We should update the hbase-thirdparty to use this one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-24214) Update Apache POM to version 23 for hbase-thirdparty
[ https://issues.apache.org/jira/browse/HBASE-24214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24214 started by Jan Hentschel. - > Update Apache POM to version 23 for hbase-thirdparty > > > Key: HBASE-24214 > URL: https://issues.apache.org/jira/browse/HBASE-24214 > Project: HBase > Issue Type: Task > Components: thirdparty >Reporter: Jan Hentschel >Assignee: Jan Hentschel >Priority: Minor > > Version 23 for the Apache parent POM has been released. We should update the > hbase-thirdparty to use this one. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24166) Duplicate implementation for acquireLock between CreateTableProcedure and its parent class
[
https://issues.apache.org/jira/browse/HBASE-24166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086378#comment-17086378
]
Hudson commented on HBASE-24166:
Results for branch branch-2.3
[build #42 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/42/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/42/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/42/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/42/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/42/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Duplicate implementation for acquireLock between CreateTableProcedure and its
> parent class
> --
>
> Key: HBASE-24166
> URL: https://issues.apache.org/jira/browse/HBASE-24166
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
>Affects Versions: 3.0.0, 2.2.4
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0, 2.3.0, 2.2.5
>
>
> The override method _acquireLock_ in _CreateTableProcedure_ and
> _InitMetaProcedure_ is the same as the implementation in its parent class
> _AbstractStateMachineTableProcedure_. So delete the override method in
> subclass.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24208) Remove RS entry from zk draining servers node after RS been stopped
[ https://issues.apache.org/jira/browse/HBASE-24208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-24208: --- Summary: Remove RS entry from zk draining servers node after RS been stopped (was: Remove RS entry from zk draining servers node while RS getting stopped) > Remove RS entry from zk draining servers node after RS been stopped > --- > > Key: HBASE-24208 > URL: https://issues.apache.org/jira/browse/HBASE-24208 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Major > Fix For: 3.0.0, 2.3.1, 2.2.5 > > > When a RS is been decommissioned, we will add an entry into the zk node. This > will be there unless the same RS instance is recommissioned. > But if we want to scale down a cluster, the best path would be to > decommission the RSs in the scaling down nodes. The regions in these RSs > will get moved to live RSs. In this case these decommissioned RSs will get > stopped later. These will never get recommissioned. The zk nodes will still > be there under draining servers path. > We can remove this zk node when the RS is getting stopped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24208) Remove RS entry from zk draining servers node while RS getting stopped
[ https://issues.apache.org/jira/browse/HBASE-24208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-24208: --- Fix Version/s: 2.2.5 2.3.1 3.0.0 > Remove RS entry from zk draining servers node while RS getting stopped > -- > > Key: HBASE-24208 > URL: https://issues.apache.org/jira/browse/HBASE-24208 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Major > Fix For: 3.0.0, 2.3.1, 2.2.5 > > > When a RS is been decommissioned, we will add an entry into the zk node. This > will be there unless the same RS instance is recommissioned. > But if we want to scale down a cluster, the best path would be to > decommission the RSs in the scaling down nodes. The regions in these RSs > will get moved to live RSs. In this case these decommissioned RSs will get > stopped later. These will never get recommissioned. The zk nodes will still > be there under draining servers path. > We can remove this zk node when the RS is getting stopped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24208) Remove RS entry from zk draining servers node while RS getting stopped
[ https://issues.apache.org/jira/browse/HBASE-24208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086358#comment-17086358 ] Anoop Sam John commented on HBASE-24208: Saying about removing the zk node when this decommissioned (drained) RS is been stopped. When it is restarted anyways it wont be the same old instance. The servername will be different as the start time part of it will be different at least. The ZK node is required to be maintained as long as this RS is still around in the cluster. So once that is removed from cluster (to be precise we should call it RS instance) the zk node is of no use really. > Remove RS entry from zk draining servers node while RS getting stopped > -- > > Key: HBASE-24208 > URL: https://issues.apache.org/jira/browse/HBASE-24208 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Major > > When a RS is been decommissioned, we will add an entry into the zk node. This > will be there unless the same RS instance is recommissioned. > But if we want to scale down a cluster, the best path would be to > decommission the RSs in the scaling down nodes. The regions in these RSs > will get moved to live RSs. In this case these decommissioned RSs will get > stopped later. These will never get recommissioned. The zk nodes will still > be there under draining servers path. > We can remove this zk node when the RS is getting stopped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24208) Remove RS entry from zk draining servers node while RS getting stopped
[ https://issues.apache.org/jira/browse/HBASE-24208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086339#comment-17086339 ] Mingliang Liu commented on HBASE-24208: --- Just curious, if we remove the ZK node, after the drained RS and HMaster restart, will the drained status respected? > Remove RS entry from zk draining servers node while RS getting stopped > -- > > Key: HBASE-24208 > URL: https://issues.apache.org/jira/browse/HBASE-24208 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Major > > When a RS is been decommissioned, we will add an entry into the zk node. This > will be there unless the same RS instance is recommissioned. > But if we want to scale down a cluster, the best path would be to > decommission the RSs in the scaling down nodes. The regions in these RSs > will get moved to live RSs. In this case these decommissioned RSs will get > stopped later. These will never get recommissioned. The zk nodes will still > be there under draining servers path. > We can remove this zk node when the RS is getting stopped. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24203) Bump git version in Dockerfile
[
https://issues.apache.org/jira/browse/HBASE-24203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086328#comment-17086328
]
Hudson commented on HBASE-24203:
Results for branch branch-2
[build #2617 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Bump git version in Dockerfile
> --
>
> Key: HBASE-24203
> URL: https://issues.apache.org/jira/browse/HBASE-24203
> Project: HBase
> Issue Type: Bug
> Components: build
>Reporter: Peter Somogyi
>Assignee: Peter Somogyi
>Priority: Blocker
> Fix For: 3.0.0, 2.3.0
>
>
> Nightly build fails when Docker image rebuild is needed on workers.
> Dockerfile has hardcoded version for git but it is not available anymore.
> git=1:2.17.1-1ubuntu0.6
> These versions are available:
> {noformat}
> root@44cf3485b02e:/# apt-cache madison git
>git | 1:2.17.1-1ubuntu0.6 | http://archive.ubuntu.com/ubuntu
> bionic-updates/main amd64 Packages
>git | 1:2.17.1-1ubuntu0.6 | http://security.ubuntu.com/ubuntu
> bionic-security/main amd64 Packages
>git | 1:2.17.0-1ubuntu1 | http://archive.ubuntu.com/ubuntu bionic/main
> amd64 Packages
> {noformat}
> {noformat}
> [2020-04-16T15:31:15.100Z]
>
> [2020-04-16T15:31:15.100Z]
>
> [2020-04-16T15:31:15.100Z]Docker Image Creation
> [2020-04-16T15:31:15.100Z]
>
> [2020-04-16T15:31:15.100Z]
>
> [2020-04-16T15:31:15.100Z]
> [2020-04-16T15:31:15.100Z]
> [2020-04-16T15:31:15.100Z] Sending build context to Docker daemon 18.99kB
> [2020-04-16T15:31:15.815Z] Step 1/60 : FROM ubuntu:18.04 AS BASE_IMAGE
> [2020-04-16T15:31:16.537Z] 18.04: Pulling from library/ubuntu
> [2020-04-16T15:31:16.537Z] Digest:
> sha256:bec5a2727be7fff3d308193cfde3491f8fba1a2ba392b7546b43a051853a341d
> [2020-04-16T15:31:16.537Z] Status: Downloaded newer image for ubuntu:18.04
> [2020-04-16T15:31:16.537Z] ---> 4e5021d210f6
> [2020-04-16T15:31:16.537Z] Step 2/60 : SHELL ["/bin/bash", "-o", "pipefail",
> "-c"]
> [2020-04-16T15:31:16.537Z] ---> Using cache
> [2020-04-16T15:31:16.537Z] ---> 1d47e8973913
> [2020-04-16T15:31:16.537Z] Step 3/60 : RUN DEBIAN_FRONTEND=noninteractive
> apt-get -qq update && DEBIAN_FRONTEND=noninteractive apt-get -qq install
> --no-install-recommends -y ca-certificates=20180409
> curl=7.58.0-2ubuntu3.8 locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2
> build-essential=12.4ubuntu1 diffutils=1:3.6-1
> git=1:2.17.1-1ubuntu0.5 rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1
> wget=1.19.4-1ubuntu2.2 bats=0.4.0-1.1 libperl-critic-perl=1.130-1
> python3=3.6.7-1~18.04 python3-pip=9.0.1-2.3~ubuntu1.18.04.1
> python3-setuptools=39.0.1-2 ruby=1:2.5.1 ruby-dev=1:2.5.1
> shellcheck=0.4.6-1 && apt-get clean && rm -rf /var/lib/apt/lists/*
> [2020-04-16T15:31:19.732Z] ---> Running in a130e4f222ae
> [2020-04-16T15:31:27.852Z] E: Version '1:2.17.1-1ubuntu0.5' for 'git' was not
> found
> [2020-04-16T15:31:28.566Z] The command '/bin/bash -o pipefail -c
> DEBIAN_FRONTEND=noninteractive apt-get -qq update &&
> DEBIAN_FRONTEND=noninteractive apt-get -qq install --no-install-recommends -y
> ca-certificates=20180409 curl=7.58.0-2ubuntu3.8
> locales=2.27-3ubuntu1 bash=4.4.18-2ubuntu1.2
> build-essential=12.4ubuntu1 diffutils=1:3.6-1 git=1:2.17.1-1ubuntu0.5
> rsync=3.1.2-2.1ubuntu1 tar=1.29b-2ubuntu0.1
> wget=1.19.4-1ubuntu2.2
[jira] [Commented] (HBASE-24143) [JDK11] Switch default garbage collector from CMS
[
https://issues.apache.org/jira/browse/HBASE-24143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086327#comment-17086327
]
Hudson commented on HBASE-24143:
Results for branch branch-2
[build #2617 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2617/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [JDK11] Switch default garbage collector from CMS
> -
>
> Key: HBASE-24143
> URL: https://issues.apache.org/jira/browse/HBASE-24143
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
>
> When running HBase tools on the cli, one of the warnings generated is
> {noformat}
> OpenJDK 64-Bit Server VM warning: Option UseConcMarkSweepGC was deprecated in
> version 9.0 and will likely be removed in a future release.
> {noformat}
> Java9+ use G1GC as the default collector. Maybe we simply omit GC
> configurations and use the default settings? Or someone has some suggested
> settings we can ship out of the box?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on issue #1485: HBASE-23969 Meta browser should show all `info` columns
Apache-HBase commented on issue #1485: HBASE-23969 Meta browser should show all `info` columns URL: https://github.com/apache/hbase/pull/1485#issuecomment-615577124 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 40s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 11s | master passed | | +1 :green_heart: | compile | 1m 27s | master passed | | +1 :green_heart: | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 8s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 1s | the patch passed | | +1 :green_heart: | compile | 1m 25s | the patch passed | | +1 :green_heart: | javac | 1m 25s | the patch passed | | +1 :green_heart: | shadedjars | 5m 30s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 59s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 3s | hbase-client in the patch passed. | | -1 :x: | unit | 191m 25s | hbase-server in the patch failed. | | | | 221m 49s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1485/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1485 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d2cd8c32191a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 2c8d104d71 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1485/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1485/4/testReport/ | | Max. process+thread count | 3881 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1485/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[ https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan updated HBASE-24174: -- Fix Version/s: 2.2.5 2.3.0 > Fix findbugs warning on ServiceAuthorizationManager > --- > > Key: HBASE-24174 > URL: https://issues.apache.org/jira/browse/HBASE-24174 > Project: HBase > Issue Type: Bug >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5 > > > Inconsistent synchronization of > org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time. > It is introduced by HBASE-24121, let me fix it. It haven't got released yet. > Looks affect branch-1 so far. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24174) Fix findbugs warning on ServiceAuthorizationManager
[ https://issues.apache.org/jira/browse/HBASE-24174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-24174. --- Hadoop Flags: Reviewed Resolution: Fixed > Fix findbugs warning on ServiceAuthorizationManager > --- > > Key: HBASE-24174 > URL: https://issues.apache.org/jira/browse/HBASE-24174 > Project: HBase > Issue Type: Bug >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > Fix For: 3.0.0, 2.3.0, 1.7.0, 1.4.14, 2.2.5 > > > Inconsistent synchronization of > org.apache.hadoop.hbase.ipc.RpcServer.authManager; locked 66% of time. > It is introduced by HBASE-24121, let me fix it. It haven't got released yet. > Looks affect branch-1 so far. -- This message was sent by Atlassian Jira (v8.3.4#803005)
