[GitHub] [hbase] bsglz commented on pull request #1337: HBASE-24038 Add a metric to show the locality of ssd in table.jsp
bsglz commented on pull request #1337: URL: https://github.com/apache/hbase/pull/1337#issuecomment-638122516 @wchevreuil Sorry for the delay, since it remove the checkbox and use tabs in latest version, i add a new tab named Localities, including two metrics Locality and LocalityForSsd. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
infraio commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434471121
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java
##
@@ -302,30 +283,28 @@ public void testConvert() {
HBaseProtos.RegionInfo info = HBaseProtos.RegionInfo.newBuilder()
.setTableName(HBaseProtos.TableName.newBuilder()
.setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier()))
-
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace()))
-.build())
+
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace())).build())
.setStartKey(UnsafeByteOperations.unsafeWrap(startKey))
- .setEndKey(UnsafeByteOperations.unsafeWrap(endKey))
- .setSplit(split)
- .setRegionId(regionId)
+
.setEndKey(UnsafeByteOperations.unsafeWrap(endKey)).setSplit(split).setRegionId(regionId)
.build();
convertedRi = ProtobufUtil.toRegionInfo(info);
-RegionInfo expectedRi = RegionInfoBuilder.newBuilder(tableName)
-.setStartKey(startKey)
-.setEndKey(endKey)
-.setSplit(split)
-.setRegionId(regionId)
-.setReplicaId(0).build();
+RegionInfo expectedRi =
RegionInfoBuilder.newBuilder(tableName).setStartKey(startKey)
+
.setEndKey(endKey).setSplit(split).setRegionId(regionId).setReplicaId(0).build();
assertEquals(expectedRi, convertedRi);
}
- // Duplicated method in TestRegionInfoDisplay too.
- private HRegionInfo convert(RegionInfo ri) {
-HRegionInfo hri = new HRegionInfo(
-ri.getTable(), ri.getStartKey(), ri.getEndKey(), ri.isSplit(),
ri.getRegionId());
-hri.setOffline(ri.isOffline());
-return hri;
+ @Test
+ public void testNewBuilderWithRegionInfo() {
+RegionInfo ri = RegionInfoBuilder.newBuilder(name.getTableName()).build();
+RegionInfo ri2 = RegionInfoBuilder.newBuilder(ri).build();
+assertEquals(ri, ri2);
+
+// make sure that the region name and encoded name are changed, see
HBASE-24500 for more
+// details.
Review comment:
As you said on the issue desc, set different startkey or endkey?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638106437 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 25s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 10s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 47s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 2s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 38s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 124m 52s | hbase-server in the patch passed. | | | | 151m 33s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1743 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 7e4dc54c893a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/testReport/ | | Max. process+thread count | 3981 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC
[ https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124834#comment-17124834 ] Anoop Sam John commented on HBASE-23296: The way we can introduce that can be this way (I believe that is what mostly the patch is doing). 1. We can have a combined cache as that of today - No change. There will be on heap LRU cache for which size is defined as % of Xmx. Then there can be Bucket Cache on either offheap or file. Here all index and bloom goes to on heap cache and data goes to bucket cache. 2. Allow 2 tier in Bucket Cache itself. I would recommend not using the term L1 and L2 here (even in configs) so that it is clear what it does. The tier 1 can be off heap (will be mostly) and tier 2 will be file based. Now if this is configured, nothing will go to the on heap cache. In fact user should be able to config the on heap block cache size % as 0. Even if configured a value, there is no usage. We at least need to log that very clearly. And here the index and bloom will go to tier 1 and data to tier 2. I believe right now if we have block cache % as 0, we will not even create the bucket cache. The RS can not have a bucket cache alone thing. This we need to change in code. This 2 types might be enough for this jira. But I would like to see a 3rd type where the tiered Bucket cache can be configured as L1, L2 way. (Like what we have in 1.x with CombinedCache) The tier 1 will become L1 and tier 2 will be L2 cache for all types of blocks. > Add CompositeBucketCache to support tiered BC > - > > Key: HBASE-23296 > URL: https://issues.apache.org/jira/browse/HBASE-23296 > Project: HBase > Issue Type: New Feature > Components: BlockCache >Reporter: chenxu >Assignee: chenxu >Priority: Major > > LruBlockCache is not suitable in the following scenarios: > (1) cache size too large (will take too much heap memory, and > evictBlocksByHfileName is not so efficient, as HBASE-23277 mentioned) > (2) block evicted frequently, especially cacheOnWrite & prefetchOnOpen are > enabled. > Since block‘s data is reclaimed by GC, this may affect GC performance. > So how about enabling a Bucket based L1 Cache. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache9 commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434450351
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3355,8 +3354,10 @@ public static String
toLockJson(List lockedRes
if (proto.hasOffline()) {
rib.setOffline(proto.getOffline());
}
-if (proto.hasRegionEncodedName()) {
- rib.setEncodedName(proto.getRegionEncodedName());
+org.apache.hadoop.hbase.client.RegionInfo ri = rib.build();
+if (proto.hasRegionEncodedName() &&
!proto.getRegionEncodedName().equals(ri.getEncodedName())) {
+ LOG.warn("The converted region info is {}, but the encoded name in proto
is {}", ri,
Review comment:
The proto could be recevied from network so there is no guarantee that
this will not happen?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache9 commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434450669
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java
##
@@ -302,30 +283,28 @@ public void testConvert() {
HBaseProtos.RegionInfo info = HBaseProtos.RegionInfo.newBuilder()
.setTableName(HBaseProtos.TableName.newBuilder()
.setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier()))
-
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace()))
-.build())
+
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace())).build())
.setStartKey(UnsafeByteOperations.unsafeWrap(startKey))
- .setEndKey(UnsafeByteOperations.unsafeWrap(endKey))
- .setSplit(split)
- .setRegionId(regionId)
+
.setEndKey(UnsafeByteOperations.unsafeWrap(endKey)).setSplit(split).setRegionId(regionId)
.build();
convertedRi = ProtobufUtil.toRegionInfo(info);
-RegionInfo expectedRi = RegionInfoBuilder.newBuilder(tableName)
-.setStartKey(startKey)
-.setEndKey(endKey)
-.setSplit(split)
-.setRegionId(regionId)
-.setReplicaId(0).build();
+RegionInfo expectedRi =
RegionInfoBuilder.newBuilder(tableName).setStartKey(startKey)
+
.setEndKey(endKey).setSplit(split).setRegionId(regionId).setReplicaId(0).build();
assertEquals(expectedRi, convertedRi);
}
- // Duplicated method in TestRegionInfoDisplay too.
- private HRegionInfo convert(RegionInfo ri) {
-HRegionInfo hri = new HRegionInfo(
-ri.getTable(), ri.getStartKey(), ri.getEndKey(), ri.isSplit(),
ri.getRegionId());
-hri.setOffline(ri.isOffline());
-return hri;
+ @Test
+ public void testNewBuilderWithRegionInfo() {
+RegionInfo ri = RegionInfoBuilder.newBuilder(name.getTableName()).build();
+RegionInfo ri2 = RegionInfoBuilder.newBuilder(ri).build();
+assertEquals(ri, ri2);
+
+// make sure that the region name and encoded name are changed, see
HBASE-24500 for more
+// details.
Review comment:
For example? I think this is enough?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped
Apache-HBase commented on pull request #1841: URL: https://github.com/apache/hbase/pull/1841#issuecomment-638091249 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 59s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 22s | the patch passed | | -0 :warning: | checkstyle | 1m 2s | hbase-server: The patch generated 4 new + 13 unchanged - 0 fixed = 17 total (was 13) | | -0 :warning: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | hadoopcheck | 11m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 47s | the patch passed | ||| _ Other Tests _ | | -1 :x: | asflicense | 0m 14s | The patch generated 1 ASF License warnings. | | | | 35m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1841 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux dc43a77632e1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8de8c44029 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | whitespace | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-general-check/output/whitespace-eol.txt | | asflicense | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1841/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638083491 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 57s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 21s | master passed | | +1 :green_heart: | compile | 1m 23s | master passed | | +1 :green_heart: | shadedjars | 7m 31s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 53s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 23s | the patch passed | | +1 :green_heart: | compile | 1m 32s | the patch passed | | +1 :green_heart: | javac | 1m 32s | the patch passed | | +1 :green_heart: | shadedjars | 7m 26s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 196m 26s | hbase-server in the patch passed. | | | | 230m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1764 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux a42a89874e4c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/testReport/ | | Max. process+thread count | 3547 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache-HBase commented on pull request #1840: URL: https://github.com/apache/hbase/pull/1840#issuecomment-638076577 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 0s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 24s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | checkstyle | 1m 44s | master passed | | +1 :green_heart: | spotbugs | 3m 26s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 45s | the patch passed | | +1 :green_heart: | checkstyle | 0m 35s | hbase-client: The patch generated 0 new + 189 unchanged - 4 fixed = 189 total (was 193) | | +1 :green_heart: | checkstyle | 1m 19s | hbase-server: The patch generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 13m 28s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 50s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 43m 51s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1840 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux efacabf56557 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 8de8c44029 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1840/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] infraio commented on a change in pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
infraio commented on a change in pull request #1840:
URL: https://github.com/apache/hbase/pull/1840#discussion_r434428788
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java
##
@@ -3355,8 +3354,10 @@ public static String
toLockJson(List lockedRes
if (proto.hasOffline()) {
rib.setOffline(proto.getOffline());
}
-if (proto.hasRegionEncodedName()) {
- rib.setEncodedName(proto.getRegionEncodedName());
+org.apache.hadoop.hbase.client.RegionInfo ri = rib.build();
+if (proto.hasRegionEncodedName() &&
!proto.getRegionEncodedName().equals(ri.getEncodedName())) {
+ LOG.warn("The converted region info is {}, but the encoded name in proto
is {}", ri,
Review comment:
When this happen?
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java
##
@@ -115,14 +109,18 @@ public RegionInfoBuilder setOffline(boolean offLine) {
return this;
}
+ /**
+ * @deprecated Since 2.3.0, will be removed in 4.0.0. Calling this method
will have no effect as
+ * the encoded name will be generated by region name.
+ */
+ @Deprecated
Review comment:
This marked as IA.Private. Can remove this directly?
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionInfoBuilder.java
##
@@ -302,30 +283,28 @@ public void testConvert() {
HBaseProtos.RegionInfo info = HBaseProtos.RegionInfo.newBuilder()
.setTableName(HBaseProtos.TableName.newBuilder()
.setQualifier(UnsafeByteOperations.unsafeWrap(tableName.getQualifier()))
-
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace()))
-.build())
+
.setNamespace(UnsafeByteOperations.unsafeWrap(tableName.getNamespace())).build())
.setStartKey(UnsafeByteOperations.unsafeWrap(startKey))
- .setEndKey(UnsafeByteOperations.unsafeWrap(endKey))
- .setSplit(split)
- .setRegionId(regionId)
+
.setEndKey(UnsafeByteOperations.unsafeWrap(endKey)).setSplit(split).setRegionId(regionId)
.build();
convertedRi = ProtobufUtil.toRegionInfo(info);
-RegionInfo expectedRi = RegionInfoBuilder.newBuilder(tableName)
-.setStartKey(startKey)
-.setEndKey(endKey)
-.setSplit(split)
-.setRegionId(regionId)
-.setReplicaId(0).build();
+RegionInfo expectedRi =
RegionInfoBuilder.newBuilder(tableName).setStartKey(startKey)
+
.setEndKey(endKey).setSplit(split).setRegionId(regionId).setReplicaId(0).build();
assertEquals(expectedRi, convertedRi);
}
- // Duplicated method in TestRegionInfoDisplay too.
- private HRegionInfo convert(RegionInfo ri) {
-HRegionInfo hri = new HRegionInfo(
-ri.getTable(), ri.getStartKey(), ri.getEndKey(), ri.isSplit(),
ri.getRegionId());
-hri.setOffline(ri.isOffline());
-return hri;
+ @Test
+ public void testNewBuilderWithRegionInfo() {
+RegionInfo ri = RegionInfoBuilder.newBuilder(name.getTableName()).build();
+RegionInfo ri2 = RegionInfoBuilder.newBuilder(ri).build();
+assertEquals(ri, ri2);
+
+// make sure that the region name and encoded name are changed, see
HBASE-24500 for more
+// details.
Review comment:
Add more test case?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638074898 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 25s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 3m 38s | master passed | | +1 :green_heart: | shadedjars | 5m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 40s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 26s | the patch passed | | +1 :green_heart: | compile | 3m 35s | the patch passed | | +1 :green_heart: | javac | 3m 35s | the patch passed | | +1 :green_heart: | shadedjars | 5m 32s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 2m 33s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 1s | hbase-client in the patch passed. | | -1 :x: | unit | 144m 56s | hbase-server in the patch failed. | | +1 :green_heart: | unit | 13m 21s | hbase-mapreduce in the patch passed. | | +1 :green_heart: | unit | 4m 55s | hbase-thrift in the patch passed. | | +1 :green_heart: | unit | 7m 29s | hbase-shell in the patch passed. | | +1 :green_heart: | unit | 1m 11s | hbase-it in the patch passed. | | +1 :green_heart: | unit | 3m 24s | hbase-rest in the patch passed. | | | | 211m 58s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1830 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ef7dfc7aa1cf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/testReport/ | | Max. process+thread count | 5566 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] gkanade opened a new pull request #1841: HBASE-24208 Remove RS entry from zk draining servers node after RS been stopped
gkanade opened a new pull request #1841: URL: https://github.com/apache/hbase/pull/1841 removed RS entry from zk draining server znode on RS stopped This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-21406:
-
Fix Version/s: 2.4.0
> "status 'replication'" should not show SINK if the cluster does not act as
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5
>Reporter: Daisuke Kobayashi
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
> Attachments: HBASE-21406-branch-1.001.patch,
> HBASE-21406-master.001.patch, HBASE-21406-master.002.patch, Screen Shot
> 2018-10-31 at 18.12.54.png
>
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on
> source always dumps SINK with meaningless metrics. It only makes sense when
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-21406) "status 'replication'" should not show SINK if the cluster does not act as sink
[
https://issues.apache.org/jira/browse/HBASE-21406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wellington Chevreuil updated HBASE-21406:
-
Affects Version/s: 2.4.0
2.3.0
2.2.5
> "status 'replication'" should not show SINK if the cluster does not act as
> sink
> ---
>
> Key: HBASE-21406
> URL: https://issues.apache.org/jira/browse/HBASE-21406
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5
>Reporter: Daisuke Kobayashi
>Assignee: Wellington Chevreuil
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
> Attachments: HBASE-21406-branch-1.001.patch,
> HBASE-21406-master.001.patch, HBASE-21406-master.002.patch, Screen Shot
> 2018-10-31 at 18.12.54.png
>
>
> When replicating in 1 way, from source to target, {{status 'replication'}} on
> source always dumps SINK with meaningless metrics. It only makes sense when
> running the command on target cluster.
> {{status 'replication'}} on source, for example. {{AgeOfLastAppliedOp}} is
> always zero and {{TimeStampsOfLastAppliedOp}} does not get updated from the
> time the RS started since it's not acting as sink.
> {noformat}
> source-1.com
>SOURCE: PeerID=1, AgeOfLastShippedOp=0, SizeOfLogQueue=0,
> TimeStampsOfLastShippedOp=Mon Oct 29 23:44:14 PDT 2018, Replication Lag=0
>SINK : AgeOfLastAppliedOp=0, TimeStampsOfLastAppliedOp=Thu Oct 25
> 23:56:53 PDT 2018
> {noformat}
> {{status 'replication'}} on target works as expected. SOURCE is empty as it's
> not acting as source:
> {noformat}
> target-1.com
>SOURCE:
>SINK : AgeOfLastAppliedOp=70, TimeStampsOfLastAppliedOp=Mon Oct 29
> 23:44:08 PDT 2018
> {noformat}
> This is because {{getReplicationLoadSink}}, called in {{admin.rb}}, always
> returns a value (not null).
> 1.X
> https://github.com/apache/hbase/blob/rel/1.4.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L194-L204
> 2.X
> https://github.com/apache/hbase/blob/rel/2.0.0/hbase-client/src/main/java/org/apache/hadoop/hbase/ServerLoad.java#L392-L399
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.
virajjasani commented on a change in pull request #1839:
URL: https://github.com/apache/hbase/pull/1839#discussion_r434406124
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3521,20 +3522,33 @@ private void getProcedureResult(long procId,
CompletableFuture future, int
return failedFuture(e);
}
CompletableFuture future = new CompletableFuture<>();
-addListener(ConnectionFactory.createAsyncConnection(peerConf), (conn, err)
-> {
+CompletableFuture cf =
ConnectionFactory.createAsyncConnection(peerConf);
+addListener(cf, (conn, err) -> {
if (err != null) {
-future.completeExceptionally(err);
+try {
+ future.completeExceptionally(err);
+} finally {
+ IOUtils.closeQuietly(conn);
Review comment:
Something similar to this might help avoid closing conn at each step:
```
.
CompletableFuture future = new CompletableFuture<>();
CompletableFuture asyncConnection =
ConnectionFactory.createAsyncConnection(peerConf);
addListener(asyncConnection, (conn, err) -> {
future.whenComplete((resp, error) -> {
try {
Closeables.close(conn, true);
} catch (IOException e) {
throw new AssertionError("IOException should not be thrown for
swallowIOException=true");
}
});
if (err != null) {
future.completeExceptionally(err);
return;
}
.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Fix Version/s: 2.2.6 2.3.0 3.0.0-alpha-1 > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.6 > > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 opened a new pull request #1840: HBASE-24500 The behavior of RegionInfoBuilder.newBuilder(RegionInfo) …
Apache9 opened a new pull request #1840: URL: https://github.com/apache/hbase/pull/1840 …is strange This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz edited a comment on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…
bsglz edited a comment on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help to review it if you have time, Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bsglz commented on pull request #1737: HBASE-24382 Flush partial stores of region filtered by seqId when arc…
bsglz commented on pull request #1737: URL: https://github.com/apache/hbase/pull/1737#issuecomment-638046560 @saintstack @Apache9 Help review if you have time, Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-638046066 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 51s | master passed | | +1 :green_heart: | checkstyle | 1m 6s | master passed | | +1 :green_heart: | spotbugs | 2m 3s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | checkstyle | 1m 11s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 47s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 14s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 12s | The patch does not generate ASF License warnings. | | | | 34m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1743 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 48be4a7be5d3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/7/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] virajjasani commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.
virajjasani commented on a change in pull request #1839:
URL: https://github.com/apache/hbase/pull/1839#discussion_r434395602
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3521,20 +3522,33 @@ private void getProcedureResult(long procId,
CompletableFuture future, int
return failedFuture(e);
}
CompletableFuture future = new CompletableFuture<>();
-addListener(ConnectionFactory.createAsyncConnection(peerConf), (conn, err)
-> {
+CompletableFuture cf =
ConnectionFactory.createAsyncConnection(peerConf);
+addListener(cf, (conn, err) -> {
if (err != null) {
-future.completeExceptionally(err);
+try {
+ future.completeExceptionally(err);
+} finally {
+ IOUtils.closeQuietly(conn);
Review comment:
+1 for the above suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-638043811 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 29s | master passed | | +1 :green_heart: | compile | 0m 53s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 24s | the patch passed | | +1 :green_heart: | compile | 0m 54s | the patch passed | | +1 :green_heart: | javac | 0m 54s | the patch passed | | +1 :green_heart: | shadedjars | 5m 33s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 134m 52s | hbase-server in the patch passed. | | | | 158m 25s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1764 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 42a1211dd8d4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/testReport/ | | Max. process+thread count | 4933 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124743#comment-17124743 ] Viraj Jasani commented on HBASE-24492: -- Let's wait for [~stack]'s confirmation. So far, pushed to master and branch-2. Thanks for the quick review [~zhangduo]. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani merged pull request #1831: HBASE-24492 : Remove infinite loop from ProtobufLogReader#readNext
virajjasani merged pull request #1831: URL: https://github.com/apache/hbase/pull/1831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…
ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r434376478
##
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import org.apache.hadoop.hbase.metrics.BaseSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+@InterfaceAudience.Private
+public interface MetricsStoreAggregateSource extends BaseSource {
+ /**
+ * The name of the metrics
+ */
+ String METRICS_NAME = "Stores";
+
+ /**
+ * The name of the metrics context that metrics will be under.
+ */
+ String METRICS_CONTEXT = "regionserver";
+
+ /**
+ * Description
+ */
+ String METRICS_DESCRIPTION = "Metrics about Stores under a region";
+
+ /**
+ * The name of the metrics context that metrics will be under in jmx
+ */
+ String METRICS_JMX_CONTEXT = "RegionServer,sub=" + METRICS_NAME;
Review comment:
And seeing ur other comment - this is where yo uwill get per region
under each store I have how many requests. If I want to remove this then I may
have to do something like how it has been done for Table vs Store - we will
have region vs store (and it will be at the region level only).
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tab of Base Stats not actived by default in table.jsp
Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-638023212 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 35s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 7s | master passed | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | the patch passed | | +1 :green_heart: | javadoc | 0m 35s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 208m 16s | hbase-server in the patch passed. | | | | 220m 46s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1837 | | Optional Tests | javac javadoc unit | | uname | Linux 84b63edab85a 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/testReport/ | | Max. process+thread count | 3296 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ramkrish86 commented on a change in pull request #1552: HBASE-24205 Create metric to know the number of reads that happens fr…
ramkrish86 commented on a change in pull request #1552:
URL: https://github.com/apache/hbase/pull/1552#discussion_r434369134
##
File path:
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsStoreAggregateSource.java
##
@@ -0,0 +1,60 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import org.apache.hadoop.hbase.metrics.BaseSource;
+import org.apache.yetus.audience.InterfaceAudience;
+
+
+@InterfaceAudience.Private
+public interface MetricsStoreAggregateSource extends BaseSource {
+ /**
+ * The name of the metrics
+ */
+ String METRICS_NAME = "Stores";
+
+ /**
+ * The name of the metrics context that metrics will be under.
+ */
+ String METRICS_CONTEXT = "regionserver";
+
+ /**
+ * Description
+ */
+ String METRICS_DESCRIPTION = "Metrics about Stores under a region";
+
+ /**
+ * The name of the metrics context that metrics will be under in jmx
+ */
+ String METRICS_JMX_CONTEXT = "RegionServer,sub=" + METRICS_NAME;
Review comment:
I was just trying to push all the store level metric per region under
this. that is why collected it under RegionServer.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-23296) Add CompositeBucketCache to support tiered BC
[
https://issues.apache.org/jira/browse/HBASE-23296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124700#comment-17124700
]
Guanghao Zhang commented on HBASE-23296:
{quote}Do you mean BucketCache with heap ioEngine? seems this is not supported
now. If use LruBlockCache there may be some gc problems.
{quote}
I mean LruBlockCache. For combined cache, now we only support two tired cache,
let's call it L1 and L2 cache. Now L1 cache must be on heap. And L2 cache may
be offheap, file or others. Introduce a offheap L1 cache is good idea.
> Add CompositeBucketCache to support tiered BC
> -
>
> Key: HBASE-23296
> URL: https://issues.apache.org/jira/browse/HBASE-23296
> Project: HBase
> Issue Type: New Feature
> Components: BlockCache
>Reporter: chenxu
>Assignee: chenxu
>Priority: Major
>
> LruBlockCache is not suitable in the following scenarios:
> (1) cache size too large (will take too much heap memory, and
> evictBlocksByHfileName is not so efficient, as HBASE-23277 mentioned)
> (2) block evicted frequently, especially cacheOnWrite & prefetchOnOpen are
> enabled.
> Since block‘s data is reclaimed by GC, this may affect GC performance.
> So how about enabling a Bucket based L1 Cache.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24347) Hadoop2 profiles are both active when pre-commit PR builds run
[
https://issues.apache.org/jira/browse/HBASE-24347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124709#comment-17124709
]
Guanghao Zhang commented on HBASE-24347:
{quote}I think much of the CI refactoring I did to support JDK11 didn't go back
to branch-2.2 since it wasn't to be supported there. I think that would be the
primary reason for differences.
{quote}
Got it. Thanks for explanation.
> Hadoop2 profiles are both active when pre-commit PR builds run
> --
>
> Key: HBASE-24347
> URL: https://issues.apache.org/jira/browse/HBASE-24347
> Project: HBase
> Issue Type: Sub-task
> Components: build
>Reporter: Michael Stack
>Assignee: Josh Elser
>Priority: Major
> Fix For: 2.3.0, 2.4.0, 2.2.6
>
> Attachments: HBASE-24280.001.branch-2.3.patch,
> HBASE-24280.001.branch-2.patch
>
>
> We need the magic done in the parent out in our precommit builds too. See how
> https://github.com/apache/hbase/pull/1664 fails in hbase-rest w/ complaint
> about jersey; this is a symptom of double hadoop2+hadoop3 profile activation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-24500: - Assignee: Duo Zhang > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work started] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24500 started by Duo Zhang. - > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Critical > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Priority: Critical (was: Major) > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task >Reporter: Duo Zhang >Priority: Critical > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
Duo Zhang created HBASE-24500: - Summary: The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange Key: HBASE-24500 URL: https://issues.apache.org/jira/browse/HBASE-24500 Project: HBase Issue Type: Task Reporter: Duo Zhang In this method, we will copy all the fields, including RegionName and EncodedRegionName of the RegionInfo, so after we changed some other fields like start key or stop key or replica id, and then create a new RegionInfo, the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124695#comment-17124695 ] Viraj Jasani commented on HBASE-24492: -- Thanks [~zhangduo] Exactly the loop is useless and confusing for readers. When I came here, I started searching for howmany times this could loop, ran some tests and then suddenly realized, this is not at all looping. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24500) The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange
[ https://issues.apache.org/jira/browse/HBASE-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24500: -- Component/s: read replicas Client > The behavior of RegionInfoBuilder.newBuilder(RegionInfo) is strange > --- > > Key: HBASE-24500 > URL: https://issues.apache.org/jira/browse/HBASE-24500 > Project: HBase > Issue Type: Task > Components: Client, read replicas >Reporter: Duo Zhang >Priority: Critical > > In this method, we will copy all the fields, including RegionName and > EncodedRegionName of the RegionInfo, so after we changed some other fields > like start key or stop key or replica id, and then create a new RegionInfo, > the RegionName of the RegionInfo will not be regenerated and cause problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-24492: -- Component/s: wal Replication > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task > Components: Replication, wal >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124691#comment-17124691 ] Duo Zhang commented on HBASE-24492: --- OK, checked the code, there is a 'return true' at the last of the while(true) loop, and there is no continue statement in the middle, so I agree with you that the loop is useless. +1 on removing it. [~stack] I think this could go into all 2.x branches? Just a code clean. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on pull request #1830: HBASE-24491 Remove HRegionInfo
Apache9 commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-638006266 The failed UT is caused by a serious problem of our RegionInfo related API. Let me open a new issue for fixing it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124667#comment-17124667 ] Viraj Jasani edited comment on HBASE-24492 at 6/3/20, 7:09 AM: --- [~zhangduo] The issue is not visible at production level. This is a code improvement I would say. I was going through WAL specific code and stumbled upon ProtobufLogReader.readNext and realized that while(true) is a confusing for any reader. If you look at the code closely, there is no loop happening at all. And I am fine with keeping this in master and branch-2. was (Author: vjasani): [~zhangduo] The issue is not visible at production level. This is a code improvement I would say. I was going through WAL specific code and stumbled upon ProtobufLogReader.readNext and realized that while(true) is a confusing for any reader. If you look at the code closely, there is no loop happening at all. And I am fine with keeping this till branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124667#comment-17124667 ] Viraj Jasani commented on HBASE-24492: -- [~zhangduo] The issue is not visible at production level. This is a code improvement I would say. I was going through WAL specific code and stumbled upon ProtobufLogReader.readNext and realized that while(true) is a confusing for any reader. If you look at the code closely, there is no loop happening at all. And I am fine with keeping this till branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124664#comment-17124664 ] Duo Zhang commented on HBASE-24492: --- Do you hit this in real production? Or can you reproduce the problem through a UT? Otherwise I do not think it is necessary to do this right now? Thanks. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #1839: HBASE-24497: Close one off connections in RawSyncHBaseAdmin.
Apache9 commented on a change in pull request #1839:
URL: https://github.com/apache/hbase/pull/1839#discussion_r434343419
##
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java
##
@@ -3521,20 +3522,33 @@ private void getProcedureResult(long procId,
CompletableFuture future, int
return failedFuture(e);
}
CompletableFuture future = new CompletableFuture<>();
-addListener(ConnectionFactory.createAsyncConnection(peerConf), (conn, err)
-> {
+CompletableFuture cf =
ConnectionFactory.createAsyncConnection(peerConf);
+addListener(cf, (conn, err) -> {
if (err != null) {
-future.completeExceptionally(err);
+try {
+ future.completeExceptionally(err);
+} finally {
+ IOUtils.closeQuietly(conn);
Review comment:
This method has been deprecated IIRC? Can use Closeables.close instead.
And maybe we could just call addListener on the above 'future', to close the
AsyncConnection? Then we do not need to add close code everwhere.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on pull request #1838: HBASE-24498: Include jetty-schemas so that xml parsing does not need …
Apache9 commented on pull request #1838: URL: https://github.com/apache/hbase/pull/1838#issuecomment-637992660 It will be good if we do not need to go to sun/oracle urls. Mind explaining a bit about how adding a dependency could solve the problem? And seems the build is failing? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1830: HBASE-24491 Remove HRegionInfo
Apache-HBase commented on pull request #1830: URL: https://github.com/apache/hbase/pull/1830#issuecomment-637991532 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 2s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | checkstyle | 3m 38s | master passed | | +1 :green_heart: | spotbugs | 5m 41s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 28s | the patch passed | | +1 :green_heart: | checkstyle | 0m 31s | hbase-client: The patch generated 0 new + 179 unchanged - 58 fixed = 179 total (was 237) | | -0 :warning: | checkstyle | 1m 17s | hbase-server: The patch generated 1 new + 761 unchanged - 34 fixed = 762 total (was 795) | | +1 :green_heart: | checkstyle | 0m 19s | hbase-mapreduce: The patch generated 0 new + 31 unchanged - 2 fixed = 31 total (was 33) | | +1 :green_heart: | checkstyle | 0m 57s | The patch passed checkstyle in hbase-thrift | | +1 :green_heart: | checkstyle | 0m 10s | The patch passed checkstyle in hbase-shell | | +1 :green_heart: | checkstyle | 0m 17s | The patch passed checkstyle in hbase-it | | +1 :green_heart: | checkstyle | 0m 17s | hbase-rest: The patch generated 0 new + 1 unchanged - 2 fixed = 1 total (was 3) | | -0 :warning: | rubocop | 0m 13s | The patch generated 2 new + 166 unchanged - 1 fixed = 168 total (was 167) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 38s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 8m 27s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 1m 29s | The patch does not generate ASF License warnings. | | | | 54m 8s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1830 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle rubocop | | uname | Linux b85dcf58638e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | rubocop | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-client hbase-server hbase-mapreduce hbase-thrift hbase-shell hbase-it hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1830/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 rubocop=0.80.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24456) Immutable Scan as unmodifiable subclass or wrapper of Scan
[ https://issues.apache.org/jira/browse/HBASE-24456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124644#comment-17124644 ] Viraj Jasani commented on HBASE-24456: -- [~ndimiduk] ACK and agree on keeping it till branch-2. > Immutable Scan as unmodifiable subclass or wrapper of Scan > -- > > Key: HBASE-24456 > URL: https://issues.apache.org/jira/browse/HBASE-24456 > Project: HBase > Issue Type: Improvement >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > We should provide an ImmutableScan as subclass or wrapper of Scan which can > be used specifically by Coprocessors as read only Scan. This suggestion came > up while reviewing HBASE-24321 by multiple reviewers: > [https://github.com/apache/hbase/pull/1655] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24496) The tab of Base Stats not actived by default in table.jsp
[ https://issues.apache.org/jira/browse/HBASE-24496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zheng Wang updated HBASE-24496: --- Summary: The tab of Base Stats not actived by default in table.jsp (was: The tag of Base Stats not actived by default in table.jsp) > The tab of Base Stats not actived by default in table.jsp > - > > Key: HBASE-24496 > URL: https://issues.apache.org/jira/browse/HBASE-24496 > Project: HBase > Issue Type: Bug > Components: UI >Affects Versions: 3.0.0-alpha-1 >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > > This bug was introduced by HBASE-21404, it expect to resovle the active issue > of nav bar, but impact other areas. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out
[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang resolved HBASE-24467. Resolution: Fixed Merged to branch-2.2. Thanks [~zhangduo] [~stack] for reviewing. > Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete > timing out > > > Key: HBASE-24467 > URL: https://issues.apache.org/jira/browse/HBASE-24467 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.5 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24467) Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete timing out
[ https://issues.apache.org/jira/browse/HBASE-24467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guanghao Zhang updated HBASE-24467: --- Fix Version/s: 2.2.6 > Backport HBASE-23963: Split TestFromClientSide; it takes too long to complete > timing out > > > Key: HBASE-24467 > URL: https://issues.apache.org/jira/browse/HBASE-24467 > Project: HBase > Issue Type: Improvement >Affects Versions: 2.2.5 >Reporter: Guanghao Zhang >Assignee: Guanghao Zhang >Priority: Major > Fix For: 2.2.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] infraio merged pull request #1805: HBASE-24467 Backport HBASE-23963: Split TestFromClientSide; it takes …
infraio merged pull request #1805: URL: https://github.com/apache/hbase/pull/1805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1837: HBASE-24496 The tag of Base Stats not actived by default in table.jsp
Apache-HBase commented on pull request #1837: URL: https://github.com/apache/hbase/pull/1837#issuecomment-637983439 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 28s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 20s | master passed | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 4s | the patch passed | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 126m 34s | hbase-server in the patch passed. | | | | 139m 56s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1837 | | Optional Tests | javac javadoc unit | | uname | Linux 7b1479d8f819 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/testReport/ | | Max. process+thread count | 4379 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1837/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124640#comment-17124640 ] Viraj Jasani commented on HBASE-24499: -- [~rvaleti] ACK. Agree, this should be configurable. > Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to > 5) > > > Key: HBASE-24499 > URL: https://issues.apache.org/jira/browse/HBASE-24499 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.3.2 >Reporter: Ravi Kishore Valeti >Assignee: Ravi Kishore Valeti >Priority: Minor > Fix For: 2.3.0, master, 1.7.0 > > > The no.of retries for Sasl handshake is hardcoded to 5 (MAX_ATTEMPTS). Use > cases which have strict SLAs on their operation timeouts need this to be > configurable to meet their SLAs. > Sample Scenario: > * RS is slow in accepting connections but is slow in responding to requests. > * Client makes a Sasl Connection attempt but times out on read (can be > configurable via hbase.ipc.client.socket.timeout.read) and retries 5 times at > this time (this is not configurable) and eventually bails out. > Make this configurable by a new client property (say > *hbase.security.relogin.maxretries)* so that clients/usecases can override > and meet their timeout SLAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24499: - Fix Version/s: (was: 1.3.7) 1.7.0 > Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to > 5) > > > Key: HBASE-24499 > URL: https://issues.apache.org/jira/browse/HBASE-24499 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.3.2 >Reporter: Ravi Kishore Valeti >Assignee: Ravi Kishore Valeti >Priority: Minor > Fix For: 2.3.0, master, 1.7.0 > > > The no.of retries for Sasl handshake is hardcoded to 5 (MAX_ATTEMPTS). Use > cases which have strict SLAs on their operation timeouts need this to be > configurable to meet their SLAs. > Sample Scenario: > * RS is slow in accepting connections but is slow in responding to requests. > * Client makes a Sasl Connection attempt but times out on read (can be > configurable via hbase.ipc.client.socket.timeout.read) and retries 5 times at > this time (this is not configurable) and eventually bails out. > Make this configurable by a new client property (say > *hbase.security.relogin.maxretries)* so that clients/usecases can override > and meet their timeout SLAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1764: HBASE-24420 Avoid Meaningless Retry Attempts in Unrecoverable Failure
Apache-HBase commented on pull request #1764: URL: https://github.com/apache/hbase/pull/1764#issuecomment-637980870 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | checkstyle | 1m 5s | master passed | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | -0 :warning: | checkstyle | 1m 5s | hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 2s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 7s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 20s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1764 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 4ac659462ccc 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1764/5/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24492) ProtobufLogReader.readNext does not need looping
[ https://issues.apache.org/jira/browse/HBASE-24492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124619#comment-17124619 ] Viraj Jasani edited comment on HBASE-24492 at 6/3/20, 6:17 AM: --- [~stack] sure I am definitely fine with restricting this till branch-2. Moreover, the major reason behind removal of while is: The method is single pass execution. I was going through WAL split code and reached here and realized this while loop seems confusing to readers, and it's not looping at all. Tried some tests locally to confirm. But most importantly, if we look at the entire method, the code is surrounded by mostly try/cache and some if/else, for each branching, either we are returning boolean value or we are throwing Exception. I could not find a single point from where we are looping. was (Author: vjasani): [~stack] sure I am definitely fine with restricting this till branch-2. > ProtobufLogReader.readNext does not need looping > > > Key: HBASE-24492 > URL: https://issues.apache.org/jira/browse/HBASE-24492 > Project: HBase > Issue Type: Task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.4.0 > > > ProtobufLogReader.readNext is using infinite while loop for the whole method, > however it returns value or throws errors in single execution. while(true) > was part of initial code and with better improvements in the method, this > loop has not been removed yet. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637979510 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 41s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 35s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 39s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 0m 53s | the patch passed | | +1 :green_heart: | javac | 0m 53s | the patch passed | | +1 :green_heart: | shadedjars | 5m 29s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 34s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 135m 28s | hbase-server in the patch failed. | | | | 159m 22s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1791 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 2f03ebdea3bc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/testReport/ | | Max. process+thread count | 4669 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24499) Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to 5)
[ https://issues.apache.org/jira/browse/HBASE-24499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124636#comment-17124636 ] Ravi Kishore Valeti commented on HBASE-24499: - [~vjasani] [~apurt...@yahoo.com]. > Use a client property for SaslConnection MAX_ATTEMPTS (currently hardcoded to > 5) > > > Key: HBASE-24499 > URL: https://issues.apache.org/jira/browse/HBASE-24499 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 1.3.2 >Reporter: Ravi Kishore Valeti >Assignee: Ravi Kishore Valeti >Priority: Minor > Fix For: 2.3.0, master, 1.3.7 > > > The no.of retries for Sasl handshake is hardcoded to 5 (MAX_ATTEMPTS). Use > cases which have strict SLAs on their operation timeouts need this to be > configurable to meet their SLAs. > Sample Scenario: > * RS is slow in accepting connections but is slow in responding to requests. > * Client makes a Sasl Connection attempt but times out on read (can be > configurable via hbase.ipc.client.socket.timeout.read) and retries 5 times at > this time (this is not configurable) and eventually bails out. > Make this configurable by a new client property (say > *hbase.security.relogin.maxretries)* so that clients/usecases can override > and meet their timeout SLAs. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1791: HBASE-23202 ExportSnapshot (import) will fail if copying files to roo…
Apache-HBase commented on pull request #1791: URL: https://github.com/apache/hbase/pull/1791#issuecomment-637976835 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 27s | master passed | | +1 :green_heart: | compile | 1m 6s | master passed | | +1 :green_heart: | shadedjars | 5m 54s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | the patch passed | | +1 :green_heart: | compile | 1m 4s | the patch passed | | +1 :green_heart: | javac | 1m 4s | the patch passed | | +1 :green_heart: | shadedjars | 5m 53s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 126m 1s | hbase-server in the patch passed. | | | | 152m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1791 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 999780d57651 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/testReport/ | | Max. process+thread count | 4426 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1791/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637975698 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 45s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 57s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 48s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 54s | the patch passed | | +1 :green_heart: | compile | 1m 9s | the patch passed | | +1 :green_heart: | javac | 1m 9s | the patch passed | | +1 :green_heart: | shadedjars | 7m 27s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 46s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 10m 18s | hbase-server in the patch failed. | | | | 40m 55s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1743 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 069ec6b46ae1 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/testReport/ | | Max. process+thread count | 558 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1743: HBASE-24403 FsDelegationToken Should Cache Token After Acquired A New One
Apache-HBase commented on pull request #1743: URL: https://github.com/apache/hbase/pull/1743#issuecomment-637975313 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 21s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 49s | master passed | | +1 :green_heart: | compile | 1m 14s | master passed | | +1 :green_heart: | shadedjars | 6m 40s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 48s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 46s | the patch passed | | +1 :green_heart: | compile | 1m 19s | the patch passed | | +1 :green_heart: | javac | 1m 19s | the patch passed | | +1 :green_heart: | shadedjars | 6m 40s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 44s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 10m 13s | hbase-server in the patch failed. | | | | 39m 50s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1743 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 5c379e29c976 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / f71f1cdfa0 | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/testReport/ | | Max. process+thread count | 417 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1743/6/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
