[GitHub] [hbase] Apache9 commented on pull request #4531: [HBASE-27116]fix the ruby issue which cause disable all table failure

[GitBox]

Apache9 commented on PR #4531:
URL: https://github.com/apache/hbase/pull/4531#issuecomment-1196301093

   @busbey Mind taking a look at this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on pull request #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…

[GitBox]

Apache9 commented on PR #4652:
URL: https://github.com/apache/hbase/pull/4652#issuecomment-1196299575

   @apurtell FYI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (HBASE-25983) javadoc generation fails on openjdk-11.0.11+9

[Duo Zhang (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571745#comment-17571745
 ] 

Duo Zhang commented on HBASE-25983:
---

This is a behavior change between the javadoc command of jdk8 and jdk11, where 
the source errors will not be ignored by default in jdk11's javadoc command. We 
need to manually pass --ignore-source-errors option to the javadoc command. 
Let's prepare a PR for fixing this.

> javadoc generation fails on openjdk-11.0.11+9
> -
>
> Key: HBASE-25983
> URL: https://issues.apache.org/jira/browse/HBASE-25983
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.4.3
> Environment: maven - 3.5.4 and 3.6.2
> java - openjdk 11.0.11+9
> centos6
> hbase - 2.4.3
>Reporter: Bryan Beaudreault
>Priority: Major
>
> I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running 
> is as follows:
> {code:java}
> JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/  mvn 
> -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2 
> -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25 
> -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests 
> -Dcheckstyle.skip=true site{code}
> I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above, 
> jdk11.0.11+9.
> {{The error is as follows:}}
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on 
> project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork 
> report:
>  [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in 
> the packages
>  [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations
>  [ERROR] are planned to be removed in a future JDK release. These
>  [ERROR] components have been superseded by the new APIs in 
> jdk.javadoc.doclet.
>  [ERROR] Users are strongly recommended to migrate to the new APIs.
>  [ERROR] javadoc: error - invalid flag: -author
>  [ERROR]
>  [ERROR] Command line was: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G 
> @options @packages
>  [ERROR]
>  [ERROR] Refer to the generated Javadoc files in 
> '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir.
>  [ERROR] -> [Help 1]
>  [ERROR]
>  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
>  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>  [ERROR]
>  [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
>  [ERROR] [Help 1]{code}
> I believe this is due to the yetus doclet 
> org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet. 
> Commenting this doclet out from the userapi and testuserapi reportSets in 
> pom.xml fixes the build.
>  
>  I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very 
> old. I tried updating to 0.13.0, but that did not help. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (HBASE-25983) javadoc generation fails on openjdk-11.0.11+9

[Duo Zhang (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang reassigned HBASE-25983:
-

Assignee: Duo Zhang

> javadoc generation fails on openjdk-11.0.11+9
> -
>
> Key: HBASE-25983
> URL: https://issues.apache.org/jira/browse/HBASE-25983
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.4.3
> Environment: maven - 3.5.4 and 3.6.2
> java - openjdk 11.0.11+9
> centos6
> hbase - 2.4.3
>Reporter: Bryan Beaudreault
>Assignee: Duo Zhang
>Priority: Major
>
> I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running 
> is as follows:
> {code:java}
> JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/  mvn 
> -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2 
> -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25 
> -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests 
> -Dcheckstyle.skip=true site{code}
> I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above, 
> jdk11.0.11+9.
> {{The error is as follows:}}
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on 
> project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork 
> report:
>  [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in 
> the packages
>  [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations
>  [ERROR] are planned to be removed in a future JDK release. These
>  [ERROR] components have been superseded by the new APIs in 
> jdk.javadoc.doclet.
>  [ERROR] Users are strongly recommended to migrate to the new APIs.
>  [ERROR] javadoc: error - invalid flag: -author
>  [ERROR]
>  [ERROR] Command line was: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G 
> @options @packages
>  [ERROR]
>  [ERROR] Refer to the generated Javadoc files in 
> '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir.
>  [ERROR] -> [Help 1]
>  [ERROR]
>  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
>  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>  [ERROR]
>  [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
>  [ERROR] [Help 1]{code}
> I believe this is due to the yetus doclet 
> org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet. 
> Commenting this doclet out from the userapi and testuserapi reportSets in 
> pom.xml fixes the build.
>  
>  I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very 
> old. I tried updating to 0.13.0, but that did not help. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work started] (HBASE-25983) javadoc generation fails on openjdk-11.0.11+9

[Duo Zhang (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-25983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on HBASE-25983 started by Duo Zhang.
-
> javadoc generation fails on openjdk-11.0.11+9
> -
>
> Key: HBASE-25983
> URL: https://issues.apache.org/jira/browse/HBASE-25983
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.4.3
> Environment: maven - 3.5.4 and 3.6.2
> java - openjdk 11.0.11+9
> centos6
> hbase - 2.4.3
>Reporter: Bryan Beaudreault
>Assignee: Duo Zhang
>Priority: Major
>
> I'm trying to build javadoc for HBase 2.4.3 on jdk11. The command I'm running 
> is as follows:
> {code:java}
> JAVA_HOME=/usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/  mvn 
> -Phadoop-3.0 -Phadoop.profile=3.0 -Dhadoop-three.version=3.2.2 
> -Dhadoop.guava.version=27.0-jre -Dslf4j.version=1.7.25 
> -Djetty.version=9.3.29.v20201019 -Dzookeeper.version=3.5.7 -DskipTests 
> -Dcheckstyle.skip=true site{code}
> I've tried this with maven 3.5.4 and 3.6.2. Based on JAVA_HOME above, 
> jdk11.0.11+9.
> {{The error is as follows:}}
> {code:java}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-site-plugin:3.7.1:site (default-site) on 
> project hbase: Error generating maven-javadoc-plugin:3.2.0:aggregate-no-fork 
> report:
>  [ERROR] Exit code: 1 - javadoc: warning - The old Doclet and Taglet APIs in 
> the packages
>  [ERROR] com.sun.javadoc, com.sun.tools.doclets and their implementations
>  [ERROR] are planned to be removed in a future JDK release. These
>  [ERROR] components have been superseded by the new APIs in 
> jdk.javadoc.doclet.
>  [ERROR] Users are strongly recommended to migrate to the new APIs.
>  [ERROR] javadoc: error - invalid flag: -author
>  [ERROR]
>  [ERROR] Command line was: 
> /usr/lib/jvm/java-11-openjdk-11.0.11.0.9-2.el8_4.x86_64/bin/javadoc -J-Xmx2G 
> @options @packages
>  [ERROR]
>  [ERROR] Refer to the generated Javadoc files in 
> '/hbase/rpm/build/BUILD/hbase-2.4.3/target/site/apidocs' dir.
>  [ERROR] -> [Help 1]
>  [ERROR]
>  [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
>  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>  [ERROR]
>  [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
>  [ERROR] [Help 1]{code}
> I believe this is due to the yetus doclet 
> org.apache.yetus.audience.tools.IncludePublicAnnotationsStandardDoclet. 
> Commenting this doclet out from the userapi and testuserapi reportSets in 
> pom.xml fixes the build.
>  
>  I noticed hbase 2.4.3 depends on audience-annotations 0.5.0, which is very 
> old. I tried updating to 0.13.0, but that did not help. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] alexdongli0829 opened a new pull request, #4656: [HBASE-27245]Expose the archive API to the end user

[GitBox]

alexdongli0829 opened a new pull request, #4656:
URL: https://github.com/apache/hbase/pull/4656

   https://issues.apache.org/jira/browse/HBASE-27245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (HBASE-27225) Add BucketAllocator bucket size statistic logging

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571743#comment-17571743
 ] 

Hudson commented on HBASE-27225:


Results for branch branch-2
[build #602 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add BucketAllocator bucket size statistic logging
> -
>
> Key: HBASE-27225
> URL: https://issues.apache.org/jira/browse/HBASE-27225
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> BucketCache places blocks into configurably sized buckets based on the block 
> size. The default sizes aim to provide broad coverage for common block sizes, 
> but should probably be tuned for certain use-cases. However, we provide no 
> way for operators to gain insight into the distribution of buckets.
> There already exists a BucketAllocator#logStatistics method, but it is not 
> called anywhere. I suggest that we hook that up in BucketCache#logStats 
> (which is called periodically by a stats thread). We can go from there.
> Looking at the IndexStatistics used in that method, it looks like a good 
> start. One thing I'd like to add is a count of freeBuckets and 
> completelyFreeBuckets per index. I think this will be useful for indicating 
> how much more wiggle room we have for redistributing buckets among the 
> various block sizes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27235) Clean up error-prone findings in hbase-hadoop-compat

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571742#comment-17571742
 ] 

Hudson commented on HBASE-27235:


Results for branch branch-2
[build #602 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Clean up error-prone findings in hbase-hadoop-compat
> 
>
> Key: HBASE-27235
> URL: https://issues.apache.org/jira/browse/HBASE-27235
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27222) Purge FutureReturnValueIgnored warnings from error prone

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571744#comment-17571744
 ] 

Hudson commented on HBASE-27222:


Results for branch branch-2
[build #602 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/602/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Purge FutureReturnValueIgnored warnings from error prone
> 
>
> Key: HBASE-27222
> URL: https://issues.apache.org/jira/browse/HBASE-27222
> Project: HBase
>  Issue Type: Improvement
>  Components: netty
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> We used to introduce a FutureUtils to purge the FutureReturnValueIgnored 
> warnings in the async client implementation, to make sure we catch the 
> exception from the callback.
> For netty, we could apply the same trick. And there is another problem for 
> netty that channel.write and some other methods will also return a 
> ChannelFuture but usually we just do nothing on it, this will generated a 
> FutureReturnValueIgnored warning too. We could add a logging listener to log 
> the errors if any.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] alexdongli0829 closed pull request #4655: [HBASE-27245]Expose the archive API to the end user

[GitBox]

alexdongli0829 closed pull request #4655: [HBASE-27245]Expose the archive API 
to the end user
URL: https://github.com/apache/hbase/pull/4655


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4655: [HBASE-27245]Expose the archive API to the end user

[GitBox]

Apache-HBase commented on PR #4655:
URL: https://github.com/apache/hbase/pull/4655#issuecomment-1196279093

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 11s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 28s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 23s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 49s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 37s |  master passed  |
   | -0 :warning: |  patch  |   6m 13s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 12s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 29s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 29s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   2m 48s |  patch has 212 errors when building our 
shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 35s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 11s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  |   0m 30s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   1m 56s |  hbase-testing-util in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 22s |  hbase-thrift in the patch passed.  
|
   | +1 :green_heart: |  unit  |   6m 52s |  hbase-shell in the patch passed.  |
   |  |   |  38m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4655 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux f4e1244ebd24 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/testReport/
 |
   | Max. process+thread count | 1891 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server 
hbase-testing-util hbase-thrift hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4655: [HBASE-27245]Expose the archive API to the end user

[GitBox]

Apache-HBase commented on PR #4655:
URL: https://github.com/apache/hbase/pull/4655#issuecomment-1196279035

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 12s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 42s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 50s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  master passed  |
   | -0 :warning: |  patch  |   6m  0s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m 13s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 29s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 29s |  hbase-server in the patch failed.  |
   | -1 :x: |  shadedjars  |   2m 45s |  patch has 212 errors when building our 
shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 31s |  hbase-protocol-shaded in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   1m 20s |  hbase-client in the patch passed.  
|
   | -1 :x: |  unit  |   0m 29s |  hbase-server in the patch failed.  |
   | +1 :green_heart: |  unit  |   1m 45s |  hbase-testing-util in the patch 
passed.  |
   | +1 :green_heart: |  unit  |   6m 27s |  hbase-thrift in the patch passed.  
|
   | +1 :green_heart: |  unit  |   7m 32s |  hbase-shell in the patch passed.  |
   |  |   |  38m 36s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4655 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 8fc76776cefc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/testReport/
 |
   | Max. process+thread count | 2006 (vs. ulimit of 3) |
   | modules | C: hbase-protocol-shaded hbase-client hbase-server 
hbase-testing-util hbase-thrift hbase-shell U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4655: [HBASE-27245]Expose the archive API to the end user

[GitBox]

Apache-HBase commented on PR #4655:
URL: https://github.com/apache/hbase/pull/4655#issuecomment-1196277331

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 20s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 41s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 42s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   5m 40s |  master passed  |
   | -0 :warning: |  patch  |   1m 14s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m  2s |  root in the patch failed.  |
   | -1 :x: |  compile  |   1m  2s |  hbase-server in the patch failed.  |
   | -0 :warning: |  cc  |   1m  2s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 33s |  hbase-client generated 1 new + 31 
unchanged - 0 fixed = 32 total (was 31)  |
   | -0 :warning: |  javac  |   1m  2s |  hbase-server in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 11s |  hbase-client: The patch 
generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)  |
   | -0 :warning: |  checkstyle  |   0m 17s |  The patch fails to run 
checkstyle in hbase-server  |
   | -0 :warning: |  rubocop  |   0m 12s |  The patch generated 5 new + 407 
unchanged - 0 fixed = 412 total (was 407)  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch has 4 line(s) that end 
in whitespace. Use git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply  |
   | -1 :x: |  hadoopcheck  |   1m 15s |  The patch causes 212 errors with 
Hadoop v3.1.2.  |
   | -1 :x: |  hadoopcheck  |   2m 29s |  The patch causes 212 errors with 
Hadoop v3.2.2.  |
   | -1 :x: |  hadoopcheck  |   3m 41s |  The patch causes 212 errors with 
Hadoop v3.3.1.  |
   | -1 :x: |  hbaseprotoc  |   0m 20s |  hbase-server in the patch failed.  |
   | -1 :x: |  spotless  |   0m 14s |  patch has 67 errors when running 
spotless:check, run spotless:apply to fix.  |
   | -1 :x: |  spotbugs  |   0m 17s |  hbase-server in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 36s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  35m  8s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4655 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux bf1018775ca1 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | cc | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt
 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4655/1/artifact/yetus-general-check/output/buildtool-p

[jira] [Commented] (HBASE-27239) Upgrade reload4j due to XXE vulnerability

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571735#comment-17571735
 ] 

Hudson commented on HBASE-27239:


Results for branch branch-2.4
[build #396 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Upgrade reload4j due to XXE vulnerability
> -
>
> Key: HBASE-27239
> URL: https://issues.apache.org/jira/browse/HBASE-27239
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 2.4.13
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.4.14
>
>
> https://github.com/qos-ch/reload4j/issues/53 fixed in reload4j 1.2.22



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27225) Add BucketAllocator bucket size statistic logging

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571734#comment-17571734
 ] 

Hudson commented on HBASE-27225:


Results for branch branch-2.4
[build #396 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/396/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add BucketAllocator bucket size statistic logging
> -
>
> Key: HBASE-27225
> URL: https://issues.apache.org/jira/browse/HBASE-27225
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> BucketCache places blocks into configurably sized buckets based on the block 
> size. The default sizes aim to provide broad coverage for common block sizes, 
> but should probably be tuned for certain use-cases. However, we provide no 
> way for operators to gain insight into the distribution of buckets.
> There already exists a BucketAllocator#logStatistics method, but it is not 
> called anywhere. I suggest that we hook that up in BucketCache#logStats 
> (which is called periodically by a stats thread). We can go from there.
> Looking at the IndexStatistics used in that method, it looks like a good 
> start. One thing I'd like to add is a count of freeBuckets and 
> completelyFreeBuckets per index. I think this will be useful for indicating 
> how much more wiggle room we have for redistributing buckets among the 
> various block sizes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache-HBase commented on pull request #4638: HBASE-27224 HFile tool statistic sampling produces misleading results

[GitBox]

Apache-HBase commented on PR #4638:
URL: https://github.com/apache/hbase/pull/4638#issuecomment-1196263168

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 53s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  1s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 59s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 43s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 59s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 58s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 47s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 33s |  hbase-server: The patch 
generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  13m 58s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 50s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 38s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  7s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  41m  1s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/4/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4638 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux f00692c15f69 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/4/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache9 commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930609712


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##
@@ -48,15 +44,15 @@ public RpcRetryingCallerFactory(Configuration conf, 
RetryingCallerInterceptor in
 startLogErrorsCnt = 
conf.getInt(AsyncProcess.START_LOG_ERRORS_AFTER_COUNT_KEY,
   AsyncProcess.DEFAULT_START_LOG_ERRORS_AFTER_COUNT);
 this.interceptor = interceptor;
-enableBackPressure = conf.getBoolean(HConstants.ENABLE_CLIENT_BACKPRESSURE,
-  HConstants.DEFAULT_ENABLE_CLIENT_BACKPRESSURE);
   }
 
   /**
* Set the tracker that should be used for tracking statistics about the 
server
+   * @deprecated Does nothing. Since 2.5.0, will be removed in 4.0.0.

Review Comment:
   This class is IA.Private so we are free to remove it at any time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache9 commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930608998


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1911,7 +1916,13 @@ public void split(final TableName tableName, final 
byte[] splitPoint) throws IOE
 continue;
   }
   // call out to master to do split now
-  splitRegionAsync(r, splitPoint);
+  try {
+splitRegionAsync(r, splitPoint).get();

Review Comment:
   Should be the same with mergeRegions method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache9 commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930608839


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, 
final byte[] nameOfRegi
   @Override
   public void mergeRegions(final byte[] nameOfRegionA, final byte[] 
nameOfRegionB,
 final boolean forcible) throws IOException {
-mergeRegionsAsync(nameOfRegionA, nameOfRegionB, forcible);
+try {

Review Comment:
   IIRC this is a known issue. You can see the comments in the Admin interface.
   
   ```
 /**
  * Merge two regions. Asynchronous operation.
  * @param nameOfRegionA encoded or full name of region a
  * @param nameOfRegionB encoded or full name of region b
  * @param forcible  true if do a compulsory merge, 
otherwise we will only merge
  *  two adjacent regions
  * @throws IOException if a remote or network exception occurs
  * @deprecated Since 2.0. Will be removed in 3.0. Use
  * {@link #mergeRegionsAsync(byte[], byte[], boolean)} instead.
  */
 @Deprecated
 void mergeRegions(byte[] nameOfRegionA, byte[] nameOfRegionB, boolean 
forcible)
   throws IOException;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] alexdongli0829 opened a new pull request, #4655: [HBASE-27245]Expose the archive API to the end user

[GitBox]

alexdongli0829 opened a new pull request, #4655:
URL: https://github.com/apache/hbase/pull/4655

   https://issues.apache.org/jira/browse/HBASE-27245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4653: HBASE-27240 Clean up error-prone findings in hbase-http

[GitBox]

Apache9 commented on code in PR #4653:
URL: https://github.com/apache/hbase/pull/4653#discussion_r930606253


##
hbase-http/src/test/java/org/apache/hadoop/hbase/http/ssl/KeyStoreTestUtil.java:
##
@@ -369,7 +372,7 @@ private static Configuration 
createSSLConfig(SSLFactory.Mode mode, String keysto
* @throws IOException if there is an I/O error saving the file
*/
   public static void saveConfig(File file, Configuration conf) throws 
IOException {
-Writer writer = new FileWriter(file);
+Writer writer = Files.newWriter(file, StandardCharsets.UTF_8);

Review Comment:
   Use try with resource?



##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/log/LogLevel.java:
##
@@ -85,7 +85,7 @@ private static void printUsage() {
   }
 
   public static boolean isValidProtocol(String protocol) {
-return ((protocol.equals(PROTOCOL_HTTP) || 
protocol.equals(PROTOCOL_HTTPS)));
+return (protocol.equals(PROTOCOL_HTTP) || protocol.equals(PROTOCOL_HTTPS));

Review Comment:
   The outer parentheses are still useless?



##
hbase-http/src/main/java/org/apache/hadoop/hbase/http/lib/StaticUserWebFilter.java:
##
@@ -143,8 +146,7 @@ static String getUsernameFromConf(Configuration conf) {
   // since we need to split out the username from the configured UGI.
   LOG.warn(
 DEPRECATED_UGI_KEY + " should not be used. Instead, use " + 
HBASE_HTTP_STATIC_USER + ".");
-  String[] parts = oldStyleUgi.split(",");
-  return parts[0];
+  return Iterators.get(Splitter.on(',').split(oldStyleUgi).iterator(), 0);

Review Comment:
   Iterables.get so we do not need to call iterator explicitly :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] alexdongli0829 closed pull request #4654: [HBASE-27245]Expose archive option to end user

[GitBox]

alexdongli0829 closed pull request #4654: [HBASE-27245]Expose archive option to 
end user
URL: https://github.com/apache/hbase/pull/4654


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4653: HBASE-27240 Clean up error-prone findings in hbase-http

[GitBox]

Apache-HBase commented on PR #4653:
URL: https://github.com/apache/hbase/pull/4653#issuecomment-1196217092

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 58s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  1s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 55s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 54s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 29s |  master passed  |
   | +1 :green_heart: |  spotless  |   1m 21s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 49s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m 38s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 49s |  hbase-http generated 0 new + 1 
unchanged - 21 fixed = 1 total (was 22)  |
   | -0 :warning: |  checkstyle  |   0m 27s |  hbase-http: The patch generated 
1 new + 2 unchanged - 0 fixed = 3 total (was 2)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  18m  3s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   1m 21s |  patch has no errors when 
running spotless:check.  |
   | -1 :x: |  spotbugs  |   1m  2s |  hbase-http generated 2 new + 0 unchanged 
- 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  43m  0s |   |
   
   
   | Reason | Tests |
   |---:|:--|
   | FindBugs | module:hbase-http |
   |  |  Impossible cast from 
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter to 
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$User in 
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$User.equals(Object)  At 
StaticUserWebFilter.java:org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$User
 in org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$User.equals(Object)  
At StaticUserWebFilter.java:[line 79] |
   |  |  
org.apache.hadoop.hbase.http.lib.StaticUserWebFilter$User.equals(Object) checks 
for operand being a StaticUserWebFilter  At StaticUserWebFilter.java:a 
StaticUserWebFilter  At StaticUserWebFilter.java:[line 76] |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4653 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux b7ae7dfda418 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | checkstyle | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-http.txt
 |
   | spotbugs | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/artifact/yetus-general-check/output/new-spotbugs-hbase-http.html
 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-http U: hbase-http |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4654: [HBASE-27245]Expose archive option to end user

[GitBox]

Apache-HBase commented on PR #4654:
URL: https://github.com/apache/hbase/pull/4654#issuecomment-1196215324

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 47s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  prototool  |   0m  0s |  prototool was not available.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 14s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  master passed  |
   | +1 :green_heart: |  compile  |   6m  0s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 53s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 57s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   7m 51s |  master passed  |
   | -0 :warning: |  patch  |   1m 49s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   1m  1s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 18s |  hbase-client in the patch failed.  |
   | -1 :x: |  compile  |   0m 28s |  hbase-server in the patch failed.  |
   | -1 :x: |  compile  |   0m 15s |  hbase-testing-util in the patch failed.  |
   | -1 :x: |  compile  |   0m 23s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  cc  |   0m 18s |  hbase-client in the patch failed.  |
   | -0 :warning: |  cc  |   0m 28s |  hbase-server in the patch failed.  |
   | -0 :warning: |  cc  |   0m 15s |  hbase-testing-util in the patch failed.  
|
   | -0 :warning: |  cc  |   0m 23s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javac  |   0m 18s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javac  |   0m 28s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 15s |  hbase-testing-util in the patch 
failed.  |
   | -0 :warning: |  javac  |   0m 23s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  checkstyle  |   0m 13s |  hbase-client: The patch 
generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4)  |
   | -0 :warning: |  checkstyle  |   0m 32s |  hbase-server: The patch 
generated 14 new + 7 unchanged - 0 fixed = 21 total (was 7)  |
   | -0 :warning: |  rubocop  |   0m 17s |  The patch generated 5 new + 407 
unchanged - 0 fixed = 412 total (was 407)  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch has 2 line(s) that end 
in whitespace. Use git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply  |
   | -1 :x: |  hadoopcheck  |   0m 49s |  The patch causes 14 errors with 
Hadoop v3.1.2.  |
   | -1 :x: |  hadoopcheck  |   1m 44s |  The patch causes 14 errors with 
Hadoop v3.2.2.  |
   | -1 :x: |  hadoopcheck  |   2m 42s |  The patch causes 14 errors with 
Hadoop v3.3.1.  |
   | -1 :x: |  hbaseprotoc  |   0m 15s |  hbase-client in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 29s |  hbase-server in the patch failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 13s |  hbase-testing-util in the patch 
failed.  |
   | -1 :x: |  hbaseprotoc  |   0m 19s |  hbase-thrift in the patch failed.  |
   | -1 :x: |  spotless  |   0m 17s |  patch has 66 errors when running 
spotless:check, run spotless:apply to fix.  |
   | -1 :x: |  spotbugs  |   0m 14s |  hbase-client in the patch failed.  |
   | -1 :x: |  spotbugs  |   0m 24s |  hbase-server in the patch failed.  |
   | -1 :x: |  spotbugs  |   0m 14s |  hbase-testing-util in the patch failed.  
|
   | -1 :x: |  spotbugs  |   0m 16s |  hbase-thrift in the patch failed.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 43s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  39m  5s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4654 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile cc hbaseprotoc prototool rubocop |
   | uname | Linux d80509a4c35b 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1

[GitHub] [hbase] Apache-HBase commented on pull request #4654: [HBASE-27245]Expose archive option to end user

[GitBox]

Apache-HBase commented on PR #4654:
URL: https://github.com/apache/hbase/pull/4654#issuecomment-1196210772

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 23s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  9s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 36s |  master passed  |
   | -0 :warning: |  patch  |   6m 23s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 50s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 15s |  hbase-client in the patch failed.  |
   | -1 :x: |  compile  |   0m 27s |  hbase-server in the patch failed.  |
   | -1 :x: |  compile  |   0m 13s |  hbase-testing-util in the patch failed.  |
   | -1 :x: |  compile  |   0m 20s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javac  |   0m 15s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javac  |   0m 27s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 13s |  hbase-testing-util in the patch 
failed.  |
   | -0 :warning: |  javac  |   0m 20s |  hbase-thrift in the patch failed.  |
   | -1 :x: |  shadedjars  |   1m 47s |  patch has 14 errors when building our 
shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 34s |  hbase-protocol-shaded in the patch 
passed.  |
   | -1 :x: |  unit  |   0m 14s |  hbase-client in the patch failed.  |
   | -1 :x: |  unit  |   0m 28s |  hbase-server in the patch failed.  |
   | -1 :x: |  unit  |   0m 13s |  hbase-testing-util in the patch failed.  |
   | -1 :x: |  unit  |   0m 21s |  hbase-thrift in the patch failed.  |
   | -1 :x: |  unit  |   7m 31s |  hbase-shell in the patch failed.  |
   |  |   |  29m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4654 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux e39538af321a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-testing-util.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-client.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-testing-util.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-thrift.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
 |
   | uni

[GitHub] [hbase] Apache-HBase commented on pull request #4654: [HBASE-27245]Expose archive option to end user

[GitBox]

Apache-HBase commented on PR #4654:
URL: https://github.com/apache/hbase/pull/4654#issuecomment-1196209607

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 38s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 21s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 58s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  2s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 20s |  master passed  |
   | -0 :warning: |  patch  |   5m 57s |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m 38s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m 15s |  hbase-client in the patch failed.  |
   | -1 :x: |  compile  |   0m 22s |  hbase-server in the patch failed.  |
   | -1 :x: |  compile  |   0m 12s |  hbase-testing-util in the patch failed.  |
   | -1 :x: |  compile  |   0m 16s |  hbase-thrift in the patch failed.  |
   | -0 :warning: |  javac  |   0m 15s |  hbase-client in the patch failed.  |
   | -0 :warning: |  javac  |   0m 22s |  hbase-server in the patch failed.  |
   | -0 :warning: |  javac  |   0m 12s |  hbase-testing-util in the patch 
failed.  |
   | -0 :warning: |  javac  |   0m 16s |  hbase-thrift in the patch failed.  |
   | -1 :x: |  shadedjars  |   1m 41s |  patch has 14 errors when building our 
shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   1m 18s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 24s |  hbase-protocol-shaded in the patch 
passed.  |
   | -1 :x: |  unit  |   0m 15s |  hbase-client in the patch failed.  |
   | -1 :x: |  unit  |   0m 23s |  hbase-server in the patch failed.  |
   | -1 :x: |  unit  |   0m 12s |  hbase-testing-util in the patch failed.  |
   | -1 :x: |  unit  |   0m 17s |  hbase-thrift in the patch failed.  |
   | -1 :x: |  unit  |   7m 36s |  hbase-shell in the patch failed.  |
   |  |   |  26m 43s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4654 |
   | JIRA Issue | HBASE-27245 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux fecde3e717ee 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | mvninstall | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
 |
   | compile | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-client.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-testing-util.txt
 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-thrift.txt
 |
   | shadedjars | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4654/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt
 |
   | unit | 
ht

[GitHub] [hbase] Apache-HBase commented on pull request #4653: HBASE-27240 Clean up error-prone findings in hbase-http

[GitBox]

Apache-HBase commented on PR #4653:
URL: https://github.com/apache/hbase/pull/4653#issuecomment-1196204723

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 21s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 54s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 15s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 47s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 14s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 43s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 40s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 43s |  hbase-http in the patch passed.  |
   |  |   |  16m 10s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4653 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3c57b426d3e8 5.4.0-96-generic #109-Ubuntu SMP Wed Jan 12 
16:49:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/testReport/
 |
   | Max. process+thread count | 350 (vs. ulimit of 3) |
   | modules | C: hbase-http U: hbase-http |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4653: HBASE-27240 Clean up error-prone findings in hbase-http

[GitBox]

Apache-HBase commented on PR #4653:
URL: https://github.com/apache/hbase/pull/4653#issuecomment-1196204624

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 34s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 11s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 58s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 12s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 16s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 12s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 58s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m  9s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   0m 35s |  hbase-http in the patch passed.  |
   |  |   |  15m 48s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4653 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 20d3794f5e06 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 80b366817e |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/testReport/
 |
   | Max. process+thread count | 252 (vs. ulimit of 3) |
   | modules | C: hbase-http U: hbase-http |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4653/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27245) Expose the archive option to end user

[Dong0829 (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong0829 updated HBASE-27245:
-
Description: 
For the delete table procedure, we already have archive option, but the archive 
now will already be true and not provided to end user.

Actually its valuable to provide this option to the end user because some time, 
customer does not want this table archived when drop the table, it will waste 
the storage and time if hbase keep archive the table. Especially for the users 
who are using AWS s3 or Azure as storage which will take lots time for the 
rename and delete operation for big tables

  was:
For the delete table procedure, we already have archive option, but the archive 
now will already be true and not provided to end user.

Actually its valuable to provide this option to the end user because some time, 
customer does not want this table archived when drop the table, it will waste 
the storage and time if hbase keep archive the table. Especially for the users 
who are using AWS s3 or Azure as storage which will take more time for the 
rename and delete operation


> Expose the archive option to end user
> -
>
> Key: HBASE-27245
> URL: https://issues.apache.org/jira/browse/HBASE-27245
> Project: HBase
>  Issue Type: New Feature
>  Components: master
>Affects Versions: 2.5.0
>Reporter: Dong0829
>Priority: Minor
>
> For the delete table procedure, we already have archive option, but the 
> archive now will already be true and not provided to end user.
> Actually its valuable to provide this option to the end user because some 
> time, customer does not want this table archived when drop the table, it will 
> waste the storage and time if hbase keep archive the table. Especially for 
> the users who are using AWS s3 or Azure as storage which will take lots time 
> for the rename and delete operation for big tables



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] alexdongli0829 opened a new pull request, #4654: [HBASE-27245]Expose archive option to end user

[GitBox]

alexdongli0829 opened a new pull request, #4654:
URL: https://github.com/apache/hbase/pull/4654

   For the issue: https://issues.apache.org/jira/browse/HBASE-27245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27240) Clean up error-prone findings in hbase-http

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27240:

Fix Version/s: 2.5.0
   Status: Patch Available  (was: Open)

> Clean up error-prone findings in hbase-http
> ---
>
> Key: HBASE-27240
> URL: https://issues.apache.org/jira/browse/HBASE-27240
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (HBASE-27245) Expose the archive option to end user

[Dong0829 (Jira)]

Dong0829 created HBASE-27245:


 Summary: Expose the archive option to end user
 Key: HBASE-27245
 URL: https://issues.apache.org/jira/browse/HBASE-27245
 Project: HBase
  Issue Type: New Feature
  Components: master
Affects Versions: 2.5.0
Reporter: Dong0829


For the delete table procedure, we already have archive option, but the archive 
now will already be true and not provided to end user.

Actually its valuable to provide this option to the end user because some time, 
customer does not want this table archived when drop the table, it will waste 
the storage and time if hbase keep archive the table. Especially for the users 
who are using AWS s3 or Azure as storage which will take more time for the 
rename and delete operation



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache-HBase commented on pull request #4638: HBASE-27224 HFile tool statistic sampling produces misleading results

[GitBox]

Apache-HBase commented on PR #4638:
URL: https://github.com/apache/hbase/pull/4638#issuecomment-1196171226

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  5s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  2s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 58s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 47s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 50s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 28s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 48s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 48s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 27s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 218m  9s |  hbase-server in the patch failed.  |
   |  |   | 236m 47s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4638 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 22268db5610a 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/testReport/
 |
   | Max. process+thread count | 2464 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…

[GitBox]

Apache-HBase commented on PR #4652:
URL: https://github.com/apache/hbase/pull/4652#issuecomment-1196167477

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 53s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2.4 Compile Tests _ |
   | +1 :green_heart: |  spotless  |   0m 42s |  branch has no errors when 
running spotless:check.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  shellcheck  |   0m  1s |  There were no new shellcheck 
issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  spotless  |   0m 38s |  patch has no errors when 
running spotless:check.  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  The patch does not generate 
ASF License warnings.  |
   |  |   |   3m 31s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4652 |
   | JIRA Issue | HBASE-27244 |
   | Optional Tests | dupname asflicense spotless shellcheck shelldocs |
   | uname | Linux efaefc945b14 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / 57cba05d09 |
   | Max. process+thread count | 33 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…

[GitBox]

Apache-HBase commented on PR #4652:
URL: https://github.com/apache/hbase/pull/4652#issuecomment-1196167079

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 37s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2.4 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   2m 46s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4652 |
   | JIRA Issue | HBASE-27244 |
   | Optional Tests |  |
   | uname | Linux eb3cf96b973f 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / 57cba05d09 |
   | Max. process+thread count | 42 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…

[GitBox]

Apache-HBase commented on PR #4652:
URL: https://github.com/apache/hbase/pull/4652#issuecomment-1196166747

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 47s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  5s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2.4 Compile Tests _ |
   ||| _ Patch Compile Tests _ |
   ||| _ Other Tests _ |
   |  |   |   1m 56s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4652 |
   | JIRA Issue | HBASE-27244 |
   | Optional Tests |  |
   | uname | Linux f29dddb2529d 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2.4 / 57cba05d09 |
   | Max. process+thread count | 29 (vs. ulimit of 12500) |
   | modules | C: . U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4652/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (HBASE-27185) Rewrite NettyRpcServer to decode rpc request with netty handler

[Duo Zhang (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang resolved HBASE-27185.
---
Fix Version/s: 2.6.0
   3.0.0-alpha-4
 Hadoop Flags: Reviewed
   Resolution: Fixed

Pushed to master and branch-2.

Thanks [~sunxin] for reviewing!

> Rewrite NettyRpcServer to decode rpc request with netty handler
> ---
>
> Key: HBASE-27185
> URL: https://issues.apache.org/jira/browse/HBASE-27185
> Project: HBase
>  Issue Type: Improvement
>  Components: netty, rpc
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> This is a follow on issue of HBASE-26708.
> The memory leaks happens in the saslReadAndProcess method. It does not follow 
> a typical netty style so it is more likely to introduce bugs.
> Since we agree that NettyRpcServer is the future and SimpleRpcServer should 
> be deprecated and finally removed, let's first implement dedicated rpc 
> request decoder for netty.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache-HBase commented on pull request #4638: HBASE-27224 HFile tool statistic sampling produces misleading results

[GitBox]

Apache-HBase commented on PR #4638:
URL: https://github.com/apache/hbase/pull/4638#issuecomment-1196165079

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 36s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 26s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  0s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 14s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 35s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m  3s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 21s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 206m 34s |  hbase-server in the patch failed.  |
   |  |   | 223m 10s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4638 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux bc7b6a1a5f8d 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | unit | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/testReport/
 |
   | Max. process+thread count | 2400 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (HBASE-27185) Rewrite NettyRpcServer to decode rpc request with netty handler

[Duo Zhang (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Duo Zhang reassigned HBASE-27185:
-

Assignee: Duo Zhang

> Rewrite NettyRpcServer to decode rpc request with netty handler
> ---
>
> Key: HBASE-27185
> URL: https://issues.apache.org/jira/browse/HBASE-27185
> Project: HBase
>  Issue Type: Improvement
>  Components: netty, rpc
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
> This is a follow on issue of HBASE-26708.
> The memory leaks happens in the saslReadAndProcess method. It does not follow 
> a typical netty style so it is more likely to introduce bugs.
> Since we agree that NettyRpcServer is the future and SimpleRpcServer should 
> be deprecated and finally removed, let's first implement dedicated rpc 
> request decoder for netty.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] alexdongli0829 opened a new pull request, #4652: [HBASE-27244]Fix the issue legacy log4j issue: https://issues.apache.org/jira/brow…

[GitBox]

alexdongli0829 opened a new pull request, #4652:
URL: https://github.com/apache/hbase/pull/4652

   [HBASE-27244](https://issues.apache.org/jira/browse/HBASE-27244)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache9 commented on a diff in pull request #4647: HBASE-27234 Clean up error-prone warnings in hbase-examples

[GitBox]

Apache9 commented on code in PR #4647:
URL: https://github.com/apache/hbase/pull/4647#discussion_r930533780


##
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:
##
@@ -495,6 +494,21 @@ public static String toString(final byte[] b) {
 return toString(b, 0, b.length);
   }
 
+  /**
+   * Returns String made from b
+   */
+  public static String toString(ByteBuffer buf) {
+if (buf == null) {
+  return null;
+}
+if (!buf.hasArray()) {
+  buf = ByteBuffer.wrap(buf.array(), buf.arrayOffset(), buf.remaining());

Review Comment:
   This is the code in hbase-common. I mean here we should copy the content out 
to a byte array and then call the toString method which accepts byte array.
   
   If `buf.hasArray()` returns false, then how could we call `buf.array()` to 
get its non-existent backing array?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27236) Clean up error-prone findings in hbase-hbtop

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27236:

Hadoop Flags: Reviewed
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

> Clean up error-prone findings in hbase-hbtop
> 
>
> Key: HBASE-27236
> URL: https://issues.apache.org/jira/browse/HBASE-27236
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] apurtell commented on a diff in pull request #4647: HBASE-27234 Clean up error-prone warnings in hbase-examples

[GitBox]

apurtell commented on code in PR #4647:
URL: https://github.com/apache/hbase/pull/4647#discussion_r930530740


##
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:
##
@@ -495,6 +494,21 @@ public static String toString(final byte[] b) {
 return toString(b, 0, b.length);
   }
 
+  /**
+   * Returns String made from b
+   */
+  public static String toString(ByteBuffer buf) {
+if (buf == null) {
+  return null;
+}
+if (!buf.hasArray()) {
+  buf = ByteBuffer.wrap(buf.array(), buf.arrayOffset(), buf.remaining());

Review Comment:
   No. Added this support here in hbase-common. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell merged pull request #4649: HBASE-27236 Clean up error-prone warnings in hbase-hbtop

[GitBox]

apurtell merged PR #4649:
URL: https://github.com/apache/hbase/pull/4649


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27210) Clean up error-prone findings in hbase-endpoint

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27210:

Hadoop Flags: Reviewed
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

> Clean up error-prone findings in hbase-endpoint
> ---
>
> Key: HBASE-27210
> URL: https://issues.apache.org/jira/browse/HBASE-27210
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache9 merged pull request #4624: HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty h…

[GitBox]

Apache9 merged PR #4624:
URL: https://github.com/apache/hbase/pull/4624


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place

[Dong0829 (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571683#comment-17571683
 ] 

Dong0829 commented on HBASE-27244:
--

Yes, I am preparing the PR

> bin/hbase still use slf4j-log4j while reload4j in place
> ---
>
> Key: HBASE-27244
> URL: https://issues.apache.org/jira/browse/HBASE-27244
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.4.13
>Reporter: Dong0829
>Priority: Major
>
> For the bin/hbase file, there are some class path set which will handle the 
> slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but 
> the hbase file not upgrade, for example, if we run mapredcp:
> hbase mapredcp:
> /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar
> Among above, 
> /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should 
> be excluded but as slf4j-log4j before
> This will impact the downstream users 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place

[Duo Zhang (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571682#comment-17571682
 ] 

Duo Zhang commented on HBASE-27244:
---

Mind opening a PR to fix it?

> bin/hbase still use slf4j-log4j while reload4j in place
> ---
>
> Key: HBASE-27244
> URL: https://issues.apache.org/jira/browse/HBASE-27244
> Project: HBase
>  Issue Type: Bug
>  Components: shell
>Affects Versions: 2.4.13
>Reporter: Dong0829
>Priority: Major
>
> For the bin/hbase file, there are some class path set which will handle the 
> slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but 
> the hbase file not upgrade, for example, if we run mapredcp:
> hbase mapredcp:
> /usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar
> Among above, 
> /usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should 
> be excluded but as slf4j-log4j before
> This will impact the downstream users 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (HBASE-27244) bin/hbase still use slf4j-log4j while reload4j in place

[Dong0829 (Jira)]

Dong0829 created HBASE-27244:


 Summary: bin/hbase still use slf4j-log4j while reload4j in place
 Key: HBASE-27244
 URL: https://issues.apache.org/jira/browse/HBASE-27244
 Project: HBase
  Issue Type: Bug
  Components: shell
Affects Versions: 2.4.13
Reporter: Dong0829


For the bin/hbase file, there are some class path set which will handle the 
slf4j-log4j before, but now in hbase branch 2, we upgrade to reload4j, but the 
hbase file not upgrade, for example, if we run mapredcp:

hbase mapredcp:

/usr/lib/hbase/lib/shaded-clients/hbase-shaded-mapreduce-2.4.12.jar:/usr/lib/hbase/lib/client-facing-thirdparty/audience-annotations-0.5.0.jar:/usr/lib/hbase/lib/client-facing-thirdparty/commons-logging-1.2.jar:/usr/lib/hbase/lib/client-facing-thirdparty/htrace-core4-4.2.0-incubating.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jcl-over-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/jul-to-slf4j-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/reload4j-1.2.19.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-api-1.7.33.jar:/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar


Among above, 
/usr/lib/hbase/lib/client-facing-thirdparty/slf4j-reload4j-1.7.33.jar should be 
excluded but as slf4j-log4j before

This will impact the downstream users 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930512690


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1931,7 +1942,13 @@ public void splitRegion(final byte[] regionName, final 
byte[] splitPoint) throws
 if (regionServerPair.getSecond() == null) {
   throw new NoServerForRegionException(Bytes.toStringBinary(regionName));
 }
-splitRegionAsync(regionServerPair.getFirst(), splitPoint);
+try {
+  splitRegionAsync(regionServerPair.getFirst(), splitPoint).get();

Review Comment:
   `splitRegion` will return immediately without waiting for or surfacing any 
exception from the operation. This seems wrong. We don't expect to wait for the 
split to complete but we would expect to surface an IOException from the RPC. 
Yet, it is a semantic change over previously released versions. For discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930512471


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1911,7 +1916,13 @@ public void split(final TableName tableName, final 
byte[] splitPoint) throws IOE
 continue;
   }
   // call out to master to do split now
-  splitRegionAsync(r, splitPoint);
+  try {
+splitRegionAsync(r, splitPoint).get();

Review Comment:
   `split` will return immediately without waiting for or surfacing any 
exception from the operation. This seems wrong. We don't expect to wait for the 
split to complete but we would expect to surface an IOException from the RPC. 
Yet, it is a semantic change over previously released versions. For discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930512250


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, 
final byte[] nameOfRegi
   @Override
   public void mergeRegions(final byte[] nameOfRegionA, final byte[] 
nameOfRegionB,
 final boolean forcible) throws IOException {
-mergeRegionsAsync(nameOfRegionA, nameOfRegionB, forcible);
+try {

Review Comment:
   `mergeRegions` will return immediately without waiting for or surfacing any 
exception from the operation. This seems wrong. We don't expect to wait for the 
master to complete the merge but we would expect to surface an IOException from 
the RPC. Yet, it is a semantic change over previously released versions. For 
discussion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930509784


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java:
##
@@ -94,34 +94,35 @@ private long resultSize2CacheSize(long maxResultSize) {
   public Result next() throws IOException {
 try (Scope ignored = span.makeCurrent()) {
   lock.lock();
-  while (cache.isEmpty()) {
-handleException();
-if (this.closed) {
-  return null;
+  try {
+while (cache.isEmpty()) {
+  handleException();
+  if (this.closed) {
+return null;
+  }
+  try {
+notEmpty.await();
+  } catch (InterruptedException e) {
+span.recordException(e);
+throw new InterruptedIOException("Interrupted when wait to load 
cache");
+  }
 }
-try {
-  notEmpty.await();
-} catch (InterruptedException e) {
-  span.recordException(e);
-  throw new InterruptedIOException("Interrupted when wait to load 
cache");
+Result result = pollCache();
+if (prefetchCondition()) {
+  notFull.signalAll();
 }
+return result;
+  } finally {
+lock.unlock();
+handleException();
   }
-
-  Result result = pollCache();
-  if (prefetchCondition()) {
-notFull.signalAll();
-  }
-  return result;
-} finally {
-  lock.unlock();
-  handleException();
 }
   }
 
   @Override
   public void close() {
+lock.lock();

Review Comment:
   Not a bug like above but still a nit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (HBASE-27203) Clean up error-prone findings in hbase-client

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571679#comment-17571679
 ] 

Andrew Kyle Purtell edited comment on HBASE-27203 at 7/27/22 12:45 AM:
---

As I suspected there are some findings that suggest changes that need a new 
minor. See #4651. /cc [~vjasani] 
(There will be likely be some in hbase-server too, when I finally get there.)


was (Author: apurtell):
As I suspected there are some findings that suggest changes that need a new 
minor. See #4651. /cc [~vjasani] 

> Clean up error-prone findings in hbase-client
> -
>
> Key: HBASE-27203
> URL: https://issues.apache.org/jira/browse/HBASE-27203
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27203) Clean up error-prone findings in hbase-client

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571679#comment-17571679
 ] 

Andrew Kyle Purtell commented on HBASE-27203:
-

As I suspected there are some findings that suggest changes that need a new 
minor. See #4651. /cc [~vjasani] 

> Clean up error-prone findings in hbase-client
> -
>
> Key: HBASE-27203
> URL: https://issues.apache.org/jira/browse/HBASE-27203
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache-HBase commented on pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache-HBase commented on PR #4651:
URL: https://github.com/apache/hbase/pull/4651#issuecomment-1196146163

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 43s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  7s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 27s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 34s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   5m 55s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 41s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   4m 12s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 30s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 30s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   5m 45s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 23s |  hbase-client generated 0 new + 
81 unchanged - 11 fixed = 81 total (was 92)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   3m 24s |  hbase-client in the patch passed.  
|
   |  |   |  29m 34s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4651 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux a35b2be73d55 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4c08a8a423 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/testReport/
 |
   | Max. process+thread count | 200 (vs. ulimit of 12500) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache-HBase commented on PR #4651:
URL: https://github.com/apache/hbase/pull/4651#issuecomment-1196146127

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 56s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 55s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 51s |  branch-2 passed  |
   | +1 :green_heart: |  checkstyle  |   0m 23s |  branch-2 passed  |
   | +1 :green_heart: |  spotless  |   1m  6s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m  7s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 39s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 50s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 50s |  hbase-client generated 69 new + 36 
unchanged - 109 fixed = 105 total (was 145)  |
   | +1 :green_heart: |  checkstyle  |   0m 21s |  hbase-client: The patch 
generated 0 new + 283 unchanged - 83 fixed = 283 total (was 366)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |   8m 50s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1.  |
   | +1 :green_heart: |  spotless  |   0m 56s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m  5s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  29m 37s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4651 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 906aacbf0f85 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4c08a8a423 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-client.txt
 |
   | Max. process+thread count | 64 (vs. ulimit of 12500) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell merged pull request #4646: HBASE-27210 Clean up error-prone findings in hbase-endpoint

[GitBox]

apurtell merged PR #4646:
URL: https://github.com/apache/hbase/pull/4646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

Apache-HBase commented on PR #4651:
URL: https://github.com/apache/hbase/pull/4651#issuecomment-1196140867

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  7s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  6s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ branch-2 Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 18s |  branch-2 passed  |
   | +1 :green_heart: |  compile  |   0m 18s |  branch-2 passed  |
   | +1 :green_heart: |  shadedjars  |   3m 43s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 19s |  branch-2 passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 20s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 20s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 38s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 16s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   2m 33s |  hbase-client in the patch passed.  
|
   |  |   |  18m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4651 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 093629bc8d87 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | branch-2 / 4c08a8a423 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/testReport/
 |
   | Max. process+thread count | 169 (vs. ulimit of 12500) |
   | modules | C: hbase-client U: hbase-client |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4651/1/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #4645: HBASE-27206 Clean up error-prone findings in hbase-common

[GitBox]

apurtell commented on PR #4645:
URL: https://github.com/apache/hbase/pull/4645#issuecomment-1196139409

   hbase-server TestAsyncTableScanAll.testReversedScanAll failure is I think a 
tracing flake /cc @ndimiduk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] (HBASE-27203) Clean up error-prone findings in hbase-client

[Andrew Kyle Purtell (Jira)]

[ https://issues.apache.org/jira/browse/HBASE-27203 ]


Andrew Kyle Purtell deleted comment on HBASE-27203:
-

was (Author: apurtell):
As I feared there are what I think are real bugs in branch-2 and we should take 
advantage of the new minor (2.5.0) to correct them. 

> Clean up error-prone findings in hbase-client
> -
>
> Key: HBASE-27203
> URL: https://issues.apache.org/jira/browse/HBASE-27203
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] apurtell commented on a diff in pull request #4651: HBASE-27203 Clean up error-prone findings in hbase-client [branch-2]

[GitBox]

apurtell commented on code in PR #4651:
URL: https://github.com/apache/hbase/pull/4651#discussion_r930509784


##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java:
##
@@ -94,34 +94,35 @@ private long resultSize2CacheSize(long maxResultSize) {
   public Result next() throws IOException {
 try (Scope ignored = span.makeCurrent()) {
   lock.lock();
-  while (cache.isEmpty()) {
-handleException();
-if (this.closed) {
-  return null;
+  try {
+while (cache.isEmpty()) {
+  handleException();
+  if (this.closed) {
+return null;
+  }
+  try {
+notEmpty.await();
+  } catch (InterruptedException e) {
+span.recordException(e);
+throw new InterruptedIOException("Interrupted when wait to load 
cache");
+  }
 }
-try {
-  notEmpty.await();
-} catch (InterruptedException e) {
-  span.recordException(e);
-  throw new InterruptedIOException("Interrupted when wait to load 
cache");
+Result result = pollCache();
+if (prefetchCondition()) {
+  notFull.signalAll();
 }
+return result;
+  } finally {
+lock.unlock();
+handleException();
   }
-
-  Result result = pollCache();
-  if (prefetchCondition()) {
-notFull.signalAll();
-  }
-  return result;
-} finally {
-  lock.unlock();
-  handleException();
 }
   }
 
   @Override
   public void close() {
+lock.lock();

Review Comment:
   Not a real bug like above but still a nit.



##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ClientAsyncPrefetchScanner.java:
##
@@ -94,34 +94,35 @@ private long resultSize2CacheSize(long maxResultSize) {
   public Result next() throws IOException {
 try (Scope ignored = span.makeCurrent()) {
   lock.lock();
-  while (cache.isEmpty()) {
-handleException();
-if (this.closed) {
-  return null;
+  try {

Review Comment:
   We were missing an inner try here. 



##
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java:
##
@@ -167,6 +168,7 @@ private void established(Channel ch) throws IOException {
 
   private boolean reloginInProgress;
 
+  @SuppressWarnings("FutureReturnValueIgnored")

Review Comment:
   Suppressed here because the scheduling returns a future we don't care about.



##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java:
##
@@ -48,15 +44,15 @@ public RpcRetryingCallerFactory(Configuration conf, 
RetryingCallerInterceptor in
 startLogErrorsCnt = 
conf.getInt(AsyncProcess.START_LOG_ERRORS_AFTER_COUNT_KEY,
   AsyncProcess.DEFAULT_START_LOG_ERRORS_AFTER_COUNT);
 this.interceptor = interceptor;
-enableBackPressure = conf.getBoolean(HConstants.ENABLE_CLIENT_BACKPRESSURE,
-  HConstants.DEFAULT_ENABLE_CLIENT_BACKPRESSURE);
   }
 
   /**
* Set the tracker that should be used for tracking statistics about the 
server
+   * @deprecated Does nothing. Since 2.5.0, will be removed in 4.0.0.

Review Comment:
   Remove this in 3.0.0 instead? 



##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java:
##
@@ -1717,7 +1716,13 @@ public void mergeRegionsSync(final byte[] nameOfRegionA, 
final byte[] nameOfRegi
   @Override
   public void mergeRegions(final byte[] nameOfRegionA, final byte[] 
nameOfRegionB,
 final boolean forcible) throws IOException {
-mergeRegionsAsync(nameOfRegionA, nameOfRegionB, forcible);
+try {

Review Comment:
   `mergeRegions` will return immediately without waiting for or surfacing any 
exception from the operation. This seems wrong. Yet, it is a semantic change 
over previously released versions. For discussion.



##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/PreemptiveFastFailInterceptor.java:
##
@@ -86,7 +86,8 @@ class PreemptiveFastFailInterceptor extends 
RetryingCallerInterceptor {
   // fast fail mode for any reason.
   private long fastFailClearingTimeMilliSec;
 
-  private final ThreadLocal threadRetryingInFastFailMode = new 
ThreadLocal<>();
+  private static final ThreadLocal 
threadRetryingInFastFailMode =

Review Comment:
   ThreadLocals should to be class fields not instance fields. Otherwise the 
coder may get the false impression interactions with the thread local is also 
scoped to the instance. They are not, they are scoped to the thread.



##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java:
##
@@ -189,9 +189,13 @@ public class ConnectionImplementation implements 
ClusterConnection, Closeable {
   final int rpcTimeout;
 
   /**
-   * Global nonceGenerator shared per client.Currently there's no reason to 
limit its scope. Once
+   * Global nonc

[jira] [Commented] (HBASE-27203) Clean up error-prone findings in hbase-client

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571666#comment-17571666
 ] 

Andrew Kyle Purtell commented on HBASE-27203:
-

As I feared there are what I think are real bugs in branch-2 and we should take 
advantage of the new minor (2.5.0) to correct them. 

> Clean up error-prone findings in hbase-client
> -
>
> Key: HBASE-27203
> URL: https://issues.apache.org/jira/browse/HBASE-27203
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] Apache-HBase commented on pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

Apache-HBase commented on PR #4643:
URL: https://github.com/apache/hbase/pull/4643#issuecomment-1196042458

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   3m 18s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 53s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 20s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 20s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 15s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 35s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 17s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 17s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 35s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 15s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  12m  6s |  hbase-backup in the patch passed.  
|
   |  |   |  31m 59s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4643 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 1b2aa5a91136 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/testReport/
 |
   | Max. process+thread count | 3174 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

Apache-HBase commented on PR #4643:
URL: https://github.com/apache/hbase/pull/4643#issuecomment-1196038103

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 42s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 45s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 15s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   3m 52s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 13s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 29s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 15s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 48s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 11s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   9m 39s |  hbase-backup in the patch passed.  
|
   |  |   |  25m 14s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4643 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 1570e94762f8 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/testReport/
 |
   | Max. process+thread count | 2934 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

Apache-HBase commented on PR #4643:
URL: https://github.com/apache/hbase/pull/4643#issuecomment-1196038073

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 37s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 10s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 22s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 40s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 23s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 22s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 22s |  hbase-backup generated 0 new + 0 
unchanged - 52 fixed = 0 total (was 52)  |
   | +1 :green_heart: |  checkstyle  |   0m  7s |  the patch passed  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  11m 33s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 41s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   0m 29s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m  6s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  25m  9s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4643 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 2830bcd2f6bc 5.4.0-1071-aws #76~18.04.1-Ubuntu SMP Mon Mar 
28 17:49:57 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-backup U: hbase-backup |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4643/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4638: HBASE-27224 HFile tool statistic sampling produces misleading results

[GitBox]

Apache-HBase commented on PR #4638:
URL: https://github.com/apache/hbase/pull/4638#issuecomment-1196037296

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m 23s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   3m  9s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 47s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   0m 41s |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 52s |  branch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 38s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   2m 44s |  the patch passed  |
   | +1 :green_heart: |  compile  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  javac  |   2m 40s |  the patch passed  |
   | +1 :green_heart: |  checkstyle  |   0m 32s |  hbase-server: The patch 
generated 0 new + 8 unchanged - 1 fixed = 8 total (was 9)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  13m 49s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.2 3.3.1.  |
   | +1 :green_heart: |  spotless  |   0m 48s |  patch has no errors when 
running spotless:check.  |
   | +1 :green_heart: |  spotbugs  |   1m 44s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 11s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  38m 54s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4638 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
spotless checkstyle compile |
   | uname | Linux 8c54007870f6 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 
20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 9ba868d2ad |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | Max. process+thread count | 64 (vs. ulimit of 3) |
   | modules | C: hbase-server U: hbase-server |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4638/3/console 
|
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell merged pull request #4644: HBASE-27203 Clean up error-prone findings in hbase-client

[GitBox]

apurtell merged PR #4644:
URL: https://github.com/apache/hbase/pull/4644


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4644: HBASE-27203 Clean up error-prone findings in hbase-client

[GitBox]

apurtell commented on code in PR #4644:
URL: https://github.com/apache/hbase/pull/4644#discussion_r930437997


##
hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java:
##
@@ -62,7 +65,8 @@ public boolean matches(String stringQop) {
 
   /** Splitting fully qualified Kerberos name into parts */
   public static String[] splitKerberosName(String fullName) {
-return fullName.split("[/@]");
+List result = Splitter.onPattern("[/@]").splitToList(fullName);

Review Comment:
   You indicated a preference for using a stream to do toArray on the 
hbase-backup review, will apply the pattern to all such places, no problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4644: HBASE-27203 Clean up error-prone findings in hbase-client

[GitBox]

apurtell commented on code in PR #4644:
URL: https://github.com/apache/hbase/pull/4644#discussion_r930437997


##
hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java:
##
@@ -62,7 +65,8 @@ public boolean matches(String stringQop) {
 
   /** Splitting fully qualified Kerberos name into parts */
   public static String[] splitKerberosName(String fullName) {
-return fullName.split("[/@]");
+List result = Splitter.onPattern("[/@]").splitToList(fullName);

Review Comment:
   You mentioned a preference for using a stream to do toArray on the 
hbase-backup review, will apply the pattern to all such places, no problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4644: HBASE-27203 Clean up error-prone findings in hbase-client

[GitBox]

apurtell commented on code in PR #4644:
URL: https://github.com/apache/hbase/pull/4644#discussion_r930437997


##
hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java:
##
@@ -62,7 +65,8 @@ public boolean matches(String stringQop) {
 
   /** Splitting fully qualified Kerberos name into parts */
   public static String[] splitKerberosName(String fullName) {
-return fullName.split("[/@]");
+List result = Splitter.onPattern("[/@]").splitToList(fullName);

Review Comment:
   I saw your preference for using a stream to do toArray on the hbase-backup 
review, will apply the pattern to all such places, no problem



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

apurtell commented on PR #4643:
URL: https://github.com/apache/hbase/pull/4643#issuecomment-1196011980

   Rebase. More review feedback. Fix test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] bbeaudreault commented on a diff in pull request #4638: HBASE-27224 HFile tool statistic sampling produces misleading results

[GitBox]

bbeaudreault commented on code in PR #4638:
URL: https://github.com/apache/hbase/pull/4638#discussion_r930431234


##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:
##
@@ -760,6 +830,37 @@ private void printHistogram(Histogram histogram) {
   output.printf(locale, "  99%% <= %2.2f%n", 
snapshot.get99thPercentile());
   output.printf(locale, "99.9%% <= %2.2f%n", 
snapshot.get999thPercentile());
   output.printf(locale, " count = %d%n", histogram.getCount());
+

Review Comment:
   @cbaenziger just pushed a comment, let me know if it clears anything up



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4624: HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty h…

[GitBox]

Apache-HBase commented on PR #4624:
URL: https://github.com/apache/hbase/pull/4624#issuecomment-1195990150

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   1m  0s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 38s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 44s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 13s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 31s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m  7s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 11s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   4m 36s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 47s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m 36s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 231m  3s |  hbase-server in the patch passed.  
|
   |  |   | 256m 24s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4624 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux b8d36551b880 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 8b091c4061 |
   | Default Java | AdoptOpenJDK-11.0.10+9 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/testReport/
 |
   | Max. process+thread count | 2676 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] apurtell commented on a diff in pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

apurtell commented on code in PR #4643:
URL: https://github.com/apache/hbase/pull/4643#discussion_r930417557


##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##
@@ -1720,7 +1726,8 @@ public String[] getListOfBackupIdsFromMergeOperation() 
throws IOException {
   if (val.length == 0) {
 return null;
   }
-  return new String(val).split(",");
+  List result = Splitter.on(',').splitToList(new String(val, 
StandardCharsets.UTF_8));

Review Comment:
   Ok, seems fine to do it with streams



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27229) BucketCache statistics should not count evictions by hfile

[Bryan Beaudreault (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-27229:
--
Labels:   (was: patch-available)

> BucketCache statistics should not count evictions by hfile
> --
>
> Key: HBASE-27229
> URL: https://issues.apache.org/jira/browse/HBASE-27229
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> The eviction metrics are helpful for determining how much access-related 
> churn there is in your block cache. The LruBlockCache properly ignores 
> evictions by invalidation of HFile, but the BucketCache tracks them. 
> We should make the BucketCache work similarly so that one can get an accurate 
> view of the evictions occurring through too much random access or too large 
> working set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (HBASE-27229) BucketCache statistics should not count evictions by hfile

[Bryan Beaudreault (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Beaudreault updated HBASE-27229:
--
Release Note: The eviction metric for the BucketCache has been updated to 
only count evictions triggered by the eviction process (i.e responding to cache 
pressure). This brings it in-line with the other cache implementations, with 
the goal of this metric being to give operators insight into cache pressure. 
Other evictions by hfile or drain to storage engine failure, etc, no longer 
count towards the eviction rate.
  Resolution: Fixed
  Status: Resolved  (was: Patch Available)

Thanks for the review [~apurtell]. Release note added.

> BucketCache statistics should not count evictions by hfile
> --
>
> Key: HBASE-27229
> URL: https://issues.apache.org/jira/browse/HBASE-27229
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> The eviction metrics are helpful for determining how much access-related 
> churn there is in your block cache. The LruBlockCache properly ignores 
> evictions by invalidation of HFile, but the BucketCache tracks them. 
> We should make the BucketCache work similarly so that one can get an accurate 
> view of the evictions occurring through too much random access or too large 
> working set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] apurtell commented on a diff in pull request #4643: HBASE-27201 Clean up error-prone findings in hbase-backup

[GitBox]

apurtell commented on code in PR #4643:
URL: https://github.com/apache/hbase/pull/4643#discussion_r930417145


##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupSystemTable.java:
##
@@ -1639,7 +1645,7 @@ public String[] getListOfBackupIdsFromDeleteOperation() 
throws IOException {
   if (val.length == 0) {
 return null;
   }
-  return new String(val).split(",");
+  return new String(val, StandardCharsets.UTF_8).split(",");

Review Comment:
   This one doesn't set off the warning. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (HBASE-27243) Fix TestQuotaThrottle after HBASE-27046

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27243:

Fix Version/s: 2.6.0
   2.5.1
   3.0.0-alpha-4
   2.4.14

> Fix TestQuotaThrottle after HBASE-27046
> ---
>
> Key: HBASE-27243
> URL: https://issues.apache.org/jira/browse/HBASE-27243
> Project: HBase
>  Issue Type: Test
>Reporter: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> TestQuotaThrottle breaks monotonic WAL numbering after HBASE-20746 because of 
> how it manipulates the EnvironmentEdge and was disabled by HBASE-27087. Fix 
> the test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (HBASE-27087) TestQuotaThrottle times out

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27087:

Fix Version/s: 2.4.14

> TestQuotaThrottle times out
> ---
>
> Key: HBASE-27087
> URL: https://issues.apache.org/jira/browse/HBASE-27087
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.5.0, 3.0.0-alpha-2
>Reporter: Huaxiang Sun
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4, 2.4.14
>
>
> With branch-2.5, TestQuotaThrottle times out. Need to investigate.
>  
> h3. Error Message
> Failed after attempts=7, exceptions: 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27087) TestQuotaThrottle times out

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571620#comment-17571620
 ] 

Andrew Kyle Purtell commented on HBASE-27087:
-

HBASE-27243 to fix the test

> TestQuotaThrottle times out
> ---
>
> Key: HBASE-27087
> URL: https://issues.apache.org/jira/browse/HBASE-27087
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.5.0, 3.0.0-alpha-2
>Reporter: Huaxiang Sun
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> With branch-2.5, TestQuotaThrottle times out. Need to investigate.
>  
> h3. Error Message
> Failed after attempts=7, exceptions: 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27046) The filenum in AbstractFSWAL should be monotone increasing

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571619#comment-17571619
 ] 

Andrew Kyle Purtell commented on HBASE-27046:
-

HBASE-27243 to fix the test

> The filenum in AbstractFSWAL should be monotone increasing
> --
>
> Key: HBASE-27046
> URL: https://issues.apache.org/jira/browse/HBASE-27046
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> This is the current code
> {code}
>   /**
>* retrieve the next path to use for writing. Increments the internal 
> filenum.
>*/
>   private Path getNewPath() throws IOException {
> this.filenum.set(EnvironmentEdgeManager.currentTime());
> Path newPath = getCurrentFileName();
> while (fs.exists(newPath)) {
>   this.filenum.incrementAndGet();
>   newPath = getCurrentFileName();
> }
> return newPath;
>   }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts 
> always or even go backwards, the logic here is not rnough to keep the filenum 
> monotone increasing, as we may have already archive the old file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27242) HBase master reports a region has been in transition for 50+ years

[Bryan Beaudreault (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571618#comment-17571618
 ] 

Bryan Beaudreault commented on HBASE-27242:
---

Oh yea, I recently noticed this as well

> HBase master reports a region has been in transition for 50+ years
> --
>
> Key: HBASE-27242
> URL: https://issues.apache.org/jira/browse/HBASE-27242
> Project: HBase
>  Issue Type: Bug
>  Components: master
>Affects Versions: 2.4.8, 2.4.9, 2.4.10, 2.4.11
> Environment: openjdk version "11.0.14.1" 2022-02-08
> OpenJDK Runtime Environment 18.9 (build 11.0.14.1+1)
> OpenJDK 64-Bit Server VM 18.9 (build 11.0.14.1+1, mixed mode, sharing)
>Reporter: Benoit Sigoure
>Priority: Major
> Attachments: image.png
>
>
> Every time we upgrade our HBase clusters we get some spurious alerts firing 
> because for a brief period of time the HBase master reports some impossibly 
> high RIT (region in transition) time.
> For example:
> !image.png|width=747,height=249!
>  
> The condition resolves itself on its own within a few minutes. I'll try to 
> find some relevant logs and attach them to this issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (HBASE-27243) Fix TestQuotaThrottle after HBASE-27046

[Andrew Kyle Purtell (Jira)]

Andrew Kyle Purtell created HBASE-27243:
---

 Summary: Fix TestQuotaThrottle after HBASE-27046
 Key: HBASE-27243
 URL: https://issues.apache.org/jira/browse/HBASE-27243
 Project: HBase
  Issue Type: Test
Reporter: Andrew Kyle Purtell


TestQuotaThrottle breaks monotonic WAL numbering after HBASE-20746 because of 
how it manipulates the EnvironmentEdge and was disabled by HBASE-27087. Fix the 
test.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] bbeaudreault merged pull request #4639: HBASE-27229 BucketCache statistics should not count evictions by hfile

[GitBox]

bbeaudreault merged PR #4639:
URL: https://github.com/apache/hbase/pull/4639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (HBASE-27087) TestQuotaThrottle times out

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell resolved HBASE-27087.
-
Resolution: Fixed

> TestQuotaThrottle times out
> ---
>
> Key: HBASE-27087
> URL: https://issues.apache.org/jira/browse/HBASE-27087
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.5.0, 3.0.0-alpha-2
>Reporter: Huaxiang Sun
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> With branch-2.5, TestQuotaThrottle times out. Need to investigate.
>  
> h3. Error Message
> Failed after attempts=7, exceptions: 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27087) TestQuotaThrottle times out

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571617#comment-17571617
 ] 

Andrew Kyle Purtell commented on HBASE-27087:
-

There is discussion on HBASE-27046 indicating this broken test is the result of 
a desirable change, so to resolve this for now I will disable the test. We need 
clean tests for RCs. File a follow up to fix the test.

> TestQuotaThrottle times out
> ---
>
> Key: HBASE-27087
> URL: https://issues.apache.org/jira/browse/HBASE-27087
> Project: HBase
>  Issue Type: Bug
>  Components: test
>Affects Versions: 2.5.0, 3.0.0-alpha-2
>Reporter: Huaxiang Sun
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> With branch-2.5, TestQuotaThrottle times out. Need to investigate.
>  
> h3. Error Message
> Failed after attempts=7, exceptions: 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master 2022-06-03T11:26:33.418Z, 
> RpcRetryingCaller\{globalStartTime=2022-06-03T11:26:33.418Z, pause=250, 
> maxAttempts=7}, org.apache.hadoop.hbase.MasterNotRunningException: 
> java.io.IOException: org.apache.zookeeper.KeeperException$NoNodeException: 
> KeeperErrorCode = NoNode for /hbase/master



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27046) The filenum in AbstractFSWAL should be monotone increasing

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571615#comment-17571615
 ] 

Andrew Kyle Purtell commented on HBASE-27046:
-

I resolved HBASE-27087 for now by adding an @Ignore to the test . Sorry, but we 
need clean tests for RCs. I put a comment in the file referring to the two 
relevant JIRAs. 

> The filenum in AbstractFSWAL should be monotone increasing
> --
>
> Key: HBASE-27046
> URL: https://issues.apache.org/jira/browse/HBASE-27046
> Project: HBase
>  Issue Type: Improvement
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-3, 2.4.13
>
>
> This is the current code
> {code}
>   /**
>* retrieve the next path to use for writing. Increments the internal 
> filenum.
>*/
>   private Path getNewPath() throws IOException {
> this.filenum.set(EnvironmentEdgeManager.currentTime());
> Path newPath = getCurrentFileName();
> while (fs.exists(newPath)) {
>   this.filenum.incrementAndGet();
>   newPath = getCurrentFileName();
> }
> return newPath;
>   }
> {code}
> In some tests, we inject our own EnvironmentEdge, it may return the same ts 
> always or even go backwards, the logic here is not rnough to keep the filenum 
> monotone increasing, as we may have already archive the old file.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27229) BucketCache statistics should not count evictions by hfile

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571612#comment-17571612
 ] 

Andrew Kyle Purtell commented on HBASE-27229:
-

Approved the PR. It's a notable change for the metric so please add a release 
note.

> BucketCache statistics should not count evictions by hfile
> --
>
> Key: HBASE-27229
> URL: https://issues.apache.org/jira/browse/HBASE-27229
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> The eviction metrics are helpful for determining how much access-related 
> churn there is in your block cache. The LruBlockCache properly ignores 
> evictions by invalidation of HFile, but the BucketCache tracks them. 
> We should make the BucketCache work similarly so that one can get an accurate 
> view of the evictions occurring through too much random access or too large 
> working set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (HBASE-27229) BucketCache statistics should not count evictions by hfile

[Andrew Kyle Purtell (Jira)]

 [ 
https://issues.apache.org/jira/browse/HBASE-27229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated HBASE-27229:

Fix Version/s: 2.5.0
   3.0.0-alpha-4

> BucketCache statistics should not count evictions by hfile
> --
>
> Key: HBASE-27229
> URL: https://issues.apache.org/jira/browse/HBASE-27229
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> The eviction metrics are helpful for determining how much access-related 
> churn there is in your block cache. The LruBlockCache properly ignores 
> evictions by invalidation of HFile, but the BucketCache tracks them. 
> We should make the BucketCache work similarly so that one can get an accurate 
> view of the evictions occurring through too much random access or too large 
> working set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[GitHub] [hbase] apurtell commented on pull request #4640: HBASE-27232 Fix checking for encoded block size when deciding if bloc…

[GitBox]

apurtell commented on PR #4640:
URL: https://github.com/apache/hbase/pull/4640#issuecomment-1195961440

   Master only? Not branch-2? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [hbase] Apache-HBase commented on pull request #4624: HBASE-27185 Rewrite NettyRpcServer to decode rpc request with netty h…

[GitBox]

Apache-HBase commented on PR #4624:
URL: https://github.com/apache/hbase/pull/4624#issuecomment-1195960625

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |::|--:|:|:|
   | +0 :ok: |  reexec  |   0m 41s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): 
--brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list 
--whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 47s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   2m 26s |  master passed  |
   | +1 :green_heart: |  compile  |   0m 50s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m  1s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 36s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   2m  8s |  the patch passed  |
   | +1 :green_heart: |  compile  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  javac  |   0m 49s |  the patch passed  |
   | +1 :green_heart: |  shadedjars  |   3m 58s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   0m 34s |  the patch passed  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |   1m  8s |  hbase-client in the patch passed.  
|
   | +1 :green_heart: |  unit  | 201m 22s |  hbase-server in the patch passed.  
|
   |  |   | 222m 12s |   |
   
   
   | Subsystem | Report/Notes |
   |--:|:-|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/4624 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux d8965d9d8c0a 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 
11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 8b091c4061 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   |  Test Results | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/testReport/
 |
   | Max. process+thread count | 2619 (vs. ulimit of 3) |
   | modules | C: hbase-client hbase-server U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4624/5/console 
|
   | versions | git=2.17.1 maven=3.6.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (HBASE-27225) Add BucketAllocator bucket size statistic logging

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571608#comment-17571608
 ] 

Hudson commented on HBASE-27225:


Results for branch branch-2.5
[build #172 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add BucketAllocator bucket size statistic logging
> -
>
> Key: HBASE-27225
> URL: https://issues.apache.org/jira/browse/HBASE-27225
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> BucketCache places blocks into configurably sized buckets based on the block 
> size. The default sizes aim to provide broad coverage for common block sizes, 
> but should probably be tuned for certain use-cases. However, we provide no 
> way for operators to gain insight into the distribution of buckets.
> There already exists a BucketAllocator#logStatistics method, but it is not 
> called anywhere. I suggest that we hook that up in BucketCache#logStats 
> (which is called periodically by a stats thread). We can go from there.
> Looking at the IndexStatistics used in that method, it looks like a good 
> start. One thing I'd like to add is a count of freeBuckets and 
> completelyFreeBuckets per index. I think this will be useful for indicating 
> how much more wiggle room we have for redistributing buckets among the 
> various block sizes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27179) Issues building with OpenJDK 17

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571606#comment-17571606
 ] 

Hudson commented on HBASE-27179:


Results for branch branch-2.5
[build #172 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Issues building with OpenJDK 17
> ---
>
> Key: HBASE-27179
> URL: https://issues.apache.org/jira/browse/HBASE-27179
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.0.0-alpha-3
>Reporter: Ramón García Fernández
>Assignee: Ramón García Fernández
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> When building with OpenJDK 17, some errors appear:
>  * The flag --illegal-access=permit is ignored, therefore its function of 
> allowing access to private fields by reflection no longer works, One has to 
> explicitly enable which packages can be accessed with --add-opens.
>  * In order for the tests of kerberos code to run, one has to add the export 
> of java.security.jgss/sun.security.krb5=ALL-UNNAMED
> To address these issues, I have created pull request 
> [https://github.com/apache/hbase/pull/4594]
>  
> Best regards.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27235) Clean up error-prone findings in hbase-hadoop-compat

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571607#comment-17571607
 ] 

Hudson commented on HBASE-27235:


Results for branch branch-2.5
[build #172 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/172/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Clean up error-prone findings in hbase-hadoop-compat
> 
>
> Key: HBASE-27235
> URL: https://issues.apache.org/jira/browse/HBASE-27235
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27235) Clean up error-prone findings in hbase-hadoop-compat

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571583#comment-17571583
 ] 

Hudson commented on HBASE-27235:


Results for branch master
[build #642 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Clean up error-prone findings in hbase-hadoop-compat
> 
>
> Key: HBASE-27235
> URL: https://issues.apache.org/jira/browse/HBASE-27235
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Andrew Kyle Purtell
>Assignee: Andrew Kyle Purtell
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27179) Issues building with OpenJDK 17

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571582#comment-17571582
 ] 

Hudson commented on HBASE-27179:


Results for branch master
[build #642 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Issues building with OpenJDK 17
> ---
>
> Key: HBASE-27179
> URL: https://issues.apache.org/jira/browse/HBASE-27179
> Project: HBase
>  Issue Type: Bug
>  Components: build
>Affects Versions: 3.0.0-alpha-3
>Reporter: Ramón García Fernández
>Assignee: Ramón García Fernández
>Priority: Minor
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> When building with OpenJDK 17, some errors appear:
>  * The flag --illegal-access=permit is ignored, therefore its function of 
> allowing access to private fields by reflection no longer works, One has to 
> explicitly enable which packages can be accessed with --add-opens.
>  * In order for the tests of kerberos code to run, one has to add the export 
> of java.security.jgss/sun.security.krb5=ALL-UNNAMED
> To address these issues, I have created pull request 
> [https://github.com/apache/hbase/pull/4594]
>  
> Best regards.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27225) Add BucketAllocator bucket size statistic logging

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571584#comment-17571584
 ] 

Hudson commented on HBASE-27225:


Results for branch master
[build #642 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add BucketAllocator bucket size statistic logging
> -
>
> Key: HBASE-27225
> URL: https://issues.apache.org/jira/browse/HBASE-27225
> Project: HBase
>  Issue Type: Improvement
>Reporter: Bryan Beaudreault
>Assignee: Bryan Beaudreault
>Priority: Major
>  Labels: patch-available
> Fix For: 2.5.1, 3.0.0-alpha-4, 2.4.14
>
>
> BucketCache places blocks into configurably sized buckets based on the block 
> size. The default sizes aim to provide broad coverage for common block sizes, 
> but should probably be tuned for certain use-cases. However, we provide no 
> way for operators to gain insight into the distribution of buckets.
> There already exists a BucketAllocator#logStatistics method, but it is not 
> called anywhere. I suggest that we hook that up in BucketCache#logStats 
> (which is called periodically by a stats thread). We can go from there.
> Looking at the IndexStatistics used in that method, it looks like a good 
> start. One thing I'd like to add is a count of freeBuckets and 
> completelyFreeBuckets per index. I think this will be useful for indicating 
> how much more wiggle room we have for redistributing buckets among the 
> various block sizes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27232) Fix checking for encoded block size when deciding if block should be closed

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571581#comment-17571581
 ] 

Hudson commented on HBASE-27232:


Results for branch master
[build #642 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/642/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Fix checking for encoded block size when deciding if block should be closed
> ---
>
> Key: HBASE-27232
> URL: https://issues.apache.org/jira/browse/HBASE-27232
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-3, 2.4.13
>Reporter: Wellington Chevreuil
>Assignee: Wellington Chevreuil
>Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> On HFileWriterImpl.checkBlockBoundary, we useed to consider the unencoded and 
> uncompressed data size when deciding to close a block and start a new one. 
> That could lead to varying "on-disk" block sizes, depending on the encoding 
> efficiency for the cells in each block.
> HBASE-17757 introduced the hbase.writer.unified.encoded.blocksize.ratio 
> property, as ration of the original configured block size, to be compared 
> against the encoded size. This was an attempt to ensure homogeneous block 
> sizes. However, the check introduced by HBASE-17757 also considers the 
> unencoded size, which in the cases where encoding efficiency is higher than 
> what's configured in hbase.writer.unified.encoded.blocksize.ratio, it would 
> still lead to varying block sizes.
> This patch changes that logic, to only consider encoded size if 
> hbase.writer.unified.encoded.blocksize.ratio property is set, otherwise, it 
> will consider the unencoded size. This gives a finer control over the on-disk 
> block sizes and the overall number of blocks when encoding is in use.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (HBASE-27153) Improvements to read-path tracing

[Andrew Kyle Purtell (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-27153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17571579#comment-17571579
 ] 

Andrew Kyle Purtell commented on HBASE-27153:
-

[~ndimiduk] based on those results it seeks ok to proceed with integrating the 
proposal on this issue.

> Improvements to read-path tracing
> -
>
> Key: HBASE-27153
> URL: https://issues.apache.org/jira/browse/HBASE-27153
> Project: HBase
>  Issue Type: Improvement
>  Components: Operability, regionserver
>Affects Versions: 2.5.0, 3.0.0-alpha-2, 2.6.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> Take another pass through tracing of the read path, make adjustments 
> accordingly. One of the major concerns raised previously is that we create a 
> span for every block access. Start by simplifying this to trace events and 
> see what else comes up.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)