[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251050#comment-14251050
 ] 

Varun Saxena commented on HBASE-12645:
--

Thanks [~stack] for the review and commit.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 12645.addendum.txt, 12645.v7.txt, HBASE-12645.002.patch, 
> HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
> HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249604#comment-14249604
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. I'm going to leave it in. If there is anything you want me to change Varun 
Saxena, just say and I'll add as an addendum. 
[~stack], you changed the flag name to {{create}} it seems. But I still see 
{{getNewDirPathIfExists}} flag being used in the code and in comments section 
at a few places

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
> HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
> HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249362#comment-14249362
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Something like this Varun Saxena?
Sorry. Couldnt get you. Something like what ?

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
> HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
> HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248729#comment-14248729
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], if the flag is false, {{getDefaultRootDirPath()}} calls below 
function. As you can see, if {{dataTestDirOnTestFS}} is null, directory path is 
created/fetched again.
If not, previous value is retrieved. When the flag is true,  we create a new 
path irrespective of whether dataTestDirOnTestFS is null or not.
{code}
public Path getDataTestDirOnTestFS() throws IOException {
if (dataTestDirOnTestFS == null) {
  setupDataTestDirOnTestFS();
}

return dataTestDirOnTestFS;
  }
{code}

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248692#comment-14248692
 ] 

Varun Saxena commented on HBASE-12645:
--

Correcting myself.
The flag {{getNewRootDirPathIfExists}} indicates whether to get a new root 
directory path if this flow of getting path has been hit before (whether path 
has been hit or not is done by checking whether dataTestDirOnTestFS is null or 
not)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248687#comment-14248687
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. "Whether to get a new root or data dir path even if such a path has been 
fetched earlier is decided based on flag getNewRootDirPathIfExists"
bq. What is 'get a new root or data dir path' and what does 'fetched' mean 
here? Does it mean created (create with override)? (I think it means this 
latter – one of your javadoc param notes says so... I'd think all mention of 
this flag in javadoc would have same text?)
Well, the creation of root directory and fetching of path of root directory are 
2 distinct operations. {{createRootDir()}} fetches the path of root directory 
by calling {{getDefaultRootDirPath()}} and then creates it(overwrites if path 
exists). 
Whenever we fetch or get a root or data directory path we mark it(variable 
{{dataTestDirOnTestFS}} will be null if path hasnt been retrieved earlier). 
The flag {{getNewRootDirPathIfExists}} indicates whether this flow of getting 
path has been hit before or not by checking whether {{dataTestDirOnTestFS}} is 
null or not.
Flag name has been kept like this for the lack of a proper name. Didnt sound 
great even to me. Probably you can suggest a better name.


> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248582#comment-14248582
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], kindly review. The test case failure is unrelated and tests are 
passing in my local setup.

bq. With this in place, after the test suite completes, we are not writing to 
user homedir any more?
I removed all references of {{getHomeDir())) from code and nothing existed in 
home dir after test suite completed.
Moreover, I checked all the test logs to find if some directory was created 
inside home directory or not and could not find anything. So in all probability 
nothing should have been created in home dir.

bq. Also, the new flag is never doc'd. What is it supposed to do? (I'm not 
clear). Flag is createRootDirIfExists This means, create root dir if it exists? 
But we don't check existance when we use it. Should we?
Flag name has been changed. The flag basically meant whether to fetch a new 
root dir path if one already exists(has been fetched earlier for the test 
class). First a path is created and then directory is created. The directory is 
anyways newly created(overwritten if already there). 

bq. nit: Usually the following is written as if(!createIfExists) rather than as 
if (false == createIfExists) {
Made the necessary change.

bq. Would we not want this flag always set? Or some tests need it not set?
Some cases fail if we always set the flag.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247901#comment-14247901
 ] 

Varun Saxena commented on HBASE-12645:
--

Test failure seems unrelated. Is in REST

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247233#comment-14247233
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Will try reworking the code so that this flag isnt required.
Doesnt quite work out. Fixed your review comments and uploaded a new patch. The 
new flag's name has been changed.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.006.patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.006.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246540#comment-14246540
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Would we not want this flag always set?
Will try reworking the code so that this flag isnt required. 

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245841#comment-14245841
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], [~ndimiduk], [~enis], kindly review. 

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.005.patch

Uploading a new patch. With this patch, all the test cases passed in my local 
setup. Let us see how Jenkins responds.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245543#comment-14245543
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], current patch will fail on some tests. Will upload a new patch after 
running all the tests in my local setup.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245370#comment-14245370
 ] 

Varun Saxena commented on HBASE-12645:
--

Ran all the test cases in local. Some are failing. Will investigate and if 
required, upload a new patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245248#comment-14245248
 ] 

Varun Saxena commented on HBASE-12645:
--

Wonder why the result from Jenkins is not coming.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.004.patch

Added code to handle the reason for failure of the 3 test cases above.
The test cases above were failing due to snapshot directory being inside the 
root directory.

Ran above 3 tests and a few other random tests after fix.
Submitting patch again.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.004.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

KIck Jenkins to check if any test cases fail due to the change

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.003.patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240846#comment-14240846
 ] 

Varun Saxena commented on HBASE-12645:
--

Sure, can do that. Although some other test classes may require change as well 
because some classes create a directory with fixed name instead of using UUID

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239026#comment-14239026
 ] 

Varun Saxena commented on HBASE-12645:
--

Above wasnt the right example for startup of MiniHBaseCluster. Some test cases 
like the one above are calling HBUT#createRootDir directly as well...Whereas 
some test cases use test-data directory and generate sub-directories with 
UUIDs'.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239012#comment-14239012
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. How? Each test gets its own data dir that is named with a UUID?
Every test case using starting MiniHBaseCluster will create a directory under 
root directory as under.
{code}
~/hbase/hbase-server/target/hbase_test$ ll
total 20
drwxrwxr-x  4 varun varun 4096 Dec  9 11:02 ./
drwxrwxr-x 13 varun varun 4096 Dec  9 11:02 ../
-rw-r--r--  1 varun varun7 Dec  9 11:02 hbase.version
drwxrwxrwx  2 varun varun 4096 Dec  9 11:02 testReadOldRootAndMetaEdits/
drwxrwxr-x  2 varun varun 4096 Dec  9 11:02 .tmp/

{code}

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238720#comment-14238720
 ] 

Varun Saxena commented on HBASE-12645:
--

Test case failure unrelated to code change. These tests are passing in my local 
setup. Also I am not sure why this code change should introduce release audit 
warning. Cant open the link to check audit warning.

bq. Is there not already a UUID in the path? The test dir's name is a UUID.
[~stack], it seems there is a separate directory generated for each test 
case(if required) but there will be a chance for it being overwritten if same 
set of parallel tests are running. I am not sure whats the use case for running 
parallel test cases but dont see any reason for running the same set of test 
cases parallely. I guess if nothing clashed in HOME_DIR/hbase, nothing would 
here as well. In that case initial patch should be good enough.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Status: Open  (was: Patch Available)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: (was: HBASE-12645.002.patch)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.002.patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.002.patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238465#comment-14238465
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Was there a use of HTU where we expected the root dir to be created under 
home?
None I am aware of. I can probably run all the cases and check.

bq. I'd prefer to see a UUID used in the path to avoid conflicts from parallel 
runs and the like.
Yes that will be useful. Will do that.

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Attachment: HBASE-12645.patch

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12645:
-
Assignee: Varun Saxena
  Status: Patch Available  (was: Open)

> HBaseTestingUtility is using ${$HOME} for rootDir
> -
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
>  Issue Type: Test
>  Components: test
>Affects Versions: 1.0.0
>Reporter: Nick Dimiduk
>Assignee: Varun Saxena
>Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<< 
> FAILURE! - in 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
> elapsed: 0.009 sec  <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory: 
> /homes/hortonnd/hbase
> at 
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at 
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at 
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at 
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in 
> this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12526:
-
Attachment: HBASE-12526-branch-1-v2.patch

[~stack], this patch for branch-1 contains fix for unused imports and 
subsequent Javadoc Warnings generated due to removal of imports.

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12526-0.98.patch, HBASE-12526-branch-1-v2.patch, 
> HBASE-12526-branch-1.patch, HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230306#comment-14230306
 ] 

Varun Saxena commented on HBASE-12603:
--

Ok [~stack]...Will give a patch for branch-1 fixing Javadoc Warnings as part of 
HBASE-12526 in a few minutes

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230031#comment-14230031
 ] 

Varun Saxena commented on HBASE-12603:
--

Or probably I can create a new patch for branch-1 for HBASE-12526 which clears 
the Javadoc warnings as well.  Let me know

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230023#comment-14230023
 ] 

Varun Saxena commented on HBASE-12603:
--

[~stack], I did not create a patch for branch-1 because HBASE-12526 hasnt yet 
been pushed to branch-1 yet. Once that is pushed, will prepare a patch for 
branch-1. Similarly, HBASE-12527 is pending to be pushed to both master and 
branch-1 and may require rebasing.

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Attachment: HBASE-12603.002.patch

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Status: Patch Available  (was: Open)

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Attachment: (was: HBASE-12603.002.patch)

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Status: Open  (was: Patch Available)

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Attachment: HBASE-12603.002.patch

Patch to fix checkstyle errors.

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.002.patch, HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Fix Version/s: 2.0.0
   Status: Patch Available  (was: Open)

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Fix For: 2.0.0
>
> Attachments: HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Attachment: HBASE-12603.patch

After this patch, only one warning should remain.

1 warning
[WARNING] Javadoc Warnings
[WARNING] 
/home/varun/hbase/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java:54:
 warning: Unsafe is internal proprietary API and may be removed in a future 
release
[WARNING] import sun.misc.Unsafe;


> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
> Attachments: HBASE-12603.patch
>
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

Varun Saxena created HBASE-12603:


 Summary: Remove javadoc warnings introduced due to removal of 
unused imports
 Key: HBASE-12603
 URL: https://issues.apache.org/jira/browse/HBASE-12603
 Project: HBase
  Issue Type: Bug
Reporter: Varun Saxena
Assignee: Varun Saxena


After removal of unused imports in HBASE-12526 , a lot of javadoc warnings were 
introduced because some of the classes referred to were no longer imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12603) Remove javadoc warnings introduced due to removal of unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12603:
-
Affects Version/s: 1.0.0

> Remove javadoc warnings introduced due to removal of unused imports
> ---
>
> Key: HBASE-12603
> URL: https://issues.apache.org/jira/browse/HBASE-12603
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>
> After removal of unused imports in HBASE-12526 , a lot of javadoc warnings 
> were introduced because some of the classes referred to were no longer 
> imported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Status: Patch Available  (was: Open)

Branch 0.98 patch applied to trunk. Adding master patch again.

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Status: Open  (was: Patch Available)

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: HBASE-12527-v2.patch

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: (was: HBASE-12527-v2.patch)

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228928#comment-14228928
 ] 

Varun Saxena commented on HBASE-12526:
--

Attached patches for branch-1 and 0.98

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12526-0.98.patch, HBASE-12526-branch-1.patch, 
> HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12526:
-
Attachment: HBASE-12526-0.98.patch

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12526-0.98.patch, HBASE-12526-branch-1.patch, 
> HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12526:
-
Attachment: HBASE-12526-branch-1.patch

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12526-branch-1.patch, HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228920#comment-14228920
 ] 

Varun Saxena commented on HBASE-12527:
--

[~stack], added patches for both branch-1 and 0.98

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: HBASE-12527-0.98.patch

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: HBASE-12527-branch-1.patch

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-0.98.patch, HBASE-12527-branch-1.patch, 
> HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228914#comment-14228914
 ] 

Varun Saxena commented on HBASE-12527:
--

Sure. Will do it for branch-1 as well. Wrote scripts to make these changes. So 
manual effort will be minimal.

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: HBASE-12527-v2.patch

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Status: Patch Available  (was: Open)

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Status: Open  (was: Patch Available)

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527-v2.patch, HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Fix Version/s: 2.0.0
   Status: Patch Available  (was: Open)

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12527:
-
Attachment: HBASE-12527.patch

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HBASE-12527.patch
>
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-12527) Remove padding around parens

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena reassigned HBASE-12527:


Assignee: Varun Saxena

> Remove padding around parens
> 
>
> Key: HBASE-12527
> URL: https://issues.apache.org/jira/browse/HBASE-12527
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>
> We have checkstyle [enforcing no padding around 
> parenthesis|http://checkstyle.sourceforge.net/config_whitespace.html#ParenPad]
>  and that matches [our ref 
> guide|http://hbase.apache.org/book.html#common.patch.feedback.space.invaders].
> Right now we have ~150 instances of not meeting this standard.
> list impacted files:
> {code}
> grep -rl -E "(\( |[^ ] \))" */src/* | grep java | grep -v generated
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12526:
-
Fix Version/s: 2.0.0
   Status: Patch Available  (was: Open)

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena reassigned HBASE-12526:


Assignee: Varun Saxena

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Attachments: HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12526) Remove unused imports

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12526:
-
Attachment: HBASE-12526.patch

> Remove unused imports
> -
>
> Key: HBASE-12526
> URL: https://issues.apache.org/jira/browse/HBASE-12526
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Priority: Minor
>  Labels: beginner, checkstyle
> Attachments: HBASE-12526.patch
>
>
> Even if we relax the import checker to include javadocs in HBASE-12523, we 
> still get ~250 remaining. Find and fix. Try to avoid reorganizing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12519) Remove tabs used as whitespace

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228744#comment-14228744
 ] 

Varun Saxena commented on HBASE-12519:
--

[~busbey], I have attached patch for branch-1. 

> Remove tabs used as whitespace
> --
>
> Key: HBASE-12519
> URL: https://issues.apache.org/jira/browse/HBASE-12519
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12519-branch-1.patch, HBASE-12519.patch
>
>
> We have a number of files with tabs for whitespace. Our style guide and our 
> checkstyle settings don't allow them, so clean them up.
> Doing this in a dedicate patch should make dealing with the churn easier, 
> since ignoring whitespace changes will make the patch appear empty.
> To get a list of files:
> {code}
> grep -rl -e "\t" */src/ | grep java$
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12519) Remove tabs used as whitespace

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12519:
-
Attachment: HBASE-12519-branch-1.patch

> Remove tabs used as whitespace
> --
>
> Key: HBASE-12519
> URL: https://issues.apache.org/jira/browse/HBASE-12519
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Assignee: Varun Saxena
>Priority: Minor
>  Labels: beginner, checkstyle
> Fix For: 2.0.0
>
> Attachments: HBASE-12519-branch-1.patch, HBASE-12519.patch
>
>
> We have a number of files with tabs for whitespace. Our style guide and our 
> checkstyle settings don't allow them, so clean them up.
> Doing this in a dedicate patch should make dealing with the churn easier, 
> since ignoring whitespace changes will make the patch appear empty.
> To get a list of files:
> {code}
> grep -rl -e "\t" */src/ | grep java$
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12519) Remove tabs used as whitespace

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12519:
-
Affects Version/s: 1.0.0
   Status: Patch Available  (was: Open)

> Remove tabs used as whitespace
> --
>
> Key: HBASE-12519
> URL: https://issues.apache.org/jira/browse/HBASE-12519
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Priority: Minor
>  Labels: beginner, checkstyle
> Attachments: HBASE-12519.patch
>
>
> We have a number of files with tabs for whitespace. Our style guide and our 
> checkstyle settings don't allow them, so clean them up.
> Doing this in a dedicate patch should make dealing with the churn easier, 
> since ignoring whitespace changes will make the patch appear empty.
> To get a list of files:
> {code}
> grep -rl -e "\t" */src/ | grep java$
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HBASE-12519) Remove tabs used as whitespace

[Varun Saxena (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HBASE-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Saxena updated HBASE-12519:
-
Attachment: HBASE-12519.patch

> Remove tabs used as whitespace
> --
>
> Key: HBASE-12519
> URL: https://issues.apache.org/jira/browse/HBASE-12519
> Project: HBase
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Sean Busbey
>Priority: Minor
>  Labels: beginner, checkstyle
> Attachments: HBASE-12519.patch
>
>
> We have a number of files with tabs for whitespace. Our style guide and our 
> checkstyle settings don't allow them, so clean them up.
> Doing this in a dedicate patch should make dealing with the churn easier, 
> since ignoring whitespace changes will make the patch appear empty.
> To get a list of files:
> {code}
> grep -rl -e "\t" */src/ | grep java$
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HBASE-12519) Remove tabs used as whitespace

[Varun Saxena (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-12519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228530#comment-14228530
 ] 

Varun Saxena commented on HBASE-12519:
--

KIndly assign this issue to me.
I used the following command to find out files which have tabs and used expand 
command to convert them to spaces.

{code:xml}
find . -name "*.java" -print | xargs grep -n $'\t'
{code}

> Remove tabs used as whitespace
> --
>
> Key: HBASE-12519
> URL: https://issues.apache.org/jira/browse/HBASE-12519
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Sean Busbey
>Priority: Minor
>  Labels: beginner, checkstyle
>
> We have a number of files with tabs for whitespace. Our style guide and our 
> checkstyle settings don't allow them, so clean them up.
> Doing this in a dedicate patch should make dealing with the churn easier, 
> since ignoring whitespace changes will make the patch appear empty.
> To get a list of files:
> {code}
> grep -rl -e "\t" */src/ | grep java$
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)