[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-17 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249604#comment-14249604
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. I'm going to leave it in. If there is anything you want me to change Varun 
Saxena, just say and I'll add as an addendum. 
[~stack], you changed the flag name to {{create}} it seems. But I still see 
{{getNewDirPathIfExists}} flag being used in the code and in comments section 
at a few places

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14250449#comment-14250449
 ] 

Hudson commented on HBASE-12645:


FAILURE: Integrated in HBase-TRUNK #5938 (See 
[https://builds.apache.org/job/HBase-TRUNK/5938/])
HBASE-12645 HBaseTestingUtility is using ${$HOME} for rootDir (Varun Saxena) -- 
ADDENDUM (stack: rev 422df8a3f430e1e41f971a644eec298f23decaf8)
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.addendum.txt, 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-17 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14250487#comment-14250487
 ] 

Hudson commented on HBASE-12645:


SUCCESS: Integrated in HBase-1.0 #593 (See 
[https://builds.apache.org/job/HBase-1.0/593/])
HBASE-12645 HBaseTestingUtility is using ${$HOME} for rootDir (Varun Saxena) -- 
ADDENDUM (stack: rev 5b51218a5637e954ec64b7ae6611f936de4a61ec)
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.addendum.txt, 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-17 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251050#comment-14251050
 ] 

Varun Saxena commented on HBASE-12645:
--

Thanks [~stack] for the review and commit.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.addendum.txt, 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248582#comment-14248582
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], kindly review. The test case failure is unrelated and tests are 
passing in my local setup.

bq. With this in place, after the test suite completes, we are not writing to 
user homedir any more?
I removed all references of {{getHomeDir())) from code and nothing existed in 
home dir after test suite completed.
Moreover, I checked all the test logs to find if some directory was created 
inside home directory or not and could not find anything. So in all probability 
nothing should have been created in home dir.

bq. Also, the new flag is never doc'd. What is it supposed to do? (I'm not 
clear). Flag is createRootDirIfExists This means, create root dir if it exists? 
But we don't check existance when we use it. Should we?
Flag name has been changed. The flag basically meant whether to fetch a new 
root dir path if one already exists(has been fetched earlier for the test 
class). First a path is created and then directory is created. The directory is 
anyways newly created(overwritten if already there). 

bq. nit: Usually the following is written as if(!createIfExists) rather than as 
if (false == createIfExists) {
Made the necessary change.

bq. Would we not want this flag always set? Or some tests need it not set?
Some cases fail if we always set the flag.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248637#comment-14248637
 ] 

stack commented on HBASE-12645:
---

Patch looks good.

I'm not sure I understand what this means:

Whether to get a new root or data dir path even if such a path has been 
fetched earlier is decided based on flag getNewRootDirPathIfExists

What is 'get a new root or data dir path' and what does 'fetched' mean here?  
Does it mean created (create with override)? (I think it means this latter -- 
one of your javadoc param notes says so... I'd think all mention of this flag 
in javadoc would have same text?)

Usually too the above comment is put on the javadoc param '@param 
getNewRootDirPathIfExists Whether to get a '  I see you do it sometimes but 
not always.

getNewRootDirPathIfExists is not a good name for a flag.  It is the name of a 
getter method for a flag named newRootDirPathIfExists

Otherwise, the patch is great and thank you for checking we no longer write the 
root dir. I ran the patch again against hadoopqa so we can see test failure is 
not related.  T hanks.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248687#comment-14248687
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Whether to get a new root or data dir path even if such a path has been 
fetched earlier is decided based on flag getNewRootDirPathIfExists
bq. What is 'get a new root or data dir path' and what does 'fetched' mean 
here? Does it mean created (create with override)? (I think it means this 
latter – one of your javadoc param notes says so... I'd think all mention of 
this flag in javadoc would have same text?)
Well, the creation of root directory and fetching of path of root directory are 
2 distinct operations. {{createRootDir()}} fetches the path of root directory 
by calling {{getDefaultRootDirPath()}} and then creates it(overwrites if path 
exists). 
Whenever we fetch or get a root or data directory path we mark it(variable 
{{dataTestDirOnTestFS}} will be null if path hasnt been retrieved earlier). 
The flag {{getNewRootDirPathIfExists}} indicates whether this flow of getting 
path has been hit before or not by checking whether {{dataTestDirOnTestFS}} is 
null or not.
Flag name has been kept like this for the lack of a proper name. Didnt sound 
great even to me. Probably you can suggest a better name.


 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248692#comment-14248692
 ] 

Varun Saxena commented on HBASE-12645:
--

Correcting myself.
The flag {{getNewRootDirPathIfExists}} indicates whether to get a new root 
directory path if this flow of getting path has been hit before (whether path 
has been hit or not is done by checking whether dataTestDirOnTestFS is null or 
not)

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248729#comment-14248729
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], if the flag is false, {{getDefaultRootDirPath()}} calls below 
function. As you can see, if {{dataTestDirOnTestFS}} is null, directory path is 
created/fetched again.
If not, previous value is retrieved. When the flag is true,  we create a new 
path irrespective of whether dataTestDirOnTestFS is null or not.
{code}
public Path getDataTestDirOnTestFS() throws IOException {
if (dataTestDirOnTestFS == null) {
  setupDataTestDirOnTestFS();
}

return dataTestDirOnTestFS;
  }
{code}

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248847#comment-14248847
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687527/HBASE-12645.006.patch
  against master branch at commit 1359e87b1757dd32d81fa2039af55156de1b3298.
  ATTACHMENT ID: 12687527

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12099//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249339#comment-14249339
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687624/12645.v7.txt
  against master branch at commit d845a92fc8007085999c8beebca7e7b00ca5322e.
  ATTACHMENT ID: 12687624

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 18 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestClientPushback

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12102//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249348#comment-14249348
 ] 

Hudson commented on HBASE-12645:


FAILURE: Integrated in HBase-TRUNK #5934 (See 
[https://builds.apache.org/job/HBase-TRUNK/5934/])
HBASE-12645 HBaseTestingUtility is using ${$HOME} for rootDir (Varun Saxena) 
(stack: rev 89006f76f7f8b206c3575c146f76a3509a398190)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatTestBase.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java


 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249362#comment-14249362
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Something like this Varun Saxena?
Sorry. Couldnt get you. Something like what ?

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249459#comment-14249459
 ] 

stack commented on HBASE-12645:
---

I edited your patch and attached a new version and wondered if you were ok w/ 
it [~varun_saxena]

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249488#comment-14249488
 ] 

stack commented on HBASE-12645:
---

Looks like I committed this to master mistakenly here:

{code}
commit 89006f76f7f8b206c3575c146f76a3509a398190
Author: stack st...@apache.org
Date:   Tue Dec 16 16:41:27 2014 -0800

HBASE-12645 HBaseTestingUtility is using ${$HOME} for rootDir (Varun Saxena)
{code}

I'm going to leave it in. If there is anything you want me to change 
[~varun_saxena], just say and I'll add as an addendum.  Sorry about that.  Let 
me get this on other branches too since it an important fix.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-16 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249517#comment-14249517
 ] 

Hudson commented on HBASE-12645:


FAILURE: Integrated in HBase-1.0 #592 (See 
[https://builds.apache.org/job/HBase-1.0/592/])
HBASE-12645 HBaseTestingUtility is using ${$HOME} for rootDir (Varun Saxena) 
(stack: rev e82f048d7b17b871f813bf6f4aa7ecda226d1b19)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestTableSnapshotScanner.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatTestBase.java


 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: 12645.v7.txt, HBASE-12645.002.patch, 
 HBASE-12645.003.patch, HBASE-12645.004.patch, HBASE-12645.004.patch, 
 HBASE-12645.005.patch, HBASE-12645.006.patch, HBASE-12645.006.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-15 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246540#comment-14246540
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Would we not want this flag always set?
Will try reworking the code so that this flag isnt required. 

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-15 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247233#comment-14247233
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Will try reworking the code so that this flag isnt required.
Doesnt quite work out. Fixed your review comments and uploaded a new patch. The 
new flag's name has been changed.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-15 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247373#comment-14247373
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687296/HBASE-12645.006.patch
  against master branch at commit 065d03b7840e0091adbb2aa9779b8129ed9883aa.
  ATTACHMENT ID: 12687296

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 15 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
 

 {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):   
at 
org.apache.hadoop.hbase.rest.TestScannersWithLabels.testSimpleScannerXMLWithLabelsThatReceivesData(TestScannersWithLabels.java:226)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12089//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-15 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14247901#comment-14247901
 ] 

Varun Saxena commented on HBASE-12645:
--

Test failure seems unrelated. Is in REST

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.006.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-14 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246327#comment-14246327
 ] 

stack commented on HBASE-12645:
---

[~varun_saxena] Sorry.. should have explained.  I ran the hadoopqa just to see 
what tests would fail. Thought it might be input for you as you were debugging 
failures.

On current patch, its great.  A few questions. With this in place, after the 
test suite completes, we are not writing to user homedir any more?  Also, the 
new flag is never doc'd.  What is it supposed to do?  (I'm not clear).  Flag is 
createRootDirIfExists  This means, create root dir if it exists?  But we don't 
check existance when we use it.  Should we?

178 +  public Path getDefaultRootDirPath(boolean createIfExists) throws 
IOException {
179 +if (false == createIfExists) {
180 +  return getDataTestDirOnTestFS();
181 +} else {
182 +  return setupNewDataTestDirOnTestFS();
183 +}
184 +  }

nit: Usually the following is written as if(!createIfExists) rather than as
if (false == createIfExists) {

Would we not want this flag always set?  Or some tests need it not set?

Thanks [~varun_saxena]

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245248#comment-14245248
 ] 

Varun Saxena commented on HBASE-12645:
--

Wonder why the result from Jenkins is not coming.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245370#comment-14245370
 ] 

Varun Saxena commented on HBASE-12645:
--

Ran all the test cases in local. Some are failing. Will investigate and if 
required, upload a new patch

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245543#comment-14245543
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], current patch will fail on some tests. Will upload a new patch after 
running all the tests in my local setup.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245670#comment-14245670
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687067/HBASE-12645.004.patch
  against master branch at commit 65830b096b6f540b7e49ef590dac1ebe2491c126.
  ATTACHMENT ID: 12687067

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation
  org.apache.hadoop.hbase.snapshot.TestExportSnapshot
  
org.apache.hadoop.hbase.replication.TestReplicationDisableInactivePeer
  org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
  org.apache.hadoop.hbase.util.TestMergeTable
  
org.apache.hadoop.hbase.master.handler.TestTableDeleteFamilyHandler
  
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
  org.apache.hadoop.hbase.TestMultiVersions

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12070//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245838#comment-14245838
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687092/HBASE-12645.005.patch
  against master branch at commit 65830b096b6f540b7e49ef590dac1ebe2491c126.
  ATTACHMENT ID: 12687092

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12074//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-13 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14245841#comment-14245841
 ] 

Varun Saxena commented on HBASE-12645:
--

[~stack], [~ndimiduk], [~enis], kindly review. 

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14243215#comment-14243215
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12686658/HBASE-12645.003.patch
  against master branch at commit 534beefc132cfbfb75e8d844f5affe009d189bfc.
  ATTACHMENT ID: 12686658

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestTableSnapshotScanner
  org.apache.hadoop.hbase.mapred.TestTableSnapshotInputFormat
  org.apache.hadoop.hbase.mapreduce.TestTableSnapshotInputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12050//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch, 
 HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-10 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240846#comment-14240846
 ] 

Varun Saxena commented on HBASE-12645:
--

Sure, can do that. Although some other test classes may require change as well 
because some classes create a directory with fixed name instead of using UUID

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-10 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241307#comment-14241307
 ] 

stack commented on HBASE-12645:
---

If they are using HBaseTestingUtility, they should use its means of creating 
dirs for test data.  It has facility for doing cleanup.  Also makes dirs in 
right location, under target.  Ideally, when test suite has finished, there is 
no test data or logs outside of the module target dir.  You may not be able to 
force this.  IIRC, minihdfs is not completely configurable and can write 
outside test dir but it is a while since I looked at it.  Good luck.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-09 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239598#comment-14239598
 ] 

stack commented on HBASE-12645:
---

See comments above. I think its difference between local and hdfs fs.  Could do 
as [~enis] suggests?  We want all tests using UUID test dir if possible.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Nick Dimiduk (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238189#comment-14238189
 ] 

Nick Dimiduk commented on HBASE-12645:
--

Thanks for the patch [~varun_saxena]. Was there a use of HTU where we expected 
the root dir to be created under home? I'd prefer to see a UUID used in the 
path to avoid conflicts from parallel runs and the like.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238465#comment-14238465
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. Was there a use of HTU where we expected the root dir to be created under 
home?
None I am aware of. I can probably run all the cases and check.

bq. I'd prefer to see a UUID used in the path to avoid conflicts from parallel 
runs and the like.
Yes that will be useful. Will do that.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238518#comment-14238518
 ] 

stack commented on HBASE-12645:
---

Is there not already a UUID in the path?  The test dir's name is a UUID.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238627#comment-14238627
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12685856/HBASE-12645.002.patch
  against master branch at commit 4b1983c89dde74396cd1d41984df5f5b62a47193.
  ATTACHMENT ID: 12685856

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the master's current 0 warnings).

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
  org.apache.hadoop.hbase.snapshot.TestExportSnapshot

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/patchReleaseAuditWarnings.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12002//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238720#comment-14238720
 ] 

Varun Saxena commented on HBASE-12645:
--

Test case failure unrelated to code change. These tests are passing in my local 
setup. Also I am not sure why this code change should introduce release audit 
warning. Cant open the link to check audit warning.

bq. Is there not already a UUID in the path? The test dir's name is a UUID.
[~stack], it seems there is a separate directory generated for each test 
case(if required) but there will be a chance for it being overwritten if same 
set of parallel tests are running. I am not sure whats the use case for running 
parallel test cases but dont see any reason for running the same set of test 
cases parallely. I guess if nothing clashed in HOME_DIR/hbase, nothing would 
here as well. In that case initial patch should be good enough.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238746#comment-14238746
 ] 

stack commented on HBASE-12645:
---

The links are broke because the test did not produce 'artifacts'.  Not sure if 
that your patch or not. Lets retry and see.

bq. ...but there will be a chance for it being overwritten if same set of 
parallel tests are running

How? Each test gets its own data dir that is named with a UUID?

bq. I am not sure whats the use case for running parallel test cases but dont 
see any reason for running the same set of test cases parallely.

We run tests in // to up our testing throughput.  Usually the same tests are 
NOT run in // but it can happen on the apache build box when the test suite for 
a few different branches of hbase happen to run concurrently.




 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238751#comment-14238751
 ] 

stack commented on HBASE-12645:
---

I think the issue happens only when the filesystem is the local filesystem.  In 
that case the dir we should pass in is the test dir (getDataTestDir); 
otherwise, if hdfs, home dir is fine.

Does getDataTestDirOnTestFS do what you want?





 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Enis Soztutar (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238791#comment-14238791
 ] 

Enis Soztutar commented on HBASE-12645:
---

yest, the correct way should be to use getDataTestDirOnTestFS() instead of 
createRootDir(). I guess, in test cases, we never launch a mini hbase cluster 
without a mini hdfs cluster, that is why createRootDir() using home dir never 
became a problem. If we want that functionality, we should change createRootDir 
to use getDataTestDirOnTestFS() instead. 

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239012#comment-14239012
 ] 

Varun Saxena commented on HBASE-12645:
--

bq. How? Each test gets its own data dir that is named with a UUID?
Every test case using starting MiniHBaseCluster will create a directory under 
root directory as under.
{code}
~/hbase/hbase-server/target/hbase_test$ ll
total 20
drwxrwxr-x  4 varun varun 4096 Dec  9 11:02 ./
drwxrwxr-x 13 varun varun 4096 Dec  9 11:02 ../
-rw-r--r--  1 varun varun7 Dec  9 11:02 hbase.version
drwxrwxrwx  2 varun varun 4096 Dec  9 11:02 testReadOldRootAndMetaEdits/
drwxrwxr-x  2 varun varun 4096 Dec  9 11:02 .tmp/

{code}

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-08 Thread Varun Saxena (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239026#comment-14239026
 ] 

Varun Saxena commented on HBASE-12645:
--

Above wasnt the right example for startup of MiniHBaseCluster. Some test cases 
like the one above are calling HBUT#createRootDir directly as well...Whereas 
some test cases use test-data directory and generate sub-directories with 
UUIDs'.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.002.patch, HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-07 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237164#comment-14237164
 ] 

Hadoop QA commented on HBASE-12645:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12685606/HBASE-12645.patch
  against master branch at commit bb15fd5fe0a89e647cd9cefa0ceae342578f0833.
  ATTACHMENT ID: 12685606

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/11981//console

This message is automatically generated.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
Assignee: Varun Saxena
Priority: Critical
 Fix For: 1.0.0, 2.0.0

 Attachments: HBASE-12645.patch


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config 

[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-05 Thread Sean Busbey (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236209#comment-14236209
 ] 

Sean Busbey commented on HBASE-12645:
-

I believe if you tell HBTU that you want a minicluster it runs things out of 
the running user's home dir on the minicluster. I don't recall where it 
defaults to if you stick to non-minicluster tests. It should be under mvn's 
project.build.directory, right? Maybe crossed wires between the two?

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
 Fix For: 1.0.0, 2.0.0


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-05 Thread Nick Dimiduk (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236225#comment-14236225
 ] 

Nick Dimiduk commented on HBASE-12645:
--

HTU#createRootDir calls #getDefaultRootDirPath, which has looked as the 
following since Feb 2012.

{noformat}
  public Path getDefaultRootDirPath() throws IOException {
FileSystem fs = FileSystem.get(this.conf);
return new Path(fs.makeQualified(fs.getHomeDirectory()),hbase);
  }
{noformat}

Maybe it's been broken all this time? Yes, It should be getting a path under 
the surefire working directory.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
 Fix For: 1.0.0, 2.0.0


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HBASE-12645) HBaseTestingUtility is using ${$HOME} for rootDir

2014-12-05 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236299#comment-14236299
 ] 

stack commented on HBASE-12645:
---

Above works for dfs cluster but not for local fs.

Yeah, we go out of our way in HTU to create a test dir per test and usually all 
test crud happens therein.  This is a violation in local fs case.  Good one.

 HBaseTestingUtility is using ${$HOME} for rootDir
 -

 Key: HBASE-12645
 URL: https://issues.apache.org/jira/browse/HBASE-12645
 Project: HBase
  Issue Type: Test
  Components: test
Affects Versions: 1.0.0
Reporter: Nick Dimiduk
 Fix For: 1.0.0, 2.0.0


 I noticed this while running tests on branch-1
 {noformat}
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec  
 FAILURE! - in 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits  Time 
 elapsed: 0.009 sec   ERROR!
 java.io.FileNotFoundException: Destination exists and is not a directory: 
 /homes/hortonnd/hbase
 at 
 org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
 at 
 org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
 at 
 org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
 at 
 org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
 {noformat}
 Either the testing utility has a regression or there's a config regression in 
 this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)