[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293462#comment-16293462 ] Hudson commented on HBASE-18838: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4232 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4232/]) HBASE-18838 Fix hadoop3 check-shaded-invariants (mdrob: rev 75f512bd717a14e0c7b7bbe5594de9270759706e) * (edit) hbase-rest/pom.xml * (edit) hbase-procedure/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/JSONMetricUtil.java * (edit) hbase-shell/pom.xml * (edit) hbase-it/pom.xml * (edit) pom.xml * (edit) hbase-backup/pom.xml * (edit) hbase-shaded/pom.xml * (edit) hbase-examples/pom.xml * (edit) hbase-mapreduce/pom.xml * (edit) hbase-replication/pom.xml * (edit) hbase-rsgroup/pom.xml * (edit) hbase-endpoint/pom.xml * (edit) hbase-client/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-testing-util/pom.xml > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch, HBASE-18838.v4.patch, HBASE-18838.v5.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293088#comment-16293088 ] Mike Drob commented on HBASE-18838: --- Pushed v5, thanks for reviews appy and stack! > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch, HBASE-18838.v4.patch, HBASE-18838.v5.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292209#comment-16292209
]
Hadoop QA commented on HBASE-18838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
54s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 8m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
22s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
22m 39s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0-beta1. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}159m
20s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}251m 18s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18838 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902209/HBASE-18838.v5.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile findbugs hbaseanti checkstyle |
| uname | Linux d56411bba0ce 3.13.0-133-generic #182-Ubuntu SMP Tue Sep 19
15:49:21 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / deba43b156 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java |
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292027#comment-16292027
]
Mike Drob commented on HBASE-18838:
---
license check is due to
{noformat}
01:32:07.715 HTTP request sent, awaiting response... 502 Proxy Error
01:32:07.811 2017-12-14 23:42:48 ERROR 502: Proxy Error.
01:32:07.811
01:32:07.811 Wget error 8 in fetching excludes file from url
https://builds.apache.org/job/HBase-Find-Flaky-Tests/lastSuccessfulBuild/artifact/excludes/.
Ignoring and proceeding.
{noformat}
I'll file a JIRA to better handle that later.
compile error is strange, not sure why that appeared suddenly, v5 fixes that
> shaded artifacts are incorrect when built against hadoop 3
> --
>
> Key: HBASE-18838
> URL: https://issues.apache.org/jira/browse/HBASE-18838
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0-alpha-3
>Reporter: Sean Busbey
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch,
> HBASE-18838.v3.patch, HBASE-18838.v4.patch, HBASE-18838.v5.patch
>
>
> Building master/branch-2 against the hadoop-3 profile results in
> check-invariants screaming about unrelocated dependencies. will list details
> in comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291915#comment-16291915
]
Hadoop QA commented on HBASE-18838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 7m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 12m
1s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
46s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 8m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
26s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
23s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 19m
55s{color} | {color:red} The patch causes 17 errors with Hadoop v3.0.0-beta1.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}128m 38s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
23s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}221m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18838 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902157/HBASE-18838.v4.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile findbugs hbaseanti checkstyle |
| uname | Linux eea637dd4035 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 4a1c3b4210 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| unit |
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291870#comment-16291870 ] stack commented on HBASE-18838: --- Interesting (excludes in submodules override parent exclude clause -- thats what I was seeing t). > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch, HBASE-18838.v4.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291710#comment-16291710 ] Appy commented on HBASE-18838: -- yeah. +1 on v4. The question of whether parent exclusions are overwritten or added remains mystery. I guess you don't have definite word on it either, except what you're observing. While uneasy, it doesn't warrant blocking patch. Since it's deps change, feel free to commit - since you've verified tarball - and after testing shaded-checks locally with hadoop3 & successful hadoopcheck from QA (will suggest adding single line change to hbase-common if you want to bring down pre-commit runtime from 4hr to 45 min) > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch, HBASE-18838.v4.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291685#comment-16291685
]
Hadoop QA commented on HBASE-18838:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 20m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
45s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 10m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
21s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
5s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 15m
40s{color} | {color:red} The patch causes 18 errors with Hadoop v3.0.0-beta1.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}171m
29s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}238m 30s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18838 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12902115/HBASE-18838.v3.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux 7ebe73e3b24f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / d5aefbd2c7 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/10456/testReport/ |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/10456/console |
| Powered by | Apache Yetus 0.6.0 http://yetus.apache.org |
This message was automatically generated.
> shaded artifacts are incorrect when built against hadoop 3
> --
>
> Key: HBASE-18838
> URL: https://issues.apache.org/jira/browse/HBASE-18838
> Project: HBase
> Issue Type: Bug
> Components: Client
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291427#comment-16291427
]
Appy commented on HBASE-18838:
--
bq. Nope. What's going on here is that maven exclusions in modules overwrite
the exclusions in the parent, they are not additive. So by removing the htrace
exclusion here, we get to use the full exclusion list from parent pom.
(╯°□°）╯
[~stack] mentioned same thing on HBASE-19349 [in this
comment|https://issues.apache.org/jira/browse/HBASE-19349?focusedCommentId=16282697=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16282697].
What about this
https://stackoverflow.com/questions/10734565/effect-of-overriding-exclusions-in-maven-dependency?
{quote}
bq. patch is adding lines with 0 indent.
will take a look and fix this.
{quote}
Sorry, git patch viewer CSS issue.
{quote}
bq. Since you introduced shaded.prefix
I was debating this, will go ahead and do it since you asked nicely.
{quote}
Gracias.
{quote}
bq. Add a separate exclusion, jic.
it doesn't show up in the maven dep tree, I think we're ok.
{quote}
had same weirdness up in HBASE-19349. Not in dep tree, but present in binary
tarball.
> shaded artifacts are incorrect when built against hadoop 3
> --
>
> Key: HBASE-18838
> URL: https://issues.apache.org/jira/browse/HBASE-18838
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0-alpha-3
>Reporter: Sean Busbey
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch,
> HBASE-18838.v3.patch
>
>
> Building master/branch-2 against the hadoop-3 profile results in
> check-invariants screaming about unrelocated dependencies. will list details
> in comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291343#comment-16291343 ] Mike Drob commented on HBASE-18838: --- bq. Guessing hadoop got rid of htrace-core from their deps too and that testing against hadoop3 passes locally Nope. What's going on here is that maven exclusions in modules overwrite the exclusions in the parent, they are not additive. So by removing the htrace exclusion here, we get to use the full exclusion list from parent pom. bq. patch is adding lines with 0 indent. will take a look and fix this. bq. Since you introduced shaded.prefix I was debating this, will go ahead and do it since you asked nicely. bq. Add a separate exclusion, jic. it doesn't show up in the maven dep tree, I think we're ok. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291318#comment-16291318
]
Appy commented on HBASE-18838:
--
bq. v3: Moving hadoop-minicluster to test scope fixes most everything else
(*)
Guessing hadoop got rid of htrace-core from their deps too and that testing
against hadoop3 passes locally (?)
Few minor things:
- patch is adding lines with 0 indent. (i)
- Since you introduced shaded.prefix ((y)), let's replace old redundancies with
it too.
{quote}
- servlet-api
+ javax.servlet-api
{quote}
Add a separate exclusion, jic.
Or verify that this doesn't add servlet-api jar to tars. Although not an issue
right now since we build against 2.7 for release (right(?)), might surface when
2.x goes away.
(festive time, enjoy the colors :) )
> shaded artifacts are incorrect when built against hadoop 3
> --
>
> Key: HBASE-18838
> URL: https://issues.apache.org/jira/browse/HBASE-18838
> Project: HBase
> Issue Type: Bug
> Components: Client
>Affects Versions: 2.0.0-alpha-3
>Reporter: Sean Busbey
>Assignee: Mike Drob
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch,
> HBASE-18838.v3.patch
>
>
> Building master/branch-2 against the hadoop-3 profile results in
> check-invariants screaming about unrelocated dependencies. will list details
> in comment.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291269#comment-16291269 ] Josh Elser commented on HBASE-18838: bq. have you done any testing with the shaded artifacts, and if so, can you take these for a spin? I don't have anything set up yet. No, I haven't done anything here yet. Sorry boss. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16291265#comment-16291265 ] Mike Drob commented on HBASE-18838: --- [~elserj] - have you done any testing with the shaded artifacts, and if so, can you take these for a spin? I don't have anything set up yet. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838-WIP.v2.patch, HBASE-18838.WIP.patch, > HBASE-18838.v3.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246875#comment-16246875 ] Appy commented on HBASE-18838: -- I guess it's safer (and easier) to just relocate everything? Let's just do that. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243002#comment-16243002 ] Appy commented on HBASE-18838: -- Or do [this|https://stackoverflow.com/questions/547805/exclude-all-transitive-dependencies-of-a-single-dependency/7556707#7556707] where hbase-mapreduce pulls in hbase-server and do dependency:analyze? Just ideas which i think might work, but not sure how far they'll get you. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243001#comment-16243001 ] Appy commented on HBASE-18838: -- Don't know for sure, but here's an idea. Remove all dependencies from hbase-mapreduce and do dependency:analyze to get the list of only the required ones? > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242797#comment-16242797 ] Mike Drob commented on HBASE-18838: --- Oh, hm... that makes sense. Will need to change how we approach this then. Do you know how we can test which artifacts we need to relocate v. which artifacts we can exclude? > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242783#comment-16242783 ] Appy commented on HBASE-18838: -- Not everything needs to be relocated, some needs to be excluded. For eg. com/sun/jersey. It's likely coming from hadoop because of missing exclusion list in hadoop-3 profile (compare to hadoop 2 profile) in [hbase-mapreduce/pom.xml|https://github.com/apache/hbase/blob/master/hbase-mapreduce/pom.xml#L428]. > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[ https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242752#comment-16242752 ] Appy commented on HBASE-18838: -- Is check invariant happy now? Otherwise, what's the error? > shaded artifacts are incorrect when built against hadoop 3 > -- > > Key: HBASE-18838 > URL: https://issues.apache.org/jira/browse/HBASE-18838 > Project: HBase > Issue Type: Bug > Components: Client >Affects Versions: 2.0.0-alpha-3 >Reporter: Sean Busbey >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18838.WIP.patch > > > Building master/branch-2 against the hadoop-3 profile results in > check-invariants screaming about unrelocated dependencies. will list details > in comment. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18838) shaded artifacts are incorrect when built against hadoop 3
[
https://issues.apache.org/jira/browse/HBASE-18838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242768#comment-16242768
]
Mike Drob commented on HBASE-18838:
---
error is a subset of the error that [~busbey] reported. I did what I could, but
I didn't know if we should be relocating {{javax}} or if we add it to the
acceptable list.
{noformat}
[ERROR] Found artifact with unexpected contents:
'/Users/mdrob/IdeaProjects/hbase/hbase-shaded/hbase-shaded-client/target/hbase-shaded-client-3.0.0-SNAPSHOT.jar'
Please check the following and either correct the build or update
the allowed list with reasoning.
krb5-template.conf
krb5_udp-template.conf
ccache.txt
keytab.txt
javax/
javax/servlet/
javax/servlet/annotation/
javax/servlet/annotation/HandlesTypes.class
javax/servlet/annotation/HttpConstraint.class
javax/servlet/annotation/HttpMethodConstraint.class
javax/servlet/annotation/MultipartConfig.class
javax/servlet/annotation/package.html
javax/servlet/annotation/ServletSecurity$EmptyRoleSemantic.class
javax/servlet/annotation/ServletSecurity$TransportGuarantee.class
javax/servlet/annotation/ServletSecurity.class
javax/servlet/annotation/WebFilter.class
javax/servlet/annotation/WebInitParam.class
javax/servlet/annotation/WebListener.class
javax/servlet/annotation/WebServlet.class
javax/servlet/AsyncContext.class
javax/servlet/AsyncEvent.class
javax/servlet/AsyncListener.class
javax/servlet/descriptor/
javax/servlet/descriptor/JspConfigDescriptor.class
javax/servlet/descriptor/JspPropertyGroupDescriptor.class
javax/servlet/descriptor/package.html
javax/servlet/descriptor/TaglibDescriptor.class
javax/servlet/DispatcherType.class
javax/servlet/Filter.class
javax/servlet/FilterChain.class
javax/servlet/FilterConfig.class
javax/servlet/FilterRegistration$Dynamic.class
javax/servlet/FilterRegistration.class
javax/servlet/GenericServlet.class
javax/servlet/http/
javax/servlet/http/Cookie.class
javax/servlet/http/HttpServlet.class
javax/servlet/http/HttpServletRequest.class
javax/servlet/http/HttpServletRequestWrapper.class
javax/servlet/http/HttpServletResponse.class
javax/servlet/http/HttpServletResponseWrapper.class
javax/servlet/http/HttpSession.class
javax/servlet/http/HttpSessionActivationListener.class
javax/servlet/http/HttpSessionAttributeListener.class
javax/servlet/http/HttpSessionBindingEvent.class
javax/servlet/http/HttpSessionBindingListener.class
javax/servlet/http/HttpSessionContext.class
javax/servlet/http/HttpSessionEvent.class
javax/servlet/http/HttpSessionIdListener.class
javax/servlet/http/HttpSessionListener.class
javax/servlet/http/HttpUpgradeHandler.class
javax/servlet/http/HttpUtils.class
javax/servlet/http/LocalStrings.properties
javax/servlet/http/LocalStrings_es.properties
javax/servlet/http/LocalStrings_fr.properties
javax/servlet/http/LocalStrings_ja.properties
javax/servlet/http/NoBodyOutputStream.class
javax/servlet/http/NoBodyResponse.class
javax/servlet/http/package.html
javax/servlet/http/Part.class
javax/servlet/http/WebConnection.class
javax/servlet/HttpConstraintElement.class
javax/servlet/HttpMethodConstraintElement.class
javax/servlet/LocalStrings.properties
javax/servlet/LocalStrings_fr.properties
javax/servlet/LocalStrings_ja.properties
javax/servlet/MultipartConfigElement.class
javax/servlet/package.html
javax/servlet/ReadListener.class
javax/servlet/Registration$Dynamic.class
javax/servlet/Registration.class
javax/servlet/RequestDispatcher.class
javax/servlet/Servlet.class
javax/servlet/ServletConfig.class
javax/servlet/ServletContainerInitializer.class
javax/servlet/ServletContext.class
javax/servlet/ServletContextAttributeEvent.class
javax/servlet/ServletContextAttributeListener.class
javax/servlet/ServletContextEvent.class
javax/servlet/ServletContextListener.class
javax/servlet/ServletException.class
javax/servlet/ServletInputStream.class
javax/servlet/ServletOutputStream.class
javax/servlet/ServletRegistration$Dynamic.class
javax/servlet/ServletRegistration.class
javax/servlet/ServletRequest.class
javax/servlet/ServletRequestAttributeEvent.class
javax/servlet/ServletRequestAttributeListener.class
javax/servlet/ServletRequestEvent.class
javax/servlet/ServletRequestListener.class
javax/servlet/ServletRequestWrapper.class
javax/servlet/ServletResponse.class
javax/servlet/ServletResponseWrapper.class
javax/servlet/ServletSecurityElement.class
javax/servlet/SessionCookieConfig.class
javax/servlet/SessionTrackingMode.class
javax/servlet/SingleThreadModel.class
javax/servlet/UnavailableException.class
