[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146529#comment-17146529 ] Nick Dimiduk commented on HBASE-21782: -- And there's a release note as well. Yes, I think this issue is will documented. Filed HBASE-24644 and posted a patch. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Labels: bulkload > Fix For: 3.0.0-alpha-1, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146276#comment-17146276 ] Duo Zhang commented on HBASE-21782: --- [~ndimiduk] Usually we should keep the deprecated classes for a whole major release, as what we describe in the ref guide. But here I define the IA.Public annotation on LoadIncrementalHFiles as a mistake, especially that it exposes several IA.Private classes, so I used a more aggressive policy to drop the class. IIRC I've gotten consensus from the community. We should add a special note on this in our ref guide too. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Labels: bulkload > Fix For: 3.0.0-alpha-1, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145885#comment-17145885 ] Nick Dimiduk commented on HBASE-21782: -- [~zhangduo] the deprecation comments from this change on {{o.a.h.h.tool.LoadIncrementalHFiles}} say "deprecated since 2.2.0, removal in 3.0.0", which does not meet our guideline re: deprecation for an entire major version. I believe we cannot drop this class until 4.0. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Labels: bulkload > Fix For: 3.0.0-alpha-1, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769979#comment-16769979 ] Hudson commented on HBASE-21782: Results for branch master [build #800 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/800/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/800//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/800//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/800//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768899#comment-16768899 ] Hudson commented on HBASE-21782: Results for branch master [build #797 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/797/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/797//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753403#comment-16753403 ] Hudson commented on HBASE-21782: Results for branch branch-2 [build #1640 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1640//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753383#comment-16753383 ] Hudson commented on HBASE-21782: Results for branch master [build #750 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/750/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/750//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753242#comment-16753242 ] stack commented on HBASE-21782: --- [~Apache9] Ok. Sounds good. I missed the RN. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753226#comment-16753226 ] Duo Zhang commented on HBASE-21782: --- The RN is already there. And I do not think this issue is an incompatible change? We just deprecated the old one, not remove it. I think the issue where we remove the LoadIncrementalHFiles will be the incompatible issue. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753192#comment-16753192 ] stack commented on HBASE-21782: --- Looks good. Mark as incompatible and needs a RN. +1. > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782-v1.patch, HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753100#comment-16753100 ] Hadoop QA commented on HBASE-21782: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 32s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 32s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 14s{color} | {color:green} hbase-server: The patch generated 0 new + 13 unchanged - 2 fixed = 13 total (was 15) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} hbase-mapreduce: The patch generated 0 new + 1 unchanged - 3 fixed = 1 total (was 4) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 36s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 52s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}127m 51s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 55s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 44s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}190m 1s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21782 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956446/HBASE-21782-v1.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux c32ad3f467e2 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality |
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752537#comment-16752537 ] Hadoop QA commented on HBASE-21782: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 41s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 49s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 38s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 19s{color} | {color:red} hbase-server: The patch generated 6 new + 13 unchanged - 2 fixed = 19 total (was 15) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 39s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 9m 51s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 40s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 40s{color} | {color:green} hbase-mapreduce in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 49s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}193m 47s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21782 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956365/HBASE-21782.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux cef63115e3a9 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master /
[jira] [Commented] (HBASE-21782) LoadIncrementalHFiles should not be IA.Public
[ https://issues.apache.org/jira/browse/HBASE-21782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752333#comment-16752333 ] Duo Zhang commented on HBASE-21782: --- Review board link: https://reviews.apache.org/r/69838/ > LoadIncrementalHFiles should not be IA.Public > - > > Key: HBASE-21782 > URL: https://issues.apache.org/jira/browse/HBASE-21782 > Project: HBase > Issue Type: Task > Components: mapreduce >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.2.0 > > Attachments: HBASE-21782.patch > > > It is an implementation class, so some of the methods which are only supposed > to be used by replication sink are also public to users. And it exposes > methods which take Table and Connection as parameter and inside the > implementation we assume that they are HTable and ConnectionImplementation, > which will be a pain when we want to replace the sync client implementation > with async client. > Here I think we should make the implementation class as > IA.LimitPrivate(TOOL), and introduce an interface for bulking hfiles > programmatically. -- This message was sent by Atlassian JIRA (v7.6.3#76005)