[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-01 Thread Andrew Purtell (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141499#comment-13141499
 ] 

Andrew Purtell commented on HBASE-3939:
---

That will collide with SecureRPCEngine (HBASE-2742)

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-01 Thread Andrew Purtell (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141503#comment-13141503
 ] 

Andrew Purtell commented on HBASE-3939:
---

This is a great example of why I've asked Gary to work on upstreaming the 
security changes full time. RPC changes in particular can be painful if made in 
a manner unaware of subclassing for SecureRPCEngine.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-01 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141757#comment-13141757
 ] 

Hadoop QA commented on HBASE-3939:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501870/3939-v5.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated -165 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 4 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/129//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/129//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/129//console

This message is automatically generated.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-01 Thread Ted Yu (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141777#comment-13141777
 ] 

Ted Yu commented on HBASE-3939:
---

>From https://builds.apache.org/job/PreCommit-HBASE-Build/129//testReport/
{code}
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[163,17]
 org.apache.hadoop.hbase.ipc.TestDelayedRpc.TestRpcImpl is not abstract and 
does not override abstract method 
getProtocolSignature(java.lang.String,long,int) in 
org.apache.hadoop.hbase.ipc.VersionedProtocol
[ERROR] 
[ERROR] 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java:[266,17]
 org.apache.hadoop.hbase.ipc.TestDelayedRpc.FaultyTestRpc is not abstract and 
does not override abstract method 
getProtocolSignature(java.lang.String,long,int) in 
org.apache.hadoop.hbase.ipc.VersionedProtocol
{code}

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143399#comment-13143399
 ] 

stack commented on HBASE-3939:
--

@Gary This patch ok w/ you?

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143415#comment-13143415
 ] 

stack commented on HBASE-3939:
--

We can't get to the new rpc message because 0.90.x clients don't get that far; 
they fail reading zookeeper master entry:

{code}
hbase(main):002:0> debug
Debug mode is ON

hbase(main):003:0> list 
TABLE   





ERROR: java.lang.IllegalArgumentException: Not a host:port pair: 
�12...@h-24-30.sfo.stumble.neth-24-30.sfo.stumble.net,60637,1320344107987
Backtrace: org/apache/hadoop/hbase/HServerAddress.java:60:in `'
   org/apache/hadoop/hbase/MasterAddressTracker.java:63:in 
`getMasterAddress'
   org/apache/hadoop/hbase/client/HConnectionManager.java:354:in 
`getMaster'
   org/apache/hadoop/hbase/client/HBaseAdmin.java:94:in `'
{code}

ServerName is in the way of our getting to rpc.

I tried making an HBaseAdmin instance but that don't work because on 
construction it tries to talk to Master (which is dumb):

{code}
hbase(main):008:0> a = HBaseAdmin.new(c)
NativeException: java.lang.IllegalArgumentException: Not a host:port pair: 
�12...@h-24-30.sfo.stumble.neth-24-30.sfo.stumble.net,60637,1320344107987
{code}

Can't create an HTable.

Reverting the ServerName change is not an option.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143468#comment-13143468
 ] 

Hadoop QA commented on HBASE-3939:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502190/3939-v6.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/161//console

This message is automatically generated.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread Gary Helmling (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143591#comment-13143591
 ] 

Gary Helmling commented on HBASE-3939:
--

Would be easier to review if the latest patch was in review board.

Here are comments from what I see:

In {{HBaseServer}}:
# In {{setupResponse()}} we take a {{Status}} instance (which is good), but it 
doesn't get passed back through to the client.  If we're modifying the wire 
protocol to pass RPC version, I think we should also take advantage of the 
change to serialize {{Status}} back to the client.  This allows the client to 
differentiate between fatal errors (authentication error, or bad rpc version) 
which should kill the connection, and request-specific errors.  By the way, 
adding {{Status}} here allows me to remove it from the HBASE-2742 patch, which 
is great!

In {{Invocation}}:
# In the constructor:
{code}
rpcVersion = WritableRpcEngine.writableRpcVersion;
{code}
This binds {{Invocation}} unnecessarily to {{WritableRpcEngine}}.  We've 
diverged a little from Hadoop RPC by making {{Invocation}} a top-level class, 
allowing it to be shared between RPC engine implementations, so this would 
undermine that.  Since {{rpcVersion}} only seems to relate to {{Invocation}} 
serialization, why not just define {{RPC_VERSION}} as a static final constant 
on {{Invocation}}?  Or alternately, couldn't we just make {{Invocation}} 
implement {{VersionedWritable}} and let that handle the check for us?


Other than that, this patch looks fine to me.  I've applied it together with 
the HBASE-2742 patch and run through a few of the tests, and so far seems to 
work fine.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143634#comment-13143634
 ] 

stack commented on HBASE-3939:
--

Sorry about not putting it up in rb.  Will do next time.

On setupResponse above, there is a byte which says whether an error or not (or 
error and length of the rpc provided).  Passing the Status, I don't see FATAL 
being used.  So why introduce it?  Just so its in place when we want to use it 
later?

If this is so, see what you think of the following patch (it puts Status into 
the back and forth though it does not really exploit it -- hadoop seems to have 
come to rely on it but our stuff is old in this regard -- and it does your 
suggestion around VersionedWritable too).

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143640#comment-13143640
 ] 

stack commented on HBASE-3939:
--

Thanks for the help with this Gary.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143658#comment-13143658
 ] 

Hadoop QA commented on HBASE-3939:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502230/3939-v7.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated -164 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 48 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
  org.apache.hadoop.hbase.client.TestAdmin
  org.apache.hadoop.hbase.TestGlobalMemStoreSize

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/165//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/165//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/165//console

This message is automatically generated.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-03 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143679#comment-13143679
 ] 

Hadoop QA commented on HBASE-3939:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502241/3939-v8.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated -164 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 49 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.master.TestMasterFailover

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/167//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/167//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/167//console

This message is automatically generated.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-04 Thread jirapos...@reviews.apache.org (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144569#comment-13144569
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2718/
---

(Updated 2011-11-05 04:26:43.914383)


Review request for hbase.


Changes
---

Fix hbase issue number.


Summary (updated)
---

Versions of Gary suggestions


This addresses bug hbase-3939.
https://issues.apache.org/jira/browse/hbase-3939


Diffs
-

  
src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
fce5490 
  src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
2fa4d6f 
  
src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
6f88357 
  src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 6fcb771 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1365411 
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 4a8918a 
  src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java e60f970 
  src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java fb07374 
  src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 60a9248 
  src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 8de2314 
  src/main/java/org/apache/hadoop/hbase/master/HMaster.java 0d0e4c5 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 12bd33e 
  src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java 888f428 
  
src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 e5b6a78 

Diff: https://reviews.apache.org/r/2718/diff


Testing
---


Thanks,

Michael



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-05 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144826#comment-13144826
 ] 

Hadoop QA commented on HBASE-3939:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502575/3939-v9.txt
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

-1 javadoc.  The javadoc tool appears to have generated -164 warning 
messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 51 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   
org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
  org.apache.hadoop.hbase.client.TestAdmin
  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/188//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/188//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/188//console

This message is automatically generated.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-06 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145167#comment-13145167
 ] 

Hudson commented on HBASE-3939:
---

Integrated in HBase-0.92 #115 (See 
[https://builds.apache.org/job/HBase-0.92/115/])
HBASE-3939 Some crossports of Hadoop IPC fixes
HBASE-3939 Some crossports of Hadoop IPC fixes

stack : 
Files : 
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/Status.java

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* 
/hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java


> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-11-06 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145189#comment-13145189
 ] 

Hudson commented on HBASE-3939:
---

Integrated in HBase-TRUNK #2416 (See 
[https://builds.apache.org/job/HBase-TRUNK/2416/])
HBASE-3939 Some crossports of Hadoop IPC fixes

stack : 
Files : 
* /hbase/trunk/CHANGES.txt
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/Status.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java


> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2012-01-04 Thread Benoit Sigoure (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179450#comment-13179450
 ] 

Benoit Sigoure commented on HBASE-3939:
---

On 04/Nov/11 00:07, Stack wrote:
bq. So why introduce it? Just so its in place when we want to use it later?

Anyone knows the answer?

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2012-01-04 Thread stack (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179551#comment-13179551
 ] 

stack commented on HBASE-3939:
--

@Benoît Is this a blocker for you?

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2012-01-13 Thread Benoit Sigoure (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186128#comment-13186128
 ] 

Benoit Sigoure commented on HBASE-3939:
---

No, I'm just trying to make sense of what's doing what.  I don't understand 
what this Status is intended for, it's just unused and wasting 4 bytes on every 
RPC.  The ProtocolSignature thing is also unclear to me.  It doesn't seem to be 
used either and also adds an extra 4 bytes per RPC.  To top things up nicely, 
there is also an extra 8 bytes added per RPC for the clientVersion that this is 
always set to zero because, as a comment in the code says, "VersionedProtocol 
is exempted from version check".

I don't understand what's the point of any of this stuff, so I thought maybe 
someone could shed some light on the reasons why things are the way they are.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939-v4.txt, 3939-v5.txt, 
> 3939-v6.txt, 3939-v7.txt, 3939-v8.txt, 3939-v9.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-09-10 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102122#comment-13102122
 ] 

stack commented on HBASE-3939:
--

@Ted If you update this patch -- i.e. we have VersionedProtocol pulled in 
already -- I'll do the testing.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-01 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042510#comment-13042510
 ] 

Todd Lipcon commented on HBASE-3939:


You currently have the server-side check all commented out.

I think you should do the following:
- refactor the code that grabs the VERSION constant into a static function 
somewhere
- call that new function from Invocation(Method,Object[])
- also call that new function from the block of code starting with "// Verify 
rpc version"
- remove all of the code referencing clientMethodsHash
- we need to bump the HBaseServer.CURRENT_VERSION constant as well.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-02 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042841#comment-13042841
 ] 

Ted Yu commented on HBASE-3939:
---

VersionedProtocol has changed in hadoop-common.
getProtocolVersion() is now Deprecated.
getProtocolSignature() isn't in cdh3u0 or hadoop-core-0.20-append jar hbase 
trunk is using.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-02 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042873#comment-13042873
 ] 

Todd Lipcon commented on HBASE-3939:


Do we still depend on hadoop-common's VersionedProtocol? I thought we'd 
copy-paste forked all of the IPC code by now.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-02 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042875#comment-13042875
 ] 

Ted Yu commented on HBASE-3939:
---

We still depend on hadoop-common's VersionedProtocol:
{code}
import org.apache.hadoop.ipc.VersionedProtocol;
{code}

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-02 Thread Todd Lipcon (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042882#comment-13042882
 ] 

Todd Lipcon commented on HBASE-3939:


oh... let's stop doing that :)

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-19 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051704#comment-13051704
 ] 

Ted Yu commented on HBASE-3939:
---

Tests pass.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053920#comment-13053920
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/
---

Review request for hbase and Todd Lipcon.


Summary
---

A few fixes from Hadoop IPC that we should probably cross-port into our copy:

* HADOOP-7227: remove the protocol version check at call time
* HADOOP-7146: fix a socket leak in server
* HADOOP-7121: fix behavior when response serialization throws an exception
* HADOOP-7346: send back nicer error response when client is using an out 
of date IPC version


This addresses bug HBASE-3939.
https://issues.apache.org/jira/browse/HBASE-3939


Diffs
-

  
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
  
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 1137280 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
  
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 

Diff: https://reviews.apache.org/r/951/diff


Testing
---

Test suite passed.


Thanks,

Ted



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054035#comment-13054035
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review899
---

Ship it!


I guess it's fine if it's just a crossport, maybe clean the white spaces?

- Jean-Daniel


On 2011-06-23 15:30:03, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-23 15:30:03)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054083#comment-13054083
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/
---

(Updated 2011-06-23 20:31:21.703117)


Review request for hbase and Todd Lipcon.


Changes
---

Removed white spaces.


Summary
---

A few fixes from Hadoop IPC that we should probably cross-port into our copy:

* HADOOP-7227: remove the protocol version check at call time
* HADOOP-7146: fix a socket leak in server
* HADOOP-7121: fix behavior when response serialization throws an exception
* HADOOP-7346: send back nicer error response when client is using an out 
of date IPC version


This addresses bug HBASE-3939.
https://issues.apache.org/jira/browse/HBASE-3939


Diffs (updated)
-

  
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
  
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 1137280 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
  
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 

Diff: https://reviews.apache.org/r/951/diff


Testing
---

Test suite passed.


Thanks,

Ted



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054084#comment-13054084
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review900
---


What kind of testing did you do with this? We should test old->new RPC to make 
sure the error messages come out OK


/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java


we should check this against old versions of HBase -- the constants I put 
in this code are hadoop RPC version numbers, which might not correspond to 
hbase IPC version numbers.

ie we should start a trunk server, then try to connect to it from an 0.90 
shell, 0.89 shell, 0.20 shell, and make sure it works correctly.


- Todd


On 2011-06-23 20:31:21, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-23 20:31:21)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054090#comment-13054090
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review901
---



/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java


I checked CURRENT_VERSION field back to 0.20 codebase.
It was 3 back then.
I am not sure which baseline corresponded to version 2.


- Ted


On 2011-06-23 20:31:21, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-23 20:31:21)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054091#comment-13054091
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--



bq.  On 2011-06-23 20:51:31, Ted Yu wrote:
bq.  > /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java, line 1026
bq.  > 
bq.  >
bq.  > I checked CURRENT_VERSION field back to 0.20 codebase.
bq.  > It was 3 back then.
bq.  > I am not sure which baseline corresponded to version 2.

did you try starting a server with trunk and connecting with an older version? 
It should spit out a nice error message instead of an EOFException. If you can 
confirm that, then I'll be +1.


- Todd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review901
---


On 2011-06-23 20:31:21, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-23 20:31:21)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-23 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054131#comment-13054131
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review903
---



/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java


I tried to start cluster with hbase-0.91.0-SNAPSHOT
First time I encountered conversion failure (HBASE-451)
I removed hdfs:/hbase and started again.

Table creation request from 0.90.4 client got:

java.lang.IllegalArgumentException: Not a host:port pair: 
ciq.com,6,1308866059399


- Ted


On 2011-06-23 20:31:21, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-23 20:31:21)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1137362 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-24 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054478#comment-13054478
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/
---

(Updated 2011-06-24 14:42:47.298437)


Review request for hbase and Todd Lipcon.


Changes
---

Removed clientVersion check where clientVersion is less than 3.
Those clients would encounter the following exception connecting to zookeeper:

java.lang.IllegalArgumentException: Not a host:port pair: 
ciq.com,6,1308866059399


Summary
---

A few fixes from Hadoop IPC that we should probably cross-port into our copy:

* HADOOP-7227: remove the protocol version check at call time
* HADOOP-7146: fix a socket leak in server
* HADOOP-7121: fix behavior when response serialization throws an exception
* HADOOP-7346: send back nicer error response when client is using an out 
of date IPC version


This addresses bug HBASE-3939.
https://issues.apache.org/jira/browse/HBASE-3939


Diffs (updated)
-

  
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
  
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
  /src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 1137280 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1139326 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
  
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 

Diff: https://reviews.apache.org/r/951/diff


Testing
---

Test suite passed.


Thanks,

Ted



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-28 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056891#comment-13056891
 ] 

stack commented on HBASE-3939:
--

The 'java.lang.IllegalArgumentException: Not a host:port pair: 
abc.com,6,1308866059399' is probably because of move away from HSA toward 
ServerName.  Do you have the stack trace?  Its probably preventing the nice 
message Todd talks about above from popping up in the client.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-06-28 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056896#comment-13056896
 ] 

Ted Yu commented on HBASE-3939:
---

@Stack, I think you're right.

I don't have stack trace.
Currently we don't have a cluster running TRUNK hbase.

> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-07-09 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062395#comment-13062395
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review1014
---


Request for review.

- Ted


On 2011-06-24 14:42:47, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-24 14:42:47)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1139326 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-3939) Some crossports of Hadoop IPC fixes

2011-07-09 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062595#comment-13062595
 ] 

jirapos...@reviews.apache.org commented on HBASE-3939:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/951/#review1018
---


Needs unit tests before any +1:

- Confirm protocol signature (new feature) match and mismatch is handled 
correctly.

- Confirm this sends back nicer error responses when client is using an out of 
date IPC version

- Andrew


On 2011-06-24 14:42:47, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/951/
bq.  ---
bq.  
bq.  (Updated 2011-06-24 14:42:47)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  A few fixes from Hadoop IPC that we should probably cross-port into our 
copy:
bq.  
bq.  * HADOOP-7227: remove the protocol version check at call time
bq.  * HADOOP-7146: fix a socket leak in server
bq.  * HADOOP-7121: fix behavior when response serialization throws an 
exception
bq.  * HADOOP-7346: send back nicer error response when client is using an 
out of date IPC version
bq.  
bq.  
bq.  This addresses bug HBASE-3939.
bq.  https://issues.apache.org/jira/browse/HBASE-3939
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateProtocol.java 
1137262 
bq.
/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseEndpointCoprocessor.java 
1137262 
bq./src/main/java/org/apache/hadoop/hbase/ipc/CoprocessorProtocol.java 
1137280 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java 1139326 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterRegionInterface.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/ipc/Status.java PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java 
1134732 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1134732 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1134732 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/TestServerCustomProtocol.java
 1137280 
bq.  
bq.  Diff: https://reviews.apache.org/r/951/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Test suite passed.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



> Some crossports of Hadoop IPC fixes
> ---
>
> Key: HBASE-3939
> URL: https://issues.apache.org/jira/browse/HBASE-3939
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.92.0
>Reporter: Todd Lipcon
>Assignee: Ted Yu
> Fix For: 0.92.0
>
> Attachments: 3939-v2.txt, 3939-v3.txt, 3939.txt
>
>
> A few fixes from Hadoop IPC that we should probably cross-port into our copy:
> - HADOOP-7227: remove the protocol version check at call time
> - HADOOP-7146: fix a socket leak in server
> - HADOOP-7121: fix behavior when response serialization throws an exception
> - HADOOP-7346: send back nicer error response when client is using an out of 
> date IPC version

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira