subject:"\[jira\] \[Commented\] \(HBASE\-4213\) Support for fault tolerant, instant schema updates with out master's intervention \(i.e with out enable\/disable and bulk assign\/unassign\) through ZK."

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2012-04-07 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249195#comment-13249195
 ] 

Hudson commented on HBASE-4213:
---

Integrated in HBase-0.94-security #8 (See 
[https://builds.apache.org/job/HBase-0.94-security/8/])
HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 
1310017)

 Result = SUCCESS
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/branches/0.94/src/main/resources/hbase-default.xml
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see:

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2012-04-05 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247572#comment-13247572
 ] 

Hudson commented on HBASE-4213:
---

Integrated in HBase-0.94 #89 (See 
[https://builds.apache.org/job/HBase-0.94/89/])
HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 
1310017)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/branches/0.94/src/main/resources/hbase-default.xml
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2012-04-05 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247582#comment-13247582
 ] 

Hudson commented on HBASE-4213:
---

Integrated in HBase-TRUNK #2714 (See 
[https://builds.apache.org/job/HBase-TRUNK/2714/])
HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 
1310012)

 Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2012-04-05 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13247671#comment-13247671
 ] 

Hudson commented on HBASE-4213:
---

Integrated in HBase-TRUNK-security #158 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/158/])
HBASE-5715 Revert 'Instant schema alter' for now, HBASE-4213 (Revision 
1310012)

 Result = FAILURE
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2012-04-04 Thread stack (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246782#comment-13246782
 ] 

stack commented on HBASE-4213:
--

Reverted over in HBASE-5715

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154297#comment-13154297
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504508/4213-trunk-v7.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 18 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated -162 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 66 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/318//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/318//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/318//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt,
4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt,
4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch, schema-update.png

This Jira is a slight variation in approach to what is being done as part of
https://issues.apache.org/jira/browse/HBASE-1730
Support instant schema updates such as Modify Table, Add Column, Modify
Column operations:
1. With out enable/disabling the table.
2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154300#comment-13154300
 ] 

Ted Yu commented on HBASE-4213:
---

3 out of the 4 test failures were due to 'Too many open files'.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154306#comment-13154306
 ] 

Ted Yu commented on HBASE-4213:
---

Integrated to TRUNK.

Thanks for the patch Subbu.

Thanks for the review, Lars, Todd and Andy.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Lars Hofhansl (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154328#comment-13154328
 ] 

Lars Hofhansl commented on HBASE-4213:
--

Awesome. Thanks for all the work on this Subbu and Ted. This will be incredibly 
useful! (Once online schema changes stabilize in general)

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154333#comment-13154333
 ] 

Ted Yu commented on HBASE-4213:
---

Compared to the implementation from HBASE-1730, Subbu's code would take less 
amount of effort to stabilize.
Thanks for the support, Lars.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Hudson (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154396#comment-13154396
 ] 

Hudson commented on HBASE-4213:
---

Integrated in HBase-TRUNK #2468 (See 
[https://builds.apache.org/job/HBase-TRUNK/2468/])
HBASE-4213 Support for fault tolerant, instant schema updates with out 
master's intervention through ZK

tedyu : 
Files : 
* /hbase/trunk/pom.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
* /hbase/trunk/src/main/resources/hbase-default.xml
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java
* 
/hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread Hadoop QA (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154417#comment-13154417
 ] 

Hadoop QA commented on HBASE-4213:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12504535/4213.addendum
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/320//console

This message is automatically generated.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread stack (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154503#comment-13154503
 ] 

stack commented on HBASE-4213:
--

Want to do the test fix in another issue Ted and Subbu?

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-21 Thread ramkrishna.s.vasudevan (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154882#comment-13154882
 ] 

ramkrishna.s.vasudevan commented on HBASE-4213:
---

@Ted
One very small comment.  Javadoc for MasterSchemaChangeTracker is not found. 
Can be added as part of some related fix. 

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.addendum, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-19 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153451#comment-13153451
 ] 

Ted Yu commented on HBASE-4213:
---

TestInstantSchemaChange failures were due to 'Too many open files'.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk-v6.txt, 
 4213-trunk-v7.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153132#comment-13153132
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504247/4213-trunk-v5.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 18 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 68 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.client.TestInstantSchemaChange

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/296//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/296//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/296//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt,
4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk.txt,
4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153140#comment-13153140
 ] 

Ted Yu commented on HBASE-4213:
---

The test failures were caused by 'Too many open files'.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Lars Hofhansl (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153203#comment-13153203
 ] 

Lars Hofhansl commented on HBASE-4213:
--

Seems like this is getting ready for check-in. The most important part to have 
confidence in is whether this change will impact stability even when the 
feature is switched off.
What do you think Ted?


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153220#comment-13153220
 ] 

Ted Yu commented on HBASE-4213:
---

I have tested this feature on dev cluster and observed satisfactory behavior.
For a 75 region table with 280K rows, instant schema update took 2.2 seconds.

HBASE-4815 is introducing a config parameter which would govern online 
(current) and instant schema changes.

If schema change is totally disabled, impact on stability is minimal.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153233#comment-13153233
 ] 

Ted Yu commented on HBASE-4213:
---

See schema-update.png for screen snapshot.

Note, since the schema change completed so fast, I wasn't able to try to 
trigger region splitting.
Also, in CompactSplitThread.requestSplit(final HRegion r, byte[] midKey), call 
to waitForInflightSchemaChange() has been added.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk-v5.txt, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch, schema-update.png


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153235#comment-13153235
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-18 23:39:40.651341)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
---

Latest patch with updated tests.


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


Diffs (updated)
-

  /pom.xml 1203789 
  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202941 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1203441 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202941 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  
/src/test/java/org/apache/hadoop/hbase/client/InstantSchemaChangeTestBase.java 
PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeSplit.java 
PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch,

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153315#comment-13153315
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504296/4213-trunk-v6.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 18 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 66 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/297//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/297//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/297//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-18 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13153361#comment-13153361
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504313/4213-trunk-v7.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 18 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 66 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.client.TestInstantSchemaChangeFailover
org.apache.hadoop.hbase.client.TestShell
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.client.TestInstantSchemaChangeSplit

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/302//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/302//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/302//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-17 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152606#comment-13152606
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504154/4213-trunk-v3.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 60 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.client.TestShell
org.apache.hadoop.hbase.client.TestInstantSchemaChange

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/287//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/287//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/287//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt,
4213-trunk-v3.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-17 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13152707#comment-13152707
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504174/4213-trunk-v4.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 64 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.util.TestFSUtils
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.client.TestShell

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/289//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/289//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/289//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt,
4213-trunk-v3.txt, 4213-trunk-v4.txt, 4213-trunk.txt, 4213-v9.txt, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151433#comment-13151433
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-16 19:12:03.308667)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
---

Patch addresses Lars' comments


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


Diffs (updated)
-

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151554#comment-13151554
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503931/4213-0.92.v4
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 58 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/267//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/267//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/267//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151581#comment-13151581
 ] 

Ted Yu commented on HBASE-4213:
---

TestDistributedLogSplitting#testWorkerAbort passed on my MacBook.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151583#comment-13151583
 ] 

Ted Yu commented on HBASE-4213:
---

HBASE-4370 has mostly been covered by latest patch.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151654#comment-13151654
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review3307
---


Looks good to me now (I admit, I only browsed over the new tracker code).


/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
https://reviews.apache.org/r/1786/#comment7392

This is no longer the case.



/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment7394

It also might not return the current list of all online regions, as 
onlineRegions is changed by other callers (like the one above) without a lock. 
Is that a problem here?



/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment7395

Super minor nit: Make this string just once?


- Lars


On 2011-11-16 19:12:03, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-11-16 19:12:03)
bq.  
bq.  
bq.  Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
bq./src/main/resources/hbase-default.xml 1202381 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
bq./src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
1202381 
bq.
/src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 
bq.  
bq.  Diff: https://reviews.apache.org/r/1786/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151681#comment-13151681
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-17 00:28:04.519410)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
---

Patch addresses Lars' latest comments (except for the last comment about String 
where table changes in each iteration)


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


Diffs (updated)
-

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202941 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202941 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk.txt, 
 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch,

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151707#comment-13151707
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503966/4213-trunk.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 58 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.master.TestDistributedLogSplitting

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/271//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/271//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/271//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk.txt,
4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151727#comment-13151727
 ] 

Ted Yu commented on HBASE-4213:
---

I saw some 'Too many open files' error:
https://builds.apache.org/job/PreCommit-HBASE-Build/271//testReport/org.apache.hadoop.hbase.client/TestInstantSchemaChange/testInstantSchemaChangeExclusions/

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk.txt, 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151774#comment-13151774
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504009/4213-trunk-v2.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 59 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
org.apache.hadoop.hbase.client.TestInstantSchemaChange

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/275//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/275//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/275//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.94.0

Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt,
4213-trunk.txt, 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Lars Hofhansl (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151858#comment-13151858
 ] 

Lars Hofhansl commented on HBASE-4213:
--

Failure in TestInstantSchemaChange is suspicious. :)


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk.txt, 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-16 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151864#comment-13151864
 ] 

Ted Yu commented on HBASE-4213:
---

From 
https://builds.apache.org/job/PreCommit-HBASE-Build/275//testReport/org.apache.hadoop.hbase.client/TestInstantSchemaChange/testInstantSchemaJanitor/:
{code}
java.net.SocketException: Too many open files
at sun.nio.ch.Net.socket0(Native Method)
at sun.nio.ch.Net.socket(Net.java:97)
at sun.nio.ch.SocketChannelImpl.init(SocketChannelImpl.java:84)
{code}
The resource usage for tests in TestInstantSchemaChange is high.

I was able to run TestInstantSchemaChange successfully for several times on 
MacBook.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.94.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 4213-0.92.v4, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-trunk-v2.txt, 
 4213-trunk.txt, 4213-v9.txt, 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150820#comment-13150820
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12503785/4213-0.92.v2
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 58 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/258//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/258//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/258//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-0.92.txt, 4213-0.92.v2,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150854#comment-13150854
 ] 

Ted Yu commented on HBASE-4213:
---

It turns out that 4213-0.92.v2 can be cleanly applied to TRUNK as well.
{code}
  635  mt 
-Dtest=TestInstantSchemaChange#testConcurrentInstantSchemaChangeAndSplit 
  636  mt -Dtest=TestInstantSchemaChange#testInstantSchemaJanitor 
  637  mt -Dtest=TestInstantSchemaChange#testInstantSchemaChangeExclusions 
  638  mt 
-Dtest=TestInstantSchemaChange#testInstantSchemaChangeWhileRSOpenRegionFailure
{code}
The above tests passed individually on MacBook.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150886#comment-13150886
 ] 

Ted Yu commented on HBASE-4213:
---

https://reviews.apache.org/r/1786/ has been updated with 4213-0.92.v2

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150887#comment-13150887
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-15 23:28:55.604278)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
---

Updated with 4213-0.92.v2


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


This addresses bug HBASE-4213.
https://issues.apache.org/jira/browse/HBASE-4213


Diffs (updated)
-

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch,

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13150921#comment-13150921
 ] 

Ted Yu commented on HBASE-4213:
---

I tried the following commands for table t1 which had one column f1 and they 
worked:
{code}
alter 't1', { NAME = 'f1', VERSIONS = 1 }
alter 't1', { NAME = 'f2', VERSIONS = 1 }
{code}

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151012#comment-13151012
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review3293
---


Late to this review...
Awesome feature. Thanks for doing this Subbu!

Looks good to me in general.

Minor comments inline.

As a general comment, I think it would be better if we could drive from the ZK 
notifications, rather than doing all this sleeping in a loop waiting for some 
other action to complete by rechecking the ZK node; would probably require a 
lot of refactoring to make the code event based.



/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
https://reviews.apache.org/r/1786/#comment7373

whitespace



/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment7372

whitespace... here and below



/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment7366

How do you know for sure that while we waited for inflightSplits no new 
round of load balancing has started?
Or maybe that is not a problem?



/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment7369

Maybe put this method on schema tracker?
Similar code is found CompactSplitThread.java.

Also, can we use the ZK notifications here instead of waiting in a loop?




/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment7368

We're not added the year line anymore.



/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment7371

year line...



/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
https://reviews.apache.org/r/1786/#comment7370

Year line ...



/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
https://reviews.apache.org/r/1786/#comment7367

I think we're not putting this line anymore.


- Lars


On 2011-11-15 23:28:55, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-11-15 23:28:55)
bq.  
bq.  
bq.  Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  This addresses bug HBASE-4213.
bq.  https://issues.apache.org/jira/browse/HBASE-4213
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1202381 
bq./src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202381 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
bq.

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151018#comment-13151018
 ] 

Ted Yu commented on HBASE-4213:
---

@Lars:
Master would check whether schema change is in progress before running balancer:
{code}
+  if (schemaChangeTracker.isSchemaChangeInProgress()) {
+LOG.debug(Schema change operation is in progress. Waiting for  +
+it to complete before running the load balancer.);
+return false;
+  }
+  loadBalancerRunning = true;
{code}
In handleInstantSchemaChanges() where you asked the question:
{code}
waitForLoadBalancerToComplete(status);
waitForInflightSplit(regions, status);
{code}
See also testLoadBalancerBlocksDuringSchemaChangeRequests()

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Lars Hofhansl (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151020#comment-13151020
 ] 

Lars Hofhansl commented on HBASE-4213:
--

@Ted: Hmm... But we haven't started the schema change at that point, right? So 
the master would not know about the intention.


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151042#comment-13151042
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-16 06:05:02.324776)


Review request for hbase, Todd Lipcon, Andrew Purtell, and Subbu Iyer.


Changes
---

New patch uses master.synchronousBalanceSwitch() to ensure that balancer is 
switched off during instant schema change

TestInstantSchemaChange#testLoadBalancerBlocksDuringSchemaChangeRequests passed.


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


Diffs (updated)
-

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6,

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread jirapos...@reviews.apache.org (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151049#comment-13151049
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-11-16 06:12:33.670038)


Review request for Todd Lipcon, Andrew Purtell and Subbu Iyer.


Changes
---

New patch remembers prevBalanceSwitch and uses it to restore load balancer 
switch.


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


Diffs (updated)
-

  /src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1202381 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1202523 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1202381 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1202381 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1202381 
  /src/main/resources/hbase-default.xml 1202381 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChangeFailover.java
 PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1202381 
  /src/test/java/org/apache/hadoop/hbase/util/MockRegionServerServices.java 
1202381 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-15 Thread Lars Hofhansl (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13151051#comment-13151051
 ] 

Lars Hofhansl commented on HBASE-4213:
--

Thanks Ted.

{code}
protected void handleInstantSchemaChanges(ListHRegionInfo regions) {
  ...
  try {
...
master.synchronousBalanceSwitch(false);
waitForInflightSplit(regions, status);
...
  } finally {
master.synchronousBalanceSwitch(true); 
  }
{code}

Since balancing might be disabled for other reasons, should probably remember 
the old balancer state and restore that in the finally block.


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 4213-0.92.v2, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-07 Thread Subbu M Iyer (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145961#comment-13145961
 ] 

Subbu M Iyer commented on HBASE-4213:
-

- New patch to address concurrent schema alter and region splits.
- Added two new tests to test the concurrent split + alter scenarios.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch, 
 4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-07 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13145973#comment-13145973
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment

http://issues.apache.org/jira/secure/attachment/12502847/4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

-1 patch. The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/215//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-0.92.txt,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-Nov072011-Patch_to_support_concurrent_split_and_alter__.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-05 Thread Subbu M Iyer (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144773#comment-13144773
 ] 

Subbu M Iyer commented on HBASE-4213:
-

JD,

Fixed the NPE that is causing the RS to die. All tests pass and don't see this 
exception.

Would be great if you can give it one more try with your concurrent alter + 
split scenario. I am also adding a test case for the concurrent split + alter 
scenario and I am validating the same.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Instant_Schema_change_through_ZK.patch, 
 4213-Nov-2-2011_patch_.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-05 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13144778#comment-13144778
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment

http://issues.apache.org/jira/secure/attachment/12502604/4213-Fixed_NPE_in_RS_during_alter_.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

-1 patch. The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/187//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-0.92.txt,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Fixed_NPE_in_RS_during_alter_.patch,
4213-Instant_Schema_change_through_ZK.patch, 4213-Nov-2-2011_patch_.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-03 Thread Jean-Daniel Cryans (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143401#comment-13143401
 ] 

Jean-Daniel Cryans commented on HBASE-4213:
---

The latest patch doesn't apply to 0.92, would it be possible to have another 
version for it? Thanks.

Also looking over the patch names, it would sure be nice if they followed some 
sort of convention.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Instant_Schema_change_through_ZK.patch, 
 4213-Nov-2-2011_patch_.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-03 Thread Hadoop QA (Commented) (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143546#comment-13143546
]

Hadoop QA commented on HBASE-4213:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12502207/4213-0.92.txt
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 12 new or modified tests.

-1 javadoc. The javadoc tool appears to have generated -161 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 52 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.thrift2.TestThriftHBaseServiceHandler
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.util.TestFSUtils
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.client.TestInstantSchemaChangeFailover
org.apache.hadoop.hbase.master.TestMasterFailover

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/162//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/162//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/162//console

This message is automatically generated.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-0.92.txt,
4213-101211-Support_instant_schema_changes_through_ZK.patch,
4213-102511.patch, 4213-Instant_Schema_change_through_ZK.patch,
4213-Nov-2-2011_patch_.patch,
4213-V10-Support_instant_schema_changes_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-03 Thread Jean-Daniel Cryans (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13143605#comment-13143605
 ] 

Jean-Daniel Cryans commented on HBASE-4213:
---

First time I tried it on my cluster, all 15 region servers died with this just 
after calling the alter (which returned successfully):

{quote}
2011-11-03 23:17:49,996 ERROR org.apache.hadoop.hbase.master.HMaster: Region 
server sv4r27s44,62023,1320362227032 reported a fatal error:
ABORTING region server sv4r27s44,62023,1320362227032: Unhandled exception: null
Cause:
java.lang.NullPointerException
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.createRegionLoad(HRegionServer.java:1001)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.buildServerLoad(HRegionServer.java:800)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.tryRegionServerReport(HRegionServer.java:776)
at 
org.apache.hadoop.hbase.regionserver.HRegionServer.run(HRegionServer.java:678)
at java.lang.Thread.run(Thread.java:662)
{quote}

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-0.92.txt, 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Instant_Schema_change_through_ZK.patch, 
 4213-Nov-2-2011_patch_.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-11-02 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142666#comment-13142666
 ] 

Ted Yu commented on HBASE-4213:
---

TestInstantSchemaChange failures were due to 'Too many open files'

TestThriftHBaseServiceHandler failures were due to another hanging minicluster.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-102511.patch, 4213-Instant_Schema_change_through_ZK.patch, 
 4213-Nov-2-2011_patch_.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-10-12 Thread Subbu M Iyer (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126326#comment-13126326
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Latest patch supports:

1. LB aware schema change process.
2. Monitoring support to show the alter status/error etc.
3. Progress reporting.
4. Added extensive test scenarios to test various failover/failure scenarios. 
(17 test cases so far)

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-10-12 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126331#comment-13126331
 ] 

Ted Yu commented on HBASE-4213:
---

Nice work, Subbu.
Please adjust your patch for TRUNK:
{code}
patching file 
src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
Hunk #1 FAILED at 18.
Hunk #2 succeeded at 52 (offset 1 line).
1 out of 2 hunks FAILED -- saving rejects to file 
src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java.rej
...
Hunk #4 succeeded at 241 (offset 14 lines).
1 out of 4 hunks FAILED -- saving rejects to file 
src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java.rej
...
2 out of 20 hunks FAILED -- saving rejects to file 
src/main/java/org/apache/hadoop/hbase/master/HMaster.java.rej
...
1 out of 2 hunks FAILED -- saving rejects to file 
src/main/java/org/apache/hadoop/hbase/master/MasterServices.java.rej
{code}

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-10-12 Thread Subbu M Iyer (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126333#comment-13126333
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Ted,

Yes, I will. My trunk is from 09/12. I wanted to get some initial feedback.

This time I could successfully request for a RB request. :-):-) Let me know how 
we handle this LB integration makes sense to you.


thanks
Subbu





 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-10-12 Thread Ted Yu (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126344#comment-13126344
 ] 

Ted Yu commented on HBASE-4213:
---

I only looked at part of the patch.

For getAndStartSchemaJanitorChore(), javadoc should be corrected:
{code}
+// Start up the load balancer chore
+Chore chore = new Chore(name, schemaJanitorPeriod, master) {
{code}
For getAndStartBalancerChore():
{code}
+if (doesLoadBalancerNodeExists()) {
{code}
The trailing s in the above name is unnecessary.
For doesLoadBalancerNodeExists():
{code}
+  int r = ZKUtil.checkExists(this.zooKeeper, zooKeeper.loadBalancerZNode);
+  return ZKUtil.checkExists(this.zooKeeper, zooKeeper.loadBalancerZNode) 
!= -1;
{code}
The assignment above is for debugging, I guess. Please remove it.

I think a better name for waitForCurrentSchemaChange() would be 
waitForCurrentSchemaChangeToComplete().
But the following debug should be removed:
{code}
+ LOG.debug(Schema change operation is in progress. Waiting for  +
+ it to complete before running the load balancer.);
+ Thread.sleep(1000);
{code}
In balance():
{code}
+// I don't think we need the following check because we already have
+// acquired the lock on balancer ??
{code}
So the following isLoadBalancerRunning() call can be removed :-)

For TableEventHandler.waitForLoadBalancerToComplete(), since 
master.isLoadBalancerRunning() checks zk node, should isLoadBalancerRunning() 
be moved to ZKUtil ? This would save RPC call.

MasterSchemaChangeTracker.handleFailedExpiredSchemaChanges() should be called 
handleFailedOrExpiredSchemaChanges()

So latest patch doesn't use the new synchronous switchBalancer(). Interesting.

There're pending questions in the patch.
{code}
+// Should we block here until we successfully create a LB node in ZK?
+if (createLoadBalancerNode()) {
{code}
createLoadBalancerNode() should distinguish KeeperException's that may arise 
and inform Master so that Master can make better decision.

For getAlterStatusFromSchemaChangeTracker():
{code}
+  LOG.debug(MasterAlterStatus is NULL for table = 
+  + Bytes.toString(tableName));
+  // should we throw IOException here as it makes more sense?
+  return new PairInteger, Integer(0,0);
{code}
I think IOE makes more sense in the above case.

After the modified patch is posted to review board, comments would have better 
context.

Thanks for your perseverance, Subbu.
This feature has been requested by many customers.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-10-12 Thread Subbu M Iyer (Commented) (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126348#comment-13126348
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Thanks for your support on this Ted.

Also, on my local (with only one RS), for a 70 region test table I see a more 
than 100+% improvement in alter performance. 

For a table in a bigger cluster with large number of regions, we should see 
drastic difference in performance. 

thanks
Subbu 




 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 
 4213-101211-Support_instant_schema_changes_through_ZK.patch, 
 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V10-Support_instant_schema_changes_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 
 4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt, 
 4213.v6, HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-16 Thread Subbu M Iyer (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13106776#comment-13106776
]

Subbu M Iyer commented on HBASE-4213:
-

In addition to most of the review comments, V9 adds:

1. Handle cases when the table is not in enabled state.
2. Ensures that concurrent alter requests are not missed.
3. Validate that alter can survive cases when one of the RS goes down during
alter, or multiple RS going down during alter or adding new RS servers to the
cloud during an alter.
4. Handle cases when primary master is brought down during alter and secondary
takes over.
5. Added new test cases for all of the above mentioned cases.

To-Do:
1. Revisit the load balancer toggling. It doesn't seem right.
2. Add monitoring support for alter process.
3. Gracefully handle cases when ZooKeeper throws exceptions during an alter.
4. Add fine grained tests to validate master failover cases.
5. Address any other comments/suggestions.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-16 Thread jirapos...@reviews.apache.org (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107005#comment-13107005
]

jirapos...@reviews.apache.org commented on HBASE-4213:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

(Updated 2011-09-17 03:16:42.534475)

Review request for hbase.

Changes
---

bq. From Subbu:
In addition to most of the review comments, V9 adds:

Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change
command that supports (Add, Modify, Delete column and Modify table) actions
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through
ZK. Secondary master taking over a failed schema change will be addressed
through a separate JIRA.

This addresses bug HBASE-4213.
https://issues.apache.org/jira/browse/HBASE-4213

Diffs (updated)
-

/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1171786
/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java
1171840
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java
1171786

/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
1171786

/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
1171786

/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
1171786
/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
1171786
/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
1171786

/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
PRE-CREATION
/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
1171786
/src/main/resources/hbase-default.xml 1171786
/src/main/ruby/hbase/admin.rb 1171786
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java
PRE-CREATION
/src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1171786

/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
1171786

Diff: https://reviews.apache.org/r/1786/diff

Testing
---

Unit tests pass.

Thanks,

Ted

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch,
4213-V9-Support_instant_schema_changes_through_ZK.patch, 4213-v9.txt,
4213.v6, HBASE-4213-Instant_schema_change.patch,

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-14 Thread jirapos...@reviews.apache.org (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104280#comment-13104280
]

jirapos...@reviews.apache.org commented on HBASE-4213:
--

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1885
---

/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
https://reviews.apache.org/r/1786/#comment4337

coming late to the game on the review here...

but why do we need a separate instantAdd boolean. If this feature works,
we should always use it. Otherwise we have to maintain multiple code paths, and
the API is more complicated. Plus, this breaks a public API.

/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
https://reviews.apache.org/r/1786/#comment4338

the fact that these two constructors differ only by number of arguments is
quite suspect. Same with the two functions below.

/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4339

we need to somehow expose this to the user in a way aside from just the
logs. For example, we could make a MonitoredTask for the table operation, and
mark it as failed here.

Ideally it would actually be a response to the original RPC that the user
called in HTableAdmin.

/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4340

we need some kind of try/finally here. Plus, this can easily race against
other things enabling/disabling the balancer. We need a kind of balancer
disable stack so that if multiple operations need to disable the balancer for
a period, they can all work together. Plus, if the balancer is mid-balance,
does balanceSwitch(false) wait for the balance to finish?

/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4341

definitely need a sleep or yield. Seems like a code smell as well

/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4342

why not just make this the while condition?

Since ZK is notification-based, can't we wait on this occuring rather than
polling in a loop?

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4343

!isEmpty() instead of size() comparison

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4344

what happens if on the reopen, an exception is thrown? does the region get
orphaned? we need some kind of recovery path here.

Example case: what if you alter a table and change compression to a codec
that this RS doesn't have?

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4345

seems like DEBUG level.

This whole process should be TaskMonitored.

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4351

this function never returns null. So at call sites, don't check for null -
just adds cruft.

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4346

thread safety properties here? I'm surprised we don't need any locking. For
example, what happens to regions that are in the process of opening?

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4348

!isEmpty()

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4349

DEBUG level

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4350

DEBUG

/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
https://reviews.apache.org/r/1786/#comment4347

should be ERROR or at least WARN level.
Need to include the exception traceback.

/src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java
https://reviews.apache.org/r/1786/#comment4352

empty javadoc, plus it doesn't @return anything, it's void

/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment4353

this should be registered _before_ the above line, right?

/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment4354

if this fails, shouldn't we abort the server or something? We don't want a
half-functional RS running that doesn't

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-14 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104288#comment-13104288
 ] 

Andrew Purtell commented on HBASE-4213:
---

Just want to clarify that my +1 is conditional on having the config option that 
selects between the schema update options, with the old one the default; and an 
expectation that HBASE-4370 will be developed and go in soon after, along with 
many tests for failures at different points in the update processing.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-14 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104295#comment-13104295
 ] 

Andrew Purtell commented on HBASE-4213:
---

In fact I'm wondering now why HBASE-4370 is separate. 




 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-14 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104372#comment-13104372
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1886
---



/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4372

Master checks balanceSwitch at the beginning of balance(). Meaning, the 
toggle of balanceSwitch would take effect in the next round of balancing.
We have two options in order to make balanceSwitch() call synchronous with 
balance():
1. Change balanceSwitch() to be synchronous directly. This breaks the API 
compatibility
2. Add new method, e.g. blockingBalanceSwitch(), to HMasterInterface()



/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment4373

From listChildrenAndWatchThem():
if (children == null) {
  return null;
}
So I guess the answer is yes.


- Ted


On 2011-09-12 18:36:02, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-09-12 18:36:02)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  This addresses bug HBASE-4213.
bq.  https://issues.apache.org/jira/browse/HBASE-4213
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1169522 
bq./src/main/ruby/hbase/admin.rb 1169522 
bq./src/main/ruby/shell.rb 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 
1169522 
bq./src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
 1169522 
bq.  
bq.  Diff: https://reviews.apache.org/r/1786/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Subbu M Iyer (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103925#comment-13103925
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Based on further discussions, here are some call outs:

1. Provide separate public API's for alter instant operations so as to not 
break existing public API's with out deprecation or prior notice.

2. Provide a config level setting to enable instant schema update feature. 
(defaults to false). This will also enable us to release this feature in a more 
controlled and transparent manner.

3. We don't want to intimidate developers with scary boolean flags
that does things in a such a way that they may not completely
understand or care about.

4.
Providing a developer level API to use instant-alter is good in the
sense they can fully capitalize a scalable/fault tolerant variants. At
the same time it might be confusing to some in the sense that why we
are even providing a not scalable/fault tolerant variant in the
first place.

5. We don't want to expose implementation details such as this flag
uses ZK to track schema changes and so on

So, long story short:

In addition to review comments, V7 will include the following:

1. Add new config parameter hbase.instant.schema.change.enabled
(exact name of flag is open) and default to false so that all
existing API's will go over the current path untouched.

2. Separate public API's for all alter operations which supports the
new pattern in addition to existing public API's. New API's will take
in a boolean parameter that overrides the config setting on a per
request basis.

3. Internally both the API's will go through the same pipeline to
promote reuse as well as maintainability.

Please let me know your thoughts/comments.


 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Subbu M Iyer (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104010#comment-13104010
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Attached V7 with all the review comments + above mentioned additions.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104053#comment-13104053
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1883
---



/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
https://reviews.apache.org/r/1786/#comment4335

How many times is this expected to spin? Should there be a sleep here?


- Andrew


On 2011-09-12 18:36:02, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-09-12 18:36:02)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  This addresses bug HBASE-4213.
bq.  https://issues.apache.org/jira/browse/HBASE-4213
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1169522 
bq./src/main/ruby/hbase/admin.rb 1169522 
bq./src/main/ruby/shell.rb 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 
1169522 
bq./src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
 1169522 
bq.  
bq.  Diff: https://reviews.apache.org/r/1786/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments:

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104054#comment-13104054
]

Andrew Purtell commented on HBASE-4213:
---

I don't see the V7 patch attached?

bq. We don't want to intimidate developers with scary boolean flags that does
things in a such a way that they may not completely understand or care about.

Yes, this jumped out almost immediately. Should not have the boolean flags on
the admin methods. If 'hbase.instant.schema.change.enabled' is true, then just
do it? Is another set of admin APIs necessary?

Shell shouldn't need a new command, just do it instant if config var is
enabled?

The unit test looks ok but it might be useful to include a case where a RS is
killed while in the middle of a schema change. Confirm that the updates are all
applied successfully when recovery is complete.

Other comment on the V6 patch up on RB.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104142#comment-13104142
 ] 

Ted Yu commented on HBASE-4213:
---

@Andy:
4213-V7-Support_instant_schema_changes_through_ZK.patch is the version 7 patch.
The new methods in HBaseAdmin allow overriding 
'hbase.instant.schema.change.enabled' config parameter. Is this Okay ?

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Andrew Purtell (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104152#comment-13104152
]

Andrew Purtell commented on HBASE-4213:
---

bq. The new methods in HBaseAdmin allow overriding
'hbase.instant.schema.change.enabled' config parameter. Is this Okay ?

Isn't the configuration variable there to support a transition, if people are
not comfortable using ZK for schema updates in the beginning? Surely we will
not have two ways of updating schema coexisting for a long time. There would
not be a need to toggle between them. Adding new APIs that we'd have to quickly
deprecate does not make sense to me.

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Subbu M Iyer (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104255#comment-13104255
]

Subbu M Iyer commented on HBASE-4213:
-

Andrew, thanks for your comments.

In V8.

1. Axed all boolean based public API's from HBaseAdmin and HMAster.
2. Schema changes will now drive off the config param.
3. alter_instant removed.
4. We have new JIRA 4370 where we plan to address the Master/RS failover
scenarios in depth. So, we will probably address your new test case scenario
there. The current JIRA is to put a basic framework to support schema changes
through ZK in place.

Currently, when a RS dies halfway through the change the ZK node might stay on
for ever, although the schema changes would have been completed when the RS
comes back alive. This will be addressed intelligently in 4370 by stamping the
RS hostname in ZK and so on. (more details in 4370)

Hope this helps and let me know for any thing else.

thanks
Subbu

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
4213-V7-Support_instant_schema_changes_through_ZK.patch,
4213-V8-Support_instant_schema_changes_through_ZK.patch, 4213.v6,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-13 Thread Andrew Purtell (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13104266#comment-13104266
 ] 

Andrew Purtell commented on HBASE-4213:
---

+1 Thanks Subbu

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 4213-V7-Support_instant_schema_changes_through_ZK.patch, 
 4213-V8-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-12 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102897#comment-13102897
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/
---

Review request for hbase.


Summary
---

bq. From Subbu:
here is the latest patch that support alter_instant, an instant schema change 
command that supports (Add, Modify, Delete column and Modify table) actions 
through ZK.

1. This pattern capitalizes on the fact that HRI's are now in HDFS and need not 
be sent over again from Master to RS cloud on every schema change event.

2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.

3. Offers fault tolerant schema change support as schema changes now go through 
ZK. Secondary master taking over a failed schema change will be addressed 
through a separate JIRA.


This addresses bug HBASE-4213.
https://issues.apache.org/jira/browse/HBASE-4213


Diffs
-

  /src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 1169522 
  /src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1169522 
  /src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1169522 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1169522 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1169522 
  /src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1169522 
  
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1169522 
  /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1169522 
  /src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1169522 
  /src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522 
  
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
  /src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1169522 
  /src/main/ruby/hbase/admin.rb 1169522 
  /src/main/ruby/shell.rb 1169522 
  /src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522 
  /src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 1169522 
  /src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
  /src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 
1169522 
  /src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 1169522 
  
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
 1169522 

Diff: https://reviews.apache.org/r/1786/diff


Testing
---

Unit tests pass.


Thanks,

Ted



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-12 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103104#comment-13103104
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1862
---



/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
https://reviews.apache.org/r/1786/#comment4254

Please add javadoc for instantAdd.



/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
https://reviews.apache.org/r/1786/#comment4255

Add javadoc for instantAdd.



/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
https://reviews.apache.org/r/1786/#comment4256

Javadoc.



/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
https://reviews.apache.org/r/1786/#comment4257

Please wrap long lines.



/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
https://reviews.apache.org/r/1786/#comment4258

Javadoc for new param.



/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
https://reviews.apache.org/r/1786/#comment4260

@Override should be kept.


- Ted


On 2011-09-12 18:36:02, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-09-12 18:36:02)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  This addresses bug HBASE-4213.
bq.  https://issues.apache.org/jira/browse/HBASE-4213
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1169522 
bq./src/main/ruby/hbase/admin.rb 1169522 
bq./src/main/ruby/shell.rb 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 
1169522 
bq./src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
 1169522 
bq.  
bq.  Diff: https://reviews.apache.org/r/1786/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-12 Thread jirapos...@reviews.apache.org (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13103198#comment-13103198
 ] 

jirapos...@reviews.apache.org commented on HBASE-4213:
--


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1786/#review1863
---



/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment4261

Javadoc should explain the role of this class.



/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java
https://reviews.apache.org/r/1786/#comment4262

I think this should be: ... SchemaChangeTracker


- Ted


On 2011-09-12 18:36:02, Ted Yu wrote:
bq.  
bq.  ---
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1786/
bq.  ---
bq.  
bq.  (Updated 2011-09-12 18:36:02)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  ---
bq.  
bq.  From Subbu:
bq.  here is the latest patch that support alter_instant, an instant schema 
change command that supports (Add, Modify, Delete column and Modify table) 
actions through ZK.
bq.  
bq.  1. This pattern capitalizes on the fact that HRI's are now in HDFS and 
need not be sent over again from Master to RS cloud on every schema change 
event.
bq.  
bq.  2. Offers real time instant schema change as we bypass the explicit bulk 
reassign (unassign + assign) of regions from master to RS.
bq.  
bq.  3. Offers fault tolerant schema change support as schema changes now go 
through ZK. Secondary master taking over a failed schema change will be 
addressed through a separate JIRA.
bq.  
bq.  
bq.  This addresses bug HBASE-4213.
bq.  https://issues.apache.org/jira/browse/HBASE-4213
bq.  
bq.  
bq.  Diffs
bq.  -
bq.  
bq./src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1169522 
bq./src/main/java/org/apache/hadoop/hbase/master/MasterServices.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/DeleteTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/ModifyTableHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableAddFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableDeleteFamilyHandler.java
 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java 
1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/master/handler/TableModifyFamilyHandler.java
 1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/regionserver/OnlineRegions.java 
1169522 
bq./src/main/java/org/apache/hadoop/hbase/rest/SchemaResource.java 1169522 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterSchemaChangeTracker.java 
PRE-CREATION 
bq.
/src/main/java/org/apache/hadoop/hbase/zookeeper/SchemaChangeTracker.java 
PRE-CREATION 
bq./src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 
1169522 
bq./src/main/ruby/hbase/admin.rb 1169522 
bq./src/main/ruby/shell.rb 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1169522 
bq./src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/client/TestInstantSchemaChange.java 
PRE-CREATION 
bq.
/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java 
1169522 
bq./src/test/java/org/apache/hadoop/hbase/master/TestCatalogJanitor.java 
1169522 
bq.
/src/test/java/org/apache/hadoop/hbase/regionserver/handler/MockRegionServerServices.java
 1169522 
bq.  
bq.  Diff: https://reviews.apache.org/r/1786/diff
bq.  
bq.  
bq.  Testing
bq.  ---
bq.  
bq.  Unit tests pass.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ted
bq.  
bq.



 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-11 Thread Subbu M Iyer (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102335#comment-13102335
]

Subbu M Iyer commented on HBASE-4213:
-

Ted,

I addressed all the issues + a merge conflict and also ran all the tests on my
local. All tests pass except the following which has nothing to do with this
effort.

Results :

Failed tests:
testWorkerAbort(org.apache.hadoop.hbase.master.TestDistributedLogSplitting):
expected:1 but was:0
testMultipleResubmits(org.apache.hadoop.hbase.master.TestSplitLogManager):
expected:2 but was:3
testMergeTool(org.apache.hadoop.hbase.util.TestMergeTool): 'merging regions 0
and 1' failed with errCode -1

Tests in error:
testScanMultipleVersions(org.apache.hadoop.hbase.TestScanMultipleVersions):
Cannot lock storage /work/HBase0909/hbase/build/hbase/test/dfs/name1. The
directory is already locked.
testAll(org.apache.hadoop.hbase.thrift.TestThriftServer): Cannot lock storage
/work/HBase0909/hbase/build/hbase/test/dfs/name2. The directory is already
locked.

Tests run: 970, Failures: 3, Errors: 2, Skipped: 9

Support for fault tolerant, instant schema updates with out master's
intervention (i.e with out enable/disable and bulk assign/unassign) through
ZK.

Key: HBASE-4213
URL: https://issues.apache.org/jira/browse/HBASE-4213
Project: HBase
Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
Fix For: 0.92.0

Attachments: 4213-Instant_Schema_change_through_ZK.patch,
4213-V5-Support_instant_schema_changes_through_ZK.patch,
HBASE-4213-Instant_schema_change.patch,
HBASE-4213_Instant_schema_change_-Version_2_.patch,
HBASE_Instant_schema_change-version_3_.patch

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-11 Thread Subbu M Iyer (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102336#comment-13102336
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Yes, I agree with you that we shall address 1) progress reporting and 2) 
secondary master take over through separate JIRA's.

Let me know if you have any comments. The changes are same except new additions 
to address the 1730 merge.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-11 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102342#comment-13102342
 ] 

Ted Yu commented on HBASE-4213:
---

I created HBASE-4370 for the follow-on work.
I think publishing patch version 5 on review board should make it easier for 
other developers to comment.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-11 Thread Subbu M Iyer (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102344#comment-13102344
 ] 

Subbu M Iyer commented on HBASE-4213:
-

Ted,

Can you help me post it to RB? I have problems posting the same.

thanks
Subbu




 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4213) Support for fault tolerant, instant schema updates with out master's intervention (i.e with out enable/disable and bulk assign/unassign) through ZK.

2011-09-11 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13102353#comment-13102353
 ] 

Ted Yu commented on HBASE-4213:
---

In HBaseAdmin.java, javadoc should be added for instantAdd parameter:
{code}
* @param column column descriptor of column to be added
* @throws IOException if a remote or network exception occurs
*/
-  public void addColumn(final String tableName, HColumnDescriptor column)
+  public void addColumn(final String tableName, HColumnDescriptor column, 
boolean instantAdd)
   throws IOException {
{code}
Personally I prefer creating an enum, possibly called SCHEMA_OP_TYPE, which 
should contain NORMAL and INSTANT. There are two benefits:
1. the enum is more meaningful for readers
2. SCHEMA_OP_TYPE.INSTANT covers add/delete. This may provide benefit for 
related code.
This is minor, though.

 Support for fault tolerant, instant schema updates with out master's 
 intervention (i.e with out enable/disable and bulk assign/unassign) through 
 ZK.
 

 Key: HBASE-4213
 URL: https://issues.apache.org/jira/browse/HBASE-4213
 Project: HBase
  Issue Type: Improvement
Reporter: Subbu M Iyer
Assignee: Subbu M Iyer
 Fix For: 0.92.0

 Attachments: 4213-Instant_Schema_change_through_ZK.patch, 
 4213-V5-Support_instant_schema_changes_through_ZK.patch, 4213.v6, 
 HBASE-4213-Instant_schema_change.patch, 
 HBASE-4213_Instant_schema_change_-Version_2_.patch, 
 HBASE_Instant_schema_change-version_3_.patch


 This Jira is a slight variation in approach to what is being done as part of 
 https://issues.apache.org/jira/browse/HBASE-1730
 Support instant schema updates such as Modify Table, Add Column, Modify 
 Column operations:
 1. With out enable/disabling the table.
 2. With out bulk unassign/assign of regions.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

82 matches

Mail list logo