subject:"\[jira\] \[Commented\] \(HBASE\-6698\) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation"

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459540#comment-13459540
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

Oops, yes HBASE-6769 is the reason.  I will update the patch.. 

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459597#comment-13459597
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545896/HBASE-6698_8.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

-1 javadoc. The javadoc tool appears to have generated 139 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 14 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2906//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch,
HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, HBASE-6698.patch

Currently the checkAndPut and checkAndDelete api internally calls the
internalPut and internalDelete. May be we can just call doMiniBatchMutation
only. This will help in future like if we have some hooks and the CP
handles certain cases in the doMiniBatchMutation the same can be done while
doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459694#comment-13459694
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.  This test cases 
passes locally.
The error in the QA build seems to be different
{code}
java.io.IOException: Shutting down
at 
org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:227)
at 
org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:89)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:693)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:666)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:661)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:603)
at 
org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:572)
at 
org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.setUp(TestRegionServerMetrics.java:86)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
{code}

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459730#comment-13459730
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

As per my analysis, before the HBaseRPCServer on the RS could start and set the 
volatile variable 'started' the master started the assignment because the RS  
registration got completed successfully.
{code}
Caused by: org.apache.hadoop.ipc.RemoteException: 
org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running 
yet
at 
org.apache.hadoop.hbase.ipc.HBaseServer$Handler.run(HBaseServer.java:1798)

at org.apache.hadoop.hbase.ipc.HBaseClient.call(HBaseClient.java:1300)
at 
org.apache.hadoop.hbase.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:178)
... 11 more
{code}
This shows that the assignment failed due to Servernotrunningexcep.
Connected to master logs comes even before this
{code}
2012-09-20 13:10:31,810 INFO  
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1943): Attempting connect to Master server at 
asf011.sp2.ygridcore.net,49804,1348146629519
2012-09-20 13:10:31,841 INFO  
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1952): Connected to master at 
asf011.sp2.ygridcore.net/67.195.138.20:49804
2012-09-20 13:10:31,841 INFO  
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1998): Telling master at 
asf011.sp2.ygridcore.net,49804,1348146629519 that we are up with port=34620, 
startcode=1348146629931
2012-09-20 13:10:31,882 INFO  [IPC Server handler 0 on 49804] 
master.ServerManager(307): Registering 
server=asf011.sp2.ygridcore.net,34620,1348146629931
2012-09-20 13:10:31,893 DEBUG 
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1171): Config from master: 
hbase.rootdir=hdfs://localhost:52552/user/jenkins/hbase
2012-09-20 13:10:31,894 DEBUG 
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1171): Config from master: 
fs.default.name=hdfs://localhost:52552
2012-09-20 13:10:31,894 INFO  
[RegionServer:0;asf011.sp2.ygridcore.net,34620,1348146629931] 
regionserver.HRegionServer(1164): Master passed us hostname to use. 
Was=asf011.sp2.ygridcore.net, Now=asf011.sp2.ygridcore.net
{code}
And the ROOT assignment also started
{code}
012-09-20 13:10:33,811 INFO  
[Master:0;asf011.sp2.ygridcore.net,49804,1348146629519] 
master.AssignmentManager(1579): Assigning region -ROOT-,,0.70236052 to 
asf011.sp2.ygridcore.net,34620,1348146629931
2012-09-20 13:10:33,811 INFO  
[Master:0;asf011.sp2.ygridcore.net,49804,1348146629519] 
master.RegionStates(250): Region {NAME = '-ROOT-,,0', STARTKEY = '', ENDKEY 
= '', ENCODED = 70236052,} transitioned from {-ROOT-,,0.70236052 
state=OFFLINE, ts=1348146633581, server=null} to {-ROOT-,,0.70236052 
state=PENDING_OPEN, ts=1348146633811, 
server=asf011.sp2.ygridcore.net,34620,1348146629931}
{code}
I think this should be addressed in a seperate JIRA.  Let me know if i can 
commit the patch?

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459748#comment-13459748
 ] 

stack commented on HBASE-6698:
--

Nice analysis Ram.  Commit your patch and open a new one for the failed test 
especially since you've done the work to figure why it failed.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, 
 HBASE-6698_8.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459808#comment-13459808
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545931/HBASE-6698_8.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

-1 javadoc. The javadoc tool appears to have generated 139 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 14 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

+1 core tests. The patch passed unit tests in .

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2907//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459877#comment-13459877
 ] 

Hudson commented on HBASE-6698:
---

Integrated in HBase-TRUNK #3359 (See 
[https://builds.apache.org/job/HBase-TRUNK/3359/])
HBASE-6698 Refactor checkAndPut and checkAndDelete to use 
doMiniBatchMutation
(Priya)

Submitted by:PrIya
Reviewed by:Ram, Stack, Ted, Lars (Revision 1388141)

 Result = FAILURE
ramkrishna : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, 
 HBASE-6698_8.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-20 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460079#comment-13460079
 ] 

Hudson commented on HBASE-6698:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #184 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/184/])
HBASE-6698 Refactor checkAndPut and checkAndDelete to use 
doMiniBatchMutation
(Priya)

Submitted by:PrIya
Reviewed by:Ram, Stack, Ted, Lars (Revision 1388141)

 Result = FAILURE
ramkrishna : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698_8.patch, HBASE-6698_8.patch, 
 HBASE-6698_8.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458866#comment-13458866
 ] 

stack commented on HBASE-6698:
--

lol I tried doing the above but forgot how I was missing the Pair[]... was 
complaining that my [] was generic... so I let it pass.  Let me make an 
addendum.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458867#comment-13458867
 ] 

stack commented on HBASE-6698:
--

Or, its not committed yet... mind addressing Lars's comment above lads?

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread ramkrishna.s.vasudevan (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458998#comment-13458998
]

ramkrishna.s.vasudevan commented on HBASE-6698:
---

Addressed Lar's comments in the latest patch.
{code}
+Delete delete = new Delete(new byte[0]);
{code}
Currently used in testcase only. We need a row object to obtain lock. Anyway
changed it to use HConstants.EMPTY_BYTE_ARRAY.
{code}
doBatchMutate((Mutation)w, lid);
{code}
Cast is needed as w is of type Writable here.

bq. This comment should be removed?
Removed the comment.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459000#comment-13459000
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

Will commit this tomorrow unless no objections.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459053#comment-13459053
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545776/HBASE-6698_7.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

-1 javadoc. The javadoc tool appears to have generated 139 warning
messages.

+1 javac. The applied patch does not increase the total number of javac
compiler warnings.

-1 findbugs. The patch appears to introduce 14 new Findbugs (version
1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestHRegion

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2900//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459064#comment-13459064
 ] 

stack commented on HBASE-6698:
--

That TestHRegion failure looks suspicious.  Does this patch really introduce 14 
findbugs issues (Its removing code mostly)

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-19 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459086#comment-13459086
 ] 

Ted Yu commented on HBASE-6698:
---

Looks like the patch has to be adjusted since HBASE-6769 has gone in already.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, 
 HBASE-6698_7.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-18 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457856#comment-13457856
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

@Stack
Can you take a look at this? So that the patch is not stale.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-18 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458423#comment-13458423
 ] 

stack commented on HBASE-6698:
--

Sorry lads.  Distracted.

+1 on committing this patch.  It removes two fat delete and put methods and 
instead has us go by the batch mutate path.   Nice improvement.

Below are some comments.  You can address on commit Ram.

Why we do this?

{code}
-Delete delete = new Delete();
+Delete delete = new Delete(new byte[0]);
{code}

Null row in Delete is handled differently to a row that is an empty byte array 
(Would suggest HConstants.EMPTY_BYTE_ARRAY instead of creating a new byte array 
each time through).

Is this cast necessary?

{code}
+  doBatchMutate((Mutation)w, lid);  
{code}

This comment should be removed?  Its going to seem funny when its not followed 
by Put and Delete stuff:

{code}
   // Using default cluster id, as this can only happen in the
   // originating cluster. A slave cluster receives the result as a Put
   // or Delete
{code}

Here you put the square brackets after the variable name:

{code}
+PairMutation, Integer mutateWithLocks[] = new Pair[1];
{code}

In the rest of the method, the square brackets precede the variable name.  
Would suggest you be consistent.



 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-18 Thread Lars Hofhansl (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458432#comment-13458432
 ] 

Lars Hofhansl commented on HBASE-6698:
--

Super minor nit:
{code}
+PairMutation, Integer mutateWithLocks[] = new Pair[1];
+mutateWithLocks[0] = new PairMutation, Integer(mutation, lid);
{code}

can be written as:

{code}
  PairMutation, Integer mutateWithLocks[] = new Pair[] {new 
PairMutation, Integer(mutation, lid)};
{code}

Also, this method should be marked with:
{{@SuppressWarnings(unchecked)}}


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-13 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13454899#comment-13454899
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

[~saint@gmail.com]
Is this patch fine Stack? 

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-11 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452754#comment-13452754
 ] 

stack commented on HBASE-6698:
--

Sorry Ram.  That looks right.  Let me take another look.  I like this patch 
because of all the cleanup ; just afraid it was skipping out on checks.  Thanks 
for the above.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Priyadarshini (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451881#comment-13451881
 ] 

Priyadarshini commented on HBASE-6698:
--

Latest patch has renamed putsAndLocks to mutateWithLocks

{code}
Delete delete = new Delete(new byte[0]);
{code}

Now, delete tries to obtain row lock through mutation.getRow(). To get the row 
lock, for test case purpose this change is required.This delete api is used 
only in testcases.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451909#comment-13451909
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/1258/HBASE-6698_6.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause mvn compile goal to fail.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestFromClientSide

org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor

org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
org.apache.hadoop.hbase.master.TestAssignmentManager
org.apache.hadoop.hbase.master.TestSplitLogManager

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2837//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2837//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13451996#comment-13451996
 ] 

Ted Yu commented on HBASE-6698:
---

From 
https://builds.apache.org/job/PreCommit-HBASE-Build/2837//testReport/org.apache.hadoop.hbase.master/TestAssignmentManager/testShutdownHandler/:
{code}
org.mockito.exceptions.misusing.WrongTypeOfReturnValue: 
CatalogTracker$$EnhancerByMockitoWithCGLIB$$5da9aeb6 cannot be returned by 
isStopped()
isStopped() should return boolean
{code}

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452148#comment-13452148
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

I tried running all the failed testcases.  All of them passed.
{code}
2012-09-10 22:38:21,013 INFO  [main] hbase.HBaseTestingUtility(288): Created 
new mini-cluster data directory: 
D:\HBase\Trunk\hbase-server\target\test-data\1b34c2bc-9ae2-4c2c-a17e-a7a7ef73b1b6\dfscluster_1f11df5c-39e2-47e7-bf7b-634dbebf785a
2012-09-10 22:38:21,540 INFO  [main] zookeeper.MiniZooKeeperCluster(196): 
Started MiniZK Cluster and connect 1 ZK server on client port: 50620
2012-09-10 22:38:21,549 ERROR [main] hbase.ResourceChecker(129): Bad 
configuration: the operating systems file handles maximum is 0 our is 1024
2012-09-10 22:38:21,971 INFO  [main] hbase.ResourceChecker(144): before 
master.TestAssignmentManager#testShutdownHandler: 10 threads, 0 file 
descriptors 0 connections, 
2012-09-10 22:38:22,371 DEBUG [main] zookeeper.ZKUtil(102): mockedServer 
opening connection to ZooKeeper with ensemble (localhost:50620)
2012-09-10 22:38:22,435 INFO  [main] zookeeper.RecoverableZooKeeper(101): The 
identifier of this process is 4624@Ram
2012-09-10 22:38:22,569 DEBUG [main-EventThread] 
zookeeper.ZooKeeperWatcher(261): mockedServer Received ZooKeeper Event, 
type=None, state=SyncConnected, path=null
2012-09-10 22:38:22,580 DEBUG [main-EventThread] 
zookeeper.ZooKeeperWatcher(338): mockedServer-0x139b127390f connected
2012-09-10 22:38:24,517 DEBUG [main] executor.ExecutorService(132): Starting 
executor service name=MASTER_OPEN_REGION-testShutdownHandler, corePoolSize=3, 
maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting 
executor service name=MASTER_CLOSE_REGION-testShutdownHandler, corePoolSize=3, 
maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting 
executor service name=MASTER_SERVER_OPERATIONS-testShutdownHandler, 
corePoolSize=3, maxPoolSize=3
2012-09-10 22:38:24,518 DEBUG [main] executor.ExecutorService(132): Starting 
executor service name=MASTER_META_SERVER_OPERATIONS-testShutdownHandler, 
corePoolSize=3, maxPoolSize=3
2012-09-10 22:38:26,200 INFO  [main] handler.ServerShutdownHandler(181): 
Skipping log splitting for example.org,1234,5678
2012-09-10 22:38:26,461 DEBUG [main] client.ClientScanner(94): Creating scanner 
over .META. starting at key ''
2012-09-10 22:38:26,461 DEBUG [main] client.ClientScanner(205): Advancing 
internal scanner to startKey at ''
2012-09-10 22:38:26,781 DEBUG [main] client.ClientScanner(192): Finished with 
scanning at {NAME = 't,,1347296900866.db9424ce7e14acb58b9420b098b996ea.', 
STARTKEY = '', ENDKEY = '', ENCODED = db9424ce7e14acb58b9420b098b996ea,}
2012-09-10 22:38:26,801 INFO  [main] handler.ServerShutdownHandler(282): 
Reassigning 1 region(s) that example.org,1234,5678 was carrying (skipping 0 
regions(s) that are already in transition)
2012-09-10 22:38:26,801 INFO  [main] handler.ServerShutdownHandler(378): The 
table t was deleted.  Hence not proceeding.
2012-09-10 22:38:26,801 INFO  [main] master.AssignmentManager(1372): Quickly 
assigning 0 region(s) across 2 server(s)
2012-09-10 22:38:26,801 INFO  [main] master.AssignmentManager(1377): Failed 
getting bulk plan, assigning region singly
2012-09-10 22:38:26,801 INFO  [main] handler.ServerShutdownHandler(359): 
Finished processing of shutdown of example.org,1234,5678
2012-09-10 22:38:26,801 DEBUG [main] zookeeper.ZKAssign(538): 
mockedServer-0x139b127390f Deleting any existing unassigned nodes
2012-09-10 22:38:26,832 DEBUG [main] zookeeper.ZKAssign(538): 
mockedServer-0x139b127390f Deleting any existing unassigned nodes
2012-09-10 22:38:26,853 INFO  [main] hbase.ResourceChecker(144): after 
master.TestAssignmentManager#testShutdownHandler: 12 threads (was 10), 0 file 
descriptors 1 connections,  -thread leak?- 
2012-09-10 22:38:27,863 INFO  [main] zookeeper.MiniZooKeeperCluster(238): 
Shutdown MiniZK cluster with all ZK servers

{code}
Also could not find the error that occured while running testShutDownHandler.  
The code is the updated one? Am i missing something here?

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452248#comment-13452248
]

stack commented on HBASE-6698:
--

I ran the tests individually and they passed for me. Let me retry the patch.

Rather than '+Delete delete = new Delete(new byte[0]);', could pass
HConstants.EMPTY_BYTE_ARRAY (I could add on commit)... thats minor. Let me do
a more extensive review. This patch is great. It could be too good to be true.
I just want to check

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452325#comment-13452325
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544495/HBASE-6698_6.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause mvn compile goal to fail.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2838//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2838//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452405#comment-13452405
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544509/HBASE-6698_6.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause mvn compile goal to fail.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2840//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2840//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452423#comment-13452423
 ] 

stack commented on HBASE-6698:
--

The first rerun above OOME'd.  The second shows no obvious hang.  Retry again.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread stack (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452432#comment-13452432
]

stack commented on HBASE-6698:
--

I took a look at the first change:

{code}
-prepareDelete(delete);
-internalDelete(delete, delete.getClusterId(), writeToWAL);
+doBatchMutate(delete, lid);
{code}

If I look at doBatchMutate, it is missing special handling that prepareDelete
does: e.g. the piece in prepareDelete where if no column family is specified,
we set for each column family in the HTableDescriptor, a special cell w/ the
current timestamp.

My worry is that corner cases are not covered by this mass replace. Please
convince me its just my bad review not catching them. Thanks Priyadarshini.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452495#comment-13452495
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544525/HBASE-6698_6.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause mvn compile goal to fail.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2843//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2843//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch,
HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-10 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452705#comment-13452705
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

@Stack
bq.If I look at doBatchMutate, it is missing special handling that prepareDelete
You feel that the prepareDelete is not called at all ?
If you see doBatchMutate it internally calls 
{code}
OperationStatus[] batchMutate = this.batchMutate(mutateWithLocks);
{code}
Inside batchMutate we have
{code}
long addedSize = doMiniBatchMutation(batchOp);
newSize = this.addAndGetGlobalMemstoreSize(addedSize);
{code}
This code takes care of both Puts and deletes.
{code}
  if (isPutMutation) {
// Check the families in the put. If bad, skip this one.
checkFamilies(familyMap.keySet());
checkTimestamps(mutation.getFamilyMap(), now);
  } else {
prepareDelete((Delete) mutation);
  }
{code}
Pls correct me if am not addressing your concern? Thanks Stack.


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698_6.patch, 
 HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-07 Thread Priyadarshini (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450551#comment-13450551
 ] 

Priyadarshini commented on HBASE-6698:
--

Attached patch addressing Ted's review comments.
Pls review..

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-07 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450567#comment-13450567
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

@Ted
We tried to run the test suite on trunk but every time we were getting OOME.  
The internal jenkins is on 0.94 so not able to use that too.
From the 'Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//testReport/' found 
that there was a heap space issue.


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-07 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450607#comment-13450607
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12544205/HBASE-6698_5.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

+1 javadoc. The javadoc tool did not generate any warning messages.

-1 javac. The patch appears to cause mvn compile goal to fail.

-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2814//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2814//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-07 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450832#comment-13450832
 ] 

Ted Yu commented on HBASE-6698:
---

Latest patch is much cleaner.
Please remind me what the following change is for:
{code}
-Delete delete = new Delete();
+Delete delete = new Delete(new byte[0]);
{code}
Please rename the variable below to reflect the nature of this change:
{code}
+putsAndLocks[0] = new PairMutation, Integer(mutation, lid);
{code}
From https://builds.apache.org/job/PreCommit-HBASE-Build/2814/console, it was 
clear TestReplication hung.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698_5.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449444#comment-13449444
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

Deleted the attachment as the attached had one problem while creating patch.  

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449493#comment-13449493
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543996/HBASE-6698_3.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

-1 javadoc. The javadoc tool appears to have generated 108 warning
messages.

-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).

-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2799//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch,
HBASE-6698_3.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449821#comment-13449821
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

Latest patch attached.  Pls provide your reviews/comments.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449924#comment-13449924
 ] 

Ted Yu commented on HBASE-6698:
---

PreCommit build #2799 timed out.
Please run latest patch through test suite.
nit:
{code}
+batchOp[0] = new PairMutation, Integer(((Put) w), lid);
{code}
The cast to Put should be to Mutation, right ?

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449972#comment-13449972
 ] 

Ted Yu commented on HBASE-6698:
---

nit: line is too long:
{code}
+if 
(batchMutate[0].getOperationStatusCode().equals(OperationStatusCode.SANITY_CHECK_FAILURE))
 {
{code}
The code snippet of creating PairMutation, Integer, calling batchMutate(), 
etc is repeated multiple times. Consider refactoring into a utility method.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-06 Thread stack (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450272#comment-13450272
 ] 

stack commented on HBASE-6698:
--

Patch looks great.  Thanks for working on this important stuff.  The Ted 
comment on factoring out common code sounds good.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-05 Thread Priyadarshini (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448697#comment-13448697
 ] 

Priyadarshini commented on HBASE-6698:
--

Refactored internalPut() and internalDelete().



 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-05 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448737#comment-13448737
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543846/HBASE-6698_2.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.

+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

-1 javadoc. The javadoc tool appears to have generated 108 warning
messages.

-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).

-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.

+1 release audit. The applied patch does not increase the total number of
release audit warnings.

-1 core tests. The patch failed these unit tests:

org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics

Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2787//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-05 Thread Priyadarshini (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449441#comment-13449441
 ] 

Priyadarshini commented on HBASE-6698:
--

Attached patch for testcase modification.
Now completely internalPut() and internalDelete() are removed to use 
batchmutate 

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, 
 HBASE-6698_3.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-03 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447481#comment-13447481
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

@Ted
We did not remove internalPut and internalDelete because mostly they were 
getting used in HBaseFSck and in Merge tools.
Others were in testcases only.
What do you feel Ted?  


 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-03 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447484#comment-13447484
 ] 

Ted Yu commented on HBASE-6698:
---

internalPut() is called by put(). So its use is widespread.

Since this JIRA aims to facilitate coprocessor hooks, I think we should examine 
the usage carefully.

BTW, Hadoop QA is temporarily out of order because of non-zero return value 
from mvn command.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-09-03 Thread ramkrishna.s.vasudevan (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447491#comment-13447491
 ] 

ramkrishna.s.vasudevan commented on HBASE-6698:
---

One thing i can find here is we need to make use of prePut hook which after the 
refactoring will not be used in checkAndMutate case.  
So will be it be ok to replace all internalPut() to batchMutate()?  

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698_1.patch, HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-08-31 Thread Priyadarshini (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445800#comment-13445800
 ] 

Priyadarshini commented on HBASE-6698:
--

Attached the patch for trunk. Pls review 

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-08-31 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445808#comment-13445808
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543246/HBASE-6698.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 patch. The patch command could not apply the patch.

Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2749//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698.patch

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-08-31 Thread Ted Yu (JIRA)


[ 
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13446418#comment-13446418
 ] 

Ted Yu commented on HBASE-6698:
---

internalPut() is still called in a few other methods ? Do you plan to replace 
those calls as well ?

Please base patch on trunk code base.

 Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
 --

 Key: HBASE-6698
 URL: https://issues.apache.org/jira/browse/HBASE-6698
 Project: HBase
  Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
 Fix For: 0.96.0

 Attachments: HBASE-6698.patch


 Currently the checkAndPut and checkAndDelete api internally calls the 
 internalPut and internalDelete.  May be we can just call doMiniBatchMutation
 only.  This will help in future like if we have some hooks and the CP
 handles certain cases in the doMiniBatchMutation the same can be done while
 doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation

2012-08-31 Thread Hadoop QA (JIRA)

[
https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13446453#comment-13446453
]

Hadoop QA commented on HBASE-6698:
--

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543246/HBASE-6698.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 patch. The patch command could not apply the patch.

Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2758//console

This message is automatically generated.

Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
--

Key: HBASE-6698
URL: https://issues.apache.org/jira/browse/HBASE-6698
Project: HBase
Issue Type: Improvement
Reporter: ramkrishna.s.vasudevan
Fix For: 0.96.0

Attachments: HBASE-6698.patch

51 matches

Mail list logo