[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502218#comment-13502218 ] Gary Helmling commented on HBASE-6787: -- Since HBASE-7185 went in (moving .proto files and generates sources under hbase-protocol module), the latest patch needs to be updated to move the PB bits as well. I like the updates to RowProcessor adding a type param for request as well as response. And making these extend Message means implementors don't actually have to worry about the serialization bits. Overall this version looks good. Can you update the patch to account for the HBASE-7185 changes? Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502402#comment-13502402
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554578/6787-8.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
98 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3390//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch,
6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502409#comment-13502409 ] Ted Yu commented on HBASE-6787: --- Integrated to trunk. Thanks for the patch, Devaraj. Thanks for the review, Gary. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502424#comment-13502424 ] Gary Helmling commented on HBASE-6787: -- Did anyone +1 this patch yet? The -6 version was looking good, but I hadn't yet given a +1 and we've had 2 updates posted since then, which I was still in the process of working through. I don't want to force a revert on a patch that I might end up +1ing shortly, but I would appreciate having a chance to finish reviewing changes posted mere hours before. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502433#comment-13502433 ] stack commented on HBASE-6787: -- I don't see +1s on the patch yet. I see an encouraging comment by Gary followed by revs by DD and a successful hadoopqa. This is a thorny issue and its been through a couple of character changes based off feedback. No need of rushing it in. Suggest we wait a while and if Gary gets through w/ his review, revert or leave dependent on what he says else if no complete review soon, revert. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502438#comment-13502438 ] Gary Helmling commented on HBASE-6787: -- After completing review, post-facto +1 on 6787-8.1.patch from me. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502448#comment-13502448
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554578/6787-8.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
98 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3392//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch,
6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502449#comment-13502449 ] Ted Yu commented on HBASE-6787: --- Thanks for clarification, Gary. I will read your comments more carefully. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502476#comment-13502476 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK #3557 (See [https://builds.apache.org/job/HBase-TRUNK/3557/]) HBASE-6787 Convert RowProcessorProtocol to protocol buffer service (Devaraj) (Revision 1412356) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProcessorProtos.java * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/MultiRowMutationProcessorMessages.proto * /hbase/trunk/hbase-protocol/src/main/protobuf/RowProcessor.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/RowProcessorClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRowProcessorEndpoint.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessorProtocol.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java * /hbase/trunk/hbase-server/src/test/protobuf/IncrementCounterProcessor.proto Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502480#comment-13502480 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #269 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/269/]) HBASE-6787 Convert RowProcessorProtocol to protocol buffer service (Devaraj) (Revision 1412356) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MultiRowMutationProcessorProtos.java * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RowProcessorProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/MultiRowMutationProcessorMessages.proto * /hbase/trunk/hbase-protocol/src/main/protobuf/RowProcessor.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/coprocessor/RowProcessorClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRowProcessorEndpoint.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/ColumnInterpreter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RowProcessorProtocol.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BaseRowProcessor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RowProcessor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRowProcessorEndpoint.java * /hbase/trunk/hbase-server/src/test/protobuf/IncrementCounterProcessor.proto Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502488#comment-13502488 ] Ted Yu commented on HBASE-6787: --- IncrementCounterProcessorTestProtos.java was missing in the initial checkin. I picked up this file and integrated to repository. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502522#comment-13502522 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK #3558 (See [https://builds.apache.org/job/HBase-TRUNK/3558/]) HBASE-6787 Convert RowProcessorProtocol to protocol buffer service - forgot to checkin IncrementCounterProcessorTestProtos.java (Revision 1412389) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/IncrementCounterProcessorTestProtos.java Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502523#comment-13502523 ] Hudson commented on HBASE-6787: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #270 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/270/]) HBASE-6787 Convert RowProcessorProtocol to protocol buffer service - forgot to checkin IncrementCounterProcessorTestProtos.java (Revision 1412389) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/protobuf/generated/IncrementCounterProcessorTestProtos.java Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch, 6787-7.patch, 6787-8.1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499653#comment-13499653
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553949/6787-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
98 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestDrainingServer
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3358//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch,
6787-5.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499857#comment-13499857 ] Devaraj Das commented on HBASE-6787: bq. Yeah.. that's true. Should we move this work to a different jira (where we make the relevant changes for the other coprocessor implementations as well). Raised HBASE-7182 for the interface addition. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499981#comment-13499981
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554075/6787-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
98 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3362//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch,
6787-5.patch, 6787-6.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499983#comment-13499983 ] Devaraj Das commented on HBASE-6787: Test TestRegionServerCoprocessorExceptionWithAbort passes locally. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch, 6787-5.patch, 6787-6.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499520#comment-13499520
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553915/6787-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3356//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499535#comment-13499535
]
Ted Yu commented on HBASE-6787:
---
nit: on review board, I can see a few white spaces.
{code}
+public class RowProcessorClient {
{code}
Please add short javadoc and annotation for audience.
{code}
+ * The request argument contains the processor. The processor object defines
...
* @return The processing result
*/
...
+ public void process(RpcController controller, RowProcessorRequest request,
{code}
There is no return value any more. The request contains information for
constructing processor (see constructRowProcessorFromRequest), I think the
first sentence above should be slightly modified.
{code}
+Class? superClass = processor.getClass();
+Type type = superClass.getGenericSuperclass();
{code}
The variable naming above might be a little confusing :-)
{code}
+Type t1 = ((ParameterizedType)type).getActualTypeArguments()[1];
{code}
Do you need to check that there're two type arguments ?
{code}
-public abstract class BaseRowProcessorT implements RowProcessorT {
+public abstract class BaseRowProcessorS extends Message,T extends Message
{code}
Better describe what the two Messages mean. This is javadoc at the beginning of
RowProcessor. It would be nice to elaborate above.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499537#comment-13499537 ] Devaraj Das commented on HBASE-6787: Thanks, Ted for catching that assert (I had forgotten to remove this line from the final patch). I'll upload another patch with the javadoc stuff updated. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13499541#comment-13499541
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553923/6787-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
99 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 24 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3357//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch, 6787-3.patch, 6787-4.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497562#comment-13497562 ] Devaraj Das commented on HBASE-6787: bq. between this and the ColumnInterpreter stuff for AggregateService, we seem to be working towards a common interface for the user code serialization/deserialization bits Yeah.. that's true. Should we move this work to a different jira (where we make the relevant changes for the other coprocessor implementations as well). bq. But I think we're adding some complexity to remain serialization agnostic in this case. Is the need there to make the trade off worth it? I am not sure if we should enforce PB for users to be able to use the coprocessor service, but I can go either way, and yeah doing pure PB everywhere (in framework user code) would probably make the implementation of the framework code simpler. Will take a pass at it... Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497619#comment-13497619 ] stack commented on HBASE-6787: -- +1 for enforcing PB going forward especially if it means can loose some complexity. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496394#comment-13496394
]
Gary Helmling commented on HBASE-6787:
--
Sorry for the delay in the review. Overall this looks good to me, but I'm
still trying to think through the client usage.
The one thing eating at me is that between this and the ColumnInterpreter stuff
for AggregateService, we seem to be working towards a common interface for the
user code serialization/deserialization bits:
Request ser/de:
{code:java}
public ByteString rowProcessorSpecificData() throws IOException {}
public void initialize(ByteString bytes) throws IOException {}
{code}
Response ser/de:
{code:java}
public ByteString getProtoForResult(T t) {}
public T parseResponseAsResultType(byte[] response) {}
{code}
Given the very similar pattern here, does it make sense to try to factor these
out into a common interface that can be shared?
I'm not sure it's really necessary to remain serialization agnostic for the
user code, either. Would it be simpler if we just required PB serialization
for these bits?
RowProcessor could represent it's serialization as a message:
{code:java}
Message getRequestData() throws IOException;
void initialize(Message request) throws IOException;
{code}
(These could also be parameterized for additional type safety.)
And the response type could similarly be a message:
{code:java}
T getResult(); // where T extends Message
{code}
Clients would still get a typed response that they could extract values from
without the additional {{getProtoForResult(T t)}} and
{{parseResponseAsResultType(byte[] bytes)}} methods.
Does this make sense? Of course you could still do the PB-conversions yourself
for PB serialization with the original patch. But I think we're adding some
complexity to remain serialization agnostic in this case. Is the need there to
make the trade off worth it?
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481469#comment-13481469 ] Devaraj Das commented on HBASE-6787: Did my response to the questions make sense, [~stack] ? Anything else pending from my end on this one? Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch, 6787-2.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480555#comment-13480555
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550108/6787-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3096//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch, 6787-2.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480219#comment-13480219 ] Devaraj Das commented on HBASE-6787: Thanks for taking a look, [~stack]. The overall idea is that all the CP protocol conversions take into account only those protocols that are part of the framework, and not necessarily the user code (like a particular implementation of ColumnInterpreter). The CP framework tries to be agnostic about what serialization techniques the user code chooses to use (so yeah that could be PB or writable or anything else; to the CP framework they are just a bunch of bytes). I'll respond to your other comments shortly (need to look at code for those). Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480261#comment-13480261 ] Devaraj Das commented on HBASE-6787: bq. This ability to add arbitrary bytes? If so, does it have to part of the general RowProcessor? Can it not be specific to aggregating CP? Just wondering. Maybe, I shouldn't have mixed up the small fixes with this patch. Yes, this code belongs purely to Aggregating CP and while doing this patch I noticed an obvious optimization that I could do (create one ByteString object instead of two)... Should I raise a separate jira for the two unrelated changes (this one and there is another to do with Javadoc in ColumnInterpreter.java), or is it okay to leave them as part of this patch. bq. I ain't sure whats going on in RowProcessorClient. It has a method getRowProcessorPB that takes and returns generics of RowProcessorArgument? I don't follow what is going on. This method just converts the passed RowProcessorT to a PB so that it can be serialized when the RowProcessorEndpoint CP Service is invoked and that's all. The first T that is there in the method signature to take care of Java generics syntax since the argument needs to have the generics type T (without the first T the thing won't compile...). bq. In BaseRowProcessorEndpoint#process, we take a RowProcessorArgument. Should that be a RowProcessorRequest? (Ditto here constructRowProcessorFromRequest(RowProcessorArgument request)) Yeah it could be.. will rename. bq. What is getProtoForResultType that takes a Result? Why ResultType in the method name? This is used at the server side. This converts the received result instance (of type T) to PB (so that the CP framework can serialize it over the wire to the client). I guess I should remove the 'Type' string from the method name. bq. The initialize taking 'bytes' drops typing, ability to extend (unless these arbitrary bytes are serialized pb themselves) Yes, as I said in my previous jira comment, the CP endpoint framework is agnostic to the actual application types. bq. When would there be different result types? (looking at getProtoForResultType in the Interface) And it returns serialized pb? For different implementations of RowProcessor interface, the types could be different. [I'll remove the 'Type' from the method name - that's confusing things it seems.] bq. So result of the CP is arbitrary bytes for the client to interpret? Can it not be a pb? Ditto as my previous jira comment. bq. Sorry if my comments above are clueless for I am when it comes to these endpoint CPs. That's okay, [~stack]. Those were good questions. Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[ https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479541#comment-13479541 ] Devaraj Das commented on HBASE-6787: BTW I fixed some minor things here that I noticed from previous patches (in files AggregationClient.java ColumnInterpreter.java). Convert RowProcessorProtocol to protocol buffer service --- Key: HBASE-6787 URL: https://issues.apache.org/jira/browse/HBASE-6787 Project: HBase Issue Type: Sub-task Components: Coprocessors Reporter: Gary Helmling Assignee: Devaraj Das Fix For: 0.96.0 Attachments: 6787-1.patch With coprocessor endpoints now exposed as protobuf defined services, we should convert over all of our built-in endpoints to PB services. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479591#comment-13479591
]
Hadoop QA commented on HBASE-6787:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549789/6787-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
81 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3085//console
This message is automatically generated.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6787) Convert RowProcessorProtocol to protocol buffer service
[
https://issues.apache.org/jira/browse/HBASE-6787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479645#comment-13479645
]
stack commented on HBASE-6787:
--
Thanks for doing this DD.
Looking at this:
{code}
-if (ci.columnInterpreterSpecificData() != null) {
- requestBuilder.setInterpreterSpecificBytes(
-ci.columnInterpreterSpecificData());
+ByteString columnInterpreterSpecificData = null;
+if ((columnInterpreterSpecificData = ci.columnInterpreterSpecificData())
+ != null) {
+
requestBuilder.setInterpreterSpecificBytes(columnInterpreterSpecificData);
{code}
... you are doing straight mapping of old style to new pb style. Thats fine
for this CP. Going forward though, we're expecting folks to define their own
pbs when they do their own endpoints, right? And if so, they won't be doing
stuff like the above passing arbitrary byte arrays but rather, they'll be pb
attributes? Or is this patch adding this functionality? This ability to add
arbitrary bytes? If so, does it have to part of the general RowProcessor? Can
it not be specific to aggregating CP? Just wondering.
I ain't sure whats going on in RowProcessorClient. It has a method
getRowProcessorPB that takes and returns generics of RowProcessorArgument? I
don't follow what is going on.
In BaseRowProcessorEndpoint#process, we take a RowProcessorArgument. Should
that be a RowProcessorRequest? (Ditto here
constructRowProcessorFromRequest(RowProcessorArgument request))
What is getProtoForResultType that takes a Result? Why ResultType in the
method name?
The initialize taking 'bytes' drops typing, ability to extend (unless these
arbitrary bytes are serialized pb themselves)
When would there be different result types? (looking at getProtoForResultType
in the Interface) And it returns serialized pb?
So result of the CP is arbitrary bytes for the client to interpret? Can it not
be a pb?
Sorry if my comments above are clueless for I am when it comes to these
endpoint CPs.
Convert RowProcessorProtocol to protocol buffer service
---
Key: HBASE-6787
URL: https://issues.apache.org/jira/browse/HBASE-6787
Project: HBase
Issue Type: Sub-task
Components: Coprocessors
Reporter: Gary Helmling
Assignee: Devaraj Das
Fix For: 0.96.0
Attachments: 6787-1.patch
With coprocessor endpoints now exposed as protobuf defined services, we
should convert over all of our built-in endpoints to PB services.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
