[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989219#comment-12989219
 ] 

Hudson commented on HBASE-3305:
---

Integrated in HBase-TRUNK #1726 (See 
[https://hudson.apache.org/hudson/job/HBase-TRUNK/1726/])


> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Fix For: 0.90.1, 0.92.0
>
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969162#action_12969162
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Jonathan Gray" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2049
---

Ship it!


looks good, thanks ted!  i will commit the final patch to trunk.


trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


line is > 80 chars but will fix on commit, don't worry


- Jonathan





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969153#action_12969153
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/
---

(Updated 2010-12-07 18:28:46.368066)


Review request for hbase, stack and Jonathan Gray.


Changes
---

Reverted movement of imports


Summary
---

Adopted round-robin assignment as default for regions specified when table is 
created.


This addresses bug HBASE-3305.
http://issues.apache.org/jira/browse/HBASE-3305


Diffs (updated)
-

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1043216 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1043216 

Diff: http://review.cloudera.org/r/1271/diff


Testing
---

Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
They passed.


Thanks,

Ted




> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969149#action_12969149
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/
---

(Updated 2010-12-07 18:25:05.129171)


Review request for hbase, stack and Jonathan Gray.


Changes
---

I used Organize Imports in Eclipse for AssignmentManager


Summary
---

Adopted round-robin assignment as default for regions specified when table is 
created.


This addresses bug HBASE-3305.
http://issues.apache.org/jira/browse/HBASE-3305


Diffs (updated)
-

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1043216 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1043216 

Diff: http://review.cloudera.org/r/1271/diff


Testing
---

Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
They passed.


Thanks,

Ted




> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969148#action_12969148
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2048
---



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


I wrap InterruptedException in IOException.


- Ted





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969135#action_12969135
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Jonathan Gray" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2047
---


almost :)


trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


why is this and above import of EventType moved in your diff?



trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


white space here and two lines below



trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java


put back the previous comment about round-robin, and whitespace (tabs?)



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


Generally it's not good or "right" to catch, log, and ignore an IE.  How is 
this handled elsewhere?


- Jonathan





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969107#action_12969107
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/
---

(Updated 2010-12-07 16:56:46.150530)


Review request for hbase, stack and Jonathan Gray.


Changes
---

Added AssignmentManager.assignUserRegions() which is called from createTable() 
and assignAllUserRegions()


Summary
---

Adopted round-robin assignment as default for regions specified when table is 
created.


This addresses bug HBASE-3305.
http://issues.apache.org/jira/browse/HBASE-3305


Diffs (updated)
-

  trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 
1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1043216 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1043216 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1043216 

Diff: http://review.cloudera.org/r/1271/diff


Testing
---

Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
They passed.


Thanks,

Ted




> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969080#action_12969080
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Jonathan Gray" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2042
---


Almost there.  Some spacing only changes still in here and need to move out 
logic into AM method.


trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


still tabbing changes here and next method signature as well



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


same as stack's original comment.  this logic should be in 
AssignmentManager.  I wouldn't reuse the method 'assignAllUserRegions' because 
it says "all" in it.  A method 'assignUserRegions' which takes a list and does 
a bulk assign w/ round-robin would make sense . 'assignAllUserRegions' could 
then call it once it makes a list of regions.


- Jonathan





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968610#action_12968610
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/
---

(Updated 2010-12-06 23:22:29.259676)


Review request for hbase, stack and Jonathan Gray.


Changes
---

Removes tabs.
Format code using multiple of two spaces.


Summary
---

Adopted round-robin assignment as default for regions specified when table is 
created.


This addresses bug HBASE-3305.
http://issues.apache.org/jira/browse/HBASE-3305


Diffs (updated)
-

  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1042922 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1042922 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1042922 

Diff: http://review.cloudera.org/r/1271/diff


Testing
---

Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
They passed.


Thanks,

Ted




> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968608#action_12968608
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2038
---



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


A new patch will be uploaded that reverts such changes.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


I think you're implying rewriting
AssignmentManager.assignAllUserRegions().

How about creating this method:
assignAllUserRegions(List regions).

finishInitialization() would pass null to the above method to indicate that 
all user regions should be assigned.
createTable() would pass the list of regions for the new table.

This way, BulkStartupAssigner doesn't appear in HMaster.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


Yes. I prefer space between if and left parenthesis.

I will revert anyway.


- Ted





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968579#action_12968579
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: st...@duboce.net

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/#review2037
---

Ship it!


Looks good Ted.  Below are a few pointers mostly on formatting and then a few 
questions.  Thanks for making the patch.


trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


Do you need to pollute HMaster with this AssignmentManager inner class?



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


FYI, don't make these kinda formatting changes in a patch... its 
distracting and the change you are making is against the convention used in the 
rest of this file.  Just FYI.  No biggie.



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


Yeah, maybe these lines belong inside a method that is inside 
AssignmentManager?  What you think Ted?



trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java


What changed on this line?  White space?



trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java


Convention is two spaces for tab in hbase and hadoop.  This seems like 
something else?



trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


FYI, tab is two spaces... we indent in multiples of two spaces.



trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java


Good.  Nice test.


- stack





> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968354#action_12968354
 ] 

HBase Review Board commented on HBASE-3305:
---

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1271/
---

(Updated 2010-12-06 10:42:26.792838)


Review request for hbase, stack and Jonathan Gray.


Changes
---

Add hbase group as reviewer


Summary
---

Adopted round-robin assignment as default for regions specified when table is 
created.


This addresses bug HBASE-3305.
http://issues.apache.org/jira/browse/HBASE-3305


Diffs
-

  trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1042725 
  trunk/src/main/java/org/apache/hadoop/hbase/master/LoadBalancer.java 1042725 
  trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1042725 

Diff: http://review.cloudera.org/r/1271/diff


Testing
---

Put unit tests for this change inside TestAdmin.testCreateTableWithRegions()
They passed.


Thanks,

Ted




> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>Assignee: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305-round-robin-unit-test.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Jonathan Gray (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967012#action_12967012
 ] 

Jonathan Gray commented on HBASE-3305:
--

Ted, you want to put this patch up on review board?  Looks pretty close to 
being done but a few small comments.  You can reuse that numServers variable in 
the LoadBalancer method rather than calling .size() every time.  Get rid of the 
"there are x servers online" debug message.

Is there a unit test for the round-robin method?  Want to write on?  It's a 
simple algorithm but always good to have something to detect regressions.

Also, looks like you have tabs in the diff.  HBase style is 2 spaces and no 
tabs.

> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
> Attachments: hbase-3305-array.patch, 
> hbase-3305-default-round-robin.patch, hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966899#action_12966899
 ] 

Ted Yu commented on HBASE-3305:
---

If the total number of regions is small compared to the number of region 
servers, the benefit of round-robin is less obvious.
Our use case would do round-robin assignment for every table we create. I have 
no problem making this the default.

I plan to move the initialization of mRandomizer out of roundRobinAssignment()  
for better randomness.


> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
> Attachments: hbase-3305-array-random.patch, hbase-3305-array.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Jonathan Gray (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966892#action_12966892
 ] 

Jonathan Gray commented on HBASE-3305:
--

I would rather not complicate the API and introduce new enums all the way to 
the client.  I see no reason why you'd want random assignment not round-robin 
w/ random starting point, so I see no reason to make this configurable (at 
least on a per create table call basis).  If anything, make it a Configuration 
parameter but I don't even think that's necessary.

> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
> Attachments: hbase-3305-array-random.patch, hbase-3305-array.patch, 
> hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Jonathan Gray (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966883#action_12966883
 ] 

Jonathan Gray commented on HBASE-3305:
--

Seems reasonable to me that we'd have this as the default rather than all of 
the new option enum stuff.  When would you not want round robin?  I think the 
one thing to change in the round robin assignment is to start at a random 
starting point.

> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
> Attachments: hbase-3305.patch
>
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HBASE-3305) Allow round-robin distribution for table created with multiple regions

[Ted Yu (JIRA)]

[ 
https://issues.apache.org/jira/browse/HBASE-3305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966772#action_12966772
 ] 

Ted Yu commented on HBASE-3305:
---

Currently we have this in HMaster:
{code}
  private synchronized void createTable(final HRegionInfo [] newRegions, 
boolean sync)
{code}

Maybe we should change the second parameter to EnumSet so 
that both sync and round-robin options can be expressed.

> Allow round-robin distribution for table created with multiple regions
> --
>
> Key: HBASE-3305
> URL: https://issues.apache.org/jira/browse/HBASE-3305
> Project: HBase
>  Issue Type: Improvement
>  Components: master
>Affects Versions: 0.20.6
>Reporter: Ted Yu
>
> We can distribute the initial regions created for a new table in round-robin 
> fashion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.