[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782865
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:24
Start Date: 20/Jun/22 08:24
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901388685
##
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##
@@ -4678,6 +4678,12 @@ public static enum ConfVars {
HIVE_ACID_DIRECT_INSERT_ENABLED("hive.acid.direct.insert.enabled", true,
"Enable writing the data files directly to the table's final
destination instead of the staging directory."
+ "This optimization only applies on INSERT operations on ACID
tables."),
+
HIVE_ACID_CHECK_FOR_CONCURRENT_CTAS_ENABLED("hive.acid.check.for.concurrent.ctas.enabled",
false,
Review Comment:
unused config
Issue Time Tracking
---
Worklog Id: (was: 782865)
Time Spent: 7h 40m (was: 7.5h)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[ https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782864 ] ASF GitHub Bot logged work on HIVE-26244: - Author: ASF GitHub Bot Created on: 20/Jun/22 08:24 Start Date: 20/Jun/22 08:24 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3307: URL: https://github.com/apache/hive/pull/3307#discussion_r901388096 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -3163,6 +3168,7 @@ private boolean shouldUpdateTxnComponent(long txnid, LockRequest rqst, LockCompo case INSERT: case UPDATE: case DELETE: +case CTAS: Review Comment: do we need new operationType here? Issue Time Tracking --- Worklog Id: (was: 782864) Time Spent: 7.5h (was: 7h 20m) > Implementing locking for concurrent ctas > > > Key: HIVE-26244 > URL: https://issues.apache.org/jira/browse/HIVE-26244 > Project: Hive > Issue Type: Improvement >Reporter: Simhadri G >Assignee: Simhadri G >Priority: Major > Labels: pull-request-available > Time Spent: 7.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782870
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:33
Start Date: 20/Jun/22 08:33
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901397117
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -5280,23 +5291,24 @@ is performed on that db (e.g. show tables, created
table, etc).
LOG.debug("Failure to acquire lock({} intLockId:{} {}), blocked by
({})", JavaUtils.lockIdToString(extLockId),
intLockId, JavaUtils.txnIdToString(txnId), blockedBy);
-if (zeroWaitReadEnabled && isValidTxn(txnId)) {
+if ((zeroWaitReadEnabled || isExclusiveCTAS) && isValidTxn(txnId)) {
LockType lockType = LockTypeUtil.getLockTypeFromEncoding(lockChar)
- .orElseThrow(() -> new MetaException("Unknown lock type: " +
lockChar));
-
- if (lockType == LockType.SHARED_READ) {
-String cleanupQuery = "DELETE FROM \"HIVE_LOCKS\" WHERE
\"HL_LOCK_EXT_ID\" = " + extLockId;
+ .orElseThrow(() -> new MetaException("Unknown lock type: " +
lockChar));
-LOG.debug("Going to execute query: <" + cleanupQuery + ">");
-stmt.executeUpdate(cleanupQuery);
+ if (lockType == LockType.SHARED_READ || isExclusiveCTAS) {
+if (!isExclusiveCTAS) {
Review Comment:
delete from HIVE_LOCKS should be done for isExclusiveCTAS as well
Issue Time Tracking
---
Worklog Id: (was: 782870)
Time Spent: 7h 50m (was: 7h 40m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[ https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782873 ] ASF GitHub Bot logged work on HIVE-26244: - Author: ASF GitHub Bot Created on: 20/Jun/22 08:35 Start Date: 20/Jun/22 08:35 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3307: URL: https://github.com/apache/hive/pull/3307#discussion_r901399288 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -3163,6 +3168,7 @@ private boolean shouldUpdateTxnComponent(long txnid, LockRequest rqst, LockCompo case INSERT: case UPDATE: case DELETE: +case CTAS: Review Comment: was the operationType for CTAS = 'i' before so we had to include it here? Issue Time Tracking --- Worklog Id: (was: 782873) Time Spent: 8h (was: 7h 50m) > Implementing locking for concurrent ctas > > > Key: HIVE-26244 > URL: https://issues.apache.org/jira/browse/HIVE-26244 > Project: Hive > Issue Type: Improvement >Reporter: Simhadri G >Assignee: Simhadri G >Priority: Major > Labels: pull-request-available > Time Spent: 8h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[ https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782874 ] ASF GitHub Bot logged work on HIVE-26244: - Author: ASF GitHub Bot Created on: 20/Jun/22 08:40 Start Date: 20/Jun/22 08:40 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3307: URL: https://github.com/apache/hive/pull/3307#discussion_r901399288 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -3163,6 +3168,7 @@ private boolean shouldUpdateTxnComponent(long txnid, LockRequest rqst, LockCompo case INSERT: case UPDATE: case DELETE: +case CTAS: Review Comment: was the operationType for CTAS = 'i' before so we had to include it here? I think that should be removed, it we didn't insert before Issue Time Tracking --- Worklog Id: (was: 782874) Time Spent: 8h 10m (was: 8h) > Implementing locking for concurrent ctas > > > Key: HIVE-26244 > URL: https://issues.apache.org/jira/browse/HIVE-26244 > Project: Hive > Issue Type: Improvement >Reporter: Simhadri G >Assignee: Simhadri G >Priority: Major > Labels: pull-request-available > Time Spent: 8h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782875
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:41
Start Date: 20/Jun/22 08:41
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901405027
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##
@@ -310,6 +310,11 @@ abstract class TxnHandler implements TxnStore,
TxnStore.MutexAPI {
"INNER JOIN \"TXNS\" ON \"TC_TXNID\" = \"TXN_ID\" WHERE
\"TXN_STATE\" = " + TxnStatus.ABORTED +
" GROUP BY \"TC_DATABASE\", \"TC_TABLE\", \"TC_PARTITION\" HAVING
COUNT(\"TXN_ID\") > ?";
+ private static final String EX_CTAS_ERR_MSG =
Review Comment:
rename to `EXCL_CTAS_ERR_MSG`
Issue Time Tracking
---
Worklog Id: (was: 782875)
Time Spent: 8h 20m (was: 8h 10m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782876
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:47
Start Date: 20/Jun/22 08:47
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901411252
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3086,6 +3086,13 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
output.getWriteType().name()));
break;
+ case CTAS:
+if (AcidUtils.isExclusiveCTASEnabled(conf) &&
AcidUtils.isTransactionalTable(t)) {
+ compBuilder.setExclWrite();
+ compBuilder.setOperationType(DataOperationType.CTAS);
Review Comment:
set to `NO_TXN`
Issue Time Tracking
---
Worklog Id: (was: 782876)
Time Spent: 8.5h (was: 8h 20m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782877
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:50
Start Date: 20/Jun/22 08:50
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901411913
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3104,6 +3111,11 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
return lockComponents;
}
+ public static boolean isExclusiveCTAS(List lockComponents,
HiveConf conf) {
+return lockComponents.stream().anyMatch(lc -> DataOperationType.CTAS ==
lc.getOperationType()
Review Comment:
use Set outputs.getType
isExclusiveCTAS(work.getOutputs())
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/OperationType.java:
##
@@ -34,7 +34,8 @@ public enum OperationType {
INSERT('i', DataOperationType.INSERT),
UPDATE('u', DataOperationType.UPDATE),
DELETE('d', DataOperationType.DELETE),
- COMPACT('c', null);
+ COMPACT('c', null),
+ CTAS('t', DataOperationType.CTAS);
Review Comment:
remove this
Issue Time Tracking
---
Worklog Id: (was: 782877)
Time Spent: 8h 40m (was: 8.5h)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782879
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 08:51
Start Date: 20/Jun/22 08:51
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901411913
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3104,6 +3111,11 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
return lockComponents;
}
+ public static boolean isExclusiveCTAS(List lockComponents,
HiveConf conf) {
+return lockComponents.stream().anyMatch(lc -> DataOperationType.CTAS ==
lc.getOperationType()
Review Comment:
use Set'<'WriteEntity'>' outputs.getType
isExclusiveCTAS(work.getOutputs())
Issue Time Tracking
---
Worklog Id: (was: 782879)
Time Spent: 8h 50m (was: 8h 40m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782898
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 09:19
Start Date: 20/Jun/22 09:19
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901442197
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3086,6 +3086,13 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
output.getWriteType().name()));
break;
+ case CTAS:
+if (AcidUtils.isExclusiveCTASEnabled(conf) &&
AcidUtils.isTransactionalTable(t)) {
Review Comment:
Could we move `AcidUtils.isTransactionalTable(t)` check inside of
isExclusiveCTASEnabled?
Issue Time Tracking
---
Worklog Id: (was: 782898)
Time Spent: 9h (was: 8h 50m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 9h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=782901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782901
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 09:20
Start Date: 20/Jun/22 09:20
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901442197
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3086,6 +3086,13 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
output.getWriteType().name()));
break;
+ case CTAS:
+if (AcidUtils.isExclusiveCTASEnabled(conf) &&
AcidUtils.isTransactionalTable(t)) {
Review Comment:
Could we move `AcidUtils.isTransactionalTable(t)` check inside of
isExclusiveCTASEnabled?
AcidUtils.isExclusiveCTASEnabled(t, conf)
Issue Time Tracking
---
Worklog Id: (was: 782901)
Time Spent: 9h 10m (was: 9h)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GuangMing Lu reassigned HIVE-26342: --- Assignee: Aihua Xu > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Bug >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] and > [Harish > JP|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=harishjp] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GuangMing Lu updated HIVE-26342: Affects Version/s: All Versions > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Bug >Affects Versions: All Versions >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] and > [Harish > JP|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=harishjp] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26291) Ranger client file descriptor leak
[ https://issues.apache.org/jira/browse/HIVE-26291?focusedWorklogId=782923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782923 ] ASF GitHub Bot logged work on HIVE-26291: - Author: ASF GitHub Bot Created on: 20/Jun/22 10:00 Start Date: 20/Jun/22 10:00 Worklog Time Spent: 10m Work Description: adrian-wang commented on PR #3345: URL: https://github.com/apache/hive/pull/3345#issuecomment-1160236604 @kgyrtkirk Could you please re-trigger the tests? Issue Time Tracking --- Worklog Id: (was: 782923) Time Spent: 1h (was: 50m) > Ranger client file descriptor leak > -- > > Key: HIVE-26291 > URL: https://issues.apache.org/jira/browse/HIVE-26291 > Project: Hive > Issue Type: Improvement >Reporter: Adrian Wang >Assignee: Adrian Wang >Priority: Minor > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Ranger Client has an fd leak -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26310) Remove unused junit runners from test-utils module
[
https://issues.apache.org/jira/browse/HIVE-26310?focusedWorklogId=782934&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782934
]
ASF GitHub Bot logged work on HIVE-26310:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 10:31
Start Date: 20/Jun/22 10:31
Worklog Time Spent: 10m
Work Description: zabetak closed pull request #3358: HIVE-26310: Remove
unused junit runners from test-utils module
URL: https://github.com/apache/hive/pull/3358
Issue Time Tracking
---
Worklog Id: (was: 782934)
Time Spent: 20m (was: 10m)
> Remove unused junit runners from test-utils module
> --
>
> Key: HIVE-26310
> URL: https://issues.apache.org/jira/browse/HIVE-26310
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
>Reporter: Stamatis Zampetakis
>Assignee: Stamatis Zampetakis
>Priority: Trivial
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The two classes under
> https://github.com/apache/hive/tree/master/testutils/src/java/org/apache/hive/testutils/junit/runners
> namely:
> *
> [ConcurrentTestRunner|https://github.com/apache/hive/blob/fe0f1a648b14cdf27edcf7a5d323cbd060104ebf/testutils/src/java/org/apache/hive/testutils/junit/runners/ConcurrentTestRunner.java]
> *
> [ConcurrentScheduler|https://github.com/apache/hive/blob/fe0f1a648b14cdf27edcf7a5d323cbd060104ebf/testutils/src/java/org/apache/hive/testutils/junit/runners/model/ConcurrentScheduler.java]
> have been introduced a long time ago by HIVE-2935 to somewhat parallelize
> execution for {{TestBeeLineDriver}}.
> However, since HIVE-1 (resolved 6 years ago) they are not used by anyone
> and unlikely to be used again in the future since there are much more modern
> alternatives.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (HIVE-26310) Remove unused junit runners from test-utils module
[
https://issues.apache.org/jira/browse/HIVE-26310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stamatis Zampetakis resolved HIVE-26310.
Fix Version/s: 4.0.0-alpha-2
Resolution: Fixed
Fixed in
https://github.com/apache/hive/commit/948f9fb56a00e981cd653146de44ae82307b4f2f.
Thanks for the review [~ayushsaxena]!
> Remove unused junit runners from test-utils module
> --
>
> Key: HIVE-26310
> URL: https://issues.apache.org/jira/browse/HIVE-26310
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
>Reporter: Stamatis Zampetakis
>Assignee: Stamatis Zampetakis
>Priority: Trivial
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The two classes under
> https://github.com/apache/hive/tree/master/testutils/src/java/org/apache/hive/testutils/junit/runners
> namely:
> *
> [ConcurrentTestRunner|https://github.com/apache/hive/blob/fe0f1a648b14cdf27edcf7a5d323cbd060104ebf/testutils/src/java/org/apache/hive/testutils/junit/runners/ConcurrentTestRunner.java]
> *
> [ConcurrentScheduler|https://github.com/apache/hive/blob/fe0f1a648b14cdf27edcf7a5d323cbd060104ebf/testutils/src/java/org/apache/hive/testutils/junit/runners/model/ConcurrentScheduler.java]
> have been introduced a long time ago by HIVE-2935 to somewhat parallelize
> execution for {{TestBeeLineDriver}}.
> However, since HIVE-1 (resolved 6 years ago) they are not used by anyone
> and unlikely to be used again in the future since there are much more modern
> alternatives.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556325#comment-17556325 ] GuangMing Lu commented on HIVE-26342: - * Related discussion posts https://lists.apache.org/thread/sxcrcf4v9j630tl9domp0bn4m33bdq0s > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Bug >Affects Versions: All Versions >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] and > [Harish > JP|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=harishjp] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GuangMing Lu updated HIVE-26342: Issue Type: Task (was: Bug) > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Task >Affects Versions: All Versions >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] and > [Harish > JP|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=harishjp] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GuangMing Lu updated HIVE-26342: Description: h4. Hi [Aihua Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] , [Stamatis Zampetakis|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zabetak] h4. We don't have a EOL schedule for every version at present, can we discuss making one? was: h4. Hi [Aihua Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] and [Harish JP|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=harishjp] h4. We don't have a EOL schedule for every version at present, can we discuss making one? > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Task >Affects Versions: All Versions >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] , > [Stamatis > Zampetakis|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zabetak] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26298) Selecting complex types on migrated iceberg table does not work
[
https://issues.apache.org/jira/browse/HIVE-26298?focusedWorklogId=782952&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782952
]
ASF GitHub Bot logged work on HIVE-26298:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 11:38
Start Date: 20/Jun/22 11:38
Worklog Time Spent: 10m
Work Description: lcspinter merged PR #3383:
URL: https://github.com/apache/hive/pull/3383
Issue Time Tracking
---
Worklog Id: (was: 782952)
Time Spent: 1h 20m (was: 1h 10m)
> Selecting complex types on migrated iceberg table does not work
> ---
>
> Key: HIVE-26298
> URL: https://issues.apache.org/jira/browse/HIVE-26298
> Project: Hive
> Issue Type: Bug
>Reporter: Gergely Fürnstáhl
>Assignee: László Pintér
>Priority: Major
> Labels: pull-request-available
> Attachments: 1-a5d522f4-a065-44e6-983b-ba66596b4332.metadata.json
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I am working on implementing NameMapping in Impala (mainly replicating Hive's
> functionality) and ran into the following issue:
> {code:java}
> CREATE TABLE array_demo
> (
> int_primitive INT,
> int_array ARRAY,
> int_array_array ARRAY>,
> int_to_array_array_Map MAP>>
> )
> STORED AS ORC;
> INSERT INTO array_demo values (0, array(1), array(array(2), array(3,4)),
> map(5,array(array(6),array(7,8;
> select * from array_demo;
> +---+---+-++
> | array_demo.int_primitive | array_demo.int_array |
> array_demo.int_array_array | array_demo.int_to_array_array_map |
> +---+---+-++
> | 0 | [1] | [[2],[3,4]]
> | {5:[[6],[7,8]]} |
> +---+---+-++
> {code}
> Converting to iceberg
>
>
> {code:java}
> ALTER TABLE array_demo SET TBLPROPERTIES
> ('storage_handler'='org.apache.iceberg.mr.hive.HiveIcebergStorageHandler')
> select * from array_demo;
> INFO : Compiling
> command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe):
> select * from array_demo
> INFO : No Stats for default@array_demo, Columns: int_primitive, int_array,
> int_to_array_array_map, int_array_array
> INFO : Semantic Analysis Completed (retrial = false)
> INFO : Created Hive schema:
> Schema(fieldSchemas:[FieldSchema(name:array_demo.int_primitive, type:int,
> comment:null), FieldSchema(name:array_demo.int_array, type:array,
> comment:null), FieldSchema(name:array_demo.int_array_array,
> type:array>, comment:null),
> FieldSchema(name:array_demo.int_to_array_array_map,
> type:map>>, comment:null)], properties:null)
> INFO : Completed compiling
> command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe);
> Time taken: 0.036 seconds
> INFO : Executing
> command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe):
> select * from array_demo
> INFO : Completed executing
> command(queryId=gfurnstahl_20220608102746_54bf3e74-e12b-400b-94a9-4e4c9fe460fe);
> Time taken: 0.0 seconds
> INFO : OK
> Error: java.io.IOException: java.lang.IllegalArgumentException: Can not
> promote MAP type to INTEGER (state=,code=0)
> select int_primitive from array_demo;
> ++
> | int_primitive |
> ++
> | 0 |
> ++
> 1 row selected (0.088 seconds)
> {code}
> Removing schema.name-mapping.default solves it
> {code:java}
> ALTER TABLE array_demo UNSET TBLPROPERTIES ('schema.name-mapping.default');
> select * from array_demo;
> +---+---+-++
> | array_demo.int_primitive | array_demo.int_array |
> array_demo.int_array_array | array_demo.int_to_array_array_map |
> +---+---+-++
> | 0 | [1] | [[2],[3,4]]
> | {5:[[6],[7,8]]} |
> +---+---+-++
> {code}
> Possible cause:
>
> The name mapping generated and pushed into schema.name-mapping.default is
> different from the name mapping in the schema in the metadata.json (attached
> it)
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26021) Change integration tests under DBInstallBase to regular unit tests
[
https://issues.apache.org/jira/browse/HIVE-26021?focusedWorklogId=782958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782958
]
ASF GitHub Bot logged work on HIVE-26021:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 11:46
Start Date: 20/Jun/22 11:46
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request, #3389:
URL: https://github.com/apache/hive/pull/3389
### Why are the changes needed?
- Simplify execution of tests by developers and CI
- Extend test coverage to include `mysql` and `mssql` install upgrade tests
### Does this PR introduce _any_ user-facing change?
Only developers are affected since tests are now run differently.
### How was this patch tested?
```
mvn test -Dtest.groups=MetastoreCheckinTest -pl
standalone-metastore/metastore-server
-Dtest=ITestDerby,ITestOracle,ITestPostgres,ITestMssql,ITestMysql
```
Issue Time Tracking
---
Worklog Id: (was: 782958)
Remaining Estimate: 0h
Time Spent: 10m
> Change integration tests under DBInstallBase to regular unit tests
> --
>
> Key: HIVE-26021
> URL: https://issues.apache.org/jira/browse/HIVE-26021
> Project: Hive
> Issue Type: Improvement
> Components: Tests
>Reporter: Stamatis Zampetakis
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After HIVE-18588, some tests including those under
> [DBInstallBase|https://github.com/apache/hive/blob/1139c4b14db82a9e2316196819b35cfb713f34b5/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java]
> class have been marked as integration tests mainly to keep the test duration
> low.
> Nowadays, Hive developers rarely run all tests locally so separating between
> integration tests and unit tests does not provide a clear benefit. The
> separation adds maintenance cost and makes their execution more difficult
> scaring people away.
> The goal of this issue is to change the tests under {{DBInstallBase}} from
> "integration" tests back to regular unit tests and run them as part of the
> standard maven test phase without any fancy arguments.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HIVE-26021) Change integration tests under DBInstallBase to regular unit tests
[
https://issues.apache.org/jira/browse/HIVE-26021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HIVE-26021:
--
Labels: pull-request-available (was: )
> Change integration tests under DBInstallBase to regular unit tests
> --
>
> Key: HIVE-26021
> URL: https://issues.apache.org/jira/browse/HIVE-26021
> Project: Hive
> Issue Type: Improvement
> Components: Tests
>Reporter: Stamatis Zampetakis
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After HIVE-18588, some tests including those under
> [DBInstallBase|https://github.com/apache/hive/blob/1139c4b14db82a9e2316196819b35cfb713f34b5/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java]
> class have been marked as integration tests mainly to keep the test duration
> low.
> Nowadays, Hive developers rarely run all tests locally so separating between
> integration tests and unit tests does not provide a clear benefit. The
> separation adds maintenance cost and makes their execution more difficult
> scaring people away.
> The goal of this issue is to change the tests under {{DBInstallBase}} from
> "integration" tests back to regular unit tests and run them as part of the
> standard maven test phase without any fancy arguments.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HIVE-26343) TestWebHCatE2e causes surefire fork to exit and fails
[
https://issues.apache.org/jira/browse/HIVE-26343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556412#comment-17556412
]
Stamatis Zampetakis commented on HIVE-26343:
I will disable the test since it has been failing for a while now. If anyone is
willing to investigate this more feel free to pick this up.
> TestWebHCatE2e causes surefire fork to exit and fails
> -
>
> Key: HIVE-26343
> URL: https://issues.apache.org/jira/browse/HIVE-26343
> Project: Hive
> Issue Type: Bug
> Components: HCatalog, Testing Infrastructure
>Reporter: Stamatis Zampetakis
>Priority: Major
>
> Any attempt to run TestWebHCatE2e in current master
> ([https://github.com/apache/hive/commit/948f9fb56a00e981cd653146de44ae82307b4f2f])
> causes the surefire fork to exit and the test fails.
> {noformat}
> cd hcatalog/webhcat/svr && mvn test -Dtest=TestWebHCatE2e
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test)
> on project hive-webhcat: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire-reports
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException The forked VM terminated without properly saying goodbye.
> VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:460)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:301)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:249)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1217)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1063)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:889)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
>
[jira] [Work logged] (HIVE-26343) TestWebHCatE2e causes surefire fork to exit and fails
[
https://issues.apache.org/jira/browse/HIVE-26343?focusedWorklogId=783013&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783013
]
ASF GitHub Bot logged work on HIVE-26343:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 14:48
Start Date: 20/Jun/22 14:48
Worklog Time Spent: 10m
Work Description: zabetak opened a new pull request, #3390:
URL: https://github.com/apache/hive/pull/3390
### Why are the changes needed?
Test fails
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
mvn test -Dtest=TestWebHCatE2e
Issue Time Tracking
---
Worklog Id: (was: 783013)
Remaining Estimate: 0h
Time Spent: 10m
> TestWebHCatE2e causes surefire fork to exit and fails
> -
>
> Key: HIVE-26343
> URL: https://issues.apache.org/jira/browse/HIVE-26343
> Project: Hive
> Issue Type: Bug
> Components: HCatalog, Testing Infrastructure
>Reporter: Stamatis Zampetakis
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Any attempt to run TestWebHCatE2e in current master
> ([https://github.com/apache/hive/commit/948f9fb56a00e981cd653146de44ae82307b4f2f])
> causes the surefire fork to exit and the test fails.
> {noformat}
> cd hcatalog/webhcat/svr && mvn test -Dtest=TestWebHCatE2e
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test)
> on project hive-webhcat: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire-reports
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException The forked VM terminated without properly saying goodbye.
> VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:460)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:301)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:249)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1217)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1063)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:889)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.Singl
[jira] [Updated] (HIVE-26343) TestWebHCatE2e causes surefire fork to exit and fails
[
https://issues.apache.org/jira/browse/HIVE-26343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HIVE-26343:
--
Labels: pull-request-available (was: )
> TestWebHCatE2e causes surefire fork to exit and fails
> -
>
> Key: HIVE-26343
> URL: https://issues.apache.org/jira/browse/HIVE-26343
> Project: Hive
> Issue Type: Bug
> Components: HCatalog, Testing Infrastructure
>Reporter: Stamatis Zampetakis
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Any attempt to run TestWebHCatE2e in current master
> ([https://github.com/apache/hive/commit/948f9fb56a00e981cd653146de44ae82307b4f2f])
> causes the surefire fork to exit and the test fails.
> {noformat}
> cd hcatalog/webhcat/svr && mvn test -Dtest=TestWebHCatE2e
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test)
> on project hive-webhcat: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire-reports
> for the individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException:
> ExecutionException The forked VM terminated without properly saying goodbye.
> VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr &&
> /opt/jdks/jdk1.8.0_261/jre/bin/java -Xmx2048m -jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire/surefirebooter4564605288390864592.jar
> /home/stamatis/Projects/Apache/hive/hcatalog/webhcat/svr/target/surefire
> 2022-06-20T16-29-05_858-jvmRun1 surefire4795088574293215609tmp
> surefire_01535173811171404671tmp
> [ERROR] Error occurred in starting fork, check output in log
> [ERROR] Process Exit Code: 1
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.awaitResultsDone(ForkStarter.java:513)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:460)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:301)
> [ERROR] at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:249)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1217)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1063)
> [ERROR] at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:889)
> [ERROR] at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:137)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:210)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:156)
> [ERROR] at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:148)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:117)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:81)
> [ERROR] at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:56)
> [ERROR] at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:305)
> [ERROR] at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192)
> [ERROR] at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105)
> [ERROR] at org.apache.maven.cli.MavenCli.execute(MavenCli.java:957)
> [ERROR] at org.apache.maven.cli.MavenCli.doMain(MavenCli.jav
[jira] [Resolved] (HIVE-26342) About EOL schedule discussion
[ https://issues.apache.org/jira/browse/HIVE-26342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis resolved HIVE-26342. Resolution: Information Provided Hi [~luguangming] , this discussion does not need a Jira ticket. Reply to the respective thread in the mailing list directly. This is not something that can be decided by one or two people. It requires PMC approval and most likely a vote. > About EOL schedule discussion > - > > Key: HIVE-26342 > URL: https://issues.apache.org/jira/browse/HIVE-26342 > Project: Hive > Issue Type: Task >Affects Versions: All Versions >Reporter: GuangMing Lu >Assignee: Aihua Xu >Priority: Major > > h4. Hi [Aihua > Xu|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=aihuaxu] , > [Stamatis > Zampetakis|https://issues.apache.org/jira/secure/ViewProfile.jspa?name=zabetak] > h4. We don't have a EOL schedule for every version at present, can we discuss > making one? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HIVE-21045) Add HMS total api count stats and connection pool stats to metrics
[
https://issues.apache.org/jira/browse/HIVE-21045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556431#comment-17556431
]
Naveen Gangam commented on HIVE-21045:
--
[~karthik.manamcheri] Quick q? do you remember how you accessed these metrics
from HMS? For HMS, I found that it dumps the metrics to /tmp/report.json file.
I am guessing that we do not have a http server running in HMS, which is
probably why we cannot access it via a curl request. Can you please share
anything you may remember on this? Thank you
> Add HMS total api count stats and connection pool stats to metrics
> --
>
> Key: HIVE-21045
> URL: https://issues.apache.org/jira/browse/HIVE-21045
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
>Reporter: Karthik Manamcheri
>Assignee: Karthik Manamcheri
>Priority: Minor
> Fix For: 3.2.0, 4.0.0, 4.0.0-alpha-1
>
> Attachments: HIVE-21045.1.patch, HIVE-21045.2.branch-3.patch,
> HIVE-21045.2.patch, HIVE-21045.3.patch, HIVE-21045.4.patch,
> HIVE-21045.5.patch, HIVE-21045.6.patch, HIVE-21045.7.patch,
> HIVE-21045.branch-3.patch
>
>
> There are two key metrics which I think we lack and which would be really
> great to help with scaling visibility in HMS.
> *Total API calls duration stats*
> We already compute and log the duration of API calls in the {{PerfLogger}}.
> We don't have any gauge or timer on what the average duration of an API call
> is for the past some bucket of time. This will give us an insight into if
> there is load on the server which is increasing the average API response time.
>
> *Connection Pool stats*
> We can use different connection pooling libraries such as bonecp or hikaricp.
> These pool managers expose statistics such as average time waiting to get a
> connection, number of connections active, etc. We should expose this as a
> metric so that we can track if the the connection pool size configured is too
> small and we are saturating!
> These metrics would help catch problems with HMS resource contention before
> they actually have jobs failing.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26208) Exception in Vectorization with Decimal64 to Decimal casting
[
https://issues.apache.org/jira/browse/HIVE-26208?focusedWorklogId=783110&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783110
]
ASF GitHub Bot logged work on HIVE-26208:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:15
Start Date: 20/Jun/22 18:15
Worklog Time Spent: 10m
Work Description: ramesh0201 merged PR #3344:
URL: https://github.com/apache/hive/pull/3344
Issue Time Tracking
---
Worklog Id: (was: 783110)
Time Spent: 0.5h (was: 20m)
> Exception in Vectorization with Decimal64 to Decimal casting
>
>
> Key: HIVE-26208
> URL: https://issues.apache.org/jira/browse/HIVE-26208
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
>Reporter: Steve Carlin
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The following query fails:
>
> {code:java}
> select count(*)
> from
> int_txt
> where
> (( 1.0 * i) / ( 1.0 * i)) > 1.2;
> {code}
> with the following exception:
>
> {code:java}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColDivideDecimalColumn.evaluate(DecimalColDivideDecimalColumn.java:59)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:334)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FilterDecimalColGreaterDecimalScalar.evaluate(FilterDecimalColGreaterDecimalScalar.java:62)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorFilterOperator.process(VectorFilterOperator.java:125)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:919)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:171)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.deliverVectorizedRowBatch(VectorMapOperator.java:809)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:900)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> ... 19 more
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (HIVE-26208) Exception in Vectorization with Decimal64 to Decimal casting
[
https://issues.apache.org/jira/browse/HIVE-26208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556496#comment-17556496
]
Ramesh Kumar Thangarajan commented on HIVE-26208:
-
Thanks [~scarlin] for the patch, I just merged the patch.
> Exception in Vectorization with Decimal64 to Decimal casting
>
>
> Key: HIVE-26208
> URL: https://issues.apache.org/jira/browse/HIVE-26208
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
>Reporter: Steve Carlin
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The following query fails:
>
> {code:java}
> select count(*)
> from
> int_txt
> where
> (( 1.0 * i) / ( 1.0 * i)) > 1.2;
> {code}
> with the following exception:
>
> {code:java}
> Caused by: java.lang.ClassCastException:
> org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector cannot be cast to
> org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColDivideDecimalColumn.evaluate(DecimalColDivideDecimalColumn.java:59)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression.evaluateChildren(VectorExpression.java:334)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FilterDecimalColGreaterDecimalScalar.evaluate(FilterDecimalColGreaterDecimalScalar.java:62)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorFilterOperator.process(VectorFilterOperator.java:125)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.Operator.vectorForward(Operator.java:919)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:171)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.deliverVectorizedRowBatch(VectorMapOperator.java:809)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> at
> org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:900)
> ~[hive-exec-4.0.0-alpha-2-SNAPSHOT.jar:4.0.0-alpha-2-SNAPSHOT]
> ... 19 more
> {code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[ https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783129 ] ASF GitHub Bot logged work on HIVE-21456: - Author: ASF GitHub Bot Created on: 20/Jun/22 21:47 Start Date: 20/Jun/22 21:47 Worklog Time Spent: 10m Work Description: hsnusonic commented on code in PR #3381: URL: https://github.com/apache/hive/pull/3381#discussion_r901975625 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: ## @@ -63,10 +63,14 @@ import org.eclipse.jetty.security.ConstraintMapping; import org.eclipse.jetty.security.ConstraintSecurityHandler; +import org.eclipse.jetty.server.HttpChannel; import org.eclipse.jetty.server.HttpConfiguration; import org.eclipse.jetty.server.HttpConnectionFactory; +import org.eclipse.jetty.server.Request; import org.eclipse.jetty.server.Server; import org.eclipse.jetty.server.ServerConnector; + Review Comment: nit: additional empty line? Issue Time Tracking --- Worklog Id: (was: 783129) Time Spent: 7h 10m (was: 7h) > Hive Metastore Thrift over HTTP > --- > > Key: HIVE-21456 > URL: https://issues.apache.org/jira/browse/HIVE-21456 > Project: Hive > Issue Type: New Feature > Components: Metastore, Standalone Metastore >Reporter: Amit Khanna >Assignee: Sourabh Goyal >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, > HIVE-21456.4.patch, HIVE-21456.patch > > Time Spent: 7h 10m > Remaining Estimate: 0h > > Hive Metastore currently doesn't have support for HTTP transport because of > which it is not possible to access it via Knox. Adding support for Thrift > over HTTP transport will allow the clients to access via Knox -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[ https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=783128&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783128 ] ASF GitHub Bot logged work on HIVE-26244: - Author: ASF GitHub Bot Created on: 20/Jun/22 21:47 Start Date: 20/Jun/22 21:47 Worklog Time Spent: 10m Work Description: simhadri-g commented on code in PR #3307: URL: https://github.com/apache/hive/pull/3307#discussion_r901984683 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ## @@ -3163,6 +3168,7 @@ private boolean shouldUpdateTxnComponent(long txnid, LockRequest rqst, LockCompo case INSERT: case UPDATE: case DELETE: +case CTAS: Review Comment: It was NO_TXN before. Issue Time Tracking --- Worklog Id: (was: 783128) Time Spent: 9h 20m (was: 9h 10m) > Implementing locking for concurrent ctas > > > Key: HIVE-26244 > URL: https://issues.apache.org/jira/browse/HIVE-26244 > Project: Hive > Issue Type: Improvement >Reporter: Simhadri G >Assignee: Simhadri G >Priority: Major > Labels: pull-request-available > Time Spent: 9h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783130&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783130
]
ASF GitHub Bot logged work on HIVE-21456:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 21:48
Start Date: 20/Jun/22 21:48
Worklog Time Spent: 10m
Work Description: hsnusonic commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r901977331
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##
@@ -461,6 +459,14 @@ public Thread newThread(@NotNull Runnable r) {
// TODO: AcceptQueueSize needs to be higher for HMS
connector.setAcceptQueueSize(maxWorkerThreads);
// TODO: Connection keepalive configuration?
+connector.addBean(new HttpChannel.Listener() {
+ @Override
+ public void onComplete(Request request) {
+LOG.debug("Request " + request + " is completed. HttpChannel was: " +
request.getHttpChannel()
++ ", HttpTransport: " +
request.getHttpChannel().getHttpTransport());
+HMSHandler.cleanupHandlerContext();
Review Comment:
Is it possible to add a unit test to make sure we indeed clean up all of
objects that need to be removed?
Issue Time Tracking
---
Worklog Id: (was: 783130)
Time Spent: 7h 20m (was: 7h 10m)
> Hive Metastore Thrift over HTTP
> ---
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
>Reporter: Amit Khanna
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch,
> HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of
> which it is not possible to access it via Knox. Adding support for Thrift
> over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783131&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783131
]
ASF GitHub Bot logged work on HIVE-21456:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 21:49
Start Date: 20/Jun/22 21:49
Worklog Time Spent: 10m
Work Description: hsnusonic commented on code in PR #3381:
URL: https://github.com/apache/hive/pull/3381#discussion_r901986870
##
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##
@@ -399,19 +403,13 @@ private static ThriftServer startHttpMetastore(int port,
Configuration conf)
// Start with minWorkerThreads, expand till maxWorkerThreads and reject
// subsequent requests
final String threadPoolNamePrefix = "HiveMetastore-HttpHandler-Pool";
-ExecutorService executorService = new ThreadPoolExecutor(
-minWorkerThreads, maxWorkerThreads, 60, TimeUnit.SECONDS,
-new SynchronousQueue<>(), new ThreadFactory() {
- @Override
- public Thread newThread(@NotNull Runnable r) {
-Thread newThread = new Thread(r);
-newThread.setName(threadPoolNamePrefix + ": Thread-" +
newThread.getId());
-return newThread;
- }
-});
-ExecutorThreadPool threadPool = new
ExecutorThreadPool((ThreadPoolExecutor) executorService);
+ExecutorThreadPool executorThreadPool = new
ExecutorThreadPool(maxWorkerThreads, minWorkerThreads,
Review Comment:
Could you give me some context why the change is needed? It seems netty has
default idle timeout 30 seconds, but it was declared 60 seconds explicitly.
Issue Time Tracking
---
Worklog Id: (was: 783131)
Time Spent: 7.5h (was: 7h 20m)
> Hive Metastore Thrift over HTTP
> ---
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
>Reporter: Amit Khanna
>Assignee: Sourabh Goyal
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch,
> HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of
> which it is not possible to access it via Knox. Adding support for Thrift
> over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-26244) Implementing locking for concurrent ctas
[
https://issues.apache.org/jira/browse/HIVE-26244?focusedWorklogId=783140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783140
]
ASF GitHub Bot logged work on HIVE-26244:
-
Author: ASF GitHub Bot
Created on: 20/Jun/22 22:24
Start Date: 20/Jun/22 22:24
Worklog Time Spent: 10m
Work Description: simhadri-g commented on code in PR #3307:
URL: https://github.com/apache/hive/pull/3307#discussion_r901999420
##
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java:
##
@@ -3086,6 +3086,13 @@ Seems much cleaner if each stmt is identified as a
particular HiveOperation (whi
output.getWriteType().name()));
break;
+ case CTAS:
+if (AcidUtils.isExclusiveCTASEnabled(conf) &&
AcidUtils.isTransactionalTable(t)) {
Review Comment:
No, since we do not have table data at the other places where the
isExclusiveCTASEnabled method is called.
Issue Time Tracking
---
Worklog Id: (was: 783140)
Time Spent: 9.5h (was: 9h 20m)
> Implementing locking for concurrent ctas
>
>
> Key: HIVE-26244
> URL: https://issues.apache.org/jira/browse/HIVE-26244
> Project: Hive
> Issue Type: Improvement
>Reporter: Simhadri G
>Assignee: Simhadri G
>Priority: Major
> Labels: pull-request-available
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Work logged] (HIVE-21456) Hive Metastore Thrift over HTTP
[ https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=783139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783139 ] ASF GitHub Bot logged work on HIVE-21456: - Author: ASF GitHub Bot Created on: 20/Jun/22 22:24 Start Date: 20/Jun/22 22:24 Worklog Time Spent: 10m Work Description: hsnusonic commented on code in PR #3381: URL: https://github.com/apache/hive/pull/3381#discussion_r901975625 ## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: ## @@ -63,10 +63,14 @@ import org.eclipse.jetty.security.ConstraintMapping; import org.eclipse.jetty.security.ConstraintSecurityHandler; +import org.eclipse.jetty.server.HttpChannel; import org.eclipse.jetty.server.HttpConfiguration; import org.eclipse.jetty.server.HttpConnectionFactory; +import org.eclipse.jetty.server.Request; import org.eclipse.jetty.server.Server; import org.eclipse.jetty.server.ServerConnector; + Review Comment: nit: remove additional empty line? Issue Time Tracking --- Worklog Id: (was: 783139) Time Spent: 7h 40m (was: 7.5h) > Hive Metastore Thrift over HTTP > --- > > Key: HIVE-21456 > URL: https://issues.apache.org/jira/browse/HIVE-21456 > Project: Hive > Issue Type: New Feature > Components: Metastore, Standalone Metastore >Reporter: Amit Khanna >Assignee: Sourabh Goyal >Priority: Major > Labels: pull-request-available > Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, > HIVE-21456.4.patch, HIVE-21456.patch > > Time Spent: 7h 40m > Remaining Estimate: 0h > > Hive Metastore currently doesn't have support for HTTP transport because of > which it is not possible to access it via Knox. Adding support for Thrift > over HTTP transport will allow the clients to access via Knox -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26151) Support range-based time travel queries for Iceberg
[ https://issues.apache.org/jira/browse/HIVE-26151?focusedWorklogId=783164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783164 ] ASF GitHub Bot logged work on HIVE-26151: - Author: ASF GitHub Bot Created on: 21/Jun/22 00:21 Start Date: 21/Jun/22 00:21 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on PR #3222: URL: https://github.com/apache/hive/pull/3222#issuecomment-1160982831 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. Issue Time Tracking --- Worklog Id: (was: 783164) Time Spent: 2h (was: 1h 50m) > Support range-based time travel queries for Iceberg > --- > > Key: HIVE-26151 > URL: https://issues.apache.org/jira/browse/HIVE-26151 > Project: Hive > Issue Type: New Feature >Reporter: Marton Bod >Assignee: Marton Bod >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > Allow querying which records have been inserted during a certain time window > for Iceberg tables. The Iceberg TableScan API provides an implementation for > that, so most of the work would go into adding syntax support and > transporting the startTime and endTime parameters to the Iceberg input format. > Proposed new syntax: > SELECT * FROM table FOR SYSTEM_TIME FROM '' TO '' > SELECT * FROM table FOR SYSTEM_VERSION FROM TO > (the TO clause is optional in both cases) -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26072) Enable vectorization for stats gathering (tablescan op)
[ https://issues.apache.org/jira/browse/HIVE-26072?focusedWorklogId=783163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783163 ] ASF GitHub Bot logged work on HIVE-26072: - Author: ASF GitHub Bot Created on: 21/Jun/22 00:21 Start Date: 21/Jun/22 00:21 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on PR #3228: URL: https://github.com/apache/hive/pull/3228#issuecomment-1160982815 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. Issue Time Tracking --- Worklog Id: (was: 783163) Time Spent: 40m (was: 0.5h) > Enable vectorization for stats gathering (tablescan op) > --- > > Key: HIVE-26072 > URL: https://issues.apache.org/jira/browse/HIVE-26072 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Rajesh Balamohan >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > https://issues.apache.org/jira/browse/HIVE-24510 enabled vectorization for > compute_bit_vector. > But tablescan operator for stats gathering is disabled by default. > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java#L2577] > Need to enable vectorization for this. This can significantly reduce runtimes > for analyze statements for large tables. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26054) Distinct + Groupby with column alias is failing
[
https://issues.apache.org/jira/browse/HIVE-26054?focusedWorklogId=783165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783165
]
ASF GitHub Bot logged work on HIVE-26054:
-
Author: ASF GitHub Bot
Created on: 21/Jun/22 00:22
Start Date: 21/Jun/22 00:22
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #3155:
HIVE-26054: Query with distinct is failing if column is referenced by its name
in order by
URL: https://github.com/apache/hive/pull/3155
Issue Time Tracking
---
Worklog Id: (was: 783165)
Time Spent: 0.5h (was: 20m)
> Distinct + Groupby with column alias is failing
> ---
>
> Key: HIVE-26054
> URL: https://issues.apache.org/jira/browse/HIVE-26054
> Project: Hive
> Issue Type: Bug
>Reporter: Naresh P R
>Assignee: Krisztian Kasa
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After [HIVE-16924|https://issues.apache.org/jira/browse/HIVE-16924], below
> query is failing.
> {code:java}
> create table table1 (col1 bigint, col2 string);
> create table table2 (t2_col1 string);
> Select distinct col1 as alias_col1
> from table1
> where col2 = (SELECT max(t2_col1) as currentdate from table2 limit 1)
> order by col1;
> Error: Error while compiling statement: FAILED: SemanticException Line 0:-1
> Unsupported SubQuery Expression '1': Only SubQuery expressions that are top
> level conjuncts are allowed (state=42000,code=4) {code}
> Workaround is either remove distinct column alias "alias_col1" or use alias
> in order by.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Assigned] (HIVE-26344) MapredLocalTask 로그 개선
[ https://issues.apache.org/jira/browse/HIVE-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongdae Kim reassigned HIVE-26344: --- > MapredLocalTask 로그 개선 > - > > Key: HIVE-26344 > URL: https://issues.apache.org/jira/browse/HIVE-26344 > Project: Hive > Issue Type: Improvement >Reporter: Jeongdae Kim >Assignee: Jeongdae Kim >Priority: Minor > > MapredLocalTask는 hive server2의 자식 프로세스에서 실행되고, 로그는 > hive-exec-log4j2.properties 에 정의된 별도의 파일에 출력 됨. > 이로 인해 디버깅도 어렵고, operation log에 남지 않기때문에 사용자에게 상세 오류가 전달되지 않음. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26344) .
[ https://issues.apache.org/jira/browse/HIVE-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongdae Kim updated HIVE-26344: Summary: . (was: MapredLocalTask 로그 개선) > . > - > > Key: HIVE-26344 > URL: https://issues.apache.org/jira/browse/HIVE-26344 > Project: Hive > Issue Type: Improvement >Reporter: Jeongdae Kim >Assignee: Jeongdae Kim >Priority: Minor > > . -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26344) MapredLocalTask 로그 개선
[ https://issues.apache.org/jira/browse/HIVE-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongdae Kim updated HIVE-26344: Description: . (was: MapredLocalTask는 hive server2의 자식 프로세스에서 실행되고, 로그는 hive-exec-log4j2.properties 에 정의된 별도의 파일에 출력 됨. 이로 인해 디버깅도 어렵고, operation log에 남지 않기때문에 사용자에게 상세 오류가 전달되지 않음.) > MapredLocalTask 로그 개선 > - > > Key: HIVE-26344 > URL: https://issues.apache.org/jira/browse/HIVE-26344 > Project: Hive > Issue Type: Improvement >Reporter: Jeongdae Kim >Assignee: Jeongdae Kim >Priority: Minor > > . -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HIVE-26344) .
[ https://issues.apache.org/jira/browse/HIVE-26344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeongdae Kim resolved HIVE-26344. - Resolution: Invalid > . > - > > Key: HIVE-26344 > URL: https://issues.apache.org/jira/browse/HIVE-26344 > Project: Hive > Issue Type: Improvement >Reporter: Jeongdae Kim >Assignee: Jeongdae Kim >Priority: Minor > > . -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26341) Replication logs & metrics shows last repl id as 0 when number of events is zero
[ https://issues.apache.org/jira/browse/HIVE-26341?focusedWorklogId=783201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783201 ] ASF GitHub Bot logged work on HIVE-26341: - Author: ASF GitHub Bot Created on: 21/Jun/22 04:37 Start Date: 21/Jun/22 04:37 Worklog Time Spent: 10m Work Description: maheshk114 merged PR #3387: URL: https://github.com/apache/hive/pull/3387 Issue Time Tracking --- Worklog Id: (was: 783201) Time Spent: 0.5h (was: 20m) > Replication logs & metrics shows last repl id as 0 when number of events is > zero > > > Key: HIVE-26341 > URL: https://issues.apache.org/jira/browse/HIVE-26341 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HIVE-26341) Replication logs & metrics shows last repl id as 0 when number of events is zero
[ https://issues.apache.org/jira/browse/HIVE-26341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haymant Mangla resolved HIVE-26341. --- Resolution: Fixed > Replication logs & metrics shows last repl id as 0 when number of events is > zero > > > Key: HIVE-26341 > URL: https://issues.apache.org/jira/browse/HIVE-26341 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HIVE-26341) Replication logs & metrics shows last repl id as 0 when number of events is zero
[ https://issues.apache.org/jira/browse/HIVE-26341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556655#comment-17556655 ] Haymant Mangla commented on HIVE-26341: --- Committed to master. > Replication logs & metrics shows last repl id as 0 when number of events is > zero > > > Key: HIVE-26341 > URL: https://issues.apache.org/jira/browse/HIVE-26341 > Project: Hive > Issue Type: Bug >Reporter: Haymant Mangla >Assignee: Haymant Mangla >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26240) Add tests for Esri UDFs for Geospatial
[ https://issues.apache.org/jira/browse/HIVE-26240?focusedWorklogId=783222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783222 ] ASF GitHub Bot logged work on HIVE-26240: - Author: ASF GitHub Bot Created on: 21/Jun/22 06:31 Start Date: 21/Jun/22 06:31 Worklog Time Spent: 10m Work Description: ayushtkn merged PR #3385: URL: https://github.com/apache/hive/pull/3385 Issue Time Tracking --- Worklog Id: (was: 783222) Time Spent: 20m (was: 10m) > Add tests for Esri UDFs for Geospatial > -- > > Key: HIVE-26240 > URL: https://issues.apache.org/jira/browse/HIVE-26240 > Project: Hive > Issue Type: Sub-task >Reporter: Ramesh Kumar Thangarajan >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (HIVE-26240) Add tests for Esri UDFs for Geospatial
[ https://issues.apache.org/jira/browse/HIVE-26240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556667#comment-17556667 ] Ayush Saxena commented on HIVE-26240: - Committed to master. Thanx [~maheshk114] for the review!!! > Add tests for Esri UDFs for Geospatial > -- > > Key: HIVE-26240 > URL: https://issues.apache.org/jira/browse/HIVE-26240 > Project: Hive > Issue Type: Sub-task >Reporter: Ramesh Kumar Thangarajan >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (HIVE-26240) Add tests for Esri UDFs for Geospatial
[ https://issues.apache.org/jira/browse/HIVE-26240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayush Saxena resolved HIVE-26240. - Fix Version/s: 4.0.0-alpha-2 Resolution: Fixed > Add tests for Esri UDFs for Geospatial > -- > > Key: HIVE-26240 > URL: https://issues.apache.org/jira/browse/HIVE-26240 > Project: Hive > Issue Type: Sub-task >Reporter: Ramesh Kumar Thangarajan >Assignee: Ayush Saxena >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-2 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (HIVE-26345) SQLOperation class output real exception message to jdbc client
[ https://issues.apache.org/jira/browse/HIVE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangbutao reassigned HIVE-26345: - Assignee: zhangbutao > SQLOperation class output real exception message to jdbc client > --- > > Key: HIVE-26345 > URL: https://issues.apache.org/jira/browse/HIVE-26345 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Affects Versions: 4.0.0-alpha-2 >Reporter: zhangbutao >Assignee: zhangbutao >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26345) SQLOperation class output real exception message to jdbc client
[
https://issues.apache.org/jira/browse/HIVE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbutao updated HIVE-26345:
--
Description:
Beeline client may can not get real exception from _*SQLOperation class*_ and
user may don't how to fix query based on client exception massage.
Step to repro:
{code:java}
set hive.support.concurrency=false;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
create table testacid(id int) stored as orc
tblproperties('transactional'='true');{code}
Beeline console output exception:
{code:java}
Error: Error running query (state=,code=0) {code}
However, Hive3 beeline can output readable exception information:
{code:java}
Error: Error while compiling statement: FAILED: RuntimeException [Error 10264]:
To use DbTxnManager you must set hive.support.concurrency=true
(state=42000,code=10264) {code}
This change was introduced by HIVE-23124, i think we should fix this to output
real exception to prompt users to amend the query.
> SQLOperation class output real exception message to jdbc client
> ---
>
> Key: HIVE-26345
> URL: https://issues.apache.org/jira/browse/HIVE-26345
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 4.0.0-alpha-2
>Reporter: zhangbutao
>Assignee: zhangbutao
>Priority: Major
>
> Beeline client may can not get real exception from _*SQLOperation class*_ and
> user may don't how to fix query based on client exception massage.
> Step to repro:
>
> {code:java}
> set hive.support.concurrency=false;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> create table testacid(id int) stored as orc
> tblproperties('transactional'='true');{code}
> Beeline console output exception:
> {code:java}
> Error: Error running query (state=,code=0) {code}
> However, Hive3 beeline can output readable exception information:
> {code:java}
> Error: Error while compiling statement: FAILED: RuntimeException [Error
> 10264]: To use DbTxnManager you must set hive.support.concurrency=true
> (state=42000,code=10264) {code}
> This change was introduced by HIVE-23124, i think we should fix this to
> output real exception to prompt users to amend the query.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (HIVE-26345) SQLOperation class output real exception message to jdbc client
[
https://issues.apache.org/jira/browse/HIVE-26345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangbutao updated HIVE-26345:
--
Description:
Beeline client may can not get real exception from _*SQLOperation class*_ and
user may don't how to fix query based on client exception massage.
Step to repro:
{code:java}
set hive.support.concurrency=false;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
create table testacid(id int) stored as orc
tblproperties('transactional'='true');{code}
Beeline console output exception:
{code:java}
Error: Error running query (state=,code=0) {code}
However, Hive3 beeline can output readable exception information:
{code:java}
Error: Error while compiling statement: FAILED: RuntimeException [Error 10264]:
To use DbTxnManager you must set hive.support.concurrency=true
(state=42000,code=10264) {code}
This change was introduced by HIVE-23124, i think we should fix this to output
real exception to prompt users to amend the query.
was:
Beeline client may can not get real exception from _*SQLOperation class*_ and
user may don't how to fix query based on client exception massage.
Step to repro:
{code:java}
set hive.support.concurrency=false;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
create table testacid(id int) stored as orc
tblproperties('transactional'='true');{code}
Beeline console output exception:
{code:java}
Error: Error running query (state=,code=0) {code}
However, Hive3 beeline can output readable exception information:
{code:java}
Error: Error while compiling statement: FAILED: RuntimeException [Error 10264]:
To use DbTxnManager you must set hive.support.concurrency=true
(state=42000,code=10264) {code}
This change was introduced by HIVE-23124, i think we should fix this to output
real exception to prompt users to amend the query.
> SQLOperation class output real exception message to jdbc client
> ---
>
> Key: HIVE-26345
> URL: https://issues.apache.org/jira/browse/HIVE-26345
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Affects Versions: 4.0.0-alpha-2
>Reporter: zhangbutao
>Assignee: zhangbutao
>Priority: Major
>
> Beeline client may can not get real exception from _*SQLOperation class*_ and
> user may don't how to fix query based on client exception massage.
> Step to repro:
> {code:java}
> set hive.support.concurrency=false;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> create table testacid(id int) stored as orc
> tblproperties('transactional'='true');{code}
> Beeline console output exception:
> {code:java}
> Error: Error running query (state=,code=0) {code}
>
> However, Hive3 beeline can output readable exception information:
> {code:java}
> Error: Error while compiling statement: FAILED: RuntimeException [Error
> 10264]: To use DbTxnManager you must set hive.support.concurrency=true
> (state=42000,code=10264) {code}
>
> This change was introduced by HIVE-23124, i think we should fix this to
> output real exception to prompt users to amend the query.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
