[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[ https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098224#comment-17098224 ] Ashutosh Chauhan commented on HIVE-23215: - +1 > Make FilterContext and MutableFilterContext interfaces > -- > > Key: HIVE-23215 > URL: https://issues.apache.org/jira/browse/HIVE-23215 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Owen O'Malley >Assignee: Owen O'Malley >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23215.01.patch, HIVE-23215.02.patch, > HIVE-23215.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > HIVE-22959 introduced FilterContext to support ORC-577. The duplication of > fields between the FilterContext and VectorizedRowBatch seems likely to cause > user confusion. This patch makes them interfaces that VectorizedRowBatch > implements. > Thus, there is a single copy of the data and no need to copy them back and > forth. LLAP can make its own implementation of the interfaces if it doesn't > want to use VectorizedRowBatch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097740#comment-17097740
]
Hive QA commented on HIVE-23215:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001802/HIVE-23215.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17194 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22064/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22064/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22064/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13001802 - PreCommit-HIVE-Build
> Make FilterContext and MutableFilterContext interfaces
> --
>
> Key: HIVE-23215
> URL: https://issues.apache.org/jira/browse/HIVE-23215
> Project: Hive
> Issue Type: Bug
> Components: storage-api
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23215.01.patch, HIVE-23215.02.patch,
> HIVE-23215.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HIVE-22959 introduced FilterContext to support ORC-577. The duplication of
> fields between the FilterContext and VectorizedRowBatch seems likely to cause
> user confusion. This patch makes them interfaces that VectorizedRowBatch
> implements.
> Thus, there is a single copy of the data and no need to copy them back and
> forth. LLAP can make its own implementation of the interfaces if it doesn't
> want to use VectorizedRowBatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17097728#comment-17097728
]
Hive QA commented on HIVE-23215:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
52s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
23s{color} | {color:blue} storage-api in master has 51 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
46s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
4s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} storage-api: The patch generated 0 new + 11
unchanged - 3 fixed = 11 total (was 14) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} The patch ql passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} storage-api generated 4 new + 46 unchanged - 5 fixed =
50 total (was 51) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:storage-api |
| | org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.getSelected()
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 373] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.updateSelected(int)
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 406] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setFilterContext(boolean,
int[], int) may expose internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 384] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setSelected(int[]) may
expose internal representation by storing an externally mutable object into
VectorizedRowBatch.selected At VectorizedRowBatch.java:by storing an
externally mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 416] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096995#comment-17096995
]
Hive QA commented on HIVE-23215:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13001664/HIVE-23215.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17131 tests
executed
*Failed tests:*
{noformat}
TestReplicationScenarios - did not produce a TEST-*.xml file (likely timed out)
(batchId=192)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/22040/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/22040/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-22040/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 13001664 - PreCommit-HIVE-Build
> Make FilterContext and MutableFilterContext interfaces
> --
>
> Key: HIVE-23215
> URL: https://issues.apache.org/jira/browse/HIVE-23215
> Project: Hive
> Issue Type: Bug
> Components: storage-api
>Reporter: Owen O'Malley
>Assignee: Owen O'Malley
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-23215.01.patch, HIVE-23215.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HIVE-22959 introduced FilterContext to support ORC-577. The duplication of
> fields between the FilterContext and VectorizedRowBatch seems likely to cause
> user confusion. This patch makes them interfaces that VectorizedRowBatch
> implements.
> Thus, there is a single copy of the data and no need to copy them back and
> forth. LLAP can make its own implementation of the interfaces if it doesn't
> want to use VectorizedRowBatch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17096971#comment-17096971
]
Hive QA commented on HIVE-23215:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
47s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
22s{color} | {color:blue} storage-api in master has 51 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
38s{color} | {color:blue} ql in master has 1530 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} storage-api: The patch generated 0 new + 11
unchanged - 3 fixed = 11 total (was 14) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} The patch ql passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
32s{color} | {color:red} storage-api generated 4 new + 46 unchanged - 5 fixed =
50 total (was 51) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 7s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:storage-api |
| | org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.getSelected()
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 373] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.updateSelected(int)
may expose internal representation by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:by returning VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 406] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setFilterContext(boolean,
int[], int) may expose internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:internal representation by storing an externally
mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 384] |
| |
org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch.setSelected(int[]) may
expose internal representation by storing an externally mutable object into
VectorizedRowBatch.selected At VectorizedRowBatch.java:by storing an
externally mutable object into VectorizedRowBatch.selected At
VectorizedRowBatch.java:[line 416] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[ https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095971#comment-17095971 ] Panagiotis Garefalakis commented on HIVE-23215: --- Food catch [~jcamachorodriguez] ! Updated > Make FilterContext and MutableFilterContext interfaces > -- > > Key: HIVE-23215 > URL: https://issues.apache.org/jira/browse/HIVE-23215 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Owen O'Malley >Assignee: Owen O'Malley >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23215.01.patch, HIVE-23215.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > HIVE-22959 introduced FilterContext to support ORC-577. The duplication of > fields between the FilterContext and VectorizedRowBatch seems likely to cause > user confusion. This patch makes them interfaces that VectorizedRowBatch > implements. > Thus, there is a single copy of the data and no need to copy them back and > forth. LLAP can make its own implementation of the interfaces if it doesn't > want to use VectorizedRowBatch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[ https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095914#comment-17095914 ] Jesus Camacho Rodriguez commented on HIVE-23215: I think this patch should not contain the change in the pom.xml file? > Make FilterContext and MutableFilterContext interfaces > -- > > Key: HIVE-23215 > URL: https://issues.apache.org/jira/browse/HIVE-23215 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Owen O'Malley >Assignee: Owen O'Malley >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23215.01.patch, HIVE-23215.patch > > Time Spent: 1h 20m > Remaining Estimate: 0h > > HIVE-22959 introduced FilterContext to support ORC-577. The duplication of > fields between the FilterContext and VectorizedRowBatch seems likely to cause > user confusion. This patch makes them interfaces that VectorizedRowBatch > implements. > Thus, there is a single copy of the data and no need to copy them back and > forth. LLAP can make its own implementation of the interfaces if it doesn't > want to use VectorizedRowBatch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[
https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088272#comment-17088272
]
Hive QA commented on HIVE-23215:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/13000575/HIVE-23215.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21813/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21813/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21813/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2020-04-21 04:02:23.821
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-21813/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2020-04-21 04:02:23.824
+ cd apache-github-source-source
+ git fetch origin
>From https://github.com/apache/hive
57b2024..00423c1 master -> origin/master
+ git reset --hard HEAD
HEAD is now at 57b2024 HIVE-23241 : Reduce transitive dependencies
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded.
(use "git pull" to update your local branch)
+ git reset --hard origin/master
HEAD is now at 00423c1 HIVE-23258 : Remove BoneCP Connection Pool (David
Mollitor via Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2020-04-21 04:02:25.063
+ rm -rf ../yetus_PreCommit-HIVE-Build-21813
+ mkdir ../yetus_PreCommit-HIVE-Build-21813
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-21813
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-21813/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Trying to apply the patch with -p0
error: a/pom.xml: does not exist in index
error:
a/ql/src/test/org/apache/hadoop/hive/ql/io/filter/TestFilterContext.java: does
not exist in index
error:
a/storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:
does not exist in index
error:
a/storage-api/src/java/org/apache/hadoop/hive/ql/io/filter/FilterContext.java:
does not exist in index
error:
a/storage-api/src/java/org/apache/hadoop/hive/ql/io/filter/MutableFilterContext.java:
does not exist in index
error:
a/storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:
does not exist in index
Trying to apply the patch with -p1
error: patch failed: pom.xml:196
Falling back to three-way merge...
Applied patch to 'pom.xml' with conflicts.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:359
Falling back to three-way merge...
Applied patch to
'storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java'
cleanly.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:360
Falling back to three-way merge...
Applied patch to
'storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java'
cleanly.
Going to apply patch with: git apply -p1
error: patch failed: pom.xml:196
Falling back to three-way merge...
Applied patch to 'pom.xml' with conflicts.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:359
Falling back to three-way merge...
Applied patch to
'storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java'
cleanly.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java:360
Falling back to three-way
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[ https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087822#comment-17087822 ] Panagiotis Garefalakis commented on HIVE-23215: --- Just submitted the patch to trigger precommit build. +1 from my side pending tests. > Make FilterContext and MutableFilterContext interfaces > -- > > Key: HIVE-23215 > URL: https://issues.apache.org/jira/browse/HIVE-23215 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Owen O'Malley >Assignee: Owen O'Malley >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23215.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > HIVE-22959 introduced FilterContext to support ORC-577. The duplication of > fields between the FilterContext and VectorizedRowBatch seems likely to cause > user confusion. This patch makes them interfaces that VectorizedRowBatch > implements. > Thus, there is a single copy of the data and no need to copy them back and > forth. LLAP can make its own implementation of the interfaces if it doesn't > want to use VectorizedRowBatch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23215) Make FilterContext and MutableFilterContext interfaces
[ https://issues.apache.org/jira/browse/HIVE-23215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084710#comment-17084710 ] Panagiotis Garefalakis commented on HIVE-23215: --- cc [~gopalv] [~jcamachorodriguez] [~hashutosh] > Make FilterContext and MutableFilterContext interfaces > -- > > Key: HIVE-23215 > URL: https://issues.apache.org/jira/browse/HIVE-23215 > Project: Hive > Issue Type: Bug > Components: storage-api >Reporter: Owen O'Malley >Assignee: Owen O'Malley >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > HIVE-22959 introduced FilterContext to support ORC-577. The duplication of > fields between the FilterContext and VectorizedRowBatch seems likely to cause > user confusion. This patch makes them interfaces that VectorizedRowBatch > implements. > Thus, there is a single copy of the data and no need to copy them back and > forth. LLAP can make its own implementation of the interfaces if it doesn't > want to use VectorizedRowBatch. -- This message was sent by Atlassian Jira (v8.3.4#803005)
