[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=808094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-808094 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 13/Sep/22 03:45 Start Date: 13/Sep/22 03:45 Worklog Time Spent: 10m Work Description: pudidic merged PR #3544: URL: https://github.com/apache/hive/pull/3544 Issue Time Tracking --- Worklog Id: (was: 808094) Time Spent: 5h 40m (was: 5.5h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 5h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=804312=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804312 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 29/Aug/22 11:09 Start Date: 29/Aug/22 11:09 Worklog Time Spent: 10m Work Description: jhungund commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1230137481 I have incorporated all the review comments. The latest change had run into some unrelated failures due to flaky tests. The rerun has succeeded. The change has been reviewed by @Francis. The change looks good to be merged/submitted. @Francis, Do you want to take a quick look at the latest patch set? Thanks, Janardhan Issue Time Tracking --- Worklog Id: (was: 804312) Time Spent: 5.5h (was: 5h 20m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 5.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=804289=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-804289 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 29/Aug/22 08:37 Start Date: 29/Aug/22 08:37 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1229957401 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3544) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [35 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3544=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 804289) Time Spent: 5h 20m (was: 5h 10m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 5h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=803936=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803936 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 26/Aug/22 11:59 Start Date: 26/Aug/22 11:59 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1228402961 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3544) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [35 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3544=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 803936) Time Spent: 5h 10m (was: 5h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=803650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803650 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 25/Aug/22 13:56 Start Date: 25/Aug/22 13:56 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1227297571 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3544) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [35 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3544=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 803650) Time Spent: 5h (was: 4h 50m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=803116=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803116 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 24/Aug/22 05:52 Start Date: 24/Aug/22 05:52 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1225228387 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3544) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3544=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 803116) Time Spent: 4h 50m (was: 4h 40m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=803078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803078 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 24/Aug/22 02:02 Start Date: 24/Aug/22 02:02 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3544: URL: https://github.com/apache/hive/pull/3544#issuecomment-1225085305 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3544) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3544=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3544=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3544=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3544=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 803078) Time Spent: 4h 40m (was: 4.5h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=803069=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803069 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 24/Aug/22 01:15 Start Date: 24/Aug/22 01:15 Worklog Time Spent: 10m Work Description: jhungund opened a new pull request, #3544: URL: https://github.com/apache/hive/pull/3544 Replication fails for transactional tables having same name as dropped external tables. Summary of the change: While setting up the tasks during the repl-load phase of the replication, delay the access to table metadata until the task execution. This will avoid inconsistent metadata access during task creation. Root Cause Analysis: Background: During the incremental load phase of replication, all event logs are processed sequentially. Multiple tasks are spawned/created during the processing of each event. All the spawned tasks are subsequently, executed sequantially. Scenario of the issue: The issue is seen in the following scenario: 1. An external table(Eg. T1) created, is replicated, to target cluster during earlier replication cycles. 2. This external table is dropped. 3. An new managed table with the same name (T1) is recreated. 4. The subsequent repl-load phase fails. Root cause: 1. The above mentioned operations (table drop and recreation) are propogated to the target cluster via event logs during the subsequent incremental phase of replication. 2. We create DDL tasks to drop the external table for drop-table event. 3. We also create new tasks to create new managed tables. 4. Some additional events are logged which create tasks to load the newly created table. 5. During the creation of these load-table tasks, we try to access metadata corresponding to the new table. During normal scenario of a fresh table creation, the metadata store will not have data correspoding to the new table (yet to be created). However, in this scenario, the old table still exists and hence, we end up using the metadata corrsesponding to old table(external). We try to use this metadata to create the load tasks for the new table. During the exeuciton of these load tasks, which execute after the drop and recreate tasks, we find that the metadata set in the task context is stale and is inconsistent with the newly created table. Hence, the error. Fix: Do not access the table metadata during the task creation phase for table-load. Instead, access the metadata during the task execution. By that time, the metadata is updated to the latest state with the previously executed tasks. Change-Id: I79ed804617dcdadb51f961a933f4023ac0b6f509 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? - Unit-Tested Issue Time Tracking --- Worklog Id: (was: 803069) Time Spent: 4.5h (was: 4h 20m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=802799=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802799 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 23/Aug/22 10:40 Start Date: 23/Aug/22 10:40 Worklog Time Spent: 10m Work Description: jhungund merged PR #3435: URL: https://github.com/apache/hive/pull/3435 Issue Time Tracking --- Worklog Id: (was: 802799) Time Spent: 4h 20m (was: 4h 10m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=802534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802534
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 22/Aug/22 16:13
Start Date: 22/Aug/22 16:13
Worklog Time Spent: 10m
Work Description: cmunkey commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r951627733
##
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.metastore.ReplChangeManager;
+import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils;
+import org.apache.hadoop.hive.ql.Context;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.Hive;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.metadata.Table;
+import org.apache.hadoop.hive.ql.parse.ImportSemanticAnalyzer;
+
+import java.util.Collections;
+import java.util.TreeMap;
+
+public class DeferredWorkHelper {
Review Comment:
Call this DeferredContext since it does not do anything anymore.
The deferred context is used to make decisions at deferred time.
Issue Time Tracking
---
Worklog Id: (was: 802534)
Time Spent: 4h 10m (was: 4h)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=801856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801856
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 19/Aug/22 04:08
Start Date: 19/Aug/22 04:08
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r949782006
##
ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java:
##
@@ -26,15 +26,23 @@
import org.apache.hadoop.hive.ql.exec.Utilities;
import org.apache.hadoop.hive.ql.hooks.ReadEntity;
import org.apache.hadoop.hive.ql.hooks.WriteEntity;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.parse.ImportSemanticAnalyzer;
import org.apache.hadoop.hive.ql.parse.repl.metric.ReplicationMetricCollector;
+import org.apache.hadoop.hive.ql.plan.BaseCopyWork;
+import org.apache.hadoop.hive.ql.plan.DeferredWorkHelper;
import org.apache.hadoop.hive.ql.plan.Explain.Level;
+import java.util.Collections;
+import java.util.TreeMap;
+
/**
* MoveWork.
*
*/
@Explain(displayName = "Move Operator", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
-public class MoveWork implements Serializable {
+public class MoveWork implements Serializable, BaseCopyWork {
Review Comment:
> Doesn't CopyWork and ReplCopyWork also need to implement BaseCopyWork? I
don't see it.
Ah, Thanks for pointing out. I missed it in CopyWork. I will extend CopyWork
to implement BaseCopyWork. ReplCopyWork inherits CopyWork. Hence, I think, we
only need to override the setupWork in ReplCopyWork.
I will push a new patchset shortly.
Thanks,
Janardhan
Issue Time Tracking
---
Worklog Id: (was: 801856)
Time Spent: 4h (was: 3h 50m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=801817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801817
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 18/Aug/22 22:22
Start Date: 18/Aug/22 22:22
Worklog Time Spent: 10m
Work Description: cmunkey commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r949648323
##
ql/src/java/org/apache/hadoop/hive/ql/plan/MoveWork.java:
##
@@ -26,15 +26,23 @@
import org.apache.hadoop.hive.ql.exec.Utilities;
import org.apache.hadoop.hive.ql.hooks.ReadEntity;
import org.apache.hadoop.hive.ql.hooks.WriteEntity;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.apache.hadoop.hive.ql.parse.ImportSemanticAnalyzer;
import org.apache.hadoop.hive.ql.parse.repl.metric.ReplicationMetricCollector;
+import org.apache.hadoop.hive.ql.plan.BaseCopyWork;
+import org.apache.hadoop.hive.ql.plan.DeferredWorkHelper;
import org.apache.hadoop.hive.ql.plan.Explain.Level;
+import java.util.Collections;
+import java.util.TreeMap;
+
/**
* MoveWork.
*
*/
@Explain(displayName = "Move Operator", explainLevels = { Level.USER,
Level.DEFAULT, Level.EXTENDED })
-public class MoveWork implements Serializable {
+public class MoveWork implements Serializable, BaseCopyWork {
Review Comment:
Doesn't CopyWork and ReplCopyWork also need to implement BaseCopyWork? I
don't see it.
Issue Time Tracking
---
Worklog Id: (was: 801817)
Time Spent: 3h 50m (was: 3h 40m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=801070=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-801070
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 16/Aug/22 17:24
Start Date: 16/Aug/22 17:24
Worklog Time Spent: 10m
Work Description: cmunkey commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r947060277
##
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
+ void setupWork(ReplCopyWork replCopyWork) throws HiveException;
+ void setupWork(MoveWork moveWork) throws HiveException;
Review Comment:
Yes a new interface or abstract , maybe call it BaseWork.
Issue Time Tracking
---
Worklog Id: (was: 801070)
Time Spent: 3h 40m (was: 3.5h)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798715=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798715
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 07/Aug/22 12:34
Start Date: 07/Aug/22 12:34
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938518815
##
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
+ void setupWork(ReplCopyWork replCopyWork) throws HiveException;
+ void setupWork(MoveWork moveWork) throws HiveException;
Review Comment:
Currently, the copyWork, ReplCopyWork and MoveWork do not share a common
base class/interface. CopyWork is a base class for ReplCopyWork. MoveWork is
not related to these classes. Do you suggest that we define a new base
class/interface and then extend these classes? That base class will only have a
single function that will need to be implemented.
Issue Time Tracking
---
Worklog Id: (was: 798715)
Time Spent: 3.5h (was: 3h 20m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798297
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 05/Aug/22 07:21
Start Date: 05/Aug/22 07:21
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938518815
##
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
+ void setupWork(ReplCopyWork replCopyWork) throws HiveException;
+ void setupWork(MoveWork moveWork) throws HiveException;
Review Comment:
Currently, the copyWork, ReplCopyWork and MoveWork do not share a common
base class/interface. Do you suggest that we define a new base class/interface
and then extend these classes? That base class will only have a single function
that will need to be implemented.
Issue Time Tracking
---
Worklog Id: (was: 798297)
Time Spent: 3h 20m (was: 3h 10m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798296
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 05/Aug/22 07:16
Start Date: 05/Aug/22 07:16
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938515261
##
ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java:
##
@@ -166,6 +169,12 @@ public int execute() {
}
}
+ private void setupWork() throws HiveException {
Review Comment:
The implementation of setupWork for each task seem to be updating different
fields of the task class.
Issue Time Tracking
---
Worklog Id: (was: 798296)
Time Spent: 3h 10m (was: 3h)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798289=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798289
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 05/Aug/22 06:48
Start Date: 05/Aug/22 06:48
Worklog Time Spent: 10m
Work Description: jhungund commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938496746
##
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java:
##
@@ -3408,4 +3411,83 @@ public void testTableWithPartitionsInBatch() throws
Throwable {
.verifyResults(new String[] { "bangalore", "paris", "sydney" })
.verifyReplTargetProperty(replicatedDbName);
}
+
+
+ @Test
+ public void testTxnTblReplWithSameNameAsDroppedNonTxnTbl() throws Throwable {
+List withClauseOptions = new LinkedList<>();
+withClauseOptions.add("'" + HiveConf.ConfVars.HIVE_DISTCP_DOAS_USER.varname
++ "'='" + UserGroupInformation.getCurrentUser().getUserName() + "'");
+
+String tbl = "t1";
+primary
+.run("use " + primaryDbName)
+.run("create table " + tbl + " (id int)")
+.run("insert into table " + tbl + " values (1)")
+.dump(primaryDbName, withClauseOptions);
+
+replica
+.load(replicatedDbName, primaryDbName)
+.run("use " + replicatedDbName)
+.run("select id from " + tbl)
+.verifyResults(new String[] {"1"});
+
+
assertFalse(AcidUtils.isTransactionalTable(replica.getTable(replicatedDbName,
tbl)));
+
+primary
+.run("use " + primaryDbName)
+.run("drop table " + tbl)
+.run("create table " + tbl + " (id int) clustered by(id) into 3
buckets stored as orc " +
+"tblproperties (\"transactional\"=\"true\")")
+.run("insert into table " + tbl + " values (2)")
+.dump(primaryDbName, withClauseOptions);
+
+replica
+.load(replicatedDbName, primaryDbName)
+.run("use " + replicatedDbName)
+.run("select id from " + tbl)
+.verifyResults(new String[] {"2"});
+
+
assertTrue(AcidUtils.isTransactionalTable(replica.getTable(replicatedDbName,
tbl)));
+ }
+
+ @Test
+ public void testTxnTblReplWithSameNameAsDroppedExtTbl() throws Throwable {
Review Comment:
Test testTxnTblReplWithSameNameAsDroppedNonTxnTbl verifies the drop of a
non-ACID managed table and the recreation a managed ACID table. Test
testTxnTblReplWithSameNameAsDroppedExtTbl verifies the drop of an external
table and a recreation of a managed ACID table.
Issue Time Tracking
---
Worklog Id: (was: 798289)
Time Spent: 3h (was: 2h 50m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=798172=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-798172
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 04/Aug/22 20:51
Start Date: 04/Aug/22 20:51
Worklog Time Spent: 10m
Work Description: cmunkey commented on code in PR #3435:
URL: https://github.com/apache/hive/pull/3435#discussion_r938223551
##
ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java:
##
@@ -166,6 +169,12 @@ public int execute() {
}
}
+ private void setupWork() throws HiveException {
Review Comment:
All of these setupWork() implementations are basically the same, can they be
moved to base class Task?
##
ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
+ void setupWork(ReplCopyWork replCopyWork) throws HiveException;
+ void setupWork(MoveWork moveWork) throws HiveException;
Review Comment:
If you have interface or abstract that is common to CopyWork, ReplCopyWork,
and Move work. And a setupWork() in each of those works.
This can use be just be one setupWork(DeferredWorkHelper helper).
Interface BaseWork, CopyWork, ReplCopyWork and Move work all implement.
BaseWork.setupWork(DeferredWorkHelper helper) is the method that they all
have to implement.
For instance CopyWork.setupWork(DeferredWorkHelper helper) {
ImportSemanticAnalyzer.evaluate(helper.getReplace(),
helper.getTgtPath(), helper.getWriteId(), helper.getStmtId(), helper.getHive(),
helper.getCtx(), helper.getTblDesc(), helper.getInReplScope(), helper);
this.setToPath(new Path[] { destPath });
}
}
##
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java:
##
@@ -3408,4 +3411,83 @@ public void testTableWithPartitionsInBatch() throws
Throwable {
.verifyResults(new String[] { "bangalore", "paris", "sydney" })
.verifyReplTargetProperty(replicatedDbName);
}
+
+
+ @Test
+ public void testTxnTblReplWithSameNameAsDroppedNonTxnTbl() throws Throwable {
+List withClauseOptions = new LinkedList<>();
+withClauseOptions.add("'" + HiveConf.ConfVars.HIVE_DISTCP_DOAS_USER.varname
++ "'='" + UserGroupInformation.getCurrentUser().getUserName() + "'");
+
+String tbl = "t1";
+primary
+.run("use " + primaryDbName)
+.run("create table " + tbl + " (id int)")
+.run("insert into table " + tbl + " values (1)")
+.dump(primaryDbName, withClauseOptions);
+
+replica
+.load(replicatedDbName, primaryDbName)
+.run("use " + replicatedDbName)
+.run("select id from " + tbl)
+.verifyResults(new String[] {"1"});
+
+
assertFalse(AcidUtils.isTransactionalTable(replica.getTable(replicatedDbName,
tbl)));
+
+primary
+.run("use " + primaryDbName)
+.run("drop table " + tbl)
+.run("create table " + tbl + " (id int) clustered by(id) into 3
buckets stored as orc " +
+"tblproperties (\"transactional\"=\"true\")")
+.run("insert into table " + tbl + " values (2)")
+.dump(primaryDbName, withClauseOptions);
+
+replica
+.load(replicatedDbName, primaryDbName)
+.run("use " + replicatedDbName)
+.run("select id from " + tbl)
+.verifyResults(new String[] {"2"});
+
+
assertTrue(AcidUtils.isTransactionalTable(replica.getTable(replicatedDbName,
tbl)));
+ }
+
+ @Test
+ public void testTxnTblReplWithSameNameAsDroppedExtTbl() throws Throwable {
Review Comment:
What type is the table dropped in
testTxnTblReplWithSameNameAsDroppedNonTxnTbl?
Here it is external, is there a managed one?
Issue Time Tracking
---
Worklog Id: (was: 798172)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=797158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-797158 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 02/Aug/22 09:07 Start Date: 02/Aug/22 09:07 Worklog Time Spent: 10m Work Description: jhungund commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1202220981 > Yes, I did not know this was an exiting PR that was resurrected. Yes, I thought that keeping table logic where it was was more logical, DeferredWorkHelperImpl doesn't need to know about tables, and doesn't need to be changed in the future if we find more of these issues where we look at an object in different places and get different results. > > Otherwise, seems fine. Thanks Francis. I have tried to address your comment in the latest patchset. Please take a look. Thanks, Janardhan Issue Time Tracking --- Worklog Id: (was: 797158) Time Spent: 2h 40m (was: 2.5h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=796203=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796203 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 28/Jul/22 22:41 Start Date: 28/Jul/22 22:41 Worklog Time Spent: 10m Work Description: cmunkey commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1198697975 Yes, I did not know this was an exiting PR that was resurrected. Yes, I thought that keeping table logic where it was was more logical, DeferredWorkHelperImpl doesn't need to know about tables, and doesn't need to be changed in the future if we find more of these issues where we look at an object in different places and get different results. Otherwise, seems fine. Issue Time Tracking --- Worklog Id: (was: 796203) Time Spent: 2.5h (was: 2h 20m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=796037=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796037
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 28/Jul/22 10:55
Start Date: 28/Jul/22 10:55
Worklog Time Spent: 10m
Work Description: jhungund commented on PR #3435:
URL: https://github.com/apache/hive/pull/3435#issuecomment-1197987231
Hi Francis,
Thank you for taking a look at this change.
Below are my replies to your comments (starting with **[JH]**) below
> Can you add an analysis? Like the reason for the bug and how you are
fixing it?
>
**[JH]**I have added a detailed comment about the root cause analysis.
Please take a look.
> From the changes, I can infer that the access is "deferred", moved from
occurring semantic analysis "load table" time, to later when the task actually
runs and does the copy.
**[JH]** Yes, this is right.
>
> But what necessitates needing this? Did some state change between the two
points?
**[JH]** Please check the detailed comment added earlier.
>
> Is this the significant change?
>
> > table = ImportSemanticAnalyzer.tableIfExists(tblDesc, hive);
> > if (table == null) {
> > table = ImportSemanticAnalyzer.createNewTableMetadataObject(tblDesc,
true);
> > }
>
**[JH]** Yes, the access and the subsequent check:
if (AcidUtils.isTransactionalTable(table)) {
returns different results at task creation time and task execution time.
> So at deferred time, the copy/move/etc is only done if the table exists?
>
> Just wondering if you can pass runnable/callable/function from
ImportSemanticAnaylzer, so to keep all that current logic in the same place and
not moved to another file. Then the DeferredWorkHelperImpl just needs to
execute it, and logic can be removed from there.
**[JH]** The current logic of moving code in deferred implementation
simplifies the callers which only need to set the deferred implementation
class. This keeps the logic at the same place as the execution. Hence, it looks
OK to me.
Do let me know, if it looks ok. If not, I can try to change it as per your
comment.
Thanks,
Janardhan
Issue Time Tracking
---
Worklog Id: (was: 796037)
Time Spent: 2h 20m (was: 2h 10m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=796014=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796014 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 28/Jul/22 10:07 Start Date: 28/Jul/22 10:07 Worklog Time Spent: 10m Work Description: jhungund commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1197938266 Summary of the change: While setting up the tasks during the repl-load phase of the replication, the delay the access to the metadata until the task execution. This will avoid inconsistent metadata state by the tasks. **Root Cause Analysis** Background: During the incremental load phase of replication, all event logs are processed sequentially. One or more tasks are additionally spawned/created during the processing of each event. All the spawned tasks are also, subsequently, executed sequentially. **Scenario of the issue:** The issue is seen in the following scenario: 1. An external table(Eg. T1) is already replication to target cluster from source cluster during earlier replication cycles. 2. This external table is dropped. 3. A new managed table with the same name (T1) is recreated. **Root cause:** 1. The above mentioned operations (table drop and recreation) are propagated to the target cluster vis event logs during the subsequent incremental phase of replication. 2. We create tasks to drop the old external tables for drop table event. 3. We also create new tasks to create and load the table for the new table. 4. Additionally, some additional events are logged which create tasks to load the table. 5. During the creation of these load-table tasks, we try to access the metadata corresponding to the new table from the metadata store. In normal scenario of a fresh table creation, the metadata store will not have data corresponding to the new table (yet to be created). However, in this scenario, the old table still exists and hence, we end up using the metadata corresponding to old table. We try to use this metadata to create the load tasks for the new table. During the execution of these load tasks, which subsequently execute after the drop and recreate tasks, we find that the metadata set in the task context is stale and is inconsistent with the newly created table. Hence, the error. **Fix:** Do not access the metadata during the task creation for load table. Instead, access the metadata during the task execution. By that time, the metadata is updated to the latest state with the previously executed tasks. Issue Time Tracking --- Worklog Id: (was: 796014) Time Spent: 2h 10m (was: 2h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=794333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794333 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 22/Jul/22 18:06 Start Date: 22/Jul/22 18:06 Worklog Time Spent: 10m Work Description: cmunkey commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1192818697 Can you add an analysis? Like the reason for the bug and how you are fixing it? Issue Time Tracking --- Worklog Id: (was: 794333) Time Spent: 2h (was: 1h 50m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=793146=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793146 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 20/Jul/22 10:07 Start Date: 20/Jul/22 10:07 Worklog Time Spent: 10m Work Description: jhungund commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1190084647 The test re-run succeeded. Thanks, Janardhan Issue Time Tracking --- Worklog Id: (was: 793146) Time Spent: 1h 50m (was: 1h 40m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=792803=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-792803 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 19/Jul/22 16:30 Start Date: 19/Jul/22 16:30 Worklog Time Spent: 10m Work Description: sshiwalkar commented on PR #3435: URL: https://github.com/apache/hive/pull/3435#issuecomment-1189307540 recheck Issue Time Tracking --- Worklog Id: (was: 792803) Time Spent: 1h 40m (was: 1.5h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=790359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790359 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 13/Jul/22 10:37 Start Date: 13/Jul/22 10:37 Worklog Time Spent: 10m Work Description: jhungund opened a new pull request, #3435: URL: https://github.com/apache/hive/pull/3435 …me as dropped external tables. Change-Id: I79ed804617dcdadb51f961a933f4023ac0b6f509 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Issue Time Tracking --- Worklog Id: (was: 790359) Time Spent: 1.5h (was: 1h 20m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=632015=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632015 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 01/Aug/21 00:09 Start Date: 01/Aug/21 00:09 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #2151: URL: https://github.com/apache/hive/pull/2151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 632015) Time Spent: 1h 20m (was: 1h 10m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=627425=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-627425 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 25/Jul/21 00:08 Start Date: 25/Jul/21 00:08 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #2151: URL: https://github.com/apache/hive/pull/2151#issuecomment-886126479 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 627425) Time Spent: 1h 10m (was: 1h) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyush Madhukar >Assignee: Pratyush Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=601560=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-601560
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 25/May/21 07:18
Start Date: 25/May/21 07:18
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2151:
URL: https://github.com/apache/hive/pull/2151#discussion_r638519322
##
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/DeferredWorkHelper.java
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.plan;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+public interface DeferredWorkHelper {
+ void setupWork(CopyWork copyWork) throws HiveException;
Review comment:
Can we not use generics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 601560)
Time Spent: 1h (was: 50m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyush Madhukar
>Assignee: Pratyush Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=592055=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592055
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 03/May/21 04:03
Start Date: 03/May/21 04:03
Worklog Time Spent: 10m
Work Description: pmadhukar-cloudera commented on a change in pull
request #2151:
URL: https://github.com/apache/hive/pull/2151#discussion_r624864844
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##
@@ -1406,4 +1439,114 @@ public static Table tableIfExists(ImportTableDesc
tblDesc, Hive db) throws HiveE
}
}
+ public static class LoadTableStateWrapper {
Review comment:
DelayExecUtil has been renamed to LoadTableStateWrapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 592055)
Time Spent: 50m (was: 40m)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyushotpal Madhukar
>Assignee: Pratyushotpal Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[
https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=587022=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587022
]
ASF GitHub Bot logged work on HIVE-24933:
-
Author: ASF GitHub Bot
Created on: 22/Apr/21 03:16
Start Date: 22/Apr/21 03:16
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2151:
URL: https://github.com/apache/hive/pull/2151#discussion_r618048430
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java
##
@@ -1406,4 +1439,114 @@ public static Table tableIfExists(ImportTableDesc
tblDesc, Hive db) throws HiveE
}
}
+ public static class LoadTableStateWrapper {
Review comment:
Why are both LoadTableStateWrapper and DelayExecUtil needed? They are
almost alike
##
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/CopyWork.java
##
@@ -136,4 +140,18 @@ public boolean isOverwrite() {
public void setOverwrite(boolean overwrite) {
this.overwrite = overwrite;
}
+
+ public void setLoadTableStateWrapper(LoadTableStateWrapper
loadTableStateWrapper) {
+this.loadTableStateWrapper = loadTableStateWrapper;
+ }
+
+ public void setValuesBeforeExec() throws HiveException {
+if (loadTableStateWrapper == null) {
+ return;
+}
+
+Table table = loadTableStateWrapper.getTableIfExists();
Review comment:
CopyWork was generic in nature. setValuesBeforeExec is tying it to
resolve the path only from table. All we need is to be able to resolve the path
dynamically. A resolver interface should be prefered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 587022)
Time Spent: 40m (was: 0.5h)
> Replication fails for transactional tables having same name as dropped
> non-transactional table
> --
>
> Key: HIVE-24933
> URL: https://issues.apache.org/jira/browse/HIVE-24933
> Project: Hive
> Issue Type: Bug
>Reporter: Pratyushotpal Madhukar
>Assignee: Pratyushotpal Madhukar
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=579451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-579451 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 08/Apr/21 18:32 Start Date: 08/Apr/21 18:32 Worklog Time Spent: 10m Work Description: pmadhukar-cloudera closed pull request #2117: URL: https://github.com/apache/hive/pull/2117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 579451) Time Spent: 0.5h (was: 20m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyushotpal Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=577080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-577080 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 05/Apr/21 19:50 Start Date: 05/Apr/21 19:50 Worklog Time Spent: 10m Work Description: pmadhukar-cloudera opened a new pull request #2151: URL: https://github.com/apache/hive/pull/2151 …me as dropped non-transactional table ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 577080) Time Spent: 20m (was: 10m) > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyushotpal Madhukar >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24933) Replication fails for transactional tables having same name as dropped non-transactional table
[ https://issues.apache.org/jira/browse/HIVE-24933?focusedWorklogId=571648=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-571648 ] ASF GitHub Bot logged work on HIVE-24933: - Author: ASF GitHub Bot Created on: 25/Mar/21 05:05 Start Date: 25/Mar/21 05:05 Worklog Time Spent: 10m Work Description: pmadhukar-cloudera opened a new pull request #2117: URL: https://github.com/apache/hive/pull/2117 …me as dropped non-transactional table ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 571648) Remaining Estimate: 0h Time Spent: 10m > Replication fails for transactional tables having same name as dropped > non-transactional table > -- > > Key: HIVE-24933 > URL: https://issues.apache.org/jira/browse/HIVE-24933 > Project: Hive > Issue Type: Bug >Reporter: Pratyushotpal Madhukar >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
