[jira] [Updated] (MNG-7563) Java system properties now override user properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Guillemet updated MNG-7563:
-
Description:
An important change has been introduced in 3.8.5 that breaks some existing
builds: Java system properties now take precedence over default values of user
properties in dependency POMs. This look like a bug since it's now easy to
affect dependency behaviors with system properties, a practice that has been
discouraged. But maybe do you consider this as a new feature ?
As an example, 3 poms are attached to this ticket.
After installing projects b and c, building project a with:
{{mvn package -Ddep=x}}
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
3.8.6 (-D override the default).
Note that without the setting of the default value for property {{dep}} in
project b, the build fails with any version of Maven.
was:
An important change has been introduced in 3.8.5 that breaks some existing
builds: Java system properties now take precedence over default values of user
properties in dependency POMs. This look like a bug since it's now easy to
affect dependency behaviors with system properties, a practice that has been
discouraged. But maybe do you consider this as a new feature ?
As an example, 3 poms are attached to this ticket.
After installing projects b and c, building project a with:
{{mvn package -Ddep=x}}
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
3.8.6 (-D override the default).
> Java system properties now override user properties in dependencies
> ---
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Priority: Major
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in
> project b, the build fails with any version of Maven.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7563) Java system properties now override user properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Guillemet updated MNG-7563:
-
Description:
An important change has been introduced in 3.8.5 that breaks some existing
builds: Java system properties now take precedence over default values of user
properties in dependency POMs. This look like a bug since it's now easy to
affect dependency behaviors with system properties, a practice that has been
discouraged. But maybe do you consider this as a new feature ?
As an example, 3 poms are attached to this ticket.
After installing projects b and c, building project a with:
{{mvn package -Ddep=x}}
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
3.8.6 (-D override the default).
was:
An important change has been introduced in 3.8.5 that breaks some existing
builds: Java system properties now take precedence over default values of user
properties in dependency POMs. This look like a bug since it's now easy to
affect dependency behaviors with system properties, a practice that has been
discouraged. But maybe do you consider this as a new feature ?
As an example, 3 poms are attached to this ticket.
After installing project b and c, building project a with:
{{mvn package -Ddep=x}}
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
3.8.6 (-D override the default).
> Java system properties now override user properties in dependencies
> ---
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Hervé Guillemet
>Priority: Major
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7563) Java system properties now override user properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herv updated MNG-7563:
--
Summary: Java system properties now override user properties in
dependencies (was: Java system properties now overide user properties in
dependencies)
> Java system properties now override user properties in dependencies
> ---
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Herv
>Priority: Major
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing project b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7563) Java system properties now overide user properties in dependencies
[
https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herv updated MNG-7563:
--
Summary: Java system properties now overide user properties in dependencies
(was: Java system properties now overides user properties in dependencies)
> Java system properties now overide user properties in dependencies
> --
>
> Key: MNG-7563
> URL: https://issues.apache.org/jira/browse/MNG-7563
> Project: Maven
> Issue Type: Bug
> Components: Dependencies, POM
>Affects Versions: 3.8.5, 3.8.6
>Reporter: Herv
>Priority: Major
> Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing
> builds: Java system properties now take precedence over default values of
> user properties in dependency POMs. This look like a bug since it's now easy
> to affect dependency behaviors with system properties, a practice that has
> been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing project b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
> 3.8.6 (-D override the default).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7563) Java system properties now overides user properties in dependencies
Herv created MNG-7563:
-
Summary: Java system properties now overides user properties in
dependencies
Key: MNG-7563
URL: https://issues.apache.org/jira/browse/MNG-7563
Project: Maven
Issue Type: Bug
Components: Dependencies, POM
Affects Versions: 3.8.6, 3.8.5
Reporter: Herv
Attachments: poms.zip
An important change has been introduced in 3.8.5 that breaks some existing
builds: Java system properties now take precedence over default values of user
properties in dependency POMs. This look like a bug since it's now easy to
affect dependency behaviors with system properties, a practice that has been
discouraged. But maybe do you consider this as a new feature ?
As an example, 3 poms are attached to this ticket.
After installing project b and c, building project a with:
{{mvn package -Ddep=x}}
used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and
3.8.6 (-D override the default).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] mohnishkodnani opened a new issue, #710: Too many open files on Mac OS with JDK 11 and mvnd 0.8.2
mohnishkodnani opened a new issue, #710: URL: https://github.com/apache/maven-mvnd/issues/710 We have a very large project and in our day to day development also when we upgraded from JDK8 to JDK11, when running regular maven builds we used to get `Too many open files` error. We circumvented this in 2 ways. 1. On mac , we created a max.limitfiles.plist file with a huge 10 million value. 2. We passed `-XX:-MaxFDLimit` under `.mvn/jvm.config` Together after these 2 running `mvnw clean install -DskipTests -T16` worked fine as opposed to giving `Too many open files`. The system is Apple M1 Max with JDK 11 and maven 3.8 We wanted to try maven daemon and we faced the same `Too many open files` issue when building our project. Doing lsof shows that it happens around 10k files ( since that is the JVM limit on Mac OS ) which is why `-XX:-MaxFDLimit` was needed. We tried to create `.mvn/mvnd.properties` and put `mvnd.jvmArgs=-XX:-MaxFDLimit` however we still get this error. On the shell we see that `ulimit -a` is set to the 10 million file value. We can also see in the command that runs the `-Dmvnd.jvmArgs` having the above value. Not sure if there is any steps that I could use to debug this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616699#comment-17616699 ] ASF GitHub Bot commented on MPLUGIN-423: gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276758366 > Please also check these: > > ``` > [INFO] - > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276758366 > Please also check these: > > ``` > [INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ maven-plugin-report-plugin --- > [WARNING] Used undeclared dependencies found: > [WARNING] org.codehaus.plexus:plexus-container-default:jar:1.0-alpha-9:compile > [WARNING] Unused declared dependencies found: > [WARNING]org.apache.maven.doxia:doxia-site-renderer:jar:1.11.1:compile > [WARNING]org.apache.maven:maven-repository-metadata:jar:3.2.5:provided > [WARNING]org.apache.maven:maven-artifact:jar:3.2.5:provided > [WARNING]org.apache.maven:maven-settings:jar:3.2.5:provided > [WARNING]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.5:provided > [WARNING]org.codehaus.plexus:plexus-velocity:jar:1.2:compile > [WARNING]org.sonatype.plexus:plexus-build-api:jar:0.0.7:compile > [WARNING]org.junit.jupiter:junit-jupiter:jar:5.9.1:test > [WARNING]org.hamcrest:hamcrest:jar:2.2:test > ``` This now looks like: ``` [INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ maven-plugin-report-plugin --- [WARN] Unused declared dependencies found: [WARN]org.apache.maven:maven-artifact:jar:3.2.5:provided [WARN]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.5:provided ``` I can't really get rid of those warnings. If I remove the `maven-artifact` dependency, I end up with ``` [ERROR] Some dependencies of Maven Plugins are expected to be in provided scope. Please make sure that dependencies listed below declared in POM have set 'provided' as well. The following dependencies are in wrong scope: * org.apache.maven:maven-artifact:jar:3.2.5:compile ``` which is much worse imho. If I remove `org.eclipse.sisu.plexus`, I end up with: ``` [INFO] --- maven-dependency-plugin:3.3.0:analyze (default-cli) @ maven-plugin-report-plugin --- [WARN] Used undeclared dependencies found: [WARN]org.eclipse.sisu:org.eclipse.sisu.plexus:jar:0.3.5:provided [WARN] Unused declared dependencies found: [WARN]org.apache.maven:maven-artifact:jar:3.2.5:provided [WARN]org.codehaus.plexus:plexus-container-default:jar:2.1.1:provided ``` ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] johanjanssen commented on issue #701: mvndaemon 0.8.1 not at Chocolatey repo
johanjanssen commented on issue #701: URL: https://github.com/apache/maven-mvnd/issues/701#issuecomment-1276743213 Yes indeed, you need a script which changes: - Version in the .nuspec file - Url and checksum in the chocolateyinstall.ps1 file - Installation directory in the three .ps1 files I quickly looked at the Homebrew script and that already seems to contain most of the information needed. After that you execute `choco pack` to create the package. To publish packages to the Chocolatey sever you need to create a Chocolatey account and create a token which you use to login to the Chocolatey server from the script: `choco apikey --key "$env:CHOCOLATEY_API_KEY" --source https://push.chocolatey.org/ CHOCOLATEY_API_KEY` Once you have a Chocolatey account, I can make you a package maintainer so that you can push the package with the same id/name as I currently use by using `choco push`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616692#comment-17616692 ] ASF GitHub Bot commented on MPLUGIN-423: gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276741523 > > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. > > I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. I was about to try, but I realized there is problem with this approach. I think it makes sense to keep the ITs with the report. However, the ITs actually need the `maven-plugin-plugin` to generate the plugins and then run the `site` goal. This means a cyclic dependency, which would have to be broken by moving back the ITs to the `maven-plugin-plugin` or to a new module... so not really sure the end state would be really better. > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276741523 > > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. > > I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. I was about to try, but I realized there is problem with this approach. I think it makes sense to keep the ITs with the report. However, the ITs actually need the `maven-plugin-plugin` to generate the plugins and then run the `site` goal. This means a cyclic dependency, which would have to be broken by moving back the ITs to the `maven-plugin-plugin` or to a new module... so not really sure the end state would be really better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #701: mvndaemon 0.8.1 not at Chocolatey repo
gnodet commented on issue #701: URL: https://github.com/apache/maven-mvnd/issues/701#issuecomment-1276728652 I misunderstood how the packages were built, I thought they were building from sources. So the idea would be to define our own package, basically copying your [package definition](https://github.com/johanjanssen/ChocolateyPackages/tree/master/mvndaemon) to [our own repo](https://github.com/mvndaemon/mvnd-chocolatey) and setup the [git workflow you pointed](https://github.com/johanjanssen/ChocolateyPackages/blob/master/.github/workflows/push-single-chocolatey-package.yml), so that any commit will update the chocolatey package. This commit can then be scripted easily like [we do for homebrew](https://github.com/apache/maven-mvnd/blob/master/build/publish-on-homebrew.sh). Do I get that right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616688#comment-17616688 ] ASF GitHub Bot commented on MPLUGIN-423: michael-o commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276723274 > > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. > > I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. Good point, we shouldn't put too much effort into it. The warning is decent. The move from one to another is trivial. > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] michael-o commented on pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
michael-o commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276723274 > > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. > > I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. Good point, we shouldn't put too much effort into it. The warning is decent. The move from one to another is trivial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616687#comment-17616687
]
ASF GitHub Bot commented on MPLUGIN-423:
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993882936
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plu
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993882936
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin applies a heuristic to derive a heuristic from
+ * the plugin's artifactId.
+ *
+ *
+ * It removes any occurrences of the regular expression
-?maven-?,
+ * and then removes any occurrences of -?plugin-?.
+ *
+ *
+ * F
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616686#comment-17616686 ] ASF GitHub Bot commented on MPLUGIN-423: gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276715621 > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276715621 > I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. > > In such way we need not to duplicate code. What do you thing? > > We should have a separate java package in separate module. I suppose it would be a bit cleaner. What I had in mind was to switch to 4.0-SNAPSHOT soon after the 3.7 release. So not sure it's really worth the extra work, but I'll try it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616685#comment-17616685
]
ASF GitHub Bot commented on MPLUGIN-423:
gnodet commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993875063
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
gnodet commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993875063
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin applies a heuristic to derive a heuristic from
+ * the plugin's artifactId.
+ *
+ *
+ * It removes any occurrences of the regular expression
-?maven-?,
+ * and then removes any occurrences of -?plugin-?.
+ *
+ *
+ * For
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616681#comment-17616681 ] ASF GitHub Bot commented on MPLUGIN-423: slawekjaranowski commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276705201 I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. In such way we need not to duplicate code. What do you thing? We should have a separate java package in separate module. > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
slawekjaranowski commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276705201 I would like to have a report in maven-plugin-plugin module which simply extends reports from new module. We can override `executeReport` methods with warning and call supper. In such way we need not to duplicate code. What do you thing? We should have a separate java package in separate module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616680#comment-17616680
]
ASF GitHub Bot commented on MPLUGIN-423:
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993869171
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plu
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993869171
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin applies a heuristic to derive a heuristic from
+ * the plugin's artifactId.
+ *
+ *
+ * It removes any occurrences of the regular expression
-?maven-?,
+ * and then removes any occurrences of -?plugin-?.
+ *
+ *
+ * F
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616676#comment-17616676
]
ASF GitHub Bot commented on MPLUGIN-423:
gnodet commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993842954
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
gnodet commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993842954
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+ * 1.4
+ * 256m
+ * 1m
+ *
+ *
+ * SVN
+ * 1.4.6
+ *
+ *
+ *
+ *
+ *
+ * If not is specified, Maven requirement is extracted from
+ *
+ * and JDK requirement is extracted from maven-compiler-plugin
configuration.
+ *
+ * @deprecated will be removed in the next major version, please don't use
+ */
+@Deprecated
+@Parameter
+private Requirements requirements;
+
+/**
+ *
+ * The goal prefix that will appear before the ":".
+ * By default, this plugin applies a heuristic to derive a heuristic from
+ * the plugin's artifactId.
+ *
+ *
+ * It removes any occurrences of the regular expression
-?maven-?,
+ * and then removes any occurrences of -?plugin-?.
+ *
+ *
+ * For
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
slawekjaranowski commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276656396 > > I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for: > > > > * imports order - settings -> Code Style -> Java - imports tab has default values > > > > how we will manage it? > > Meh, you're right. > > We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those. > > Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose. I'm for preserve native settings for InteliJ, it can be in m-shared-r. I hope that not will be changed so frequently, so we can do such manual works as you describe, to have synchronized Eclipse and InteliJ. It will be easier for user to simply import settings. We have also import settings for eclipse in https://github.com/apache/maven-site/blob/master/content/resources/developers/maven-eclipse.importorder so this file should be moved to shared to have everything in one place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616664#comment-17616664 ] ASF GitHub Bot commented on MPLUGIN-423: slawekjaranowski commented on code in PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993827425 ## maven-plugin-report-plugin/src/it/mplugin-394_report-encoding/invoker.properties: ## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. -invoker.goals = clean plugin:report +invoker.goals = -Dfile.encoding=CP1252 site Review Comment: yes `goals` is not only `goals` it is arguments for cli, I will create issue for m-invoker-p for change it > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
slawekjaranowski commented on code in PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993827425 ## maven-plugin-report-plugin/src/it/mplugin-394_report-encoding/invoker.properties: ## @@ -15,4 +15,4 @@ # specific language governing permissions and limitations # under the License. -invoker.goals = clean plugin:report +invoker.goals = -Dfile.encoding=CP1252 site Review Comment: yes `goals` is not only `goals` it is arguments for cli, I will create issue for m-invoker-p for change it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616658#comment-17616658
]
ASF GitHub Bot commented on MPLUGIN-423:
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993794117
##
maven-plugin-report-plugin/src/it/mplugin-394_report-encoding/invoker.properties:
##
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
-invoker.goals = clean plugin:report
+invoker.goals = -Dfile.encoding=CP1252 site
Review Comment:
@slawekjaranowski This is the stuff I have told you about...
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -226,6 +228,10 @@ public boolean canGenerateReport()
protected void executeReport( Locale locale )
throws MavenReportException
{
+getLog().warn( "The report of the maven-plugin-plugin is deprecated,
please use "
++ "the report from the maven-plugin-report-plugin instead.
This plugin will be removed "
++ "in version 4.0.0." );
+
Review Comment:
Important: The plugin is *not* removed, but just the report goal. Therfore:
"report goal", "plugin goal"
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Paramet
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[
https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616659#comment-17616659
]
ASF GitHub Bot commented on MPLUGIN-423:
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993788064
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -226,6 +228,10 @@ public boolean canGenerateReport()
protected void executeReport( Locale locale )
throws MavenReportException
{
+getLog().warn( "The report of the maven-plugin-plugin is deprecated,
please use "
++ "the report from the maven-plugin-report-plugin instead.
This plugin will be removed "
++ "in version 4.0.0." );
+
Review Comment:
Important: The plugin is *not* removed, but just the report goal. Therefore:
"report goal", "plugin goal"
> Extract plugin report into its own plugin
> -
>
> Key: MPLUGIN-423
> URL: https://issues.apache.org/jira/browse/MPLUGIN-423
> Project: Maven Plugin Tools
> Issue Type: Task
>Reporter: Guillaume Nodet
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993788064
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -226,6 +228,10 @@ public boolean canGenerateReport()
protected void executeReport( Locale locale )
throws MavenReportException
{
+getLog().warn( "The report of the maven-plugin-plugin is deprecated,
please use "
++ "the report from the maven-plugin-report-plugin instead.
This plugin will be removed "
++ "in version 4.0.0." );
+
Review Comment:
Important: The plugin is *not* removed, but just the report goal. Therefore:
"report goal", "plugin goal"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #147: [MPLUGIN-423] Extract plugin report into its own plugin and deprecate the previous one
michael-o commented on code in PR #147:
URL: https://github.com/apache/maven-plugin-tools/pull/147#discussion_r993794117
##
maven-plugin-report-plugin/src/it/mplugin-394_report-encoding/invoker.properties:
##
@@ -15,4 +15,4 @@
# specific language governing permissions and limitations
# under the License.
-invoker.goals = clean plugin:report
+invoker.goals = -Dfile.encoding=CP1252 site
Review Comment:
@slawekjaranowski This is the stuff I have told you about...
##
maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -226,6 +228,10 @@ public boolean canGenerateReport()
protected void executeReport( Locale locale )
throws MavenReportException
{
+getLog().warn( "The report of the maven-plugin-plugin is deprecated,
please use "
++ "the report from the maven-plugin-report-plugin instead.
This plugin will be removed "
++ "in version 4.0.0." );
+
Review Comment:
Important: The plugin is *not* removed, but just the report goal. Therfore:
"report goal", "plugin goal"
##
maven-plugin-report-plugin/src/main/java/org/apache/maven/plugin/plugin/report/PluginReport.java:
##
@@ -0,0 +1,792 @@
+package org.apache.maven.plugin.plugin.report;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Map;
+import java.util.ResourceBundle;
+
+import org.apache.maven.doxia.sink.Sink;
+import org.apache.maven.model.Plugin;
+import org.apache.maven.plugin.descriptor.MojoDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptor;
+import org.apache.maven.plugin.descriptor.PluginDescriptorBuilder;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Execute;
+import org.apache.maven.plugins.annotations.LifecyclePhase;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import
org.apache.maven.plugins.plugin.descriptor.MNG6109PluginDescriptorBuilder;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.reporting.AbstractMavenReport;
+import org.apache.maven.reporting.AbstractMavenReportRenderer;
+import org.apache.maven.reporting.MavenReportException;
+import org.apache.maven.rtinfo.RuntimeInformation;
+import org.apache.maven.tools.plugin.DefaultPluginToolsRequest;
+import org.apache.maven.tools.plugin.PluginToolsRequest;
+import org.apache.maven.tools.plugin.generator.GeneratorException;
+import org.apache.maven.tools.plugin.generator.GeneratorUtils;
+import org.apache.maven.tools.plugin.generator.PluginXdocGenerator;
+import org.apache.maven.tools.plugin.util.PluginUtils;
+import org.codehaus.plexus.configuration.PlexusConfigurationException;
+import org.codehaus.plexus.util.StringUtils;
+import org.codehaus.plexus.util.xml.XmlStreamReader;
+import org.codehaus.plexus.util.xml.Xpp3Dom;
+
+/**
+ * Generates the Plugin's documentation report: plugin-info.html
plugin overview page,
+ * and one goal-mojo.html per goal.
+ *
+ * @author Stephane Nicoll
+ * @author mailto:vincent.sive...@gmail.com";>Vincent Siveton
+ * @since 2.0
+ */
+@Mojo( name = "report", threadSafe = true )
+@Execute( phase = LifecyclePhase.PROCESS_CLASSES )
+public class PluginReport
+extends AbstractMavenReport
+{
+/**
+ * Report output directory for mojos' documentation.
+ */
+@Parameter( defaultValue =
"${project.build.directory}/generated-site/xdoc" )
+private File outputDirectory;
+
+/**
+ * The file encoding of the source files.
+ *
+ * @deprecated not used in report, will be removed in the next major
version
+ *
+ * @since 2.7
+ */
+@Deprecated
+@Parameter( property = "encoding", defaultValue =
"${project.build.sourceEncoding}" )
+private String encoding;
+
+/**
+ * Specify some requirements to execute this plugin.
+ * Example:
+ *
+ *
+ * 2.0
+
[GitHub] [maven-mvnd] johanjanssen commented on issue #701: mvndaemon 0.8.1 not at Chocolatey repo
johanjanssen commented on issue #701: URL: https://github.com/apache/maven-mvnd/issues/701#issuecomment-1276594504 Maybe I don't understand your concern, but why can't you use GitHub actions? You can run them manually after the voting is completed. I also run them manually :). You can indeed call the commands from a shell, after you use the API to connect to the Chocolatey server. You don't need GitHub actions. It's easiest from a Windows image with Chocolatey installed, see also: https://stackoverflow.com/questions/39386471/can-i-build-chocolatey-packages-on-linux. I haven't tried it yet on Linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #701: mvndaemon 0.8.1 not at Chocolatey repo
gnodet commented on issue #701: URL: https://github.com/apache/maven-mvnd/issues/701#issuecomment-1276582959 > I'm the maintainer of Chocolatey and I just upgraded the package to 0.8.2. > > Please be aware that I plan to stop supporting the Chocolatey package at the end of the year, as I want to focus on other things. If you have any questions regarding the creation of the packages then I'm happy to help. > > Here is the current configuration: https://github.com/johanjanssen/ChocolateyPackages/tree/master/mvndaemon. > > With the `choco pack` and `choco push` commands the package is created and pushed to Chocolatey, see for example my GitHub action: https://github.com/johanjanssen/ChocolateyPackages/blob/master/.github/workflows/push-single-chocolatey-package.yml. The apache release process imposes a voting period, so we the post voting steps, which includes updating the packagers, can't rely on github actions. Are those `chocolate pack` and `chocolate push` commands available from a simple shell ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276546403 > I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for: > > * imports order - settings -> Code Style -> Java - imports tab has default values > > how we will manage it? Meh, you're right. We could tell users that imports won't be sorted and that they need to either add those or rely on the impsort plugin wich will fix those. Alternatively, we can add back idea settings, but I'd rather avoid it. We can generate it by importing the eclipse settings into IDEA, fix the import settings to comply with maven code style and export those settings. But we'd have to put them in maven-shared-resources also I suppose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
slawekjaranowski commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276505031 I tested importing importing eclipse formats ... into InteliJ, We have missing configurations for: - imports order - settings -> Code Style -> Java - imports tab has default values how we will manage it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616600#comment-17616600
]
ASF GitHub Bot commented on MNG-7106:
-
gnodet commented on PR #825:
URL: https://github.com/apache/maven/pull/825#issuecomment-1276500899
> Should we backport to 3.9?
I think so.
> VersionRange.toString() produces a string that cannot be parsed with
> VersionRange.createFromVersionSpec() for same lower and upper bounds
> -
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on pull request #825: [MNG-7106] Accept same lower and upper bound in version spec string
gnodet commented on PR #825: URL: https://github.com/apache/maven/pull/825#issuecomment-1276500899 > Should we backport to 3.9? I think so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616577#comment-17616577
]
ASF GitHub Bot commented on MNG-7106:
-
kwin commented on PR #825:
URL: https://github.com/apache/maven/pull/825#issuecomment-1276452756
Should we backport to 3.9?
> VersionRange.toString() produces a string that cannot be parsed with
> VersionRange.createFromVersionSpec() for same lower and upper bounds
> -
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on pull request #825: [MNG-7106] Accept same lower and upper bound in version spec string
kwin commented on PR #825: URL: https://github.com/apache/maven/pull/825#issuecomment-1276452756 Should we backport to 3.9? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] johanjanssen commented on issue #701: mvndaemon 0.8.1 not at Chocolatey repo
johanjanssen commented on issue #701: URL: https://github.com/apache/maven-mvnd/issues/701#issuecomment-1276423302 I'm the maintainer of Chocolatey and I just upgraded the package to 0.8.2. Please be aware that I plan to stop supporting the Chocolatey package at the end of the year, as I want to focus on other things. If you have any questions regarding the creation of the packages then I'm happy to help. Here is the current configuration: https://github.com/johanjanssen/ChocolateyPackages/tree/master/mvndaemon. With the `choco pack` and `choco push` commands the package is created and pushed to Chocolatey, see for example my GitHub action: https://github.com/johanjanssen/ChocolateyPackages/blob/master/.github/workflows/push-single-chocolatey-package.yml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616543#comment-17616543 ] ASF GitHub Bot commented on MPLUGIN-423: gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276410663 > I think wr can do a bit better. Leave old partial code, print the depreciation warning and recommend the new plugin in 3.7.0. MOVE all reporting related tests. In 4.0 remove old code and only new code will remain. Ah, I could not understand what you meant in the previous PR. That makes sense now ! > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on pull request #147: [4.x] [MPLUGIN-423] Extract plugin report into its own plugin
gnodet commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276410663 > I think wr can do a bit better. Leave old partial code, print the depreciation warning and recommend the new plugin in 3.7.0. MOVE all reporting related tests. In 4.0 remove old code and only new code will remain. Ah, I could not understand what you meant in the previous PR. That makes sense now ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #147: [4.x] [MPLUGIN-423] Extract plugin report into its own plugin
michael-o commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276408224 I think wr can do a bit better. Leave old partial code, print the depreciation warning and recommend the new plugin in 3.7.0. MOVE all reporting related tests. In 4.0 remove old code and only new code will remain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-423) Extract plugin report into its own plugin
[ https://issues.apache.org/jira/browse/MPLUGIN-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616542#comment-17616542 ] ASF GitHub Bot commented on MPLUGIN-423: michael-o commented on PR #147: URL: https://github.com/apache/maven-plugin-tools/pull/147#issuecomment-1276408224 I think wr can do a bit better. Leave old partial code, print the depreciation warning and recommend the new plugin in 3.7.0. MOVE all reporting related tests. In 4.0 remove old code and only new code will remain. > Extract plugin report into its own plugin > - > > Key: MPLUGIN-423 > URL: https://issues.apache.org/jira/browse/MPLUGIN-423 > Project: Maven Plugin Tools > Issue Type: Task >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel in BF collector
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616505#comment-17616505 ] Tamas Cservenak commented on MRESOLVER-7: - Also, have to remark that in case of collection "POM downloads" happens in two distinct cases (but interleaved during collection): * a) when downloading the dependency POM (for example D depends on D1, D2, D3, then corresponding D1.pom, D2.pom, D3.pom will be downloaded) – these can and are downloaded in parallel with provided PR for BF collector. * b) but, when D1.pom is being built (in model builder), and IF D1.pom has D1-parent.pom, amd parent has D1-parent-parent.pom (and so on, but similar for POM imports, etc), these are still sequentially downloaded, as model bullder processes/builds the D1.pom. Model builder was not altered by PR. The PR implements case a) in BF collector only. DF collector and model builder is unchanged. > Download dependency POMs in parallel in BF collector > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.0 > > Attachments: resolve_deps.png, resolver.log > > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-388) Make reporting optional dependency
[
https://issues.apache.org/jira/browse/MPLUGIN-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616493#comment-17616493
]
ASF GitHub Bot commented on MPLUGIN-388:
gnodet commented on PR #66:
URL:
https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1276310917
Superseded by #147
> Make reporting optional dependency
> --
>
> Key: MPLUGIN-388
> URL: https://issues.apache.org/jira/browse/MPLUGIN-388
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> Current m-p-p is far from being "lightweight", mostly due
> maven-reporting-impl being pulled in (that pulls in doxia, http-client and
> almost whole universe), and all this due one single mojo, the {{report}} mojo
> (org.apache.maven.plugin.plugin.PluginReport), and all these dependencies are
> needed ONLY when mojo directly invoked (ie. {{{}mvn m-p-p:report{}}}), as
> when used as part of site, all these are provided by site plugin.
> Make this dependency optional. This implies, that users of this release using
> report mojo "standalone" MUST ADD maven-reporting-impl:3.0.0 as dependency to
> m-p-p plugin as plugin dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-388) Make reporting optional dependency
[
https://issues.apache.org/jira/browse/MPLUGIN-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616492#comment-17616492
]
ASF GitHub Bot commented on MPLUGIN-388:
gnodet closed pull request #66: [MPLUGIN-388] Make reporting dependency optional
URL: https://github.com/apache/maven-plugin-tools/pull/66
> Make reporting optional dependency
> --
>
> Key: MPLUGIN-388
> URL: https://issues.apache.org/jira/browse/MPLUGIN-388
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> Current m-p-p is far from being "lightweight", mostly due
> maven-reporting-impl being pulled in (that pulls in doxia, http-client and
> almost whole universe), and all this due one single mojo, the {{report}} mojo
> (org.apache.maven.plugin.plugin.PluginReport), and all these dependencies are
> needed ONLY when mojo directly invoked (ie. {{{}mvn m-p-p:report{}}}), as
> when used as part of site, all these are provided by site plugin.
> Make this dependency optional. This implies, that users of this release using
> report mojo "standalone" MUST ADD maven-reporting-impl:3.0.0 as dependency to
> m-p-p plugin as plugin dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on pull request #66: [MPLUGIN-388] Make reporting dependency optional
gnodet commented on PR #66: URL: https://github.com/apache/maven-plugin-tools/pull/66#issuecomment-1276310917 Superseded by #147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet closed pull request #66: [MPLUGIN-388] Make reporting dependency optional
gnodet closed pull request #66: [MPLUGIN-388] Make reporting dependency optional URL: https://github.com/apache/maven-plugin-tools/pull/66 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPLUGIN-388) Make reporting optional dependency
[
https://issues.apache.org/jira/browse/MPLUGIN-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MPLUGIN-388.
---
Resolution: Won't Fix
> Make reporting optional dependency
> --
>
> Key: MPLUGIN-388
> URL: https://issues.apache.org/jira/browse/MPLUGIN-388
> Project: Maven Plugin Tools
> Issue Type: Task
> Components: Plugin Plugin
>Reporter: Tamas Cservenak
>Priority: Major
>
> Current m-p-p is far from being "lightweight", mostly due
> maven-reporting-impl being pulled in (that pulls in doxia, http-client and
> almost whole universe), and all this due one single mojo, the {{report}} mojo
> (org.apache.maven.plugin.plugin.PluginReport), and all these dependencies are
> needed ONLY when mojo directly invoked (ie. {{{}mvn m-p-p:report{}}}), as
> when used as part of site, all these are provided by site plugin.
> Make this dependency optional. This implies, that users of this release using
> report mojo "standalone" MUST ADD maven-reporting-impl:3.0.0 as dependency to
> m-p-p plugin as plugin dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPLUGIN-423) Extract plugin report into its own plugin
Guillaume Nodet created MPLUGIN-423: --- Summary: Extract plugin report into its own plugin Key: MPLUGIN-423 URL: https://issues.apache.org/jira/browse/MPLUGIN-423 Project: Maven Plugin Tools Issue Type: Task Reporter: Guillaume Nodet -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel in BF collector
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616484#comment-17616484 ] Tamas Cservenak commented on MRESOLVER-7: - [~Chealer] the requirements to make this happen requires several changes, and one of them was done as part of breadth-first collecting of dependencies (BF) while so far "original" collector and default as well is depth-first (DF). The provided PR enables the new BF collector to download POMs in parallel, while the "original" DF is still unchanged... But that said, I think there may be a slight mixup here: the PR was done as part of this issue (while it modified BF collector only, something that when this issue was created did not even exist yet), so to say, this issue got "hijacked"? > Download dependency POMs in parallel in BF collector > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.0 > > Attachments: resolve_deps.png, resolver.log > > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MRESOLVER-7) Download dependency POMs in parallel in BF collector
[ https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616469#comment-17616469 ] Philippe Cloutier commented on MRESOLVER-7: --- [~cstamas] : Does this specifically affect the BF collector as opposed to other collectors? Is there a workaround? > Download dependency POMs in parallel in BF collector > > > Key: MRESOLVER-7 > URL: https://issues.apache.org/jira/browse/MRESOLVER-7 > Project: Maven Resolver > Issue Type: Improvement > Components: Resolver >Affects Versions: Aether 1.0.2 >Reporter: Harald Wellmann >Assignee: Tamas Cservenak >Priority: Major > Fix For: 1.9.0 > > Attachments: resolve_deps.png, resolver.log > > Time Spent: 40m > Remaining Estimate: 0h > > h3. Background > When building a project with dependencies not yet available in the local > repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the > dependency POMs _sequentially_ and then proceeds downloading the dependency > JARs with up to 5 threads _in parallel_. > Due to this, when first building a project with a large number of > dependencies, downloading a large number of small POMs may take a lot longer > than downloading the much larger JARs, or even longer than building the > project itself, especially when a repository manager is used which increases > the download latency. > h3. Enhancement > Download POMs of (transitive) dependencies in parallel to significantly speed > up initial builds of large projects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MNG-7562) Mechanism for preventing inheritance of sections such as .
[
https://issues.apache.org/jira/browse/MNG-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Garret Wilson updated MNG-7562:
---
Description:
There needs to a way in the Maven POM to prevent an element from being
inherited altogether in child POMs.
We are currently publishing a Maven POM that is useful to serve as the parent
POM for various projects. Some of the projects that use the POM will be open
source, but some will not be. To designate our parent POM as open source, we
include this:
{code:xml}
Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0
repo
{code}
This essentially says, "this project is open source".
Unfortunately because of [POM
inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
uses this parent POM will also effectively be saying "this project is also open
source", because the effective POM of all descendant projects will also include
this same license section.
Developers could try to remember to include some {{}} section to
override this license, but the whole point of the parent POM is that it should
given developers less to do, not more. Besides, some private projects (even
ours) might not wish to indicate a license at all!
There needs to be a way for our public parent POM to indicate that it is open
source without effectively making all child projects open source as well
through POM inheritance. Preventing the {{}} section from being
inherited is one example of a more general mechanism needed to say, "Do not
inherit this element at all in child POMs".
was:
There needs to a way in the Maven POM to prevent an element from being
inherited altogether in child POMs.
We are currently publishing a Maven POM that is useful to serve as the parent
POM for various projects. Some of the projects that use the POM will be open
source, but some will not be. To designate our parent POM as open source, we
include this:
{code:xml}
Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0
repo
{code}
This essentially says, "this project is open source".
Unfortunately because of [POM
inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
uses this parent POM will also effectively be saying "this project is also open
source", because the effective POM of all descendant projects will also include
this same license section.
Developers could try to remember to include some {{}} section to
override this license, but the whole point of the parent POM is that it should
given developers less to do, not more. Besides, some private projects (even
ours) might not wish to indicate a license at all!
There needs to be a way for our public parent POM to indicate that it is open
source without effectively making all child projects open source as well
through POM inheritance. Preventing the {{}} section from being
inherited is one example.
> Mechanism for preventing inheritance of sections such as .
> ---
>
> Key: MNG-7562
> URL: https://issues.apache.org/jira/browse/MNG-7562
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.8.6
>Reporter: Garret Wilson
>Priority: Major
>
> There needs to a way in the Maven POM to prevent an element from being
> inherited altogether in child POMs.
> We are currently publishing a Maven POM that is useful to serve as the parent
> POM for various projects. Some of the projects that use the POM will be open
> source, but some will not be. To designate our parent POM as open source, we
> include this:
> {code:xml}
>
>
> Apache-2.0
> https://www.apache.org/licenses/LICENSE-2.0
> repo
>
>
> {code}
> This essentially says, "this project is open source".
> Unfortunately because of [POM
> inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
> uses this parent POM will also effectively be saying "this project is also
> open source", because the effective POM of all descendant projects will also
> include this same license section.
> Developers could try to remember to include some {{}} section to
> override this license, but the whole point of the parent POM is that it
> should given developers less to do, not more. Besides, some private projects
> (even ours) might not wish to indicate a license at all!
> There needs to be a way for our public parent POM to indicate that it is open
> source without effectively making all child projects open source as well
> through POM inheritance. Preventing the {{}} section from being
> inherited is one example of a more general mechanism needed to say, "Do not
> inherit this element at all in child POMs".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-7562) Mechanism for preventing inheritance of sections such as .
[
https://issues.apache.org/jira/browse/MNG-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616434#comment-17616434
]
Garret Wilson edited comment on MNG-7562 at 10/12/22 1:50 PM:
--
I [asked about this on Stack Overflow|https://stackoverflow.com/q/73239332],
and someone [suggested|https://stackoverflow.com/a/73983784]
{{child.licences.append.path="false"}}, which is apparently a mechanism
introduced in MNG-6059 (building on MNG-5951) and documented briefly in [Maven
Model Builder|https://maven.apache.org/ref/3.8.6/maven-model-builder/]. But
this mechanism doesn't seem to prevent inheritance—it only seems to prevent
appending a path to the inherited value, unless I'm reading it incorrectly.
was (Author: garretwilson):
I [asked about this on Stack Overflow|https://stackoverflow.com/q/73239332],
and someone [suggested|https://stackoverflow.com/a/73983784]
{{child.licences.append.path=false}}, which is apparently a mechanism
introduced in MNG-6059 (building on MNG-5951) and documented briefly in [Maven
Model Builder|https://maven.apache.org/ref/3.8.6/maven-model-builder/]. But
this mechanism doesn't seem to prevent inheritance—it only seems to prevent
appending a path to the inherited value, unless I'm reading it incorrectly.
> Mechanism for preventing inheritance of sections such as .
> ---
>
> Key: MNG-7562
> URL: https://issues.apache.org/jira/browse/MNG-7562
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.8.6
>Reporter: Garret Wilson
>Priority: Major
>
> There needs to a way in the Maven POM to prevent an element from being
> inherited altogether in child POMs.
> We are currently publishing a Maven POM that is useful to serve as the parent
> POM for various projects. Some of the projects that use the POM will be open
> source, but some will not be. To designate our parent POM as open source, we
> include this:
> {code:xml}
>
>
> Apache-2.0
> https://www.apache.org/licenses/LICENSE-2.0
> repo
>
>
> {code}
> This essentially says, "this project is open source".
> Unfortunately because of [POM
> inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
> uses this parent POM will also effectively be saying "this project is also
> open source", because the effective POM of all descendant projects will also
> include this same license section.
> Developers could try to remember to include some {{}} section to
> override this license, but the whole point of the parent POM is that it
> should given developers less to do, not more. Besides, some private projects
> (even ours) might not wish to indicate a license at all!
> There needs to be a way for our public parent POM to indicate that it is open
> source without effectively making all child projects open source as well
> through POM inheritance. Preventing the {{}} section from being
> inherited is one example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7562) Mechanism for preventing inheritance of sections such as .
[
https://issues.apache.org/jira/browse/MNG-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616434#comment-17616434
]
Garret Wilson commented on MNG-7562:
I [asked about this on Stack Overflow|https://stackoverflow.com/q/73239332],
and someone [suggested|https://stackoverflow.com/a/73983784]
{{child.licences.append.path=false}}, which is apparently a mechanism
introduced in MNG-6059 (building on MNG-5951) and documented briefly in [Maven
Model Builder|https://maven.apache.org/ref/3.8.6/maven-model-builder/]. But
this mechanism doesn't seem to prevent inheritance—it only seems to prevent
appending a path to the inherited value, unless I'm reading it incorrectly.
> Mechanism for preventing inheritance of sections such as .
> ---
>
> Key: MNG-7562
> URL: https://issues.apache.org/jira/browse/MNG-7562
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.8.6
>Reporter: Garret Wilson
>Priority: Major
>
> There needs to a way in the Maven POM to prevent an element from being
> inherited altogether in child POMs.
> We are currently publishing a Maven POM that is useful to serve as the parent
> POM for various projects. Some of the projects that use the POM will be open
> source, but some will not be. To designate our parent POM as open source, we
> include this:
> {code:xml}
>
>
> Apache-2.0
> https://www.apache.org/licenses/LICENSE-2.0
> repo
>
>
> {code}
> This essentially says, "this project is open source".
> Unfortunately because of [POM
> inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
> uses this parent POM will also effectively be saying "this project is also
> open source", because the effective POM of all descendant projects will also
> include this same license section.
> Developers could try to remember to include some {{}} section to
> override this license, but the whole point of the parent POM is that it
> should given developers less to do, not more. Besides, some private projects
> (even ours) might not wish to indicate a license at all!
> There needs to be a way for our public parent POM to indicate that it is open
> source without effectively making all child projects open source as well
> through POM inheritance. Preventing the {{}} section from being
> inherited is one example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7562) Mechanism for preventing inheritance of sections such as .
[
https://issues.apache.org/jira/browse/MNG-7562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Garret Wilson updated MNG-7562:
---
Description:
There needs to a way in the Maven POM to prevent an element from being
inherited altogether in child POMs.
We are currently publishing a Maven POM that is useful to serve as the parent
POM for various projects. Some of the projects that use the POM will be open
source, but some will not be. To designate our parent POM as open source, we
include this:
{code:xml}
Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0
repo
{code}
This essentially says, "this project is open source".
Unfortunately because of [POM
inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
uses this parent POM will also effectively be saying "this project is also open
source", because the effective POM of all descendant projects will also include
this same license section.
Developers could try to remember to include some {{}} section to
override this license, but the whole point of the parent POM is that it should
given developers less to do, not more. Besides, some private projects (even
ours) might not wish to indicate a license at all!
There needs to be a way for our public parent POM to indicate that it is open
source without effectively making all child projects open source as well
through POM inheritance. Preventing the {{}} section from being
inherited is one example.
was:
There needs to a way in the Maven POM to prevent an element from being
inherited altogether in child POMs.
We are currently publishing a Maven POM that is useful to serve as the parent
POM for various projects. Some of the projects that use the POM will be open
source, but some will not be. To designate our parent POM as open source, we
include this:
{code:xml}
Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0
repo
{code:xml}
This essentially says, "this project is open source".
Unfortunately because of [POM
inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
uses this parent POM will also effectively be saying "this project is also open
source", because the effective POM of all descendant projects will also include
this same license section.
Developers could try to remember to include some {{}} section to
override this license, but the whole point of the parent POM is that it should
given developers less to do, not more. Besides, some private projects (even
ours) might not wish to indicate a license at all!
There needs to be a way for our public parent POM to indicate that it is open
source without effectively making all child projects open source as well
through POM inheritance. Preventing the {{}} section from being
inherited is one example.
> Mechanism for preventing inheritance of sections such as .
> ---
>
> Key: MNG-7562
> URL: https://issues.apache.org/jira/browse/MNG-7562
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.8.6
>Reporter: Garret Wilson
>Priority: Major
>
> There needs to a way in the Maven POM to prevent an element from being
> inherited altogether in child POMs.
> We are currently publishing a Maven POM that is useful to serve as the parent
> POM for various projects. Some of the projects that use the POM will be open
> source, but some will not be. To designate our parent POM as open source, we
> include this:
> {code:xml}
>
>
> Apache-2.0
> https://www.apache.org/licenses/LICENSE-2.0
> repo
>
>
> {code}
> This essentially says, "this project is open source".
> Unfortunately because of [POM
> inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
> uses this parent POM will also effectively be saying "this project is also
> open source", because the effective POM of all descendant projects will also
> include this same license section.
> Developers could try to remember to include some {{}} section to
> override this license, but the whole point of the parent POM is that it
> should given developers less to do, not more. Besides, some private projects
> (even ours) might not wish to indicate a license at all!
> There needs to be a way for our public parent POM to indicate that it is open
> source without effectively making all child projects open source as well
> through POM inheritance. Preventing the {{}} section from being
> inherited is one example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7562) Mechanism for preventing inheritance of sections such as .
Garret Wilson created MNG-7562:
--
Summary: Mechanism for preventing inheritance of sections such as
.
Key: MNG-7562
URL: https://issues.apache.org/jira/browse/MNG-7562
Project: Maven
Issue Type: Improvement
Components: Inheritance and Interpolation
Affects Versions: 3.8.6
Reporter: Garret Wilson
There needs to a way in the Maven POM to prevent an element from being
inherited altogether in child POMs.
We are currently publishing a Maven POM that is useful to serve as the parent
POM for various projects. Some of the projects that use the POM will be open
source, but some will not be. To designate our parent POM as open source, we
include this:
{code:xml}
Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0
repo
{code:xml}
This essentially says, "this project is open source".
Unfortunately because of [POM
inheritance|https://maven.apache.org/pom.html#Inheritance], any project that
uses this parent POM will also effectively be saying "this project is also open
source", because the effective POM of all descendant projects will also include
this same license section.
Developers could try to remember to include some {{}} section to
override this license, but the whole point of the parent POM is that it should
given developers less to do, not more. Besides, some private projects (even
ours) might not wish to indicate a license at all!
There needs to be a way for our public parent POM to indicate that it is open
source without effectively making all child projects open source as well
through POM inheritance. Preventing the {{}} section from being
inherited is one example.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] slawekjaranowski commented on pull request #329: Change code style to refer to the one from maven-shared-resources
slawekjaranowski commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276087750 @cstamas `Eclipse Interoperability` helps 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1276026664 Btw, given we enforce a 120 characters hard break on lines, I wonder if we should switch to header formatted in the same way, something like ``` /* * Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. * See the NOTICE file distributed with this work for additional information regarding copyright ownership. * The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software distributed under the License is * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and limitations under the License. */ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7106) VersionRange.toString() produces a strin that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-7106:
-
Summary: VersionRange.toString() produces a strin that cannot be parsed
with VersionRange.createFromVersionSpec() for same lower and upper bounds
(was: VersionRange.toString() produces a version range that cannot be parsed
with VersionRange.createFromVersionSpec() for same lower and upper bounds)
> VersionRange.toString() produces a strin that cannot be parsed with
> VersionRange.createFromVersionSpec() for same lower and upper bounds
>
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7106) VersionRange.toString() produces a string that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-7106:
-
Summary: VersionRange.toString() produces a string that cannot be parsed
with VersionRange.createFromVersionSpec() for same lower and upper bounds
(was: VersionRange.toString() produces a strin that cannot be parsed with
VersionRange.createFromVersionSpec() for same lower and upper bounds)
> VersionRange.toString() produces a string that cannot be parsed with
> VersionRange.createFromVersionSpec() for same lower and upper bounds
> -
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MNG-7106) VersionRange.toString() produces a version range that cannot be parsed with VersionRange.createFromVersionSpec() for same lower and upper bounds
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MNG-7106:
-
Summary: VersionRange.toString() produces a version range that cannot be
parsed with VersionRange.createFromVersionSpec() for same lower and upper
bounds (was: VersionRange produces a version range that is incompatible with
itself)
> VersionRange.toString() produces a version range that cannot be parsed with
> VersionRange.createFromVersionSpec() for same lower and upper bounds
>
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #146: Refresh download page
gnodet commented on code in PR #146:
URL: https://github.com/apache/maven-plugin-tools/pull/146#discussion_r993338393
##
src/site/xdoc/download.xml.vm:
##
@@ -23,102 +23,51 @@ under the License.
Download ${project.name} Source
+
- ${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.
-
- You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.
-
- In order to guard against corrupted downloads/installations, it is
highly recommended to
- http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature
- of the release bundles against the public https://www.apache.org/dist/maven/KEYS";>KEYS used by the Apache Maven
- developers.
+ ${project.name} ${project.version} is distributed in
source format.
- ${project.name} is distributed under the http://www.apache.org/licenses/";>Apache License, version 2.0.
+ Use a source archive if you intend to build
${project.name} yourself.
- We strongly encourage our users to configure a Maven
repository mirror closer to their location, please read How to Use Mirrors for
Repositories.
-
-
-
-
-
- [if-any logo]
-
-
-
- [end]
- The currently selected mirror is
- [preferred].
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- backup
- mirrors
- (at the end of the mirrors list) that should be available.
-
+ Otherwise, simply use the ready-made binary artifacts from
central repository.
-
- Other mirrors:
-
-[if-any http]
-[for http]
-[http]
-[end]
-[end]
-[if-any ftp]
-[for ftp]
-[ftp]
-[end]
-[end]
-[if-any backup]
-[for backup]
-[backup] (backup)
-[end]
-[end]
-
-
-
+ ${project.name} is distributed under the https://www.apache.org/licenses/";>Apache License, version 2.0.
-
- You may also consult the
- http://www.apache.org/mirrors/";>complete list of
-mirrors.
+
+
+This is the current stable version of
${project.name}.
+
+
+
+
+
+ Link
+ Checksum
+ Signature
+
+
+
+
+ ${project.name} ${project.version} (Source zip)
+ ${project.artifactId}-${project.version}-source-release.zip
Review Comment:
Ok, I suppose the executable called by the cgi script has been updated to
point to `dlcdn.apache.org`. Let's keep it that way then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616365#comment-17616365
]
ASF GitHub Bot commented on MNG-7106:
-
kwin commented on PR #825:
URL: https://github.com/apache/maven/pull/825#issuecomment-1276005133
@cstamas Even Maven4 API still uses that implementation under the hood:
https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultVersionParser.java#L57
so I think this is worth fixing. Deprecation can come as a subsequent step
(and providing an implementation based on Maven Resolver's
`GenericVersionScheme`)
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on pull request #825: [MNG-7106] Accept same lower and upper bound in version spec string
kwin commented on PR #825: URL: https://github.com/apache/maven/pull/825#issuecomment-1276005133 @cstamas Even Maven4 API still uses that implementation under the hood: https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-core/src/main/java/org/apache/maven/internal/impl/DefaultVersionParser.java#L57 so I think this is worth fixing. Deprecation can come as a subsequent step (and providing an implementation based on Maven Resolver's `GenericVersionScheme`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #146: Refresh download page
gnodet commented on code in PR #146:
URL: https://github.com/apache/maven-plugin-tools/pull/146#discussion_r993330690
##
src/site/xdoc/download.xml.vm:
##
@@ -23,102 +23,51 @@ under the License.
Download ${project.name} Source
+
- ${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.
-
- You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.
-
- In order to guard against corrupted downloads/installations, it is
highly recommended to
- http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature
- of the release bundles against the public https://www.apache.org/dist/maven/KEYS";>KEYS used by the Apache Maven
- developers.
+ ${project.name} ${project.version} is distributed in
source format.
- ${project.name} is distributed under the http://www.apache.org/licenses/";>Apache License, version 2.0.
+ Use a source archive if you intend to build
${project.name} yourself.
- We strongly encourage our users to configure a Maven
repository mirror closer to their location, please read How to Use Mirrors for
Repositories.
-
-
-
-
-
- [if-any logo]
-
-
-
- [end]
- The currently selected mirror is
- [preferred].
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- backup
- mirrors
- (at the end of the mirrors list) that should be available.
-
+ Otherwise, simply use the ready-made binary artifacts from
central repository.
-
- Other mirrors:
-
-[if-any http]
-[for http]
-[http]
-[end]
-[end]
-[if-any ftp]
-[for ftp]
-[ftp]
-[end]
-[end]
-[if-any backup]
-[for backup]
-[backup] (backup)
-[end]
-[end]
-
-
-
+ ${project.name} is distributed under the https://www.apache.org/licenses/";>Apache License, version 2.0.
-
- You may also consult the
- http://www.apache.org/mirrors/";>complete list of
-mirrors.
+
+
+This is the current stable version of
${project.name}.
+
+
+
+
+
+ Link
+ Checksum
+ Signature
+
+
+
+
+ ${project.name} ${project.version} (Source zip)
+ ${project.artifactId}-${project.version}-source-release.zip
Review Comment:
But that was when there were mirrors, which is not the case anymore IIUC,
and that's why the pages have to be updated. Do I miss something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993329409
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
https://user-images.githubusercontent.com/84022/195330215-71dc8258-36bd-4ffc-a2fd-edac18a6746e.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993327594
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
@slawekjaranowski Eclipse Interoperability plugin disabled maybe? (by
default is enabled, unless you tampered with it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #146: Refresh download page
slawekjaranowski commented on code in PR #146:
URL: https://github.com/apache/maven-plugin-tools/pull/146#discussion_r993325587
##
src/site/xdoc/download.xml.vm:
##
@@ -23,102 +23,51 @@ under the License.
Download ${project.name} Source
+
- ${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.
-
- You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.
-
- In order to guard against corrupted downloads/installations, it is
highly recommended to
- http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature
- of the release bundles against the public https://www.apache.org/dist/maven/KEYS";>KEYS used by the Apache Maven
- developers.
+ ${project.name} ${project.version} is distributed in
source format.
- ${project.name} is distributed under the http://www.apache.org/licenses/";>Apache License, version 2.0.
+ Use a source archive if you intend to build
${project.name} yourself.
- We strongly encourage our users to configure a Maven
repository mirror closer to their location, please read How to Use Mirrors for
Repositories.
-
-
-
-
-
- [if-any logo]
-
-
-
- [end]
- The currently selected mirror is
- [preferred].
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- backup
- mirrors
- (at the end of the mirrors list) that should be available.
-
+ Otherwise, simply use the ready-made binary artifacts from
central repository.
-
- Other mirrors:
-
-[if-any http]
-[for http]
-[http]
-[end]
-[end]
-[if-any ftp]
-[for ftp]
-[ftp]
-[end]
-[end]
-[if-any backup]
-[for backup]
-[backup] (backup)
-[end]
-[end]
-
-
-
+ ${project.name} is distributed under the https://www.apache.org/licenses/";>Apache License, version 2.0.
-
- You may also consult the
- http://www.apache.org/mirrors/";>complete list of
-mirrors.
+
+
+This is the current stable version of
${project.name}.
+
+
+
+
+
+ Link
+ Checksum
+ Signature
+
+
+
+
+ ${project.name} ${project.version} (Source zip)
+ ${project.artifactId}-${project.version}-source-release.zip
Review Comment:
`[preferred]` will be replaced by cgi to cdn address
https://infra.apache.org/release-download-pages.html#custom
so we need cgi also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993325329
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
This is supported since 2014 it seems
https://blog.jetbrains.com/idea/2014/01/intellij-idea-13-importing-code-formatter-settings-from-eclipse/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993323438
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
https://user-images.githubusercontent.com/84022/195328105-e517952b-6445-426f-aa44-81411c43d159.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r99331
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
But this is NOT a "latest" IDEA feature at all, it is since a while, that
IDEA supports eclipse XML import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993319091
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
Same as @cstamas on 2022.2.1 Community Edition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
cstamas commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993317454
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
slawekjaranowski commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993315469
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
I don't see such options:
IntelliJ IDEA 2022.2.2 (Ultimate Edition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993305918
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
@slawekjaranowski YES ! A single file is used. The recent versions of IDEA
allow importing eclipse config files 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-enforcer] kwin commented on pull request #187: [MENFORCER-427] New rule to ban dynamic versions
kwin commented on PR #187: URL: https://github.com/apache/maven-enforcer/pull/187#issuecomment-1275973098 I opened https://issues.apache.org/jira/browse/MNG-7561 for same lower and upper bounds but it seems using a hard restriction always require resolving against metadata from local/remote repo, therefore at least optionally this pattern should be banned as well in this rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] gnodet commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
gnodet commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993305918
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
YES ! A single file is used. The recent versions of IDEA allow importing
eclipse config files 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #329: Change code style to refer to the one from maven-shared-resources
slawekjaranowski commented on code in PR #329:
URL: https://github.com/apache/maven-site/pull/329#discussion_r993304231
##
content/apt/developers/conventions/code.apt:
##
@@ -145,13 +145,13 @@ public class MyMojo
*** IntelliJ IDEA
- Download
<<<{{{../../developers/maven-idea-codestyle.xml}maven-idea-codestyle.xml}}>>>
- and import it into IDEA using File > Settings > Editor > Code Style > Gear
icon >
- Import Scheme > IntelliJ IDEA Code Style XML
+ Download
<<<{{{https://github.com/apache/maven-shared-resources/blob/master/src/main/resources/config/eclipse-formatter-config.xml}eclipse-formatter-config.xml}}>>>
+ and import it into IDEA using Intellij IDEA > Preferences > Editor > Code
Style > Java > Gear icon >
+ Import Scheme > Eclipse XML Profile
Review Comment:
Link is for eclipse-formatter-config.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-site] cstamas commented on pull request #329: Change code style to refer to the one from maven-shared-resources
cstamas commented on PR #329: URL: https://github.com/apache/maven-site/pull/329#issuecomment-1275966753 Maybe point the download links to gitbox instead of a "just a mirror" GH? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #146: Refresh download page
gnodet commented on code in PR #146:
URL: https://github.com/apache/maven-plugin-tools/pull/146#discussion_r993296197
##
src/site/xdoc/download.xml.vm:
##
@@ -23,102 +23,51 @@ under the License.
Download ${project.name} Source
+
- ${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.
-
- You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.
-
- In order to guard against corrupted downloads/installations, it is
highly recommended to
- http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature
- of the release bundles against the public https://www.apache.org/dist/maven/KEYS";>KEYS used by the Apache Maven
- developers.
+ ${project.name} ${project.version} is distributed in
source format.
- ${project.name} is distributed under the http://www.apache.org/licenses/";>Apache License, version 2.0.
+ Use a source archive if you intend to build
${project.name} yourself.
- We strongly encourage our users to configure a Maven
repository mirror closer to their location, please read How to Use Mirrors for
Repositories.
-
-
-
-
-
- [if-any logo]
-
-
-
- [end]
- The currently selected mirror is
- [preferred].
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- backup
- mirrors
- (at the end of the mirrors list) that should be available.
-
+ Otherwise, simply use the ready-made binary artifacts from
central repository.
-
- Other mirrors:
-
-[if-any http]
-[for http]
-[http]
-[end]
-[end]
-[if-any ftp]
-[for ftp]
-[ftp]
-[end]
-[end]
-[if-any backup]
-[for backup]
-[backup] (backup)
-[end]
-[end]
-
-
-
+ ${project.name} is distributed under the https://www.apache.org/licenses/";>Apache License, version 2.0.
-
- You may also consult the
- http://www.apache.org/mirrors/";>complete list of
-mirrors.
+
+
+This is the current stable version of
${project.name}.
+
+
+
+
+
+ Link
+ Checksum
+ Signature
+
+
+
+
+ ${project.name} ${project.version} (Source zip)
+ ${project.artifactId}-${project.version}-source-release.zip
Review Comment:
@slawekjaranowski Shouldn't the link be
`https://downloads.apache.org/maven/plugin-tools/...` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #146: Refresh download page
gnodet commented on code in PR #146:
URL: https://github.com/apache/maven-plugin-tools/pull/146#discussion_r993296197
##
src/site/xdoc/download.xml.vm:
##
@@ -23,102 +23,51 @@ under the License.
Download ${project.name} Source
+
- ${project.name} ${project.version} is distributed in source format.
Use a source archive if you intend to build
- ${project.name} yourself. Otherwise, simply use the ready-made binary
artifacts from central repository.
-
- You will be prompted for a mirror - if the file is not found on
yours, please be patient, as it may take 24
- hours to reach all mirrors.
-
- In order to guard against corrupted downloads/installations, it is
highly recommended to
- http://www.apache.org/dev/release-signing#verifying-signature";>verify the
signature
- of the release bundles against the public https://www.apache.org/dist/maven/KEYS";>KEYS used by the Apache Maven
- developers.
+ ${project.name} ${project.version} is distributed in
source format.
- ${project.name} is distributed under the http://www.apache.org/licenses/";>Apache License, version 2.0.
+ Use a source archive if you intend to build
${project.name} yourself.
- We strongly encourage our users to configure a Maven
repository mirror closer to their location, please read How to Use Mirrors for
Repositories.
-
-
-
-
-
- [if-any logo]
-
-
-
- [end]
- The currently selected mirror is
- [preferred].
- If you encounter a problem with this mirror,
- please select another mirror.
- If all mirrors are failing, there are
- backup
- mirrors
- (at the end of the mirrors list) that should be available.
-
+ Otherwise, simply use the ready-made binary artifacts from
central repository.
-
- Other mirrors:
-
-[if-any http]
-[for http]
-[http]
-[end]
-[end]
-[if-any ftp]
-[for ftp]
-[ftp]
-[end]
-[end]
-[if-any backup]
-[for backup]
-[backup] (backup)
-[end]
-[end]
-
-
-
+ ${project.name} is distributed under the https://www.apache.org/licenses/";>Apache License, version 2.0.
-
- You may also consult the
- http://www.apache.org/mirrors/";>complete list of
-mirrors.
+
+
+This is the current stable version of
${project.name}.
+
+
+
+
+
+ Link
+ Checksum
+ Signature
+
+
+
+
+ ${project.name} ${project.version} (Source zip)
+ ${project.artifactId}-${project.version}-source-release.zip
Review Comment:
Should n't the link be `https://downloads.apache.org/maven/plugin-tools/...`
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616346#comment-17616346
]
ASF GitHub Bot commented on MNG-7106:
-
kwin opened a new pull request, #825:
URL: https://github.com/apache/maven/pull/825
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin opened a new pull request, #825: [MNG-7106] Accept same lower and upper bound in version spec string
kwin opened a new pull request, #825: URL: https://github.com/apache/maven/pull/825 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #202: add test to ensure that a version constraint having same upper and lower
cstamas commented on PR #202: URL: https://github.com/apache/maven-resolver/pull/202#issuecomment-1275940856 Honestly, I was surprised by the existence of archaic maven-artifact `org.apache.maven.artifact.versioning` package, that is not even compatible (functionality wise) with resolver Version (and it's schemes). Personally, I'd just deprecate all this package as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616340#comment-17616340
]
Konrad Windszus edited comment on MNG-7106 at 10/12/22 10:26 AM:
-
This works fine already in Maven Resolver (verified in
https://github.com/apache/maven-resolver/pull/202/files) so I think just
dropping the exception when parsing string {{"[1.0,1.0]"}} is the correct
solution here.
was (Author: kwin):
This works fine already in Maven Resolver (verified in
https://github.com/apache/maven-resolver/pull/202/files) so I think just
dropping the exception for string {{"[1.0,1.0]"}} is the correct solution here.
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616340#comment-17616340
]
Konrad Windszus edited comment on MNG-7106 at 10/12/22 10:26 AM:
-
This works fine already in Maven Resolver (verified in
https://github.com/apache/maven-resolver/pull/202/files) so I think just
dropping the exception for string {{"[1.0,1.0]"}} is the correct solution here.
was (Author: kwin):
This works fine already in Maven Resolver (verified in
https://github.com/apache/maven-resolver/pull/202/files) so I think just
dropping the exception for string {{["1.0,1.0]"}} is the correct solution here.
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616340#comment-17616340
]
Konrad Windszus commented on MNG-7106:
--
This works fine already in Maven Resolver (verified in
https://github.com/apache/maven-resolver/pull/202/files) so I think just
dropping the exception for string {{["1.0,1.0]"}} is the correct solution here.
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MNG-7106) VersionRange produces a version range that is incompatible with itself
[
https://issues.apache.org/jira/browse/MNG-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MNG-7106:
Assignee: Konrad Windszus
> VersionRange produces a version range that is incompatible with itself
> --
>
> Key: MNG-7106
> URL: https://issues.apache.org/jira/browse/MNG-7106
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Akshay Shankara
>Assignee: Konrad Windszus
>Priority: Minor
>
> When a hard version requirement (Ex - [1.0]) is passed to
> [VersionRange#createFromVersionSpec(String)|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L106],
> it is parsed to [1.0, 1.0]. But, this version range is invalid [according to
> this
> exception|https://github.com/apache/maven/blob/maven-3.6.3/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/VersionRange.java#L214-L217].
> If the parsed version range ([1.0, 1.0]) is converted to a String, it cannot
> be parsed once again by VersionRange#createFromVersionSpec(String).
> Steps to reproduce -
> {code:java}
> VersionRange versionRange = VersionRange.createFromVersionSpec("[1.0]"); //
> [1.0, 1.0]
> String stringVersionRange = VersionRange.toString(versionRange); // "[1.0,
> 1.0]"
> VersionRange exceptionVersionRange =
> VersionRange.createFromVersionSpec(stringVersionRange); // <-
> InvalidVersionSpecificationException( "Range cannot have identical
> boundaries: [1.0, 1.0]" )
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] kwin opened a new pull request, #202: add test to ensure that a version constraint having same upper and lower
kwin opened a new pull request, #202: URL: https://github.com/apache/maven-resolver/pull/202 bound works compare with MNG-7106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-496) Outline all means to load extensions and clarify differences
[ https://issues.apache.org/jira/browse/MNGSITE-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616336#comment-17616336 ] ASF GitHub Bot commented on MNGSITE-496: cstamas commented on PR #326: URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275922609 oh, i missed those, sorry (I hate archaic APT format). Yes, is important for ext authors, not much for consumers. > Outline all means to load extensions and clarify differences > > > Key: MNGSITE-496 > URL: https://issues.apache.org/jira/browse/MNGSITE-496 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > > Currently in https://maven.apache.org/guides/mini/guide-using-extensions.html > there are only two ways specified how extensions can be loaded. Two means > outlined at > https://maven.apache.org/examples/maven-3-lifecycle-extensions.html#use-your-extension-in-your-build-s > are missing. > There should be a clear guidance which extensions can be loaded through which > means. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] cstamas commented on pull request #326: [MNGSITE-496] Outline all means to load extensions and clarify
cstamas commented on PR #326: URL: https://github.com/apache/maven-site/pull/326#issuecomment-1275922609 oh, i missed those, sorry (I hate archaic APT format). Yes, is important for ext authors, not much for consumers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MNG-7561) DefaultVersionRangeResolver should not try to resolve request with same upper and lower bound
[
https://issues.apache.org/jira/browse/MNG-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616331#comment-17616331
]
Konrad Windszus edited comment on MNG-7561 at 10/12/22 10:09 AM:
-
There seems to be a difference between soft and hard requirements which is not
really documented. Soft requirements (aka recommended versions) have to be
given with an exact version match, while hard requirements require resolving
(i.e. checking against metadata/repo whether they exists). Which means that a
dependency on version {{[1]}} is valid if the version {{1.0}} exists, on the
other hand the soft requirement {{1}} is invalid here.
was (Author: kwin):
There seems to be a difference between soft and hard references which is not
really documented. Soft references (aka recommended versions) have to be given
with an exact version match, while hard references require resolving (i.e.
checking against metadata/repo whether they exists). Which means that a
dependency on version {{[1]}} is valid if the version {{1.0}} exists, on the
other hand the soft reference {{1}} is invalid here.
> DefaultVersionRangeResolver should not try to resolve request with same upper
> and lower bound
> -
>
> Key: MNG-7561
> URL: https://issues.apache.org/jira/browse/MNG-7561
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> For dependencies having e.g. version {{[1.0]}} the
> DefaultVersionRangeResolver still tries to resolve versions although only a
> single version (namely 1.0) is valid here according to
> https://maven.apache.org/pom.html#Dependency_Version_Requirement_Specification.
>
> This leads in the worst case to long-running calls against a remote
> repository for no reason.
> There should be a shortcut in
> https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java#L108
> when the range has the same upper and lower bound.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7561) DefaultVersionRangeResolver should not try to resolve request with same upper and lower bound
[
https://issues.apache.org/jira/browse/MNG-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616335#comment-17616335
]
ASF GitHub Bot commented on MNG-7561:
-
kwin commented on code in PR #823:
URL: https://github.com/apache/maven/pull/823#discussion_r993263931
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##
@@ -111,28 +111,36 @@ public VersionRangeResult resolveVersionRange(
RepositorySystemSession session,
}
else
{
-Map versionIndex = getVersions(
session, result, request );
-
-List versions = new ArrayList<>();
-for ( Map.Entry v :
versionIndex.entrySet() )
+if ( Objects.equals( versionConstraint.getRange().getLowerBound(),
+ versionConstraint.getRange().getUpperBound()
) )
+{
+result.addVersion(
versionConstraint.getRange().getLowerBound().getVersion() );
Review Comment:
why is this shortcut allowed for recommended versions (soft-requirements)?
> DefaultVersionRangeResolver should not try to resolve request with same upper
> and lower bound
> -
>
> Key: MNG-7561
> URL: https://issues.apache.org/jira/browse/MNG-7561
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> For dependencies having e.g. version {{[1.0]}} the
> DefaultVersionRangeResolver still tries to resolve versions although only a
> single version (namely 1.0) is valid here according to
> https://maven.apache.org/pom.html#Dependency_Version_Requirement_Specification.
>
> This leads in the worst case to long-running calls against a remote
> repository for no reason.
> There should be a shortcut in
> https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java#L108
> when the range has the same upper and lower bound.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #823: [MNG-7561] never resolve version ranges with same lower and upper bound
kwin commented on code in PR #823:
URL: https://github.com/apache/maven/pull/823#discussion_r993263931
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##
@@ -111,28 +111,36 @@ public VersionRangeResult resolveVersionRange(
RepositorySystemSession session,
}
else
{
-Map versionIndex = getVersions(
session, result, request );
-
-List versions = new ArrayList<>();
-for ( Map.Entry v :
versionIndex.entrySet() )
+if ( Objects.equals( versionConstraint.getRange().getLowerBound(),
+ versionConstraint.getRange().getUpperBound()
) )
+{
+result.addVersion(
versionConstraint.getRange().getLowerBound().getVersion() );
Review Comment:
why is this shortcut allowed for recommended versions (soft-requirements)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7561) DefaultVersionRangeResolver should not try to resolve request with same upper and lower bound
[
https://issues.apache.org/jira/browse/MNG-7561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616334#comment-17616334
]
ASF GitHub Bot commented on MNG-7561:
-
kwin commented on code in PR #823:
URL: https://github.com/apache/maven/pull/823#discussion_r993263931
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##
@@ -111,28 +111,36 @@ public VersionRangeResult resolveVersionRange(
RepositorySystemSession session,
}
else
{
-Map versionIndex = getVersions(
session, result, request );
-
-List versions = new ArrayList<>();
-for ( Map.Entry v :
versionIndex.entrySet() )
+if ( Objects.equals( versionConstraint.getRange().getLowerBound(),
+ versionConstraint.getRange().getUpperBound()
) )
+{
+result.addVersion(
versionConstraint.getRange().getLowerBound().getVersion() );
Review Comment:
why is this shortcut allowed for recommended versions (soft-references)?
> DefaultVersionRangeResolver should not try to resolve request with same upper
> and lower bound
> -
>
> Key: MNG-7561
> URL: https://issues.apache.org/jira/browse/MNG-7561
> Project: Maven
> Issue Type: Improvement
> Components: Artifacts and Repositories
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> For dependencies having e.g. version {{[1.0]}} the
> DefaultVersionRangeResolver still tries to resolve versions although only a
> single version (namely 1.0) is valid here according to
> https://maven.apache.org/pom.html#Dependency_Version_Requirement_Specification.
>
> This leads in the worst case to long-running calls against a remote
> repository for no reason.
> There should be a shortcut in
> https://github.com/apache/maven/blob/3f90e7028e0338c110aea267b44362653d55273a/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java#L108
> when the range has the same upper and lower bound.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin commented on a diff in pull request #823: [MNG-7561] never resolve version ranges with same lower and upper bound
kwin commented on code in PR #823:
URL: https://github.com/apache/maven/pull/823#discussion_r993263931
##
maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/DefaultVersionRangeResolver.java:
##
@@ -111,28 +111,36 @@ public VersionRangeResult resolveVersionRange(
RepositorySystemSession session,
}
else
{
-Map versionIndex = getVersions(
session, result, request );
-
-List versions = new ArrayList<>();
-for ( Map.Entry v :
versionIndex.entrySet() )
+if ( Objects.equals( versionConstraint.getRange().getLowerBound(),
+ versionConstraint.getRange().getUpperBound()
) )
+{
+result.addVersion(
versionConstraint.getRange().getLowerBound().getVersion() );
Review Comment:
why is this shortcut allowed for recommended versions (soft-references)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
