[PR] Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 [maven-site-plugin]
dependabot[bot] opened a new pull request, #192: URL: https://github.com/apache/maven-site-plugin/pull/192 Bumps [org.apache.maven.reporting:maven-reporting-exec](https://github.com/apache/maven-reporting-exec) from 2.0.0-M13 to 2.0.0-M14. Commits https://github.com/apache/maven-reporting-exec/commit/9bf76454ec2eb6ef5eacb542294cc8f6fe08fed6;>9bf7645 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M14 https://github.com/apache/maven-reporting-exec/commit/be97a272f3d605658df797fa59776f802c1ca527;>be97a27 [MSHARED-1404] Upgrade plugins and components (in ITs) https://github.com/apache/maven-reporting-exec/commit/001346913d167074a0c5b899129104cb744f244d;>0013469 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 (2) https://github.com/apache/maven-reporting-exec/commit/1e5bc1bbf3b8a4fc45d2ad61dd9eedcd251390e5;>1e5bc1b Bump maven-gh-actions-shared to v4 https://github.com/apache/maven-reporting-exec/commit/2cd21f6537e066c70f9d002e972a6312cfb5ad25;>2cd21f6 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-reporting-exec/commit/c5ea890fa8e6d548c3856e072b7df7ccb4cc65e4;>c5ea890 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-reporting-exec/compare/maven-reporting-exec-2.0.0-M13...maven-reporting-exec-2.0.0-M14;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-8132) Dependency-management "client" exclusions overwrite BOM exclusions
[
https://issues.apache.org/jira/browse/MNG-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lenny Primak updated MNG-8132:
--
Description:
Continuation of https://issues.apache.org/jira/browse/MNG-8118
When importing BOM and introducing exclusions, they overwrite exclusions
already present in the BOM. They should not
Slack conversation link:
[https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939]
Regressed by https://issues.apache.org/jira/browse/MNG-5600
Reproducer project: [https://github.com/flowlogix/bom-exclusions-mvn4]
Offending / reproducing key lines of pom. Shiro BOM excludes non-Jakarta
classifier reference to Shrio-core amongst other things:
{code:java}
org.apache.shiro
shiro-bom
2.0.0
pom
import
org.slf4j
*
{code}
Expected result (maven 3.9.7) only one shiro-core.jar dependency with _jakarta_
classifier is present:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /Users/lprimak/.sdkman/candidates/maven/3.9.7
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] ---< com.flowlogix.repdoducers:bom-exclusions-mvn4 >---
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] [ pom ]
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
[INFO] \- org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.630 s
[INFO] Finished at: 2024-05-28T22:44:57-04:00
[INFO] ---
{code}
Current result (maven 4.0.0-alpha-3): both shiro-core with and without jakarta
classifier exist:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 4.0.0-beta-3 (e92f645c2749eb2a4f5a8843cf01e7441e4b559f)
Maven home: /Users/lprimak/.sdkman/candidates/maven/4.0.0-beta-3
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] <
com.flowlogix.repdoducers:bom-exclusions-mvn4
>
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] -[ pom
]-
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
*** below should not exist - non-jakarta classifier
[INFO] | +- org.apache.shiro:shiro-core:jar:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
*** below is the correct reference to shiro-core
[INFO] \- org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO] Copying com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
to project local repository
[INFO] Copying
com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:consumer:1.x-SNAPSHOT to
project local repository
[INFO]
-
[INFO] BUILD SUCCESS
[INFO]
-
[INFO] Total time: 2.589 s
[INFO] Finished at: 2024-05-28T22:49:26-04:00
[INFO]
-
{code}
was:
Continuation of https://issues.apache.org/jira/browse/MNG-8118
When importing BOM and introducing exclusions, they overwrite exclusions
already present in the BOM. They
[jira] [Updated] (MNG-8132) Dependency-management "client" exclusions overwrite BOM exclusions
[
https://issues.apache.org/jira/browse/MNG-8132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lenny Primak updated MNG-8132:
--
Description:
Continuation of https://issues.apache.org/jira/browse/MNG-8118
When importing BOM and introducing exclusions, they overwrite exclusions
already present in the BOM. They should not
Slack conversation link:
[https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939]
Regressed by https://issues.apache.org/jira/browse/MNG-5600
Reproducer project: [https://github.com/flowlogix/bom-exclusions-mvn4]
Offending / reproducing key lines of pom:
{code:java}
org.apache.shiro
shiro-bom
2.0.0
pom
import
org.slf4j
*
{code}
Expected result (maven 3.9.7) only one shiro-core.jar dependency with _jakarta_
classifier is present:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /Users/lprimak/.sdkman/candidates/maven/3.9.7
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] ---< com.flowlogix.repdoducers:bom-exclusions-mvn4 >---
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] [ pom ]
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
[INFO] \- org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.630 s
[INFO] Finished at: 2024-05-28T22:44:57-04:00
[INFO] ---
{code}
Current result (maven 4.0.0-alpha-3): both shiro-core with and without jakarta
classifier exist:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 4.0.0-beta-3 (e92f645c2749eb2a4f5a8843cf01e7441e4b559f)
Maven home: /Users/lprimak/.sdkman/candidates/maven/4.0.0-beta-3
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] <
com.flowlogix.repdoducers:bom-exclusions-mvn4
>
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] -[ pom
]-
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
*** below should not exist - non-jakarta classifier
[INFO] | +- org.apache.shiro:shiro-core:jar:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
*** below is the correct reference to shiro-core
[INFO] \- org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO] Copying com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
to project local repository
[INFO] Copying
com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:consumer:1.x-SNAPSHOT to
project local repository
[INFO]
-
[INFO] BUILD SUCCESS
[INFO]
-
[INFO] Total time: 2.589 s
[INFO] Finished at: 2024-05-28T22:49:26-04:00
[INFO]
-
{code}
was:
Continuation of https://issues.apache.org/jira/browse/MNG-8118
When importing BOM and introducing exclusions, they overwrite exclusions
already present in the BOM. They should not
Slack conversation link:
[jira] [Created] (MNG-8132) Dependency-management "client" exclusions overwrite BOM exclusions
Lenny Primak created MNG-8132:
-
Summary: Dependency-management "client" exclusions overwrite BOM
exclusions
Key: MNG-8132
URL: https://issues.apache.org/jira/browse/MNG-8132
Project: Maven
Issue Type: Bug
Components: Bootstrap Build
Affects Versions: 4.0.0-beta-3, 4.0.0-alpha-13
Environment: Any
Reporter: Lenny Primak
Continuation of https://issues.apache.org/jira/browse/MNG-8118
When importing BOM and introducing exclusions, they overwrite exclusions
already present in the BOM. They should not
Slack conversation link:
[https://the-asf.slack.com/archives/C7Q9JB404/p1714938396499939]
Regressed by https://issues.apache.org/jira/browse/MNG-5600
Reproducer project: [https://github.com/flowlogix/bom-exclusions-mvn4]
Offending / reproducing key lines of pom:
{code:java}
org.apache.shiro
shiro-bom
2.0.0
pom
import
org.slf4j
*
{code}
Expected result (maven 3.9.7) only one shiro-core.jar dependency with _jakarta_
classifier is present:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 3.9.7 (8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0)
Maven home: /Users/lprimak/.sdkman/candidates/maven/3.9.7
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] ---< com.flowlogix.repdoducers:bom-exclusions-mvn4 >---
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] [ pom ]
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
[INFO] \- org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 1.630 s
[INFO] Finished at: 2024-05-28T22:44:57-04:00
[INFO] ---
{code}
Current result (maven 4.0.0-alpha-3): both shiro-core with and without jakarta
classifier exist:
{code:java}
lprimak@Lennys-MacBook-Pro bom-exclusions-mvn4 % mvn -V dependency:tree
Apache Maven 4.0.0-beta-3 (e92f645c2749eb2a4f5a8843cf01e7441e4b559f)
Maven home: /Users/lprimak/.sdkman/candidates/maven/4.0.0-beta-3
Java version: 22.0.1, vendor: Azul Systems, Inc., runtime:
/Users/lprimak/.sdkman/candidates/java/22.0.1.fx-zulu/zulu-22.jdk/Contents/Home
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "12.7.5", arch: "x86_64", family: "mac"
[INFO] Scanning for projects...
[INFO]
[INFO] <
com.flowlogix.repdoducers:bom-exclusions-mvn4
>
[INFO] Building bom-exclusions-mvn4 1.x-SNAPSHOT
[INFO] from pom.xml
[INFO] -[ pom
]-
[INFO]
[INFO] --- dependency:3.6.1:tree (default-cli) @ bom-exclusions-mvn4 ---
[INFO] com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
[INFO] +- org.apache.shiro:shiro-web:jar:jakarta:2.0.0:compile
*** should not exist - non-jakarta classifier [INFO] | +-
org.apache.shiro:shiro-core:jar:2.0.0:compile
[INFO] | \- org.owasp.encoder:encoder:jar:1.2.3:compile
*** this is the correct reference [INFO] \-
org.apache.shiro:shiro-core:jar:jakarta:2.0.0:compile
. cut unnecessary lines
[INFO] Copying com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:1.x-SNAPSHOT
to project local repository
[INFO] Copying
com.flowlogix.repdoducers:bom-exclusions-mvn4:pom:consumer:1.x-SNAPSHOT to
project local repository
[INFO]
-
[INFO] BUILD SUCCESS
[INFO]
-
[INFO] Total time: 2.589 s
[INFO] Finished at: 2024-05-28T22:49:26-04:00
[INFO]
-
{code}
--
This message was sent by
[PR] Dependency analyze cleanup [maven-surefire]
michael-o opened a new pull request, #738: URL: https://github.com/apache/maven-surefire/pull/738 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[
https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850185#comment-17850185
]
Nils Breunese commented on MWRAPPER-110:
Ok, so the intention is for {{MAVEN_ARGS}} (documented in the Maven
configuration docs) to work with all Maven Wrapper distribution types then? If
so, why was the pull request in this ticket closed?
> The Maven 3.9 `MAVEN_ARGS` env var is not supported
> ---
>
> Key: MWRAPPER-110
> URL: https://issues.apache.org/jira/browse/MWRAPPER-110
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Dimitar Dimitrov
>Priority: Major
>
> If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by
> `mvn`, but not by `mvnw`.
> Please port this patch: [https://github.com/apache/maven/pull/49]
> A workaround is to export an extra env variable `MAVEN_CONFIG` which is
> picked by `mvnw`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works
[
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850165#comment-17850165
]
John Neffenger commented on MNG-8131:
-
See also: https://mail.openjdk.org/pipermail/openjfx-dev/2024-May/047279.html
> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Priority: Major
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to
> performing profile activation of a parent pom of the dependency, or not
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
> # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0
> -Djavafx-version=22.0.1{}
> # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO]
> {}}}{{{}[INFO] -< org.openjfx:sample
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]
> from pom.xml{}}}{{{}[INFO] [ jar
> ]-{}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
> (908 B at 1.9 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
> (8.4 kB at 165 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
> (904 B at 21 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
> (749 B at 17 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
> (306 B at 6.8 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar
> (302 B at 2.4 kB/s){}}}{{{}Downloaded from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar
> (306 B at 2.4 kB/s){}}}{{{}[INFO]
> {}}}{{{}[INFO]
> BUILD FAILURE{}}}{{{}[INFO]
> {}}}{{{}[INFO]
> Total time: 1.378 s{}}}{{{}[INFO] Finished at:
> 2024-05-28T10:23:05-06:00{}}}{{{}[INFO]
> {}}}{{{}[ERROR]
> Failed to execute goal on project sample: Could not resolve dependencies for
> project org.openjfx:sample:jar:1.0.0: The following artifacts could not be
> resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 (absent),
> org.openjfx:javafx-graphics:jar:${javafx.platform}:22.0.1 (absent),
> org.openjfx:javafx-base:jar:${javafx.platform}:22.0.1 (absent): Could not
> find artifact org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 in
> central
[jira] [Commented] (MNG-8129) Incorrect relative path in transitive dependencies leads to build failure
[
https://issues.apache.org/jira/browse/MNG-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850145#comment-17850145
]
Guillaume Nodet commented on MNG-8129:
--
I think they are. The model builder has no explicit context. Even if various
things are assumed in various places. I've tried to fix some of those but got
bitten by various ITs.
> Incorrect relative path in transitive dependencies leads to build failure
> -
>
> Key: MNG-8129
> URL: https://issues.apache.org/jira/browse/MNG-8129
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Kedar Joshi
>Priority: Major
> Labels: win64
>
> I was trying to build Spring Boot v3.3.0 project with latest beta and got
> following error (which does not occur on v3.9.x) -
>
> {code:java}
> [ERROR] Internal error: java.nio.file.InvalidPathException: Illegal char <:>
> at index 10: org.apache:apache -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:157)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at
> jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)
> Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
> at java.nio.file.Path.resolve(Path.java:516)
> at org.apache.maven.api.services.PathSource.resolve(PathSource.java:65)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.getParentPomFile(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParentLocally(DefaultModelBuilder.java:934)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParent(DefaultModelBuilder.java:904)
> {code}
> This exception occurs in *org.apache.maven.api.services.PathSource#resolve*
> method when parameter *relative* has value *org.apache:apache* since on
> Windows `:` is not allowed in file names.
> In Maven v3.x, this scenario is handled with `exists` check on the parent
> file and thus issue does not occur. No such check is done in v4.0.
> The source of the issue lies in
> *org.apache:apache* declaration in
> {*}https://repo.maven.apache.org/maven2/org/apache/activemq/artemis-project/2.33.0/artemis-project-2.33.0.pom{*}.
> As we can see, relative path *org.apache:apache* does not actually exist.
>
> I am using Windows 10 64 Bit.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
dependabot[bot] commented on PR #227: URL: https://github.com/apache/maven-shade-plugin/pull/227#issuecomment-2135904832 OK, I won't notify you about version 4.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
dependabot[bot] closed pull request #227: Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 URL: https://github.com/apache/maven-shade-plugin/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
slachiewicz commented on PR #227: URL: https://github.com/apache/maven-shade-plugin/pull/227#issuecomment-2135904756 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[ https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850131#comment-17850131 ] Tamas Cservenak commented on MWRAPPER-110: -- Certainly not. The wrapper was "inherited" from Takari project, and MAVEN_CONFIG was their feat (undocumented and not documented as proper Maven config either). The "script" basically delegates to Maven proper, so it supports things listed here [https://maven.apache.org/configure.html] Basically, we need to fix and align these (as much as possible) on "proper" (documented) configuration ways. > The Maven 3.9 `MAVEN_ARGS` env var is not supported > --- > > Key: MWRAPPER-110 > URL: https://issues.apache.org/jira/browse/MWRAPPER-110 > Project: Maven Wrapper > Issue Type: Bug > Components: Maven Wrapper Scripts >Affects Versions: 3.2.0 >Reporter: Dimitar Dimitrov >Priority: Major > > If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by > `mvn`, but not by `mvnw`. > Please port this patch: [https://github.com/apache/maven/pull/49] > A workaround is to export an extra env variable `MAVEN_CONFIG` which is > picked by `mvnw` -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[
https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850125#comment-17850125
]
Nils Breunese edited comment on MWRAPPER-110 at 5/28/24 6:10 PM:
-
I just found that {{MAVEN_CONFIG}} still gets read when using Maven Wrapper
3.3.0+ with the {{bin}} type, but {{MAVEN_CONFIG}} doesn't get read when using
the new default {{only-script}} type.
And when you use {{only-script}}, you can use {{MAVEN_ARGS}}. But that doesn't
work with the {{bin}} type.
Is it intentional that what environment variable you can use depends on the
Maven Wrapper distribution type? Because I think the current situation is
pretty confusing.
was (Author: breun):
I just found that {{MAVEN_CONFIG}} still gets read when using Maven Wrapper
3.3.0+ with the {{bin}} type, but {{MAVEN_CONFIG}} doesn't get read when using
the new default {{only-script}} type.
And when you use {{only-script}}, you should use {{MAVEN_ARGS}}? Which doesn't
work with the {{bin}} type? This is all pretty confusing.
> The Maven 3.9 `MAVEN_ARGS` env var is not supported
> ---
>
> Key: MWRAPPER-110
> URL: https://issues.apache.org/jira/browse/MWRAPPER-110
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Dimitar Dimitrov
>Priority: Major
>
> If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by
> `mvn`, but not by `mvnw`.
> Please port this patch: [https://github.com/apache/maven/pull/49]
> A workaround is to export an extra env variable `MAVEN_CONFIG` which is
> picked by `mvnw`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[
https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850125#comment-17850125
]
Nils Breunese edited comment on MWRAPPER-110 at 5/28/24 6:01 PM:
-
I just found that {{MAVEN_CONFIG}} still gets read when using Maven Wrapper
3.3.0+ with the {{bin}} type, but {{MAVEN_CONFIG}} doesn't get read when using
the new default {{only-script}} type.
And when you use {{only-script}}, you should use {{MAVEN_ARGS}}? Which doesn't
work with the {{bin}} type? This is all pretty confusing.
was (Author: breun):
I just found that {{MAVEN_CONFIG}} still gets read when using Maven Wrapper
3.3.0+ with the {{bin}} type, but {{MAVEN_CONFIG}} doesn't get read when using
the new default {{only-script}} type.
This is all very confusing...
> The Maven 3.9 `MAVEN_ARGS` env var is not supported
> ---
>
> Key: MWRAPPER-110
> URL: https://issues.apache.org/jira/browse/MWRAPPER-110
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Dimitar Dimitrov
>Priority: Major
>
> If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by
> `mvn`, but not by `mvnw`.
> Please port this patch: [https://github.com/apache/maven/pull/49]
> A workaround is to export an extra env variable `MAVEN_CONFIG` which is
> picked by `mvnw`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[
https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850125#comment-17850125
]
Nils Breunese commented on MWRAPPER-110:
I just found that {{MAVEN_CONFIG}} still gets read when using Maven Wrapper
3.3.0+ with the {{bin}} type, but {{MAVEN_CONFIG}} doesn't get read when using
the new default {{only-script}} type.
This is all very confusing...
> The Maven 3.9 `MAVEN_ARGS` env var is not supported
> ---
>
> Key: MWRAPPER-110
> URL: https://issues.apache.org/jira/browse/MWRAPPER-110
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Dimitar Dimitrov
>Priority: Major
>
> If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by
> `mvn`, but not by `mvnw`.
> Please port this patch: [https://github.com/apache/maven/pull/49]
> A workaround is to export an extra env variable `MAVEN_CONFIG` which is
> picked by `mvnw`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works
[
https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850097#comment-17850097
]
Tamas Cservenak commented on MNG-8131:
--
Please see https://lists.apache.org/thread/qcbgby00xl27ljdv5yqp0gf1sbvwnq71
> Property replacement in dependency pom no longer works
> --
>
> Key: MNG-8131
> URL: https://issues.apache.org/jira/browse/MNG-8131
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.9.7
> Environment: macOS 14.5 (23F79)
>Reporter: Taylor Smock
>Priority: Major
>
> h1. The problem:{{{}{}}}
> Classifiers in dependency poms are no longer replaced (either due to
> performing profile activation of a parent pom of the dependency, or not
> performing replacement of a property).{{{}{}}}
> Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
> # {{m{{{}vn archetype:generate
> -DarchetypeGroupId=org.openjfx
> -DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3
> -DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0
> -Djavafx-version=22.0.1{}
> # {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO]
> {}}}{{{}[INFO] -< org.openjfx:sample
> >-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]
> from pom.xml{}}}{{{}[INFO] [ jar
> ]-{}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
> (908 B at 1.9 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
> (8.4 kB at 165 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
> (904 B at 21 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
> (749 B at 17 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
> (306 B at 6.8 kB/s){}}}{{{}Downloading from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloaded
> from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar
> (302 B at 2.4 kB/s){}}}{{{}Downloaded from central:
> https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar
> (306 B at 2.4 kB/s){}}}{{{}[INFO]
> {}}}{{{}[INFO]
> BUILD FAILURE{}}}{{{}[INFO]
> {}}}{{{}[INFO]
> Total time: 1.378 s{}}}{{{}[INFO] Finished at:
> 2024-05-28T10:23:05-06:00{}}}{{{}[INFO]
> {}}}{{{}[ERROR]
> Failed to execute goal on project sample: Could not resolve dependencies for
> project org.openjfx:sample:jar:1.0.0: The following artifacts could not be
> resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 (absent),
> org.openjfx:javafx-graphics:jar:${javafx.platform}:22.0.1 (absent),
> org.openjfx:javafx-base:jar:${javafx.platform}:22.0.1 (absent): Could not
> find artifact org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 in
> central
[jira] [Created] (MNG-8131) Property replacement in dependency pom no longer works
Taylor Smock created MNG-8131:
-
Summary: Property replacement in dependency pom no longer works
Key: MNG-8131
URL: https://issues.apache.org/jira/browse/MNG-8131
Project: Maven
Issue Type: Bug
Components: Core
Affects Versions: 3.9.7
Environment: macOS 14.5 (23F79)
Reporter: Taylor Smock
h1. The problem:{{{}{}}}
Classifiers in dependency poms are no longer replaced (either due to performing
profile activation of a parent pom of the dependency, or not performing
replacement of a property).{{{}{}}}
Steps to reproduce (from [https://openjfx.io/openjfx-docs/#maven] )
# {{m{{{}vn archetype:generate
-DarchetypeGroupId=org.openjfx
-DarchetypeArtifactId=javafx-archetype-simple -DarchetypeVersion=0.0.3
-DgroupId=org.openjfx -DartifactId=sample -Dversion=1.0.0
-Djavafx-version=22.0.1{}
# {{{}mvn compile{{{}{}}}[INFO] Scanning for projects...{}}}{{{}[INFO]
{}}}{{{}[INFO] -< org.openjfx:sample
>-{}}}{{{}[INFO] Building sample 1.0.0{}}}{{{}[INFO]
from pom.xml{}}}{{{}[INFO] [ jar
]-{}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.pom
(908 B at 1.9 kB/s){}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx/22.0.1/javafx-22.0.1.pom
(8.4 kB at 165 kB/s){}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.pom
(904 B at 21 kB/s){}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.pom
(749 B at 17 kB/s){}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1.jar
(306 B at 6.8 kB/s){}}}{{{}Downloading from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-controls/22.0.1/javafx-controls-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar{}}}{{{}Downloading
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloading
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar{}}}{{{}Downloading
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1-$%7Bjavafx.platform%7D.jar{}}}{{{}Downloaded
from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-base/22.0.1/javafx-base-22.0.1.jar
(302 B at 2.4 kB/s){}}}{{{}Downloaded from central:
https://repo.maven.apache.org/maven2/org/openjfx/javafx-graphics/22.0.1/javafx-graphics-22.0.1.jar
(306 B at 2.4 kB/s){}}}{{{}[INFO]
{}}}{{{}[INFO]
BUILD FAILURE{}}}{{{}[INFO]
{}}}{{{}[INFO]
Total time: 1.378 s{}}}{{{}[INFO] Finished at:
2024-05-28T10:23:05-06:00{}}}{{{}[INFO]
{}}}{{{}[ERROR]
Failed to execute goal on project sample: Could not resolve dependencies for
project org.openjfx:sample:jar:1.0.0: The following artifacts could not be
resolved: org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 (absent),
org.openjfx:javafx-graphics:jar:${javafx.platform}:22.0.1 (absent),
org.openjfx:javafx-base:jar:${javafx.platform}:22.0.1 (absent): Could not find
artifact org.openjfx:javafx-controls:jar:${javafx.platform}:22.0.1 in central
(https://repo.maven.apache.org/maven2) -> [Help 1]{}}}{{{}[ERROR]
{}}}{{{}[ERROR] To see the full stack trace of the errors, re-run Maven with
the -e switch.{}}}{{{}[ERROR] Re-run Maven using the -X switch to enable full
debug logging.{}}}{{{}[ERROR] {}}}{{{}[ERROR] For more information about the
errors and possible solutions, please read the following
articles:{}}}{{{}[ERROR] [Help 1]
[jira] [Updated] (MSHADE-473) Drop legacy and superfluous deps: maven-dependency-tree and commons-collections4
[ https://issues.apache.org/jira/browse/MSHADE-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MSHADE-473: --- Summary: Drop legacy and superfluous deps: maven-dependency-tree and commons-collections4 (was: Drop plugin cruft) > Drop legacy and superfluous deps: maven-dependency-tree and > commons-collections4 > > > Key: MSHADE-473 > URL: https://issues.apache.org/jira/browse/MSHADE-473 > Project: Maven Shade Plugin > Issue Type: Task >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.6.0 > > > Plugin drags a lot of legacy and superfluous dependencies, get rid of them. > Such as maven-dependency-tree (that is about to be deprecated) and few lines > in one class uses commons-collections4. These are all not really necessary > and are just burden. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MWRAPPER-110) The Maven 3.9 `MAVEN_ARGS` env var is not supported
[
https://issues.apache.org/jira/browse/MWRAPPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850078#comment-17850078
]
Nils Breunese commented on MWRAPPER-110:
We use Maven Wrapper type {{bin}}, because our JDK build image doesn't contain
{{curl}} or {{wget}}, so moving to {{only-script}} is not immediately an option
for us. We migrated from {{MAVEN_CONFIG}} to {{MAVEN_ARGS}} because
{{MAVEN_CONFIG}} is no longer read since Maven Wrapper 3.3.0 (MWRAPPER-133),
but now it turns out that {{MAVEN_ARGS}} also doesn't work when calling Maven
via {{./mvnw}}. We really need an environment variable to pass Maven CLI
arguments, so support for {{MAVEN_ARGS}} would be really appreciated, or are
there any other options for us?
> The Maven 3.9 `MAVEN_ARGS` env var is not supported
> ---
>
> Key: MWRAPPER-110
> URL: https://issues.apache.org/jira/browse/MWRAPPER-110
> Project: Maven Wrapper
> Issue Type: Bug
> Components: Maven Wrapper Scripts
>Affects Versions: 3.2.0
>Reporter: Dimitar Dimitrov
>Priority: Major
>
> If we specify arguments in `MAVEN_ARGS`, they are picked up automatically by
> `mvn`, but not by `mvnw`.
> Please port this patch: [https://github.com/apache/maven/pull/49]
> A workaround is to export an extra env variable `MAVEN_CONFIG` which is
> picked by `mvnw`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8129) Incorrect relative path in transitive dependencies leads to build failure
[
https://issues.apache.org/jira/browse/MNG-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850076#comment-17850076
]
Tamas Cservenak commented on MNG-8129:
--
But parent/relativePath is not used when POM comes from local repository, is
build time only information, no? Why Maven even tries to resolve this path for
cached POM?
> Incorrect relative path in transitive dependencies leads to build failure
> -
>
> Key: MNG-8129
> URL: https://issues.apache.org/jira/browse/MNG-8129
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Kedar Joshi
>Priority: Major
> Labels: win64
>
> I was trying to build Spring Boot v3.3.0 project with latest beta and got
> following error (which does not occur on v3.9.x) -
>
> {code:java}
> [ERROR] Internal error: java.nio.file.InvalidPathException: Illegal char <:>
> at index 10: org.apache:apache -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:157)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at
> jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)
> Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
> at java.nio.file.Path.resolve(Path.java:516)
> at org.apache.maven.api.services.PathSource.resolve(PathSource.java:65)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.getParentPomFile(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParentLocally(DefaultModelBuilder.java:934)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParent(DefaultModelBuilder.java:904)
> {code}
> This exception occurs in *org.apache.maven.api.services.PathSource#resolve*
> method when parameter *relative* has value *org.apache:apache* since on
> Windows `:` is not allowed in file names.
> In Maven v3.x, this scenario is handled with `exists` check on the parent
> file and thus issue does not occur. No such check is done in v4.0.
> The source of the issue lies in
> *org.apache:apache* declaration in
> {*}https://repo.maven.apache.org/maven2/org/apache/activemq/artemis-project/2.33.0/artemis-project-2.33.0.pom{*}.
> As we can see, relative path *org.apache:apache* does not actually exist.
>
> I am using Windows 10 64 Bit.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8129) Incorrect relative path in transitive dependencies leads to build failure
[
https://issues.apache.org/jira/browse/MNG-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850075#comment-17850075
]
Tamas Cservenak commented on MNG-8129:
--
It does not: [https://gist.github.com/cstamas/b992091d9331ce45c032d804a31ec3bf]
Note: artemis-pom 2.23.0 has same issue
https://repo.maven.apache.org/maven2/org/apache/activemq/artemis-pom/2.23.0/artemis-pom-2.23.0.pom
> Incorrect relative path in transitive dependencies leads to build failure
> -
>
> Key: MNG-8129
> URL: https://issues.apache.org/jira/browse/MNG-8129
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Kedar Joshi
>Priority: Major
> Labels: win64
>
> I was trying to build Spring Boot v3.3.0 project with latest beta and got
> following error (which does not occur on v3.9.x) -
>
> {code:java}
> [ERROR] Internal error: java.nio.file.InvalidPathException: Illegal char <:>
> at index 10: org.apache:apache -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:157)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at
> jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)
> Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
> at java.nio.file.Path.resolve(Path.java:516)
> at org.apache.maven.api.services.PathSource.resolve(PathSource.java:65)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.getParentPomFile(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParentLocally(DefaultModelBuilder.java:934)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParent(DefaultModelBuilder.java:904)
> {code}
> This exception occurs in *org.apache.maven.api.services.PathSource#resolve*
> method when parameter *relative* has value *org.apache:apache* since on
> Windows `:` is not allowed in file names.
> In Maven v3.x, this scenario is handled with `exists` check on the parent
> file and thus issue does not occur. No such check is done in v4.0.
> The source of the issue lies in
> *org.apache:apache* declaration in
> {*}https://repo.maven.apache.org/maven2/org/apache/activemq/artemis-project/2.33.0/artemis-project-2.33.0.pom{*}.
> As we can see, relative path *org.apache:apache* does not actually exist.
>
> I am using Windows 10 64 Bit.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8129) Incorrect relative path in transitive dependencies leads to build failure
[
https://issues.apache.org/jira/browse/MNG-8129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850071#comment-17850071
]
Guillaume Nodet commented on MNG-8129:
--
This should generate a warning in 3.9.x
> Incorrect relative path in transitive dependencies leads to build failure
> -
>
> Key: MNG-8129
> URL: https://issues.apache.org/jira/browse/MNG-8129
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-beta-3
>Reporter: Kedar Joshi
>Priority: Major
> Labels: win64
>
> I was trying to build Spring Boot v3.3.0 project with latest beta and got
> following error (which does not occur on v3.9.x) -
>
> {code:java}
> [ERROR] Internal error: java.nio.file.InvalidPathException: Illegal char <:>
> at index 10: org.apache:apache -> [Help 1]
> org.apache.maven.InternalErrorException: Internal error:
> java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:157)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:958)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:205)
> at
> jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke(Method.java:580)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:255)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:201)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:361)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:314)
> Caused by: java.nio.file.InvalidPathException: Illegal char <:> at index 10:
> org.apache:apache
> at sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:204)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:175)
> at sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77)
> at sun.nio.fs.WindowsPath.parse(WindowsPath.java:92)
> at sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:231)
> at java.nio.file.Path.resolve(Path.java:516)
> at org.apache.maven.api.services.PathSource.resolve(PathSource.java:65)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.getParentPomFile(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParentLocally(DefaultModelBuilder.java:934)
> at
> org.apache.maven.internal.impl.model.DefaultModelBuilder.readParent(DefaultModelBuilder.java:904)
> {code}
> This exception occurs in *org.apache.maven.api.services.PathSource#resolve*
> method when parameter *relative* has value *org.apache:apache* since on
> Windows `:` is not allowed in file names.
> In Maven v3.x, this scenario is handled with `exists` check on the parent
> file and thus issue does not occur. No such check is done in v4.0.
> The source of the issue lies in
> *org.apache:apache* declaration in
> {*}https://repo.maven.apache.org/maven2/org/apache/activemq/artemis-project/2.33.0/artemis-project-2.33.0.pom{*}.
> As we can see, relative path *org.apache:apache* does not actually exist.
>
> I am using Windows 10 64 Bit.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8097) Validate that each dependency->type is a type registered in an artifact handler
[
https://issues.apache.org/jira/browse/MNG-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850037#comment-17850037
]
ASF GitHub Bot commented on MNG-8097:
-
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
or in https://github.com/apache/maven/pull/1466#issuecomment-2054145589
>> It is artifact that you need to inspect, not the backing file.
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle Validate that each dependency->type is a type registered in an artifact
> handler
> ---
>
> Key: MNG-8097
> URL: https://issues.apache.org/jira/browse/MNG-8097
> Project: Maven
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently often the dependency's type is being set to the extension and the
> resolution is lenient, i.e. if there is no artifact handler defining the
> value given in {{dependency->type}} resolution transparently uses the type as
> extension.
> That can potentially lead to two issues:
> 1. Resolution might fail with surprising error messages like
> {code}
> Could not resolve dependencies for project : The following artifacts
> could not be resolved: : Could not transfer artifact
> ::: from/to ...
> {code}
> This is an issue for all types not defined by Maven Core itself, e.g. for
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html which
> registers an artifact handler for type {{content-package}} with extension
> {{zip}}.
> 2. The information {{addedToClasspath}}, {{includesDependencies}} and
> {{classifier}} from the artifact handler is not evaluated
> Compare with
> https://maven.apache.org/repositories/artifacts.html#but-where-do-i-set-artifact-extension
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-8097] Outline the two different ways to reference a dependency [maven-site]
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
or in https://github.com/apache/maven/pull/1466#issuecomment-2054145589
>> It is artifact that you need to inspect, not the backing file.
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle
3. ```
org.project
my-content-package
1.0
zip
```
vs.
```
org.project
my-content-package
1.0
content-package
Please be more concise with your criticism so that I am able to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8097] Outline the two different ways to reference a dependency [maven-site]
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
> did you maybe mix up the "former and latter"?
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle
3. ```
org.project
my-content-package
1.0
zip
```
vs.
```
org.project
my-content-package
1.0
content-package
Please be more concise with your criticism so that I am able to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8097) Validate that each dependency->type is a type registered in an artifact handler
[
https://issues.apache.org/jira/browse/MNG-8097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850036#comment-17850036
]
ASF GitHub Bot commented on MNG-8097:
-
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
> did you maybe mix up the "former and latter"?
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle Validate that each dependency->type is a type registered in an artifact
> handler
> ---
>
> Key: MNG-8097
> URL: https://issues.apache.org/jira/browse/MNG-8097
> Project: Maven
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently often the dependency's type is being set to the extension and the
> resolution is lenient, i.e. if there is no artifact handler defining the
> value given in {{dependency->type}} resolution transparently uses the type as
> extension.
> That can potentially lead to two issues:
> 1. Resolution might fail with surprising error messages like
> {code}
> Could not resolve dependencies for project : The following artifacts
> could not be resolved: : Could not transfer artifact
> ::: from/to ...
> {code}
> This is an issue for all types not defined by Maven Core itself, e.g. for
> https://jackrabbit.apache.org/filevault-package-maven-plugin/index.html which
> registers an artifact handler for type {{content-package}} with extension
> {{zip}}.
> 2. The information {{addedToClasspath}}, {{includesDependencies}} and
> {{classifier}} from the artifact handler is not evaluated
> Compare with
> https://maven.apache.org/repositories/artifacts.html#but-where-do-i-set-artifact-extension
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.16 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #293: URL: https://github.com/apache/maven-plugin-tools/pull/293 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.11.13 to 1.14.16. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.14.16 Update ASM and introduce support for Java 23. Byte Buddy 1.14.15 Allow attaching from root on J9. Byte Buddy 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. Byte Buddy 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. Byte Buddy 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. Byte Buddy 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. byte-buddy-1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. Byte Buddy 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 Byte Buddy 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. Support APK 7.4+ versions in Byte Buddy Gradle for Android plugin. Byte Buddy 1.14.7 Correctly read minor version from class file. Catch type resolution errors when applying Plugin.Engine. Byte Buddy 1.14.6 Add PatchMode.SUBSTITUTE and ResettableClassFileTransformer.Substitutable for in-order patching. Allow for explicit specification og differential matcher when patching an AgentBuilder. Add platform loader to locator for build plugins. Correctly resolve accessors for fields with capitalized first letter. Make jars for Android read-only as newer versions require it. ... (truncated) Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>net.bytebuddy:byte-buddy's changelog. 22. May 2024: version 1.14.16 Update ASM and introduce support for Java 23. 8. May 2024: version 1.14.15 Allow attaching from root on J9. 23. April 2024: version 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. 28. March 2024: version 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. 16. February 2024: version 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. 21. December 2023: version 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. 16. October 2023: version 1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. 9. October 2023: version 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 15. September 2023: version 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. Support APK 7.4+ versions in Byte Buddy Gradle for Android plugin. 28. August 2023: version 1.14.7 ... (truncated) Commits https://github.com/raphw/byte-buddy/commit/8f37644d35fdb1478d0982995f9cee9f7e2a91ff;>8f37644 [maven-release-plugin] prepare release byte-buddy-1.14.16 https://github.com/raphw/byte-buddy/commit/9e62bad5a1535a7ab16275652eac81ee5597833f;>9e62bad [release] Release new version https://github.com/raphw/byte-buddy/commit/6dc6b2ee59071ea88dbf9c3bbe4bf7df7aa95a69;>6dc6b2e Add checksums and fix build configuration. https://github.com/raphw/byte-buddy/commit/840bab42306b5d074a9265511480d2388cec1d84;>840bab4 Add missing checksums
[PR] Bump org.codehaus.plexus:plexus-classworlds from 2.7.0 to 2.8.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #292: URL: https://github.com/apache/maven-plugin-tools/pull/292 Bumps [org.codehaus.plexus:plexus-classworlds](https://github.com/codehaus-plexus/plexus-classworlds) from 2.7.0 to 2.8.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-classworlds/releases;>org.codehaus.plexus:plexus-classworlds's releases. 2.8.0 pom.mxl and site.xml cleanup (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/95;>#95) https://github.com/hboutemy;>@hboutemy Dependency updates Migrate to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/86;>#86) https://github.com/slachiewicz;>@slachiewicz Update dependencies used in test to more recent ones with less CVE (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/88;>#88) https://github.com/slachiewicz;>@slachiewicz Maintenance Reuse plexus-pom action for CI (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/101;>#101) https://github.com/slachiewicz;>@slachiewicz Cleanup gha - use same defaults from template (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/87;>#87) https://github.com/slachiewicz;>@slachiewicz Commits https://github.com/codehaus-plexus/plexus-classworlds/commit/fc454e40c98c7122338a35733d8d00eee4e0eefb;>fc454e4 [maven-release-plugin] prepare release plexus-classworlds-2.8.0 https://github.com/codehaus-plexus/plexus-classworlds/commit/30cc871a4217ed0db11648c89649c62badf1d8a9;>30cc871 Bump org.codehaus.plexus:plexus from 15 to 16 https://github.com/codehaus-plexus/plexus-classworlds/commit/fe02226a5a32c5bdefbd887c1d1c52b38d2e0547;>fe02226 Reuse plexus-pom action for CI https://github.com/codehaus-plexus/plexus-classworlds/commit/07d2c10437f5c9826c0f4325eb7d3ccf5345ac2b;>07d2c10 Bump org.apache.maven.plugins:maven-dependency-plugin https://github.com/codehaus-plexus/plexus-classworlds/commit/d1bdf7c93cb215816e6eca5f84aadc39c30cf32e;>d1bdf7c fix surefire plugin config - forkMode none - forkCount 1 https://github.com/codehaus-plexus/plexus-classworlds/commit/32fac00c453d59ea2017533b55efaea7000c68f3;>32fac00 Bump org.codehaus.plexus:plexus from 14 to 15 https://github.com/codehaus-plexus/plexus-classworlds/commit/f70ed4a8fa1e8c265e7632c98eebec1584fe323a;>f70ed4a Bump org.codehaus.plexus:plexus from 13 to 14 https://github.com/codehaus-plexus/plexus-classworlds/commit/5f778ff6378aad5669365a1fb58f83fdb21c9caa;>5f778ff pom.mxl and site.xml cleanup https://github.com/codehaus-plexus/plexus-classworlds/commit/61101ebf31b3b41cabb82e70b1b97e107554d194;>61101eb Bump maven-bundle-plugin from 5.1.8 to 5.1.9 https://github.com/codehaus-plexus/plexus-classworlds/commit/78884e4d468ef8613ca0d29e5e815549af23e551;>78884e4 Bump maven-dependency-plugin from 3.5.0 to 3.6.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-classworlds/compare/plexus-classworlds-2.7.0...plexus-classworlds-2.8.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more
[PR] Bump maven3Version from 3.9.6 to 3.9.7 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #291: URL: https://github.com/apache/maven-plugin-tools/pull/291 Bumps `maven3Version` from 3.9.6 to 3.9.7. Updates `org.apache.maven:maven-model-builder` from 3.9.6 to 3.9.7 Release notes Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-model-builder's releases. 3.9.7 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12353964;>Release Notes - Maven - Version 3.9.7 ... (truncated) Commits https://github.com/apache/maven/commit/8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0;>8b094c9 [maven-release-plugin] prepare release maven-3.9.7 https://github.com/apache/maven/commit/6ff3a821e73ad5fa3fa30e40c51b161139573c15;>6ff3a82 [MNG-8125][MNG-8126][MNG-8127] Mild updates (https://redirect.github.com/apache/maven/issues/1533;>#1533) https://github.com/apache/maven/commit/73bc6caec7fb46d20aeefb29bc6bd00d39fb007e;>73bc6ca [MNG-8121] Fix NPE in metadata merge (https://redirect.github.com/apache/maven/issues/1508;>#1508) https://github.com/apache/maven/commit/558ae8a924440c57d7033ce039246d9b176d572b;>558ae8a [MNG-8115] Upgrade minimal set of dependencies (https://redirect.github.com/apache/maven/issues/1496;>#1496) https://github.com/apache/maven/commit/c44304fe33e091be2a4b6a5d65f06ba777a692a0;>c44304f [MNG-8118] Backport to Maven 3.9.x (https://redirect.github.com/apache/maven/issues/1505;>#1505) https://github.com/apache/maven/commit/c1c114dbf98f77eefacb5aa6887645e4de9f069c;>c1c114d [MNG-8081] Interpolate available properties during default profile selection ... https://github.com/apache/maven/commit/b4cbda8cb98ed1e72119d41095b9831ebd0fba86;>b4cbda8 [3.9.x][MNG-8109] Resolver 1.9.20 (https://redirect.github.com/apache/maven/issues/1490;>#1490) https://github.com/apache/maven/commit/bc52363d402f14043e2e4efed40799044cdf531b;>bc52363 [3.9.x][MNG-8106] Fix metadata merge (https://redirect.github.com/apache/maven/issues/1480;>#1480) https://github.com/apache/maven/commit/587e99bc70132f71d69305bcb7217ec5e151c25e;>587e99b [MNG-8094] Resolver 1.9.19 (https://redirect.github.com/apache/maven/issues/1468;>#1468) https://github.com/apache/maven/commit/548459b1a96b79d5e5917af17a0248954deaaa3f;>548459b [MNG-8011] Neuter the README (https://redirect.github.com/apache/maven/issues/1470;>#1470) Additional commits viewable in https://github.com/apache/maven/compare/maven-3.9.6...maven-3.9.7;>compare view Updates `org.apache.maven:maven-model` from 3.9.6 to 3.9.7 Release notes Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-model's releases. 3.9.7 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12353964;>Release Notes - Maven - Version 3.9.7 ... (truncated) Commits https://github.com/apache/maven/commit/8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0;>8b094c9 [maven-release-plugin] prepare release maven-3.9.7 https://github.com/apache/maven/commit/6ff3a821e73ad5fa3fa30e40c51b161139573c15;>6ff3a82 [MNG-8125][MNG-8126][MNG-8127] Mild updates (https://redirect.github.com/apache/maven/issues/1533;>#1533) https://github.com/apache/maven/commit/73bc6caec7fb46d20aeefb29bc6bd00d39fb007e;>73bc6ca [MNG-8121] Fix NPE in metadata merge (https://redirect.github.com/apache/maven/issues/1508;>#1508) https://github.com/apache/maven/commit/558ae8a924440c57d7033ce039246d9b176d572b;>558ae8a [MNG-8115] Upgrade minimal set of dependencies (https://redirect.github.com/apache/maven/issues/1496;>#1496) https://github.com/apache/maven/commit/c44304fe33e091be2a4b6a5d65f06ba777a692a0;>c44304f [MNG-8118] Backport to Maven 3.9.x (https://redirect.github.com/apache/maven/issues/1505;>#1505) https://github.com/apache/maven/commit/c1c114dbf98f77eefacb5aa6887645e4de9f069c;>c1c114d [MNG-8081] Interpolate available properties during default profile selection ... https://github.com/apache/maven/commit/b4cbda8cb98ed1e72119d41095b9831ebd0fba86;>b4cbda8 [3.9.x][MNG-8109] Resolver 1.9.20 (https://redirect.github.com/apache/maven/issues/1490;>#1490) https://github.com/apache/maven/commit/bc52363d402f14043e2e4efed40799044cdf531b;>bc52363 [3.9.x][MNG-8106] Fix metadata merge (https://redirect.github.com/apache/maven/issues/1480;>#1480) https://github.com/apache/maven/commit/587e99bc70132f71d69305bcb7217ec5e151c25e;>587e99b [MNG-8094] Resolver 1.9.19 (https://redirect.github.com/apache/maven/issues/1468;>#1468) https://github.com/apache/maven/commit/548459b1a96b79d5e5917af17a0248954deaaa3f;>548459b [MNG-8011] Neuter the README (https://redirect.github.com/apache/maven/issues/1470;>#1470) Additional commits viewable in https://github.com/apache/maven/compare/maven-3.9.6...maven-3.9.7;>compare view Updates `org.apache.maven:maven-plugin-api` from 3.9.6 to 3.9.7
[PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #290: URL: https://github.com/apache/maven-plugin-tools/pull/290 Bumps `resolverVersion` from 1.9.18 to 1.9.20. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.9.18 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12354578;>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/483;>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/484;>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3;>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82;>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484;>#484) https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56;>4f16d5e [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483;>#483) https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626;>c1b24c6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56;>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0;>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469;>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c;>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462;>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7;>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455;>#455) (https://redirect.github.com/apache/maven-resolver/issues/461;>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c;>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420;>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde;>a3e620d Use one Maven in CI Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.20;>compare view Updates `org.apache.maven.resolver:maven-resolver-util` from 1.9.18 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-util's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12354578;>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/483;>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/484;>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3;>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82;>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent
[jira] [Closed] (MSHADE-428) Typo causes mysterious NPE in build
[
https://issues.apache.org/jira/browse/MSHADE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MSHADE-428.
--
Assignee: Tamas Cservenak
Resolution: Fixed
> Typo causes mysterious NPE in build
> ---
>
> Key: MSHADE-428
> URL: https://issues.apache.org/jira/browse/MSHADE-428
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> All versions are affected.
> Has this config for plugin:
> {noformat}
>
> implementation="org.apache.maven.plugins.shade.resource.ComponentsXmlResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"
> />
> implementatioh="org.apache.maven.plugins.shade.resource.SisuIndexResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
>
>
> org.apache.maven.index.cli.NexusIndexerCli
> true
>
>
>{noformat}
> And build was failing with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.4.0:shade (default) on project
> indexer-cli: Error creating shaded jar: Problem shading JAR
> /home/cstamas/Worx/apache-maven/maven-indexer/indexer-cli/target/indexer-cli-7.0.0-SNAPSHOT.jar
> entry META-INF/sisu/javax.inject.Named: java.lang.NullPointerException ->
> [Help 1] {noformat}
> Cause: there is a typo in config, notive {{implementatioH}} for sisu
> transformer.
> This caused that list of transformes had a null element, and seems there is
> no validation that transformers list may not have null element. NPE happened
> when default shared method {{private boolean resourceTransformed(}} stepped
> onto null element and had {{null.canTransformResource( name )}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-428) Typo causes mysterious NPE in build
[
https://issues.apache.org/jira/browse/MSHADE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850023#comment-17850023
]
ASF GitHub Bot commented on MSHADE-428:
---
cstamas merged PR #229:
URL: https://github.com/apache/maven-shade-plugin/pull/229
> Typo causes mysterious NPE in build
> ---
>
> Key: MSHADE-428
> URL: https://issues.apache.org/jira/browse/MSHADE-428
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> All versions are affected.
> Has this config for plugin:
> {noformat}
>
> implementation="org.apache.maven.plugins.shade.resource.ComponentsXmlResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"
> />
> implementatioh="org.apache.maven.plugins.shade.resource.SisuIndexResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
>
>
> org.apache.maven.index.cli.NexusIndexerCli
> true
>
>
>{noformat}
> And build was failing with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.4.0:shade (default) on project
> indexer-cli: Error creating shaded jar: Problem shading JAR
> /home/cstamas/Worx/apache-maven/maven-indexer/indexer-cli/target/indexer-cli-7.0.0-SNAPSHOT.jar
> entry META-INF/sisu/javax.inject.Named: java.lang.NullPointerException ->
> [Help 1] {noformat}
> Cause: there is a typo in config, notive {{implementatioH}} for sisu
> transformer.
> This caused that list of transformes had a null element, and seems there is
> no validation that transformers list may not have null element. NPE happened
> when default shared method {{private boolean resourceTransformed(}} stepped
> onto null element and had {{null.canTransformResource( name )}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-428] Prevent null value in array of transformers [maven-shade-plugin]
cstamas merged PR #229: URL: https://github.com/apache/maven-shade-plugin/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 [maven-dist-tool]
dependabot[bot] closed pull request #55: Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 URL: https://github.com/apache/maven-dist-tool/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 [maven-dist-tool]
dependabot[bot] commented on PR #55: URL: https://github.com/apache/maven-dist-tool/pull/55#issuecomment-2135078243 Superseded by #58. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M15 [maven-dist-tool]
dependabot[bot] opened a new pull request, #58: URL: https://github.com/apache/maven-dist-tool/pull/58 Bumps [org.apache.maven.reporting:maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 4.0.0-M2 to 4.0.0-M15. Commits https://github.com/apache/maven-reporting-impl/commit/a5ac7d7c600a9bcb4d2fea6d32d75f03f2a8555d;>a5ac7d7 [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M15 https://github.com/apache/maven-reporting-impl/commit/610c5230c447102f9899a7ae35d30541c3b1df6c;>610c523 [MSHARED-1402] Upgrade plugins and components (in ITs) https://github.com/apache/maven-reporting-impl/commit/99d69ef381eec1db8bbdedfe4d51ef1699ce391f;>99d69ef [MSHARED-1397] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 (https://redirect.github.com/apache/maven-reporting-impl/issues/34;>#34) https://github.com/apache/maven-reporting-impl/commit/7bff1c2ddbe6d196ab71ad196a0367235a694332;>7bff1c2 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-reporting-impl/commit/4dae8a736ba7c32fed3dac76ecf547edb922d492;>4dae8a7 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-reporting-impl/commit/cefa8b026db16dab156d39cad7096a183046c467;>cefa8b0 [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M14 https://github.com/apache/maven-reporting-impl/commit/34de83672db5f01a3023d951db3366466d827f12;>34de836 [MSHARED-1361] Upgrade plugins and components (in ITs) (2) https://github.com/apache/maven-reporting-impl/commit/8464ab92499b37677eadf60ef4661bd9c847b0ac;>8464ab9 Bump org.junit:junit-bom from 5.10.1 to 5.10.2 https://github.com/apache/maven-reporting-impl/commit/e6db48408db861e3209748fe5ec10abd7dd25bfa;>e6db484 Add Dependabot config https://github.com/apache/maven-reporting-impl/commit/72181306bb0e12eed50c4ba4aec98dd76499df39;>7218130 [MSHARED-1348] Upgrade plugins and components (in ITs) Additional commits viewable in https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-4.0.0-M2...maven-reporting-impl-4.0.0-M15;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850013#comment-17850013
]
ASF GitHub Bot commented on MPLUGIN-526:
michael-o commented on PR #287:
URL:
https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135059349
> > > @michael-o @gnodet should we cherry-pick to 3.x branch?
> >
> >
> > If the 3.x branch is active, we should, but I should that @gnodet would
reset 3.x as as soon as he will bump master to 4.0.0.
>
> I've reset the 3.x branch to the current master (just after the release).
Perfect, thanks. Let's wait until the vote has passed and then we can
continue with your open PRs.
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
michael-o commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135059349 > > > @michael-o @gnodet should we cherry-pick to 3.x branch? > > > > > > If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. > > I've reset the 3.x branch to the current master (just after the release). Perfect, thanks. Let's wait until the vote has passed and then we can continue with your open PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850008#comment-17850008
]
ASF GitHub Bot commented on MPLUGIN-526:
gnodet commented on PR #287:
URL:
https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135049608
> > @michael-o @gnodet should we cherry-pick to 3.x branch?
>
> If the 3.x branch is active, we should, but I should that @gnodet would
reset 3.x as as soon as he will bump master to 4.0.0.
I've reset the 3.x branch to the current master (just after the release).
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
gnodet commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135049608 > > @michael-o @gnodet should we cherry-pick to 3.x branch? > > If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. I've reset the 3.x branch to the current master (just after the release). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-428) Typo causes mysterious NPE in build
[
https://issues.apache.org/jira/browse/MSHADE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849995#comment-17849995
]
ASF GitHub Bot commented on MSHADE-428:
---
cstamas opened a new pull request, #229:
URL: https://github.com/apache/maven-shade-plugin/pull/229
As Plexus will silently add it as in issue.
---
https://issues.apache.org/jira/browse/MSHADE-428
> Typo causes mysterious NPE in build
> ---
>
> Key: MSHADE-428
> URL: https://issues.apache.org/jira/browse/MSHADE-428
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> All versions are affected.
> Has this config for plugin:
> {noformat}
>
> implementation="org.apache.maven.plugins.shade.resource.ComponentsXmlResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"
> />
> implementatioh="org.apache.maven.plugins.shade.resource.SisuIndexResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
>
>
> org.apache.maven.index.cli.NexusIndexerCli
> true
>
>
>{noformat}
> And build was failing with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.4.0:shade (default) on project
> indexer-cli: Error creating shaded jar: Problem shading JAR
> /home/cstamas/Worx/apache-maven/maven-indexer/indexer-cli/target/indexer-cli-7.0.0-SNAPSHOT.jar
> entry META-INF/sisu/javax.inject.Named: java.lang.NullPointerException ->
> [Help 1] {noformat}
> Cause: there is a typo in config, notive {{implementatioH}} for sisu
> transformer.
> This caused that list of transformes had a null element, and seems there is
> no validation that transformers list may not have null element. NPE happened
> when default shared method {{private boolean resourceTransformed(}} stepped
> onto null element and had {{null.canTransformResource( name )}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHADE-428) Typo causes mysterious NPE in build
[
https://issues.apache.org/jira/browse/MSHADE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MSHADE-428:
---
Fix Version/s: 3.6.0
> Typo causes mysterious NPE in build
> ---
>
> Key: MSHADE-428
> URL: https://issues.apache.org/jira/browse/MSHADE-428
> Project: Maven Shade Plugin
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> All versions are affected.
> Has this config for plugin:
> {noformat}
>
> implementation="org.apache.maven.plugins.shade.resource.ComponentsXmlResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"
> />
> implementatioh="org.apache.maven.plugins.shade.resource.SisuIndexResourceTransformer"
> />
> implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
>
>
> org.apache.maven.index.cli.NexusIndexerCli
> true
>
>
>{noformat}
> And build was failing with
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-shade-plugin:3.4.0:shade (default) on project
> indexer-cli: Error creating shaded jar: Problem shading JAR
> /home/cstamas/Worx/apache-maven/maven-indexer/indexer-cli/target/indexer-cli-7.0.0-SNAPSHOT.jar
> entry META-INF/sisu/javax.inject.Named: java.lang.NullPointerException ->
> [Help 1] {noformat}
> Cause: there is a typo in config, notive {{implementatioH}} for sisu
> transformer.
> This caused that list of transformes had a null element, and seems there is
> no validation that transformers list may not have null element. NPE happened
> when default shared method {{private boolean resourceTransformed(}} stepped
> onto null element and had {{null.canTransformResource( name )}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-142) distributionUrl could be interpolated with env variables
[
https://issues.apache.org/jira/browse/MWRAPPER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philippe GRANET updated MWRAPPER-142:
-
Description:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
# {{{}$\{env.HOME{ etc. for environment variables
I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
you put this conf in _maven-wrapper.properties_ :
{code:java}
distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{code}
it generate this error:
{code:java}
wget: Failed to fetch
https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip{code}
{{ARTIFACTORY_URL env variable is not replaced}}
was:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
# {{{}$\{env.HOME{ etc. for environment variables
I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
you put this conf in maven-wrapper.properties :
{code:java}
distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{code}
it generate this error:
{code:java}
wget: Failed to fetch
https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip{code}
{{ARTIFACTORY_URL env variable is not replaced}}
> distributionUrl could be interpolated with env variables
>
>
> Key: MWRAPPER-142
> URL: https://issues.apache.org/jira/browse/MWRAPPER-142
> Project: Maven Wrapper
> Issue Type: New Feature
>Reporter: Philippe GRANET
>Priority: Major
>
> The contents of the {{settings.xml}} can be interpolated using the following
> expressions:
> # {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
> # {{{}$\{env.HOME{ etc. for environment variables
> I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
> you put this conf in _maven-wrapper.properties_ :
> {code:java}
> distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
> {code}
> it generate this error:
> {code:java}
> wget: Failed to fetch
> https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip{code}
> {{ARTIFACTORY_URL env variable is not replaced}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-142) distributionUrl could be interpolated with env variables
[
https://issues.apache.org/jira/browse/MWRAPPER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philippe GRANET updated MWRAPPER-142:
-
Description:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
# {{{}$\{env.HOME{ etc. for environment variables
I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
you put this conf in maven-wrapper.properties :
{code:java}
distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{code}
it generate this error:
{code:java}
wget: Failed to fetch
https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip{code}
{{ARTIFACTORY_URL env variable is not replaced}}
was:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
# {{{}$\{env.HOME{ etc. for environment variables
I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
you put this conf in maven-wrapper.properties :
{{distributionUrl=[https://$|https://$/]{ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
it generate this error:}}
wget: Failed to fetch
[https://$|https://$/]}ARTIFACTORY_URL{/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{{ARTIFACTORY_URL env variable is not replaced}}
{{}}
> distributionUrl could be interpolated with env variables
>
>
> Key: MWRAPPER-142
> URL: https://issues.apache.org/jira/browse/MWRAPPER-142
> Project: Maven Wrapper
> Issue Type: New Feature
>Reporter: Philippe GRANET
>Priority: Major
>
> The contents of the {{settings.xml}} can be interpolated using the following
> expressions:
> # {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
> # {{{}$\{env.HOME{ etc. for environment variables
> I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
> you put this conf in maven-wrapper.properties :
> {code:java}
> distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
> {code}
> it generate this error:
> {code:java}
> wget: Failed to fetch
> https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip{code}
> {{ARTIFACTORY_URL env variable is not replaced}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MWRAPPER-142) distributionUrl could be interpolated with env variables
[
https://issues.apache.org/jira/browse/MWRAPPER-142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philippe GRANET updated MWRAPPER-142:
-
Description:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
# {{{}$\{env.HOME{ etc. for environment variables
I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
you put this conf in maven-wrapper.properties :
{{distributionUrl=[https://$|https://$/]{ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
it generate this error:}}
wget: Failed to fetch
[https://$|https://$/]}ARTIFACTORY_URL{/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{{ARTIFACTORY_URL env variable is not replaced}}
{{}}
was:
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{${user.home}}} and all other system properties _(since Maven 3.0)_
# {{${env.HOME}}} etc. for environment variables
I tray the same with .mvn/wrapper/maven-wrapper.properties, but actually, if
you put this conf in maven-wrapper.properties :
{{distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
it generate this error:}}
wget: Failed to fetch
https://$}ARTIFACTORY_URL{/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{{ARTIFACTORY_URL env variable is not replaced}}
{{}}
> distributionUrl could be interpolated with env variables
>
>
> Key: MWRAPPER-142
> URL: https://issues.apache.org/jira/browse/MWRAPPER-142
> Project: Maven Wrapper
> Issue Type: New Feature
>Reporter: Philippe GRANET
>Priority: Major
>
> The contents of the {{settings.xml}} can be interpolated using the following
> expressions:
> # {{{}$\{user.home{ and all other system properties _(since Maven 3.0)_
> # {{{}$\{env.HOME{ etc. for environment variables
> I try the same with _.mvn/wrapper/maven-wrapper.properties,_ but actually, if
> you put this conf in maven-wrapper.properties :
> {{distributionUrl=[https://$|https://$/]{ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
> it generate this error:}}
> wget: Failed to fetch
> [https://$|https://$/]}ARTIFACTORY_URL{/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
> {{ARTIFACTORY_URL env variable is not replaced}}
> {{}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MWRAPPER-142) distributionUrl could be interpolated with env variables
Philippe GRANET created MWRAPPER-142:
Summary: distributionUrl could be interpolated with env variables
Key: MWRAPPER-142
URL: https://issues.apache.org/jira/browse/MWRAPPER-142
Project: Maven Wrapper
Issue Type: New Feature
Reporter: Philippe GRANET
The contents of the {{settings.xml}} can be interpolated using the following
expressions:
# {{${user.home}}} and all other system properties _(since Maven 3.0)_
# {{${env.HOME}}} etc. for environment variables
I tray the same with .mvn/wrapper/maven-wrapper.properties, but actually, if
you put this conf in maven-wrapper.properties :
{{distributionUrl=https://${ARTIFACTORY_URL}/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
it generate this error:}}
wget: Failed to fetch
https://$}ARTIFACTORY_URL{/artifactory/remote-maven-central/org/apache/maven/apache-maven/3.9.7/apache-maven-3.9.7-bin.zip
{{ARTIFACTORY_URL env variable is not replaced}}
{{}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-444) Parameter localRepository uses deprecated parameter expression ${localRepository}
[
https://issues.apache.org/jira/browse/MSHADE-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849988#comment-17849988
]
Tamas Cservenak commented on MSHADE-444:
This issue is fixed in some subsequent release, as current master does not use
deprecated type for parameter.
> Parameter localRepository uses deprecated parameter expression
> ${localRepository}
> -
>
> Key: MSHADE-444
> URL: https://issues.apache.org/jira/browse/MSHADE-444
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.4.1
>Reporter: Basil Crow
>Priority: Major
>
> h3. Reproduction steps
> * Use Maven 3.9.2.
> * Run {{mvn clean verify}} in a Maven project that uses Maven Shade Plugin.
> h3. Expected Results
> No warning
> h3. Actual Results
> {noformat}
> [WARNING] * org.apache.maven.plugins:maven-shade-plugin:3.4.1
> […]
> [WARNING] Mojo issue(s):
> [WARNING]* Mojo shade:shade
> (org.apache.maven.plugins.shade.mojo.ShadeMojo)
> [WARNING] - Parameter 'localRepository' uses deprecated parameter
> expression '${localRepository}': ArtifactRepository type is deprecated and
> its use in Mojos should be avoided.
> {noformat}
> h3. Anything else?
> See
> https://maven.apache.org/docs/3.9.2/release-notes.html#notable-new-features
> for the root cause.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MSHADE-478.
--
Resolution: Fixed
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849985#comment-17849985
]
Tamas Cservenak commented on MSHADE-478:
Merged as
https://github.com/apache/maven-shade-plugin/commit/b573b8c498ea12cd2b84edb45be3036d9853d03e
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849984#comment-17849984
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas merged PR #228:
URL: https://github.com/apache/maven-shade-plugin/pull/228
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas merged PR #228: URL: https://github.com/apache/maven-shade-plugin/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849979#comment-17849979
]
ASF GitHub Bot commented on MPLUGIN-526:
michael-o commented on PR #287:
URL:
https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134922184
> @michael-o @gnodet should we cherry-pick to 3.x branch?
If the 3.x branch is active, we should, but I should that @gnodet would
reset 3.x as as soon as he will bump master to 4.0.0.
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
michael-o commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134922184 > @michael-o @gnodet should we cherry-pick to 3.x branch? If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] First try [maven-surefire]
michael-o opened a new pull request, #737: URL: https://github.com/apache/maven-surefire/pull/737 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849965#comment-17849965
]
ASF GitHub Bot commented on MSHADE-478:
---
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616976316
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
```java
private void createErrorOutput() {
getLog().error("The project main artifact does not exist. This could
have the following");
getLog().error("reasons:");
```
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616976316
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
```java
private void createErrorOutput() {
getLog().error("The project main artifact does not exist. This could
have the following");
getLog().error("reasons:");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849962#comment-17849962
]
ASF GitHub Bot commented on MSHADE-478:
---
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616973202
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
Please check if this error message are correct here
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616973202
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
Please check if this error message are correct here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849955#comment-17849955
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616945401
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
pushed update
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
pushed update
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616945401
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
pushed update
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
pushed update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849953#comment-17849953
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616940993
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
The ["standard"
format](https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java#L51-L63),
will add to comment.
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849952#comment-17849952
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616939947
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
Yes, these are files.
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616940993
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
The ["standard"
format](https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java#L51-L63),
will add to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616939947
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
Yes, these are files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849950#comment-17849950
]
ASF GitHub Bot commented on MSHADE-478:
---
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616933185
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
we should add what is the item ... I guess that is a path to jar file
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849951#comment-17849951
]
ASF GitHub Bot commented on MSHADE-478:
---
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616934940
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
We should describe format of item ... `groupId:artifactId:...`
which items are required?
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616934940
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
We should describe format of item ... `groupId:artifactId:...`
which items are required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616933185
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
we should add what is the item ... I guess that is a path to jar file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849949#comment-17849949
]
ASF GitHub Bot commented on MPLUGIN-526:
slawekjaranowski commented on PR #287:
URL:
https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134786032
@michael-o @gnodet should we cherry-pick to 3.x branch?
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
slawekjaranowski commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134786032 @michael-o @gnodet should we cherry-pick to 3.x branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-mvnd]
gnodet merged PR #1003: URL: https://github.com/apache/maven-mvnd/pull/1003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-wrapper-plugin from 3.3.1 to 3.3.2 [maven-mvnd]
gnodet merged PR #1004: URL: https://github.com/apache/maven-mvnd/pull/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2240) Using JUnit BOM prevents upgrading the engine version via plugin dependency
[
https://issues.apache.org/jira/browse/SUREFIRE-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2240:
-
Fix Version/s: 3.2.6
(was: 3.x-candidate)
> Using JUnit BOM prevents upgrading the engine version via plugin dependency
> ---
>
> Key: SUREFIRE-2240
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2240
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support
>Affects Versions: 3.2.1
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 3.2.6
>
>
> The change being introduced in SUREFIRE-2177 prevents updating the
> {{junit-jupiter-engine}} through explicit plugin dependencies as outlined in
> https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html#select-engine-and-use-multiple-apis:
> {code}
>
> maven-surefire-plugin
>
>
> org.junit.jupiter
> junit-jupiter-engine
> 5.10.2
>
>
>
> {code}
> The following classpath is then used in m-surefire-p
> {code}
> [INFO] --- surefire:3.2.2:test (default-test) @ doxia-converter ---
> [DEBUG] Dependency collection stats {ConflictMarker.analyzeTime=62708,
> ConflictMarker.markTime=28792, ConflictMarker.nodeCount=94,
> ConflictIdSorter.graphTime=19292, ConflictIdSorter.topsortTime=17458,
> ConflictIdSorter.conflictIdCount=48, ConflictIdSorter.conflictIdCycleCount=0,
> ConflictResolver.totalTime=382250, ConflictResolver.conflictItemCount=92,
> DfDependencyCollector.collectTime=35588250,
> DfDependencyCollector.transformTime=530209}
> [DEBUG] org.apache.maven.plugins:maven-surefire-plugin:jar:3.2.2
> [DEBUG]org.junit.jupiter:junit-jupiter-engine:jar:5.10.2:runtime
> [DEBUG] org.junit.platform:junit-platform-engine:jar:1.9.3:runtime
> (version managed from default)
> ...
> {code}
> The managed {{junit-platform-engine}} version is incompatible (as being
> downgraded via
> https://github.com/apache/maven-surefire/blob/2fed802397f8c7de4cfc72f49ab4565e72f7aab7/pom.xml#L311-L318)
> For this reason there shouldn't be any depMgmt used in surefire.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849933#comment-17849933
]
Hudson commented on MPLUGIN-526:
Build failed in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #204
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/204/
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 [maven-plugin-tools]
asfgit merged PR #283: URL: https://github.com/apache/maven-plugin-tools/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-plugin-tools]
asfgit merged PR #289: URL: https://github.com/apache/maven-plugin-tools/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 [maven-plugin-tools]
michael-o commented on PR #283: URL: https://github.com/apache/maven-plugin-tools/pull/283#issuecomment-2134602135 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-plugin-tools]
michael-o commented on PR #289: URL: https://github.com/apache/maven-plugin-tools/pull/289#issuecomment-2134599150 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MPLUGIN-526.
--
Resolution: Fixed
Fixed with
[ca6a0739d4c239af9c52b8adb771579913082325|https://gitbox.apache.org/repos/asf?p=velocity-tools.git;a=commit;h=ca6a0739d4c239af9c52b8adb771579913082325].
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-526) Clean up dependencies reported by dependencies:analyze
[
https://issues.apache.org/jira/browse/MPLUGIN-526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849929#comment-17849929
]
ASF GitHub Bot commented on MPLUGIN-526:
asfgit closed pull request #287: [MPLUGIN-526] Clean up dependencies reported
by dependencies:analyze
URL: https://github.com/apache/maven-plugin-tools/pull/287
> Clean up dependencies reported by dependencies:analyze
> --
>
> Key: MPLUGIN-526
> URL: https://issues.apache.org/jira/browse/MPLUGIN-526
> Project: Maven Plugin Tools
> Issue Type: Task
>Affects Versions: 3.13.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.13.1
>
>
> A lot of output from {{dependencies:analyze}}. Let's clean up before we split.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
asfgit closed pull request #287: [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze URL: https://github.com/apache/maven-plugin-tools/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MSHADE-478:
---
Description:
Use case: Let's assume your main artifact is a "plugin" of some sort. Moreover,
assume that the "host" of your plugin uses SLF4J API for logging, hence the
module have {{slf4j-api}} declared as compile dependency (or provided, does not
matter). Still, you want to create a self contained JAR out of same module,
hence shade it. But the problem is given: how would standalone JAR log?
You should be able to "inject" extra JARs, but at the same time to have all the
"benefits" of all resource transformers as well (ie. your "extra artifact" may
have Sisu components, or Service providers).
The {{extrajars}} IT showcase this very scenario.
was:
Use case: Let's assume your main artifact is a "plugin" of some sort. Moreover,
assume that the "host" of your plugin uses SLF4J API for logging, hence the
module have {{slf4j-api}} declared as compile dependency (or provided, does not
matter). Still, you want to create a self contained JAR out of same module,
hence shade it. But the problem is given: how would standalone JAR log?
You should be able to "inject" extra JARs, but at the same time to have all the
"benefits" of all resource transformers as well (ie. your "extra artifact" may
have Sisu components, or Service providers).
The {{extrajars}} showcase this very scenario.
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} IT showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] closed pull request #285: Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 URL: https://github.com/apache/maven-javadoc-plugin/pull/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
michael-o commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134562214 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134562300 OK, I won't notify you about org.codehaus.plexus:plexus-archiver again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134561635 Sorry, the command you entered is not valid for this pull request. Please check the syntax and try again. Valid commands: For single dependency PRs, use commands like: `@dependabot ignore this major version` `@dependabot ignore this minor version` `@dependabot ignore this dependency` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
michael-o commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134561590 @dependabot ignore dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-javadoc-plugin]
dependabot[bot] commented on PR #284: URL: https://github.com/apache/maven-javadoc-plugin/pull/284#issuecomment-2134560977 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-javadoc-plugin]
dependabot[bot] closed pull request #284: Bump resolverVersion from 1.4.1 to 1.9.20 URL: https://github.com/apache/maven-javadoc-plugin/pull/284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-javadoc-plugin]
michael-o commented on PR #284: URL: https://github.com/apache/maven-javadoc-plugin/pull/284#issuecomment-2134560857 @dependabot ignore dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.commons:commons-compress from 1.26.1 to 1.26.2 [maven-mvnd]
gnodet merged PR #1001: URL: https://github.com/apache/maven-mvnd/pull/1001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849912#comment-17849912
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas closed pull request #226: [MSHADE-478] Extra JARs feature
URL: https://github.com/apache/maven-shade-plugin/pull/226
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849911#comment-17849911
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas opened a new pull request, #228:
URL: https://github.com/apache/maven-shade-plugin/pull/228
Ability to add "extra JARs and Artifacts" and still enjoy the full benefits
of relocation, resource transformation, etc.
---
https://issues.apache.org/jira/browse/MSHADE-478
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHADE-478) Add ability to inject extra artifacts into shaded output
[
https://issues.apache.org/jira/browse/MSHADE-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849913#comment-17849913
]
ASF GitHub Bot commented on MSHADE-478:
---
cstamas commented on PR #226:
URL:
https://github.com/apache/maven-shade-plugin/pull/226#issuecomment-2134517672
Superseded by https://github.com/apache/maven-shade-plugin/pull/228
> Add ability to inject extra artifacts into shaded output
>
>
> Key: MSHADE-478
> URL: https://issues.apache.org/jira/browse/MSHADE-478
> Project: Maven Shade Plugin
> Issue Type: New Feature
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.6.0
>
>
> Use case: Let's assume your main artifact is a "plugin" of some sort.
> Moreover, assume that the "host" of your plugin uses SLF4J API for logging,
> hence the module have {{slf4j-api}} declared as compile dependency (or
> provided, does not matter). Still, you want to create a self contained JAR
> out of same module, hence shade it. But the problem is given: how would
> standalone JAR log?
> You should be able to "inject" extra JARs, but at the same time to have all
> the "benefits" of all resource transformers as well (ie. your "extra
> artifact" may have Sisu components, or Service providers).
> The {{extrajars}} showcase this very scenario.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on PR #226: URL: https://github.com/apache/maven-shade-plugin/pull/226#issuecomment-2134517672 Superseded by https://github.com/apache/maven-shade-plugin/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas closed pull request #226: [MSHADE-478] Extra JARs feature URL: https://github.com/apache/maven-shade-plugin/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
