[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041768#comment-16041768 ] ASF GitHub Bot commented on METRON-990: --- GitHub user merrimanr opened a pull request: https://github.com/apache/metron/pull/613 METRON-990: Clean up and organize flux properties ## Contributor Comments This PR is mainly a refactor of the enrichment and indexing flux files along with their matching property files. The changes include: - moving important settings with hardcoded values in flux files to property files so that they are configurable through Ambari - removing old and unused properties - elasticsearch.properties file is now implemented as a jinja2 template in the mpack, matching the enrichment.properties implementation - global.json is now implemented as a jinja2 template in the mpack - properties are now organized in Ambari as separate tabs and sub sections, hopefully making them easier to find - changed a couple properties to use a dropdown widget in Ambari I wrote descriptions for new properties in a similar style as existing properties. I feel the descriptions are a little short, curious if others agree. I also stopped short of improving ALL our properties with better widgets than just a text box. I imagine people will have opinions on how to best present properties in Ambari but this is a start. This has been tested on full dev with the usual process. When reviewing, spin up full dev and navigate to the Metron service in Ambari. The Config section should look as described in the section above. The enrichment.properties and elasticsearch.properties should look much shorter and easier to read. One more thing. I added a rat exception for *.json.j2 since we already have an exception for *.json (no comments in json is the reason?). Let me know if that's wrong. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-990 Alternatively you can review and apply these changes as the patch at: https://g
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041855#comment-16041855 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/613 Still working on updating the integration tests with the new properties. Will have them fixed shortly. > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042978#comment-16042978 ] ASF GitHub Bot commented on METRON-990: --- GitHub user merrimanr reopened a pull request: https://github.com/apache/metron/pull/613 METRON-990: Clean up and organize flux properties ## Contributor Comments This PR is mainly a refactor of the enrichment and indexing flux files along with their matching property files. The changes include: - moving important settings with hardcoded values in flux files to property files so that they are configurable through Ambari - removing old and unused properties - elasticsearch.properties file is now implemented as a jinja2 template in the mpack, matching the enrichment.properties implementation - global.json is now implemented as a jinja2 template in the mpack - properties are now organized in Ambari as separate tabs and sub sections, hopefully making them easier to find - changed a couple properties to use a dropdown widget in Ambari I wrote descriptions for new properties in a similar style as existing properties. I feel the descriptions are a little short, curious if others agree. I also stopped short of improving ALL our properties with better widgets than just a text box. I imagine people will have opinions on how to best present properties in Ambari but this is a start. This has been tested on full dev with the usual process. When reviewing, spin up full dev and navigate to the Metron service in Ambari. The Config section should look as described in the section above. The enrichment.properties and elasticsearch.properties should look much shorter and easier to read. One more thing. I added a rat exception for *.json.j2 since we already have an exception for *.json (no comments in json is the reason?). Let me know if that's wrong. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via: ``` mvn -q clean integration-test install && build_utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/merrimanr/incubator-metron METRON-990 Alternatively you can review and apply these changes as the patch at: https:/
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042976#comment-16042976 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr closed the pull request at: https://github.com/apache/metron/pull/613 > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057672#comment-16057672 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123265664 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057673#comment-16057673 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123263841 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057744#comment-16057744 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123290700 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers --- End diff -- It does not seem like changes I make in Ambari are being propagated into the running topologies. Here is what I am seeing. After deploying in Full Dev, I went into Ambari and changed some Enrichment properties like "Enrichment Workers". The Enrichment component was then restarted. * In Ambari, the "Enrichment Workers" value is set to 2. This is what I expect. * When I look on disk `/usr/metron/0.4.0/config/enrichment.properties` the value is still the default of 1. I would expect to see 2 here. ``` enrichment.workers=1 ``` * The Storm UI also indicates that the Enrichment topology is running with a `topology.workers` value of 1. I would expect to see 2 here. > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057743#comment-16057743 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123287744 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers --- End diff -- After deploying in Full Dev, I went into Ambari and changed some Enrichment properties like "Enrichment Workers". After saving the changes, Ambari indicated that I needed to restart all of the Metron-related components. Even unrelated components like the Metron Management UI. It only really needed to restart the Enrichment topology. I am not sure what logic controls that. Is that something controlled in this PR? Or is that external to these changes? > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058266#comment-16058266 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368840 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058268#comment-16058268 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368910 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers --- End diff -- Fixed > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058267#comment-16058267 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368861 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment.properties.j2 --- @@ -16,72 +16,48 @@ # limitations under the License. #} -# Kafka # +# Storm # +enrichment.workers={{enrichment_workers}} +enrichment.acker.executors={{enrichment_acker_executors}} +topology.worker.childopts={{enrichment_topology_worker_childopts}} +topology.auto-credentials={{topology_auto_credentials}} +topology.max.spout.pending={{enrichment_topology_max_spout_pending}} +# Kafka # kafka.zk={{zookeeper_quorum}} kafka.broker={{kafka_brokers}} -kafka.security.protocol={{kafka_security_protocol}} -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -enrichment.output.topic=indexing -enrichment.error.topic=indexing -threat.intel.error.topic=indexing - -# Metrics # - -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false - -#Graphite Addresses +kafka.security.protocol=PLAINTEXT --- End diff -- Fixed > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058265#comment-16058265 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123368823 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058277#comment-16058277 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123370264 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers --- End diff -- This issue existed before this PR but I think it's annoying and would be happy to fix it. I will have to reorganize metron-env.xml into component-level files so I can make the configuration dependencies more granular. Will try to get this turned around quickly. > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058299#comment-16058299 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123372371 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers --- End diff -- Great. Feel free to do as a separate PR, if you like. Definitely not needed as part of this one. > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058304#comment-16058304 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123373290 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058310#comment-16058310 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123374090 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058309#comment-16058309 ] ASF GitHub Bot commented on METRON-990: --- Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123374060 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ -global-json -global.json template -This is the jinja template for global.json file - -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": ".MM.dd.HH", -"parser.error.topic": "indexing" -} - +es_date_format +Elasticsearch Date Format +.MM.dd.HH +Elasticsearch Date Format + + +parser_error_topic +Parser Error Topic +indexing +Parser Error Topic + + +enrichment_workers +Number of Enrichment Topology Workers +1 +Enrichment Workers + + +enrichment_acker_executors +Number of Enrichment Topology Ackers +1 +Enrichment Ackers + + +enrichment_topology_worker_childopts +Enrichment Topology JVM Options + +Enrichment childopts -content +true + + + +enrichment_topology_max_spout_pending +Enrichment Topology Spout Max Pending Tuples + +Enrichment Max Pending + +true -elasticsearch-properties -The template for the elasticsearch.properties file. -elasticsearch.properties template - -# Storm # -indexing.workers=1 -indexing.executors=0 -topology.worker.childopts={{topology_worker_childopts}} -topology.auto-credentials={{topology_auto_credentials}} -# Kafka # -kafka.zk={{ zookeeper_quorum }} -kafka.broker={{ kafka_brokers }} -kafka.start=UNCOMMITTED_EARLIEST -kafka.security.protocol={{kafka_security_protocol}} -storm.auto.credentials=[] -# Indexing # -index.input.topic=indexing -index.error.topic=indexing -writer.class.name=org.apache.metron.elasticsearch.writer.ElasticsearchWriter -# Metrics # -#reporters -org.apache.metron.metrics.reporter.graphite=true -org.apache.metron.metrics.reporter.console=false -org.apache.metron.metrics.reporter.jmx=false -#Graphite Addresses -org.apache.metron.metrics.graphite.address=localhost -org.apache.metron.metrics.graphite.port=2023 -#TelemetryParserBolt -org.apache.metron.metrics.TelemetryParserBolt.acks=true -org.apache.metron.metrics.TelemetryParserBolt.emits=true -org.apache.metron.metrics.TelemetryParserBolt.fails=true -# HDFS # -bolt.hdfs.batch.size=5000 -bolt.hdfs.field.delimiter=| -bolt.hdfs.rotation.policy=org.apache.storm.hdfs.bolt.rotation.TimedRotationPolicy -bolt.hdfs.rotation.policy.units=DAYS -bolt.hdfs.rotation.policy.count=1 -bolt.hdfs.file.rotation.size.in.mb=5 -bolt.hdfs.file.system.url={{ default_fs }} -bolt.hdfs.wip.file.path=/paloalto/wip -bolt.hdfs.finished.file.path=/paloalto/rotated -bolt.hdfs.compression.codec.class=org.apache.hadoop.io.compress.SnappyCodec -index.hdfs.output={{ metron_apps_indexed_hdfs_dir }} - +enrichment_kafka_start +Enrichment Topology Spout Offset +UNCOMMITTED_EARLIEST +Enrichment Offset + +value-list + + +EARLIEST + + +LATEST + + +UNCOMMITTED_EARLIEST + + +UNCOMMITTED_LATEST + + +1 + + + +enrichment_input_topic +Enrichment Input Topic +enrichments +Enrichment Input Topic + + +enrichment_output_topic +Enrichment Output Topic +indexing +Enrichment Output Topic + + +enrichment_error_topic +Enrichment Error Topic +indexing +Enrichment Error Topic + + +threatintel_error_topic +Threat
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059558#comment-16059558 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/613 Your updates look good @merrimanr. Just running it up again for a round of testing. > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16060211#comment-16060211 ] ASF GitHub Bot commented on METRON-990: --- Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/613 +1 I was able to alter settings for the Enrichment topology, successfully restart all services, and see the new configuration changes take effect. Splitting out all of the settings across different tabs is a really nice way to do it. Would have been a mess if you hadn't gone that extra mile. Nice > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (METRON-990) Clean up and organize flux properties
[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075009#comment-16075009 ] ASF GitHub Bot commented on METRON-990: --- Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/613 > Clean up and organize flux properties > - > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement >Reporter: Ryan Merriman >Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)