[GitHub] [nifi] peetkes commented on a change in pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property
peetkes commented on a change in pull request #3956: Added NTLM Authentication
based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#discussion_r363626510
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@ -113,9 +114,10 @@
import static org.apache.commons.lang3.StringUtils.trimToEmpty;
@SupportsBatching
-@Tags({"http", "https", "rest", "client"})
+@Tags({"http", "https", "rest", "client","ntlm"})
@InputRequirement(Requirement.INPUT_ALLOWED)
@CapabilityDescription("An HTTP client processor which can interact with a
configurable HTTP Endpoint. The destination URL and HTTP Method are
configurable."
++ " Also supports NTLM authentication to communicate with a sharepoint
webservice"
+ " FlowFile attributes are converted to HTTP headers and the FlowFile
contents are included as the body of the request (if the HTTP Method is PUT,
POST or PATCH).")
Review comment:
Adjusted the Description, works with NTLM in general
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6915) Jms Durable non shared subscription is broken
[
https://issues.apache.org/jira/browse/NIFI-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gardella Juan Pablo updated NIFI-6915:
--
Status: Patch Available (was: In Progress)
> Jms Durable non shared subscription is broken
> -
>
> Key: NIFI-6915
> URL: https://issues.apache.org/jira/browse/NIFI-6915
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2, 1.9.1, 1.10.0, 1.9.0, 1.8.0, 1.7.0, 1.6.0
> Environment: All
>Reporter: Gardella Juan Pablo
>Assignee: Gardella Juan Pablo
>Priority: Critical
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The enhancement NIFI-4834 broke JMS non shared Durable subscriptions. It may
> lose messages after stopping and starting a {{ConsumeJMS}} processor as
> [client ID is always
> different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189]
> since NIFI-4834.
> Using different client identifiers, makes the consumer missing messages after
> it is restarted. The problem is when some messages were published to the
> topic during the consumer is not running.
> A simple solution is to keep old behavior if it is a durable subscriber.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] gardellajuanpablo opened a new pull request #3961: NIFI-6915 Jms Durable non shared subscription is broken
gardellajuanpablo opened a new pull request #3961: NIFI-6915 Jms Durable non
shared subscription is broken
URL: https://github.com/apache/nifi/pull/3961
Revert NIFI-4834 enhancement for durable non shared consumers only.
Updated also AbstractJMSProcessor class to be public. The testing are not
working
without that change, as org.apache.nifi.jms.processors.PublishJMSIT and
org.apache.nifi.jms.processors.ConsumeJMSIT are not working, as @OnSchedule
method is not called (because it is not public).
The method org.apache.nifi.util.StandardProcessorTestRunner.run(int
iterations, boolean stopOnFinish, boolean initialize, long runWait) uses
ReflectionUtils.invokeMethodsWithAnnotation which does not call non public
methods.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6915) Jms Durable non shared subscription is broken
[
https://issues.apache.org/jira/browse/NIFI-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gardella Juan Pablo updated NIFI-6915:
--
Summary: Jms Durable non shared subscription is broken (was: Jms Durable
subscription is broken)
> Jms Durable non shared subscription is broken
> -
>
> Key: NIFI-6915
> URL: https://issues.apache.org/jira/browse/NIFI-6915
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.9.1, 1.9.2
> Environment: All
>Reporter: Gardella Juan Pablo
>Assignee: Gardella Juan Pablo
>Priority: Critical
>
> The enhancement NIFI-4834 broke JMS non shared Durable subscriptions. It may
> lose messages after stopping and starting a {{ConsumeJMS}} processor as
> [client ID is always
> different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189]
> since NIFI-4834.
> Using different client identifiers, makes the consumer missing messages after
> it is restarted. The problem is when some messages were published to the
> topic during the consumer is not running.
> A simple solution is to keep old behavior if it is a durable subscriber.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (NIFI-6915) Jms Durable subscription is broken
[
https://issues.apache.org/jira/browse/NIFI-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gardella Juan Pablo reassigned NIFI-6915:
-
Assignee: Gardella Juan Pablo
> Jms Durable subscription is broken
> --
>
> Key: NIFI-6915
> URL: https://issues.apache.org/jira/browse/NIFI-6915
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.9.1, 1.9.2
> Environment: All
>Reporter: Gardella Juan Pablo
>Assignee: Gardella Juan Pablo
>Priority: Critical
>
> The enhancement NIFI-4834 broke JMS non shared Durable subscriptions. It may
> lose messages after stopping and starting a {{ConsumeJMS}} processor as
> [client ID is always
> different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189]
> since NIFI-4834.
> Using different client identifiers, makes the consumer missing messages after
> it is restarted. The problem is when some messages were published to the
> topic during the consumer is not running.
> A simple solution is to keep old behavior if it is a durable subscriber.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-6915) Jms Durable subscription is broken
[
https://issues.apache.org/jira/browse/NIFI-6915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gardella Juan Pablo updated NIFI-6915:
--
Description:
The enhancement NIFI-4834 broke JMS non shared Durable subscriptions. It may
lose messages after stopping and starting a {{ConsumeJMS}} processor as [client
ID is always
different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189]
since NIFI-4834.
Using different client identifiers, makes the consumer missing messages after
it is restarted. The problem is when some messages were published to the topic
during the consumer is not running.
A simple solution is to keep old behavior if it is a durable subscriber.
was:
The enhancement NIFI-4834 broke JMS Durable subscriptions because after stop
and start a {{ConsumeJMS}} processor the [client ID is always
different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189].
Using different client identifiers make the consumer missing messages after
it is stopped, some messages were published to the topic and then, the consumer
is started.
A simple solution is to keep old behavior if it is a durable subscriber.
> Jms Durable subscription is broken
> --
>
> Key: NIFI-6915
> URL: https://issues.apache.org/jira/browse/NIFI-6915
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.6.0, 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.9.1, 1.9.2
> Environment: All
>Reporter: Gardella Juan Pablo
>Priority: Critical
>
> The enhancement NIFI-4834 broke JMS non shared Durable subscriptions. It may
> lose messages after stopping and starting a {{ConsumeJMS}} processor as
> [client ID is always
> different|https://github.com/apache/nifi/pull/2445/commits/cd091103e4a76e7b54e00257e5e18eaab3d389ec#diff-4ce7e53c92829e48b85959da41653f2bR189]
> since NIFI-4834.
> Using different client identifiers, makes the consumer missing messages after
> it is restarted. The problem is when some messages were published to the
> topic during the consumer is not running.
> A simple solution is to keep old behavior if it is a durable subscriber.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6982) It is not very clear how to use the NiFi API. Some details can be added.
[ https://issues.apache.org/jira/browse/NIFI-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009385#comment-17009385 ] Tushar Sarma commented on NIFI-6982: Thanks for removing the fix version, i did not realize that i should not add it Can we also have one more option "Documentation" under "Issue Type" while creating a new issue? Is there any other way to send request to add more details to some part of the documentation? This Jira is about how to use the various APIs, for e.g. probably we need to use " [http://ip:port/nifi-api/flow/process-groups/root; |http://localhost:8080/nifi-api/flow/process-groups/root]to get the process group ID of the root so that we can add processor to it and then create connection/snippet etc. > It is not very clear how to use the NiFi API. Some details can be added. > > > Key: NIFI-6982 > URL: https://issues.apache.org/jira/browse/NIFI-6982 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Affects Versions: 1.10.0 >Reporter: Tushar Sarma >Priority: Minor > > Suppose we want to build an IOT solution and use MiNi/NiFi to create a flow > where source will be MQTT and destination is Kafka and we want to create the > flow programmatically using the NiFi REST API > > While the APIs are quite powerful, it is not very clear what APIs to be used > for various use case like Create a data flow using API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] shawnweeks commented on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers
shawnweeks commented on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers URL: https://github.com/apache/nifi/pull/3959#issuecomment-571381257 My test runs fine on the new build. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6978) Log which encrypted configuration value is improperly formatted
[
https://issues.apache.org/jira/browse/NIFI-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
M Tien updated NIFI-6978:
-
Status: Patch Available (was: In Progress)
> Log which encrypted configuration value is improperly formatted
> ---
>
> Key: NIFI-6978
> URL: https://issues.apache.org/jira/browse/NIFI-6978
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.10.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As reported on the mailing list, a user has improperly formatted encrypted
> configuration value in {{nifi.properties}} or another configuration file. The
> error message in {{nifi-app.log}} is:
> {code}
> 2019-12-31 05:42:26,515 INFO [main] o.a.n.properties.ProtectedNiFiProperties
> There are 5 protected properties of 5 sensitive properties (100%)
> 2019-12-31 05:42:26,517 ERROR [main] org.apache.nifi.NiFi Failure to launch
> NiFi due to java.lang.IllegalArgumentException: There was an issue decrypting
> protected properties
> java.lang.IllegalArgumentException: There was an issue decrypting protected
> properties
> at org.apache.nifi.NiFi.initializeProperties(NiFi.java:341)
> at
> org.apache.nifi.NiFi.convertArgumentsToValidatedNiFiProperties(NiFi.java:309)
> at org.apache.nifi.NiFi.main(NiFi.java:300)
> Caused by: java.lang.IllegalArgumentException: The cipher text does not
> contain the delimiter || -- it should be of the form Base64(IV) ||
> Base64(cipherText)
> at
> org.apache.nifi.properties.AESSensitivePropertyProvider.unprotect(AESSensitivePropertyProvider.java:217)
> at
> org.apache.nifi.properties.ProtectedNiFiProperties.unprotectValue(ProtectedNiFiProperties.java:524)
> at
> org.apache.nifi.properties.ProtectedNiFiProperties.getUnprotectedProperties(ProtectedNiFiProperties.java:343)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.load(NiFiPropertiesLoader.java:209)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.load(NiFiPropertiesLoader.java:223)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.loadDefault(NiFiPropertiesLoader.java:130)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.get(NiFiPropertiesLoader.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.nifi.NiFi.initializeProperties(NiFi.java:336)
> ... 2 common frames omitted
> Received trapped signal, beginning shutdown...
> {code}
> The relevant code in {{ProtectedNiFiProperties.java}} is:
> {code}
> try {
> SensitivePropertyProvider sensitivePropertyProvider =
> getSensitivePropertyProvider(protectionScheme);
> return sensitivePropertyProvider.unprotect(retrievedValue);
> } catch (SensitivePropertyProtectionException e) {
> throw new SensitivePropertyProtectionException("Error
> unprotecting value for " + key, e.getCause());
> }
> {code}
> Currently, the {{IllegalArgumentException}} is not caught here, so the
> specific improperly-formatted value is not identified in the log. Manual
> inspection of the file is required.
> The {{IAE}} should be caught in the same block and treated identically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] shawnweeks removed a comment on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers
shawnweeks removed a comment on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers URL: https://github.com/apache/nifi/pull/3959#issuecomment-571379551 My examples run without error now. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] shawnweeks commented on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers
shawnweeks commented on issue #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers URL: https://github.com/apache/nifi/pull/3959#issuecomment-571379551 My examples run without error now. +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mtien-apache opened a new pull request #3960: NIFI-6978 Added code and unit test to throw IllegalArgumentException …
mtien-apache opened a new pull request #3960: NIFI-6978 Added code and unit
test to throw IllegalArgumentException …
URL: https://github.com/apache/nifi/pull/3960
…when improper value given
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Added code to throw IllegalArgumentException when improper value given.
Added unit test to verify IAE.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/7/20 12:06 AM:
---
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so (*confirmed working)*:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
// This should remove any trailing paths: /nifi-registry, /../..
// as well as any query parameters ?a=b and any combo of the two.
uri = new URIBuilder(registryUrl)
.setPath("")
.removeQuery()
.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for URI " + registryUrl
+ " because this NiFi is not configured with a
Keystore/Truststore, so it is not capable of communicating with a secure
Registry. "
+ "Please populate NiFi's Keystore/Truststore properties or
connect to a NiFi Registry over http instead of https.");
}
registry = new RestBasedFlowRegistry(this, registryId,
registryBaseUrl, sslContext, registryName);
registry.setDescription(description);
} else {
throw new IllegalArgumentException("Cannot create Flow Registry
with URI of " + registryUrl
+ " because there are no known implementations of Flow
Registries that can handle URIs of scheme " + uriScheme);
}
addFlowRegistry(registry);
return registry;
}
{code}
was (Author: superkool):
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so *confirmed working*:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
// This should remove any trailing paths: /nifi-registry, /../..
// as well as any query parameters ?a=b and any combo of the two.
uri = new URIBuilder(registryUrl)
.setPath("")
.removeQuery()
.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/7/20 12:06 AM:
---
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so *confirmed working*:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
// This should remove any trailing paths: /nifi-registry, /../..
// as well as any query parameters ?a=b and any combo of the two.
uri = new URIBuilder(registryUrl)
.setPath("")
.removeQuery()
.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for URI " + registryUrl
+ " because this NiFi is not configured with a
Keystore/Truststore, so it is not capable of communicating with a secure
Registry. "
+ "Please populate NiFi's Keystore/Truststore properties or
connect to a NiFi Registry over http instead of https.");
}
registry = new RestBasedFlowRegistry(this, registryId,
registryBaseUrl, sslContext, registryName);
registry.setDescription(description);
} else {
throw new IllegalArgumentException("Cannot create Flow Registry
with URI of " + registryUrl
+ " because there are no known implementations of Flow
Registries that can handle URIs of scheme " + uriScheme);
}
addFlowRegistry(registry);
return registry;
}
{code}
was (Author: superkool):
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
// This should remove any trailing paths: /nifi-registry, /../..
// as well as any query parameters ?a=b and any combo of the two.
uri = new URIBuilder(registryUrl)
.setPath("")
.removeQuery()
.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/6/20 11:11 PM:
---
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
// This should remove any trailing paths: /nifi-registry, /../..
// as well as any query parameters ?a=b and any combo of the two.
uri = new URIBuilder(registryUrl)
.setPath("")
.removeQuery()
.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for URI " + registryUrl
+ " because this NiFi is not configured with a
Keystore/Truststore, so it is not capable of communicating with a secure
Registry. "
+ "Please populate NiFi's Keystore/Truststore properties or
connect to a NiFi Registry over http instead of https.");
}
registry = new RestBasedFlowRegistry(this, registryId,
registryBaseUrl, sslContext, registryName);
registry.setDescription(description);
} else {
throw new IllegalArgumentException("Cannot create Flow Registry
with URI of " + registryUrl
+ " because there are no known implementations of Flow
Registries that can handle URIs of scheme " + uriScheme);
}
addFlowRegistry(registry);
return registry;
}
{code}
was (Author: superkool):
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
URIBuilder uriBuilder = new URIBuilder(registryUrl);
// This should remove any trailing paths such as /nifi-registry or
/../..
uriBuilder.setPath("");
// This should remove any query parameters ?a=b
uriBuilder.removeQuery();
uri = uriBuilder.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/6/20 11:02 PM:
---
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
URIBuilder uriBuilder = new URIBuilder(registryUrl);
// This should remove any trailing paths such as /nifi-registry or
/../..
uriBuilder.setPath("");
// This should remove any query parameters ?a=b
uriBuilder.removeQuery();
uri = uriBuilder.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
// This will be the base URI with no paths or params. But will include
the port if set initially.
final String registryBaseUrl = uri.toString();
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for URI " + registryUrl
+ " because this NiFi is not configured with a
Keystore/Truststore, so it is not capable of communicating with a secure
Registry. "
+ "Please populate NiFi's Keystore/Truststore properties or
connect to a NiFi Registry over http instead of https.");
}
registry = new RestBasedFlowRegistry(this, registryId,
registryBaseUrl, sslContext, registryName);
registry.setDescription(description);
} else {
throw new IllegalArgumentException("Cannot create Flow Registry
with URI of " + registryUrl
+ " because there are no known implementations of Flow
Registries that can handle URIs of scheme " + uriScheme);
}
addFlowRegistry(registry);
return registry;
}
{code}
was (Author: superkool):
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
URIBuilder uriBuilder = new URIBuilder(registryUrl);
uriBuilder.setPath(""); // This should remove any
trailing paths such as /nifi-registry or /../..
uriBuilder.removeQuery(); // This should remove any query
parameters ?a=b
uri = uriBuilder.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
final String registryBaseUrl = uri.toString(); // This will be the
base URI with no paths or params. But will include the port if set initially.
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/6/20 11:01 PM:
---
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
I would rewrite the method as so:
{code:java}
import org.apache.http.client.utils.URIBuilder;
@Override
public FlowRegistry addFlowRegistry(final String registryId, final String
registryName, final String registryUrl, final String description) {
final URI uri;
try {
URIBuilder uriBuilder = new URIBuilder(registryUrl);
uriBuilder.setPath(""); // This should remove any
trailing paths such as /nifi-registry or /../..
uriBuilder.removeQuery(); // This should remove any query
parameters ?a=b
uri = uriBuilder.build();
//uri = new URI(registryUrl);
} catch (URISyntaxException e) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
final String uriScheme = uri.getScheme();
if (uriScheme == null) {
throw new IllegalArgumentException("The given Registry URL is not
valid: " + registryUrl);
}
// Handles case where the URI entered has a trailing slash, or includes
the trailing /nifi-registry-api
// final String registryBaseUrl = uri.getScheme() + "://" +
uri.getHost() + ":" + uri.getPort();
final String registryBaseUrl = uri.toString(); // This will be the
base URI with no paths or params. But will include the port if set initially.
final FlowRegistry registry;
if (uriScheme.equalsIgnoreCase("http") ||
uriScheme.equalsIgnoreCase("https")) {
final SSLContext sslContext =
SslContextFactory.createSslContext(nifiProperties);
if (sslContext == null && uriScheme.equalsIgnoreCase("https")) {
throw new IllegalStateException("Failed to create Flow Registry
for URI " + registryUrl
+ " because this NiFi is not configured with a
Keystore/Truststore, so it is not capable of communicating with a secure
Registry. "
+ "Please populate NiFi's Keystore/Truststore properties or
connect to a NiFi Registry over http instead of https.");
}
registry = new RestBasedFlowRegistry(this, registryId,
registryBaseUrl, sslContext, registryName);
registry.setDescription(description);
} else {
throw new IllegalArgumentException("Cannot create Flow Registry
with URI of " + registryUrl
+ " because there are no known implementations of Flow
Registries that can handle URIs of scheme " + uriScheme);
}
addFlowRegistry(registry);
return registry;
}
{code}
was (Author: superkool):
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
> NiFi Registry Config does not persist after a cluster restart
> -
>
> Key: NIFI-6767
> URL: https://issues.apache.org/jira/browse/NIFI-6767
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Affects Versions: 1.10.0, 1.9.2
>Reporter: John E Fortin
>Priority: Major
> Attachments: registry-bad.png
>
>
> After configuring the NiFi Registery and versioning flows the Registry works
> fine. However, after restarting the NiFI cluster the Registry Config now has
> "https://null:-1; as the value for the Registry URL.
> If I reconfigure the URL it works fine until the next Cluster restart.
> This has been happening since 1.9.1 (that I know of) and continues into 1.10
> It's not a show stopper, but is quite annoying
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009209#comment-17009209
]
Kristjan Antunovic commented on NIFI-6767:
--
[~bbende] This is the problematic piece of code:
{code:java}
final String registryBaseUrl = uri.getScheme() + "://" + uri.getHost() + ":" +
uri.getPort();
{code}
> NiFi Registry Config does not persist after a cluster restart
> -
>
> Key: NIFI-6767
> URL: https://issues.apache.org/jira/browse/NIFI-6767
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Affects Versions: 1.10.0, 1.9.2
>Reporter: John E Fortin
>Priority: Major
> Attachments: registry-bad.png
>
>
> After configuring the NiFi Registery and versioning flows the Registry works
> fine. However, after restarting the NiFI cluster the Registry Config now has
> "https://null:-1; as the value for the Registry URL.
> If I reconfigure the URL it works fine until the next Cluster restart.
> This has been happening since 1.9.1 (that I know of) and continues into 1.10
> It's not a show stopper, but is quite annoying
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009203#comment-17009203
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/6/20 10:28 PM:
---
[~bbende] I managed to replicate this issue. Found the bug in following method:
{code:java}
StandardFlowRegistryClient@addFlowRegistry
{code}
The method saves domains in this format: http://domain.com:-1 or
https://domain.com:-1 if you are using http or https. If you than restart NiFi
the *registryUri* parameter comes in as such: *https://domain.com:-1*
The trailing *:-1* results in the invalid URI object that is being created in
the first line. When calling *getHost()* on this URI it will return *null* and
persist it again to flow file thus corrupting your URL.
I was able to replicate this pretty easily with just simple setup. Add registry
to nifi, restart it and the URL is gone.
was (Author: superkool):
[~bbende] I managed to replicate this issue. Found the bug in following method:
{code:java}
StandardFlowRegistryClient@addFlowRegistry
{code}
> NiFi Registry Config does not persist after a cluster restart
> -
>
> Key: NIFI-6767
> URL: https://issues.apache.org/jira/browse/NIFI-6767
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Affects Versions: 1.10.0, 1.9.2
>Reporter: John E Fortin
>Priority: Major
> Attachments: registry-bad.png
>
>
> After configuring the NiFi Registery and versioning flows the Registry works
> fine. However, after restarting the NiFI cluster the Registry Config now has
> "https://null:-1; as the value for the Registry URL.
> If I reconfigure the URL it works fine until the next Cluster restart.
> This has been happening since 1.9.1 (that I know of) and continues into 1.10
> It's not a show stopper, but is quite annoying
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[
https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009203#comment-17009203
]
Kristjan Antunovic edited comment on NIFI-6767 at 1/6/20 10:24 PM:
---
[~bbende] I managed to replicate this issue. Found the bug in following method:
{code:java}
StandardFlowRegistryClient@addFlowRegistry
{code}
was (Author: superkool):
[~bbende] I managed to replicate this issue.
> NiFi Registry Config does not persist after a cluster restart
> -
>
> Key: NIFI-6767
> URL: https://issues.apache.org/jira/browse/NIFI-6767
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Affects Versions: 1.10.0, 1.9.2
>Reporter: John E Fortin
>Priority: Major
> Attachments: registry-bad.png
>
>
> After configuring the NiFi Registery and versioning flows the Registry works
> fine. However, after restarting the NiFI cluster the Registry Config now has
> "https://null:-1; as the value for the Registry URL.
> If I reconfigure the URL it works fine until the next Cluster restart.
> This has been happening since 1.9.1 (that I know of) and continues into 1.10
> It's not a show stopper, but is quite annoying
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6767) NiFi Registry Config does not persist after a cluster restart
[ https://issues.apache.org/jira/browse/NIFI-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009203#comment-17009203 ] Kristjan Antunovic commented on NIFI-6767: -- [~bbende] I managed to replicate this issue. > NiFi Registry Config does not persist after a cluster restart > - > > Key: NIFI-6767 > URL: https://issues.apache.org/jira/browse/NIFI-6767 > Project: Apache NiFi > Issue Type: Bug > Components: Flow Versioning >Affects Versions: 1.10.0, 1.9.2 >Reporter: John E Fortin >Priority: Major > Attachments: registry-bad.png > > > After configuring the NiFi Registery and versioning flows the Registry works > fine. However, after restarting the NiFI cluster the Registry Config now has > "https://null:-1; as the value for the Registry URL. > If I reconfigure the URL it works fine until the next Cluster restart. > This has been happening since 1.9.1 (that I know of) and continues into 1.10 > It's not a show stopper, but is quite annoying -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 opened a new pull request #3959: NIFI-6886: Fix issue with SiteToSite refreshing peers
mattyb149 opened a new pull request #3959: NIFI-6886: Fix issue with SiteToSite
refreshing peers
URL: https://github.com/apache/nifi/pull/3959
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571321819 Thank you very much @joewitt for merging my change to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571321490 > @bahlulh the email on your author line for git is quite lengthy. It is better this is something more clearly tied to you from a provenance point of view. > > More important though is your commit message needs to indicate teh JIRA involved. > > For instance the commit message should start with 'NIFI-6942 ...' > > I'll fix this in the commit message that gets merged. But please correct for future contribs. > > Thanks I will follow the guidance in the future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
bahlulh commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571313160 > @bahlulh there appear to be three commits at the start of this which are not part of the PR - just FYI for future. I merged nifi/master to my branch. Next time I will do it in the correct way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6942) Add a reporting task to push provenance data to azure log analytics.
[ https://issues.apache.org/jira/browse/NIFI-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-6942. Resolution: Fixed +1 merged to master > Add a reporting task to push provenance data to azure log analytics. > > > Key: NIFI-6942 > URL: https://issues.apache.org/jira/browse/NIFI-6942 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Bahlul Haider >Assignee: Bahlul Haider >Priority: Major > Fix For: 1.11.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6942) Add a reporting task to push provenance data to azure log analytics.
[ https://issues.apache.org/jira/browse/NIFI-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009166#comment-17009166 ] ASF subversion and git services commented on NIFI-6942: --- Commit 65ca8e6c8defbc82bbac8c510cf16621a34418e9 in nifi's branch refs/heads/master from Ubuntu [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=65ca8e6 ] NIFI-6942 This closes #3934. Added a reporting task to push provenance data to azure log analytics. Signed-off-by: Joe Witt > Add a reporting task to push provenance data to azure log analytics. > > > Key: NIFI-6942 > URL: https://issues.apache.org/jira/browse/NIFI-6942 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Bahlul Haider >Assignee: Bahlul Haider >Priority: Major > Fix For: 1.11.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-6973) QueryRecord row_number Function Never Returns on Larger Files
[ https://issues.apache.org/jira/browse/NIFI-6973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Weeks resolved NIFI-6973. --- Resolution: Won't Fix Issues is caused by Calcite doing the calculation in memory. Since there isn't really a work around to that there isn't anything NiFi can do. > QueryRecord row_number Function Never Returns on Larger Files > - > > Key: NIFI-6973 > URL: https://issues.apache.org/jira/browse/NIFI-6973 > Project: Apache NiFi > Issue Type: Bug >Reporter: Shawn Weeks >Priority: Minor > Attachments: Query_Record_Bug.xml > > > In the attached example I am attempting to use the row_number() over() > function in calcite to generate a row id. It works fine for smaller files but > uses all the ram and cpu allocated to NiFi with larger files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
asfgit closed pull request #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571309415 confirmed the java 11 build for travis actually worked. so this change appears good to go. Did not test on azure services. But did eyeball to ensure old properties are still there/supported still post refactor. Looks good. Assuming my local build finishes well +1 merging to master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571304047 @bahlulh the email on your author line for git is quite lengthy. It is better this is something more clearly tied to you from a provenance point of view. More important though is your commit message needs to indicate teh JIRA involved. For instance the commit message should start with 'NIFI-6942 ...' I'll fix this in the commit message that gets merged. But please correct for future contribs. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics.
joewitt commented on issue #3934: NIFI-6942: Add a reporting task to push provenance data to azure log analytics. URL: https://github.com/apache/nifi/pull/3934#issuecomment-571302912 @bahlulh there appear to be three commits at the start of this which are not part of the PR - just FYI for future. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6822) When RunDuration > 0 ms, some statistics are not tracked correctly.
[ https://issues.apache.org/jira/browse/NIFI-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009138#comment-17009138 ] ASF subversion and git services commented on NIFI-6822: --- Commit c958deb5b01bf26c856b5d6a2b93cee87163c10f in nifi's branch refs/heads/master from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=c958deb ] NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we properly merge those maps during a checkpoint instead of overwriting existing values > When RunDuration > 0 ms, some statistics are not tracked correctly. > --- > > Key: NIFI-6822 > URL: https://issues.apache.org/jira/browse/NIFI-6822 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > When using a Run Duration of more than 0 ms, the counts for the number of > FlowFiles & bytes in/out for connections is not tracked properly. > Additionally, the counter values that are presented are too low. This is due > to the counts that are maintained by the Process Session not being properly > updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] markap14 merged pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
markap14 merged pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p… URL: https://github.com/apache/nifi/pull/3853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6822) When RunDuration > 0 ms, some statistics are not tracked correctly.
[ https://issues.apache.org/jira/browse/NIFI-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6822: - Resolution: Fixed Status: Resolved (was: Patch Available) > When RunDuration > 0 ms, some statistics are not tracked correctly. > --- > > Key: NIFI-6822 > URL: https://issues.apache.org/jira/browse/NIFI-6822 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > When using a Run Duration of more than 0 ms, the counts for the number of > FlowFiles & bytes in/out for connections is not tracked properly. > Additionally, the counter values that are presented are too low. This is due > to the counts that are maintained by the Process Session not being properly > updated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6882) PutFile throws NullPointerException if destination directory doesn't exist
[
https://issues.apache.org/jira/browse/NIFI-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009120#comment-17009120
]
Matt Burgess commented on NIFI-6882:
[~JoshE] Are you working this one? There's a release coming up soon, would be
nice to get this one in there :) If you're not actively working it, I can take
a stab at it.
> PutFile throws NullPointerException if destination directory doesn't exist
> --
>
> Key: NIFI-6882
> URL: https://issues.apache.org/jira/browse/NIFI-6882
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Mark Payne
>Assignee: Josh P
>Priority: Critical
>
> I have a PutFile processor that is configured to create directories if they
> don't exist. I have the directory set to "heap-dumps", which does not exist.
> When data came into the processor, it started throwing the following NPE:
> {code}
> 2019-11-18 16:46:14,879 ERROR [Timer-Driven Process Thread-2]
> o.a.nifi.processors.standard.PutFile
> PutFile[id=0b173f77-d60a-1ce8-d59e-4a9aeff49dbf] Penalizing
> StandardFlowFileRecord[uuid=38a6849b-965b-46b2-96d3-fe37a1c22cf8,claim=StandardContentClaim
> [resourceClaim=StandardResourceClaim[id=1574113470589-2, container=default,
> section=2], offset=0,
> length=1139822320],offset=0,name=heap.bin.gz,size=1139822320] and
> transferring to failure due to java.lang.NullPointerException:
> java.lang.NullPointerException
> java.lang.NullPointerException: null
> at java.nio.file.Files.provider(Files.java:97)
> at java.nio.file.Files.exists(Files.java:2385)
> at
> org.apache.nifi.processors.standard.PutFile.onTrigger(PutFile.java:243)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] pvillard31 commented on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character
pvillard31 commented on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character URL: https://github.com/apache/nifi/pull/3958#issuecomment-571280631 Didn't notice the impact on the poi processors. Will try to have a closer look when I get the chance. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord
mattyb149 commented on a change in pull request #3953: NIFI-5901 Added
JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r363445914
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@ -1042,7 +1072,22 @@ private static String normalizeColumnName(final String
colName, final boolean tr
return colName == null ? null : (translateColumnNames ?
colName.toUpperCase().replace("_", "") : colName);
}
+private static final ObjectMapper MAPPER = new ObjectMapper();
+
+private static String convertMapRecord(Record record) {
Review comment:
If we use a set of options for what to convert the record to (see my other
comment), this method should be named accordingly for converting to a JSON
string, as we would need other similar methods for other representations such
as XML.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord
mattyb149 commented on a change in pull request #3953: NIFI-5901 Added
JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r363446188
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/pattern/Put.java
##
@@ -89,7 +89,7 @@ public void onTrigger(ProcessContext context, ProcessSession
session, FC functio
session.transfer(routedFlowFiles, relationship)));
if (flowFiles == null || flowFiles.isEmpty()) {
-logger.debug("No incoming FlowFiles.");
+//logger.debug("No incoming FlowFiles.");
Review comment:
This should probably be restored as it appears to be useful for debugging
live flows
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3953: NIFI-5901 Added JSON/JSONB support to PutDatabaseRecord
mattyb149 commented on a change in pull request #3953: NIFI-5901 Added
JSON/JSONB support to PutDatabaseRecord
URL: https://github.com/apache/nifi/pull/3953#discussion_r363445186
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##
@@ -252,6 +258,16 @@
.defaultValue("false")
.build();
+static final PropertyDescriptor MAP_RECORD_TO_JSON = new
PropertyDescriptor.Builder()
+.name("put-db-record-map-record-to-json")
+.displayName("Map \"record\" types to JSON")
Review comment:
What if we made this a dropdown with allowable values vs booleans? It
appears that setting the JDBC type to `OTHER` supports both JSON and JSONB (at
least for PostgreSQL), but in the future we may want to support the SQLXML type
for inserting into XML columns and so on. The description of the `JSON` option
should probably explicitly say that the JDBC type is set to `OTHER`, as that
might be helpful information for other databases that do things differently.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3945: NIFI-6960: Add Provenance Table to MetricsSqlQueryService
mattyb149 commented on a change in pull request #3945: NIFI-6960: Add
Provenance Table to MetricsSqlQueryService
URL: https://github.com/apache/nifi/pull/3945#discussion_r363439180
##
File path:
nifi-nar-bundles/nifi-sql-reporting-bundle/nifi-sql-reporting-tasks/src/main/java/org/apache/nifi/reporting/sql/QueryNiFiReportingTask.java
##
@@ -38,9 +38,9 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
-@Tags({"status", "connection", "processor", "jvm", "metrics", "history",
"bulletin", "prediction", "process", "group", "record", "sql"})
+@Tags({"status", "connection", "processor", "jvm", "metrics", "history",
"bulletin", "prediction", "process", "group", "provenance", "record", "sql"})
@CapabilityDescription("Publishes NiFi status information based on the results
of a user-specified SQL query. The query may make use of the CONNECTION_STATUS,
PROCESSOR_STATUS, "
-+ "BULLETINS, PROCESS_GROUP_STATUS, JVM_METRICS, or
CONNECTION_STATUS_PREDICTIONS tables, and can use any functions or capabilities
provided by Apache Calcite. Note that the "
++ "BULLETINS, PROCESS_GROUP_STATUS, JVM_METRICS,
CONNECTION_STATUS_PREDICTIONS, or PROVENANCE tables, and can use any functions
or capabilities provided by Apache Calcite. Note that the "
Review comment:
Will do thanks! Also those SiteToSiteReportingRecordSink errors are directly
related to #3898 as you thought, those changes should get in shortly and not
otherwise affect this PR
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] shawnweeks edited a comment on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character
shawnweeks edited a comment on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character URL: https://github.com/apache/nifi/pull/3958#issuecomment-571268282 It looks like the CSV Commons library doesn't support no escapes and no quotes. That's a bummer. Maybe just removing required option but leaving the default and using the Jackson CSV parser would work? That way we don't break the test cases. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] shawnweeks commented on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character
shawnweeks commented on issue #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character URL: https://github.com/apache/nifi/pull/3958#issuecomment-571268282 It looks like the CSV Commons library doesn't support no escapes and no quotes. That's a bummer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6942) Add a reporting task to push provenance data to azure log analytics.
[ https://issues.apache.org/jira/browse/NIFI-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009099#comment-17009099 ] Joe Witt commented on NIFI-6942: flagging as a 1.11 candidate which i'll try to sweep in as I do the RM rounds > Add a reporting task to push provenance data to azure log analytics. > > > Key: NIFI-6942 > URL: https://issues.apache.org/jira/browse/NIFI-6942 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Bahlul Haider >Assignee: Bahlul Haider >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6942) Add a reporting task to push provenance data to azure log analytics.
[ https://issues.apache.org/jira/browse/NIFI-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6942: --- Fix Version/s: 1.11.0 > Add a reporting task to push provenance data to azure log analytics. > > > Key: NIFI-6942 > URL: https://issues.apache.org/jira/browse/NIFI-6942 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Bahlul Haider >Assignee: Bahlul Haider >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6926) Memory leak in NiFiAtlasHook
[ https://issues.apache.org/jira/browse/NIFI-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-6926: -- Fix Version/s: 1.11.0 > Memory leak in NiFiAtlasHook > > > Key: NIFI-6926 > URL: https://issues.apache.org/jira/browse/NIFI-6926 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Peter Turcsanyi >Assignee: Peter Turcsanyi >Priority: Major > Fix For: 1.11.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > NiFiAtlasHook collects the notification messages to be sent to Atlas in a > list, but it does not clean up the list after committing the messages. So it > is just growing and the same notifications are being sent to Atlas again and > again. This will lead to communication slow-down, OOM and/or exceeding Kafka > message size limit. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (NIFI-6978) Log which encrypted configuration value is improperly formatted
[
https://issues.apache.org/jira/browse/NIFI-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
M Tien reassigned NIFI-6978:
Assignee: M Tien (was: Andy LoPresto)
> Log which encrypted configuration value is improperly formatted
> ---
>
> Key: NIFI-6978
> URL: https://issues.apache.org/jira/browse/NIFI-6978
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Affects Versions: 1.10.0
>Reporter: Andy LoPresto
>Assignee: M Tien
>Priority: Minor
>
> As reported on the mailing list, a user has improperly formatted encrypted
> configuration value in {{nifi.properties}} or another configuration file. The
> error message in {{nifi-app.log}} is:
> {code}
> 2019-12-31 05:42:26,515 INFO [main] o.a.n.properties.ProtectedNiFiProperties
> There are 5 protected properties of 5 sensitive properties (100%)
> 2019-12-31 05:42:26,517 ERROR [main] org.apache.nifi.NiFi Failure to launch
> NiFi due to java.lang.IllegalArgumentException: There was an issue decrypting
> protected properties
> java.lang.IllegalArgumentException: There was an issue decrypting protected
> properties
> at org.apache.nifi.NiFi.initializeProperties(NiFi.java:341)
> at
> org.apache.nifi.NiFi.convertArgumentsToValidatedNiFiProperties(NiFi.java:309)
> at org.apache.nifi.NiFi.main(NiFi.java:300)
> Caused by: java.lang.IllegalArgumentException: The cipher text does not
> contain the delimiter || -- it should be of the form Base64(IV) ||
> Base64(cipherText)
> at
> org.apache.nifi.properties.AESSensitivePropertyProvider.unprotect(AESSensitivePropertyProvider.java:217)
> at
> org.apache.nifi.properties.ProtectedNiFiProperties.unprotectValue(ProtectedNiFiProperties.java:524)
> at
> org.apache.nifi.properties.ProtectedNiFiProperties.getUnprotectedProperties(ProtectedNiFiProperties.java:343)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.load(NiFiPropertiesLoader.java:209)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.load(NiFiPropertiesLoader.java:223)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.loadDefault(NiFiPropertiesLoader.java:130)
> at
> org.apache.nifi.properties.NiFiPropertiesLoader.get(NiFiPropertiesLoader.java:241)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.nifi.NiFi.initializeProperties(NiFi.java:336)
> ... 2 common frames omitted
> Received trapped signal, beginning shutdown...
> {code}
> The relevant code in {{ProtectedNiFiProperties.java}} is:
> {code}
> try {
> SensitivePropertyProvider sensitivePropertyProvider =
> getSensitivePropertyProvider(protectionScheme);
> return sensitivePropertyProvider.unprotect(retrievedValue);
> } catch (SensitivePropertyProtectionException e) {
> throw new SensitivePropertyProtectionException("Error
> unprotecting value for " + key, e.getCause());
> }
> {code}
> Currently, the {{IllegalArgumentException}} is not caught here, so the
> specific improperly-formatted value is not identified in the log. Manual
> inspection of the file is required.
> The {{IAE}} should be caught in the same block and treated identically.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6886) Unable to refresh Remote Group's peers due to null
[ https://issues.apache.org/jira/browse/NIFI-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009077#comment-17009077 ] Matt Burgess commented on NIFI-6886: There still need to be some changes made, I commented on the PR and added a commit to my own branch (based off the PR): https://github.com/mattyb149/nifi/commits/NIFI-6886 > Unable to refresh Remote Group's peers due to null > -- > > Key: NIFI-6886 > URL: https://issues.apache.org/jira/browse/NIFI-6886 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions > Environment: Linux CentOS 7 x64 >Reporter: Eduardo Mota Fontes >Priority: Major > Fix For: 1.11.0 > > Time Spent: 2h > Remaining Estimate: 0h > > If you create SiteToSiteBulletinReportingTask pointing to cluster itself to > an arbitrary input port it generates Bulletin in every execution: > WARNING > *SiteToSiteBulletinReportingTask[id=843df3f5-016e-1000-15f0-c32647b2a675] > org.apache.nifi.remote.client.PeerSelector@48a5201e Unable to refresh Remote > Group's peers due to null* > This log appears in nifi-app.log too. > Try to debug this error, I figure out that has a new PeerSelector > implementation in version 1.10.0 and the error occurs when it tries to save > the Peers State. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 commented on a change in pull request #3898: NIFI-6886 - Bugfix site-to-site-reporting-task
mattyb149 commented on a change in pull request #3898: NIFI-6886 - Bugfix
site-to-site-reporting-task
URL: https://github.com/apache/nifi/pull/3898#discussion_r363402405
##
File path:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java
##
@@ -118,9 +116,10 @@
return properties;
}
-@OnScheduled
-public void setup(final ConfigurationContext context) throws IOException {
-siteToSiteClient = SiteToSiteUtils.getClient(context, getLogger());
+public void setup(final ReportingContext reportContext) throws IOException
{
+if (siteToSiteClient != null) {
Review comment:
I believe this is a negative-logic error, as the real `siteToSiteClient`
never gets set. If I run this with a `SiteToSiteProvenanceReportingTask`, then
as soon as a provenance event is generated and the reporting task runs, it
fails with a NullPointerException.
The unit tests did not catch it because the
`MockSiteToSiteProvenanceReportingTask.getClient()` method does not use this
one. For consistency of behavior, I'm thinking with the new `setup()` method in
`AbstractSiteToSiteReportingTask` (as well as the `getClient()` method for
testing, `MockSiteToSiteProvenanceReportingTask` should not override
`getClient()` but instead override `setup()` and create the mock there. That
still won't catch the above logic error, but that will be hard to do with a
unit test anyway as that method is trying to create a real client. We could
include the same logic in the mocked `setup()` method though, to check if the
client is null and create it if it is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3898: NIFI-6886 - Bugfix site-to-site-reporting-task
mattyb149 commented on a change in pull request #3898: NIFI-6886 - Bugfix
site-to-site-reporting-task
URL: https://github.com/apache/nifi/pull/3898#discussion_r363410701
##
File path:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting/AbstractSiteToSiteReportingTask.java
##
@@ -118,9 +116,10 @@
return properties;
}
-@OnScheduled
-public void setup(final ConfigurationContext context) throws IOException {
-siteToSiteClient = SiteToSiteUtils.getClient(context, getLogger());
+public void setup(final ReportingContext reportContext) throws IOException
{
+if (siteToSiteClient != null) {
Review comment:
This means when the client is closed in `shutdown()`, `siteToSiteClient`
should be reset to `null`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] phrocker commented on a change in pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
phrocker commented on a change in pull request #3853: NIFI-6822: Ensure that
when we manage a Map of ID -> Count, that we p…
URL: https://github.com/apache/nifi/pull/3853#discussion_r363415464
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
##
@@ -561,9 +563,8 @@ private void updateEventRepository(final Checkpoint
checkpoint) {
return first;
}
-final Map combined = new HashMap<>();
-combined.putAll(first);
-combined.putAll(second);
+final Map combined = new HashMap<>(first);
+second.forEach((key, value) -> combined.merge(key, value, (v1, v2) ->
v1 + v2));
Review comment:
In retrospect after a nice refreshing break I'm not sure how I arrived at
such a question.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] phrocker commented on a change in pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
phrocker commented on a change in pull request #3853: NIFI-6822: Ensure that
when we manage a Map of ID -> Count, that we p…
URL: https://github.com/apache/nifi/pull/3853#discussion_r363415464
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
##
@@ -561,9 +563,8 @@ private void updateEventRepository(final Checkpoint
checkpoint) {
return first;
}
-final Map combined = new HashMap<>();
-combined.putAll(first);
-combined.putAll(second);
+final Map combined = new HashMap<>(first);
+second.forEach((key, value) -> combined.merge(key, value, (v1, v2) ->
v1 + v2));
Review comment:
In retrospect after a nice refreshing break I'm not sure how I arrived that
such a question.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] markap14 commented on issue #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
markap14 commented on issue #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p… URL: https://github.com/apache/nifi/pull/3853#issuecomment-571246045 Rebased against master. Thanks for reviewing & approving @phrocker This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] markap14 commented on a change in pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
markap14 commented on a change in pull request #3853: NIFI-6822: Ensure that
when we manage a Map of ID -> Count, that we p…
URL: https://github.com/apache/nifi/pull/3853#discussion_r363412199
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
##
@@ -561,9 +563,8 @@ private void updateEventRepository(final Checkpoint
checkpoint) {
return first;
}
-final Map combined = new HashMap<>();
-combined.putAll(first);
-combined.putAll(second);
+final Map combined = new HashMap<>(first);
+second.forEach((key, value) -> combined.merge(key, value, (v1, v2) ->
v1 + v2));
Review comment:
I don't believe so. `putIfAbsent` would say "If not there, add it. If there,
leave the destination it alone." `merge` says "If not there, add it. If there,
combine the value from both maps." So the result is different if both maps have
the key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] markap14 commented on a change in pull request #3853: NIFI-6822: Ensure that when we manage a Map of ID -> Count, that we p…
markap14 commented on a change in pull request #3853: NIFI-6822: Ensure that
when we manage a Map of ID -> Count, that we p…
URL: https://github.com/apache/nifi/pull/3853#discussion_r363411815
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
##
@@ -3406,6 +3396,41 @@ private void checkpoint(final StandardProcessSession
session, final List void mergeMaps(final Map destination, final
Map toMerge, final BiFunction merger) {
+if (toMerge == null) {
Review comment:
not sure that null check against destination makes sense in the way this is
being used. If `toMerge` is null, we can simply do nothing, because there is
nothing to merge. But if the destination is null, we should not return without
merging the values that are expected to be merged. It makes more sense IMO to
throw a NPE in such a case. Is also worth noting that currently, all objects
that could be passed in for `destination` are guaranteed non-null and if that
were to change, the existing unit tests would fail.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6984) Flow files are struck on Load Balancing with Partition with AttributeID
[ https://issues.apache.org/jira/browse/NIFI-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] venugopal updated NIFI-6984: Attachment: Capture1.PNG > Flow files are struck on Load Balancing with Partition with AttributeID > --- > > Key: NIFI-6984 > URL: https://issues.apache.org/jira/browse/NIFI-6984 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.10.0 > Environment: Nifi 1.10 with Docker Image in Kubernetes (3 Node > cluster) >Reporter: venugopal >Priority: Major > Attachments: Capture1.PNG > > > Flow files are struck on Load Balancing with Partition with AttributeID > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] bakaid commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE
bakaid commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#issuecomment-571235830 @apiri @arpadboda thanks for the reviews, addressed the review comments in a new commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6984) Flow files are struck on Load Balancing with Partition with AttributeID
[ https://issues.apache.org/jira/browse/NIFI-6984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] venugopal updated NIFI-6984: Environment: Nifi 1.10 with Docker Image in Kubernetes (3 Node cluster) (was: Nifi 1.10 with Docker Image in Kubernetes) > Flow files are struck on Load Balancing with Partition with AttributeID > --- > > Key: NIFI-6984 > URL: https://issues.apache.org/jira/browse/NIFI-6984 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.10.0 > Environment: Nifi 1.10 with Docker Image in Kubernetes (3 Node > cluster) >Reporter: venugopal >Priority: Major > > Flow files are struck on Load Balancing with Partition with AttributeID > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6966) CSVReader Should Support Null Quote and Escape Character
[ https://issues.apache.org/jira/browse/NIFI-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009045#comment-17009045 ] Pierre Villard commented on NIFI-6966: -- Sorry Shawn, got distracted by few things and forgot to push the PR... I agree with you, it should not break anything. > CSVReader Should Support Null Quote and Escape Character > > > Key: NIFI-6966 > URL: https://issues.apache.org/jira/browse/NIFI-6966 > Project: Apache NiFi > Issue Type: Bug >Reporter: Shawn Weeks >Assignee: Pierre Villard >Priority: Minor > Attachments: Bug_Template.xml > > Time Spent: 10m > Remaining Estimate: 0h > > The CSVReader doesn't currently provide a way to set null for the quote and > escape characters. This is needed if your processing data with a single > delimiter like a tab but the data may contain quotes and slashes and such. > While you can set the quote and delimiter to another character this isn't > always practical. It looks like the Jackson CSV reader is already written to > except nulls for those characters and correctly disable quotes but the actual > service doesn't allow it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363398867 ## File path: LICENSE ## @@ -1793,3 +1620,1012 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +This product bundles 'libcoap' which is available under a 2-clause BSD license: + +Copyright (c) 2010--2019, Olaf Bergmann and others +All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + o Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + + o Redistributions in binary form must reproduce the above copyright +notice, this list of conditions and the following disclaimer in +the documentation and/or other materials provided with the +distribution. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + +getopt.c + +License information for getopt.c. This file is only used on Windows +builds of the executables in the examples folder: + +/* + * This file was copied from the following newsgroup posting: + * + * Newsgroups: mod.std.unix + * Subject: public domain AT getopt source + * Date: 3 Nov 85 19:34:15 GMT + * + * Here's something you've all been waiting for: the AT public domain + * source for getopt(3). It is the code which was given out at the 1985 + * UNIFORUM conference in Dallas. I obtained it by electronic mail + * directly from AT The people there assure me that it is indeed + * in the public domain. + */ + + +OpenSSL + +Binaries that are linked against OpenSSL include software developed +by the OpenSSL Project for use in the OpenSSL Toolkit. +(http://www.openssl.org/). Please consult the OpenSSL license +(https://www.openssl.org/source/license.html) for licensing terms. + + +GnuTLS + +When compiled with GnuTLS support, this software includes components +that are licensed under the terms of the the GNU Lesser General Public +License, version 2.1 +(https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html). + + +tinyDTLS + +When compiled with tinyDTLS support, this software includes components +that are licensed under the terms of the Eclipse Distribution License 1.0 +(http://www.eclipse.org/org/documents/edl-v10.php). + +This project bundles 'open62541' which is available under an MPLv2.0 license, Review comment: Yep, it is a binary-only inclusion, will update the language to reflect this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6849) On startup, NiFi should be more liberal about what it's willing to inherit from cluster
[ https://issues.apache.org/jira/browse/NIFI-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009038#comment-17009038 ] Joe Witt commented on NIFI-6849: This does not have a reviewer and is a big change. But the benefit to typical/desired usage patterns is huge. I'm pulling this into 1.11 for now and will hunt down a reviewer. > On startup, NiFi should be more liberal about what it's willing to inherit > from cluster > --- > > Key: NIFI-6849 > URL: https://issues.apache.org/jira/browse/NIFI-6849 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > On startup, if an instance is configured to be clustered, the instance must > connect to the Cluster Coordinator and download the existing cluster flow, > access policies, and users and groups. The instance then performs some checks > to ensure that the local flow matches the cluster's flow. If it doesn't, then > the node fails to startup and logs errors that the local flow is different > than the cluster's flow. > This was done in order to facilitate debugging. If a particular node is not > behaving as expected, a user is able to disconnect the node from the cluster > and make modifications to the node. If the node is then restarted, it may not > be desirable to lose those changes. > However, in the vast majority of cases (probably over 98% of the time), what > the user really wants is for the node to just join back to the cluster and > inherit the cluster's flow - especially if the node just disconnected because > it failed to make a modification. This is also problematic with how the > Users, Groups, and Policies are inherited. > As a result, we should make the following modifications: > 1) If Users, Groups, or Access Policies cannot be inherited, continue to > fail, unless the flow is empty. If the flow is empty, it doesn't really make > sense to retain the authorizations' configuration because they don't really > apply to anything. As a result, if the flow is empty, just inherit whatever > the cluster has. But first, make a backup of the existing policies, users, > and groups, so that users can manually revert if they do end up needing to. > 2) If the flow differs from the cluster flow, check the proposed flow to see > if it removes any existing connections. If it does remove a connection, and > that connection has data queued locally, continue to fail. Otherwise, create > a backup of the flow and replace the node's flow with the cluster flow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
bakaid commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363398426 ## File path: LICENSE ## @@ -203,6 +203,12 @@ APACHE NIFI - MINIFI SUBCOMPONENTS: +The Apache NiFi - MiNiFi project contains subcomponents licensed under the Apache License, Version 2.0: Review comment: Agreed, will update all instances. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6849) On startup, NiFi should be more liberal about what it's willing to inherit from cluster
[ https://issues.apache.org/jira/browse/NIFI-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6849: --- Fix Version/s: 1.11.0 > On startup, NiFi should be more liberal about what it's willing to inherit > from cluster > --- > > Key: NIFI-6849 > URL: https://issues.apache.org/jira/browse/NIFI-6849 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > On startup, if an instance is configured to be clustered, the instance must > connect to the Cluster Coordinator and download the existing cluster flow, > access policies, and users and groups. The instance then performs some checks > to ensure that the local flow matches the cluster's flow. If it doesn't, then > the node fails to startup and logs errors that the local flow is different > than the cluster's flow. > This was done in order to facilitate debugging. If a particular node is not > behaving as expected, a user is able to disconnect the node from the cluster > and make modifications to the node. If the node is then restarted, it may not > be desirable to lose those changes. > However, in the vast majority of cases (probably over 98% of the time), what > the user really wants is for the node to just join back to the cluster and > inherit the cluster's flow - especially if the node just disconnected because > it failed to make a modification. This is also problematic with how the > Users, Groups, and Policies are inherited. > As a result, we should make the following modifications: > 1) If Users, Groups, or Access Policies cannot be inherited, continue to > fail, unless the flow is empty. If the flow is empty, it doesn't really make > sense to retain the authorizations' configuration because they don't really > apply to anything. As a result, if the flow is empty, just inherit whatever > the cluster has. But first, make a backup of the existing policies, users, > and groups, so that users can manually revert if they do end up needing to. > 2) If the flow differs from the cluster flow, check the proposed flow to see > if it removes any existing connections. If it does remove a connection, and > that connection has data queued locally, continue to fail. Otherwise, create > a backup of the flow and replace the node's flow with the cluster flow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] pvillard31 opened a new pull request #3958: NIFI-6966 - CSVReader Should Support Null Quote and Escape Character
pvillard31 opened a new pull request #3958: NIFI-6966 - CSVReader Should
Support Null Quote and Escape Character
URL: https://github.com/apache/nifi/pull/3958
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6498) XMLTransform processor: XSLT doesn't give detail error message with line number
[ https://issues.apache.org/jira/browse/NIFI-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6498: --- Fix Version/s: (was: 1.11.0) > XMLTransform processor: XSLT doesn't give detail error message with line > number > --- > > Key: NIFI-6498 > URL: https://issues.apache.org/jira/browse/NIFI-6498 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.10.0, 1.9.2 >Reporter: Raymond >Priority: Major > Attachments: > 0001-Add-support-for-Saxon-error-messages-and-functions.patch, > 0001-Add-support-for-Saxon-error-messages-and-functions.patch > > > When something is wrong with the XSLT in the XMLTransform processor you get > an error, but this is only a general error without any details or the line > number where the parsing error occurs. For example when using Saxon from > example I get the following error: > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element > type "xsl:tomplate" must be terminated by the matching end-tag > "". > When using NiFi the following error is printed: > 11:07:43 CEST > ERROR > 2b4c1dab-3a87-175f-f817-3f3c72af4102 > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102] Unable to transform > StandardFlowFileRecord[uuid=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,claim=StandardContentClaim > [resourceClaim=StandardResourceClaim[id=1564391260760-1, container=default, > section=1], offset=0, > length=6380],offset=0,name=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,size=6380] > due to IOException thrown from > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: java.io.IOException: > java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported: org.apache.nifi.processor.exception.ProcessException: IOException > thrown from TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: > java.io.IOException: java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported > The error in NiFi gives almost no information for debugging. Would be a big > improvement if the Saxon error message is catched and add to the NiFi error > message (bulletin board). > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6498) XMLTransform processor: XSLT doesn't give detail error message with line number
[ https://issues.apache.org/jira/browse/NIFI-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009030#comment-17009030 ] Joe Witt commented on NIFI-6498: just needs review traction and once we have that we can set a fix version. Patches offered this way are tougher than PRs through github as it requires higher reviewer effort. > XMLTransform processor: XSLT doesn't give detail error message with line > number > --- > > Key: NIFI-6498 > URL: https://issues.apache.org/jira/browse/NIFI-6498 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.10.0, 1.9.2 >Reporter: Raymond >Priority: Major > Fix For: 1.11.0 > > Attachments: > 0001-Add-support-for-Saxon-error-messages-and-functions.patch, > 0001-Add-support-for-Saxon-error-messages-and-functions.patch > > > When something is wrong with the XSLT in the XMLTransform processor you get > an error, but this is only a general error without any details or the line > number where the parsing error occurs. For example when using Saxon from > example I get the following error: > Error on line 17 column 5 SXXP0003: Error reported by XML parser: The element > type "xsl:tomplate" must be terminated by the matching end-tag > "". > When using NiFi the following error is printed: > 11:07:43 CEST > ERROR > 2b4c1dab-3a87-175f-f817-3f3c72af4102 > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102] Unable to transform > StandardFlowFileRecord[uuid=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,claim=StandardContentClaim > [resourceClaim=StandardResourceClaim[id=1564391260760-1, container=default, > section=1], offset=0, > length=6380],offset=0,name=c4dde8e5-89b0-4f29-8f2d-a97a009cf843,size=6380] > due to IOException thrown from > TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: java.io.IOException: > java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported: org.apache.nifi.processor.exception.ProcessException: IOException > thrown from TransformXml[id=2b4c1dab-3a87-175f-f817-3f3c72af4102]: > java.io.IOException: java.util.concurrent.ExecutionException: > javax.xml.transform.TransformerConfigurationException: > net.sf.saxon.s9api.SaxonApiException: Stylesheet compilation failed: 1 error > reported > The error in NiFi gives almost no information for debugging. Would be a big > improvement if the Saxon error message is catched and add to the NiFi error > message (bulletin board). > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363389173 ## File path: LICENSE ## @@ -203,6 +203,12 @@ APACHE NIFI - MINIFI SUBCOMPONENTS: +The Apache NiFi - MiNiFi project contains subcomponents licensed under the Apache License, Version 2.0: Review comment: yeah, that seems fair. it was originally done as such from the standpoint that it was under a common effort/subproject but for licensing clarity, clearly differentiating will be helpful This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE
apiri commented on a change in pull request #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#discussion_r363395242 ## File path: LICENSE ## @@ -1793,3 +1620,1012 @@ ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +This product bundles 'libcoap' which is available under a 2-clause BSD license: + +Copyright (c) 2010--2019, Olaf Bergmann and others +All rights reserved. + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions are +met: + + o Redistributions of source code must retain the above copyright +notice, this list of conditions and the following disclaimer. + + o Redistributions in binary form must reproduce the above copyright +notice, this list of conditions and the following disclaimer in +the documentation and/or other materials provided with the +distribution. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + + +getopt.c + +License information for getopt.c. This file is only used on Windows +builds of the executables in the examples folder: + +/* + * This file was copied from the following newsgroup posting: + * + * Newsgroups: mod.std.unix + * Subject: public domain AT getopt source + * Date: 3 Nov 85 19:34:15 GMT + * + * Here's something you've all been waiting for: the AT public domain + * source for getopt(3). It is the code which was given out at the 1985 + * UNIFORUM conference in Dallas. I obtained it by electronic mail + * directly from AT The people there assure me that it is indeed + * in the public domain. + */ + + +OpenSSL + +Binaries that are linked against OpenSSL include software developed +by the OpenSSL Project for use in the OpenSSL Toolkit. +(http://www.openssl.org/). Please consult the OpenSSL license +(https://www.openssl.org/source/license.html) for licensing terms. + + +GnuTLS + +When compiled with GnuTLS support, this software includes components +that are licensed under the terms of the the GNU Lesser General Public +License, version 2.1 +(https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html). + + +tinyDTLS + +When compiled with tinyDTLS support, this software includes components +that are licensed under the terms of the Eclipse Distribution License 1.0 +(http://www.eclipse.org/org/documents/edl-v10.php). + +This project bundles 'open62541' which is available under an MPLv2.0 license, Review comment: It is my understanding this is a binary inclusion. We should be explicit about that fact as it is a weak copyleft license and its use outside of that capacity would not be okay. I see the conditional nature of it is highlighted in the README, but we should be also update the language here. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6860) Upgrade NiFi 1.9.2 to 1.10.0 - Java11 LDAP (START_TLS) Issue
[
https://issues.apache.org/jira/browse/NIFI-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009028#comment-17009028
]
Joe Witt commented on NIFI-6860:
removing fix version for now. It might make sense to flag this in migration
guide or something as a known issue for start-tls on java 11 if indeed that is
the problem.
ONce there is a fix/pr/merge we can tag a fix version
> Upgrade NiFi 1.9.2 to 1.10.0 - Java11 LDAP (START_TLS) Issue
>
>
> Key: NIFI-6860
> URL: https://issues.apache.org/jira/browse/NIFI-6860
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.10.0
> Environment: NiFi Single Node with HTTPS/LDAP enabled; CentOS 7.x
>Reporter: Josef Zahner
>Assignee: Nathan Gough
>Priority: Blocker
> Labels: Java11, LDAP, Nifi, START-TLS
> Attachments: Screenshot 2019-11-11 at 11.14.52.png, authorizers.xml,
> login-identity-providers.xml
>
>
> We would like to upgrade from NiFi 1.9.2 to 1.10.0 and we have HTTPS with
> LDAP (START_TLS) authentication successfully enabled on 1.9.2. Now after
> upgrading, we have an issue which prevents nifi from startup:
> {code:java}
> 2019-11-11 08:29:30,447 ERROR [main] o.s.web.context.ContextLoader Context
> initialization failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration':
> Unsatisfied dependency expressed through method
> 'setFilterChainProxySecurityConfigurer' parameter 1; nested exception is
> org.springframework.beans.factory.BeanExpressionException: Expression parsing
> failed; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.apache.nifi.web.NiFiWebApiSecurityConfiguration': Unsatisfied dependency
> expressed through method 'setJwtAuthenticationProvider' parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'jwtAuthenticationProvider' defined in class path
> resource [nifi-web-security-context.xml]: Cannot resolve reference to bean
> 'authorizer' while setting constructor argument; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'authorizer': FactoryBean threw exception on object creation;
> nested exception is
> org.springframework.ldap.AuthenticationNotSupportedException: [LDAP: error
> code 13 - confidentiality required]; nested exception is
> javax.naming.AuthenticationNotSupportedException: [LDAP: error code 13 -
> confidentiality required]
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:666)
> at
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:366)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1269)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:551)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:481)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:312)
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:308)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
> at
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:867)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
> at
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
> at
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
> at
>
[jira] [Updated] (NIFI-6860) Upgrade NiFi 1.9.2 to 1.10.0 - Java11 LDAP (START_TLS) Issue
[
https://issues.apache.org/jira/browse/NIFI-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-6860:
---
Fix Version/s: (was: 1.11.0)
> Upgrade NiFi 1.9.2 to 1.10.0 - Java11 LDAP (START_TLS) Issue
>
>
> Key: NIFI-6860
> URL: https://issues.apache.org/jira/browse/NIFI-6860
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.10.0
> Environment: NiFi Single Node with HTTPS/LDAP enabled; CentOS 7.x
>Reporter: Josef Zahner
>Assignee: Nathan Gough
>Priority: Blocker
> Labels: Java11, LDAP, Nifi, START-TLS
> Attachments: Screenshot 2019-11-11 at 11.14.52.png, authorizers.xml,
> login-identity-providers.xml
>
>
> We would like to upgrade from NiFi 1.9.2 to 1.10.0 and we have HTTPS with
> LDAP (START_TLS) authentication successfully enabled on 1.9.2. Now after
> upgrading, we have an issue which prevents nifi from startup:
> {code:java}
> 2019-11-11 08:29:30,447 ERROR [main] o.s.web.context.ContextLoader Context
> initialization failed
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.springframework.security.config.annotation.web.configuration.WebSecurityConfiguration':
> Unsatisfied dependency expressed through method
> 'setFilterChainProxySecurityConfigurer' parameter 1; nested exception is
> org.springframework.beans.factory.BeanExpressionException: Expression parsing
> failed; nested exception is
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error
> creating bean with name
> 'org.apache.nifi.web.NiFiWebApiSecurityConfiguration': Unsatisfied dependency
> expressed through method 'setJwtAuthenticationProvider' parameter 0; nested
> exception is org.springframework.beans.factory.BeanCreationException: Error
> creating bean with name 'jwtAuthenticationProvider' defined in class path
> resource [nifi-web-security-context.xml]: Cannot resolve reference to bean
> 'authorizer' while setting constructor argument; nested exception is
> org.springframework.beans.factory.BeanCreationException: Error creating bean
> with name 'authorizer': FactoryBean threw exception on object creation;
> nested exception is
> org.springframework.ldap.AuthenticationNotSupportedException: [LDAP: error
> code 13 - confidentiality required]; nested exception is
> javax.naming.AuthenticationNotSupportedException: [LDAP: error code 13 -
> confidentiality required]
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredMethodElement.inject(AutowiredAnnotationBeanPostProcessor.java:666)
> at
> org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:87)
> at
> org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:366)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1269)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:551)
> at
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:481)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:312)
> at
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:308)
> at
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
> at
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
> at
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:867)
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:543)
> at
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
> at
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
> at
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107){code}
> In authorizers.xml we added the line “{{false}}”, but beside of that at least
> the authorizers.xml is the same. Anybody an idea what could cause the
[jira] [Created] (NIFI-6984) Flow files are struck on Load Balancing with Partition with AttributeID
venugopal created NIFI-6984: --- Summary: Flow files are struck on Load Balancing with Partition with AttributeID Key: NIFI-6984 URL: https://issues.apache.org/jira/browse/NIFI-6984 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.10.0 Environment: Nifi 1.10 with Docker Image in Kubernetes Reporter: venugopal Flow files are struck on Load Balancing with Partition with AttributeID -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6861) Add displayName to InfluxDB max connection timeout property
[ https://issues.apache.org/jira/browse/NIFI-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009024#comment-17009024 ] Joe Witt commented on NIFI-6861: once there is a PR and merge happening we can set a fix version. The current PR needs to be updated by review comments. > Add displayName to InfluxDB max connection timeout property > --- > > Key: NIFI-6861 > URL: https://issues.apache.org/jira/browse/NIFI-6861 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.10.0 >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Trivial > Labels: influxdb, property > Original Estimate: 0.5h > Time Spent: 0.5h > Remaining Estimate: 0h > > Added display name to property -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6861) Add displayName to InfluxDB max connection timeout property
[ https://issues.apache.org/jira/browse/NIFI-6861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6861: --- Fix Version/s: (was: 1.11.0) > Add displayName to InfluxDB max connection timeout property > --- > > Key: NIFI-6861 > URL: https://issues.apache.org/jira/browse/NIFI-6861 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.10.0 >Reporter: Mans Singh >Assignee: Mans Singh >Priority: Trivial > Labels: influxdb, property > Original Estimate: 0.5h > Time Spent: 0.5h > Remaining Estimate: 0h > > Added display name to property -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6970) Add DistributeRecord processor for distribute data by key hash
[
https://issues.apache.org/jira/browse/NIFI-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009022#comment-17009022
]
Joe Witt commented on NIFI-6970:
once there is a PR and merge happening we can set a fix version
> Add DistributeRecord processor for distribute data by key hash
> --
>
> Key: NIFI-6970
> URL: https://issues.apache.org/jira/browse/NIFI-6970
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Ilya Kovalev
>Priority: Minor
>
> Necessary to add processor for {color:#00875a}Record{color} distribution.
> Processor must have next fields :
> reader, writer, keys (list of {color:#00875a}Record{color} fields for
> hashing), hash function name.
> and an arbitrary number of dynamic properties representing relationships.
> Also relationships would have weights.
> if we have one key and this key is integer then hash function does not
> evaluate. If we have several keys then cast record values to String and join
> them with "-" delimiter
> like "34-NY-open".
> Hash function must return {color:#FF}int{color} value. Next processor
> find {color:#172b4d}+target relationship+ = {color}(hashResult %
> sum(weights)) and move record according integer range for relationships,
> so if we have 2 relationships with weights 4 and 7 appropriately then we have
> 2 intervals [0, 4) and [4, 11) for first and second relationship (order of
> relationships matters)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-6970) Add DistributeRecord processor for distribute data by key hash
[
https://issues.apache.org/jira/browse/NIFI-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-6970:
---
Fix Version/s: (was: 1.11.0)
> Add DistributeRecord processor for distribute data by key hash
> --
>
> Key: NIFI-6970
> URL: https://issues.apache.org/jira/browse/NIFI-6970
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
>Affects Versions: 1.10.0
>Reporter: Ilya Kovalev
>Priority: Minor
>
> Necessary to add processor for {color:#00875a}Record{color} distribution.
> Processor must have next fields :
> reader, writer, keys (list of {color:#00875a}Record{color} fields for
> hashing), hash function name.
> and an arbitrary number of dynamic properties representing relationships.
> Also relationships would have weights.
> if we have one key and this key is integer then hash function does not
> evaluate. If we have several keys then cast record values to String and join
> them with "-" delimiter
> like "34-NY-open".
> Hash function must return {color:#FF}int{color} value. Next processor
> find {color:#172b4d}+target relationship+ = {color}(hashResult %
> sum(weights)) and move record according integer range for relationships,
> so if we have 2 relationships with weights 4 and 7 appropriately then we have
> 2 intervals [0, 4) and [4, 11) for first and second relationship (order of
> relationships matters)
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-6982) It is not very clear how to use the NiFi API. Some details can be added.
[ https://issues.apache.org/jira/browse/NIFI-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009021#comment-17009021 ] Joe Witt commented on NIFI-6982: removed fix version. Not clear what the action will be from this JIRA and we dont tag things to release until there is a PR and merge has happened or is near - or something is a blocker. > It is not very clear how to use the NiFi API. Some details can be added. > > > Key: NIFI-6982 > URL: https://issues.apache.org/jira/browse/NIFI-6982 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Affects Versions: 1.10.0 >Reporter: Tushar Sarma >Priority: Minor > > Suppose we want to build an IOT solution and use MiNi/NiFi to create a flow > where source will be MQTT and destination is Kafka and we want to create the > flow programmatically using the NiFi REST API > > While the APIs are quite powerful, it is not very clear what APIs to be used > for various use case like Create a data flow using API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6886) Unable to refresh Remote Group's peers due to null
[ https://issues.apache.org/jira/browse/NIFI-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6886: --- Fix Version/s: 1.11.0 > Unable to refresh Remote Group's peers due to null > -- > > Key: NIFI-6886 > URL: https://issues.apache.org/jira/browse/NIFI-6886 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions > Environment: Linux CentOS 7 x64 >Reporter: Eduardo Mota Fontes >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > If you create SiteToSiteBulletinReportingTask pointing to cluster itself to > an arbitrary input port it generates Bulletin in every execution: > WARNING > *SiteToSiteBulletinReportingTask[id=843df3f5-016e-1000-15f0-c32647b2a675] > org.apache.nifi.remote.client.PeerSelector@48a5201e Unable to refresh Remote > Group's peers due to null* > This log appears in nifi-app.log too. > Try to debug this error, I figure out that has a new PeerSelector > implementation in version 1.10.0 and the error occurs when it tries to save > the Peers State. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-6982) It is not very clear how to use the NiFi API. Some details can be added.
[ https://issues.apache.org/jira/browse/NIFI-6982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-6982: --- Fix Version/s: (was: 1.11.0) > It is not very clear how to use the NiFi API. Some details can be added. > > > Key: NIFI-6982 > URL: https://issues.apache.org/jira/browse/NIFI-6982 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Affects Versions: 1.10.0 >Reporter: Tushar Sarma >Priority: Minor > > Suppose we want to build an IOT solution and use MiNi/NiFi to create a flow > where source will be MQTT and destination is Kafka and we want to create the > flow programmatically using the NiFi REST API > > While the APIs are quite powerful, it is not very clear what APIs to be used > for various use case like Create a data flow using API. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-6886) Unable to refresh Remote Group's peers due to null
[ https://issues.apache.org/jira/browse/NIFI-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009014#comment-17009014 ] Joe Witt commented on NIFI-6886: looks like this is ready just needs final push on review/merge. Looks good as a 1.11 candidate > Unable to refresh Remote Group's peers due to null > -- > > Key: NIFI-6886 > URL: https://issues.apache.org/jira/browse/NIFI-6886 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions > Environment: Linux CentOS 7 x64 >Reporter: Eduardo Mota Fontes >Priority: Major > Fix For: 1.11.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > If you create SiteToSiteBulletinReportingTask pointing to cluster itself to > an arbitrary input port it generates Bulletin in every execution: > WARNING > *SiteToSiteBulletinReportingTask[id=843df3f5-016e-1000-15f0-c32647b2a675] > org.apache.nifi.remote.client.PeerSelector@48a5201e Unable to refresh Remote > Group's peers due to null* > This log appears in nifi-app.log too. > Try to debug this error, I figure out that has a new PeerSelector > implementation in version 1.10.0 and the error occurs when it tries to save > the Peers State. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] apiri commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE
apiri commented on issue #702: MINIFICPP-1091 - Update LICENSE and NOTICE URL: https://github.com/apache/nifi-minifi-cpp/pull/702#issuecomment-571221571 reviewing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid commented on issue #705: MINIFICPP-1114 - Fix u16 build
bakaid commented on issue #705: MINIFICPP-1114 - Fix u16 build URL: https://github.com/apache/nifi-minifi-cpp/pull/705#issuecomment-571219795 @arpadboda still running a few tests, so don't merge yet, but this should solve the issue on host and in docker containers as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] bakaid opened a new pull request #705: MINIFICPP-1114 - Fix u16 build
bakaid opened a new pull request #705: MINIFICPP-1114 - Fix u16 build URL: https://github.com/apache/nifi-minifi-cpp/pull/705 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] ottobackwards commented on a change in pull request #3956: Added NTLM Authentication based on presence of NTLM Domain property
ottobackwards commented on a change in pull request #3956: Added NTLM
Authentication based on presence of NTLM Domain property
URL: https://github.com/apache/nifi/pull/3956#discussion_r363383565
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@ -113,9 +114,10 @@
import static org.apache.commons.lang3.StringUtils.trimToEmpty;
@SupportsBatching
-@Tags({"http", "https", "rest", "client"})
+@Tags({"http", "https", "rest", "client","ntlm"})
@InputRequirement(Requirement.INPUT_ALLOWED)
@CapabilityDescription("An HTTP client processor which can interact with a
configurable HTTP Endpoint. The destination URL and HTTP Method are
configurable."
++ " Also supports NTLM authentication to communicate with a sharepoint
webservice"
+ " FlowFile attributes are converted to HTTP headers and the FlowFile
contents are included as the body of the request (if the HTTP Method is PUT,
POST or PATCH).")
Review comment:
Unless NTLM _only_ works with sharepoint, there isn't a need to specify it
here. If you _do_ specify it, you might want to capitalize it correctly.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mattyb149 commented on a change in pull request #3943: NIFI-6947: Add PutRecord processor using RecordSinkService
mattyb149 commented on a change in pull request #3943: NIFI-6947: Add PutRecord
processor using RecordSinkService
URL: https://github.com/apache/nifi/pull/3943#discussion_r363378160
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-sink-api/src/main/java/org/apache/nifi/record/sink/RetryableIOException.java
##
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.record.sink;
+
+import java.io.IOException;
+
+/**
+ * This is a marker class for IOExceptions that may succeed if the operation
is performed again, it is a hint to retry the operation
+ */
+public class RetryableIOException extends IOException {
Review comment:
Yes, I thought maybe I (or someone else) can look back at existing impls as
well, to see if there are some retryable errors that can occur, and start
throwing this instead. Will add a unit test (and all constructors of
`IOException` to `RetryableIOException`)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6983) PublishKafka* Processors not properly handling exceptions when creating transactions
[ https://issues.apache.org/jira/browse/NIFI-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-6983: -- Resolution: Fixed Status: Resolved (was: Patch Available) > PublishKafka* Processors not properly handling exceptions when creating > transactions > > > Key: NIFI-6983 > URL: https://issues.apache.org/jira/browse/NIFI-6983 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 40m > Remaining Estimate: 0h > > When an Exception is thrown while publishing a message to Kafka, NiFi > properly poisons the client and creates a new one. However, if an Exception > is thrown while creating the transaction, the client does not get poisoned. > As a result, the client continues to be used and continues to fail until the > processor is restarted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] bbende closed pull request #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ…
bbende closed pull request #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ… URL: https://github.com/apache/nifi/pull/3957 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6983) PublishKafka* Processors not properly handling exceptions when creating transactions
[ https://issues.apache.org/jira/browse/NIFI-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008980#comment-17008980 ] ASF subversion and git services commented on NIFI-6983: --- Commit b03e5b0520230d90d112a1e7958fc17adbed3834 in nifi's branch refs/heads/master from Mark Payne [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b03e5b0 ] NIFI-6983: Ensure that if any call to kafka's Producer throws a ProducerFencedException that it's handled properly by poisoning the lease, which in turn will close the client This closes #6983. Signed-off-by: Bryan Bende > PublishKafka* Processors not properly handling exceptions when creating > transactions > > > Key: NIFI-6983 > URL: https://issues.apache.org/jira/browse/NIFI-6983 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When an Exception is thrown while publishing a message to Kafka, NiFi > properly poisons the client and creates a new one. However, if an Exception > is thrown while creating the transaction, the client does not get poisoned. > As a result, the client continues to be used and continues to fail until the > processor is restarted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] bbende commented on issue #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ…
bbende commented on issue #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ… URL: https://github.com/apache/nifi/pull/3957#issuecomment-571210093 Merged this to master, but used the wrong magic message, so manually closing. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on issue #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ…
bbende commented on issue #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ… URL: https://github.com/apache/nifi/pull/3957#issuecomment-571209256 Looks good, will merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6983) PublishKafka* Processors not properly handling exceptions when creating transactions
[ https://issues.apache.org/jira/browse/NIFI-6983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-6983: - Fix Version/s: 1.11.0 Status: Patch Available (was: Open) > PublishKafka* Processors not properly handling exceptions when creating > transactions > > > Key: NIFI-6983 > URL: https://issues.apache.org/jira/browse/NIFI-6983 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Mark Payne >Assignee: Mark Payne >Priority: Major > Fix For: 1.11.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When an Exception is thrown while publishing a message to Kafka, NiFi > properly poisons the client and creates a new one. However, if an Exception > is thrown while creating the transaction, the client does not get poisoned. > As a result, the client continues to be used and continues to fail until the > processor is restarted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] markap14 opened a new pull request #3957: NIFI-6983: Ensure that if any call to kafka's Producer throws a Produ…
markap14 opened a new pull request #3957: NIFI-6983: Ensure that if any call to
kafka's Producer throws a Produ…
URL: https://github.com/apache/nifi/pull/3957
…cerFencedException that it's handled properly by poisoning the lease, which
in turn will close the client
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on both JDK 8 and
JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Reopened] (MINIFICPP-1114) u16 docker build fails because old CMake version
[ https://issues.apache.org/jira/browse/MINIFICPP-1114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dániel Bakai reopened MINIFICPP-1114: - > u16 docker build fails because old CMake version > > > Key: MINIFICPP-1114 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1114 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Dániel Bakai >Assignee: Dániel Bakai >Priority: Blocker > Fix For: 0.7.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-6983) PublishKafka* Processors not properly handling exceptions when creating transactions
Mark Payne created NIFI-6983: Summary: PublishKafka* Processors not properly handling exceptions when creating transactions Key: NIFI-6983 URL: https://issues.apache.org/jira/browse/NIFI-6983 Project: Apache NiFi Issue Type: Bug Components: Extensions Reporter: Mark Payne Assignee: Mark Payne When an Exception is thrown while publishing a message to Kafka, NiFi properly poisons the client and creates a new one. However, if an Exception is thrown while creating the transaction, the client does not get poisoned. As a result, the client continues to be used and continues to fail until the processor is restarted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363331413 ## File path: nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/pom.xml ## @@ -57,6 +56,12 @@ nifi-distributed-cache-client-service-api provided + +org.apache.nifi +nifi-dbcp-service-api +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP
service changes
URL: https://github.com/apache/nifi/pull/3843#discussion_r363338486
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_2-client-service-bundle/nifi-hbase_2-client-service/src/main/java/org/apache/nifi/hbase/phoenix/PhoenixThickDBCPService.java
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.hbase.phoenix;
+
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.commons.dbcp.BasicDataSource;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.dbcp.DBCPService;
+import org.apache.nifi.expression.AttributeExpression;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.phoenix.jdbc.PhoenixDriver;
+
+@Tags({ "Phoenix", "DBCP", "hbase","Thick" })
+@CapabilityDescription("Create a phoenix DBCP connection pool using the
Phoenix Thick Driver.")
+public class PhoenixThickDBCPService extends AbstractControllerService
implements DBCPService {
+
+public static final PropertyDescriptor DATABASE_URL = new
PropertyDescriptor.Builder()
+.name("Phoenix Connection URL")
+.description(
+"A database connection URL used to connect to a database.
May contain database system name, host, port, database name and some
parameters."
++ " The exact syntax of a database connection URL
is specified by your DBMS.")
+
.defaultValue(null).addValidator(StandardValidators.NON_EMPTY_VALIDATOR).required(true)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+public static final PropertyDescriptor DB_USER = new
PropertyDescriptor.Builder().name("Database User")
+.description("HBase user
name").defaultValue(null).addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+public static final PropertyDescriptor DB_PASSWORD = new
PropertyDescriptor.Builder().name("Password")
+.description("The password for the HBase
user").defaultValue(null).required(false).sensitive(true)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY).build();
+
+public static final PropertyDescriptor MAX_WAIT_TIME = new
PropertyDescriptor.Builder().name("Max Wait Time")
+.description("The maximum amount of time that the pool will wait
(when there are no available connections) "
++ " for a connection to be returned before failing, or -1
to wait indefinitely. ")
+.defaultValue("500
millis").required(true).addValidator(StandardValidators.TIME_PERIOD_VALIDATOR)
+.sensitive(false).build();
+
+public static final PropertyDescriptor MAX_TOTAL_CONNECTIONS = new
PropertyDescriptor.Builder()
+.name("Max Total Connections")
+.description(
+"The maximum number of active connections that can be
allocated from this pool at the same time, "
++ " or negative for no limit.")
+
.defaultValue("8").required(true).addValidator(StandardValidators.INTEGER_VALIDATOR).sensitive(false)
+.build();
+
+public static final PropertyDescriptor VALIDATION_QUERY = new
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363330803 ## File path: nifi-nar-bundles/nifi-phoenix-bundle/pom.xml ## @@ -0,0 +1,38 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-nar-bundles +1.9.2 + + +2.1.1 +5.0.0-HBase-2.0 + +org.apache.nifi +nifi-phoenix-bundle +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363317896 ## File path: nifi-nar-bundles/nifi-phoenix-bundle/nifi-phoenix-nar/pom.xml ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-phoenix-bundle +1.10.0-SNAPSHOT + + +nifi-phoenix-nar +1.10.0-SNAPSHOT +nar + +true +true + + + + +org.apache.nifi +nifi-standard-services-api-nar +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363317917 ## File path: nifi-nar-bundles/nifi-phoenix-bundle/nifi-phoenix-nar/pom.xml ## @@ -0,0 +1,47 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-phoenix-bundle +1.10.0-SNAPSHOT + + +nifi-phoenix-nar +1.10.0-SNAPSHOT +nar + +true +true + + + + +org.apache.nifi +nifi-standard-services-api-nar +1.10.0-SNAPSHOT +nar + + +org.apache.nifi +nifi-phoenix-service +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363318158 ## File path: nifi-nar-bundles/nifi-phoenix-bundle/nifi-phoenix-service/pom.xml ## @@ -0,0 +1,91 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-phoenix-bundle +1.10.0-SNAPSHOT + + +nifi-phoenix-service +jar + + +org.apache.nifi +nifi-dbcp-service-api +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes
bbende commented on a change in pull request #3843: NIFI-6054 - Phoenix DBCP service changes URL: https://github.com/apache/nifi/pull/3843#discussion_r363317954 ## File path: nifi-nar-bundles/nifi-phoenix-bundle/nifi-phoenix-service/pom.xml ## @@ -0,0 +1,91 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-phoenix-bundle +1.10.0-SNAPSHOT Review comment: Update to 1.11.0-SNAPSHOT This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
