[GitHub] [nifi] github-actions[bot] closed pull request #4740: NIFI-8108 PublishKafka can specify kafka message timestamp by flowfile attribute
github-actions[bot] closed pull request #4740: URL: https://github.com/apache/nifi/pull/4740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #4827: NIFI-8037 Support TLSv1.3 in SSLContextService on Java 8
thenatog commented on pull request #4827: URL: https://github.com/apache/nifi/pull/4827#issuecomment-846306822 Testing this out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #5068: NIFI-8516 Enabled HTTPS and Single User Authentication by default
exceptionfactory commented on pull request #5068: URL: https://github.com/apache/nifi/pull/5068#issuecomment-846266488 > Thanks @exceptionfactory. This appears to work as designed. However, I think that this is a pretty concerning change to the user experience. Every time the user wants to login, they now are required to go find that generated username and password. There appears to be no way to set your own. I think we need the ability to set the username & password somehow. Preferably with something like `nifi.sh set-single-user ` or something like that. > > Would also recommend using a pre-defined username such as `admin` or `nifi` or something but I can leave that up to your discretion if the commandline util gives us the ability to set username and password Thanks for the review and feedback @markap14! Although Single User authentication is not intended for production use cases, having the ability to change the credentials would certainly make it easier to get started. I pushed an update that includes a new command option: `nifi.sh set-single-user-credentials ` This required refactoring shared classes to a new `nifi-single-user-utils` module that could be leveraged in the bootstrap library. I also updated the Getting Started documentation with an example command, and included a log statement with the command after generating the default random credentials. With this option, I kept the random username as well as random password. Please let me know if you have any additional feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1080: MINIFICPP-1559 Add new redistributable files to the msi in VS2019 builds
szaszm commented on a change in pull request #1080: URL: https://github.com/apache/nifi-minifi-cpp/pull/1080#discussion_r637186528 ## File path: msi/WixWin.wsi ## @@ -395,6 +371,23 @@ Licensed to the Apache Software Foundation (ASF) under one or more EventMessageFile="[#MiNiFiExeWithPassword]" /> + + + + + + + + + + + + + + Review comment: Why did you remove vcruntime140_1.dll from 32bit builds? I couldn't find a description of individual DLLs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
Lehel44 commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r637165820
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SetSNMP.java
##
@@ -105,6 +113,8 @@ public void onTrigger(final ProcessContext context, final
ProcessSession process
getLogger().error("Failed to send request to the agent. Check
if the agent supports the used version.");
processError(context, processSession, flowFile);
}
+} else {
+throw new ProcessException("No incoming flowfile found.");
Review comment:
No, the processor gets the OIDs to modify as flowfile attributes.
Without a flowfile we should let the user know it won't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
Lehel44 commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r637165029
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.snmp.configuration.TrapConfiguration;
+import org.apache.nifi.snmp.configuration.TrapV1Configuration;
+import org.apache.nifi.snmp.configuration.TrapV2cV3Configuration;
+import org.apache.nifi.snmp.utils.SNMPUtils;
+import org.snmp4j.mp.SnmpConstants;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Receiving data from configured SNMP agent which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSession)} method, will construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "send", "trap"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Sends information to SNMP Manager.")
+public class SendTrapSNMP extends AbstractSNMPProcessor {
+
+public static final AllowableValue GENERIC_TRAP_TYPE_0 = new
AllowableValue("0", "Cold Start",
+"A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" the agent's configuration or the protocol entity
implementation may be altered.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_1 = new
AllowableValue("1", "Warm Start",
+"A warmStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" neither the agent configuration nor the protocol entity
implementation is altered.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_2 = new
AllowableValue("2", "Link Down",
+"A linkDown trap signifies that the sending protocol entity
recognizes a failure in one of " +
+"the communication links represented in the agent's
configuration.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_3 = new
AllowableValue("3", "Link Up",
+"A linkUp trap signifies that the sending protocol entity
recognizes that one of the communication " +
+"links represented in the agent's configuration has come
up.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_4 = new
AllowableValue("4", "Authentication Failure",
+"An authenticationFailure trap signifies that the sending protocol
entity is the addressee of a " +
+"protocol message that is not properly authenticated.
While implementations of the SNMP must be " +
+"capable of generating this trap, they must also be
capable of suppressing the emission of such traps " +
+"via an implementation- specific mechanism.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_5 = new
AllowableValue("5", "EGP Neighbor Loss",
+"An egpNeighborLoss trap signifies that an EGP neighbor for whom
the sending protocol entity was " +
+"an EGP peer has been marked down and the peer
relationship no longer obtains.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_6 = new
[GitHub] [nifi] exceptionfactory commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
exceptionfactory commented on a change in pull request #5088: URL: https://github.com/apache/nifi/pull/5088#discussion_r637164632 ## File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml ## @@ -52,6 +52,16 @@ language governing permissions and limitations under the License. --> 1.14.0-SNAPSHOT test + +com.google.guava +guava +30.1.1-jre + + +com.alibaba +fastjson +1.2.76 Review comment: Thanks for the reply, yes, changing to use Jackson ObjectMapper should work, and also bring the implementation in line with other processors that handle JSON. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] Lehel44 commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
Lehel44 commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r637163865
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/SendTrapSNMP.java
##
@@ -0,0 +1,269 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.snmp.configuration.TrapConfiguration;
+import org.apache.nifi.snmp.configuration.TrapV1Configuration;
+import org.apache.nifi.snmp.configuration.TrapV2cV3Configuration;
+import org.apache.nifi.snmp.utils.SNMPUtils;
+import org.snmp4j.mp.SnmpConstants;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Receiving data from configured SNMP agent which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSession)} method, will construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "send", "trap"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Sends information to SNMP Manager.")
+public class SendTrapSNMP extends AbstractSNMPProcessor {
+
+public static final AllowableValue GENERIC_TRAP_TYPE_0 = new
AllowableValue("0", "Cold Start",
+"A coldStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" the agent's configuration or the protocol entity
implementation may be altered.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_1 = new
AllowableValue("1", "Warm Start",
+"A warmStart trap signifies that the sending protocol entity is
reinitializing itself such that" +
+" neither the agent configuration nor the protocol entity
implementation is altered.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_2 = new
AllowableValue("2", "Link Down",
+"A linkDown trap signifies that the sending protocol entity
recognizes a failure in one of " +
+"the communication links represented in the agent's
configuration.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_3 = new
AllowableValue("3", "Link Up",
+"A linkUp trap signifies that the sending protocol entity
recognizes that one of the communication " +
+"links represented in the agent's configuration has come
up.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_4 = new
AllowableValue("4", "Authentication Failure",
+"An authenticationFailure trap signifies that the sending protocol
entity is the addressee of a " +
+"protocol message that is not properly authenticated.
While implementations of the SNMP must be " +
+"capable of generating this trap, they must also be
capable of suppressing the emission of such traps " +
+"via an implementation- specific mechanism.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_5 = new
AllowableValue("5", "EGP Neighbor Loss",
+"An egpNeighborLoss trap signifies that an EGP neighbor for whom
the sending protocol entity was " +
+"an EGP peer has been marked down and the peer
relationship no longer obtains.");
+
+public static final AllowableValue GENERIC_TRAP_TYPE_6 = new
[GitHub] [nifi] Lehel44 commented on a change in pull request #5088: NIFI-3320: SendTrapSNMP and ListenTrapSNMP processors added.
Lehel44 commented on a change in pull request #5088:
URL: https://github.com/apache/nifi/pull/5088#discussion_r637163207
##
File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml
##
@@ -52,6 +52,16 @@ language governing permissions and limitations under the
License. -->
1.14.0-SNAPSHOT
test
+
+com.google.guava
+guava
+30.1.1-jre
+
+
+com.alibaba
+fastjson
+1.2.76
Review comment:
There's no particular reason. Would you recommend changing it to jackson?
##
File path: nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/pom.xml
##
@@ -52,6 +52,16 @@ language governing permissions and limitations under the
License. -->
1.14.0-SNAPSHOT
test
+
+com.google.guava
+guava
+30.1.1-jre
+
Review comment:
I'll remove it.
##
File path:
nifi-nar-bundles/nifi-snmp-bundle/nifi-snmp-processors/src/main/java/org/apache/nifi/snmp/processors/ListenTrapSNMP.java
##
@@ -0,0 +1,203 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.snmp.processors;
+
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.RequiresInstanceClassLoading;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.processor.AbstractSessionFactoryProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSessionFactory;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+import org.apache.nifi.snmp.configuration.SNMPConfiguration;
+import org.apache.nifi.snmp.operations.SNMPTrapReceiverHandler;
+import org.apache.nifi.snmp.utils.SNMPUtils;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+/**
+ * Receiving data from configured SNMP agent which, upon each invocation of
+ * {@link #onTrigger(ProcessContext, ProcessSessionFactory)} method, will
construct a
+ * {@link FlowFile} containing in its properties the information retrieved.
+ * The output {@link FlowFile} won't have any content.
+ */
+@Tags({"snmp", "listen", "trap"})
+@InputRequirement(InputRequirement.Requirement.INPUT_FORBIDDEN)
+@CapabilityDescription("Receives information from SNMP Agent and outputs a
FlowFile with information in attributes and without any content")
+@WritesAttribute(attribute = SNMPUtils.SNMP_PROP_PREFIX + "*", description =
"Attributes retrieved from the SNMP response. It may include:"
++ " snmp$errorIndex, snmp$errorStatus, snmp$errorStatusText,
snmp$nonRepeaters, snmp$requestID, snmp$type, snmp$variableBindings")
+@RequiresInstanceClassLoading
+public class ListenTrapSNMP extends AbstractSessionFactoryProcessor {
+
+private static final String DEFAULT_HOST = "127.0.0.1";
+private static final String DEFAULT_PORT = "0";
+
+// SNMP versions
+public static final AllowableValue SNMP_V1 = new AllowableValue("SNMPv1",
"v1", "SNMP version 1");
+public static final AllowableValue SNMP_V2C = new
AllowableValue("SNMPv2c", "v2c", "SNMP version 2c");
+public static final AllowableValue SNMP_V3 = new AllowableValue("SNMPv3",
"v3", "SNMP version 3 with improved security");
+
+// SNMPv3 security levels
+public static final AllowableValue NO_AUTH_NO_PRIV = new
AllowableValue("noAuthNoPriv", "No authentication or encryption",
+"No authentication or encryption.");
+public static final AllowableValue AUTH_NO_PRIV = new
[jira] [Commented] (NIFI-3320) Listen to SNMP Trap
[ https://issues.apache.org/jira/browse/NIFI-3320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349446#comment-17349446 ] Lehel Boér commented on NIFI-3320: -- Added PR: https://github.com/apache/nifi/pull/5088 > Listen to SNMP Trap > --- > > Key: NIFI-3320 > URL: https://issues.apache.org/jira/browse/NIFI-3320 > Project: Apache NiFi > Issue Type: New Feature >Affects Versions: 1.1.1 >Reporter: Balakrishnan R >Assignee: Hemantha kumara M S >Priority: Major > Labels: SNMP, Traps > > As part NIFI-1537 SNMP Get, Walk and Set were introduced. However SNMP Traps > sent to NIFI cannot be converted to a flowfile currently. This is a fairly > useful feature. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] Lehel44 opened a new pull request #5093: NIFI-4344: Improve bulletin messages with exception details.
Lehel44 opened a new pull request #5093:
URL: https://github.com/apache/nifi/pull/5093
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Changed
- Changed exception message in Connectable task. Component log automatically
adds the component name and id to
the beginning of the log message, don't need to add it manually.
- Added functionality to make chained exceptions displayed nicely in
bulletins.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-7900) Add AWS session token to AWSCredentialsProvider
[ https://issues.apache.org/jira/browse/NIFI-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi reassigned NIFI-7900: - Assignee: Peter Turcsanyi > Add AWS session token to AWSCredentialsProvider > --- > > Key: NIFI-7900 > URL: https://issues.apache.org/jira/browse/NIFI-7900 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.9.2, 1.12.1 >Reporter: Jody >Assignee: Peter Turcsanyi >Priority: Major > > As a NiFi user, I want to use AWS processors, e.g. PutS3Object processor, > with temporary credentials to allow connecting to secure AWS environments > that make use of the AWS Security Token Service. > > The NiFi AWSCredentialsProviderControllerService is giving an option to add > the required fields for using temporary credentials. While access key id and > secret access key properties can be configured, the property "session token" > is not available. The session token property must be provided when temporary > credentials are used. If the session token is not presented, an error will be > thrown: "The AWS Access Key Id you provided does not exist in our records. > (Service: Amazon S3; Status Code: 403; Error Code: InvalidAccessKeyId" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-7737) Add support for String[] to PutCassandraRecord
[
https://issues.apache.org/jira/browse/NIFI-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349417#comment-17349417
]
ASF subversion and git services commented on NIFI-7737:
---
Commit 0b29a42991a63da3b2bacad94c4f6e49ca5e1862 in nifi's branch
refs/heads/main from Wouter de Vries
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0b29a42 ]
NIFI-7737: add string array option to putcassandrarecord
NIFI-7737: fix checkstyle issues
Signed-off-by: Matthew Burgess
This closes #5005
> Add support for String[] to PutCassandraRecord
> --
>
> Key: NIFI-7737
> URL: https://issues.apache.org/jira/browse/NIFI-7737
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Wouter de Vries
>Assignee: Wouter de Vries
>Priority: Major
> Fix For: 1.14.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the PutCassandraRecord processor does support string arrays. Trying
> to use them results in the following error:
> {noformat}
> | 2020-08-13 15:15:37,861 ERROR [Timer-Driven Process Thread-5]
> o.a.n.p.cassandra.PutCassandraRecord
> PutCassandraRecord[id=af756410-1ef0-3d80-045e-160f02632c54] Unable to write
> the records into Cassandra table due to
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type:
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:361)
> | at
> com.datastax.driver.core.querybuilder.BuiltStatement.getValues(BuiltStatement.java:265)
> | at
> com.datastax.driver.core.BatchStatement.getIdAndValues(BatchStatement.java:92)
> | at
> com.datastax.driver.core.SessionManager.makeRequestMessage(SessionManager.java:597)
> | at
> com.datastax.driver.core.SessionManager.executeAsync(SessionManager.java:131)
> | at
> com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:68)
> | at
> org.apache.nifi.processors.cassandra.PutCassandraRecord.onTrigger(PutCassandraRecord.java:300)
> | at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> | at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176)
> | at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213)
> | at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)
> | at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> | at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> | at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> | at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> | at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> | at java.lang.Thread.run(Thread.java:748)
> | Caused by: com.datastax.driver.core.exceptions.CodecNotFoundException:
> Codec not found for requested operation: [ANY <-> [Ljava.lang.Object;]
> | at
> com.datastax.driver.core.CodecRegistry.notFound(CodecRegistry.java:741)
> | at
> com.datastax.driver.core.CodecRegistry.createCodec(CodecRegistry.java:602)
> | at
> com.datastax.driver.core.CodecRegistry.findCodec(CodecRegistry.java:582)
> | at
> com.datastax.driver.core.CodecRegistry.codecFor(CodecRegistry.java:429)
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:357)
> | ... 18 common frames omitted{noformat}
> The solution is to add the appropriate codec for this type conversion. I will
> submit a PR for this change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (NIFI-7737) Add support for String[] to PutCassandraRecord
[
https://issues.apache.org/jira/browse/NIFI-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349418#comment-17349418
]
ASF subversion and git services commented on NIFI-7737:
---
Commit 0b29a42991a63da3b2bacad94c4f6e49ca5e1862 in nifi's branch
refs/heads/main from Wouter de Vries
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0b29a42 ]
NIFI-7737: add string array option to putcassandrarecord
NIFI-7737: fix checkstyle issues
Signed-off-by: Matthew Burgess
This closes #5005
> Add support for String[] to PutCassandraRecord
> --
>
> Key: NIFI-7737
> URL: https://issues.apache.org/jira/browse/NIFI-7737
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Wouter de Vries
>Assignee: Wouter de Vries
>Priority: Major
> Fix For: 1.14.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently the PutCassandraRecord processor does support string arrays. Trying
> to use them results in the following error:
> {noformat}
> | 2020-08-13 15:15:37,861 ERROR [Timer-Driven Process Thread-5]
> o.a.n.p.cassandra.PutCassandraRecord
> PutCassandraRecord[id=af756410-1ef0-3d80-045e-160f02632c54] Unable to write
> the records into Cassandra table due to
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type:
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:361)
> | at
> com.datastax.driver.core.querybuilder.BuiltStatement.getValues(BuiltStatement.java:265)
> | at
> com.datastax.driver.core.BatchStatement.getIdAndValues(BatchStatement.java:92)
> | at
> com.datastax.driver.core.SessionManager.makeRequestMessage(SessionManager.java:597)
> | at
> com.datastax.driver.core.SessionManager.executeAsync(SessionManager.java:131)
> | at
> com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:68)
> | at
> org.apache.nifi.processors.cassandra.PutCassandraRecord.onTrigger(PutCassandraRecord.java:300)
> | at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> | at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176)
> | at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213)
> | at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)
> | at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> | at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> | at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> | at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> | at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> | at java.lang.Thread.run(Thread.java:748)
> | Caused by: com.datastax.driver.core.exceptions.CodecNotFoundException:
> Codec not found for requested operation: [ANY <-> [Ljava.lang.Object;]
> | at
> com.datastax.driver.core.CodecRegistry.notFound(CodecRegistry.java:741)
> | at
> com.datastax.driver.core.CodecRegistry.createCodec(CodecRegistry.java:602)
> | at
> com.datastax.driver.core.CodecRegistry.findCodec(CodecRegistry.java:582)
> | at
> com.datastax.driver.core.CodecRegistry.codecFor(CodecRegistry.java:429)
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:357)
> | ... 18 common frames omitted{noformat}
> The solution is to add the appropriate codec for this type conversion. I will
> submit a PR for this change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-7737) Add support for String[] to PutCassandraRecord
[
https://issues.apache.org/jira/browse/NIFI-7737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-7737:
---
Fix Version/s: 1.14.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Add support for String[] to PutCassandraRecord
> --
>
> Key: NIFI-7737
> URL: https://issues.apache.org/jira/browse/NIFI-7737
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Reporter: Wouter de Vries
>Assignee: Wouter de Vries
>Priority: Major
> Fix For: 1.14.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently the PutCassandraRecord processor does support string arrays. Trying
> to use them results in the following error:
> {noformat}
> | 2020-08-13 15:15:37,861 ERROR [Timer-Driven Process Thread-5]
> o.a.n.p.cassandra.PutCassandraRecord
> PutCassandraRecord[id=af756410-1ef0-3d80-045e-160f02632c54] Unable to write
> the records into Cassandra table due to
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type:
> com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | com.datastax.driver.core.exceptions.InvalidTypeException: Value 3 of type
> class [Ljava.lang.Object; does not correspond to any CQL3 type
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:361)
> | at
> com.datastax.driver.core.querybuilder.BuiltStatement.getValues(BuiltStatement.java:265)
> | at
> com.datastax.driver.core.BatchStatement.getIdAndValues(BatchStatement.java:92)
> | at
> com.datastax.driver.core.SessionManager.makeRequestMessage(SessionManager.java:597)
> | at
> com.datastax.driver.core.SessionManager.executeAsync(SessionManager.java:131)
> | at
> com.datastax.driver.core.AbstractSession.execute(AbstractSession.java:68)
> | at
> org.apache.nifi.processors.cassandra.PutCassandraRecord.onTrigger(PutCassandraRecord.java:300)
> | at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> | at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1176)
> | at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:213)
> | at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:117)
> | at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> | at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> | at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> | at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> | at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> | at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> | at java.lang.Thread.run(Thread.java:748)
> | Caused by: com.datastax.driver.core.exceptions.CodecNotFoundException:
> Codec not found for requested operation: [ANY <-> [Ljava.lang.Object;]
> | at
> com.datastax.driver.core.CodecRegistry.notFound(CodecRegistry.java:741)
> | at
> com.datastax.driver.core.CodecRegistry.createCodec(CodecRegistry.java:602)
> | at
> com.datastax.driver.core.CodecRegistry.findCodec(CodecRegistry.java:582)
> | at
> com.datastax.driver.core.CodecRegistry.codecFor(CodecRegistry.java:429)
> | at com.datastax.driver.core.querybuilder.Utils.convert(Utils.java:357)
> | ... 18 common frames omitted{noformat}
> The solution is to add the appropriate codec for this type conversion. I will
> submit a PR for this change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] mattyb149 closed pull request #5005: NIFI-7737: add string array option to putcassandrarecord
mattyb149 closed pull request #5005: URL: https://github.com/apache/nifi/pull/5005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #5005: NIFI-7737: add string array option to putcassandrarecord
mattyb149 commented on pull request #5005: URL: https://github.com/apache/nifi/pull/5005#issuecomment-846136662 +1 LGTM, tested on a live flow, verified a string array in the record was successfully inserted into Cassandra. Thanks for the improvement! Merging to main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8522) NiFi can duplicate controller services when generating templates
[ https://issues.apache.org/jira/browse/NIFI-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349409#comment-17349409 ] Matt Burgess commented on NIFI-8522: I'm not seeing the "observer identifier already exist exception" on main either, maybe it got fixed by something else? > NiFi can duplicate controller services when generating templates > > > Key: NIFI-8522 > URL: https://issues.apache.org/jira/browse/NIFI-8522 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matthew Clarke >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > NiFi throws "The specified observer identifier already exists" exception when > trying to instantiate a template to the canvas. Parsing the template xml > reveals multiple controller services with same UUID. > Steps to reproduce: > 1. Create "PG-level1" > 2. within "PG-level1" create two new sub process groups "PG-level2-A" and > "PG-level2-B". > 3. Create a controller service(s) in "PG-level2-A" like AvroReader and > CSVRecordSetWriter. Add a processor like ConvertRecord and configure it to > reference these two controller services. > 4. Right click on the ConvertRecord processor and copy it. Exit > "PG-level2-A" and enter "PG-level2-B" and paste that copy processor. The > processor will show both configured controller services as "Incompatible > Controller Service Configured" and invalid bulletin will reflect the > properties reference controller services that do not exist. > 5. go up to "PG-level1" level and generate a template. Template is created > successfully. > 6. Try to instantiate this template to the canvas and it will only partially > instantiate and throw the "observer identifier already exist exception. > Inspection of the template shows that the controller services scoped to > PG-level2-A were added into the template again at the parent "PG-level1" > scope with same UUID. > The expected behavior is that the controller services do not get duplicated > and the processor in the instantiate template either has no configured > controller services or still reflects that it references controller > service(s) that do not exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] markap14 commented on pull request #5068: NIFI-8516 Enabled HTTPS and Single User Authentication by default
markap14 commented on pull request #5068: URL: https://github.com/apache/nifi/pull/5068#issuecomment-846109886 Thanks @exceptionfactory. This appears to work as designed. However, I think that this is a pretty concerning change to the user experience. Every time the user wants to login, they now are required to go find that generated username and password. There appears to be no way to set your own. I think we need the ability to set the username & password somehow. Preferably with something like `nifi.sh set-single-user ` or something like that. Would also recommend using a pre-defined username such as `admin` or `nifi` or something but I can leave that up to your discretion if the commandline util gives us the ability to set username and password -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-78) Add interrupt option for stopped processors with active threads
[ https://issues.apache.org/jira/browse/NIFI-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-78. Resolution: Fixed > Add interrupt option for stopped processors with active threads > --- > > Key: NIFI-78 > URL: https://issues.apache.org/jira/browse/NIFI-78 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: Joe Witt >Assignee: Mark Payne >Priority: Minor > > Some processors have really long stopping periods. Would be nice to be able > to forcibly kill them if possible. Otherwise certain flow changes cannot > occur. This is one part best practices and another part helping the user > decide when to forcibly kill a processor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-8604) Upgrade Apache Accumulo to 2.0.1
[ https://issues.apache.org/jira/browse/NIFI-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough resolved NIFI-8604. Fix Version/s: 1.13.3 1.14.0 Resolution: Fixed > Upgrade Apache Accumulo to 2.0.1 > > > Key: NIFI-8604 > URL: https://issues.apache.org/jira/browse/NIFI-8604 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.13.2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.14.0, 1.13.3 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Apache Accumulo server 2.0.0 is impacted by > [CVE-2020-17533|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-17533], > which was resolved in version 2.0.1. Although the vulnerability does not > impact NiFi client code, upgrading from version 2.0.0 maintains version > parity with Accumulo server and avoids false positives in the OWASP > Dependency Check Report. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8604) Upgrade Apache Accumulo to 2.0.1
[ https://issues.apache.org/jira/browse/NIFI-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349348#comment-17349348 ] ASF subversion and git services commented on NIFI-8604: --- Commit 1c17da562bcf581af93a22577067c26fe2c7444d in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1c17da5 ] NIFI-8604 Upgraded Apache Accumulo to 2.0.1 Signed-off-by: Nathan Gough This closes #5077. > Upgrade Apache Accumulo to 2.0.1 > > > Key: NIFI-8604 > URL: https://issues.apache.org/jira/browse/NIFI-8604 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.13.2 >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Time Spent: 1h 40m > Remaining Estimate: 0h > > Apache Accumulo server 2.0.0 is impacted by > [CVE-2020-17533|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-17533], > which was resolved in version 2.0.1. Although the vulnerability does not > impact NiFi client code, upgrading from version 2.0.0 maintains version > parity with Accumulo server and avoids false positives in the OWASP > Dependency Check Report. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] thenatog closed pull request #5077: NIFI-8604 Upgraded Apache Accumulo to 2.0.1
thenatog closed pull request #5077: URL: https://github.com/apache/nifi/pull/5077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-8626) Upgrade okhttp-digest to 2.5
David Handermann created NIFI-8626:
--
Summary: Upgrade okhttp-digest to 2.5
Key: NIFI-8626
URL: https://issues.apache.org/jira/browse/NIFI-8626
Project: Apache NiFi
Issue Type: Improvement
Affects Versions: 1.13.2
Reporter: David Handermann
Assignee: David Handermann
The okhttp-digest library provides support for HTTP Digest authentication in
InvokeHTTP and RestLookupService. The library recently moved from JCenter to
Maven Central and changed coordinates to {{io.github.rburgst:okhttp-digest}}.
Recent updates also include addressing potential issues with concurrent usage
of the digest authenticator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi] thenatog commented on pull request #5077: NIFI-8604 Upgraded Apache Accumulo to 2.0.1
thenatog commented on pull request #5077: URL: https://github.com/apache/nifi/pull/5077#issuecomment-846050472 +1 merging :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1082: MINIFICPP-1494 Allow InvokeHTTP GET requests without incoming flowfile
lordgamez opened a new pull request #1082: URL: https://github.com/apache/nifi-minifi-cpp/pull/1082 Handling the use case when InvokeHTTP processor has no real incoming connection but there is a Retry self-loop, the scheduler should trigger the processor. Jira ticket: https://issues.apache.org/jira/browse/MINIFICPP-1494 Note: We discussed that renaming the relationships is not an option to avoid introducing a breaking change, only change (1) is implemented - Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1042: MINIFICPP-1457 - Implement InputRequirements
szaszm commented on a change in pull request #1042:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r637002796
##
File path: libminifi/src/core/Processor.cpp
##
@@ -386,6 +379,38 @@ std::shared_ptr
Processor::pickIncomingConnection() {
return getNextIncomingConnectionImpl(rel_guard);
}
+void Processor::validateAnnotations() const {
+ switch (getInputRequirement()) {
+case annotation::Input::INPUT_REQUIRED: {
+ if (!hasIncomingConnections()) {
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "INPUT_REQUIRED was
specified for the processor, but no inputs were found");
Review comment:
I would rather refer to incoming connections in the error message.
```suggestion
throw Exception(PROCESS_SCHEDULE_EXCEPTION, "INPUT_REQUIRED was
specified for the processor, but no incoming connections were found");
```
##
File path: libminifi/src/core/Processor.cpp
##
@@ -386,6 +379,38 @@ std::shared_ptr
Processor::pickIncomingConnection() {
return getNextIncomingConnectionImpl(rel_guard);
}
+void Processor::validateAnnotations() const {
+ switch (getInputRequirement()) {
+case annotation::Input::INPUT_REQUIRED: {
+ if (!hasIncomingConnections()) {
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "INPUT_REQUIRED was
specified for the processor, but no inputs were found");
+ }
+ return;
+}
+case annotation::Input::INPUT_ALLOWED:
+ return;
+case annotation::Input::INPUT_FORBIDDEN: {
+ if (hasIncomingConnections()) {
+throw Exception(PROCESS_SCHEDULE_EXCEPTION, "INPUT_FORBIDDEN was
specified for the processor, but at least one input was found");
Review comment:
```suggestion
throw Exception(PROCESS_SCHEDULE_EXCEPTION, "INPUT_FORBIDDEN was
specified for the processor, but there are incoming connections");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-8522) NiFi can duplicate controller services when generating templates
[ https://issues.apache.org/jira/browse/NIFI-8522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8522: --- Affects Version/s: (was: 1.12.1) (was: 1.11.4) (was: 1.10.0) (was: 1.9.0) Status: Patch Available (was: Open) > NiFi can duplicate controller services when generating templates > > > Key: NIFI-8522 > URL: https://issues.apache.org/jira/browse/NIFI-8522 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Reporter: Matthew Clarke >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > NiFi throws "The specified observer identifier already exists" exception when > trying to instantiate a template to the canvas. Parsing the template xml > reveals multiple controller services with same UUID. > Steps to reproduce: > 1. Create "PG-level1" > 2. within "PG-level1" create two new sub process groups "PG-level2-A" and > "PG-level2-B". > 3. Create a controller service(s) in "PG-level2-A" like AvroReader and > CSVRecordSetWriter. Add a processor like ConvertRecord and configure it to > reference these two controller services. > 4. Right click on the ConvertRecord processor and copy it. Exit > "PG-level2-A" and enter "PG-level2-B" and paste that copy processor. The > processor will show both configured controller services as "Incompatible > Controller Service Configured" and invalid bulletin will reflect the > properties reference controller services that do not exist. > 5. go up to "PG-level1" level and generate a template. Template is created > successfully. > 6. Try to instantiate this template to the canvas and it will only partially > instantiate and throw the "observer identifier already exist exception. > Inspection of the template shows that the controller services scoped to > PG-level2-A were added into the template again at the parent "PG-level1" > scope with same UUID. > The expected behavior is that the controller services do not get duplicated > and the processor in the instantiate template either has no configured > controller services or still reflects that it references controller > service(s) that do not exist. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MINIFICPP-1566) Prevent stateful processors from running on multiple threads
Ádám Markovics created MINIFICPP-1566: - Summary: Prevent stateful processors from running on multiple threads Key: MINIFICPP-1566 URL: https://issues.apache.org/jira/browse/MINIFICPP-1566 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Ádám Markovics Assignee: Ádám Markovics This is wrong by design. Check on start whether multiple threads are assigned to the processor. Also mutexes can be removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request #1081: MINIFICPP-1565: Minor improvements in PerformanceDataMonitor
martinzink opened a new pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] timeabarna commented on pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors
timeabarna commented on pull request #4973: URL: https://github.com/apache/nifi/pull/4973#issuecomment-845978458 @phrocker No worries. Thank you very much for your help. Your feedback and time are much appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-1526) add systemd journal collection processor
[ https://issues.apache.org/jira/browse/MINIFICPP-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz resolved MINIFICPP-1526. - Fix Version/s: 0.10.0 Resolution: Done > add systemd journal collection processor > > > Key: MINIFICPP-1526 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1526 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Assignee: Marton Szasz >Priority: Major > Fix For: 0.10.0 > > Time Spent: 7h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1080: MINIFICPP-1559 Add new redistributable file to the msi in VS2019 builds
szaszm commented on pull request #1080: URL: https://github.com/apache/nifi-minifi-cpp/pull/1080#issuecomment-845939924 I would include all of the redistributables as long as they are not huge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1565) Improve PerformanceDataMonitor
Martin Zink created MINIFICPP-1565: -- Summary: Improve PerformanceDataMonitor Key: MINIFICPP-1565 URL: https://issues.apache.org/jira/browse/MINIFICPP-1565 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Martin Zink Assignee: Martin Zink The PerformanceDataMonitor created in MINIFICPP-1532 could use some minor improvements. * Compact output options to reduce flowfile size. * The ability to round the doubles to reduce flowfile size. * Append HostName to the OpenTelemetry format. * Dont group processes with the same name in the output. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] adamdebreceni closed pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages
adamdebreceni closed pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request #1080: MINIFICPP-1559 Add new redistributable file to the msi in VS2019 builds
fgerlits opened a new pull request #1080: URL: https://github.com/apache/nifi-minifi-cpp/pull/1080 https://issues.apache.org/jira/browse/MINIFICPP-1559 Visual Studio 2019 contains a new redistributable DLL, `vcruntime140_1.dll`, which is required by VS2019 MiNiFi builds but was not included in the MSI package. I have added it (in VS2019 builds only). NOTE: there are two other new DLLs in the VS2019 redistributable directory, `msvcp140_atomic_wait.dll` and `msvcp140_codecvt_ids.dll`. I did not include these, as our current build does not require them. Should we include these, too? --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8373) Add Kerberos support to Accumulo processors
[ https://issues.apache.org/jira/browse/NIFI-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-8373: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Add Kerberos support to Accumulo processors > --- > > Key: NIFI-8373 > URL: https://issues.apache.org/jira/browse/NIFI-8373 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > Add Kerberos support to Accumulo processors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8373) Add Kerberos support to Accumulo processors
[ https://issues.apache.org/jira/browse/NIFI-8373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349180#comment-17349180 ] ASF subversion and git services commented on NIFI-8373: --- Commit b6f84413c4c1b740a7e4c5d5a17930bdbf7bdf18 in nifi's branch refs/heads/main from Timea Barna [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b6f8441 ] NIFI-8373 Add Kerberos support to Accumulo processors This closes #4973. Signed-off-by: Tamas Palfy > Add Kerberos support to Accumulo processors > --- > > Key: NIFI-8373 > URL: https://issues.apache.org/jira/browse/NIFI-8373 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Timea Barna >Assignee: Timea Barna >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > Add Kerberos support to Accumulo processors -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] tpalfy commented on pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors
tpalfy commented on pull request #4973: URL: https://github.com/apache/nifi/pull/4973#issuecomment-845907808 LGTM+1 Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4973: NIFI-8373 Add Kerberos support to Accumulo processors
asfgit closed pull request #4973: URL: https://github.com/apache/nifi/pull/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8623) Automated Build Failures due to pentaho-aggdesigner-algorithm 5.1.5-jhyde
[ https://issues.apache.org/jira/browse/NIFI-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349176#comment-17349176 ] ASF subversion and git services commented on NIFI-8623: --- Commit 4888eaf62d2026067c40caa91e7bf6d4f2917c9f in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4888eaf ] NIFI-8623 Changed repositories from conjars.org to public.nexus.pentaho.org Signed-off-by: Matthew Burgess This closes #5091 > Automated Build Failures due to pentaho-aggdesigner-algorithm 5.1.5-jhyde > - > > Key: NIFI-8623 > URL: https://issues.apache.org/jira/browse/NIFI-8623 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Blocker > Time Spent: 40m > Remaining Estimate: 0h > > Recent automated builds on Apache Maven 3.8.1 have started failing due to > conjars.org no longer providing the pentaho-aggdesigner-algorithm 5.1.5-jhyde > dependency for calcite 1.2.0-incubating. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8623) Automated Build Failures due to pentaho-aggdesigner-algorithm 5.1.5-jhyde
[ https://issues.apache.org/jira/browse/NIFI-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-8623: --- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Automated Build Failures due to pentaho-aggdesigner-algorithm 5.1.5-jhyde > - > > Key: NIFI-8623 > URL: https://issues.apache.org/jira/browse/NIFI-8623 > Project: Apache NiFi > Issue Type: Task > Components: Tools and Build >Reporter: David Handermann >Assignee: David Handermann >Priority: Blocker > Fix For: 1.14.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Recent automated builds on Apache Maven 3.8.1 have started failing due to > conjars.org no longer providing the pentaho-aggdesigner-algorithm 5.1.5-jhyde > dependency for calcite 1.2.0-incubating. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] mattyb149 closed pull request #5091: NIFI-8623 Changed repositories from conjars.org to public.nexus.pentaho.org
mattyb149 closed pull request #5091: URL: https://github.com/apache/nifi/pull/5091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request #1079: MINIFICPP-1564 - Remove agent update
adamdebreceni opened a new pull request #1079: URL: https://github.com/apache/nifi-minifi-cpp/pull/1079 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1078: MINIFICPP-1562 Use CLCACHE_NODIRECT option to avoid clcache failures
lordgamez commented on pull request #1078: URL: https://github.com/apache/nifi-minifi-cpp/pull/1078#issuecomment-845860985 > > adding the CLCACHE_NODIRECT option to the job made the next run succeed with the same restore key > > This could happen because the hashes of the original and the preprocessed sources are different, so this was effectively a cache clear. FYI, but I don't have any other idea. That is probably the case here judging from the build runtime. We should see if the issue reappears in the future with the `no direct` option. Maybe with the different cache key handling the issue will not persist anymore. There was a similar [missing object issue](https://github.com/frerich/clcache/issues/210) in the past with the `no direct` option which was fixed and could not be reproduced later, so I'm hoping this could help us as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-1564) Remove unused c2 update functionality
Adam Debreceni created MINIFICPP-1564: - Summary: Remove unused c2 update functionality Key: MINIFICPP-1564 URL: https://issues.apache.org/jira/browse/MINIFICPP-1564 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Adam Debreceni Assignee: Adam Debreceni Remove unused c2 update functionality. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1060: MINIFI-CPP-1203 - Add linter recommended missing whitespaces
szaszm closed pull request #1060: URL: https://github.com/apache/nifi-minifi-cpp/pull/1060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KevinSky updated NIFI-8625: --- Description: In single thread, executeScript just stop and start, flow file always stuck in connections. In multi thread.executeScript always throw exception like is already marked for transfer in or is not known in this session. was: In single thread, executeScript just stop and start, flow file always stuck in connections. In multi thread.executeScript always throw excetion like is already marked for transfer in or is not known in this session. > ExecuteScript processor always stuck after restart or multi thread > -- > > Key: NIFI-8625 > URL: https://issues.apache.org/jira/browse/NIFI-8625 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: KevinSky >Priority: Critical > Labels: ExecuteScript,stcuk > Attachments: image-2021-05-21-16-22-34-775.png > > > In single thread, executeScript just stop and start, flow file always stuck > in connections. > In multi thread.executeScript always throw exception like is already marked > for transfer in or is not known in this session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8610) Invalid bigdecimal values in ORC when multiple avro records provided
[ https://issues.apache.org/jira/browse/NIFI-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349086#comment-17349086 ] Dominik Przybysz commented on NIFI-8610: The root problem could be connected with https://issues.apache.org/jira/browse/AVRO-3049 but it has to be checked. Anyway it's high time to upgrade AVRO to newer version in NIFI. > Invalid bigdecimal values in ORC when multiple avro records provided > > > Key: NIFI-8610 > URL: https://issues.apache.org/jira/browse/NIFI-8610 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: Dominik Przybysz >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Processor: convertAvroToORC > Input: flow file contains a lot of avro records with decimal values as bytes > with logical type decimal > Output: ORC file with different values for decimal values > Reason: AvroReader used in processor reuses previous generic record when > fetching next one > Solution: Don't reuse generic records when reading records from flow file -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (NIFI-8621) correct main page documentation issue
[ https://issues.apache.org/jira/browse/NIFI-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8621. -- Fix Version/s: 1.14.0 Resolution: Fixed > correct main page documentation issue > - > > Key: NIFI-8621 > URL: https://issues.apache.org/jira/browse/NIFI-8621 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Trivial > Fix For: 1.14.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > README.md > wrong link to "MiNiFi" in table of contents -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8621) correct main page documentation issue
[ https://issues.apache.org/jira/browse/NIFI-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349085#comment-17349085 ] ASF subversion and git services commented on NIFI-8621: --- Commit 48b75c15aa888cf0c106ab06652bc04d1bf4fdd9 in nifi's branch refs/heads/main from Paul Grey [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=48b75c1 ] NIFI-8621: fix page-internal link Signed-off-by: Pierre Villard This closes #5089. > correct main page documentation issue > - > > Key: NIFI-8621 > URL: https://issues.apache.org/jira/browse/NIFI-8621 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Trivial > Time Spent: 20m > Remaining Estimate: 0h > > README.md > wrong link to "MiNiFi" in table of contents -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi] asfgit closed pull request #5089: NIFI-8621: fix page-internal link
asfgit closed pull request #5089: URL: https://github.com/apache/nifi/pull/5089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349074#comment-17349074 ] KevinSky commented on NIFI-8625: remove compiledScriptRef will works fine. but I'm not sure it can resulting in up to 10x performance improvements by NIFI-8080 !image-2021-05-21-16-22-34-775.png! > ExecuteScript processor always stuck after restart or multi thread > -- > > Key: NIFI-8625 > URL: https://issues.apache.org/jira/browse/NIFI-8625 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: KevinSky >Priority: Critical > Labels: ExecuteScript,stcuk > Attachments: image-2021-05-21-16-22-34-775.png > > > In single thread, executeScript just stop and start, flow file always stuck > in connections. > In multi thread.executeScript always throw excetion like is already marked > for transfer in or is not known in this session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349074#comment-17349074 ] KevinSky edited comment on NIFI-8625 at 5/21/21, 8:25 AM: -- remove compiledScriptRef will works fine. but I'm not sure it can resulting in up to 10x performance improvements by NIFI-8080 !image-2021-05-21-16-22-34-775.png|width=573,height=240! was (Author: kevinsky1093): remove compiledScriptRef will works fine. but I'm not sure it can resulting in up to 10x performance improvements by NIFI-8080 !image-2021-05-21-16-22-34-775.png! > ExecuteScript processor always stuck after restart or multi thread > -- > > Key: NIFI-8625 > URL: https://issues.apache.org/jira/browse/NIFI-8625 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: KevinSky >Priority: Critical > Labels: ExecuteScript,stcuk > Attachments: image-2021-05-21-16-22-34-775.png > > > In single thread, executeScript just stop and start, flow file always stuck > in connections. > In multi thread.executeScript always throw excetion like is already marked > for transfer in or is not known in this session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KevinSky updated NIFI-8625: --- Attachment: image-2021-05-21-16-22-34-775.png > ExecuteScript processor always stuck after restart or multi thread > -- > > Key: NIFI-8625 > URL: https://issues.apache.org/jira/browse/NIFI-8625 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: KevinSky >Priority: Critical > Labels: ExecuteScript,stcuk > Attachments: image-2021-05-21-16-22-34-775.png > > > In single thread, executeScript just stop and start, flow file always stuck > in connections. > In multi thread.executeScript always throw excetion like is already marked > for transfer in or is not known in this session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349072#comment-17349072 ] KevinSky commented on NIFI-8625: NIFI-8080caused this, in sigle thread,if it is not first in,compiledScriptRef save the first time compiled value,and when executeScript restart, it only clear ScriptingComponentHelper.engineQ,but scriptEngineConfiguratorMap also has the reference of compiledScriptRef. so that is why we see stuck in connections. in multi thread, compiledScriptRef only save first engine compiled CompiledScript. eval() method don't use the true engine to eval,so it always throw exception NIFI-8461 reveals this problem, but the scene description is incomplete. > ExecuteScript processor always stuck after restart or multi thread > -- > > Key: NIFI-8625 > URL: https://issues.apache.org/jira/browse/NIFI-8625 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: KevinSky >Priority: Critical > Labels: ExecuteScript,stcuk > > In single thread, executeScript just stop and start, flow file always stuck > in connections. > In multi thread.executeScript always throw excetion like is already marked > for transfer in or is not known in this session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread
KevinSky created NIFI-8625: -- Summary: ExecuteScript processor always stuck after restart or multi thread Key: NIFI-8625 URL: https://issues.apache.org/jira/browse/NIFI-8625 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.13.2 Reporter: KevinSky In single thread, executeScript just stop and start, flow file always stuck in connections. In multi thread.executeScript always throw excetion like is already marked for transfer in or is not known in this session. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8610) Invalid bigdecimal values in ORC when multiple avro records provided
[ https://issues.apache.org/jira/browse/NIFI-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349070#comment-17349070 ] Peter Gyori commented on NIFI-8610: --- Understood. Thank you for checking! > Invalid bigdecimal values in ORC when multiple avro records provided > > > Key: NIFI-8610 > URL: https://issues.apache.org/jira/browse/NIFI-8610 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 >Reporter: Dominik Przybysz >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Processor: convertAvroToORC > Input: flow file contains a lot of avro records with decimal values as bytes > with logical type decimal > Output: ORC file with different values for decimal values > Reason: AvroReader used in processor reuses previous generic record when > fetching next one > Solution: Don't reuse generic records when reading records from flow file -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (NIFI-8461) Queue reports items but cannot list them
[
https://issues.apache.org/jira/browse/NIFI-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17349069#comment-17349069
]
KevinSky commented on NIFI-8461:
NIFI-8080caused this, in sigle thread,if it is not first in,compiledScriptRef
save the first time compiled value,and when executeScript restart, it only
clear
ScriptingComponentHelper.engineQ,but scriptEngineConfiguratorMap also has the
reference of compiledScriptRef. so that is why we see stuck in connections.
in multi thread, compiledScriptRef only save first engine compiled
CompiledScript. eval() method don't use the true engine to eval,so it always
throw exception like
is already marked for transfer in
or
is not known in this session
!image-2021-05-21-16-02-22-044.png|width=993,height=266!
It's hard and unless to binding compiledScriptRef to each engine in
scriptingComponentHelper.engineQ, We must always bind bindings to engine
without just complie it,so those code modification might be use:
{code:java}
public class JythonScriptEngineConfigurator implements ScriptEngineConfigurator
{
private String prefix = null;
@Override
public String getScriptEngineName() {
return "python";
}
@Override
public URL[] getModuleURLsForClasspath(String[] modulePaths, ComponentLog
log) {
// We don't need to add the module paths to the classpath, they will be
added via sys.path.append
return new URL[0];
}
@Override
public Object init(ScriptEngine engine, String scriptBody, String[]
modulePaths) throws ScriptException {
// Always compile when first run
if (engine != null) {
// Add prefix for import sys and all jython modules
prefix = "import sys\n"
+ Arrays.stream(modulePaths).map((modulePath) ->
"sys.path.append(" + PyString.encode_UnicodeEscape(modulePath, true) + ")")
.collect(Collectors.joining("\n"));
}
return null;
}
@Override
public Object eval(ScriptEngine engine, String scriptBody, String[]
modulePaths) throws ScriptException {
Object returnValue = null;
if (engine != null) {
returnValue = ((Compilable) engine).compile(prefix +
scriptBody).eval();
}
return returnValue;
}
}
{code}
> Queue reports items but cannot list them
>
>
> Key: NIFI-8461
> URL: https://issues.apache.org/jira/browse/NIFI-8461
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 1.13.2
> Environment: Docker image apache/nifi :1.13.2, Windows 10 Pro, WSL 2
> (Ubuntu), x86_64
>Reporter: Kevin Aagaard
>Assignee: Matt Burgess
>Priority: Major
> Labels: queue
> Attachments: ExecuteScript_Queue_Issue.txt, NIFI-8461.zip,
> image-2021-04-22-08-48-58-117.png, image-2021-04-22-08-49-40-904.png,
> image-2021-04-27-14-23-07-849.png, image-2021-04-27-14-23-24-477.png,
> image-2021-05-21-16-02-22-044.png
>
>
> The following segment of workflow demonstrates the issue. The queue reports
> that there are items within it, but they cannot be listed, even after
> stopping the consumer (and producer). Since this is in a Docker Container, it
> is unlikely an OS error.
>
> !image-2021-04-22-08-48-58-117.png!
>
> !image-2021-04-22-08-49-40-904.png!
> I do not currently have a simplified example workflow to recreate the error,
> but can work on it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8461) Queue reports items but cannot list them
[ https://issues.apache.org/jira/browse/NIFI-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] KevinSky updated NIFI-8461: --- Attachment: image-2021-05-21-16-02-22-044.png > Queue reports items but cannot list them > > > Key: NIFI-8461 > URL: https://issues.apache.org/jira/browse/NIFI-8461 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.13.2 > Environment: Docker image apache/nifi :1.13.2, Windows 10 Pro, WSL 2 > (Ubuntu), x86_64 >Reporter: Kevin Aagaard >Assignee: Matt Burgess >Priority: Major > Labels: queue > Attachments: ExecuteScript_Queue_Issue.txt, NIFI-8461.zip, > image-2021-04-22-08-48-58-117.png, image-2021-04-22-08-49-40-904.png, > image-2021-04-27-14-23-07-849.png, image-2021-04-27-14-23-24-477.png, > image-2021-05-21-16-02-22-044.png > > > The following segment of workflow demonstrates the issue. The queue reports > that there are items within it, but they cannot be listed, even after > stopping the consumer (and producer). Since this is in a Docker Container, it > is unlikely an OS error. > > !image-2021-04-22-08-48-58-117.png! > > !image-2021-04-22-08-49-40-904.png! > I do not currently have a simplified example workflow to recreate the error, > but can work on it. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1078: MINIFICPP-1562 Use CLCACHE_NODIRECT option to avoid clcache failures
lordgamez opened a new pull request #1078: URL: https://github.com/apache/nifi-minifi-cpp/pull/1078 The clcache object invalidation caused failures in the Github Actions Windows-VS2019 job previously which reappeared in run https://github.com/apache/nifi-minifi-cpp/runs/2628922164?check_suite_focus=true with the restore key: windows-vs2019-clcache-refs/heads/main-63f6e716f74f0936fc38b755eea23f83b481044c Amending the PR by adding the CLCACHE_NODIRECT option to the job made the next run succeed with the same restore key: https://github.com/apache/nifi-minifi-cpp/runs/2630706634?check_suite_focus=true Description of the option: > **CLCACHE_NODIRECT** > Disable direct mode. If this variable is set, clcache will always run preprocessor on source file and will hash preprocessor output to get cache key. Use this if you experience problems with direct mode or if you need built-in macroses like _TIME_ to work correctly. -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (MINIFICPP-1562) Failing CI due to corrupted cache on Windows-2019
[
https://issues.apache.org/jira/browse/MINIFICPP-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gyimesi reopened MINIFICPP-1562:
--
Assignee: Gabor Gyimesi (was: Martin Zink)
> Failing CI due to corrupted cache on Windows-2019
> -
>
> Key: MINIFICPP-1562
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1562
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Martin Zink
>Assignee: Gabor Gyimesi
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The windows-vs2019 CI is failing due to corrupted clcache.
> Unfortunetly github doesnt have clean way to clear the cache.
> {code:java}
> GitHub will remove any cache entries that have not been accessed in over 7
> days. There is no limit on the number of caches you can store, but the total
> size of all caches in a repository is limited to 5 GB. If you exceed this
> limit, GitHub will save your cache but will begin evicting caches until the
> total size is less than 5 GB.
> {code}
> But since the cache is used I dont think github will clear it.
> A quick and dirty fix is: if we were to change the key in the .github/ci.yml
> file, it would fix the issue.
> [https://github.community/t/how-to-clear-cache-in-github-actions/129038/3]
> If this issue comes up again maybe we could implement a workflow that clears
> the caches, with
> [https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (NIFI-8624) Remove the declaration of thrown ProcessException from processor archetype bundle
[
https://issues.apache.org/jira/browse/NIFI-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lockie Richter updated NIFI-8624:
-
Fix Version/s: (was: 1.13.3)
> Remove the declaration of thrown ProcessException from processor archetype
> bundle
> -
>
> Key: NIFI-8624
> URL: https://issues.apache.org/jira/browse/NIFI-8624
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Examples
>Affects Versions: 1.13.2
>Reporter: Lockie Richter
>Priority: Trivial
> Labels: templates
> Original Estimate: 24h
> Time Spent: 10m
> Remaining Estimate: 23h 50m
>
> h3. Info
> Currently the nifi-maven-archetype projects are reporting some basic code
> smells in SonarQube reporting.
> These issues should be addressed to avoid propagating code smells through to
> anyone who instantiates the processor or service archetypes.
> h3. Warnings Generated
> *Processor Archetype*
> * {{Remove the declaration of thrown exception
> 'org.apache.nifi.processor.exception.ProcessException' which is a runtime
> exception.}}
> * {{Rename "descriptors" which hides the field declared at line ...}}
> * {{Rename "relationships" which hides the field declared at line ...}}
> *Service Archetype*
> * {{Remove the declaration of thrown exception
> 'org.apache.nifi.processor.exception.ProcessException' which is a runtime
> exception.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages
adamdebreceni commented on a change in pull request #1044:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r636680823
##
File path: extensions/systemd/WorkerThread.h
##
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include "utils/MinifiConcurrentQueue.h"
+
+#include
+#include
+
+namespace org { namespace apache { namespace nifi { namespace minifi {
namespace extensions { namespace systemd {
+
+namespace detail {
+class WorkerThread final {
+ public:
+ WorkerThread();
+
+ WorkerThread(const WorkerThread&) = delete;
+ WorkerThread(WorkerThread&&) = delete;
+ WorkerThread& operator=(WorkerThread) = delete;
+
+ ~WorkerThread();
+
+ template
+ void enqueue(Args&&... args) {
task_queue_.enqueue(std::forward(args)...); }
+
+ private:
+ void run() noexcept;
+
+ utils::ConditionConcurrentQueue> task_queue_;
+ std::thread thread_;
+};
+} // namespace detail
+
+/**
+ * A worker that executes arbitrary functions with no parameters
asynchronously on an internal thread, returning a future to the result.
+ */
+class Worker final {
Review comment:
I ment, what the added complexity would be on the usage side, but lets
go with the new implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
