[GitHub] [nifi] exceptionfactory commented on pull request #7013: NIFI-4890 Refactor OIDC with support for Refresh Tokens
exceptionfactory commented on PR #7013: URL: https://github.com/apache/nifi/pull/7013#issuecomment-1478804044 Thanks for the testing @emiliosetiadarma! After some discussion with @mcgilman, I pushed an update to change the source of initial application Bearer Token expiration. The previous implementation derived the application Bearer Token expiration from the ID Token, but the update changes the approach to derive the expiration from the Access Token. This strategy aligns both initial expiration and refreshed expiration to derive from the Access Token expiration. Some Identity Providers return the same expiration value for both the ID Token and the Access Token, so the end result will not change for those providers. Changing the source of the application Bearer Token expiration to the Access Token expiration provides a consistent approach, and the updated section of the Administrator's Guide reflects these changes. Some Identity Providers make the Access Token expiration configurable, so this also aligns with expected integration behavior. I also rebased the pull request from the current main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703414#comment-17703414 ] ASF subversion and git services commented on NIFI-4651: --- Commit 663412547633d971845125130d3ae86b18586005 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6634125476 ] NIFI-4651 Corrected anonymous HashMap usage failing on Java 8 > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Kay-Uwe Moosheimer >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 2.0.0, 1.21.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11323) DBCPConnectionPool does not accept http protocol in driver location
[
https://issues.apache.org/jira/browse/NIFI-11323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Turcsanyi updated NIFI-11323:
---
Status: Patch Available (was: Open)
> DBCPConnectionPool does not accept http protocol in driver location
> ---
>
> Key: NIFI-11323
> URL: https://issues.apache.org/jira/browse/NIFI-11323
> Project: Apache NiFi
> Issue Type: Bug
>Reporter: Peter Turcsanyi
>Assignee: Peter Turcsanyi
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Before NIFI-8429 it was possible to provide an HTTP URL for {{Database Driver
> Location(s)}} property on {{DBCPConnectionPool}}.
> NIFI-8429 introduced {{dynamicallyModifiesClasspath(true)}} for the property
> and it seems it does not handle http:// urls properly.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] turcsanyip opened a new pull request, #7069: NIFI-11323: Fixed last modified change detection of dynamicallyModifi…
turcsanyip opened a new pull request, #7069: URL: https://github.com/apache/nifi/pull/7069 …esClasspath resources # Summary [NIFI-11323](https://issues.apache.org/jira/browse/NIFI-11323) All URLs were treated as file URLs which led to `java.lang.IllegalArgumentException: URI scheme is not "file"` Last modified time is checked for file:// URLs. No change detection for http(s):// URLs. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11318: Labels: dependency-upgrade (was: ) > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.21.0, 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11318: Component/s: Core Framework Extensions NiFi Registry > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Extensions, NiFi Registry >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Labels: dependency-upgrade > Fix For: 2.0.0, 1.21.0, 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-11318. - Fix Version/s: 2.0.0 1.21.0 1.latest 2.latest Resolution: Fixed > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Fix For: 2.0.0, 1.21.0, 1.latest, 2.latest > > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11318: Priority: Minor (was: Major) > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11318: Summary: Update Jackson to 2.14.2 (was: Update jackson.bom.version to 2.14.2) > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11318) Update Jackson to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11318: Affects Version/s: (was: 1.20.0) > Update Jackson to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Mike R >Assignee: Mike R >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11318) Update jackson.bom.version to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703387#comment-17703387 ] ASF subversion and git services commented on NIFI-11318: Commit a2995f334ee6b2caeafec1f49c5c32a5585551f9 in nifi's branch refs/heads/support/nifi-1.x from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a2995f334e ] NIFI-11318 Upgraded Jackson from 2.14.1 to 2.14.2 This closes #7066 Signed-off-by: David Handermann > Update jackson.bom.version to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11318) Update jackson.bom.version to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703386#comment-17703386 ] ASF subversion and git services commented on NIFI-11318: Commit 5883846e99a1a60fec42ef591292a957e8681fbe in nifi's branch refs/heads/main from mr1716 [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5883846e99 ] NIFI-11318 Upgraded Jackson from 2.14.1 to 2.14.2 This closes #7066 Signed-off-by: David Handermann > Update jackson.bom.version to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7066: NIFI-11318 Update jackson.bom.version to 2.14.2
exceptionfactory closed pull request #7066: NIFI-11318 Update jackson.bom.version to 2.14.2 URL: https://github.com/apache/nifi/pull/7066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11323) DBCPConnectionPool does not accept http protocol in driver location
Peter Turcsanyi created NIFI-11323:
--
Summary: DBCPConnectionPool does not accept http protocol in
driver location
Key: NIFI-11323
URL: https://issues.apache.org/jira/browse/NIFI-11323
Project: Apache NiFi
Issue Type: Bug
Reporter: Peter Turcsanyi
Assignee: Peter Turcsanyi
Before NIFI-8429 it was possible to provide an HTTP URL for {{Database Driver
Location(s)}} property on {{DBCPConnectionPool}}.
NIFI-8429 introduced {{dynamicallyModifiesClasspath(true)}} for the property
and it seems it does not handle http:// urls properly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI
lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143910399
##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
# CPPFLAGS are not recognized by cmake, so we have to force them to
CFLAGS and CXXFLAGS to have flex 2.6 working
./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS}
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}"
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
- name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+ ulimit -c 1024000
Review Comment:
Sorry my wording was bad. The bash is the default shell for all non-Windows
systems, MacOS included. It should be handled the same way as Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-11321) Instance identifiers are being saved to registry
[ https://issues.apache.org/jira/browse/NIFI-11321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende reassigned NIFI-11321: -- Assignee: (was: Bryan Bende) > Instance identifiers are being saved to registry > > > Key: NIFI-11321 > URL: https://issues.apache.org/jira/browse/NIFI-11321 > Project: Apache NiFi > Issue Type: Bug >Reporter: Bryan Bende >Priority: Minor > > It appears the intent of the code was to not save the instanceIdentifier > field when saving to registry, since the flow in registry is not specific to > any local NiFi instance ids. However, this field is being populated. It > doesn't not create any issues, but can make it look like many changes have > occurred if using git flow persistence and looking at diffs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 opened a new pull request, #7068: NIFI-11305: Fixed out-of-order handling of binlog client shutdown in CaptureChangeMySQL
mattyb149 opened a new pull request, #7068: URL: https://github.com/apache/nifi/pull/7068 # Summary [NIFI-11305](https://issues.apache.org/jira/browse/NIFI-11305) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [x] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (NIFI-11305) CaptureChangeMySQL does not stop if the queue is not empty
[ https://issues.apache.org/jira/browse/NIFI-11305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reopened NIFI-11305: - Reopening as there is an order-of-events bug where the binlog client waits on the event listener thread which no longer has anything pulling events off the queue. The event listener should be unregistered before the binlog client disconnects. > CaptureChangeMySQL does not stop if the queue is not empty > -- > > Key: NIFI-11305 > URL: https://issues.apache.org/jira/browse/NIFI-11305 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Matt Burgess >Assignee: Matt Burgess >Priority: Major > Fix For: 2.0.0, 1.21.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > There is a logic bug in the handling of stopping the CaptureChangeMySQL > processor. This causes it to not stop while there are events in the queue. If > the processor isn't running fast enough to drain the queue, stopping the > processor will have no effect. > The logic was being handled in OnStopped, but that won't get called until the > onTrigger has finished. Instead the loop should be checking to see if the > processor is still scheduled using isScheduled(), and if not should break out > of the loop and finish the onTrigger processing, thereby allowing the > OnStopped logic to be executed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11310) When Processor terminated, any resources that modify the classpath are not reloaded
[
https://issues.apache.org/jira/browse/NIFI-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703329#comment-17703329
]
ASF subversion and git services commented on NIFI-11310:
Commit 6adfb6131db831c9fa33bf1292b7b225482b0035 in nifi's branch
refs/heads/main from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6adfb6131d ]
NIFI-11310: Provide appropriate classpath resources to the ReloadComponent when
a processor is terminated
NIFI-11310: Fixed META-INF/services file that was mistakenly listing an extra
extension point, due to rebase
Signed-off-by: Matthew Burgess
This closes #7061
> When Processor terminated, any resources that modify the classpath are not
> reloaded
> ---
>
> Key: NIFI-11310
> URL: https://issues.apache.org/jira/browse/NIFI-11310
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Processors often provide Property Descriptors that can be used to modify the
> classpath. For example, processors may expose a property for specifying .jar
> files to load, such as JDBC drivers.
> When a Processor is terminated, though, and restarted, the Processor no
> longer has access to those additional classpath resources. The processor must
> have its properties modified in some way in order to re-establish those
> classpath resources. Otherwise, we see errors such as
> {{ClassNotFoundException}} being thrown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11310) When Processor terminated, any resources that modify the classpath are not reloaded
[
https://issues.apache.org/jira/browse/NIFI-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-11310:
Fix Version/s: 2.0.0
1.21.0
(was: 1.latest)
(was: 2.latest)
Resolution: Fixed
Status: Resolved (was: Patch Available)
> When Processor terminated, any resources that modify the classpath are not
> reloaded
> ---
>
> Key: NIFI-11310
> URL: https://issues.apache.org/jira/browse/NIFI-11310
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 2.0.0, 1.21.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Processors often provide Property Descriptors that can be used to modify the
> classpath. For example, processors may expose a property for specifying .jar
> files to load, such as JDBC drivers.
> When a Processor is terminated, though, and restarted, the Processor no
> longer has access to those additional classpath resources. The processor must
> have its properties modified in some way in order to re-establish those
> classpath resources. Otherwise, we see errors such as
> {{ClassNotFoundException}} being thrown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] mattyb149 closed pull request #7061: NIFI-11310: Provide appropriate classpath resources to the ReloadComp…
mattyb149 closed pull request #7061: NIFI-11310: Provide appropriate classpath resources to the ReloadComp… URL: https://github.com/apache/nifi/pull/7061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11310) When Processor terminated, any resources that modify the classpath are not reloaded
[
https://issues.apache.org/jira/browse/NIFI-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703328#comment-17703328
]
ASF subversion and git services commented on NIFI-11310:
Commit cece57268e69b0cbfaac41c4d3f6d92f7058daf7 in nifi's branch
refs/heads/support/nifi-1.x from Mark Payne
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cece57268e ]
NIFI-11310: Provide appropriate classpath resources to the ReloadComponent when
a processor is terminated
NIFI-11310: Fixed META-INF/services file that was mistakenly listing an extra
extension point, due to rebase
Signed-off-by: Matthew Burgess
> When Processor terminated, any resources that modify the classpath are not
> reloaded
> ---
>
> Key: NIFI-11310
> URL: https://issues.apache.org/jira/browse/NIFI-11310
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Processors often provide Property Descriptors that can be used to modify the
> classpath. For example, processors may expose a property for specifying .jar
> files to load, such as JDBC drivers.
> When a Processor is terminated, though, and restarted, the Processor no
> longer has access to those additional classpath resources. The processor must
> have its properties modified in some way in order to re-establish those
> classpath resources. Otherwise, we see errors such as
> {{ClassNotFoundException}} being thrown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11320) Upgrade Spring Framework to 5.3.26 and Spring Security to 5.8.2
[ https://issues.apache.org/jira/browse/NIFI-11320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11320: Fix Version/s: 1.latest 2.latest Status: Patch Available (was: Open) > Upgrade Spring Framework to 5.3.26 and Spring Security to 5.8.2 > --- > > Key: NIFI-11320 > URL: https://issues.apache.org/jira/browse/NIFI-11320 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, MiNiFi, NiFi Registry >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Labels: dependency-upgrade > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Spring Framework dependencies should be upgraded to > [5.3.26|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.26] > and Spring Security should be upgraded to > [5.8.2|https://github.com/spring-projects/spring-security/releases/tag/5.8.2] > to incorporate minor bug fixes and improvements over the current versions. > Spring Boot for NiFi Registry should be upgraded to > [2.7.9|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.9]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11322) ClusterSynchronization errors
[ https://issues.apache.org/jira/browse/NIFI-11322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Lord updated NIFI-11322: - Description: Environment: Small 3-node cluster; 4GB Heap/4 Cores per node See attachments referencing errors in both user.log and corresponding app.log. I'm not sure if these errors might be resolved in some of the tickets being addressed in 1.21.0? The only resolution was a restart of the node... attempts to re-sync the node through a UI level connection request failed. Of note the errors were seen within a Registry versioned ProcessGroup. 2023-03-21 02:43:16,574 INFO [Reconnect to Cluster] o.a.nifi.controller.StandardFlowService Node disconnected due to Failed to properly handle Reconnection request due to org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. 2023-03-21 02:43:16,574 ERROR [Reconnect to Cluster] o.a.nifi.controller.StandardFlowService Handling reconnection request failed due to: org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. at org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:1059) at org.apache.nifi.controller.StandardFlowService.handleReconnectionRequest(StandardFlowService.java:667) at org.apache.nifi.controller.StandardFlowService.access$200(StandardFlowService.java:107) at org.apache.nifi.controller.StandardFlowService$1.run(StandardFlowService.java:396) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: org.apache.nifi.controller.serialization.FlowSynchronizationException: java.lang.IllegalStateException: Upstream component of Connection (PutS3Object[id=9fcf34ef-d59e-16bc-9e3c-7c619c5e40af]) is running at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:447) at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.sync(VersionedFlowSynchronizer.java:205) at org.apache.nifi.controller.serialization.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:42) at org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1525) at org.apache.nifi.persistence.StandardFlowConfigurationDAO.load(StandardFlowConfigurationDAO.java:104) at org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:817) at org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:1028) ... 4 common frames omitted Caused by: java.lang.IllegalStateException: Upstream component of Connection (PutS3Object[id=9fcf34ef-d59e-16bc-9e3c-7c619c5e40af]) is running at org.apache.nifi.connectable.StandardConnection.verifySourceStoppedOrFunnel(StandardConnection.java:529) at org.apache.nifi.connectable.StandardConnection.verifyCanDelete(StandardConnection.java:510) at org.apache.nifi.groups.StandardProcessGroup.removeConnection(StandardProcessGroup.java:1375) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.removeMissingConnections(StandardVersionedComponentSynchronizer.java:619) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:383) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:537) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:411) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.lambda$synchronize$0(StandardVersionedComponentSynchronizer.java:255) at org.apache.nifi.controller.flow.AbstractFlowManager.withParameterContextResolution(AbstractFlowManager.java:550) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:253) at org.apache.nifi.groups.StandardProcessGroup.synchronizeFlow(StandardProcessGroup.java:3970) at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:438) ... 10 common frames omitted was: Environment: Small 3-node
[GitHub] [nifi] exceptionfactory opened a new pull request, #7067: NIFI-11320 Upgrade Spring Framework from 5.3.24 to 5.3.26
exceptionfactory opened a new pull request, #7067: URL: https://github.com/apache/nifi/pull/7067 # Summary [NIFI-11320](https://issues.apache.org/jira/browse/NIFI-11320) Upgrades Spring Framework dependencies from 5.3.24 to [5.3.26](https://github.com/spring-projects/spring-framework/releases/tag/v5.3.26). Changes also include the following related upgrades: - Upgraded Spring Security from 5.8.0 to [5.8.2](https://github.com/spring-projects/spring-security/releases/tag/5.8.2) - Upgraded Spring Boot from 2.7.6 to [2.7.9](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.9) for NiFi Registry # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [X] Build completed using `mvn clean install -P contrib-check` - [X] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11322) ClusterSynchronization errors
Phil Lord created NIFI-11322: Summary: ClusterSynchronization errors Key: NIFI-11322 URL: https://issues.apache.org/jira/browse/NIFI-11322 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.19.1 Reporter: Phil Lord Attachments: CorrespondingApp.log, StackTraceFromUser.log Environment: Small 3-node cluster; 4GB Heap/4 Cores per node See attachments referencing errors in both user.log and corresponding app.log. I'm not sure if these errors might be resolved in some of the tickets being addressed in 1.21.0? The only resolution was a restart of the node... attempts to re-sync the node through a UI level connection request failed. 2023-03-21 02:43:16,574 INFO [Reconnect to Cluster] o.a.nifi.controller.StandardFlowService Node disconnected due to Failed to properly handle Reconnection request due to org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. 2023-03-21 02:43:16,574 ERROR [Reconnect to Cluster] o.a.nifi.controller.StandardFlowService Handling reconnection request failed due to: org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. org.apache.nifi.controller.serialization.FlowSynchronizationException: Failed to connect node to cluster because local flow controller partially updated. Administrator should disconnect node and review flow for corruption. at org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:1059) at org.apache.nifi.controller.StandardFlowService.handleReconnectionRequest(StandardFlowService.java:667) at org.apache.nifi.controller.StandardFlowService.access$200(StandardFlowService.java:107) at org.apache.nifi.controller.StandardFlowService$1.run(StandardFlowService.java:396) at java.base/java.lang.Thread.run(Thread.java:829) Caused by: org.apache.nifi.controller.serialization.FlowSynchronizationException: java.lang.IllegalStateException: Upstream component of Connection (PutS3Object[id=9fcf34ef-d59e-16bc-9e3c-7c619c5e40af]) is running at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:447) at org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.sync(VersionedFlowSynchronizer.java:205) at org.apache.nifi.controller.serialization.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:42) at org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1525) at org.apache.nifi.persistence.StandardFlowConfigurationDAO.load(StandardFlowConfigurationDAO.java:104) at org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:817) at org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:1028) ... 4 common frames omitted Caused by: java.lang.IllegalStateException: Upstream component of Connection (PutS3Object[id=9fcf34ef-d59e-16bc-9e3c-7c619c5e40af]) is running at org.apache.nifi.connectable.StandardConnection.verifySourceStoppedOrFunnel(StandardConnection.java:529) at org.apache.nifi.connectable.StandardConnection.verifyCanDelete(StandardConnection.java:510) at org.apache.nifi.groups.StandardProcessGroup.removeConnection(StandardProcessGroup.java:1375) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.removeMissingConnections(StandardVersionedComponentSynchronizer.java:619) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:383) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:537) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:411) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.lambda$synchronize$0(StandardVersionedComponentSynchronizer.java:255) at org.apache.nifi.controller.flow.AbstractFlowManager.withParameterContextResolution(AbstractFlowManager.java:550) at org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:253) at org.apache.nifi.groups.StandardProcessGroup.synchronizeFlow(StandardProcessGroup.java:3970) at
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI
szaszm commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143757096
##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
# CPPFLAGS are not recognized by cmake, so we have to force them to
CFLAGS and CXXFLAGS to have flex 2.6 working
./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS}
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}"
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
- name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+ ulimit -c 1024000
Review Comment:
This comment was on the mac job, but the rest is linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-11321) Instance identifiers are being saved to registry
Bryan Bende created NIFI-11321: -- Summary: Instance identifiers are being saved to registry Key: NIFI-11321 URL: https://issues.apache.org/jira/browse/NIFI-11321 Project: Apache NiFi Issue Type: Bug Reporter: Bryan Bende Assignee: Bryan Bende It appears the intent of the code was to not save the instanceIdentifier field when saving to registry, since the flow in registry is not specific to any local NiFi instance ids. However, this field is being populated. It doesn't not create any issues, but can make it look like many changes have occurred if using git flow persistence and looking at diffs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1530: MINIFICPP-2018 Add ProcessContext::getStateManager to Lua/Python
martinzink commented on code in PR #1530:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1530#discussion_r1143713557
##
extensions/python/types/PyStateManager.cpp:
##
@@ -0,0 +1,103 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+a * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "PyStateManager.h"
+#include
+#include "PyException.h"
+
+extern "C" {
+namespace org::apache::nifi::minifi::extensions::python {
+
+static PyMethodDef PyStateManager_methods[] = {
Review Comment:
It follows the other PyObject naming convention (e.g.
https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/python/types/PyLogger.cpp#L24)
But we should probably change those aswell, because looking at them they are
not very consistent with themselves and definetly not with the google
styleguide.
I will create a ticket to remedy this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-11320) Upgrade Spring Framework to 5.3.26 and Spring Security to 5.8.2
David Handermann created NIFI-11320: --- Summary: Upgrade Spring Framework to 5.3.26 and Spring Security to 5.8.2 Key: NIFI-11320 URL: https://issues.apache.org/jira/browse/NIFI-11320 Project: Apache NiFi Issue Type: Improvement Components: Core Framework, MiNiFi, NiFi Registry Reporter: David Handermann Assignee: David Handermann Spring Framework dependencies should be upgraded to [5.3.26|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.26] and Spring Security should be upgraded to [5.8.2|https://github.com/spring-projects/spring-security/releases/tag/5.8.2] to incorporate minor bug fixes and improvements over the current versions. Spring Boot for NiFi Registry should be upgraded to [2.7.9|https://github.com/spring-projects/spring-boot/releases/tag/v2.7.9]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1530: MINIFICPP-2018 Add ProcessContext::getStateManager to Lua/Python
martinzink commented on code in PR #1530:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1530#discussion_r1143708657
##
extensions/lua/LuaScriptProcessContext.h:
##
@@ -22,18 +22,22 @@
#include
#include "core/ProcessSession.h"
+#include "LuaScriptStateManager.h"
namespace org::apache::nifi::minifi::extensions::lua {
class LuaScriptProcessContext {
public:
- explicit LuaScriptProcessContext(std::shared_ptr
context);
+ explicit LuaScriptProcessContext(std::shared_ptr
context, sol::state* sol_state);
std::string getProperty(const std::string );
void releaseProcessContext();
+ LuaScriptStateManager getStateManager();
+
private:
std::shared_ptr context_;
+ sol::state* sol_state_;
Review Comment:
Good idea, changed it in
https://github.com/apache/nifi-minifi-cpp/pull/1530/commits/3d43afd375b5bd6b8eb7dc0941dbfffef1fb54cd#diff-9f8d275abddb72f4021d1991f38a30ecdac5ab9831c7b01c3460009ec0ff780aR38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1530: MINIFICPP-2018 Add ProcessContext::getStateManager to Lua/Python
martinzink commented on code in PR #1530:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1530#discussion_r1143708270
##
extensions/python/PythonBindings.cpp:
##
@@ -43,15 +44,16 @@ struct PyModuleDef minifi_module = {
PyMODINIT_FUNC
PyInit_minifi_native(void) {
- const std::array, 8> types = {
+ const std::array, 9> types = {
Review Comment:
good idea, I've included this in
https://github.com/apache/nifi-minifi-cpp/pull/1530/commits/3d43afd375b5bd6b8eb7dc0941dbfffef1fb54cd#diff-9ab8cf198832c627eb6357bece7d822ae40cdef59fbd10881ffecfe7ffd5e93cR47-R57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI
lordgamez commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143708215
##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
# CPPFLAGS are not recognized by cmake, so we have to force them to
CFLAGS and CXXFLAGS to have flex 2.6 working
./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS}
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}"
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
- name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+ ulimit -c 1024000
Review Comment:
On github actions the shell defaults to bash on Linux systems, so it should
use 1024 byte increments. I clarified the size and changed it to 1GiB in
1c5e45eb79f07cd70c9509ea23e2ff063f122ea3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] mcgilman commented on pull request #7013: NIFI-4890 Refactor OIDC with support for Refresh Tokens
mcgilman commented on PR #7013: URL: https://github.com/apache/nifi/pull/7013#issuecomment-1478228509 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #7051: NIFI-11255 Allowable value for 'Use s3.region Attribute'
krisztina-zsihovszki commented on code in PR #7051:
URL: https://github.com/apache/nifi/pull/7051#discussion_r1143701000
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSProcessor.java:
##
@@ -312,21 +312,9 @@ public void onTrigger(final ProcessContext context, final
ProcessSessionFactory
*/
public abstract void onTrigger(final ProcessContext context, final
ProcessSession session) throws ProcessException;
-protected Region getRegionAndInitializeEndpoint(final ProcessContext
context, final AmazonWebServiceClient client) {
-final Region region;
-// if the processor supports REGION, get the configured region.
-if (getSupportedPropertyDescriptors().contains(REGION)) {
-final String regionValue = context.getProperty(REGION).getValue();
-if (regionValue != null) {
-region = Region.getRegion(Regions.fromName(regionValue));
-if (client != null) {
-client.setRegion(region);
-}
-} else {
-region = null;
-}
-} else {
-region = null;
+protected void initializeEndpoint(final Region region, final
ProcessContext context, final AmazonWebServiceClient client) {
Review Comment:
Usually the region is taken from the context but in case it is is defined in
the incoming flow file's 's3.region' attribute, it can not be fetched from the
context.
This method is invoked by AbstractS3Processor specially, where the region
can be taken from the flow file attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI
szaszm commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143684236
##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
# CPPFLAGS are not recognized by cmake, so we have to force them to
CFLAGS and CXXFLAGS to have flex 2.6 working
./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS}
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}"
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
- name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+ ulimit -c 1024000
Review Comment:
According to POSIX, `ulimit -c` is specified in 512 byte increments, but the
bash man page specifies 1024 byte increments, except when in posix mode. I
don't know which limit applies here, so I think it would be nice to clarify it
in a comment, what this limit means in terms of data size. 500 MiB or 1000 MiB?
If the mixing of binary and decimal multiples feel arbitrary to you as well,
consider slightly increasing the number to 1048576 (2^20)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1511: MINIFICPP-1716 Recover core dumps from CI
szaszm commented on code in PR #1511:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#discussion_r1143684236
##
.github/workflows/ci.yml:
##
@@ -39,9 +39,26 @@ jobs:
# CPPFLAGS are not recognized by cmake, so we have to force them to
CFLAGS and CXXFLAGS to have flex 2.6 working
./bootstrap.sh -e -t && cd build && cmake
-DCMAKE_BUILD_TYPE=Release -DCI_BUILD=ON -DCMAKE_C_FLAGS="${CPPFLAGS}
${CFLAGS}" -DCMAKE_CXX_FLAGS="${CPPFLAGS} ${CXXFLAGS}"
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_SQL=ON
-DUSE_REAL_ODBC_TEST_DRIVER=ON -DENABLE_AZURE=ON -DENABLE_GCP=ON
-DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_RULE_MESSAGES=OFF -DSTRICT_GSL_CHECKS=AUDIT
-DFAIL_ON_WARNINGS=ON .. && cmake --build . --parallel 4
- name: test
-run: cd build && make test ARGS="--timeout 300 -j4 --output-on-failure"
+id: test
+run: |
+ ulimit -c 1024000
Review Comment:
According to POSIX, `ulimit -c` is specified in 512 byte increments, but the
bash man page specifies 1024 byte increments, except when in posix mode. I
don't know which limit applies here, so I think it would be nice to clarify it
in a comment, what this limit means in terms of data size. 500 MiB or 1000 MiB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-7123) onPropertyModified() is called on nifi start up even when properties have never been modified
[ https://issues.apache.org/jira/browse/NIFI-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703273#comment-17703273 ] Nissim Shiman commented on NIFI-7123: - Thank you [~markap14] for the background information and the best practices pattern to deal with situation. At this point this is looking like maybe a tweak to the api document just to clarify that it is meant to always run on startup. Thank you for your comment! > onPropertyModified() is called on nifi start up even when properties have > never been modified > - > > Key: NIFI-7123 > URL: https://issues.apache.org/jira/browse/NIFI-7123 > Project: Apache NiFi > Issue Type: Bug >Affects Versions: 1.11.0 >Reporter: Nissim Shiman >Priority: Major > > Processors and Controller Services inherit the onPropertyModified() method > from ConfigurableComponent. java [1] > This method is called when nifi starts for all processors and controller > services, even for properties that are set to their defaults (i.e. have never > been modified). > [1] > https://github.com/apache/nifi/blob/master/nifi-api/src/main/java/org/apache/nifi/components/ConfigurableComponent.java#L68 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-1713) Repotests sometimes segfault in CI
[
https://issues.apache.org/jira/browse/MINIFICPP-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1713:
-
Fix Version/s: 0.14.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Repotests sometimes segfault in CI
> --
>
> Key: MINIFICPP-1713
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1713
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Fix For: 0.14.0
>
> Attachments: RepoTests_segfault.log
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Repotests failed with the following message in CI:
> {code:java}
> ~~~
> RepoTests is a Catch v2.13.10 host application.
> Run with -? for
> options---
> Flush deleted flowfiles before shutdown
> ---
> /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/rocksdb-tests/RepoTests.cpp:343
> .../home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/rocksdb-tests/RepoTests.cpp:343:
> FAILED:
> {Unknown expression after the reported line}
> due to a fatal error condition:
> SIGSEGV - Segmentation violation signal {code}
> Logs attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
fgerlits closed pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests URL: https://github.com/apache/nifi-minifi-cpp/pull/1537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1536: MINIFICPP-2075 Fix flaky PutTCPTests testcase
fgerlits closed pull request #1536: MINIFICPP-2075 Fix flaky PutTCPTests testcase URL: https://github.com/apache/nifi-minifi-cpp/pull/1536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1534: MINIFICPP-2079 Fix OOM in python.feature
fgerlits closed pull request #1534: MINIFICPP-2079 Fix OOM in python.feature URL: https://github.com/apache/nifi-minifi-cpp/pull/1534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4651: --- Fix Version/s: 2.0.0 1.21.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Kay-Uwe Moosheimer >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 2.0.0, 1.21.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mattyb149 commented on pull request #7007: NIFI-4651 Add error message and code to PutSQL FlowFile attributes
mattyb149 commented on PR #7007: URL: https://github.com/apache/nifi/pull/7007#issuecomment-1478034229 +1 LGTM, Merging to main and support/nifi-1.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #7007: NIFI-4651 Add error message and code to PutSQL FlowFile attributes
mattyb149 closed pull request #7007: NIFI-4651 Add error message and code to PutSQL FlowFile attributes URL: https://github.com/apache/nifi/pull/7007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703257#comment-17703257 ] ASF subversion and git services commented on NIFI-4651: --- Commit 5267a533bb91942fbe587e6cda163ffc4d71e591 in nifi's branch refs/heads/support/nifi-1.x from krisztina-zsihovszki [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=5267a533bb ] NIFI-4651 Add error message and code to PutSQL FlowFile attributes NIFI-4651 Review comments Signed-off-by: Matthew Burgess This closes #7007 > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Kay-Uwe Moosheimer >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703256#comment-17703256 ] ASF subversion and git services commented on NIFI-4651: --- Commit 63e9365449422b6eb35b5960c68ab80a9cfa5e11 in nifi's branch refs/heads/main from krisztina-zsihovszki [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=63e9365449 ] NIFI-4651 Add error message and code to PutSQL FlowFile attributes NIFI-4651 Review comments Signed-off-by: Matthew Burgess > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Kay-Uwe Moosheimer >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-4890) OIDC Token Refresh should be supported
[ https://issues.apache.org/jira/browse/NIFI-4890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-4890: --- Fix Version/s: 2.latest > OIDC Token Refresh should be supported > -- > > Key: NIFI-4890 > URL: https://issues.apache.org/jira/browse/NIFI-4890 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 > Environment: Environment: > Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) > >Reporter: Federico Michele Facca >Assignee: David Handermann >Priority: Major > Fix For: 2.latest > > Attachments: image-2022-10-20-12-23-38-675.png > > Time Spent: 10m > Remaining Estimate: 0h > > It looks like the NIFI UI is not refreshing the OIDC token in background, and > because of that, when the token expires, tells you that your session is > expired. and you need to refresh the page, to get a new token. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-11297) Prometheus Reporting Task throws a NullPointerException for Stateless NiFi
[ https://issues.apache.org/jira/browse/NIFI-11297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephanie Ambrose resolved NIFI-11297. -- Assignee: Stephanie Ambrose Resolution: Not A Problem [https://github.com/apache/nifi/tree/main/nifi-stateless/nifi-stateless-assembly#reporting-tasks] ^ This could use some verbiage on required properties for specific reporting tasks The nifi.stateless.reporting.task.prometheus.frequency=10 sec ...property sets the getSchedulingPeriod method on the ReportingTaskNode class, which throws a NullPointerException without it. > Prometheus Reporting Task throws a NullPointerException for Stateless NiFi > -- > > Key: NIFI-11297 > URL: https://issues.apache.org/jira/browse/NIFI-11297 > Project: Apache NiFi > Issue Type: Bug >Reporter: Stephanie Ambrose >Assignee: Stephanie Ambrose >Priority: Critical > > When configuring the Prometheus reporting task for Stateless NiFi, a > NullPointerException is thown and it does not work. > Here are my config properties: > nifi.stateless.reporting.task.prometheus.name=Prometheus > nifi.stateless.reporting.task.prometheus.type=PrometheusReportingTask > nifi.stateless.reporting.task.prometheus.bundle=org.apache.nifi:nifi-prometheus-nar:1.12.1 > nifi.stateless.reporting.task.prometheus.properties.prometheus-reporting-task-metrics-endpoint-port=9100 > nifi.stateless.reporting.task.prometheus.properties.prometheus-reporting-task-instance-id=statelessNiFi1 > nifi.stateless.reporting.task.prometheus.properties.prometheus-reporting-task-metrics-strategy=All > Components > nifi.stateless.reporting.task.prometheus.properties.prometheus-reporting-task-metrics-send-jvm=false > nifi.stateless.reporting.task.prometheus.properties.prometheus-reporting-task-client-auth=No > Authentication > And here is the error that is thrown to my Prometheus server: > HTTP ERROR 500 java.lang.NullPointerException > URI: /metrics/ > STATUS: 500 > MESSAGE: java.lang.NullPointerException > SERVLET: > org.apache.nifi.reporting.prometheus.PrometheusServer$MetricsServlet-6d1c2fd6 > CAUSED BY:java.lang.NullPointerException > Caused by: > java.lang.NullPointerException > at > org.apache.nifi.reporting.prometheus.PrometheusReportingTask.lambda$onScheduled$0(PrometheusReportingTask.java:133) > at > org.apache.nifi.reporting.prometheus.PrometheusServer$MetricsServlet.doGet(PrometheusServer.java:69) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > at > org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799) > at > org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:233) > at > org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1440) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:188) > at > org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:505) > at > org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:186) > at > org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1355) > at > org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) > at > org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:127) > at org.eclipse.jetty.server.Server.handle(Server.java:516) > at > org.eclipse.jetty.server.HttpChannel.lambda$handle$1(HttpChannel.java:487) > at org.eclipse.jetty.server.HttpChannel.dispatch(HttpChannel.java:732) > at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:479) > at > org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:277) > at > org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:311) > at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:105) > at org.eclipse.jetty.io.ChannelEndPoint$1.run(ChannelEndPoint.java:104) > at > org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:883) > at > org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1034) > at java.base/java.lang.Thread.run(Thread.java:829) > > We intend to use the Prometheus reporting task in Stateless NiFi for HPA and > pod health, so for us this would be a critical bug fix. > > Thanks! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2074) fix config validators
[ https://issues.apache.org/jira/browse/MINIFICPP-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-2074: -- Assignee: Martin Zink > fix config validators > - > > Key: MINIFICPP-2074 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2074 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Marton Szasz >Assignee: Martin Zink >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI
martinzink commented on code in PR #1538:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1143496902
##
.github/workflows/ci.yml:
##
@@ -223,13 +227,132 @@ jobs:
if [ -d ~/.ccache ]; then mv ~/.ccache .; fi
mkdir build
cd build
- cmake -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON
-DDISABLE_JEMALLOC=ON -DENABLE_AWS=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_MQTT=ON
-DENABLE_AZURE=ON -DENABLE_SQL=ON \
- -DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON
-DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
- -DDOCKER_BUILD_ONLY=ON
-DDOCKER_CCACHE_DUMP_LOCATION=$HOME/.ccache ..
+ cmake ${DOCKER_CMAKE_FLAGS} ..
make docker
+ - name: Save docker image
+run: cd build && docker save -o minifi_docker.tar
apacheminificpp:0.13.0
Review Comment:
It wasnt super simple to go with the suggested route, because this
versioning-scheme is used/anticipated in multiple places.
Found a simpler method though: [we can simply extract the version from
CMake](https://github.com/apache/nifi-minifi-cpp/pull/1538/commits/6a7cd955d9c0e37815ee27ab2dfcf149a0b932cb).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-9330) Add support for Kafka 3.0
[ https://issues.apache.org/jira/browse/NIFI-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Grey updated NIFI-9330: Resolution: Abandoned Status: Resolved (was: Patch Available) Abandoned in favor of NIFI-11259. > Add support for Kafka 3.0 > - > > Key: NIFI-9330 > URL: https://issues.apache.org/jira/browse/NIFI-9330 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Labels: kafka, processor > Time Spent: 1h 40m > Remaining Estimate: 0h > > Kafka 3.0 released in September 2021. > [https://kafka.apache.org/downloads] > As a major version release, it is anticipated that new features have been > added, and that deprecations and incompatibilities may need to be addressed. > This work effort will likely take the form of new maven sibling modules to > the existing 2.6 implementation: > [https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors] > [https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-nar] > The existing kafka support will remain in order to provide compatibility with > previous versions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-9330) Add support for Kafka 3.0
[ https://issues.apache.org/jira/browse/NIFI-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703234#comment-17703234 ] Paul Grey commented on NIFI-9330: - After discussion, the plan is to do work under NIFI-11259, to support Kafka 3, and future versions of Kafka. > Add support for Kafka 3.0 > - > > Key: NIFI-9330 > URL: https://issues.apache.org/jira/browse/NIFI-9330 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Paul Grey >Assignee: Paul Grey >Priority: Minor > Labels: kafka, processor > Time Spent: 1h 40m > Remaining Estimate: 0h > > Kafka 3.0 released in September 2021. > [https://kafka.apache.org/downloads] > As a major version release, it is anticipated that new features have been > added, and that deprecations and incompatibilities may need to be addressed. > This work effort will likely take the form of new maven sibling modules to > the existing 2.6 implementation: > [https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors] > [https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-nar] > The existing kafka support will remain in order to provide compatibility with > previous versions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] nandorsoma commented on pull request #7032: NIFI-11270 Refactoring of the overly Paho-specific MQTT interface
nandorsoma commented on PR #7032: URL: https://github.com/apache/nifi/pull/7032#issuecomment-1477940590 Thanks for your review @Lehel44! As you requested, I've addressed your comments and added a description to the Jira ticket! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on pull request #7032: NIFI-11270 Refactoring of the overly Paho-specific MQTT interface
nandorsoma commented on PR #7032: URL: https://github.com/apache/nifi/pull/7032#issuecomment-1477939848 Thanks for your review! As you requested, I've addressed your comments and added a description to the Jira ticket! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-11270) Refactoring of the overly Paho-specific MQTT interface
[ https://issues.apache.org/jira/browse/NIFI-11270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Soma Abonyi updated NIFI-11270: -- Description: ConsumeMQTT processor implements the MqttClient interface, which follows the signature of the Paho library's MqttClient interface. There are two issues with that. It mixes two types of behavior because the client itself can act as a publisher and subscriber parallelly. However, in NiFi, these two roles are separated into different processors. So it doesn't make sense to implement the subscribe interface in PublishMQTT, and it also doesn't make sense to implement deliveryComplete in ConsumeMQTT. The other issue is that these interfaces cannot be used with the HiveMQ client except messageArrived(). Because of the above, we need to move the existing implementation into the Paho adapter (because it is still required for logging) and create a new interface for handling incoming messages. > Refactoring of the overly Paho-specific MQTT interface > -- > > Key: NIFI-11270 > URL: https://issues.apache.org/jira/browse/NIFI-11270 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Nandor Soma Abonyi >Assignee: Nandor Soma Abonyi >Priority: Minor > Labels: mqtt > Fix For: 1.latest, 2.latest > > Time Spent: 50m > Remaining Estimate: 0h > > ConsumeMQTT processor implements the MqttClient interface, which follows the > signature of the Paho library's MqttClient interface. There are two issues > with that. It mixes two types of behavior because the client itself can act > as a publisher and subscriber parallelly. However, in NiFi, these two roles > are separated into different processors. So it doesn't make sense to > implement the subscribe interface in PublishMQTT, and it also doesn't make > sense to implement deliveryComplete in ConsumeMQTT. > The other issue is that these interfaces cannot be used with the HiveMQ > client except messageArrived(). Because of the above, we need to move the > existing implementation into the Paho adapter (because it is still required > for logging) and create a new interface for handling incoming messages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-11319) Fixing TestStatelessBootstrap::testClassNotAllowed
Simon Bence created NIFI-11319: -- Summary: Fixing TestStatelessBootstrap::testClassNotAllowed Key: NIFI-11319 URL: https://issues.apache.org/jira/browse/NIFI-11319 Project: Apache NiFi Issue Type: Bug Components: NiFi Stateless Reporter: Simon Bence Assignee: Simon Bence "TestStatelessBootstrap::testClassNotAllowed" is broken due to the given class is part of the allowed list. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1539: MINIFICPP-2037 Build SSLContext from minifi.properties for SSL commuincation on C2
lordgamez opened a new pull request, #1539: URL: https://github.com/apache/nifi-minifi-cpp/pull/1539 https://issues.apache.org/jira/browse/MINIFICPP-2037 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on a diff in pull request #7032: NIFI-11270 Refactoring of the overly Paho-specific MQTT interface
nandorsoma commented on code in PR #7032:
URL: https://github.com/apache/nifi/pull/7032#discussion_r1143366825
##
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/ConsumeMQTT.java:
##
@@ -383,9 +383,8 @@ private void initializeClient(ProcessContext context) {
// non-null but not connected, so we need to handle each case and only
create a new client when it is null
try {
mqttClient = createMqttClient();
-mqttClient.setCallback(this);
mqttClient.connect();
-mqttClient.subscribe(topicPrefix + topicFilter, qos);
+mqttClient.subscribe(topicPrefix + topicFilter, qos, this);
Review Comment:
It was a consequence of the original implementation, but you are right. We
no longer need to implement the interface on the processor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-11311) Upgrade maven-antrun-plugin to 3.1.0 across all modules
[
https://issues.apache.org/jira/browse/NIFI-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11311:
Fix Version/s: 2.0.0
1.21.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade maven-antrun-plugin to 3.1.0 across all modules
> ---
>
> Key: NIFI-11311
> URL: https://issues.apache.org/jira/browse/NIFI-11311
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 2.0.0, 1.21.0, 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{maven-antrun-plugin}} is used in several module builds (e.g. to copy
> files for a Docker Image build), but the version is inconsistent across
> modules and is very old in some cases.
> Current latest is {{3.1.0}}, we should look to upgrade to that across all
> modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11311) Upgrade maven-antrun-plugin to 3.1.0 across all modules
[
https://issues.apache.org/jira/browse/NIFI-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-11311:
Summary: Upgrade maven-antrun-plugin to 3.1.0 across all modules (was:
Upgrade maven-antrun-plugin version)
> Upgrade maven-antrun-plugin to 3.1.0 across all modules
> ---
>
> Key: NIFI-11311
> URL: https://issues.apache.org/jira/browse/NIFI-11311
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{maven-antrun-plugin}} is used in several module builds (e.g. to copy
> files for a Docker Image build), but the version is inconsistent across
> modules and is very old in some cases.
> Current latest is {{3.1.0}}, we should look to upgrade to that across all
> modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11264) Improve logging in list processors and fix ListFile's description
[ https://issues.apache.org/jira/browse/NIFI-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11264: Fix Version/s: 2.0.0 1.21.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Improve logging in list processors and fix ListFile's description > - > > Key: NIFI-11264 > URL: https://issues.apache.org/jira/browse/NIFI-11264 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Nandor Soma Abonyi >Assignee: Nandor Soma Abonyi >Priority: Minor > Labels: ListFile > Fix For: 2.0.0, 1.21.0, 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > There were a few cases where the ListFile processor yielded, and it was hard > to guess the reason without additional logs. I added those missing logs and > fixed the description of the ListFile processor. > > *Target branches: main, support/nifi-1x* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11264) Improve logging in list processors and fix ListFile's description
[ https://issues.apache.org/jira/browse/NIFI-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703194#comment-17703194 ] ASF subversion and git services commented on NIFI-11264: Commit 69afe7fd8d7880f41615c3bb7fffb92d2bc4780f in nifi's branch refs/heads/support/nifi-1.x from Nandor Soma Abonyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=69afe7fd8d ] NIFI-11264 Added debug logs for List Processor yielding - Corrected ListFile Processor description This closes #7027 Signed-off-by: David Handermann > Improve logging in list processors and fix ListFile's description > - > > Key: NIFI-11264 > URL: https://issues.apache.org/jira/browse/NIFI-11264 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Nandor Soma Abonyi >Assignee: Nandor Soma Abonyi >Priority: Minor > Labels: ListFile > Fix For: 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > There were a few cases where the ListFile processor yielded, and it was hard > to guess the reason without additional logs. I added those missing logs and > fixed the description of the ListFile processor. > > *Target branches: main, support/nifi-1x* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-11311) Upgrade maven-antrun-plugin version
[
https://issues.apache.org/jira/browse/NIFI-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703195#comment-17703195
]
ASF subversion and git services commented on NIFI-11311:
Commit 8c13121e3df2e1766e319f797eb635da74352391 in nifi's branch
refs/heads/support/nifi-1.x from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=8c13121e3d ]
NIFI-11311 Updated maven-antrun-plugin to 3.1.0 across all modules
This closes #7062
Signed-off-by: David Handermann
> Upgrade maven-antrun-plugin version
> ---
>
> Key: NIFI-11311
> URL: https://issues.apache.org/jira/browse/NIFI-11311
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{maven-antrun-plugin}} is used in several module builds (e.g. to copy
> files for a Docker Image build), but the version is inconsistent across
> modules and is very old in some cases.
> Current latest is {{3.1.0}}, we should look to upgrade to that across all
> modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11311) Upgrade maven-antrun-plugin version
[
https://issues.apache.org/jira/browse/NIFI-11311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703192#comment-17703192
]
ASF subversion and git services commented on NIFI-11311:
Commit d604c87247f489828b2f641e1924631eba95d87d in nifi's branch
refs/heads/main from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d604c87247 ]
NIFI-11311 Updated maven-antrun-plugin to 3.1.0 across all modules
This closes #7062
Signed-off-by: David Handermann
> Upgrade maven-antrun-plugin version
> ---
>
> Key: NIFI-11311
> URL: https://issues.apache.org/jira/browse/NIFI-11311
> Project: Apache NiFi
> Issue Type: Task
>Reporter: Chris Sampson
>Assignee: Chris Sampson
>Priority: Minor
> Fix For: 1.latest, 2.latest
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The {{maven-antrun-plugin}} is used in several module builds (e.g. to copy
> files for a Docker Image build), but the version is inconsistent across
> modules and is very old in some cases.
> Current latest is {{3.1.0}}, we should look to upgrade to that across all
> modules.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11264) Improve logging in list processors and fix ListFile's description
[ https://issues.apache.org/jira/browse/NIFI-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703191#comment-17703191 ] ASF subversion and git services commented on NIFI-11264: Commit 4e602ce40f981928e224cf2e771b225f756521ce in nifi's branch refs/heads/main from Nandor Soma Abonyi [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4e602ce40f ] NIFI-11264 Added debug logs for List Processor yielding - Corrected ListFile Processor description This closes #7027 Signed-off-by: David Handermann > Improve logging in list processors and fix ListFile's description > - > > Key: NIFI-11264 > URL: https://issues.apache.org/jira/browse/NIFI-11264 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Nandor Soma Abonyi >Assignee: Nandor Soma Abonyi >Priority: Minor > Labels: ListFile > Fix For: 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > There were a few cases where the ListFile processor yielded, and it was hard > to guess the reason without additional logs. I added those missing logs and > fixed the description of the ListFile processor. > > *Target branches: main, support/nifi-1x* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7027: NIFI-11264 Improve logging in list processors and fix ListFile's description
exceptionfactory closed pull request #7027: NIFI-11264 Improve logging in list processors and fix ListFile's description URL: https://github.com/apache/nifi/pull/7027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7062: NIFI-11311 update maven-antrun-plugin and rationalise version across all modules
exceptionfactory closed pull request #7062: NIFI-11311 update maven-antrun-plugin and rationalise version across all modules URL: https://github.com/apache/nifi/pull/7062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11318) Update jackson.bom.version to 2.14.2
[ https://issues.apache.org/jira/browse/NIFI-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike R reassigned NIFI-11318: - Assignee: Mike R > Update jackson.bom.version to 2.14.2 > > > Key: NIFI-11318 > URL: https://issues.apache.org/jira/browse/NIFI-11318 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Mike R >Assignee: Mike R >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7066: NIFI-11318 Update jackson.bom.version to 2.14.2
mr1716 opened a new pull request, #7066: URL: https://github.com/apache/nifi/pull/7066 # Summary [NIFI-11318](https://issues.apache.org/jira/browse/NIFI-11318) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-11318) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 11 - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-11318) Update jackson.bom.version to 2.14.2
Mike R created NIFI-11318: - Summary: Update jackson.bom.version to 2.14.2 Key: NIFI-11318 URL: https://issues.apache.org/jira/browse/NIFI-11318 Project: Apache NiFi Issue Type: Improvement Affects Versions: 1.20.0 Reporter: Mike R Update jackson.bom.version to 2.14.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI
szaszm commented on code in PR #1538:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1143315975
##
.github/workflows/ci.yml:
##
@@ -223,13 +227,132 @@ jobs:
if [ -d ~/.ccache ]; then mv ~/.ccache .; fi
mkdir build
cd build
- cmake -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON
-DDISABLE_JEMALLOC=ON -DENABLE_AWS=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_MQTT=ON
-DENABLE_AZURE=ON -DENABLE_SQL=ON \
- -DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON
-DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
- -DDOCKER_BUILD_ONLY=ON
-DDOCKER_CCACHE_DUMP_LOCATION=$HOME/.ccache ..
+ cmake ${DOCKER_CMAKE_FLAGS} ..
make docker
+ - name: Save docker image
+run: cd build && docker save -o minifi_docker.tar
apacheminificpp:0.13.0
Review Comment:
I think this comes from `make docker`. Maybe we could specify the version as
a parameter there, and use `testing` for CI docker image builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-4651) PutSQL should return error messages and error codes in an attribute
[ https://issues.apache.org/jira/browse/NIFI-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsihovszki Krisztina updated NIFI-4651: --- Fix Version/s: 1.latest 2.latest > PutSQL should return error messages and error codes in an attribute > --- > > Key: NIFI-4651 > URL: https://issues.apache.org/jira/browse/NIFI-4651 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.20.0 >Reporter: Kay-Uwe Moosheimer >Assignee: Zsihovszki Krisztina >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 1h > Remaining Estimate: 0h > > In case of an error PutSQL should return the error messages and the error > code in attributes to be able to edit each FlowFile manually or automatically > according to the error. > A selection "Return errors" -> "Yes/No" and the possibility to specify two > attribute names (one for error message and one for error code) would be > helpful for postprocessing. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11255) Add allowable value for “Use ‘s3.region’" attribute
[ https://issues.apache.org/jira/browse/NIFI-11255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsihovszki Krisztina updated NIFI-11255: Fix Version/s: 1.latest > Add allowable value for “Use ‘s3.region’" attribute > --- > > Key: NIFI-11255 > URL: https://issues.apache.org/jira/browse/NIFI-11255 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Zsihovszki Krisztina >Assignee: Zsihovszki Krisztina >Priority: Major > Fix For: 1.latest, 2.latest > > Time Spent: 50m > Remaining Estimate: 0h > > With the S3 processors, there’s no way to make the “Region” come from > FlowFile attributes. > It would be useful to offer a possibility for the user to take the region > value from FlowFile attribute, just like S3 Key and Bucket values. > We should have an allowable value for “Use ‘s3.region’ attribute”. In case > user selects "Use ‘s3.region’ attribute” from the region drop-down list, the > region value will be taken from the FlowFile attribute. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1538: MINIFICPP-2073 Separate docker build from docker tests in CI
fgerlits commented on code in PR #1538:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1538#discussion_r1143262824
##
.github/workflows/ci.yml:
##
@@ -223,13 +227,132 @@ jobs:
if [ -d ~/.ccache ]; then mv ~/.ccache .; fi
mkdir build
cd build
- cmake -DUSE_SHARED_LIBS= -DSTRICT_GSL_CHECKS=AUDIT -DCI_BUILD=ON
-DDISABLE_JEMALLOC=ON -DENABLE_AWS=ON -DENABLE_LIBRDKAFKA=ON -DENABLE_MQTT=ON
-DENABLE_AZURE=ON -DENABLE_SQL=ON \
- -DENABLE_SPLUNK=ON -DENABLE_GCP=ON -DENABLE_OPC=ON
-DENABLE_PYTHON_SCRIPTING=ON -DENABLE_LUA_SCRIPTING=ON -DENABLE_KUBERNETES=ON
-DENABLE_TEST_PROCESSORS=ON -DENABLE_PROMETHEUS=ON \
- -DDOCKER_BUILD_ONLY=ON
-DDOCKER_CCACHE_DUMP_LOCATION=$HOME/.ccache ..
+ cmake ${DOCKER_CMAKE_FLAGS} ..
make docker
+ - name: Save docker image
+run: cd build && docker save -o minifi_docker.tar
apacheminificpp:0.13.0
Review Comment:
Can we call this `apacheminificpp:testing` or similar? It's going to be
annoying to always have to update the version number here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MINIFICPP-1713) Repotests sometimes segfault in CI
[
https://issues.apache.org/jira/browse/MINIFICPP-1713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-1713:
-
Status: Patch Available (was: Open)
> Repotests sometimes segfault in CI
> --
>
> Key: MINIFICPP-1713
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1713
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
> Attachments: RepoTests_segfault.log
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Repotests failed with the following message in CI:
> {code:java}
> ~~~
> RepoTests is a Catch v2.13.10 host application.
> Run with -? for
> options---
> Flush deleted flowfiles before shutdown
> ---
> /home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/rocksdb-tests/RepoTests.cpp:343
> .../home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/libminifi/test/rocksdb-tests/RepoTests.cpp:343:
> FAILED:
> {Unknown expression after the reported line}
> due to a fatal error condition:
> SIGSEGV - Segmentation violation signal {code}
> Logs attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] turcsanyip commented on a diff in pull request #6985: NIFI-11215: Add custom validation for KerberosUserService in PutIceberg
turcsanyip commented on code in PR #6985:
URL: https://github.com/apache/nifi/pull/6985#discussion_r1143193301
##
nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/PutIceberg.java:
##
@@ -148,6 +153,28 @@ public Set getRelationships() {
return RELATIONSHIPS;
}
+@Override
+protected Collection customValidate(ValidationContext
context) {
+final List problems = new ArrayList<>();
+final IcebergCatalogService catalogService =
context.getProperty(CATALOG).asControllerService(IcebergCatalogService.class);
+boolean catalogServiceEnabled =
context.getControllerServiceLookup().isControllerServiceEnabled(catalogService);
+
+if (catalogServiceEnabled) {
+final boolean kerberosUserServiceIsSet =
context.getProperty(KERBEROS_USER_SERVICE).isSet();
+final boolean securityEnabled =
SecurityUtil.isSecurityEnabled(catalogService.getConfiguration());
+
+if (securityEnabled && !kerberosUserServiceIsSet) {
+problems.add(new ValidationResult.Builder()
+.subject(KERBEROS_USER_SERVICE.getDisplayName())
+.valid(false)
+.explanation("Security authentication is set to
'kerberos' in the configuration files but no KerberosUserService is
configured.")
Review Comment:
Minor but the following may be a more straightforward error message:
```suggestion
.explanation("'hadoop.security.authentication' is
set to 'kerberos' in the hadoop configuration files but no KerberosUserService
is configured.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1511: MINIFICPP-1716 Recover core dumps from CI
lordgamez commented on PR #1511: URL: https://github.com/apache/nifi-minifi-cpp/pull/1511#issuecomment-1477619203 For some reason I'm not sure of the GCC build cannot utilize ccache in github actions if built with RelWithDebInfo. Because of this I kept RelWithDebInfo only with the clang build, so we can keep the low build times and minimize the cache storage use as well. (Even though Apple clang is a bit different from the Ubuntu clang build, the build issues are usually the same with both so I kept MacOS build with Release build type.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #6985: NIFI-11215: Add custom validation for KerberosUserService in PutIceberg
turcsanyip commented on PR #6985: URL: https://github.com/apache/nifi/pull/6985#issuecomment-1477615377 @mark-bathori Could you please add a unit test (using `TestRunner`) for testing the new validation logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1538: MINIFICPP-2073 Separate docker build from docker tests in CI
martinzink opened a new pull request, #1538: URL: https://github.com/apache/nifi-minifi-cpp/pull/1538 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] If applicable, have you updated the LICENSE file? - [x] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] nandorsoma commented on a diff in pull request #7032: NIFI-11270 Refactoring of the overly Paho-specific MQTT interface
nandorsoma commented on code in PR #7032:
URL: https://github.com/apache/nifi/pull/7032#discussion_r1143140131
##
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/adapters/PahoMqttClientAdapter.java:
##
@@ -189,4 +172,53 @@ private static org.eclipse.paho.client.mqttv3.MqttClient
createClient(URI broker
}
}
+/**
+ * Paho API uses the same callback for the publisher and consumer as well.
+ * Because of that, DefaultMqttCallback sets some reasonable default logs
+ * to make it easier to track misconfiguration errors.
+ *
+ * In case of subscribing clients messageArrived needs to be overridden.
+ */
+private class DefaultMqttCallback implements MqttCallback {
+
+@Override
+public void connectionLost(Throwable cause) {
+logger.error("Connection to {} lost",
clientProperties.getRawBrokerUris(), cause);
+}
+
+@Override
+public void messageArrived(String topic, MqttMessage message) {
+logger.error(String.format("MQTT message arrived { topic:%s;
payload:%s}", topic, Arrays.toString(message.getPayload(;
Review Comment:
In the original code, a comment implied that it was an unlikely situation.
The main issue is that the Paho library uses the same interface regardless of
whether the client is a subscriber or publisher. In the case of the publisher,
this callback doesn't make sense. That's why it is logged with an error. But I
see it is confusing, so I'll add that comment back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1535: MINIFICPP-2080 Add missing processors to README.md
lordgamez commented on code in PR #1535: URL: https://github.com/apache/nifi-minifi-cpp/pull/1535#discussion_r1143129415 ## README.md: ## @@ -63,45 +63,45 @@ MiNiFi - C++ supports the following C++ processors: The following table lists the base set of processors. -| Extension Set | Processors | -|---|:--- | -| **Base** | [AppendHostInfo](PROCESSORS.md#appendhostinfo)[DefragmentText](PROCESSORS.md#defragmenttext)[ExecuteProcess](PROCESSORS.md#executeprocess)[ExtractText](PROCESSORS.md#extracttext)[FetchFile](PROCESSORS.md#fetchfile)[GenerateFlowFile](PROCESSORS.md#generateflowfile)[GetFile](PROCESSORS.md#getfile)[GetTCP](PROCESSORS.md#gettcp)[HashContent](PROCESSORS.md#hashcontent)[ListenSyslog](PROCESSORS.md#listensyslog)[ListenTCP](PROCESSORS.md#listentcp)[ListenUDP](PROCESSORS.md#listenudp)[ListFile](PROCESSORS.md#listfile)[LogAttribute](PROCESSORS.md#logattribute)[PutFile](PROCESSORS.md#putfile)[PutTCP](PROCESSORS.md#puttcp)[PutUDP](PROCESSORS.md#putudp)[ReplaceText](PROCESSORS.md#replacetext)[RetryFlowFile](PROCESSORS.md#retryflowfile)[RouteOnAttribute](PROCESSORS.md#routeonattribute)[RouteText](PROCESSORS.md#routetext)[TailFile](PROCESSORS.md#tailfile)[UpdateAttribute] (PROCESSORS.md#updateattribute) | +| Extension Set | Processors |
[jira] [Assigned] (MINIFICPP-2037) Build SSLContext from minifi.properties for SSL communication on C2
[ https://issues.apache.org/jira/browse/MINIFICPP-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2037: Assignee: Gábor Gyimesi > Build SSLContext from minifi.properties for SSL communication on C2 > --- > > Key: MINIFICPP-2037 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2037 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > If we want to use SSL for C2 communication we have to define an > SSLContextService in the flow configuration with the certificate information > used for the SSL connection. If the flow fetched from the C2 server and the > agent is started with an empty flow configuration this is not possible. We > should be able to retrieve the needed SSL information from the > minifi.properties file as well if we are not able to provide it in the flow > configuration. There is a similar use case for this in the > RemoteProcessorGroupPort where the > SSLContextService is built manually from the information provided in the > minifi.properties file. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
lordgamez commented on PR #1537: URL: https://github.com/apache/nifi-minifi-cpp/pull/1537#issuecomment-1477509409 > Could you describe what caused the segfault and why this fixes it? Even though the `flush_counter` is an atomic, incrementing it and checking its value are 2 separate operations and running them in parallel could create an ordering where the checked value is never 1. This can occur quite often if this thread is run every 1ms. Because of this the repository is not stopped before it is destroyed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2073) Separate docker build from docker tests in CI
[ https://issues.apache.org/jira/browse/MINIFICPP-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2073: --- Status: Open (was: Patch Available) > Separate docker build from docker tests in CI > - > > Key: MINIFICPP-2073 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2073 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > Since the docker tests are not as consistent as we would like, it would be > nice if we could rerun just the tests without the need to rebuild the image. > We could use docker save/load image and github upload/download artifact to > achive this capability. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
szaszm commented on PR #1537: URL: https://github.com/apache/nifi-minifi-cpp/pull/1537#issuecomment-1477487173 Could you describe what caused the segfault and why this fixes it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1536: MINIFICPP-2075 Fix flaky PutTCPTests testcase
martinzink commented on PR #1536: URL: https://github.com/apache/nifi-minifi-cpp/pull/1536#issuecomment-1477486447 > I'm fine with this, but do we even need to check the logs? `trigger_expect_failure` already checked that the flow file was routed to Failure; that may be enough. You are probably right, originally it clearly documented the reason behind the failure, but now that I look at it these 6-7 lines (and I'm not sure if this covers every possible failure message on every supported platform), its probably not really useful anymore. I've removed them in https://github.com/apache/nifi-minifi-cpp/pull/1536/commits/0c73a5bedb726660109ced05f7639e2c6f636dc5 I rerequested the reviews because this makes them moot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1534: MINIFICPP-2079 Fix OOM in python.feature
martinzink commented on PR #1534: URL: https://github.com/apache/nifi-minifi-cpp/pull/1534#issuecomment-1477471314 > Why did this cause OOM? I'm not quite sure why but sometimes this feature would fail(?) and it would continue to generate flowfiles for a minute every 10ms, that clogged the logger which is continuosly buffered and searched by the docker-verify process. That caused massive memory usage and it even failed to kill this feature after the minute has been passed. This will fix the OOM issue, but it might still come up as a failed feature which we would have to investigate further. I tried to reproduce this locally but failed to do so -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-1336) Unable to build minifi 0.7.0 on ARM 64 bit architecture
[
https://issues.apache.org/jira/browse/MINIFICPP-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink resolved MINIFICPP-1336.
Resolution: Fixed
[https://github.com/apache/nifi-minifi-cpp/commit/06d5467c6ca2d9a20ca9a969fd768e03025c362d]
fixed the compilation issues on ARM64
> Unable to build minifi 0.7.0 on ARM 64 bit architecture
> ---
>
> Key: MINIFICPP-1336
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1336
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Affects Versions: 0.7.0
>Reporter: Advith Nagappa
>Priority: Major
> Attachments: cmake.txt, debug.txt, debug01.txt, make_debug.txt
>
>
> {code:java}
> DISTRIB_ID=Ubuntu
> DISTRIB_RELEASE=18.04
> DISTRIB_CODENAME=bionic
> DISTRIB_DESCRIPTION="Ubuntu 18.04.5 LTS"
> {code}
> {code:java}
> Architecture: aarch64 Byte Order: Little Endian CPU(s): 4 On-line CPU(s)
> list: 0-3 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 1 NUMA
> node(s): 1 Vendor ID: ARM Model: 3 Model name: Cortex-A72 Stepping: r0p3
> BogoMIPS: 166.66 L1d cache: 32K L1i cache: 48K L2 cache: 2048K NUMA node0
> CPU(s): 0-3 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid
> {code}
> ./bootstrap.sh (CMAKE version 3.10.2)
> {code:java}
>
> Select MiNiFi C++ Features to toggle.
>
> A. Persistent Repositories .Disabled
> B. Lib Curl Features ...Enabled
> C. Lib Archive Features Enabled
> D. Execute Script support ..Enabled
> E. Expression Language support .Enabled
> F. Kafka support ...Disabled
> G. PCAP support Disabled
> H. USB Camera support ..Disabled
> I. GPS support .Disabled
> J. TensorFlow Support ..Disabled
> K. Bustache Support Disabled
> L. MQTT Support Disabled
> M. SQLite Support ..Disabled
> N. Python Support ..Disabled
> O. COAP Support Enabled
> S. SFTP Support Disabled
> V. AWS Support .Disabled
> T. OpenCV Support ..Disabled
> U. OPC-UA Support...Disabled
>
> Build Options.
>
> 1. Disable Tests ...Disabled
> 2. Enable all extensions
> 3. Enable JNI Support ..Disabled
> 4. Use Shared Dependency Links .Enabled
> 5. Build Profile ...RelWithDebInfo Debug MinSizeRel Release
> P. Continue with these options
> Q. Quit
> * Extension cannot be installed due to
> version of cmake or other software
> {code}
> EDIT: I have attached the output of cmake in "cmake.txt" and output of `make
> -j8` in "make_debug.txt"
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-11317) Unable to write flowfile content to content repository container
Arsal Jalib created NIFI-11317: -- Summary: Unable to write flowfile content to content repository container Key: NIFI-11317 URL: https://issues.apache.org/jira/browse/NIFI-11317 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.19.1 Environment: Linux Reporter: Arsal Jalib During processing of flow files, we randomly get this error: 2023-02-20 06:00:55,579 WARN [Timer-Driven Process Thread-10] oancrepository.FileSystemRepository Unable to write flowfile content to content repository container default due to archive file size constraints; waiting for archive cleanup. Total number of files currently archived = 29 These are the parameters in the nifi.properties: nifi.flow.configuration.archive.enabled=true nifi.flow.configuration.archive.dir=./conf/archive/ nifi.flow.configuration.archive.max.time=30 days nifi.flow.configuration.archive.max.storage=500 MB nifi.flow.configuration.archive.max.count= nifi.content.claim.max.flow.files=100 nifi.content.repository.directory.default=../nifi_data_dir/content_repository nifi.content.repository.archive.max.retention.period=12 hours nifi.content.repository.archive.max.usage.percentage=50% nifi.content.repository.archive.enabled=true The space on drive is Total 20G Used 13G Free 5.7G 70% The max number of flow files at a time is 11000. The size of these file is no more than 110 MB Given these parameters, this warning should not appear. Could be related to https://issues.apache.org/jira/browse/NIFI-9993 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1537: MINIFICPP-1713 Fix transient segfault in RepoTests
lordgamez opened a new pull request, #1537: URL: https://github.com/apache/nifi-minifi-cpp/pull/1537 https://issues.apache.org/jira/browse/MINIFICPP-1713 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINIFICPP-1756) Fix ARM compilation issues
[ https://issues.apache.org/jira/browse/MINIFICPP-1756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-1756. Resolution: Fixed [https://github.com/apache/nifi-minifi-cpp/commit/06d5467c6ca2d9a20ca9a969fd768e03025c362d] fixed these compilation issues. I was able to compile minifi on multiple arm platforms, RockyLinux:9 aarch64, Raspberry Pi OS x64 (Raspberry pi 3b+) etc > Fix ARM compilation issues > -- > > Key: MINIFICPP-1756 > URL: https://issues.apache.org/jira/browse/MINIFICPP-1756 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Affects Versions: 0.11.0 > Environment: raspberry pi 3b+ 64 bit (emulated w/ qemu) >Reporter: Marton Szasz >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > - ossp-uuid doesn't recognize the aarch64-linux-gnu target, pass > --build=aarch64-linux-gnu --target=aarch64-linux-gnu to ./configure > - ossp-uuid thinks aarch64 is an invalid platform, needs patch or upgrade > - yaml-cpp lib path issue: passthrough CMAKE_INSTALL_LIBDIR > - spdlog lib path issue: make[2]: *** No rule to make target > 'thirdparty/spdlog-install/lib/aarch64-linux-gnu/libspdlog.a', needed by > 'bin/libcore-minifi.so'. Stop. (found under lib/libspdlog.a without the > target triplet) > - TimeUtilTests.cpp: no "January" on libstdc++10 (this should be a problem on > x86, too) > - StringUtilsTests.cpp:390: narrowing conversions result in -Wnarrowing error > despite no -Werror. Either because of initializer list (shouldn't be an issue > IMO since this is not direct-list-initialization) or compiler bug. > - curl lib path issue: make[2]: *** No rule to make target > 'thirdparty/curl-install/lib/aarch64-linux-gnu/libcurl.a', needed by > 'bin/libminifi-http-curl.so'. Stop. > - civetweb lib path > - rocksdb lib path > - probably all other ExternalProject libs. GNUInstallDirs > CMAKE_INSTALL_LIBDIR references seem to include the architecture triplet > after lib/, but the builds don't -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mark-bathori commented on pull request #7058: NIFI-11266 PutGoogleDrive, ListGoogleDrive, FetchGoogleDrive can't ac…
mark-bathori commented on PR #7058: URL: https://github.com/apache/nifi/pull/7058#issuecomment-1477385110 Reviewing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dam4rus commented on a diff in pull request #7003: NIFI-11241: Initial implementation of Python-based Processor API with…
dam4rus commented on code in PR #7003: URL: https://github.com/apache/nifi/pull/7003#discussion_r1142937771 ## nifi-nar-bundles/nifi-py4j-bundle/nifi-python-extension-api/src/main/python/src/nifiapi/properties.py: ## @@ -0,0 +1,411 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +from enum import Enum +from nifiapi.__jvm__ import JvmHolder +import re + +class ExpressionLanguageScope(Enum): +NONE = 1 +LIMITED = 2 +FLOWFILE_ATTRIBUTES = 3 + + +class StandardValidators: +__standard_validators__ = JvmHolder.jvm.org.apache.nifi.processor.util.StandardValidators + +ALWAYS_VALID = JvmHolder.jvm.org.apache.nifi.components.Validator.VALID +NON_EMPTY_VALIDATOR = __standard_validators__.NON_EMPTY_VALIDATOR +INTEGER_VALIDATOR = __standard_validators__.INTEGER_VALIDATOR +POSITIVE_INTEGER_VALIDATOR = __standard_validators__.POSITIVE_INTEGER_VALIDATOR +POSITIVE_LONG_VALIDATOR = __standard_validators__.POSITIVE_LONG_VALIDATOR +NON_NEGATIVE_INTEGER_VALIDATOR = __standard_validators__.NON_NEGATIVE_INTEGER_VALIDATOR +NUMBER_VALIDATOR = __standard_validators__.NUMBER_VALIDATOR +LONG_VALIDATOR = __standard_validators__.LONG_VALIDATOR +PORT_VALIDATOR = __standard_validators__.PORT_VALIDATOR +NON_EMPTY_EL_VALIDATOR = __standard_validators__.NON_EMPTY_EL_VALIDATOR +HOSTNAME_PORT_LIST_VALIDATOR = __standard_validators__.HOSTNAME_PORT_LIST_VALIDATOR +BOOLEAN_VALIDATOR = __standard_validators__.BOOLEAN_VALIDATOR +URL_VALIDATOR = __standard_validators__.URL_VALIDATOR +URI_VALIDATOR = __standard_validators__.URI_VALIDATOR +REGULAR_EXPRESSION_VALIDATOR = __standard_validators__.REGULAR_EXPRESSION_VALIDATOR +REGULAR_EXPRESSION_WITH_EL_VALIDATOR = __standard_validators__.REGULAR_EXPRESSION_WITH_EL_VALIDATOR +TIME_PERIOD_VALIDATOR = __standard_validators__.TIME_PERIOD_VALIDATOR +DATA_SIZE_VALIDATOR = __standard_validators__.DATA_SIZE_VALIDATOR +FILE_EXISTS_VALIDATOR = __standard_validators__.FILE_EXISTS_VALIDATOR + + + +class PropertyDependency: +def __init__(self, property_descriptor, dependent_values=None): +if dependent_values is None: +dependent_values = [] + +if isinstance(property_descriptor, str): +self.property_name = property_descriptor +else: +self.property_name = property_descriptor.getName() +self.dependentValues = dependent_values + +@staticmethod +def from_java_dependency(java_dependencies): +if java_dependencies is None or len(java_dependencies) == 0: +return None + +dependencies = [] +for dependency in java_dependencies: + dependencies.append(PropertyDependency(dependency.getPropertyName(), dependency.getDependentValues())) + +return dependencies + + +class ResourceDefinition: +def __init__(self, allow_multiple=False, allow_file=True, allow_url=False, allow_directory=False, allow_text=False): +self.allow_multiple = allow_multiple +self.allow_file = allow_file +self.allow_url = allow_url +self.allow_directory = allow_directory +self.allow_text = allow_text + +@staticmethod +def from_java_definition(java_definition): +if java_definition is None: +return None + +allow_multiple = java_definition.getCardinality().name() == "MULTIPLE" +resource_types = java_definition.getResourceTypes() +allow_file = False +allow_url = False +allow_directory = False +allow_text = False +for type in resource_types: +name = type.name() +if name == "FILE": +allow_file = True +elif name == "DIRECTORY": +allow_directory = True +elif name == "TEXT": +allow_text = True +elif name == "URL": +allow_url = True + +return ResourceDefinition(allow_multiple, allow_file, allow_url, allow_directory, allow_text) + + +class PropertyDescriptor: +def __init__(self, name, description, required=False, sensitive=False, + display_name=None, default_value=None, allowable_values=None, +
