[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1631: MINIFICPP-2174 Send all cached compressed log files through C2
szaszm commented on code in PR #1631:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1329636177
##
libminifi/include/core/logging/LoggerConfiguration.h:
##
@@ -98,15 +98,15 @@ class LoggerConfiguration {
*/
void initialize(const std::shared_ptr &logger_properties);
- static std::unique_ptr getCompressedLog(bool flush = false)
{
-return getCompressedLog(std::chrono::milliseconds{0}, flush);
+ static std::vector> getCompressedLogs(bool
flush = false) {
+return getCompressedLogs(std::chrono::milliseconds{0}, flush);
Review Comment:
I was hoping for some code simplification, but since it's not trivial, I
don't want to block this PR with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1654: MINIFICPP-2214 Fix extension list inconsistencies in build scripts
szaszm commented on code in PR #1654: URL: https://github.com/apache/nifi-minifi-cpp/pull/1654#discussion_r1329600706 ## win_build_vs.bat: ## @@ -24,37 +24,35 @@ set scriptdir=%~dp0 set skiptests=OFF set skiptestrun=OFF set cmake_build_type=Release -set build_platform=Win32 -set build_kafka=OFF -set build_coap=OFF -set build_jni=OFF -set build_SQL=OFF -set build_AWS=OFF -set build_SFTP=OFF -set build_azure=OFF +set build_platform=x64 +set enable_kafka=ON +set enable_coap=OFF Review Comment: Thanks, I didn't notice the duplication here. Removed both the second `set enable_coap=OFF` from here and the second `-DENABLE_COAP=%enable_coap%` from the CMake command line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1659: MINIFICPP-2218 Refactor expected monadic functions
szaszm commented on code in PR #1659:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1659#discussion_r1329598353
##
libminifi/test/unit/ExpectedTest.cpp:
##
@@ -484,3 +484,63 @@ TEST_CASE("expected valueOrElse",
"[expected][valueOrElse]") {
REQUIRE_THROWS_AS(ex | utils::valueOrElse([](const std::string&) -> int {
throw std::exception(); }), std::exception);
REQUIRE_THROWS_AS(std::move(ex) | utils::valueOrElse([](std::string&&) ->
int { throw std::exception(); }), std::exception);
}
+
+TEST_CASE("expected transformError", "[expected][transformError]") {
+ auto mul2 = [](int a) { return a * 2; };
+
+ {
+nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = e | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+const nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = e | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = std::move(e) | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+const nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = std::move(e) | utils::transformError(mul2); //
NOLINT(performance-move-const-arg)
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
Review Comment:
It doesn't make much sense to use const rvalue refs, but this still checks
that the implementation matches the expectations in this unlikely case. I just
copy pasted the transform tests from above, which were copy pasted from
TartanLlama's test suite.
How would you structure the suggested new test case, that ends up testing
the expected implementation, and not the C++ language itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1659: MINIFICPP-2218 Refactor expected monadic functions
szaszm commented on code in PR #1659:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1659#discussion_r1329594537
##
libminifi/include/utils/expected.h:
##
@@ -31,28 +29,42 @@ inline constexpr bool is_expected_v = false;
template
inline constexpr bool is_expected_v> = true;
-// map implementation
-template>>>
-auto operator|(Expected&& object, map_wrapper f) {
- using value_type = typename utils::remove_cvref_t::value_type;
- using error_type = typename utils::remove_cvref_t::error_type;
- if constexpr (std::is_same_v) {
-using function_return_type =
std::decay_t(f.function)))>;
+template
+concept expected = is_expected_v>;
+
+template
+inline constexpr bool is_valid_unexpected_type_v = std::is_same_v> && std::is_object_v && !std::is_array_v;
+
+template
+inline constexpr bool is_valid_unexpected_type_v> =
false;
Review Comment:
I can rename it, but I don't understand the problem: it's a generic name
used for type parameters when communicating more context isn't necessary. Is it
really confusing to have identically named `typename T` in a partial template
specialization and a related concept definition?
Would it be better to use separate names for all of them (let's say `T`, `U`
and `V`), or some other arrangement (like `T` for the first one, `E` for the
partial specialization, `F` for the concept)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7665: NIFI-11197 Initial check in for Yaml record reader
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1329347499
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -31,29 +29,23 @@
public class JsonRecordSource implements RecordSource {
private static final Logger logger =
LoggerFactory.getLogger(JsonRecordSource.class);
-private static final JsonFactory jsonFactory;
private final JsonParser jsonParser;
private final StartingFieldStrategy strategy;
-private final String startingFieldName;
-
-static {
-jsonFactory = new JsonFactory();
-jsonFactory.setCodec(new ObjectMapper());
-}
public JsonRecordSource(final InputStream in) throws IOException {
-jsonParser = jsonFactory.createParser(in);
-strategy = null;
-startingFieldName = null;
+this(in, null, null);
}
public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName) throws IOException {
-jsonParser = jsonFactory.createParser(in);
+this(in , strategy, startingFieldName, new JsonParserFactory());
+}
+
+public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName, TokenParserFactory
tokenParserFactory) throws IOException {
+jsonParser = tokenParserFactory.getJsonParser(in);
this.strategy = strategy;
-this.startingFieldName = startingFieldName;
-if (strategy == StartingFieldStrategy.NESTED_FIELD) {
-final SerializedString serializedNestedField = new
SerializedString(this.startingFieldName);
+if (StartingFieldStrategy.NESTED_FIELD.equals(strategy)) {
Review Comment:
No problem, reversing the order avoided the NPE, so that was a good change,
but it will also work with `==` as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
exceptionfactory commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329346724 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: Yes! Thanks for making the adjustment, that looks good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7665: NIFI-11197 Initial check in for Yaml record reader
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1329332945
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -31,29 +29,23 @@
public class JsonRecordSource implements RecordSource {
private static final Logger logger =
LoggerFactory.getLogger(JsonRecordSource.class);
-private static final JsonFactory jsonFactory;
private final JsonParser jsonParser;
private final StartingFieldStrategy strategy;
-private final String startingFieldName;
-
-static {
-jsonFactory = new JsonFactory();
-jsonFactory.setCodec(new ObjectMapper());
-}
public JsonRecordSource(final InputStream in) throws IOException {
-jsonParser = jsonFactory.createParser(in);
-strategy = null;
-startingFieldName = null;
+this(in, null, null);
}
public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName) throws IOException {
-jsonParser = jsonFactory.createParser(in);
+this(in , strategy, startingFieldName, new JsonParserFactory());
+}
+
+public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName, TokenParserFactory
tokenParserFactory) throws IOException {
+jsonParser = tokenParserFactory.getJsonParser(in);
this.strategy = strategy;
-this.startingFieldName = startingFieldName;
-if (strategy == StartingFieldStrategy.NESTED_FIELD) {
-final SerializedString serializedNestedField = new
SerializedString(this.startingFieldName);
+if (StartingFieldStrategy.NESTED_FIELD.equals(strategy)) {
Review Comment:
@exceptionfactory Sorry I thought I needed to do that to avoid an NPE since
`strategy` could be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329320223 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: @exceptionfactory I removed the xmlunit as you requested but I was able to get the XPath working with plain Java using their Xpath API. Is that okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] taz1988 opened a new pull request, #7754: NIFI-12084: fix process group logging on support branch
taz1988 opened a new pull request, #7754: URL: https://github.com/apache/nifi/pull/7754 # Summary [NIFI-12084](https://issues.apache.org/jira/browse/NIFI-12084) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12084) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329320223 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: @exceptionfactory I removed the xmlunit as you requested but I was able to get the XPath working with plain Java using their Xpath API. IS that okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12084) Logging by process group is not workin on 1.x support branch
Zoltán Kornél Török created NIFI-12084: -- Summary: Logging by process group is not workin on 1.x support branch Key: NIFI-12084 URL: https://issues.apache.org/jira/browse/NIFI-12084 Project: Apache NiFi Issue Type: Bug Affects Versions: 1.23.2, 1.23.1, 1.23.0 Reporter: Zoltán Kornél Török Assignee: Zoltán Kornél Török During migrating https://issues.apache.org/jira/browse/NIFI-3065 feature to support branch, it seems an important line missed - https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/ExtensionBuilder.java#L278 Because of that the feature currently is not working. Will fix it by add the missing code line. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329296792 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: @exceptionfactory I think I have a way of using Xpath and not using the dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
I believe the output is XML hence there was XML parsing used originally to
access the XML.
The specific place I use it is in
`ScriptedRecordSetWriterTest.testRecordWriterGroovyScript`
This was the original code from the Groovy version
```
def xml = new XmlSlurper().parseText(outputStream.toString())
assertEquals('1', xml.record[0].id.toString())
assertEquals('200', xml.record[1].code.toString())
assertEquals('Ramon', xml.record[2].name.toString())
```
I thought the easiest way to mimic the above was to use XPath to obtain the
values and perform the identical assertions.
This is the only test in the class. Should we then just delete this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
I believe the output is XML hence there was XML parsing used originally to
access the XML.
The specific place I use it is in
`ScriptedRecordSetWriterTest.testRecordWriterGroovyScript`
This was the original code from the Groovy version
```
def xml = new XmlSlurper().parseText(outputStream.toString())
assertEquals('1', xml.record[0].id.toString())
assertEquals('200', xml.record[1].code.toString())
assertEquals('Ramon', xml.record[2].name.toString())
```
I thought the easiest way to mimic the above was to use XPath to obtain the
values and perform the identical assertions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
I believe the output is XML hence there was XML parsing used originally to
access the XML.
The specific place I use it is in
`ScriptedRecordSetWriterTest.testRecordWriterGroovyScript`
This was the original code from the Groovy version
```
def xml = new XmlSlurper().parseText(outputStream.toString())
assertEquals('1', xml.record[0].id.toString())
assertEquals('200', xml.record[1].code.toString())
assertEquals('Ramon', xml.record[2].name.toString())
```
I thought the easiest way to mimick the above was to use XPath to obtain the
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
exceptionfactory commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329282432 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: Thanks for the pointer. In that case, it would be better to change the assert to just parse the XML Document using the Java DocumentBuilder, and skip the XPath assertions. That should be sufficient in this particular scenario, and it avoids the additional dependency for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
I believe the output is XML hence there was XML parsing used originally to
access the XML.
The specific place I use it is in
`ScriptedRecordSetWriterTest.testRecordWriterGroovyScript`
This was the original assertions from the Groovy version
```
def xml = new XmlSlurper().parseText(outputStream.toString())
assertEquals('1', xml.record[0].id.toString())
assertEquals('200', xml.record[1].code.toString())
assertEquals('Ramon', xml.record[2].name.toString())
```
I thought the easiest way to mimick the above was to use XPath to obtain the
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
I believe the output is XML hence there was XML parsing used originally to
access the XML.
The specific place I use it is in
`ScriptedRecordSetWriterTest.testRecordWriterGroovyScript`
This was the original assertions fromt the Groovy version
```
def xml = new XmlSlurper().parseText(outputStream.toString())
assertEquals('1', xml.record[0].id.toString())
assertEquals('200', xml.record[1].code.toString())
assertEquals('Ramon', xml.record[2].name.toString())
```
I thought the easiest way to mimick the above was to use XPath to obtain the
values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329278406 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: I believe the output is XML hence there was XML parsing used originally to access the XML. The specific place I use it is in `ScriptedRecordSetWriterTest.testRecordWriterGroovyScript` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12081) Remove HackerOne References for Security Reporting
[ https://issues.apache.org/jira/browse/NIFI-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766587#comment-17766587 ] ASF subversion and git services commented on NIFI-12081: Commit 08ab9b14eeeb1ca9f5c3316215e7bdff9803ba33 in nifi's branch refs/heads/support/nifi-1.x from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=08ab9b14ee ] NIFI-12081 Removed HackerOne from Security Reporting Methods This closes #7751 Signed-off-by: David Handermann (cherry picked from commit 80264cdd12c54825fe52d672bb966c43eca75434) > Remove HackerOne References for Security Reporting > -- > > Key: NIFI-12081 > URL: https://issues.apache.org/jira/browse/NIFI-12081 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Fix For: 1.latest, 2.latest > > > The Apache NiFi Project using the private mailing list > secur...@nifi.apache.org for receiving security reports and no longer uses > the project page on HackerOne. References to HackerOne should be removed from > the project website and security reporting guidelines. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12081) Remove HackerOne References for Security Reporting
[ https://issues.apache.org/jira/browse/NIFI-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12081: Fix Version/s: 2.0.0 1.24.0 (was: 1.latest) (was: 2.latest) Resolution: Fixed Status: Resolved (was: Patch Available) > Remove HackerOne References for Security Reporting > -- > > Key: NIFI-12081 > URL: https://issues.apache.org/jira/browse/NIFI-12081 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Fix For: 2.0.0, 1.24.0 > > > The Apache NiFi Project using the private mailing list > secur...@nifi.apache.org for receiving security reports and no longer uses > the project page on HackerOne. References to HackerOne should be removed from > the project website and security reporting guidelines. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12081) Remove HackerOne References for Security Reporting
[ https://issues.apache.org/jira/browse/NIFI-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766586#comment-17766586 ] ASF subversion and git services commented on NIFI-12081: Commit 80264cdd12c54825fe52d672bb966c43eca75434 in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=80264cdd12 ] NIFI-12081 Removed HackerOne from Security Reporting Methods This closes #7751 Signed-off-by: David Handermann > Remove HackerOne References for Security Reporting > -- > > Key: NIFI-12081 > URL: https://issues.apache.org/jira/browse/NIFI-12081 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Fix For: 1.latest, 2.latest > > > The Apache NiFi Project using the private mailing list > secur...@nifi.apache.org for receiving security reports and no longer uses > the project page on HackerOne. References to HackerOne should be removed from > the project website and security reporting guidelines. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory closed pull request #7751: NIFI-12081 Remove HackerOne from Security Reporting Methods
exceptionfactory closed pull request #7751: NIFI-12081 Remove HackerOne from Security Reporting Methods URL: https://github.com/apache/nifi/pull/7751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
exceptionfactory commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329274604 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: Thanks for clarifying. This sounds like a case where the tests should be simplified. There is nothing specific to XML parsing in the Execute Script components themselves, so there is no need to retain the complex XML parsing tests. If this requires removing some test methods, it would be better to do that and remove this dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7665: NIFI-11197 Initial check in for Yaml record reader
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1329269945
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -31,29 +29,23 @@
public class JsonRecordSource implements RecordSource {
private static final Logger logger =
LoggerFactory.getLogger(JsonRecordSource.class);
-private static final JsonFactory jsonFactory;
private final JsonParser jsonParser;
private final StartingFieldStrategy strategy;
-private final String startingFieldName;
-
-static {
-jsonFactory = new JsonFactory();
-jsonFactory.setCodec(new ObjectMapper());
-}
public JsonRecordSource(final InputStream in) throws IOException {
-jsonParser = jsonFactory.createParser(in);
-strategy = null;
-startingFieldName = null;
+this(in, null, null);
}
public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName) throws IOException {
-jsonParser = jsonFactory.createParser(in);
+this(in , strategy, startingFieldName, new JsonParserFactory());
+}
+
+public JsonRecordSource(final InputStream in, final StartingFieldStrategy
strategy, final String startingFieldName, TokenParserFactory
tokenParserFactory) throws IOException {
+jsonParser = tokenParserFactory.getJsonParser(in);
this.strategy = strategy;
-this.startingFieldName = startingFieldName;
-if (strategy == StartingFieldStrategy.NESTED_FIELD) {
-final SerializedString serializedNestedField = new
SerializedString(this.startingFieldName);
+if (StartingFieldStrategy.NESTED_FIELD.equals(strategy)) {
Review Comment:
The comparison of `enum` values should use `==` instead of `equals()`,
although both will work.
```suggestion
if (StartingFieldStrategy.NESTED_FIELD == strategy) {
```
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/yaml/TestYamlTreeRowRecordReader.java:
##
@@ -0,0 +1,1362 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.yaml;
+
+import org.apache.avro.Schema;
+import org.apache.commons.io.FileUtils;
+import org.apache.nifi.avro.AvroTypeUtil;
+import org.apache.nifi.json.JsonSchemaInference;
+import org.apache.nifi.json.JsonTreeRowRecordReader;
+import org.apache.nifi.json.SchemaApplicationStrategy;
+import org.apache.nifi.json.StartingFieldStrategy;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.schema.inference.InferSchemaAccessStrategy;
+import org.apache.nifi.schema.inference.TimeValueInference;
+import org.apache.nifi.serialization.MalformedRecordException;
+import org.apache.nifi.serialization.SimpleRecordSchema;
+import org.apache.nifi.serialization.record.DataType;
+import org.apache.nifi.serialization.record.MapRecord;
+import org.apache.nifi.serialization.record.Record;
+import org.apache.nifi.serialization.record.RecordField;
+import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.serialization.record.RecordSchema;
+import org.apache.nifi.serialization.record.type.ChoiceDataType;
+import org.apache.nifi.util.EqualsWrapper;
+import org.apache.nifi.util.MockComponentLog;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import java.util.function.BiPredicate;
+import java.util.function.Function;
+import java.util.stream.Collectors;
+
+import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.juni
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329265817 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: Yes I use for XPath assertions in place of the Groovy script which did assertions after using XMLSlurper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752: URL: https://github.com/apache/nifi/pull/7752#discussion_r1329265817 ## nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml: ## @@ -120,28 +120,34 @@ test -org.apache.groovy +org.xmlunit +xmlunit-core Review Comment: Yes I use it in place of the Groovy script which did assertions after using XMLSlurper -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329264503
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
+2.9.1
+test
+
+
+org.codehaus.groovy
groovy-json
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-jsr223
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-xml
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-dateutil
-${nifi.groovy.version}
+${scripting.groovy.version}
Review Comment:
@exceptionfactory Sure thing. I was just noticing that before I saw your
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
exceptionfactory commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329261733
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
Review Comment:
Is this dependency required?
##
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##
@@ -120,28 +120,34 @@
test
-org.apache.groovy
+org.xmlunit
+xmlunit-core
+2.9.1
+test
+
+
+org.codehaus.groovy
groovy-json
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-jsr223
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-xml
-${nifi.groovy.version}
+${scripting.groovy.version}
provided
-org.apache.groovy
+org.codehaus.groovy
groovy-dateutil
-${nifi.groovy.version}
+${scripting.groovy.version}
Review Comment:
These package and version changes should be reverted to match the current
main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12083) Upgrade Jetty to 9.4.52 on Support Branch
[ https://issues.apache.org/jira/browse/NIFI-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12083: Status: Patch Available (was: Open) > Upgrade Jetty to 9.4.52 on Support Branch > - > > Key: NIFI-12083 > URL: https://issues.apache.org/jira/browse/NIFI-12083 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 1.24.0 > > > Jetty 9.4.52 is a security release upgrade mitigating CVE-2023-40167 related > to invalid characters in the Content-Length header. > The project support branch should be upgraded to the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12041) Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java
[ https://issues.apache.org/jira/browse/NIFI-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-12041: Status: Patch Available (was: In Progress) > Convert Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to > Java > --- > > Key: NIFI-12041 > URL: https://issues.apache.org/jira/browse/NIFI-12041 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > > The unit tests to refactor are > # > /nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestSimpleScriptedLookupService.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/lookup/script/TestScriptedLookupService.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/processors/script/ExecuteScriptGroovyTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedReaderTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/record/script/ScriptedRecordSetWriterTest.groovy > # > ./nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/test/groovy/org/apache/nifi/reporting/script/ScriptedReportingTaskTest.groovy -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7753: NIFI-12083 Upgrade Jetty from 9.4.51 to 9.4.52
exceptionfactory opened a new pull request, #7753: URL: https://github.com/apache/nifi/pull/7753 # Summary [NIFI-12083](https://issues.apache.org/jira/browse/NIFI-12083) Upgrades Jetty from 9.4.51 to 9.4.52 on the support branch to mitigate CVE-2023-40167 and several other minor bugs that do not apply directly to project usage of Jetty libraries. The main branch is already using Jetty version 10.0.16 containing similar updates. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] dan-s1 opened a new pull request, #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.
dan-s1 opened a new pull request, #7752: URL: https://github.com/apache/nifi/pull/7752 # Summary [NIFI-12041](https://issues.apache.org/jira/browse/NIFI-12041) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12083) Upgrade Jetty to 9.4.52 on Support Branch
David Handermann created NIFI-12083: --- Summary: Upgrade Jetty to 9.4.52 on Support Branch Key: NIFI-12083 URL: https://issues.apache.org/jira/browse/NIFI-12083 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 1.24.0 Jetty 9.4.52 is a security release upgrade mitigating CVE-2023-40167 related to invalid characters in the Content-Length header. The project support branch should be upgraded to the latest version. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] joewitt commented on pull request #7751: NIFI-12081 Remove HackerOne from Security Reporting Methods
joewitt commented on PR #7751: URL: https://github.com/apache/nifi/pull/7751#issuecomment-1724333513 +1 please self merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12081) Remove HackerOne References for Security Reporting
[ https://issues.apache.org/jira/browse/NIFI-12081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12081: Status: Patch Available (was: Open) > Remove HackerOne References for Security Reporting > -- > > Key: NIFI-12081 > URL: https://issues.apache.org/jira/browse/NIFI-12081 > Project: Apache NiFi > Issue Type: Improvement >Reporter: David Handermann >Assignee: David Handermann >Priority: Trivial > Fix For: 1.latest, 2.latest > > > The Apache NiFi Project using the private mailing list > secur...@nifi.apache.org for receiving security reports and no longer uses > the project page on HackerOne. References to HackerOne should be removed from > the project website and security reporting guidelines. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory opened a new pull request, #7751: NIFI-12081 Remove HackerOne from Security Reporting Methods
exceptionfactory opened a new pull request, #7751: URL: https://github.com/apache/nifi/pull/7751 # Summary [NIFI-12081](https://issues.apache.org/jira/browse/NIFI-12081) The project uses the secur...@nifi.apache.org private email list for vulnerability reporting, so the link to HackerOne should be removed. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12082) Schema in JsonTreeReader documentation is invalid
[
https://issues.apache.org/jira/browse/NIFI-12082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12082:
Attachment: invalidSchema.pdf
> Schema in JsonTreeReader documentation is invalid
> -
>
> Key: NIFI-12082
> URL: https://issues.apache.org/jira/browse/NIFI-12082
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Priority: Minor
> Attachments: invalidSchema.pdf
>
>
> The schema in the JsonTreeReader documentation
> {code:java}
> {
> "namespace": "nifi",
> "name": "person",
> "type": "record",
> "fields": [
> { "name": "id", "type": "int" },
> { "name": "name", "type": "string" },
> { "name": "gender", "type": "string" },
> { "name": "dob", "type": {
> "type": "int",
> "logicalType": "date"
> }},
> { "name": "siblings", "type": {
> "type": "array",
> "items": {
> "type": "record",
> "fields": [
> { "name": "name", "type": "string" }
> ]
> }
> }}
> ]
> } {code}
> when loaded in a AvroSchemaRegistry results with the error message not a
> valid schema.
> The documentation should be corrected to have a schema that will load.
> Screenshot attached
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12082) Schema in JsonTreeReader documentation is invalid
[
https://issues.apache.org/jira/browse/NIFI-12082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12082:
Attachment: (was: invalidSchema.pdf)
> Schema in JsonTreeReader documentation is invalid
> -
>
> Key: NIFI-12082
> URL: https://issues.apache.org/jira/browse/NIFI-12082
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Priority: Minor
>
> The schema in the JsonTreeReader documentation
> {code:java}
> {
> "namespace": "nifi",
> "name": "person",
> "type": "record",
> "fields": [
> { "name": "id", "type": "int" },
> { "name": "name", "type": "string" },
> { "name": "gender", "type": "string" },
> { "name": "dob", "type": {
> "type": "int",
> "logicalType": "date"
> }},
> { "name": "siblings", "type": {
> "type": "array",
> "items": {
> "type": "record",
> "fields": [
> { "name": "name", "type": "string" }
> ]
> }
> }}
> ]
> } {code}
> when loaded in a AvroSchemaRegistry results with the error message not a
> valid schema.
> The documentation should be corrected to have a schema that will load.
> Screenshot attached
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12082) Schema in JsonTreeReader documentation is invalid
[
https://issues.apache.org/jira/browse/NIFI-12082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12082:
Description:
The schema in the JsonTreeReader documentation
{code:java}
{
"namespace": "nifi",
"name": "person",
"type": "record",
"fields": [
{ "name": "id", "type": "int" },
{ "name": "name", "type": "string" },
{ "name": "gender", "type": "string" },
{ "name": "dob", "type": {
"type": "int",
"logicalType": "date"
}},
{ "name": "siblings", "type": {
"type": "array",
"items": {
"type": "record",
"fields": [
{ "name": "name", "type": "string" }
]
}
}}
]
} {code}
when loaded in a AvroSchemaRegistry results with the error message not a valid
schema.
The documentation should be corrected to have a schema that will load.
Screenshot attached
was:
The schema in the JsonTreeReader documentation
{code:java}
{
"namespace": "nifi",
"name": "person",
"type": "record",
"fields": [
{ "name": "id", "type": "int" },
{ "name": "name", "type": "string" },
{ "name": "gender", "type": "string" },
{ "name": "dob", "type": {
"type": "int",
"logicalType": "date"
}},
{ "name": "siblings", "type": {
"type": "array",
"items": {
"type": "record",
"fields": [
{ "name": "name", "type": "string" }
]
}
}}
]
} {code}
when loaded in a AvroSchemaRegistry results with the error message not a valid
schema.
The documentation should be corrected to have a schema that will load.
Screenshot attached
[^invalidSchema.pdf]
> Schema in JsonTreeReader documentation is invalid
> -
>
> Key: NIFI-12082
> URL: https://issues.apache.org/jira/browse/NIFI-12082
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Priority: Minor
> Attachments: invalidSchema.pdf
>
>
> The schema in the JsonTreeReader documentation
> {code:java}
> {
> "namespace": "nifi",
> "name": "person",
> "type": "record",
> "fields": [
> { "name": "id", "type": "int" },
> { "name": "name", "type": "string" },
> { "name": "gender", "type": "string" },
> { "name": "dob", "type": {
> "type": "int",
> "logicalType": "date"
> }},
> { "name": "siblings", "type": {
> "type": "array",
> "items": {
> "type": "record",
> "fields": [
> { "name": "name", "type": "string" }
> ]
> }
> }}
> ]
> } {code}
> when loaded in a AvroSchemaRegistry results with the error message not a
> valid schema.
> The documentation should be corrected to have a schema that will load.
> Screenshot attached
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12082) Schema in JsonTreeReader documentation is invalid
[
https://issues.apache.org/jira/browse/NIFI-12082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-12082:
Description:
The schema in the JsonTreeReader documentation
{code:java}
{
"namespace": "nifi",
"name": "person",
"type": "record",
"fields": [
{ "name": "id", "type": "int" },
{ "name": "name", "type": "string" },
{ "name": "gender", "type": "string" },
{ "name": "dob", "type": {
"type": "int",
"logicalType": "date"
}},
{ "name": "siblings", "type": {
"type": "array",
"items": {
"type": "record",
"fields": [
{ "name": "name", "type": "string" }
]
}
}}
]
} {code}
when loaded in a AvroSchemaRegistry results with the error message not a valid
schema.
The documentation should be corrected to have a schema that will load.
Screenshot attached
[^invalidSchema.pdf]
was:
The schema in the JsonTreeReader documentation
{code:java}
{ "namespace": "nifi", "name": "person", "type": "record", "fields": [ {
"name": "id", "type": "int" }, { "name": "name", "type": "string" }, { "name":
"gender", "type": "string" }, { "name": "dob", "type": { "type": "int",
"logicalType": "date" }}, { "name": "siblings", "type": { "type": "array",
"items": { "type": "record", "fields": [ { "name": "name", "type": "string" } ]
} }} ] }
{code}
when loaded in a AvroSchemaRegistry results with the error message not a valid
schema.
The documentation should be corrected to have a schema that will load.
Screenshot attached
[^invalidSchema.pdf]
> Schema in JsonTreeReader documentation is invalid
> -
>
> Key: NIFI-12082
> URL: https://issues.apache.org/jira/browse/NIFI-12082
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Priority: Minor
> Attachments: invalidSchema.pdf
>
>
> The schema in the JsonTreeReader documentation
> {code:java}
> {
> "namespace": "nifi",
> "name": "person",
> "type": "record",
> "fields": [
> { "name": "id", "type": "int" },
> { "name": "name", "type": "string" },
> { "name": "gender", "type": "string" },
> { "name": "dob", "type": {
> "type": "int",
> "logicalType": "date"
> }},
> { "name": "siblings", "type": {
> "type": "array",
> "items": {
> "type": "record",
> "fields": [
> { "name": "name", "type": "string" }
> ]
> }
> }}
> ]
> } {code}
> when loaded in a AvroSchemaRegistry results with the error message not a
> valid schema.
> The documentation should be corrected to have a schema that will load.
> Screenshot attached
> [^invalidSchema.pdf]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12082) Schema in JsonTreeReader documentation is invalid
Daniel Stieglitz created NIFI-12082:
---
Summary: Schema in JsonTreeReader documentation is invalid
Key: NIFI-12082
URL: https://issues.apache.org/jira/browse/NIFI-12082
Project: Apache NiFi
Issue Type: Improvement
Reporter: Daniel Stieglitz
Attachments: invalidSchema.pdf
The schema in the JsonTreeReader documentation
{code:java}
{ "namespace": "nifi", "name": "person", "type": "record", "fields": [ {
"name": "id", "type": "int" }, { "name": "name", "type": "string" }, { "name":
"gender", "type": "string" }, { "name": "dob", "type": { "type": "int",
"logicalType": "date" }}, { "name": "siblings", "type": { "type": "array",
"items": { "type": "record", "fields": [ { "name": "name", "type": "string" } ]
} }} ] }
{code}
when loaded in a AvroSchemaRegistry results with the error message not a valid
schema.
The documentation should be corrected to have a schema that will load.
Screenshot attached
[^invalidSchema.pdf]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12081) Remove HackerOne References for Security Reporting
David Handermann created NIFI-12081: --- Summary: Remove HackerOne References for Security Reporting Key: NIFI-12081 URL: https://issues.apache.org/jira/browse/NIFI-12081 Project: Apache NiFi Issue Type: Improvement Reporter: David Handermann Assignee: David Handermann Fix For: 1.latest, 2.latest The Apache NiFi Project using the private mailing list secur...@nifi.apache.org for receiving security reports and no longer uses the project page on HackerOne. References to HackerOne should be removed from the project website and security reporting guidelines. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] greyp9 commented on a diff in pull request #7676: NIFI-12033 Add EncryptContentAge and DecryptContentAge Processors
greyp9 commented on code in PR #7676:
URL: https://github.com/apache/nifi/pull/7676#discussion_r1329165850
##
nifi-nar-bundles/nifi-cipher-bundle/nifi-cipher-processors/src/main/java/org/apache/nifi/processors/cipher/age/AgeKeyIndicator.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.cipher.age;
+
+import java.util.regex.Pattern;
+
+/**
+ * Pattern indicators for age-encryption.org public and private keys
+ */
+public enum AgeKeyIndicator {
+PRIVATE_KEY("AGE-SECRET-KEY-1",
Pattern.compile("^AGE-SECRET-KEY-1[QPZRY9X8GF2TVDW0S3JN54KHCE6MUA7L]{58}$")),
Review Comment:
Maybe a reference comment indicating the use of "Bech32Chars"?
(non-obvious)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] pvillard31 commented on pull request #7750: NIFI-12079 - WIP - Remove Variables / Variable Registry
pvillard31 commented on PR #7750: URL: https://github.com/apache/nifi/pull/7750#issuecomment-1724296281 The user guide still needs to be updated with new screenshots. I'll add this tomorrow but opening the draft PR to get some builds running and if someone wants to have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] pvillard31 opened a new pull request, #7750: NIFI-12079 - WIP - Remove Variables / Variable Registry
pvillard31 opened a new pull request, #7750: URL: https://github.com/apache/nifi/pull/7750 # Summary [NIFI-12079](https://issues.apache.org/jira/browse/NIFI-12079) - Remove Variables / Variable Registry # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12080) HashiCorp Vault parameter context kv2 compatability.
Robert D created NIFI-12080:
---
Summary: HashiCorp Vault parameter context kv2 compatability.
Key: NIFI-12080
URL: https://issues.apache.org/jira/browse/NIFI-12080
Project: Apache NiFi
Issue Type: Improvement
Components: Core Framework
Affects Versions: 1.20.0
Environment: Tested on OpenShift 4.11 and local environment.
Reporter: Robert D
Attachments: image-2023-09-18-15-54-55-187.png,
image-2023-09-18-15-55-10-366.png
When trying to use hashicorp vault with a kv2 backend I can successfully
authenticate with vault but trying to use a parameter provider it can't list
any secrets.
I believe it's because {{KeyValueBackend.KV_1}} is hardcoded in the
{{listKeyValueSecrets}} function instead of using the member variable
{{{}keyValueBackend{}}}.
The code can be seen
[here|https://github.com/apache/nifi/blob/main/nifi-commons/nifi-hashicorp-vault/src/main/java/org/apache/nifi/vault/hashicorp/StandardHashiCorpVaultCommunicationService.java#L148].
!image-2023-09-18-15-54-55-187.png!
!image-2023-09-18-15-55-10-366.png!
After that is changed to {{keyValueBackend}} another issue that comes up is
that it can only list the top level secrets.
This is because {{listKeyValueSecrets}} hardcodes the path to the [root
path|https://github.com/apache/nifi/blob/main/nifi-commons/nifi-hashicorp-vault/src/main/java/org/apache/nifi/vault/hashicorp/StandardHashiCorpVaultCommunicationService.java#L149].
For example if there is a secret under the path {{shared/test}} it is
inaccessible.
Adding the {{shared}} path to the Key/Value path parameter also doesn't fix it
because Vault expects the metadata path after the kv engine.
A valid path would be {{/kv/metadata/shared/?list=true}} adding {{shared }}to
the Key/Value path makes a request to {{{}/kv/shared/metadata/?list=true{}}}.
Adding a parameter to the {{listKeyValueSecrets}} function to specify the
secret path fixes it.
In the parameter provider it says it's for Key/Value version 1 secrets but
after these changes I could use it with a kv2 backend. The only downside is
that it can only get the latest version of the secret but that is good enough
for my usecase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi] dependabot[bot] opened a new pull request, #7749: Bump org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r in /nifi-nar-bundles/nifi-framework-bundle
dependabot[bot] opened a new pull request, #7749: URL: https://github.com/apache/nifi/pull/7749 Bumps org.eclipse.jgit:org.eclipse.jgit from 4.3.1.201605051710-r to 6.6.1.202309021850-r. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/nifi/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-12079) Remove Variables / Variable Registry
Pierre Villard created NIFI-12079: - Summary: Remove Variables / Variable Registry Key: NIFI-12079 URL: https://issues.apache.org/jira/browse/NIFI-12079 Project: Apache NiFi Issue Type: Improvement Reporter: Pierre Villard Assignee: Pierre Villard Fix For: 2.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-4703) Unable to use EL for Hostname and Port on PutTCP processor
[ https://issues.apache.org/jira/browse/NIFI-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-4703. -- Resolution: Not A Problem > Unable to use EL for Hostname and Port on PutTCP processor > -- > > Key: NIFI-4703 > URL: https://issues.apache.org/jira/browse/NIFI-4703 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.4.0 >Reporter: Gino Lisignoli >Priority: Minor > Attachments: PutTCP-EL.xml > > > Although https://github.com/apache/nifi/pull/1361 was merged into master, it > doesn't seem to function. > When setting a dynamic port in the PutTCP processor, the processor produces > the error: > PutTCP[id=01601006-15cf-1651-ca50-f9597b0f303f] > PutTCP[id=01601006-15cf-1651-ca50-f9597b0f303f] failed to process session due > to java.lang.NumberFormatException: For input string: "": For input string: "" > See attached dataflow -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-4720) Expression Language guide explanation of order of evaluating an attribute is out of date
[
https://issues.apache.org/jira/browse/NIFI-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-4720.
--
Resolution: Won't Do
Removal of variables for NiFi 2.0
> Expression Language guide explanation of order of evaluating an attribute is
> out of date
>
>
> Key: NIFI-4720
> URL: https://issues.apache.org/jira/browse/NIFI-4720
> Project: Apache NiFi
> Issue Type: Bug
> Components: Documentation & Website
>Reporter: Joe Percivall
>Priority: Minor
>
> In the Expression Language guide, under "Structure of a NiFi Expression"[1],
> it explains the order in which the different sources of attribute values are
> processed but doesn't include recent updates to EL. Essentially, this should
> summarize the resolution precedence stated in the User Guide[2].
> {quote}In this example, the value to be returned is the value of the "my
> attribute" value, if it exists. If that attribute does not exist, the
> Expression Language will then look for a System Environment Variable named
> "my attribute." If unable to find this, it will look for a JVM System
> Property named "my attribute." Finally, if none of these exists, the
> Expression Language will return a null value.{quote}
> [1]
> https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#structure
> [2]
> https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#Using_Custom_Properties
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-6493) Allow components access to the VariableRegistry
[ https://issues.apache.org/jira/browse/NIFI-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-6493. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Allow components access to the VariableRegistry > --- > > Key: NIFI-6493 > URL: https://issues.apache.org/jira/browse/NIFI-6493 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Jon Kessler >Priority: Minor > > I believe it would be beneficial to allow processors and controller services > read and write access to their process group's variable registry through the > framework. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-3046) Use Variable Registry to populate fields that do not currently support EL
[ https://issues.apache.org/jira/browse/NIFI-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-3046. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Use Variable Registry to populate fields that do not currently support EL > - > > Key: NIFI-3046 > URL: https://issues.apache.org/jira/browse/NIFI-3046 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Reporter: Ryan Persaud >Priority: Minor > > My organization has NiFi instances with identical flows running in different > environments and we would like to take advantage of the ability to substitute > values from the Variable Registry into processor properties. This works > great for fields like 'Topic Name' in PutKafka that support Expression > Language (EL), but it does not work for fields like 'Known Brokers' that do > not support EL. > Would it be worth my while to enable EL for these fields and issue a Pull > Request, or is there another approach in mind for allowing these fields to be > populated from the Variable Registry? Thanks for the information. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-4721) Single quotes within a process group name causes the characters ' within the Variables menu
[ https://issues.apache.org/jira/browse/NIFI-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-4721. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Single quotes within a process group name causes the characters ' within > the Variables menu > --- > > Key: NIFI-4721 > URL: https://issues.apache.org/jira/browse/NIFI-4721 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Joe Percivall >Priority: Minor > Attachments: Screen Shot 2017-12-21 at 8.50.37 PM.png > > > Found while testing NiFi-4436: > I set the process group name to "Developer's_first versioned process group" > Within the Variables configuration window I see "Developer's_first > versioned process group" as the name under "Process Group". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-6601) Variables: "Apply" button should be greyed out if no changes have been made
[ https://issues.apache.org/jira/browse/NIFI-6601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-6601. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Variables: "Apply" button should be greyed out if no changes have been made > --- > > Key: NIFI-6601 > URL: https://issues.apache.org/jira/browse/NIFI-6601 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Reporter: Andrew M. Lim >Priority: Minor > > After opening the Variables window, the "Apply" button is available for > selection immediately even when no edits have been made to apply. If > selected, the window is closed which is what the Cancel button is for. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-5016) UI - Variables view with long processor names
[ https://issues.apache.org/jira/browse/NIFI-5016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-5016. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > UI - Variables view with long processor names > - > > Key: NIFI-5016 > URL: https://issues.apache.org/jira/browse/NIFI-5016 > Project: Apache NiFi > Issue Type: Improvement > Components: Core UI >Affects Versions: 1.5.0 > Environment: Firefox 59.0.1 >Reporter: Pierre Villard >Priority: Major > Attachments: Screen Shot 2018-03-26 at 9.28.30 PM.png, Screen Shot > 2018-03-26 at 9.28.37 PM.png > > > In case you have processors with very long names the diplay of the > referencing components in the variables view of a process group is not > perfect (see attached pictures) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-3311) Variable Registry Enhancements
[ https://issues.apache.org/jira/browse/NIFI-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-3311. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Variable Registry Enhancements > -- > > Key: NIFI-3311 > URL: https://issues.apache.org/jira/browse/NIFI-3311 > Project: Apache NiFi > Issue Type: Improvement > Components: SDLC, Variable Registry >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Major > > This is an initial parent ticket to capture work and efforts to enhance the > variable registry. > An initial design and view of areas to cover is included in a feature > proposal located at > https://cwiki.apache.org/confluence/display/NIFI/Variable+Registry. > Subcomponents of this effort should be treated as subtasks/linked where > needed and design and specific tasks are further established. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-2767) Periodically reload properties from file-based variable registry properties files
[ https://issues.apache.org/jira/browse/NIFI-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-2767. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Periodically reload properties from file-based variable registry properties > files > - > > Key: NIFI-2767 > URL: https://issues.apache.org/jira/browse/NIFI-2767 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joey Frazee >Priority: Minor > > Currently FileBasedVariableRegistry only loads properties when it is injected > into the flow controller so making updates to the properties requires a > restart. > Management of data flows would be much easier if these changes could be > picked up without doing a (rolling) restart. It'd be helpful from an > administrative standpoint if the FileBasedVariableRegistry reloaded > properties from the properties files periodically. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-5296) Add EL Support with Variable Registry scope on SSL context service
[ https://issues.apache.org/jira/browse/NIFI-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-5296. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Add EL Support with Variable Registry scope on SSL context service > -- > > Key: NIFI-5296 > URL: https://issues.apache.org/jira/browse/NIFI-5296 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > > Add EL support on Truststore and Keystore filename properties with Variable > Registry scope. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-2653) Encrypted configs should handle variable registry
[ https://issues.apache.org/jira/browse/NIFI-2653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-2653. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Encrypted configs should handle variable registry > - > > Key: NIFI-2653 > URL: https://issues.apache.org/jira/browse/NIFI-2653 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration, Tools and Build >Affects Versions: 1.0.0 >Reporter: Andy LoPresto >Assignee: Andy LoPresto >Priority: Major > Labels: config, encryption, security > > The encrypted configuration tool and internal logic to load unprotected > values should handle sensitive values contained in the variable registry > (perhaps with a unique/derived key for external containers). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-3110) Allow template export to include variable registry references for sensitive values
[
https://issues.apache.org/jira/browse/NIFI-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-3110.
--
Resolution: Won't Do
Removal of variables for NiFi 2.0
> Allow template export to include variable registry references for sensitive
> values
> --
>
> Key: NIFI-3110
> URL: https://issues.apache.org/jira/browse/NIFI-3110
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Andy LoPresto
>Priority: Major
>
> By design, templates do not include any processor properties marked as
> *sensitive* by the {{PropertyDescriptor}} (e.g. encryption password, JDBC
> connection password, etc.). This is to prevent accidental data leakage when
> templates are exported and shared.
> Now that the [Variable
> Registry|https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html#custom_properties]
> is available, templates should be able to export the value of a sensitive
> property _*if and only if*_ it can be determined that the value is a
> reference to an entry in the Variable Registry rather than a literal
> sensitive value. This will support the efforts for enhancing the "SDLC"
> process of promoting flows from "development" to "QA/QE" and "production"
> environments, as the template/flow will not need to be modified to reference
> the distinct values (under the same reference) in each environment.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-5367) Enable EL support with Variable Registry scope by default
[
https://issues.apache.org/jira/browse/NIFI-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-5367.
--
Fix Version/s: (was: 2.0.0)
Resolution: Won't Do
Removal of variables for NiFi 2.0
> Enable EL support with Variable Registry scope by default
> -
>
> Key: NIFI-5367
> URL: https://issues.apache.org/jira/browse/NIFI-5367
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Pierre Villard
>Priority: Major
>
> With the Variable Registry feature in NiFi and the FDLC concepts with the
> NiFi Registry, there is a lot of traction to enable Expression Language with
> Variable Registry scope by default.
> I suggest we change the current behavior so that Variable Registry scope is
> set as the default scope even though {{.expressionLanguageSupported()}} is
> not specified when creating the property. However it should still be possible
> for a developer to disable Expression Language evaluation by setting the EL
> scope to None (it can make sense for properties expecting a regular
> expression for instance)
> This is going to be a breaking change for existing flows and that's why I'm
> tagging this JIRA for 2.0.0 for the time being. I believe this change should
> also be considered in a more global effort regarding how we can manage the
> sensitive properties with the Variable Registry (see discussion in NIFI-5296).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-5758) Duplicate Variables
[ https://issues.apache.org/jira/browse/NIFI-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-5758. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > Duplicate Variables > --- > > Key: NIFI-5758 > URL: https://issues.apache.org/jira/browse/NIFI-5758 > Project: Apache NiFi > Issue Type: Bug > Components: Variable Registry >Affects Versions: 1.7.1 >Reporter: Joseph Rosado >Priority: Major > Attachments: nifi-duplicate-variables.PNG > > > We have a process group with variables defined for the entire flow. However, > the variables are duplicated in each nested process group. Therefore, making > it difficult to manage, and identify issues. (see attached) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-6499) Add variables on templates
[
https://issues.apache.org/jira/browse/NIFI-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard resolved NIFI-6499.
--
Resolution: Won't Do
Removing variables and templates for NiFi 2.0
> Add variables on templates
> --
>
> Key: NIFI-6499
> URL: https://issues.apache.org/jira/browse/NIFI-6499
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
>Reporter: Raymond
>Priority: Major
>
> I would like to set variables on creating a template. Currently, a template
> is copy. On some parameters I would like to set as variable (or part of the
> parameter value as variable).
> On instantiating the template the variables are set by the user. After
> instantiation the variables are fixed text. So the variables are not runtime
> variables, by only designtime variables (similar to Maven archetypes).
> Now I do it like this.
> 1) Set parameters/values like this: ${variableName}
> 2) Export the template
> 3) Search ${variableName} and replace by new value
> 4) Import the template
> Maybe this could be part of
> "[https://cwiki.apache.org/confluence/display/NIFI/Better+Support+for+Parameterizing+Flows]";,
> but that seems to focus on runtime.
>
> h3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-6098) NiFi Expression Language inside variable
[ https://issues.apache.org/jira/browse/NIFI-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-6098. -- Resolution: Won't Do Removal of variables for NiFi 2.0 > NiFi Expression Language inside variable > > > Key: NIFI-6098 > URL: https://issues.apache.org/jira/browse/NIFI-6098 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework, Variable Registry >Affects Versions: 1.9.0 >Reporter: Rabits >Priority: Major > > It will be a great improvement if variables could contain NFEL expressions - > so there could be a number of evaluate iterations to get the actual value. > This improvement could make possible to actually create modules out of > processing groups with dynamic interfaces based on the environment. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-7056) UI - Duplicate Variables
[ https://issues.apache.org/jira/browse/NIFI-7056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7056. -- Resolution: Won't Do Removing variables for NiFi 2.0 > UI - Duplicate Variables > > > Key: NIFI-7056 > URL: https://issues.apache.org/jira/browse/NIFI-7056 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Reporter: Matt Gilman >Assignee: Nagasivanath Dasari >Priority: Major > > When listing variables for a Process Group, the same variable could be listed > twice. This can happen when the response from the server is very slow and the > user clicks to see the Variable listing again. We should prevent this > possibly by: > - Reviewing what uniquely identifies rows in the variable table and ensuring > this cannot happen. > - If there are multiple outstanding requests only processing a single > response. > - Consider approaches that would more clearly show when there is an > outstanding request. This would prevent the action from being taken a second > time. If we choose to implement this, we should do so in its own JIRA and > link accordingly. > - Consider why the Variables response is taking so long to return. If we > choose to investigate here, we should do so in its own JIRA and link > accordingly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (NIFI-7875) nifi.variable.registry.properties value cleared in nifi.properties at startup
[ https://issues.apache.org/jira/browse/NIFI-7875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7875. -- Resolution: Won't Do Removing the concept of variables for NiFi 2.0 > nifi.variable.registry.properties value cleared in nifi.properties at startup > - > > Key: NIFI-7875 > URL: https://issues.apache.org/jira/browse/NIFI-7875 > Project: Apache NiFi > Issue Type: Bug > Components: Configuration, Variable Registry >Affects Versions: 1.12.1 > Environment: docker container >Reporter: Douglas Cooper >Priority: Major > Labels: workaround > > The nifi.variable.registry.properties variable in nifi.properties gets > cleared at startup. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1654: MINIFICPP-2214 Fix extension list inconsistencies in build scripts
fgerlits commented on code in PR #1654: URL: https://github.com/apache/nifi-minifi-cpp/pull/1654#discussion_r1328451795 ## win_build_vs.bat: ## @@ -24,37 +24,35 @@ set scriptdir=%~dp0 set skiptests=OFF set skiptestrun=OFF set cmake_build_type=Release -set build_platform=Win32 -set build_kafka=OFF -set build_coap=OFF -set build_jni=OFF -set build_SQL=OFF -set build_AWS=OFF -set build_SFTP=OFF -set build_azure=OFF +set build_platform=x64 +set enable_kafka=ON +set enable_coap=OFF Review Comment: it doesn't really matter, but there is another `set enable_coap=OFF` at line 36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1659: MINIFICPP-2218 Refactor expected monadic functions
fgerlits commented on code in PR #1659:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1659#discussion_r1328928477
##
libminifi/include/utils/expected.h:
##
@@ -31,28 +29,42 @@ inline constexpr bool is_expected_v = false;
template
inline constexpr bool is_expected_v> = true;
-// map implementation
-template>>>
-auto operator|(Expected&& object, map_wrapper f) {
- using value_type = typename utils::remove_cvref_t::value_type;
- using error_type = typename utils::remove_cvref_t::error_type;
- if constexpr (std::is_same_v) {
-using function_return_type =
std::decay_t(f.function)))>;
+template
+concept expected = is_expected_v>;
+
+template
+inline constexpr bool is_valid_unexpected_type_v = std::is_same_v> && std::is_object_v && !std::is_array_v;
+
+template
+inline constexpr bool is_valid_unexpected_type_v> =
false;
Review Comment:
This `T` is different from the `T` parameters in lines 35 and 41. Can we
rename it to something else, eg. `E`, please?
##
libminifi/test/unit/ExpectedTest.cpp:
##
@@ -484,3 +484,63 @@ TEST_CASE("expected valueOrElse",
"[expected][valueOrElse]") {
REQUIRE_THROWS_AS(ex | utils::valueOrElse([](const std::string&) -> int {
throw std::exception(); }), std::exception);
REQUIRE_THROWS_AS(std::move(ex) | utils::valueOrElse([](std::string&&) ->
int { throw std::exception(); }), std::exception);
}
+
+TEST_CASE("expected transformError", "[expected][transformError]") {
+ auto mul2 = [](int a) { return a * 2; };
+
+ {
+nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = e | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+const nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = e | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = std::move(e) | utils::transformError(mul2);
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
+
+ {
+const nonstd::expected e = nonstd::make_unexpected(21);
+auto ret = std::move(e) | utils::transformError(mul2); //
NOLINT(performance-move-const-arg)
+REQUIRE(!ret);
+REQUIRE(ret.error() == 42);
+ }
Review Comment:
I think `clang-tidy` has a point here: this test doesn't make much sense,
since we can't move from a `const` variable. I would remove this test case,
and the others marked with `NOLINT(performance-move-const-arg)`, too. Maybe
they could be replaced with more realistic tests where the `expected` comes
from the return value of a function.
##
libminifi/include/utils/expected.h:
##
@@ -61,56 +73,54 @@ auto operator|(Expected&& object, map_wrapper f) {
}
}
-// flatMap
-template>>>
-auto operator|(Expected&& object, flat_map_wrapper f) {
- using value_type = typename utils::remove_cvref_t::value_type;
- if constexpr (std::is_same_v) {
-using function_return_type =
std::decay_t(f.function)))>;
+// andThen
+template
+auto operator|(Expected&& object, and_then_wrapper f) {
+ using value_type = typename std::remove_cvref_t::value_type;
+ if constexpr (!std::is_void_v) {
Review Comment:
Why did you flip this? Before, we always dealt with the `void` case first
and the non-`void` case second. Now, it is the other way round in this one
instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] turcsanyip opened a new pull request, #7748: NIFI-12075: Deprecated log methods with Object[] + Throwable paramete…
turcsanyip opened a new pull request, #7748: URL: https://github.com/apache/nifi/pull/7748 …rs in ComponentLog # Summary [NIFI-12075](https://issues.apache.org/jira/browse/NIFI-12075) The PR migrates all `error(String msg, Object[] os, Throwable t)` calls to `error(String msg, Object... os)` (for all error levels) and also marks the `Object[]` methods deprecated on the `ComponentLog` interface. This PR is for the `main` branch only. `support/1.x` contains additional components (that were removed on the main branch) and a separate PR will be created for that branch (based on this one and also adding the extra logging changes for those components). # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11481) Migrate the Nifi UI to a currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766450#comment-17766450 ] Matt Gilman commented on NIFI-11481: I've begun working on this effort. As a part of this migration, I am moving away from other legacy front-end dependencies and any server-side markup generation. By removing server-side markup generation it will support faster front-end development iterations. There are a number of different UIs that we need to account for: * Canvas * Custom UIs (Update Attribute, JoltTransformJSON) * Content Viewers (JSON, Text, AVRO, etc) * Documentations * Error Handling Each of these has different levels of effort and presents different challenges. My initial focus will be updating the primary NiFi canvas. Updates for the other UIs can land in follow-on efforts. The existing canvas UX will be retained to limit the size of the effort. This will allow us to continue using the existing UIs and transition each one in time. I plan to introduce the updated UI as a separate maven module that is not included by default. A build profile can be used to include it. If the UI is included it will be deployed in a separate context path and will be available next to the existing UI. Once everything is working well and we are comfortable with the migration, we can submit another PR that removes the existing UI in favor of the new one. I don't have a timeframe for a PR just yet but I've made good progress so far. Folks can follow along here [1]. [1] https://github.com/mcgilman/nifi/commits/NIFI-11481 > Migrate the Nifi UI to a currently supported/active framework > - > > Key: NIFI-11481 > URL: https://issues.apache.org/jira/browse/NIFI-11481 > Project: Apache NiFi > Issue Type: Wish > Components: Core UI >Reporter: Dondi Imperial >Assignee: Matt Gilman >Priority: Major > > AngularJS support [officially ended as of January > 2020|https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429]. > This can be problematic in environments with strict compliance requirements. > Perhaps the Nifi UI should be refactored or upgraded to Angular (non-JS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] exceptionfactory commented on pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
exceptionfactory commented on PR #7744: URL: https://github.com/apache/nifi/pull/7744#issuecomment-1723731868 > @exceptionfactory I've made the requested change and rebased to latest main so it is just the one clean commit that gets us to the finish line for the build. I'll update this tomorrow or Wed once the official Java 21 based Github CI entries are available. Sounds great, thanks @joewitt! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
joewitt commented on PR #7744: URL: https://github.com/apache/nifi/pull/7744#issuecomment-1723727815 @exceptionfactory I've made the requested change and rebased to latest main so it is just the one clean commit that gets us to the finish line for the build. I'll update this tomorrow or Wed once the official Java 21 based Github CI entries are available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-11481) Migrate the Nifi UI to a currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-11481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-11481: -- Assignee: Matt Gilman > Migrate the Nifi UI to a currently supported/active framework > - > > Key: NIFI-11481 > URL: https://issues.apache.org/jira/browse/NIFI-11481 > Project: Apache NiFi > Issue Type: Wish > Components: Core UI >Reporter: Dondi Imperial >Assignee: Matt Gilman >Priority: Major > > AngularJS support [officially ended as of January > 2020|https://blog.angular.io/finding-a-path-forward-with-angularjs-7e186fdd4429]. > This can be problematic in environments with strict compliance requirements. > Perhaps the Nifi UI should be refactored or upgraded to Angular (non-JS). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2221) Auto-generate CONTROLLERS.md
[ https://issues.apache.org/jira/browse/MINIFICPP-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-2221: -- Fix Version/s: 0.16.0 > Auto-generate CONTROLLERS.md > > > Key: MINIFICPP-2221 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2221 > Project: Apache NiFi MiNiFi C++ > Issue Type: Task >Reporter: Ferenc Gerlits >Assignee: Ferenc Gerlits >Priority: Minor > Fix For: 0.16.0 > > > In the same way as we currently auto-generate PROCESSORS.md, we should > auto-generate CONTROLLERS.md, as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] joewitt commented on a diff in pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
joewitt commented on code in PR #7744: URL: https://github.com/apache/nifi/pull/7744#discussion_r1328897455 ## nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/pom.xml: ## @@ -412,6 +412,15 @@ + +org.apache.maven.plugins +maven-surefire-plugin + + +--add-opens java.base/java.net=ALL-UNNAMED Review Comment: added comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #7744: NIFI-12053 - Update Github CI Builds for 2.x line to Java 21 images Update NiFi Docs/Readme to reference Java 21 as basis
joewitt commented on PR #7744: URL: https://github.com/apache/nifi/pull/7744#issuecomment-1723697916 @ChrisSamo632 Correct that will be covered in another JIRA which is filed https://issues.apache.org/jira/browse/NIFI-12074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2221) Auto-generate CONTROLLERS.md
Ferenc Gerlits created MINIFICPP-2221: - Summary: Auto-generate CONTROLLERS.md Key: MINIFICPP-2221 URL: https://issues.apache.org/jira/browse/MINIFICPP-2221 Project: Apache NiFi MiNiFi C++ Issue Type: Task Reporter: Ferenc Gerlits Assignee: Ferenc Gerlits In the same way as we currently auto-generate PROCESSORS.md, we should auto-generate CONTROLLERS.md, as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi] mr1716 opened a new pull request, #7747: NIFI-12043 Update mariadb-java-client to 3.2.0
mr1716 opened a new pull request, #7747: URL: https://github.com/apache/nifi/pull/7747 # Summary [NIFI-12043](https://issues.apache.org/jira/browse/NIFI-12043) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-12043) issue created ### Pull Request Tracking - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [X] Pull Request based on current revision of the `main` branch - [X] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 17 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
lordgamez commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1328895277 ## libminifi/include/utils/TimeUtil.h: ## @@ -35,15 +35,15 @@ #include "StringUtils.h" // libc++ doesn't define operator<=> on durations, and apparently the operator rewrite rules don't automagically make one -#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 16000 +#if defined(_LIBCPP_VERSION) Review Comment: Good point, added assertion in f6ef8374a948b777cb5b2e4396768cbc092793d5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
fgerlits commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1328737637 ## libminifi/include/utils/TimeUtil.h: ## @@ -35,15 +35,15 @@ #include "StringUtils.h" // libc++ doesn't define operator<=> on durations, and apparently the operator rewrite rules don't automagically make one -#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 16000 +#if defined(_LIBCPP_VERSION) Review Comment: `operator<=>(duration, duration)` works on compiler explorer with libc++ trunk, so I think we can assume this will be fixed in version 17.0. I would prefer to change `< 16000` to `< 17000`, as that would make it more likely that we'll remove this workaround when it's no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
fgerlits commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1328737637 ## libminifi/include/utils/TimeUtil.h: ## @@ -35,15 +35,15 @@ #include "StringUtils.h" // libc++ doesn't define operator<=> on durations, and apparently the operator rewrite rules don't automagically make one -#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 16000 +#if defined(_LIBCPP_VERSION) Review Comment: `operator<=>(duration, duration)` works on compiler explorer with libc++ trunk, so I think we can assume this will be fixed in version 17.0. I would prefer to change `< 16000` to `< 17000`, as that makes it less likely that we'll remove this workaround when it's no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI
fgerlits commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1328737637 ## libminifi/include/utils/TimeUtil.h: ## @@ -35,15 +35,15 @@ #include "StringUtils.h" // libc++ doesn't define operator<=> on durations, and apparently the operator rewrite rules don't automagically make one -#if defined(_LIBCPP_VERSION) && _LIBCPP_VERSION < 16000 +#if defined(_LIBCPP_VERSION) Review Comment: According to cppreference, `operator<=>(duration, duration)` should exist in C++20, so this looks like a bug/not-yet-implemented feature. Can we add a static assert here which will fail when `libc++` fixes/implements this? Otherwise, we won't notice that this workaround can be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-11789) ExecuteSQL doesn't set fragment.count attribute when Output Batch Size is set
[ https://issues.apache.org/jira/browse/NIFI-11789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766384#comment-17766384 ] Tamas Neumer commented on NIFI-11789: - Hi! Can we expect this fix to be in the next release? Thank you! KR, Tamas > ExecuteSQL doesn't set fragment.count attribute when Output Batch Size is set > - > > Key: NIFI-11789 > URL: https://issues.apache.org/jira/browse/NIFI-11789 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Reporter: Tamas Neumer >Assignee: Matt Burgess >Priority: Minor > Fix For: 1.latest, 2.latest > > Time Spent: 10m > Remaining Estimate: 0h > > Hi, > I am working with the ExecuteSQL processor and discovered an unexpected > behavior. If I specify the attribute "Output Batch Size", I get the > fragment.index on the outflowing flowing Flowfiles, but the fragment.count > attribute is not set (according to the documentation). > The behavior I would expect (in line with how merge processors work) is that > the attribute fragment.count is just set at the last Flowfile for the batch. > This would make it possible to merge all the batches together afterward. > So my proposal, in short, is that the fragment.count should be set in the > last Flowfile of a batch. > BR Florian -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-11852) CLI - connect two process groups
[
https://issues.apache.org/jira/browse/NIFI-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11852:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> CLI - connect two process groups
>
>
> Key: NIFI-11852
> URL: https://issues.apache.org/jira/browse/NIFI-11852
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11627) Add Dynamic Schema References to ValidateJSON Processor
[
https://issues.apache.org/jira/browse/NIFI-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766371#comment-17766371
]
Daniel Stieglitz commented on NIFI-11627:
-
[~exceptionfactory] I understand a FlowFile attribute cannot be used as a
dynamic reference to a Parameter Context value but could we still allow for
specifying the schema in an attribute much like the JoltTransformJSON allows
for specifying the Jolt spec either in an attribute or from a resource? This
would allow for the use of one instance of ValidateJson.
> Add Dynamic Schema References to ValidateJSON Processor
> ---
>
> Key: NIFI-11627
> URL: https://issues.apache.org/jira/browse/NIFI-11627
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
>Affects Versions: 1.19.1
>Reporter: Chuck Tilly
>Assignee: Daniel Stieglitz
>Priority: Major
>
> For the ValidateJSON processor, add support for flowfile attribute references
> that will allow for a JSON schema located in the Parameter Contexts, to be
> referenced dynamically based on a flowfile attribute. e.g.
> {code:java}
> #{${schema.name}} {code}
>
> The benefits of adding support for attribute references are significant.
> Adding this capability will allow a single processor to be used for all JSON
> schema validation. Unfortunately, the current version of this processor
> requires a dedicated processor for every schema, i.e. 12 schemas requires 12
> ValidateJSON processors. This is very laborious to construct and maintain,
> and resource expensive.
> ValidateJSON processor (https://issues.apache.org/jira/browse/NIFI-7392)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12078) Add JDBC Catalog Controller Service for Iceberg processors
Mark Bathori created NIFI-12078: --- Summary: Add JDBC Catalog Controller Service for Iceberg processors Key: NIFI-12078 URL: https://issues.apache.org/jira/browse/NIFI-12078 Project: Apache NiFi Issue Type: New Feature Reporter: Mark Bathori Assignee: Mark Bathori Add JDBC Catalog support as Controller Service for Iceberg processors. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1651: MINIFICPP-2193 - Add manifest to debug bundle
adamdebreceni commented on code in PR #1651: URL: https://github.com/apache/nifi-minifi-cpp/pull/1651#discussion_r1328500279 ## libminifi/src/c2/C2Agent.cpp: ## @@ -686,6 +686,23 @@ C2Payload C2Agent::bundleDebugInfo(std::mapgetAgentManifest(); +state::response::SerializedResponseNode manifest; +manifest.name = std::move(reported_manifest.name); +manifest.children = std::move(reported_manifest.serialized_nodes); +manifest.array = reported_manifest.is_array; Review Comment: makes sense, we don't actually even need the variable, refactored -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1651: MINIFICPP-2193 - Add manifest to debug bundle
adamdebreceni commented on code in PR #1651: URL: https://github.com/apache/nifi-minifi-cpp/pull/1651#discussion_r1328499308 ## libminifi/src/c2/C2Agent.cpp: ## @@ -686,6 +686,23 @@ C2Payload C2Agent::bundleDebugInfo(std::map
[jira] [Commented] (NIFI-11852) CLI - connect two process groups
[
https://issues.apache.org/jira/browse/NIFI-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766305#comment-17766305
]
ASF subversion and git services commented on NIFI-11852:
Commit 7fc8455e1daebf2416edcc3131decfccde11d0d6 in nifi's branch
refs/heads/support/nifi-1.x from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7fc8455e1d ]
NIFI-11852 - CLI - connect two process groups
Backported
This closes #7527
Signed-off-by: Nandor Soma Abonyi
(cherry picked from commit dcf42d01a4d31f3dc8a7fad8618659bb8c7248c5)
> CLI - connect two process groups
>
>
> Key: NIFI-11852
> URL: https://issues.apache.org/jira/browse/NIFI-11852
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-11852) CLI - connect two process groups
[
https://issues.apache.org/jira/browse/NIFI-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-11852:
--
Fix Version/s: 2.0.0
1.24.0
(was: 1.latest)
(was: 2.latest)
> CLI - connect two process groups
>
>
> Key: NIFI-11852
> URL: https://issues.apache.org/jira/browse/NIFI-11852
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 2.0.0, 1.24.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-11852) CLI - connect two process groups
[
https://issues.apache.org/jira/browse/NIFI-11852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766300#comment-17766300
]
ASF subversion and git services commented on NIFI-11852:
Commit dcf42d01a4d31f3dc8a7fad8618659bb8c7248c5 in nifi's branch
refs/heads/main from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=dcf42d01a4 ]
NIFI-11852 - CLI - connect two process groups
This closes #7527
Signed-off-by: Nandor Soma Abonyi
> CLI - connect two process groups
>
>
> Key: NIFI-11852
> URL: https://issues.apache.org/jira/browse/NIFI-11852
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
> Fix For: 1.latest, 2.latest
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12077) CLI - make LB Strategy and Prioritizers configurable when connecting two process groups
[ https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Soma Abonyi updated NIFI-12077: -- Summary: CLI - make LB Strategy and Prioritizers configurable when connecting two process groups (was: CLI -LB Strategy and Prioritizers configurable when connecting two process groups) > CLI - make LB Strategy and Prioritizers configurable when connecting two > process groups > --- > > Key: NIFI-12077 > URL: https://issues.apache.org/jira/browse/NIFI-12077 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Nandor Soma Abonyi >Priority: Major > > Make it possible to configure the same set of properties that are available > on the UI? Like "Load Balancing Strategy" and "Selected Prioritizers". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12077) CLI -LB Strategy and Prioritizers configurable when connecting two process groups
[ https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Soma Abonyi updated NIFI-12077: -- Summary: CLI -LB Strategy and Prioritizers configurable when connecting two process groups (was: CLI - connect two process groups, make LB Strategy and Prioritizers configurable) > CLI -LB Strategy and Prioritizers configurable when connecting two process > groups > - > > Key: NIFI-12077 > URL: https://issues.apache.org/jira/browse/NIFI-12077 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Nandor Soma Abonyi >Priority: Major > > Make it possible to configure the same set of properties that are available > on the UI? Like "Load Balancing Strategy" and "Selected Prioritizers". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12077) CLI - connect two process groups, make LB Strategy and Prioritizers configurable
[ https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandor Soma Abonyi updated NIFI-12077: -- Fix Version/s: (was: 1.latest) (was: 2.latest) > CLI - connect two process groups, make LB Strategy and Prioritizers > configurable > > > Key: NIFI-12077 > URL: https://issues.apache.org/jira/browse/NIFI-12077 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Nandor Soma Abonyi >Priority: Major > > Make it possible to configure the same set of properties that are available > on the UI? Like "Load Balancing Strategy" and "Selected Prioritizers". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12077) CLI - connect two process groups, make LB Strategy and Prioritizers configurable
[
https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi updated NIFI-12077:
--
Description: Make it possible to configure the same set of properties that
are available on the UI? Like "Load Balancing Strategy" and "Selected
Prioritizers". (was: Add a CLI command to connect two process groups together
{code:java}
./cli.sh nifi pg-connect \
--source-pg \
--source-output-port \
--destination-pg \
--destination-input-port {code})
> CLI - connect two process groups, make LB Strategy and Prioritizers
> configurable
>
>
> Key: NIFI-12077
> URL: https://issues.apache.org/jira/browse/NIFI-12077
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Nandor Soma Abonyi
>Priority: Major
> Fix For: 1.latest, 2.latest
>
>
> Make it possible to configure the same set of properties that are available
> on the UI? Like "Load Balancing Strategy" and "Selected Prioritizers".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12077) CLI - connect two process groups, make LB Strategy and Prioritizers configurable
[
https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi reassigned NIFI-12077:
-
Assignee: Nandor Soma Abonyi (was: Pierre Villard)
> CLI - connect two process groups, make LB Strategy and Prioritizers
> configurable
>
>
> Key: NIFI-12077
> URL: https://issues.apache.org/jira/browse/NIFI-12077
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Nandor Soma Abonyi
>Assignee: Nandor Soma Abonyi
>Priority: Major
> Fix For: 1.latest, 2.latest
>
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12077) CLI - connect two process groups, make LB Strategy and Prioritizers configurable
Nandor Soma Abonyi created NIFI-12077:
-
Summary: CLI - connect two process groups, make LB Strategy and
Prioritizers configurable
Key: NIFI-12077
URL: https://issues.apache.org/jira/browse/NIFI-12077
Project: Apache NiFi
Issue Type: Improvement
Components: Tools and Build
Reporter: Nandor Soma Abonyi
Assignee: Pierre Villard
Fix For: 1.latest, 2.latest
Add a CLI command to connect two process groups together
{code:java}
./cli.sh nifi pg-connect \
--source-pg \
--source-output-port \
--destination-pg \
--destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12077) CLI - connect two process groups, make LB Strategy and Prioritizers configurable
[
https://issues.apache.org/jira/browse/NIFI-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nandor Soma Abonyi reassigned NIFI-12077:
-
Assignee: (was: Nandor Soma Abonyi)
> CLI - connect two process groups, make LB Strategy and Prioritizers
> configurable
>
>
> Key: NIFI-12077
> URL: https://issues.apache.org/jira/browse/NIFI-12077
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Tools and Build
>Reporter: Nandor Soma Abonyi
>Priority: Major
> Fix For: 1.latest, 2.latest
>
>
> Add a CLI command to connect two process groups together
> {code:java}
> ./cli.sh nifi pg-connect \
> --source-pg \
> --source-output-port \
> --destination-pg \
> --destination-input-port {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1651: MINIFICPP-2193 - Add manifest to debug bundle
fgerlits commented on code in PR #1651: URL: https://github.com/apache/nifi-minifi-cpp/pull/1651#discussion_r1328436591 ## libminifi/src/c2/C2Agent.cpp: ## @@ -686,6 +686,23 @@ C2Payload C2Agent::bundleDebugInfo(std::map
