[jira] [Created] (NIFI-13109) Provide a way to run PrometheusReportingTask in MiNiFi Java
Ferenc Kis created NIFI-13109: - Summary: Provide a way to run PrometheusReportingTask in MiNiFi Java Key: NIFI-13109 URL: https://issues.apache.org/jira/browse/NIFI-13109 Project: Apache NiFi Issue Type: Improvement Components: MiNiFi Affects Versions: 2.0.0-M2 Reporter: Ferenc Kis Assignee: Ferenc Kis * include prometheues NAR in the MiNiFi assembly * provide a way via bootstrap to configure the reporting task -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINIFICPP-2345) Upgrade CI matrix
[ https://issues.apache.org/jira/browse/MINIFICPP-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841878#comment-17841878 ] Gábor Gyimesi commented on MINIFICPP-2345: -- I've just read in a comment that docker is not supported on the M1 runner: [https://github.com/actions/runner-images/issues/9254#issuecomment-278307] Probably due to this, that the MacOS runners are hosted on a VM and docker on Mac also needs virtualization and nested virtualization is not supported: https://github.com/abiosoft/colima/issues/970#issuecomment-1917751242 > Upgrade CI matrix > - > > Key: MINIFICPP-2345 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2345 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > > We should move to rockylinux 8 from centos 7 > we should move from macos13 to macos14 (its ARM), and we should try to build > rockylinux from the mac runner -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2336) Python bootstrap part 2
[ https://issues.apache.org/jira/browse/MINIFICPP-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2336: Assignee: Gábor Gyimesi > Python bootstrap part 2 > --- > > Key: MINIFICPP-2336 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2336 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Gábor Gyimesi >Assignee: Gábor Gyimesi >Priority: Major > > * separate menu for MiNiFi extension options and MiNiFi build options > * save bt_state similarly to old bootstrap > * add option for docker build with bootstrap > * use make/msbuild generator instead of ninja > * add SKIP_TESTS build option > * fix the documentation > ([https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1521747415]) > * add libtool and automake as a dependency to most distributions -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2292) Support notifystop in python processors
[ https://issues.apache.org/jira/browse/MINIFICPP-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2292: - Description: When calling the onTrigger function in a python processor it is done through python C API binding. This is basically a C function call which cannot be interrupted at the moment. We should find a way to implement the notifystop function in the ExecutePythonProcessor processor to be able to interrupt the running onTrigger call of the python processor if we want to. NiFi Python processors also support onStopped function in processors which should also be investigated how to be implemented. was:When calling the onTrigger function in a python processor it is done through python C API binding. This is basically a C function call which cannot be interrupted at the moment. We should find a way to implement the notifystop function in the ExecutePythonProcessor processor to be able to interrupt the running onTrigger call of the python processor if we want to. > Support notifystop in python processors > --- > > Key: MINIFICPP-2292 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2292 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Gábor Gyimesi >Priority: Major > > When calling the onTrigger function in a python processor it is done through > python C API binding. This is basically a C function call which cannot be > interrupted at the moment. We should find a way to implement the notifystop > function in the ExecutePythonProcessor processor to be able to interrupt the > running onTrigger call of the python processor if we want to. > NiFi Python processors also support onStopped function in processors which > should also be investigated how to be implemented. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINIFICPP-2345) Upgrade CI matrix
[ https://issues.apache.org/jira/browse/MINIFICPP-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841885#comment-17841885 ] Martin Zink commented on MINIFICPP-2345: Yepp I've also found this, so unfortunetly for ARM builds we need a self hosted (somewhere) ARM node. > Upgrade CI matrix > - > > Key: MINIFICPP-2345 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2345 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Martin Zink >Assignee: Martin Zink >Priority: Major > > We should move to rockylinux 8 from centos 7 > we should move from macos13 to macos14 (its ARM), and we should try to build > rockylinux from the mac runner -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12983: Qdrant vector store support [nifi]
Anush008 commented on PR #8590: URL: https://github.com/apache/nifi/pull/8590#issuecomment-2082151944 Hi @exceptionfactory. Just bumping this PR. Please take a look when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
James Medel created MINIFICPP-2346:
--
Summary: Speed up MiNiFi Build with Conan package manager (C++)
Key: MINIFICPP-2346
URL: https://issues.apache.org/jira/browse/MINIFICPP-2346
Project: Apache NiFi MiNiFi C++
Issue Type: Improvement
Affects Versions: 0.15.0
Environment: Ubuntu 22.04
Reporter: James Medel
Assignee: James Medel
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C++. It would be
faster to build MiNiFi C++ with the external dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. At this point because we already
most of MiNiFi C++'s external dependencies with conan, our CMake build will
just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement:*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Medel updated MINIFICPP-2346:
---
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C+{+}. It would be
faster to build MiNiFi C{+}+ with the external dependencies already
preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C+{+}. At this point because we
already most of MiNiFi C{+}{+}'s external dependencies with conan, our CMake
build will just focus on building the MiNiFi C{+}+ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C++. It would be
faster to build MiNiFi C++ with the external dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. At this point because we already
most of MiNiFi C++'s external dependencies with conan, our CMake build will
just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement:*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
> Speed up MiNiFi Build with Conan package manager (C++)
> --
>
> Key: MINIFICPP-2346
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2346
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Affects Versions: 0.15.0
> Environment: Ubuntu 22.04
>Reporter: James Medel
>Assignee: James Medel
>Priority: Min
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Medel updated MINIFICPP-2346:
---
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C+{+}. It would be
faster to build MiNiFi C{+}+ with the external dependencies already
preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already most of MiNiFi C's external dependencies with conan, our
CMake build will just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C+{+}. It would be
faster to build MiNiFi C{+}+ with the external dependencies already
preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C+{+}. At this point because we
already most of MiNiFi C{+}{+}'s external dependencies with conan, our CMake
build will just focus on building the MiNiFi C{+}+ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
> Speed up MiNiFi Build with Conan package manager (C++)
> --
>
> Key: MINIFICPP-2346
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2346
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Affects Versions: 0.15.0
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Medel updated MINIFICPP-2346:
---
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C++. Sometimes the
MiNiFi C++ build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already most of MiNiFi C's external dependencies with conan, our
CMake build will just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C+{+}. It would be
faster to build MiNiFi C{+}+ with the external dependencies already
preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already most of MiNiFi C's external dependencies with conan, our
CMake build will just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
> Speed up MiNiFi Build with Conan package manager (C++)
> --
>
> Key: MINIFICPP-2346
[jira] [Updated] (MINIFICPP-2346) Speed up MiNiFi Build with Conan package manager (C++)
[
https://issues.apache.org/jira/browse/MINIFICPP-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Medel updated MINIFICPP-2346:
---
Description:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi CPP. Sometimes the
MiNiFi CPP build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi CPP. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already have most of MiNiFi CPP's external lib dependencies
installed with conan, our CMake build will just focus on building the MiNiFi
CPP code, enabling faster builds. Also I will need to account for backward
compatibility support with the previous way of installing MiNiFi CPP external
lib dependencies using CMake FetchContent_Declare(...) approach until
conanfile.py approach covers installing all these dependencies. A valid
verification of the MiNiFi C++ build would be to run GTESTs and if all the
expected test cases pass, then it may be fair to conclude we would be ready to
deprecate the slow CMake FetchContent_Declare(...) approach.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point we will have used conan version 2 C++ package manager to
install almost all MiNiFi C++'s external dependencies.
## With Conan, we will have installed these MiNiFi external lib dependencies
as prebuilt binary conan packages.
## Or we will have instructed conan to first build each C++ external lib
dependency, upload each lib to conancenter.
# Thus, conan manages installing MiNiFi C++'s external lib dependencies, so we
can then run CMake to build MiNiFi faster.
was:
*Description of Issue:* Building MiNiFi C++ with just CMake is really slow.
During the the build process, it clones all the external dependencies and then
builds those external dependencies while its building MiNiFi C++. Sometimes the
MiNiFi C++ build fails too when external lib dependencies fail to download or
fail to build. It would be faster to build MiNiFi C++ with the external
dependencies already preinstalled.
*Potential Solution:* Integrate *conan version 2* into MiNiFi C++ project to
enable support for using *conan install* to install all or most of MiNiFi's
external dependencies, using *conan install --build=missing* to build them as
prebuilt binary conan packages, upload them to conancenter with {*}conan
upload{*}, and then run cmake generate to generate the appropriate build files
for the OS, then run make to build MiNiFi C++. Also conan has really good
support for cross platform compatibility for Linux and Windows. At this point
because we already most of MiNiFi C's external dependencies with conan, our
CMake build will just focus on building the MiNiFi C++ code.
*Steps to Perform MiNiFi C++ Build Enhancement (Plan to Integrate into
script(s)):*
# Install conan version 2 into MiNiFi C++ dev environment (my preference is
using docker container)
# Create a conanfile.py file at root of MiNiFi C++ project where we run "conan
install" or "conan install --build=missing" to install MiNiFi C++ external lib
dependencies first. Then we run CMake to build MiNiFi C++.
# Find all MiNiFi C++ find_package(...) CMake function calls and check if
there is already supported conan packages on the conancenter, so we can install
those packages.
# Find all FetchContent_Declare(...) CMake function calls and check if there
is already supported conan packages on the conancenter, so we can install those
packages.
# At this point w
[jira] [Created] (MINIFICPP-2347) Flow config structure errors should reference the invalid node
Adam Debreceni created MINIFICPP-2347: - Summary: Flow config structure errors should reference the invalid node Key: MINIFICPP-2347 URL: https://issues.apache.org/jira/browse/MINIFICPP-2347 Project: Apache NiFi MiNiFi C++ Issue Type: New Feature Reporter: Adam Debreceni Assignee: Adam Debreceni Currently some exceptions in json do not contain the path they occur (in yaml the exact line and offset is logged so this is not an issue). We should make sure that the path to the node is logged as well as the error. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2243) ListenHTTP: avoid reading full input or output flow file contents into memory
[ https://issues.apache.org/jira/browse/MINIFICPP-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Debreceni reassigned MINIFICPP-2243: - Assignee: Adam Debreceni > ListenHTTP: avoid reading full input or output flow file contents into memory > - > > Key: MINIFICPP-2243 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2243 > Project: Apache NiFi MiNiFi C++ > Issue Type: Improvement >Reporter: Marton Szasz >Assignee: Adam Debreceni >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13107: --- Status: Patch Available (was: Open) > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-13107: -- Assignee: Scott Aslan (was: Matt Gilman) Fix is in https://github.com/apache/nifi/pull/8707 > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12803) BUG - policy changes require page refresh to be applied
[ https://issues.apache.org/jira/browse/NIFI-12803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman reassigned NIFI-12803: -- Assignee: Matt Gilman > BUG - policy changes require page refresh to be applied > --- > > Key: NIFI-12803 > URL: https://issues.apache.org/jira/browse/NIFI-12803 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Matt Gilman >Priority: Major > Attachments: image-2024-02-15-13-57-03-890.png, > image-2024-02-15-13-58-17-784.png > > > !image-2024-02-15-13-57-03-890.png! > > !image-2024-02-15-13-58-17-784.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13107: --- Status: In Progress (was: Patch Available) > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13107: --- Status: Patch Available (was: In Progress) > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13104) UI - Route handling
[ https://issues.apache.org/jira/browse/NIFI-13104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows reassigned NIFI-13104: -- Assignee: Rob Fellows > UI - Route handling > --- > > Key: NIFI-13104 > URL: https://issues.apache.org/jira/browse/NIFI-13104 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Rob Fellows >Priority: Major > > Address routing issues that arise under the following scenarios... > * The user attempts to visit an unknown route > * The user attempts to visit a known route but supplies a route parameter > that is unknown > Depending on level of effort it may make sense to break this into two > separate efforts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13110) Auto select relation in Create Connection
Matt Gilman created NIFI-13110: -- Summary: Auto select relation in Create Connection Key: NIFI-13110 URL: https://issues.apache.org/jira/browse/NIFI-13110 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman When there is only a single Relationship, auto select it in the Create Connection dialog. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12903) UI - update disabled/enabled drag/drop colors
[ https://issues.apache.org/jira/browse/NIFI-12903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842001#comment-17842001 ] Matt Gilman commented on NIFI-12903: Also as part of this effort we should consider reducing the height of the draggable block and possibly introduce some sort of drag handle. > UI - update disabled/enabled drag/drop colors > - > > Key: NIFI-12903 > URL: https://issues.apache.org/jira/browse/NIFI-12903 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Priority: Major > > The connection prioritizers and the parameter context inheritance drag and > drop controls need to update the background color for enabled and disabled > states. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-13101) Full Screen Error is not themed for dark mode
[ https://issues.apache.org/jira/browse/NIFI-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13101: -- Assignee: Scott Aslan > Full Screen Error is not themed for dark mode > - > > Key: NIFI-13101 > URL: https://issues.apache.org/jira/browse/NIFI-13101 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-04-25 at 1.55.09 PM.png, Screenshot > 2024-04-25 at 1.56.37 PM.png > > > When in dark mode, if you encounter an error that routes the user to a full > screen error... you can't read the error message. The text is light due to > dark mode being set but the background is not themed to be dark, so the text > is hidden. > > !Screenshot 2024-04-25 at 1.55.09 PM.png|width=581,height=310! > > !Screenshot 2024-04-25 at 1.56.37 PM.png|width=579,height=310! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-12833: -- Assignee: Scott Aslan > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12833) Style "Primary Node Only" properly for both light and dark modes
[ https://issues.apache.org/jira/browse/NIFI-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-12833: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/8707/commits > Style "Primary Node Only" properly for both light and dark modes > > > Key: NIFI-12833 > URL: https://issues.apache.org/jira/browse/NIFI-12833 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-02-22 at 10.43.01 AM.png, Screenshot > 2024-02-22 at 10.43.12 AM.png, Screenshot 2024-02-22 at 10.43.32 AM.png, > Screenshot 2024-02-22 at 10.43.54 AM.png > > > We display an "icon" when a processor is "Primary Node Only". It shows on the > canvas as well as on the Summary listing. In reality these aren't actually > icons but DOM elements styled to look like icons. We should be consistent in > how they are displayed in both light and dark mode. > > !Screenshot 2024-02-22 at 10.43.54 AM.png!!Screenshot 2024-02-22 at 10.43.32 > AM.png! > > !Screenshot 2024-02-22 at 10.43.12 AM.png!!Screenshot 2024-02-22 at 10.43.01 > AM.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13101) Full Screen Error is not themed for dark mode
[ https://issues.apache.org/jira/browse/NIFI-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13101: --- Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/8707 > Full Screen Error is not themed for dark mode > - > > Key: NIFI-13101 > URL: https://issues.apache.org/jira/browse/NIFI-13101 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-04-25 at 1.55.09 PM.png, Screenshot > 2024-04-25 at 1.56.37 PM.png > > > When in dark mode, if you encounter an error that routes the user to a full > screen error... you can't read the error message. The text is light due to > dark mode being set but the background is not themed to be dark, so the text > is hidden. > > !Screenshot 2024-04-25 at 1.55.09 PM.png|width=581,height=310! > > !Screenshot 2024-04-25 at 1.56.37 PM.png|width=579,height=310! -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13099] status history error handling [nifi]
mcgilman commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1583284994
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/cluster/state/cluster-listing/cluster-listing.effects.ts:
##
@@ -69,6 +63,22 @@ export class ClusterListingEffects {
)
);
+loadClusterListingSuccess$ = createEffect(() =>
+this.actions$.pipe(
+ofType(ClusterListingActions.loadClusterListingSuccess),
+concatLatestFrom(() => this.store.select(selectCurrentUser)),
Review Comment:
`concatLatestFrom` is imported from the wrong package. I also noticed that
`systemDiagnosticsService` is injected in the constructor here but is not used
anymore.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/navigation/navigation.component.ts:
##
@@ -129,7 +129,8 @@ export class Navigation implements OnInit, OnDestroy {
this.store.dispatch(
getSystemDiagnosticsAndOpenDialog({
request: {
-nodewise: false
+nodewise: false,
+errorStrategy: 'banner'
Review Comment:
`errorStrategy` shouldn't be needed for `getSystemDiagnosticsAndOpenDialog`.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/index.ts:
##
@@ -91,6 +91,7 @@ export interface SystemDiagnosticSnapshot {
export interface SystemDiagnosticsRequest {
nodewise: boolean;
+errorStrategy: 'banner' | 'snackbar';
Review Comment:
I don't think the `errorStrategy` is needed when opening this from
`navigation`. Can we either have a different action payload for `reload` (where
`errorStrategy` is needed) or have it be optional here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13107] fix prettier issues [nifi]
mcgilman commented on PR #8709: URL: https://github.com/apache/nifi/pull/8709#issuecomment-2083046389 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13107: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13107] fix prettier issues [nifi]
mcgilman merged PR #8709: URL: https://github.com/apache/nifi/pull/8709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13107) Fix styles broken in #8677
[ https://issues.apache.org/jira/browse/NIFI-13107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842043#comment-17842043 ] ASF subversion and git services commented on NIFI-13107: Commit 7bf7e4031754906765af4f6d7ba79daaf5e6f152 in nifi's branch refs/heads/main from Scott Aslan [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=7bf7e40317 ] [NIFI-13107] fix prettier issues (#8709) This closes #8709 > Fix styles broken in #8677 > -- > > Key: NIFI-13107 > URL: https://issues.apache.org/jira/browse/NIFI-13107 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Scott Aslan >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13111) Remove unimplemented features for 2.0.0-M3
Matt Gilman created NIFI-13111: -- Summary: Remove unimplemented features for 2.0.0-M3 Key: NIFI-13111 URL: https://issues.apache.org/jira/browse/NIFI-13111 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman In preparation for 2.0.0-M3 remove some currently unsupported/unimplemented features so avoid potential confusion as users may expect the feature to be supported due to the presence of buttons in the UI. * Remove info icons from Summary pages * Remove Enable/Disable All Controller Services from context menu * Remove color from Operation Panel -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12300: Add oauth2 support for RestLookupService [nifi]
gforeman02 commented on PR #8462: URL: https://github.com/apache/nifi/pull/8462#issuecomment-2083160210 @exceptionfactory you are very welcome! I was working on trying to squash the commits but time slipped away from me. I will work on that in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13111) Remove unimplemented features for 2.0.0-M3
[ https://issues.apache.org/jira/browse/NIFI-13111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13111: --- Status: Patch Available (was: In Progress) > Remove unimplemented features for 2.0.0-M3 > -- > > Key: NIFI-13111 > URL: https://issues.apache.org/jira/browse/NIFI-13111 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In preparation for 2.0.0-M3 remove some currently unsupported/unimplemented > features so avoid potential confusion as users may expect the feature to be > supported due to the presence of buttons in the UI. > * Remove info icons from Summary pages > * Remove Enable/Disable All Controller Services from context menu > * Remove color from Operation Panel -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13112) Fix search links for components not on canvas
Matt Gilman created NIFI-13112: -- Summary: Fix search links for components not on canvas Key: NIFI-13112 URL: https://issues.apache.org/jira/browse/NIFI-13112 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13095] surface and contrast improvements [nifi]
rfellows commented on PR #8707: URL: https://github.com/apache/nifi/pull/8707#issuecomment-2083232134 reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13112) Fix search links for components not on canvas
[ https://issues.apache.org/jira/browse/NIFI-13112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13112: --- Status: Patch Available (was: In Progress) > Fix search links for components not on canvas > - > > Key: NIFI-13112 > URL: https://issues.apache.org/jira/browse/NIFI-13112 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13100: Updating API response error handling for canvas based actions [nifi]
rfellows merged PR #8702: URL: https://github.com/apache/nifi/pull/8702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13100) Error Handling on Canvas
[ https://issues.apache.org/jira/browse/NIFI-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842124#comment-17842124 ] ASF subversion and git services commented on NIFI-13100: Commit a230eba67ba29f7c6a2aa9042a74245d1195e0d2 in nifi's branch refs/heads/main from Matt Gilman [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=a230eba67b ] NIFI-13100: Updating API response error handling for canvas based actions (#8702) * NIFI-13100: - Updating API response error handling for canvas based actions. * NIFI-13100: - Stopping polling when change version and revert changes fails. * NIFI-13100: - Fixing formatting. This closes #8702 > Error Handling on Canvas > > > Key: NIFI-13100 > URL: https://issues.apache.org/jira/browse/NIFI-13100 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, any API errors that occurs on the Canvas are persisted in the > store but not currently presented to the user. These details should be > surfaced either through a banner, full page, or snack bar error. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13100) Error Handling on Canvas
[ https://issues.apache.org/jira/browse/NIFI-13100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Fellows updated NIFI-13100: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Error Handling on Canvas > > > Key: NIFI-13100 > URL: https://issues.apache.org/jira/browse/NIFI-13100 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently, any API errors that occurs on the Canvas are persisted in the > store but not currently presented to the user. These details should be > surfaced either through a banner, full page, or snack bar error. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13099] status history error handling [nifi]
mcgilman commented on code in PR #8703:
URL: https://github.com/apache/nifi/pull/8703#discussion_r1583542530
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/status-history/status-history.selectors.ts:
##
@@ -34,3 +34,8 @@ export const selectStatusHistoryFieldDescriptors =
createSelector(
selectStatusHistory,
(state: StatusHistoryEntity) => state.statusHistory?.fieldDescriptors
);
+
+export const selectStatusHistoryStatus = createSelector(
+selectStatusHistoryState,
+(state: StatusHistoryState) => state.status
+);
Review Comment:
This is new in this PR and is not used.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/state/system-diagnostics/system-diagnostics.effects.ts:
##
@@ -74,10 +87,12 @@ export class SystemDiagnosticsEffects {
}
})
),
-catchError((error) =>
+catchError((errorResponse: HttpErrorResponse) =>
of(
-
SystemDiagnosticsActions.systemDiagnosticsApiError({
-error: error.error
+ErrorActions.snackBarError({
+error: `Failed to load System Diagnostics. -
[${
+errorResponse.error || errorResponse.status
+}]`
})
Review Comment:
I think this needs to be using `systemDiagnosticsSnackbarError` otherwise
the `status` stays in `loading`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13113) upgrade Iceberg from 1.5.0 to 1.5.1
Sean Sullivan created NIFI-13113: Summary: upgrade Iceberg from 1.5.0 to 1.5.1 Key: NIFI-13113 URL: https://issues.apache.org/jira/browse/NIFI-13113 Project: Apache NiFi Issue Type: Task Reporter: Sean Sullivan Iceberg 1.5.1 [https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.5.1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13113: upgrade Iceberg from 1.5.0 to 1.5.1 [nifi]
sullis opened a new pull request, #8712: URL: https://github.com/apache/nifi/pull/8712 # Summary [NIFI-13113](https://issues.apache.org/jira/browse/NIFI-13113) Apache Iceberg 1.5.1 is the latest version # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13113) upgrade Iceberg from 1.5.0 to 1.5.1
[ https://issues.apache.org/jira/browse/NIFI-13113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Sullivan updated NIFI-13113: - Description: Iceberg 1.5.1 [https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.5.1] [https://iceberg.apache.org/releases/] was: Iceberg 1.5.1 [https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.5.1] > upgrade Iceberg from 1.5.0 to 1.5.1 > > > Key: NIFI-13113 > URL: https://issues.apache.org/jira/browse/NIFI-13113 > Project: Apache NiFi > Issue Type: Task >Reporter: Sean Sullivan >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > > Iceberg 1.5.1 > > [https://github.com/apache/iceberg/releases/tag/apache-iceberg-1.5.1] > [https://iceberg.apache.org/releases/] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13114) Only show Primary icon when clustered
Matt Gilman created NIFI-13114: -- Summary: Only show Primary icon when clustered Key: NIFI-13114 URL: https://issues.apache.org/jira/browse/NIFI-13114 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13095] surface and contrast improvements [nifi]
rfellows commented on code in PR #8707:
URL: https://github.com/apache/nifi/pull/8707#discussion_r1583624586
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss:
##
@@ -110,15 +120,15 @@
}
tr:hover {
-background-color: $surface-highlight !important;
+background-color: $highlight-surface;
}
.selected {
-background-color: $selected-row-color !important;
+background-color: $highlight-surface !important;
Review Comment:
selected and highlight are now the same color? this makes for odd tables:
https://github.com/apache/nifi/assets/713866/9a841948-b995-43ae-9974-56312fabdbc5";>
https://github.com/apache/nifi/assets/713866/c4ef2d5a-1814-4a97-8801-a16e7e00d58d";>
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/processor-manager.service.ts:
##
@@ -226,7 +226,7 @@ export class ProcessorManager {
// in
details
.append('rect')
-.attr('class', 'processor-stats-in-out')
+.attr('class', 'processor-stats-in-out odd')
Review Comment:
if we specify `odd`, we should also specify `even`
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/remote-process-group-manager.service.ts:
##
@@ -215,7 +215,7 @@ export class RemoteProcessGroupManager {
// sent
details
.append('rect')
-.attr('class', 'remote-process-group-sent-stats')
+.attr('class', 'remote-process-group-sent-stats odd')
Review Comment:
if we specify `odd`, we should also specify `even`
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/process-group-manager.service.ts:
##
@@ -454,7 +454,7 @@ export class ProcessGroupManager {
// queued
details
.append('rect')
-.attr('class', 'process-group-queued-stats')
+.attr('class', 'process-group-queued-stats odd')
Review Comment:
if this is `odd`, shouldn't the next one be `even`? currently it displays
the right color since the background is the same color (`even`). However, if
for some reason we change the color for `even`, these would get missed.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.ts:
##
@@ -77,7 +78,8 @@ export class OperationControl {
public canvasUtils: CanvasUtils,
private canvasView: CanvasView,
private client: Client,
-private storage: Storage
+private storage: Storage,
+protected themingService: ThemingService
Review Comment:
`themingService` doesn't appear to be used. can it be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (NIFI-13115) UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles
Scott Aslan created NIFI-13115: -- Summary: UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles Key: NIFI-13115 URL: https://issues.apache.org/jira/browse/NIFI-13115 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13099] status history error handling [nifi]
mcgilman merged PR #8703: URL: https://github.com/apache/nifi/pull/8703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13099) Error Handling for Status History
[ https://issues.apache.org/jira/browse/NIFI-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842159#comment-17842159 ] ASF subversion and git services commented on NIFI-13099: Commit 658e83b7ece21440b7853e51e964af78440c98e0 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=658e83b7ec ] [NIFI-13099] status history error handling (#8703) * [NIFI-13099] - Error handling for Status History * Error handling for current user * Error handling for extension types * Error handling for flow configuration * Error handling for component state * Error handling for cluster summary * Error handling for System Diagnostics * review feedback * use SystemDiagnosticsActions.systemDiagnosticsSnackbarError * review feedback * review feedback * use snackbar This closes #8703 > Error Handling for Status History > - > > Key: NIFI-13099 > URL: https://issues.apache.org/jira/browse/NIFI-13099 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13114: Only showing the primary node indicator when the node is clustered [nifi]
mcgilman opened a new pull request, #8713: URL: https://github.com/apache/nifi/pull/8713 NIFI-13114: - Only showing the primary node indicator when the node is clustered. - Making this consistent between the canvas and the summary table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13099) Error Handling for Status History
[ https://issues.apache.org/jira/browse/NIFI-13099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13099: --- Fix Version/s: 2.0.0-M3 Resolution: Fixed Status: Resolved (was: Patch Available) > Error Handling for Status History > - > > Key: NIFI-13099 > URL: https://issues.apache.org/jira/browse/NIFI-13099 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0-M3 > > Time Spent: 1h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13114) Only show Primary icon when clustered
[ https://issues.apache.org/jira/browse/NIFI-13114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13114: --- Status: Patch Available (was: In Progress) > Only show Primary icon when clustered > - > > Key: NIFI-13114 > URL: https://issues.apache.org/jira/browse/NIFI-13114 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13095] surface and contrast improvements [nifi]
scottyaslan commented on code in PR #8707:
URL: https://github.com/apache/nifi/pull/8707#discussion_r1583802012
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss:
##
@@ -110,15 +120,15 @@
}
tr:hover {
-background-color: $surface-highlight !important;
+background-color: $highlight-surface;
}
.selected {
-background-color: $selected-row-color !important;
+background-color: $highlight-surface !important;
Review Comment:
Ok yea, James also just pointed this out. It is especially tricky since we
have the `unset` values in the properties table as well. His suggestion was to
remove the even styles for the `.listing-table`'s and just have the lighter or
darker nifi surface palette be the selected style depending on light/dark mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [NIFI-13095] surface and contrast improvements [nifi]
scottyaslan commented on PR #8707: URL: https://github.com/apache/nifi/pull/8707#issuecomment-2083768159 @rfellows thanks for the feedback. I have addressed your comments. Let me know if you find anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13116) PutDatabaseRecord (INSERT_IGNORE) uses Update keys while not specified
Mikhail Pinevskiy created NIFI-13116:
Summary: PutDatabaseRecord (INSERT_IGNORE) uses Update keys while
not specified
Key: NIFI-13116
URL: https://issues.apache.org/jira/browse/NIFI-13116
Project: Apache NiFi
Issue Type: Bug
Affects Versions: 2.0.0-M2, 1.25.0
Reporter: Mikhail Pinevskiy
Fix For: 1.26.0
PutDatabaseRecord hides field "Update Keys" while using INSERT_IGNORE ("A
comma-separated list of column names that uniquely identifies a row in the
database for UPDATE statements. If the Statement Type is UPDATE and this
property is not set, the table's Primary Keys are used. In this case, if no
Primary Key exists, the conversion to SQL will fail if Unmatched Column
Behaviour is set to FAIL. This property is ignored if the Statement Type is
INSERT").
Despite this field not being set and not being used, classes like
PostgreSQLDatabaseAdapter use it in methods for INSERT_IGNORE and UPSERT, which
triggers an exception if list of Update Keys is empty or null.
MySQLDatabaseAdapter methods have same checks for Update Keys, but do not use
them. With that for PostgreSQL we have "instert ... on conflict (Update Keys)
ignore", and for MySQL any constraint will trigger "on conflict" on any
constraint, not specified.
It means different and unclear behaviour, so i suggest removing use of Update
Keys in said classes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-13115) UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles
[ https://issues.apache.org/jira/browse/NIFI-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13115: -- Assignee: Scott Aslan > UI - update border, box-shadow, and border radius of context menu, nf editor, > and search box to match angular material overlay styles > - > > Key: NIFI-13115 > URL: https://issues.apache.org/jira/browse/NIFI-13115 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13115) UI - update border, box-shadow, and border radius of context menu, nf editor, and search box to match angular material overlay styles
[ https://issues.apache.org/jira/browse/NIFI-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13115: --- Status: Patch Available (was: In Progress) > UI - update border, box-shadow, and border radius of context menu, nf editor, > and search box to match angular material overlay styles > - > > Key: NIFI-13115 > URL: https://issues.apache.org/jira/browse/NIFI-13115 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Nifi 13116 [nifi]
Pinevskiy opened a new pull request, #8715: URL: https://github.com/apache/nifi/pull/8715 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Nifi 13116 [nifi]
joewitt commented on PR #8715: URL: https://github.com/apache/nifi/pull/8715#issuecomment-2083873604 This pull request appears to mistakenly pull in many commits. Please rebase your PR to the latest main and submit from there. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Nifi 13116 [nifi]
Pinevskiy closed pull request #8715: Nifi 13116 URL: https://github.com/apache/nifi/pull/8715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13116 PutDatabaseRecord (INSERT_IGNORE) uses Update keys while n… [nifi]
Pinevskiy opened a new pull request, #8716: URL: https://github.com/apache/nifi/pull/8716 …ot specified # Summary [NIFI-13116](https://issues.apache.org/jira/browse/NIFI-13116) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
