[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987295#comment-15987295 ] ASF GitHub Bot commented on NIFI-3633: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1705 > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987294#comment-15987294 ] ASF subversion and git services commented on NIFI-3633: --- Commit 49a9bc88c66d84c30d7ed2f213b35d2835ffc3e5 in nifi's branch refs/heads/master from Joe Percivall [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=49a9bc8 ] NIFI-3633 This closes #1705. Adding a try with resources so the OkHttp response is properly closed Signed-off-by: joewitt > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987289#comment-15987289 ] Joseph Witt commented on NIFI-3633: --- reviewing > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985933#comment-15985933 ] ASF GitHub Bot commented on NIFI-3633: -- GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1705 NIFI-3633 Adding a try with resources so the OkHttp response is prope… …rly closed Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-3633_2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1705.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1705 commit 102fbb6facd32525c56901ffd7b2ae1c3002a03b Author: Joe Percivall Date: 2017-04-27T02:23:30Z NIFI-3633 Adding a try with resources so the OkHttp response is properly closed > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963825#comment-15963825 ] Joseph Percivall commented on NIFI-3633: Thanks for the review [~joewitt], very much appreciated. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Percivall > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963821#comment-15963821 ] ASF GitHub Bot commented on NIFI-3633: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1610 > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963820#comment-15963820 ] ASF subversion and git services commented on NIFI-3633: --- Commit 5419891fe760746f3fd4bb5c397d9a43b79f8281 in nifi's branch refs/heads/master from Joe Percivall [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=5419891 ] NIFI-3633 This closes #1610. Adding HttpNotificationService. Signed-off-by: joewitt > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962261#comment-15962261 ] ASF GitHub Bot commented on NIFI-3633: -- Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550645 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi --- End diff -- It was already added to the RPM[1] even though it wasn't included in the bootstrap pom. Its transitive deps are also already included: ``` +- org.apache.nifi:nifi-security-utils:jar:1.2.0-SNAPSHOT:compile | +- (org.apache.nifi:nifi-api:jar:1.2.0-SNAPSHOT:compile - omitted for duplicate) | +- (org.apache.nifi:nifi-utils:jar:1.2.0-SNAPSHOT:compile - omitted for duplicate) | +- org.apache.commons:commons-lang3:jar:3.4:compile | +- org.bouncycastle:bcprov-jdk15on:jar:1.55:compile | \- org.bouncycastle:bcpkix-jdk15on:jar:1.55:compile | \- (org.bouncycastle:bcprov-jdk15on:jar:1.55:compile - omitted for duplicate) ``` > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[
https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962264#comment-15962264
]
ASF GitHub Bot commented on NIFI-3633:
--
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1610#discussion_r110550470
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -420,15 +424,15 @@ public static Element getChild(final Element element,
final String tagName) {
}
private static class ConfiguredNotificationService {
-private final NotificationService service;
+private final AbstractNotificationService service;
private final Map properties;
-public ConfiguredNotificationService(final NotificationService
service, final Map properties) {
+public ConfiguredNotificationService(final
AbstractNotificationService service, final Map properties) {
--- End diff --
See above, reverting.
> Create an HttpNotifierService implementation of the Bootstrap Notification
> Service
> --
>
> Key: NIFI-3633
> URL: https://issues.apache.org/jira/browse/NIFI-3633
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Witt
> Fix For: 1.2.0
>
>
> In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects
> that it has died unexpectedly" the bootstrap has the notification service but
> currently there is only one implementation, the EmailNotifierService[1].
> An HttpNotifierService should be created in order to more generically post
> notifications.
> [1]
> https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[
https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962260#comment-15962260
]
ASF GitHub Bot commented on NIFI-3633:
--
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1610#discussion_r110550466
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -420,15 +424,15 @@ public static Element getChild(final Element element,
final String tagName) {
}
private static class ConfiguredNotificationService {
-private final NotificationService service;
+private final AbstractNotificationService service;
--- End diff --
Hmm, I thought I had a good reason, and maybe in some iteration there was,
but it appears there isn't anymore. I will revert.
> Create an HttpNotifierService implementation of the Bootstrap Notification
> Service
> --
>
> Key: NIFI-3633
> URL: https://issues.apache.org/jira/browse/NIFI-3633
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Witt
> Fix For: 1.2.0
>
>
> In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects
> that it has died unexpectedly" the bootstrap has the notification service but
> currently there is only one implementation, the EmailNotifierService[1].
> An HttpNotifierService should be created in order to more generically post
> notifications.
> [1]
> https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962262#comment-15962262 ] ASF GitHub Bot commented on NIFI-3633: -- Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550270 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi +nifi-security-utils + + javax.mail mail org.apache.nifi nifi-expression-language + +com.squareup.okhttp3 +okhttp --- End diff -- The only dep that's brought in is "okio" (as shown in the previous comment). I did forget to add it to the rpm plugin build, adding it to the new commit. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962263#comment-15962263 ] ASF GitHub Bot commented on NIFI-3633: -- Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550161 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi +nifi-security-utils + + javax.mail mail org.apache.nifi nifi-expression-language + +com.squareup.okhttp3 --- End diff -- Yup when doing a "mvn dependency:tree -Dverbose" the only related deps are: ``` +- com.squareup.okhttp3:okhttp:jar:3.6.0:compile | \- com.squareup.okio:okio:jar:1.11.0:compile +- com.squareup.okhttp3:mockwebserver:jar:3.6.0:test | +- (com.squareup.okhttp3:okhttp:jar:3.6.0:test - omitted for duplicate) | +- (org.bouncycastle:bcprov-jdk15on:jar:1.55:test - version managed from 1.50; omitted for duplicate) | \- (junit:junit:jar:4.12:test - omitted for duplicate) ``` The only other compile related one is "okio" which is offered under the same license: https://github.com/square/okio > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[
https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961372#comment-15961372
]
ASF GitHub Bot commented on NIFI-3633:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1610#discussion_r110472476
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -420,15 +424,15 @@ public static Element getChild(final Element element,
final String tagName) {
}
private static class ConfiguredNotificationService {
-private final NotificationService service;
+private final AbstractNotificationService service;
--- End diff --
why abstract implementation instead of interface?
> Create an HttpNotifierService implementation of the Bootstrap Notification
> Service
> --
>
> Key: NIFI-3633
> URL: https://issues.apache.org/jira/browse/NIFI-3633
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Witt
> Fix For: 1.2.0
>
>
> In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects
> that it has died unexpectedly" the bootstrap has the notification service but
> currently there is only one implementation, the EmailNotifierService[1].
> An HttpNotifierService should be created in order to more generically post
> notifications.
> [1]
> https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[
https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961371#comment-15961371
]
ASF GitHub Bot commented on NIFI-3633:
--
Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1610#discussion_r110472437
--- Diff:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java
---
@@ -420,15 +424,15 @@ public static Element getChild(final Element element,
final String tagName) {
}
private static class ConfiguredNotificationService {
-private final NotificationService service;
+private final AbstractNotificationService service;
private final Map properties;
-public ConfiguredNotificationService(final NotificationService
service, final Map properties) {
+public ConfiguredNotificationService(final
AbstractNotificationService service, final Map properties) {
--- End diff --
why go from the interface to the abstract implementation here?
> Create an HttpNotifierService implementation of the Bootstrap Notification
> Service
> --
>
> Key: NIFI-3633
> URL: https://issues.apache.org/jira/browse/NIFI-3633
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Witt
> Fix For: 1.2.0
>
>
> In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects
> that it has died unexpectedly" the bootstrap has the notification service but
> currently there is only one implementation, the EmailNotifierService[1].
> An HttpNotifierService should be created in order to more generically post
> notifications.
> [1]
> https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961368#comment-15961368 ] ASF GitHub Bot commented on NIFI-3633: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110472232 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi +nifi-security-utils + + javax.mail mail org.apache.nifi nifi-expression-language + +com.squareup.okhttp3 --- End diff -- I checked the licensing and indeed it is apache with no claimed copyrights and no declared notices. Good. However, there are several dependencies. Did you verify none of them require any updates to our license/notices for the convenience binary/assembly? > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961363#comment-15961363 ] ASF GitHub Bot commented on NIFI-3633: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110471840 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi +nifi-security-utils + + javax.mail mail org.apache.nifi nifi-expression-language + +com.squareup.okhttp3 +okhttp --- End diff -- by pulling this dependency in here you'll also need to handle the dependency properly in the rpm assembly. Otherwise when the RPM is built it wont work. True for any transitive deps of this as well and this dependency has many of them. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961361#comment-15961361 ] ASF GitHub Bot commented on NIFI-3633: -- Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110471797 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-utils +org.apache.nifi --- End diff -- by pulling this dependency in here you'll also need to handle the dependency properly in the rpm assembly. Otherwise when the RPM is built it wont work. True for any transitive deps of this as well. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945124#comment-15945124 ] Joseph Witt commented on NIFI-3633: --- will review. please avoid setting the fix version until there is review traction. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Witt > Fix For: 1.2.0 > > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3633) Create an HttpNotifierService implementation of the Bootstrap Notification Service
[ https://issues.apache.org/jira/browse/NIFI-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935709#comment-15935709 ] ASF GitHub Bot commented on NIFI-3633: -- GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1610 NIFI-3633 Adding HttpNotificationService. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [X] Have you written or updated unit tests to verify your changes? - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [X] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-3633 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1610.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1610 commit 4e5b0a5bd3b7872f0058033e34971ab6bae97c93 Author: Joe Percivall Date: 2017-03-22T02:50:06Z NIFI-3633 Adding HttpNotificationService. > Create an HttpNotifierService implementation of the Bootstrap Notification > Service > -- > > Key: NIFI-3633 > URL: https://issues.apache.org/jira/browse/NIFI-3633 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joseph Percivall >Assignee: Joseph Percivall > > In order to notify "when the NiFi bootstrap starts or stops NiFi, or detects > that it has died unexpectedly" the bootstrap has the notification service but > currently there is only one implementation, the EmailNotifierService[1]. > An HttpNotifierService should be created in order to more generically post > notifications. > [1] > https://github.com/mcgilman/nifi/blob/3a7ddc6a35f143c1d4a735226fe7467a83d04583/nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/notification/email/EmailNotificationService.java#L47-L47 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
