Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory closed pull request #7858: NIFI-12178 add integration-tests and docker-tests github actions URL: https://github.com/apache/nifi/pull/7858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on PR #7858: URL: https://github.com/apache/nifi/pull/7858#issuecomment-1770578433 @exceptionfactory have rebased from `main` latest after you merged NIFI-12175 - all new & existing test Workflows now passing without errors or warnings (from the Github Runners) 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1365311280
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: docker-tests
+
+on:
+ # Run every day at 02:00
+ schedule:
+- cron: "0 2 * * *"
+ push:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+ pull_request:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# build assemblies (including binaries) for use in Docker Image builds
+ MAVEN_BUILD_ARGUMENTS: >-
+-am
+-D skipTests
+-T 2.0C
+install
+ MAVEN_BUILD_PROJECTS: >-
+-pl nifi-assembly
+-pl nifi-registry/nifi-registry-assembly
+-pl nifi-toolkit/nifi-toolkit-assembly
+-pl minifi/minifi-assembly
+-pl minifi/minifi-c2/minifi-c2-assembly
+
+ MAVEN_CLEAN_ARGUMENTS: >-
+-T 2.0C
+clean
+ MAVEN_CLEAN_PROJECTS: >-
+-pl -nifi-assembly
+-pl -nifi-registry/nifi-registry-assembly
+-pl -nifi-toolkit/nifi-toolkit-assembly
+-pl -nifi-toolkit/nifi-toolkit-cli
+-pl -nifi-toolkit/nifi-toolkit-encrypt-config
+-pl -nifi-toolkit/nifi-toolkit-tls
+-pl -minifi/minifi-assembly
+-pl -minifi/minifi-c2/minifi-c2-assembly
+
+# build and test Docker Images
+ MAVEN_DOCKER_ARGUMENTS: >-
+package
+-P docker
+ MAVEN_DOCKER_PROJECTS: >-
+-pl minifi/minifi-docker
+-pl minifi/minifi-c2/minifi-c2-docker
+-pl nifi-docker/dockermaven
+-pl nifi-registry/nifi-registry-docker-maven/dockermaven
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+# TODO: macos-latest doesn't come with Docker and Colima seems to have
problems with the nifi-docker integration_test scripts - see
NIFI-12177/NIFI-12191
+os: [ ubuntu-latest ]
+version: [ 21 ]
+timeout-minutes: 120
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
+steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+if: ${{ runner.os == 'macOS' }}
+run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
+ - name: Checkout Code
+uses: actions/checkout@v4
+ - name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }}
+uses: actions/setup-java@v3
+with:
+ distribution: ${{ env.JAVA_DISTRIBUTION }}
+ java-version: ${{ matrix.version }}
+ cache: 'maven'
+
+ - name: Set up Docker
+if: ${{ runner.os == 'macOS' }}
+run: |-
+ /bin/bash -c "$(curl -fsSL
https://raw.githubusercontent.com/Homebrew/install/H
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1365311773 ## .github/workflows/docker-tests.yml: ## @@ -0,0 +1,189 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: docker-tests + +on: + # Run every day at 02:00 + schedule: +- cron: "0 2 * * *" + push: +paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'nifi-toolkit/nifi-toolkit-assembly/**' + - 'nifi-toolkit/nifi-toolkit-cli/**' + - 'nifi-toolkit/nifi-toolkit-encrypt-config/**' + - 'nifi-toolkit/nifi-toolkit-tls/**' + - 'minifi/minifi-assembly/**' + - 'minifi/minifi-docker/**' + - 'minifi/minifi-c2/minifi-c2-assembly/**' + - 'minifi/minifi-c2/minifi-c2-docker/**' + pull_request: +paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'nifi-toolkit/nifi-toolkit-assembly/**' + - 'nifi-toolkit/nifi-toolkit-cli/**' + - 'nifi-toolkit/nifi-toolkit-encrypt-config/**' + - 'nifi-toolkit/nifi-toolkit-tls/**' Review Comment: References to `toolkit-tls` removed after NIFI-12200 merged to `main` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on PR #7858: URL: https://github.com/apache/nifi/pull/7858#issuecomment-1766981607 > @exceptionfactory RE [#7858 (comment)](https://github.com/apache/nifi/pull/7858#discussion_r1362094730) (skipping the `rm -rf` Clean step for the `docker-tests`) > > The last run of the Workflow in this PR that didn't include the `rm -rf` ran out of disk space, it would appear these removals are still required. > > Building without the ZIP wouldn't work - the `dockermaven` builds use the ZIP files (I don't want to change that either as that's what the `dockerhub` builds do when downloading the build convenience artefacts from the Apache Archive servers), so the clean up step: > > * cleans the Maven module `target` folders (except for the `assembly` modules as that's what we need for the Docker Image build step) > > * deletes the un-zipped files from the assembly module `target` folders > > > The Docker Image builds each create a new Image (TAR file) containing the assembled ZIP, then unzips them before deleting the ZIP file - this uses a lot of disk space Thanks for the additional background @ChrisSamo632, that makes sense now, it sounds like the current approach is the best option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on PR #7858: URL: https://github.com/apache/nifi/pull/7858#issuecomment-1766976777 @exceptionfactory RE https://github.com/apache/nifi/pull/7858#discussion_r1362094730 (skipping the `rm -rf` Clean step for the `docker-tests`) The last run of the Workflow in this PR that didn't include the `rm -rf` ran out of disk space, it would appear these removals are still required. Building without the ZIP wouldn't work - the `dockermaven` builds use the ZIP files (I don't want to change that either as that's what the `dockerhub` builds do when downloading the build convenience artefacts from the Apache Archive servers), so the clean up step: - cleans the Maven module `target` folders (except for the `assembly` modules as that's what we need for the Docker Image build step) - deletes the un-zipped files from the assembly module `target` folders The Docker Image builds each create a new Image (TAR file) containing the assembled ZIP, then unzips them before deleting the ZIP file - this uses a lot of disk space -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1362608944
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: docker-tests
+
+on:
+ # Run every day at 02:00
+ schedule:
+- cron: "0 2 * * *"
+ push:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+ pull_request:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# build assemblies (including binaries) for use in Docker Image builds
+ MAVEN_BUILD_ARGUMENTS: >-
+-am
+-D skipTests
+-T 2.0C
+install
+ MAVEN_BUILD_PROJECTS: >-
+-pl nifi-assembly
+-pl nifi-registry/nifi-registry-assembly
+-pl nifi-toolkit/nifi-toolkit-assembly
+-pl minifi/minifi-assembly
+-pl minifi/minifi-c2/minifi-c2-assembly
+
+ MAVEN_CLEAN_ARGUMENTS: >-
+-T 2.0C
+clean
+ MAVEN_CLEAN_PROJECTS: >-
+-pl -nifi-assembly
+-pl -nifi-registry/nifi-registry-assembly
+-pl -nifi-toolkit/nifi-toolkit-assembly
+-pl -nifi-toolkit/nifi-toolkit-cli
+-pl -nifi-toolkit/nifi-toolkit-encrypt-config
+-pl -nifi-toolkit/nifi-toolkit-tls
+-pl -minifi/minifi-assembly
+-pl -minifi/minifi-c2/minifi-c2-assembly
+
+# build and test Docker Images
+ MAVEN_DOCKER_ARGUMENTS: >-
+verify
+-P docker
+ MAVEN_DOCKER_PROJECTS: >-
+-pl minifi/minifi-docker
+-pl minifi/minifi-c2/minifi-c2-docker
+-pl nifi-docker/dockermaven
+-pl nifi-registry/nifi-registry-docker-maven/dockermaven
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+# TODO: macos-latest doesn't come with Docker and Colima seems to have
problems with the nifi-docker integration_test scripts - see
NIFI-12177/NIFI-12191
Review Comment:
Yeah that's fine now that I've raised the Jira tickets (I've also, I think,
got a fix for these TODOs, but don't want to extend this existing PR further),
will remove the TODOs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1362608175
##
.github/workflows/ci-workflow.yml:
##
@@ -75,7 +76,7 @@ env:
-pl -nifi-toolkit/nifi-toolkit-assembly
concurrency:
- group: ${{ github.ref }}
+ group: ${{ github.workflow }}-${{ github.ref }}
Review Comment:
Adding a `concurrency` entry for the new Workflows (and existing
`system-tests`) seemed sensible to avoid running duplicate Workflows for PRs
that trigger them (the `cron` schedule, of course, should not result in
duplicate runs)
Having a `group` of just `${{ github.ref }}` means that the Workflows cancel
each other because they're all running in the same `group`. Adding the `${{
github.workflow }}` name prefix means that a Workflow can only cancel an
existing run of itself. There's not really a *need* to add the prefix to the
`ci-workflow` Workflow definition, as it could be left as the only Workflow
without the prefix, meaning it would still be in a `group` of its own. But as I
was upting this Workflow definition for other reasons, then making this
consistent with all other NiFi Workflows seemed sensible for the sake of future
maintenance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1362093065
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: docker-tests
+
+on:
+ # Run every day at 02:00
+ schedule:
+- cron: "0 2 * * *"
+ push:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+ pull_request:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# build assemblies (including binaries) for use in Docker Image builds
+ MAVEN_BUILD_ARGUMENTS: >-
+-am
+-D skipTests
+-T 2.0C
+install
+ MAVEN_BUILD_PROJECTS: >-
+-pl nifi-assembly
+-pl nifi-registry/nifi-registry-assembly
+-pl nifi-toolkit/nifi-toolkit-assembly
+-pl minifi/minifi-assembly
+-pl minifi/minifi-c2/minifi-c2-assembly
+
+ MAVEN_CLEAN_ARGUMENTS: >-
+-T 2.0C
+clean
+ MAVEN_CLEAN_PROJECTS: >-
+-pl -nifi-assembly
+-pl -nifi-registry/nifi-registry-assembly
+-pl -nifi-toolkit/nifi-toolkit-assembly
+-pl -nifi-toolkit/nifi-toolkit-cli
+-pl -nifi-toolkit/nifi-toolkit-encrypt-config
+-pl -nifi-toolkit/nifi-toolkit-tls
+-pl -minifi/minifi-assembly
+-pl -minifi/minifi-c2/minifi-c2-assembly
+
+# build and test Docker Images
+ MAVEN_DOCKER_ARGUMENTS: >-
+verify
+-P docker
+ MAVEN_DOCKER_PROJECTS: >-
+-pl minifi/minifi-docker
+-pl minifi/minifi-c2/minifi-c2-docker
+-pl nifi-docker/dockermaven
+-pl nifi-registry/nifi-registry-docker-maven/dockermaven
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+# TODO: macos-latest doesn't come with Docker and Colima seems to have
problems with the nifi-docker integration_test scripts - see
NIFI-12177/NIFI-12191
+os: [ ubuntu-latest ]
+version: [ 21 ]
+timeout-minutes: 120
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
Review Comment:
In this case, it seems much simpler to use `Zulu` for all builds. The JDK
version is less important for this workflow because the focus is running Docker
containers.
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apac
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1358711103 ## .github/workflows/docker-tests.yml: ## @@ -0,0 +1,189 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: docker-tests + +on: + # Run every day at 02:00 + schedule: +- cron: "0 2 * * *" + push: +paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'nifi-toolkit/nifi-toolkit-assembly/**' + - 'nifi-toolkit/nifi-toolkit-cli/**' + - 'nifi-toolkit/nifi-toolkit-encrypt-config/**' + - 'nifi-toolkit/nifi-toolkit-tls/**' + - 'minifi/minifi-assembly/**' + - 'minifi/minifi-docker/**' + - 'minifi/minifi-c2/minifi-c2-assembly/**' + - 'minifi/minifi-c2/minifi-c2-docker/**' + pull_request: +paths: + - '.github/workflows/docker-tests.yml' + - 'nifi-assembly/**' + - 'nifi-docker/**' + - 'nifi-registry/nifi-registry-assembly/**' + - 'nifi-registry/nifi-registry-docker-maven/**' + - 'nifi-toolkit/nifi-toolkit-assembly/**' + - 'nifi-toolkit/nifi-toolkit-cli/**' + - 'nifi-toolkit/nifi-toolkit-encrypt-config/**' + - 'nifi-toolkit/nifi-toolkit-tls/**' Review Comment: NIFI-12200 (see #7879) will lead to this needing to be changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1358710047
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: docker-tests
+
+on:
+ # Run every day at 02:00
+ schedule:
+- cron: "0 2 * * *"
+ push:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+ pull_request:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'nifi-toolkit/nifi-toolkit-assembly/**'
+ - 'nifi-toolkit/nifi-toolkit-cli/**'
+ - 'nifi-toolkit/nifi-toolkit-encrypt-config/**'
+ - 'nifi-toolkit/nifi-toolkit-tls/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# build assemblies (including binaries) for use in Docker Image builds
+ MAVEN_BUILD_ARGUMENTS: >-
+-am
+-D skipTests
+-T 2.0C
+install
+ MAVEN_BUILD_PROJECTS: >-
+-pl nifi-assembly
+-pl nifi-registry/nifi-registry-assembly
+-pl nifi-toolkit/nifi-toolkit-assembly
+-pl minifi/minifi-assembly
+-pl minifi/minifi-c2/minifi-c2-assembly
+
+ MAVEN_CLEAN_ARGUMENTS: >-
+-T 2.0C
+clean
+ MAVEN_CLEAN_PROJECTS: >-
+-pl -nifi-assembly
+-pl -nifi-registry/nifi-registry-assembly
+-pl -nifi-toolkit/nifi-toolkit-assembly
+-pl -nifi-toolkit/nifi-toolkit-cli
+-pl -nifi-toolkit/nifi-toolkit-encrypt-config
+-pl -nifi-toolkit/nifi-toolkit-tls
+-pl -minifi/minifi-assembly
+-pl -minifi/minifi-c2/minifi-c2-assembly
+
+# build and test Docker Images
+ MAVEN_DOCKER_ARGUMENTS: >-
+package
+-P docker
+ MAVEN_DOCKER_PROJECTS: >-
+-pl minifi/minifi-docker
+-pl minifi/minifi-c2/minifi-c2-docker
+-pl nifi-docker/dockermaven
+-pl nifi-registry/nifi-registry-docker-maven/dockermaven
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+# TODO: macos-latest doesn't come with Docker and Colima seems to have
problems with the nifi-docker integration_test scripts - see
NIFI-12177/NIFI-12191
+os: [ ubuntu-latest ]
+version: [ 21 ]
+timeout-minutes: 120
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
+steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+if: ${{ runner.os == 'macOS' }}
+run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
+ - name: Checkout Code
+uses: actions/checkout@v4
+ - name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }}
+uses: actions/setup-java@v3
+with:
+ distribution: ${{ env.JAVA_DISTRIBUTION }}
+ java-version: ${{ matrix.version }}
+ cache: 'maven'
+
+ - name: Set up Docker
+if: ${{ runner.os == 'macOS' }}
+run: |-
+ /bin/bash -c "$(curl -fsSL
https://raw.githubusercontent.com/Homebrew/install/H
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on PR #7858: URL: https://github.com/apache/nifi/pull/7858#issuecomment-1760278886 @exceptionfactory I've rebased from latest `main` as there have been quite a few changes over the past few days. I also noticed I'd missed the `nifi-toolkit` tests from the new `docker-tests` workflow, which are failing on `main` due to the `file-manager` command no longer being present in the CLI - something I spotted and corrected also in [NIFI-12175](https://github.com/apache/nifi/pull/7864) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350475506 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- Review Comment: Actually, the [test](https://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#test) configuration allows us to do this - I'd have preferred the use of `includes` and `excludes` I think, but with `test` we at least retain the method-level filtering -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350464137 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- Review Comment: It seems like excluding tests at the file level is OK, but the method filtering isn't supported via the `configuration` of the failsafe plugin (see https://maven.apache.org/surefire/maven-failsafe-plugin/examples/inclusion-exclusion.html) - I'll try to dig a little deeper, as I would prefer to keep the test exclusion filter as narrow as possible and still run successful test methods from ITs where possible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350441586 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!Greml
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350426672 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!G
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350422453 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!Greml
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350421810 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- Review Comment: Thanks @ChrisSamo632! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350419864 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- Review Comment: I agree that it would be better to make it easier to run the same set of tests locally, so I'll try adding a new profile, e.g. `integration-tests-ci` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1350406115
##
.github/workflows/docker-tests.yml:
##
@@ -0,0 +1,164 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: docker-tests
+
+on:
+ # Run every day at 02:00
+ schedule:
+- cron: "0 2 * * *"
+ push:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+ pull_request:
+paths:
+ - '.github/workflows/docker-tests.yml'
+ - 'nifi-assembly/**'
+ - 'nifi-docker/**'
+ - 'nifi-registry/nifi-registry-assembly/**'
+ - 'nifi-registry/nifi-registry-docker-maven/**'
+ - 'minifi/minifi-assembly/**'
+ - 'minifi/minifi-docker/**'
+ - 'minifi/minifi-c2/minifi-c2-assembly/**'
+ - 'minifi/minifi-c2/minifi-c2-docker/**'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# build assemblies (including binaries) for use in Docker Image builds
+ MAVEN_BUILD_ARGUMENTS: >-
+-am
+-D skipTests
+-T 2.0C
+package
+ MAVEN_BUILD_PROJECTS: >-
+-pl nifi-assembly
+-pl nifi-registry/nifi-registry-assembly
+-pl nifi-toolkit/nifi-toolkit-assembly
+-pl minifi/minifi-assembly
+-pl minifi/minifi-c2/minifi-c2-assembly
+
+ MAVEN_CLEAN_ARGUMENTS: >-
+-T 2.0C
+clean
+ MAVEN_CLEAN_PROJECTS: >-
+-pl -nifi-assembly
+-pl -nifi-registry/nifi-registry-assembly
+-pl -nifi-toolkit/nifi-toolkit-assembly
+-pl -minifi/minifi-assembly
+-pl -minifi/minifi-c2/minifi-c2-assembly
+
+# build and test Docker Images
+ MAVEN_DOCKER_ARGUMENTS: >-
+install
+-P docker
+ MAVEN_DOCKER_PROJECTS: >-
+-pl minifi/minifi-docker
+-pl minifi/minifi-c2/minifi-c2-docker
+-pl nifi-docker/dockermaven
+-pl nifi-registry/nifi-registry-docker-maven/dockermaven
+
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
+permissions:
+ contents: read
+
+jobs:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+# TODO: macos-latest doesn't come with Docker and Colima seems to have
problems with the nifi-docker integration_test scripts - see
NIFI-12177/NIFI-12191
+os: [ ubuntu-latest ]
+version: [ 21 ]
+timeout-minutes: 120
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
+steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+if: ${{ runner.os == 'macos' }}
+run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
+ - name: Checkout Code
+uses: actions/checkout@v4
+ - name: Set up Java ${{ env.JAVA_DISTRIBUTION }} ${{ matrix.version }}
+uses: actions/setup-java@v3
+with:
+ distribution: ${{ env.JAVA_DISTRIBUTION }}
+ java-version: ${{ matrix.version }}
+ cache: 'maven'
+
+ - name: Set up Docker
+if: ${{ runner.os == 'macos' }}
+run: |-
+ /bin/bash -c "$(curl -fsSL
https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
+ brew install docker
+ colima start
+
+ if [ ! -e /var/run/docker.sock ]; then sudo ln -s
~/.colima/docker.sock /var/run/docker.sock; fi
+ - name: Confirm Docker
+run: id && docker info
+
+ - name: Build Assemblies
+env:
+ MAVEN_OPTS: >-
+${{ env.DEFAULT_MAVEN_OPTS }}
+run: >
+ ${{ env.MAVEN_COMMAND }}
+ ${{ env.MAVEN_BUILD_ARGUMENTS }}
+ ${{ env.MAVEN_BUILD_PROJECTS }}
+ - name:
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350404340 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!G
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350403028 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!Greml
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858: URL: https://github.com/apache/nifi/pull/7858#discussion_r1350400194 ## .github/workflows/integration-tests.yml: ## @@ -0,0 +1,248 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +name: integration-tests + +on: + # Run every day at 03:00 + schedule: +- cron: "0 3 * * *" + push: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + pull_request: +paths: + - '.github/workflows/integration-tests.yml' + - '**/test/**/*IT.java' + - '**/test/**/*ITCase.java' + - '**/test/**/IT*.java' + +env: + DEFAULT_MAVEN_OPTS: >- +-Xmx4g +-XX:ReservedCodeCacheSize=1g +-XX:+UseG1GC +-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN +-Daether.connector.http.retryHandler.count=5 +-Daether.connector.http.connectionMaxTtl=30 +-Duser.language=en +-Duser.country=GB +-Duser.timezone=UTC + MAVEN_COMMAND: >- +./mvnw +-V +-nsu +-ntp +-ff + +# skip assemblies and modules covered separately by the system-tests workflow +# skip unit tests (surefire), run integration tests (failsafe), python ITs included as part of the system-tests workflow + MAVEN_BUILD_ARGUMENTS: >- +-D failsafe.failIfNoSpecifiedTests=false +verify +-P skip-unit-tests +-P integration-tests +-P nifi-registry-integration-tests + MAVEN_BUILD_EXCLUDE_PROJECTS: >- +-pl -:minifi-assembly +-pl -:minifi-c2-assembly +-pl -:nifi-assembly +-pl -:nifi-toolkit-assembly +-pl -:nifi-registry-assembly +-pl -:nifi-registry-toolkit-assembly +-pl -:nifi-runtime-manifest +-pl -:nifi-runtime-manifest-test +-pl -:nifi-stateless-assembly +-pl -:nifi-stateless-processor-tests +-pl -:nifi-stateless-system-test-suite +-pl -:nifi-system-test-suite +-pl -:nifi-nar-provider-assembly +-pl -:nifi-py4j-integration-tests +# skip individual failing ITs (some won't work in a CI environment) +# always run the (failsafe default) IT*, *IT, *ITCase integration-tests + MAVEN_FAILSAFE_SKIP_ITS: >- +IT*, *IT, *ITCase, +!AwsSecretsManagerSensitivePropertyProviderIT, +!AwsKmsSensitivePropertyProviderIT, +!AzureKeyVaultKeySensitivePropertyProviderIT, +!GcpKmsSensitivePropertyProviderIT, +!StandardHashiCorpVaultCommunicationServiceIT, +!ConversionWithSchemaInferenceIT#testXmlToAvro, +!ConversionWithSchemaInferenceIT#testXmlToJson, +!ConversionWithSchemaInferenceIT#testJsonToCsv, +!ConversionWithSchemaInferenceIT#testCsvToXml, +!ConversionWithSchemaInferenceIT#testXmlToAvroToXml, +!ConversionWithSchemaInferenceIT#testCsvToAvro, +!ConversionWithSchemaInferenceIT#testCsvToJson, +!ConversionWithSchemaInferenceIT#testJsonToAvroToJson, +!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv, +!ConversionWithExplicitSchemaIT#testJsonToCsv, +!ConversionWithExplicitSchemaIT#testJsonToAvro, +!ConversionWithExplicitSchemaIT#testJsonToAvroToJson, +!ITConsumeKinesisStreamEndpointOverride, +!ITConsumeKinesisStreamConnectAWS, +!ITPutKinesisStream, +!ITPutKinesisStreamWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehoseWithEndpointOverride#testIntegrationSuccess, +!ITPutKinesisFirehose, +!ITTagS3Object, +!ITFetchS3Object, +!ITDeleteS3Object, +!ITPutS3Object, +!ITListS3, +!ITPutSNS#testPublish, +!ITPutSNS#testPublishWithCredentialsProviderService, +!ITDeleteSQS, +!ITGetSQS, +!ITPutSQS, +!ITPutLambda, +!GetMongoIT#testDatabaseEL, +!PutGridFSIT#testFileNameAndHashUniqueness, +!PutGridFSIT#testHashUniqueness, +!ITPutAzureCosmosDBRecord, +!ITListAzureBlobStorage_v12, +!ITPutAzureDataLakeStorage, +!ITFetchAzureDataLakeStorage, +!ITListAzureDataLakeStorage, +!ITFetchAzureBlobStorage_v12, +!ITPutAzureBlobStorage_v12, +!ITDeleteAzureDataLakeStorage, +!ITDeleteAzureBlobStorage_v12, +!ITMoveAzureDataLakeStorage, +!AzureGraphUserGroupProviderIT, +!JMSPublisherConsumerIT#validateMessageRedeliveryWhenNotAcked, +!ITPutInfluxDB, +!ITExecuteInfluxDBQuery, +!Greml
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
ChrisSamo632 commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1350393878
##
.github/workflows/system-tests.yml:
##
@@ -64,71 +64,45 @@ env:
-pl nifi-system-tests/nifi-system-test-suite
-pl nifi-system-tests/nifi-stateless-system-test-suite
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
permissions:
contents: read
jobs:
- ubuntu:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+os: [ ubuntu-latest, macos-latest ]
+version: [ 21 ]
timeout-minutes: 120
-runs-on: ubuntu-latest
-name: Ubuntu Corretto Java 21
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+if: ${{ runner.os == 'macos' }}
+run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
Review Comment:
You'd have hoped so. Apparently there was a `set-env` action a while back,
but that was deemed unsafe to use, so this appears to be the GitHub suggested
way to achieve this between steps - see
https://docs.github.com/en/actions/learn-github-actions/variables#passing-values-between-steps-and-jobs-in-a-workflow
Open to other/better approaches if you find one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12178 add integration-tests and docker-tests github actions [nifi]
exceptionfactory commented on code in PR #7858:
URL: https://github.com/apache/nifi/pull/7858#discussion_r1350345069
##
.github/workflows/system-tests.yml:
##
@@ -64,71 +64,45 @@ env:
-pl nifi-system-tests/nifi-system-test-suite
-pl nifi-system-tests/nifi-stateless-system-test-suite
+concurrency:
+ group: ${{ github.workflow }}-${{ github.ref }}
+ cancel-in-progress: true
+
permissions:
contents: read
jobs:
- ubuntu:
+ build_and_test:
+strategy:
+ fail-fast: false
+ matrix:
+os: [ ubuntu-latest, macos-latest ]
+version: [ 21 ]
timeout-minutes: 120
-runs-on: ubuntu-latest
-name: Ubuntu Corretto Java 21
+runs-on: ${{ matrix.os }}
+name: ${{ matrix.os }} Java ${{ matrix.version }}
+env:
+ # default to Amazon Corretto JDK
+ JAVA_DISTRIBUTION: corretto
steps:
+ # Zulu JDK appears to be more reliable for MacOS
+ - name: Use Java distribution Zulu
+if: ${{ runner.os == 'macos' }}
+run: echo "JAVA_DISTRIBUTION=zulu" >> "$GITHUB_ENV"
Review Comment:
Is this the only way to conditionally set an environment variable? It seems
like it should be possible with more declarative conditionals.
##
.github/workflows/integration-tests.yml:
##
@@ -0,0 +1,248 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: integration-tests
+
+on:
+ # Run every day at 03:00
+ schedule:
+- cron: "0 3 * * *"
+ push:
+paths:
+ - '.github/workflows/integration-tests.yml'
+ - '**/test/**/*IT.java'
+ - '**/test/**/*ITCase.java'
+ - '**/test/**/IT*.java'
+ pull_request:
+paths:
+ - '.github/workflows/integration-tests.yml'
+ - '**/test/**/*IT.java'
+ - '**/test/**/*ITCase.java'
+ - '**/test/**/IT*.java'
+
+env:
+ DEFAULT_MAVEN_OPTS: >-
+-Xmx4g
+-XX:ReservedCodeCacheSize=1g
+-XX:+UseG1GC
+-Dorg.slf4j.simpleLogger.defaultLogLevel=WARN
+-Daether.connector.http.retryHandler.count=5
+-Daether.connector.http.connectionMaxTtl=30
+-Duser.language=en
+-Duser.country=GB
+-Duser.timezone=UTC
+ MAVEN_COMMAND: >-
+./mvnw
+-V
+-nsu
+-ntp
+-ff
+
+# skip assemblies and modules covered separately by the system-tests workflow
+# skip unit tests (surefire), run integration tests (failsafe), python ITs
included as part of the system-tests workflow
+ MAVEN_BUILD_ARGUMENTS: >-
+-D failsafe.failIfNoSpecifiedTests=false
+verify
+-P skip-unit-tests
+-P integration-tests
+-P nifi-registry-integration-tests
+ MAVEN_BUILD_EXCLUDE_PROJECTS: >-
+-pl -:minifi-assembly
+-pl -:minifi-c2-assembly
+-pl -:nifi-assembly
+-pl -:nifi-toolkit-assembly
+-pl -:nifi-registry-assembly
+-pl -:nifi-registry-toolkit-assembly
+-pl -:nifi-runtime-manifest
+-pl -:nifi-runtime-manifest-test
+-pl -:nifi-stateless-assembly
+-pl -:nifi-stateless-processor-tests
+-pl -:nifi-stateless-system-test-suite
+-pl -:nifi-system-test-suite
+-pl -:nifi-nar-provider-assembly
+-pl -:nifi-py4j-integration-tests
+# skip individual failing ITs (some won't work in a CI environment)
+# always run the (failsafe default) IT*, *IT, *ITCase integration-tests
+ MAVEN_FAILSAFE_SKIP_ITS: >-
+IT*, *IT, *ITCase,
+!AwsSecretsManagerSensitivePropertyProviderIT,
+!AwsKmsSensitivePropertyProviderIT,
+!AzureKeyVaultKeySensitivePropertyProviderIT,
+!GcpKmsSensitivePropertyProviderIT,
+!StandardHashiCorpVaultCommunicationServiceIT,
+!ConversionWithSchemaInferenceIT#testXmlToAvro,
+!ConversionWithSchemaInferenceIT#testXmlToJson,
+!ConversionWithSchemaInferenceIT#testJsonToCsv,
+!ConversionWithSchemaInferenceIT#testCsvToXml,
+!ConversionWithSchemaInferenceIT#testXmlToAvroToXml,
+!ConversionWithSchemaInferenceIT#testCsvToAvro,
+!ConversionWithSchemaInferenceIT#testCsvToJson,
+!ConversionWithSchemaInferenceIT#testJsonToAvroToJson,
+!ConversionWithSchemaInferenceIT#testCsvToAvroToCsv,
+!ConversionWithExplicitSchemaIT#testJsonToCsv,
+!ConversionWithExplicitSchemaIT#testJsonToAvro,
+!ConversionWithExplicitSchemaIT#testJsonToAvroToJson,
+!ITConsumeKinesisStreamEndpointOverride,
