Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
NihalJain commented on PR #156: URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970564565 I think this PR also handles thttps://issues.apache.org/jira/browse/OMID-266, just FYI @stoty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-272 Support JDK17 [phoenix-omid]
stoty commented on PR #153: URL: https://github.com/apache/phoenix-omid/pull/153#issuecomment-1970560127 merged manually -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
NihalJain commented on PR #156: URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970557100 I see there is an explicit guava dependency in omid at https://github.com/apache/phoenix-omid/blob/master/pom.xml#L1215. If it was replaced with shaded one, do we really need it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-272 Support JDK17 [phoenix-omid]
stoty closed pull request #153: OMID-272 Support JDK17 URL: https://github.com/apache/phoenix-omid/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821957#comment-17821957 ] ASF GitHub Bot commented on PHOENIX-7130: - chrajeshbabu merged PR #1745: URL: https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821956#comment-17821956 ] ASF GitHub Bot commented on PHOENIX-7130: - chrajeshbabu commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1970510225 Since build failures are not related this. Merging > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
chrajeshbabu merged PR #1745: URL: https://github.com/apache/phoenix/pull/1745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
chrajeshbabu commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1970510225 Since build failures are not related this. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
stoty commented on PR #156: URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970502628 The most frustrating part is that every single one of these Guava usages is completely unneccessary, this could have been done without Guava with the same effort. But I digress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
stoty commented on PR #156: URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970500550 > Here we need manual verification only with locally deployed cluster? Yes, that's the only way to make sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
stoty commented on code in PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#discussion_r1507077825
##
pom.xml:
##
@@ -293,6 +294,67 @@
+
+ org.apache.maven.plugins
+ maven-enforcer-plugin
+
+
+ de.skuzzle.enforcer
+ restrict-imports-enforcer-rule
+ ${restrict-imports.enforcer.version}
+
+
Review Comment:
Straight copy-paste from Phoenix :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
virajjasani commented on code in PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#discussion_r1507075329
##
pom.xml:
##
@@ -293,6 +294,67 @@
+
+ org.apache.maven.plugins
+ maven-enforcer-plugin
+
+
+ de.skuzzle.enforcer
+ restrict-imports-enforcer-rule
+ ${restrict-imports.enforcer.version}
+
+
Review Comment:
Nice! When i started looking at the changes, i immediately came here to see
if we are going to restrict the import.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] OMID-277 Omid 1.1.2 fails with Phoenix 5.2 [phoenix-omid]
stoty opened a new pull request, #156: URL: https://github.com/apache/phoenix-omid/pull/156 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821908#comment-17821908 ] ASF GitHub Bot commented on PHOENIX-7243: - palashc commented on PR #1838: URL: https://github.com/apache/phoenix/pull/1838#issuecomment-1970198673 Opened https://github.com/apache/phoenix/pull/1839 for master branch @shahrs87 > Add isServerConnection property to ConnectionInfo class. > > > Key: PHOENIX-7243 > URL: https://issues.apache.org/jira/browse/PHOENIX-7243 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Palash Chauhan >Priority: Major > > In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed > by ConnectionInfo object. Refer > [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270] > for more details. > Lets say if we want to create a server connection (with property > IS_SERVER_CONNECTION set to true) and we already have a _non server_ > connection present in the cache (with the same user, principal, keytab, > haGroup), it will return the non server connection. > We need to add isServerConnection property to > [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334] > class to differentiate between server and non server connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821909#comment-17821909 ] ASF GitHub Bot commented on PHOENIX-7243: - palashc closed pull request #1838: PHOENIX-7243 : Add isServerConnection property to ConnectionInfo URL: https://github.com/apache/phoenix/pull/1838 > Add isServerConnection property to ConnectionInfo class. > > > Key: PHOENIX-7243 > URL: https://issues.apache.org/jira/browse/PHOENIX-7243 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Palash Chauhan >Priority: Major > > In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed > by ConnectionInfo object. Refer > [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270] > for more details. > Lets say if we want to create a server connection (with property > IS_SERVER_CONNECTION set to true) and we already have a _non server_ > connection present in the cache (with the same user, principal, keytab, > haGroup), it will return the non server connection. > We need to add isServerConnection property to > [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334] > class to differentiate between server and non server connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
palashc closed pull request #1838: PHOENIX-7243 : Add isServerConnection property to ConnectionInfo URL: https://github.com/apache/phoenix/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
palashc commented on PR #1838: URL: https://github.com/apache/phoenix/pull/1838#issuecomment-1970198673 Opened https://github.com/apache/phoenix/pull/1839 for master branch @shahrs87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821907#comment-17821907 ] ASF GitHub Bot commented on PHOENIX-7243: - palashc opened a new pull request, #1839: URL: https://github.com/apache/phoenix/pull/1839 (no comment) > Add isServerConnection property to ConnectionInfo class. > > > Key: PHOENIX-7243 > URL: https://issues.apache.org/jira/browse/PHOENIX-7243 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Palash Chauhan >Priority: Major > > In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed > by ConnectionInfo object. Refer > [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270] > for more details. > Lets say if we want to create a server connection (with property > IS_SERVER_CONNECTION set to true) and we already have a _non server_ > connection present in the cache (with the same user, principal, keytab, > haGroup), it will return the non server connection. > We need to add isServerConnection property to > [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334] > class to differentiate between server and non server connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
palashc opened a new pull request, #1839: URL: https://github.com/apache/phoenix/pull/1839 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-1661) Implement built-in functions for JSON
[ https://issues.apache.org/jira/browse/PHOENIX-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821898#comment-17821898 ] ASF GitHub Bot commented on PHOENIX-1661: - wlei-llvm closed pull request #102: PHOENIX-1661 Implement built-in functions for JSON URL: https://github.com/apache/phoenix/pull/102 > Implement built-in functions for JSON > - > > Key: PHOENIX-1661 > URL: https://issues.apache.org/jira/browse/PHOENIX-1661 > Project: Phoenix > Issue Type: Sub-task >Reporter: James R. Taylor >Assignee: LeiWang >Priority: Major > Labels: JSON, Java, SQL, gsoc2015, mentor > Attachments: Implement built-in functions for JSON.pdf, > PHOENIX-1661-00.patch, PHOENIX-1661.patch, > PhoenixJSONSpecification-First-Draft.pdf > > > Take a look at the JSON built-in functions that are implemented in Postgres > (http://www.postgresql.org/docs/9.3/static/functions-json.html) and implement > the same for Phoenix in Java following this guide: > http://phoenix-hbase.blogspot.com/2013/04/how-to-add-your-own-built-in-function.html > Examples of functions include ARRAY_TO_JSON, ROW_TO_JSON, TO_JSON, etc. The > implementation of these built-in functions will be impacted by how JSON is > stored in Phoenix. See PHOENIX-628. An initial implementation could work off > of a simple text-based JSON representation and then when a native JSON type > is implemented, they could be reworked to be more efficient. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-1661 Implement built-in functions for JSON [phoenix]
wlei-llvm closed pull request #102: PHOENIX-1661 Implement built-in functions for JSON URL: https://github.com/apache/phoenix/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[
https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821885#comment-17821885
]
ASF GitHub Bot commented on PHOENIX-7243:
-
palashc commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506758361
##
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
-ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Pushed the refactor, no changes in Drivers needed.
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
Done.
> Add isServerConnection property to ConnectionInfo class.
>
>
> Key: PHOENIX-7243
> URL: https://issues.apache.org/jira/browse/PHOENIX-7243
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rushabh Shah
>Assignee: Palash Chauhan
>Priority: Major
>
> In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed
> by ConnectionInfo object. Refer
> [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270]
> for more details.
> Lets say if we want to create a server connection (with property
> IS_SERVER_CONNECTION set to true) and we already have a _non server_
> connection present in the cache (with the same user, principal, keytab,
> haGroup), it will return the non server connection.
> We need to add isServerConnection property to
> [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334]
> class to differentiate between server and non server connection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
palashc commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506758361
##
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
-ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Pushed the refactor, no changes in Drivers needed.
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[
https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821878#comment-17821878
]
ASF GitHub Bot commented on PHOENIX-7243:
-
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506718473
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
All the other variables are being set via Builder. Lets not break that
pattern for `isServerConnection`
> Add isServerConnection property to ConnectionInfo class.
>
>
> Key: PHOENIX-7243
> URL: https://issues.apache.org/jira/browse/PHOENIX-7243
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rushabh Shah
>Assignee: Palash Chauhan
>Priority: Major
>
> In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed
> by ConnectionInfo object. Refer
> [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270]
> for more details.
> Lets say if we want to create a server connection (with property
> IS_SERVER_CONNECTION set to true) and we already have a _non server_
> connection present in the cache (with the same user, principal, keytab,
> haGroup), it will return the non server connection.
> We need to add isServerConnection property to
> [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334]
> class to differentiate between server and non server connection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506718473
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
All the other variables are being set via Builder. Lets not break that
pattern for `isServerConnection`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[
https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821877#comment-17821877
]
ASF GitHub Bot commented on PHOENIX-7243:
-
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506717514
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
I think we should initialize `isServerConnection` the same way we are
initializing principal, keytab, user and haGroup variables.
> Add isServerConnection property to ConnectionInfo class.
>
>
> Key: PHOENIX-7243
> URL: https://issues.apache.org/jira/browse/PHOENIX-7243
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rushabh Shah
>Assignee: Palash Chauhan
>Priority: Major
>
> In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed
> by ConnectionInfo object. Refer
> [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270]
> for more details.
> Lets say if we want to create a server connection (with property
> IS_SERVER_CONNECTION set to true) and we already have a _non server_
> connection present in the cache (with the same user, principal, keytab,
> haGroup), it will return the non server connection.
> We need to add isServerConnection property to
> [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334]
> class to differentiate between server and non server connection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506717514
##
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java:
##
@@ -114,6 +115,15 @@ public static ConnectionInfo create(String url,
ReadOnlyProps props, Properties
return create(url, conf, props, info);
}
+public static ConnectionInfo create(String url, ReadOnlyProps props,
+Properties info, boolean isServerConnection)
+throws SQLException {
+Configuration conf =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration();
+ConnectionInfo connInfo = create(url, conf, props, info);
+connInfo.isServerConnection = isServerConnection;
Review Comment:
I think we should initialize `isServerConnection` the same way we are
initializing principal, keytab, user and haGroup variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[
https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821876#comment-17821876
]
ASF GitHub Bot commented on PHOENIX-7243:
-
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506709112
##
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
-ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Why do we want to pass as a separate argument for `isServerConnection`? It
is present in `info` object anyways.
> Add isServerConnection property to ConnectionInfo class.
>
>
> Key: PHOENIX-7243
> URL: https://issues.apache.org/jira/browse/PHOENIX-7243
> Project: Phoenix
> Issue Type: Sub-task
>Reporter: Rushabh Shah
>Assignee: Palash Chauhan
>Priority: Major
>
> In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed
> by ConnectionInfo object. Refer
> [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270]
> for more details.
> Lets say if we want to create a server connection (with property
> IS_SERVER_CONNECTION set to true) and we already have a _non server_
> connection present in the cache (with the same user, principal, keytab,
> haGroup), it will return the non server connection.
> We need to add isServerConnection property to
> [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334]
> class to differentiate between server and non server connection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
shahrs87 commented on code in PR #1838:
URL: https://github.com/apache/phoenix/pull/1838#discussion_r1506709112
##
phoenix-core/src/test/java/org/apache/phoenix/jdbc/PhoenixTestDriver.java:
##
@@ -92,7 +93,8 @@ public synchronized Connection connect(String url, Properties
info) throws SQLEx
public synchronized ConnectionQueryServices
getConnectionQueryServices(String url, Properties infoIn) throws SQLException {
checkClosed();
final Properties info = PropertiesUtil.deepCopy(infoIn);
-ConnectionInfo connInfo = ConnectionInfo.create(url, null, info);
+boolean isServerConnection =
Boolean.valueOf(info.getProperty(QueryUtil.IS_SERVER_CONNECTION));
+ConnectionInfo connInfo = ConnectionInfo.create(url, null, info,
isServerConnection);
Review Comment:
Why do we want to pass as a separate argument for `isServerConnection`? It
is present in `info` object anyways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7243) Add isServerConnection property to ConnectionInfo class.
[ https://issues.apache.org/jira/browse/PHOENIX-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821866#comment-17821866 ] ASF GitHub Bot commented on PHOENIX-7243: - palashc opened a new pull request, #1838: URL: https://github.com/apache/phoenix/pull/1838 (no comment) > Add isServerConnection property to ConnectionInfo class. > > > Key: PHOENIX-7243 > URL: https://issues.apache.org/jira/browse/PHOENIX-7243 > Project: Phoenix > Issue Type: Sub-task >Reporter: Rushabh Shah >Assignee: Palash Chauhan >Priority: Major > > In PhoenixDriver, we have a cache of ConnectionQueryServices which is keyed > by ConnectionInfo object. Refer > [here|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java#L258-L270] > for more details. > Lets say if we want to create a server connection (with property > IS_SERVER_CONNECTION set to true) and we already have a _non server_ > connection present in the cache (with the same user, principal, keytab, > haGroup), it will return the non server connection. > We need to add isServerConnection property to > [ConnectionInfo|https://github.com/apache/phoenix/blob/master/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java#L317-L334] > class to differentiate between server and non server connection. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] PHOENIX-7243 : Add isServerConnection property to ConnectionInfo [phoenix]
palashc opened a new pull request, #1838: URL: https://github.com/apache/phoenix/pull/1838 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7242) Cleanup / Resurrect hbase-table-reporter
[ https://issues.apache.org/jira/browse/PHOENIX-7242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821786#comment-17821786 ] Nihal Jain commented on PHOENIX-7242: - Oops I mistakenly created in PHOENIX project. [~stoty] could you please help move to HBASE? I am not sure why but I can't see an option to move. Sorry for the inconvenience. > Cleanup / Resurrect hbase-table-reporter > - > > Key: PHOENIX-7242 > URL: https://issues.apache.org/jira/browse/PHOENIX-7242 > Project: Phoenix > Issue Type: Task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Seems hbase-table-reporter code is not maintained or maybe not even used? We > have not had any change since a long time. > With this JIRA, I plan on doing following: > * Bump dependencies to be latest, remove redundant ones > * Update docs as I am not sure why it references com.apple.hbase.Reporter > * Do basic sanity based on docs and ensure it works -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain commented on PR #1837: URL: https://github.com/apache/phoenix/pull/1837#issuecomment-1969405263 This is a backport of https://github.com/apache/phoenix/pull/1745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821764#comment-17821764 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1837: URL: https://github.com/apache/phoenix/pull/1837#issuecomment-1969405263 This is a backport of https://github.com/apache/phoenix/pull/1745 > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821763#comment-17821763 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain opened a new pull request, #1837: URL: https://github.com/apache/phoenix/pull/1837 (no comment) > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain opened a new pull request, #1837: URL: https://github.com/apache/phoenix/pull/1837 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821759#comment-17821759 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1969390922 Rebased code and updated all new instances of createSourcesJar in code. Could you please review and merge this.? CC: @gjacoby126 @stoty @virajjasani > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1969390922 Rebased code and updated all new instances of createSourcesJar in code. Could you please review and merge this.? CC: @gjacoby126 @stoty @virajjasani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] PHOENIX-7130 Support skipping of shade sources jar creation [phoenix]
NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1969380052 Rebased code and verified no new instances of createSourcesJar in code. Could you please merge this.? CC: @gjacoby126 @stoty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (PHOENIX-7130) Support skipping of shade sources jar creation
[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821754#comment-17821754 ] ASF GitHub Bot commented on PHOENIX-7130: - NihalJain commented on PR #1773: URL: https://github.com/apache/phoenix/pull/1773#issuecomment-1969380052 Rebased code and verified no new instances of createSourcesJar in code. Could you please merge this.? CC: @gjacoby126 @stoty > Support skipping of shade sources jar creation > -- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7172) Support HBase 2.6
[
https://issues.apache.org/jira/browse/PHOENIX-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821724#comment-17821724
]
ASF GitHub Bot commented on PHOENIX-7172:
-
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506152751
##
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+public CompatIndexHalfStoreFileReader(final FileSystem fs, final
CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext,
final HFileInfo hFileInfo) throws IOException {
+super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs,
new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This will point to the FS root, and fail.
At least fails on 3.0, and it doesn't ,make sense either.
> Support HBase 2.6
> -
>
> Key: PHOENIX-7172
> URL: https://issues.apache.org/jira/browse/PHOENIX-7172
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.2.0, 5.1.3
>Reporter: Istvan Toth
>Assignee: Richárd Antal
>Priority: Major
>
> HBase 2.6.0 release work is ongoing.
> Make sure Phoenix works with it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506152751
##
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+public CompatIndexHalfStoreFileReader(final FileSystem fs, final
CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext,
final HFileInfo hFileInfo) throws IOException {
+super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs,
new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This will point to the FS root, and fail.
At least fails on 3.0, and it doesn't ,make sense either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7172) Support HBase 2.6
[
https://issues.apache.org/jira/browse/PHOENIX-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821722#comment-17821722
]
ASF GitHub Bot commented on PHOENIX-7172:
-
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506148196
##
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+public CompatIndexHalfStoreFileReader(final FileSystem fs, final
CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext,
final HFileInfo hFileInfo) throws IOException {
+super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs,
new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This is broken.
You need to pass the Path here, and use it directly.
> Support HBase 2.6
> -
>
> Key: PHOENIX-7172
> URL: https://issues.apache.org/jira/browse/PHOENIX-7172
> Project: Phoenix
> Issue Type: Improvement
> Components: core
>Affects Versions: 5.2.0, 5.1.3
>Reporter: Istvan Toth
>Assignee: Richárd Antal
>Priority: Major
>
> HBase 2.6.0 release work is ongoing.
> Make sure Phoenix works with it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506148196
##
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+public CompatIndexHalfStoreFileReader(final FileSystem fs, final
CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext,
final HFileInfo hFileInfo) throws IOException {
+super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs,
new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This is broken.
You need to pass the Path here, and use it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (PHOENIX-7241) SaltedTableMergeBucketsIT is very slow on HBase 3.0
[ https://issues.apache.org/jira/browse/PHOENIX-7241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821624#comment-17821624 ] Istvan Toth commented on PHOENIX-7241: -- I don't see this after increasing the max heap size, so this may have been simply due to too much GC because the heap usage was on the limit. > SaltedTableMergeBucketsIT is very slow on HBase 3.0 > --- > > Key: PHOENIX-7241 > URL: https://issues.apache.org/jira/browse/PHOENIX-7241 > Project: Phoenix > Issue Type: Bug > Components: core >Affects Versions: 5.3.0 >Reporter: Istvan Toth >Priority: Minor > > it runs for more than 20 minutes, while it finishes in less than 10 with > HBase 2 (same machine) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (PHOENIX-7237) Pherf unit tests PherfTest and ResourceTest are failing
[
https://issues.apache.org/jira/browse/PHOENIX-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821571#comment-17821571
]
ASF GitHub Bot commented on PHOENIX-7237:
-
ddupg commented on PR #1835:
URL: https://github.com/apache/phoenix/pull/1835#issuecomment-1968517106
> I don't like this, as this is very brittle, and we will have the same
problem again soon. (The previous patch has the same problem)
>
> The real problem is that pherf seems to try to load its test config from
anywhere on the classpath.
>
> I would prefer that the logic in getResourcesPath is fixed so that it does
not recursively search the whole classpath.
>
>
https://github.com/apache/phoenix/blob/bc1e2e7bea40c7d03940748e8f1d9f6b23339867/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java#L103
Thanks @stoty for reviewing and opinion, I'll try to fix it.
> Pherf unit tests PherfTest and ResourceTest are failing
> ---
>
> Key: PHOENIX-7237
> URL: https://issues.apache.org/jira/browse/PHOENIX-7237
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 5.2.0, 5.1.3
>Reporter: Sun Xin
>Priority: Major
>
> I got same problem like PHOENIX-5776 in master and 5.1 branch.
> {code:java}
> org.apache.phoenix.pherf.exception.PherfException: Could not load resources:
> /datamodel/alter_table_add.sql {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] PHOENIX-7237 Pherf unit tests PherfTest and ResourceTest are failing [phoenix]
ddupg commented on PR #1835: URL: https://github.com/apache/phoenix/pull/1835#issuecomment-1968517106 > I don't like this, as this is very brittle, and we will have the same problem again soon. (The previous patch has the same problem) > > The real problem is that pherf seems to try to load its test config from anywhere on the classpath. > > I would prefer that the logic in getResourcesPath is fixed so that it does not recursively search the whole classpath. > > https://github.com/apache/phoenix/blob/bc1e2e7bea40c7d03940748e8f1d9f6b23339867/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java#L103 Thanks @stoty for reviewing and opinion, I'll try to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
