Re: [PR] SOLR-17198: AttributeFetcher no longer fails when it observes multiple shard leaders [solr]
dsmiley commented on PR #2335: URL: https://github.com/apache/solr/pull/2335#issuecomment-1985044638 BTW I looked into the test failure in the first run; can't have anything to do with this PR. I filed https://github.com/apache/solr/pull/2337 to avoid that NPE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]
solrbot commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1985017934 ### Edited/Blocked Notification Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ **Warning**: custom changes will be lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
cdrini commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908 ## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ## @@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the list of constraints to |Optional |Default: `0` |=== + -The `facet.mincount` parameter specifies the minimum counts required for a facet field to be included in the response. +The minimum count required for a facet field to be included in the response. If a field's counts are below the minimum, the field's facet is not returned. Review Comment: Good question! I think I might leave this as it was originally for now, since I don't fully understand how these terms are supposed to differ. These terms really need a good untangling in this document. If I get the time I'll tackle this in a separate PR to tidy it up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
cdrini commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908 ## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ## @@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the list of constraints to |Optional |Default: `0` |=== + -The `facet.mincount` parameter specifies the minimum counts required for a facet field to be included in the response. +The minimum count required for a facet field to be included in the response. If a field's counts are below the minimum, the field's facet is not returned. Review Comment: Good question! I think I might leave this as it was originally, since I don't fully understand how these terms are supposed to differ. These terms really need a good untangling in this document. If I get the time I'll tackle this in a separate PR to tidy it up! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
cdrini commented on PR #2162: URL: https://github.com/apache/solr/pull/2162#issuecomment-1985016847 Thanks for the review @cpoerschke ! Ok @epugh , this should be ready to go now! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
cdrini commented on code in PR #2162: URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908 ## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ## @@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the list of constraints to |Optional |Default: `0` |=== + -The `facet.mincount` parameter specifies the minimum counts required for a facet field to be included in the response. +The minimum count required for a facet field to be included in the response. If a field's counts are below the minimum, the field's facet is not returned. Review Comment: Good question! I think I might leave this as is, since I don't fully understand how these terms are supposed to differ. These terms really need a good untangling in this document. If I get the time I'll tackle this in a separate PR to tidy it up! ## solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc: ## @@ -113,7 +113,7 @@ This does not limit the query in any way, only the facets that would be returned |Optional |Default: none |=== + -If `facet.contains` is used, the `facet.contains.ignoreCase` parameter causes case to be ignored when matching the given substring against candidate facet terms. +Causes case to be ignored when matching the `facet.contains` substring against candidate facet terms. Review Comment: Nice, this appears to be consistent with other lines on this page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
cdrini commented on PR #2162: URL: https://github.com/apache/solr/pull/2162#issuecomment-1985010050 Ah apologies for the delay! Will update this week :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]
risdenk commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1984985404 Pushed e0d36967626d1e261c172739974d534dc81ce219 updating the assertions in the percentiles for tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]
risdenk commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1984975758 The nitty gritty details look to be here: https://github.com/tdunning/t-digest/issues/171 and https://github.com/opensearch-project/OpenSearch/pull/3634 basically for small sample sizes there used to be a bug and now its fixed. That seems to be my rough interpretation so its not surprising that our tests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]
risdenk commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1984966867 t-digest 3.2 looks fine but 3.3 seems to have different stats assertions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
risdenk commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-1984950183 The stack trace to me looks like it could be there are 2 things doing the delete and its a race condition who gets there first? Otherwise I don't see how we would end up getting this exception. This isn't the top level path right? The stack trace says this is happening while walking the file tree... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17106) LBSolrClient: Make it configurable to remove zombie ping checks
[
https://issues.apache.org/jira/browse/SOLR-17106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824591#comment-17824591
]
Chris M. Hostetter commented on SOLR-17106:
---
Hi Aparna,
This looks pretty good ... but it still seems like a few things have slipped
through the cracks?
* In the {{Builder}} classes, {{aliveCheckQuery}} needs to to default to the
existing behavior which is currently in {{LBSolrClient}} 's {{private static
final SolrQuery solrQuery}}
** I would rename/refactor that to something like {{protected static final
SolrQuery DEFAULT_ALIVE_CHECK_QUERY}} and re-use it when initializing
{{aliveCheckQuery}} in both {{Builder}} classes
** IMO we should change the default to {{null}} on the {{main}} branch, but
first we need a patch that is cleanly backcompatible to commit & backport to
9x, then we can discuss changing the defaults on it's own merits
* In the actual {{LBSolrClient}} subclasses, the {{aliveCheckSkipIters}} and
{{aliveCheckQuery}} variables need to be final
* In {{checkAZombieServer}} you are inspection & decrementing
{{zombieServer.skipAliveCheckIters}} before doing the ping check – but in the
event that the ping fails, you are never re-setting the value of
{{zombieServer.skipAliveCheckIters}}
** So instead of only pinging ever Nth iter, it will ping on every iter
starting with the Nth iter
** {{handleServerDown}} should reset {{zombieServer.skipAliveCheckIters =
this.aliveCheckSkipIters;}}
* The new private {{pingServer}} and {{isServerAlive}} methods you added feel
like they are too intertwined to make sense as individual methods?
** Both have to explicitly check if {{aliveCheckQuery}} is null
** The return value of {{pingServer}} is only used by {{isServerAlive}} and no
where else.
** I think it would make more sense to just merge these two methods into...
{code:java}
private boolean isServerAlive(ServerWrapper zombieServer) throws
SolrServerException, IOException {
if (null == aliveCheckQuery) {
return true;
}
QueryRequest queryRequest = new QueryRequest(aliveCheckQuery);
queryRequest.setBasePath(zombieServer.baseUrl);
return
queryRequest.process(getClient(zombieServer.getBaseUrl())).getStatus() == 0;
}
{code}
...those are my functionality concerns, i also have some nit-picky concerns...
* Severally places in your patch modify lines in ways that only change
formatting
** If you run {{gradle tidy}} before committing to your branch these should be
automatically cleaned up
* It looks like you also added an unused import of
{{io.swagger.v3.oas.annotations.servers.Server}} ?
** {{gradle tidy}} (or maybe it's {{gradle check}} ?) should also catch this.
* I it would be good to have some {{@see}} tags or {{@link}} tags in the
javadocs of {{setAliveCheckSkipIters}} , {{{}setAliveCheckInterval{}}}, and
{{setAliveCheckQuery}} explaining how they all relate to each other.
* {{testReliability()}} is already not a very good test – it's certainly not
worth copy/pasting exactly as is just to change the client slightly
** It would be cleaner to just refactor it's body into a helper method (ie:
{{protected doTestReliability(LBSolrClient)}} ) that you call from both
{{testReliabilityWithLivenessChecks()}} and your new
{{testReliabilityWithMinimumZombieTimeAndDisabledQueries()}}
** Better still: we can make {{{}checkAZombieServer{}}}, {{isServerAlive}} do
some {{DEBUG}} level logging about the particulars of what it's doing (when it
skips a server because of the {{{}skipAliveCheckIters{}}}, when it assumes
success because {{aliveCheckQuery}} is null, when it gets a success or failure
result from a server, etc...) and then make tose tests use the {{@LogLevel}}
annotation along with the {{LogListener}} helper class (restricted to
substrings matching the name of the server we stop/restart) to assert it got
the expected log messages (we just can't be too picky about the number of times
those messages are logged)
> LBSolrClient: Make it configurable to remove zombie ping checks
> ---
>
> Key: SOLR-17106
> URL: https://issues.apache.org/jira/browse/SOLR-17106
> Project: Solr
> Issue Type: Improvement
>Reporter: Aparna Suresh
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Following discussion from a dev list discussion here:
> [https://lists.apache.org/thread/f0zfmpg0t48xrtppyfsmfc5ltzsq2qqh]
> The issue involves scalability challenges in SolrJ's *LBSolrClient* when a
> pod with numerous cores experiences connectivity problems. The "zombie"
> tracking mechanism, operating on a core basis, becomes a bottleneck during
> distributed search on a massive multi shard collection. Threads attempting to
> reach unhealthy cores contribute to a high computational load, causing
>
[PR] Tests: avoid NPE in JettySolrRunner lifeCycleStopped [solr]
dsmiley opened a new pull request, #2337: URL: https://github.com/apache/solr/pull/2337 Very simple little check. I saw in a failure here: https://github.com/apache/solr/actions/runs/8180447387/job/22376604762?pr=2335 for TestLBHttp2SolrClient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
HoustonPutman commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-1984577087 Not sure if this is the end-all-be-all approach. Maybe the error occurs while it's deleting a child tree, and the rest of the files arent' deleted? Here's the stack trace: ``` 2024-03-07 18:59:44.928 ERROR (parallelCoreAdminAPIBaseExecutor-20-thread-6-processing-solr-e2e-1-foo-solrcloud-0.test.solr.org:80_solr e2e-2_shard2_replica_n5 solr-e2e-1-foo-solrcloud-0.test.solr.org-78 move-replicas-foo-solrcloud-0698005595075831 unload) [ x:e2e-2_shard2_replica_n5 t:solr-e2e-1-foo-solrcloud-0.test.solr.org-78] o.a.s.c.CachingDirectoryFactory Error removing directory => java.nio.file.NoSuchFileException: /var/solr/data/e2e-2_shard2_replica_n5/data/index at java.base/sun.nio.fs.UnixException.translateToIOException(Unknown Source) java.nio.file.NoSuchFileException: /var/solr/data/e2e-2_shard2_replica_n5/data/index at sun.nio.fs.UnixException.translateToIOException(Unknown Source) ~[?:?] at sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source) ~[?:?] at sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source) ~[?:?] at sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(Unknown Source) ~[?:?] at sun.nio.fs.UnixFileSystemProvider.readAttributes(Unknown Source) ~[?:?] at sun.nio.fs.LinuxFileSystemProvider.readAttributes(Unknown Source) ~[?:?] at java.nio.file.Files.readAttributes(Unknown Source) ~[?:?] at java.nio.file.FileTreeWalker.getAttributes(Unknown Source) ~[?:?] at java.nio.file.FileTreeWalker.visit(Unknown Source) ~[?:?] at java.nio.file.FileTreeWalker.walk(Unknown Source) ~[?:?] at java.nio.file.Files.walkFileTree(Unknown Source) ~[?:?] at java.nio.file.Files.walkFileTree(Unknown Source) ~[?:?] at org.apache.commons.io.file.PathUtils.visitFileTree(PathUtils.java:1654) ~[?:?] at org.apache.commons.io.file.PathUtils.lambda$deleteDirectory$0(PathUtils.java:503) ~[?:?] at org.apache.commons.io.file.PathUtils.withPosixFileAttributes(PathUtils.java:1774) ~[?:?] at org.apache.commons.io.file.PathUtils.deleteDirectory(PathUtils.java:502) ~[?:?] at org.apache.commons.io.file.PathUtils.deleteDirectory(PathUtils.java:487) ~[?:?] at org.apache.solr.core.StandardDirectoryFactory.removeDirectory(StandardDirectoryFactory.java:92) ~[?:?] at org.apache.solr.core.CachingDirectoryFactory.close(CachingDirectoryFactory.java:216) ~[?:?] at org.apache.solr.core.SolrCore.doClose(SolrCore.java:1891) ~[?:?] at org.apache.solr.core.SolrCore.close(SolrCore.java:1755) ~[?:?] at org.apache.solr.core.SolrCore.closeAndWait(SolrCore.java:1561) ~[?:?] at org.apache.solr.core.CoreContainer.unload(CoreContainer.java:2170) ~[?:?] at org.apache.solr.handler.admin.CoreAdminOperation.lambda$static$1(CoreAdminOperation.java:128) ~[?:?] at org.apache.solr.handler.admin.CoreAdminOperation.execute(CoreAdminOperation.java:414) ~[?:?] at org.apache.solr.handler.admin.CoreAdminHandler$CallInfo.call(CoreAdminHandler.java:374) ~[?:?] at org.apache.solr.handler.admin.CoreAdminHandler.lambda$handleRequestBody$0(CoreAdminHandler.java:235) ~[?:?] at org.apache.solr.handler.admin.CoreAdminHandler$CoreAdminAsyncTracker.lambda$submitAsyncTask$0(CoreAdminHandler.java:473) ~[?:?] at com.codahale.metrics.InstrumentedExecutorService$InstrumentedRunnable.run(InstrumentedExecutorService.java:212) ~[metrics-core-4.2.20.jar:4.2.20] at org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:294) ~[?:?] at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) ~[?:?] at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) ~[?:?] at java.lang.Thread.run(Unknown Source) [?:?] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
HoustonPutman commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-1984574418 > I'm curious, was there a reason for replacing FileUtils.deleteDirectory() with PathUtils.deleteDirectory()? @magibney https://issues.apache.org/jira/browse/SOLR-16074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Use a System wide property to enable PRS [solr]
dsmiley commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-1984571357 BTW it's nice to see PRS used/tested more :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
magibney commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-1984545453 I'm curious, was there a reason for replacing `FileUtils.deleteDirectory()` with `PathUtils.deleteDirectory()`? Related: I've been in the CachingDirectoryFactory code recently and I recall there's some logic that's supposed to defer the deletion of parent directories until descendant directories are no longer referenced (have been deleted). This change seems reasonable to me (i.e., if you're asking to delete something, at the end of the day you want it gone; so if it's already gone, that shouldn't throw an exception). Still I'm going to take a look and see whether there might be a problem with the "deletion-deferral" code that's being uncovered by this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Use a System wide property to enable PRS [solr]
dsmiley commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-1984524318 I believe this has caused NullPointerExceptions in OverseerStatusTest -- createcollection is null. Quite a number of test failures for this since this was merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17173) Be explicit if distrib.statsCache=true but there's no statsCache configured or not?
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev reassigned SOLR-17173:
---
Assignee: Mikhail Khludnev
> Be explicit if distrib.statsCache=true but there's no statsCache configured
> or not?
>
>
> Key: SOLR-17173
> URL: https://issues.apache.org/jira/browse/SOLR-17173
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query
>Reporter: Mikhail Khludnev
>Assignee: Mikhail Khludnev
>Priority: Minor
> Fix For: 9.6.0
>
>
> Let's discuss [~weiwang19].
> h2. What if
> user forget to configure distributed statsCache, but request
> {{distrib.statsCache=true}} see SOLR-17058
> h2. Expect
> I prefer to through exception (400) explaining that one can't expect
> distributed IDF in response.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17173) Be explicit if distrib.statsCache=true but there's no statsCache configured or not?
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-17173:
Fix Version/s: 9.6.0
> Be explicit if distrib.statsCache=true but there's no statsCache configured
> or not?
>
>
> Key: SOLR-17173
> URL: https://issues.apache.org/jira/browse/SOLR-17173
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: query
>Reporter: Mikhail Khludnev
>Priority: Minor
> Fix For: 9.6.0
>
>
> Let's discuss [~weiwang19].
> h2. What if
> user forget to configure distributed statsCache, but request
> {{distrib.statsCache=true}} see SOLR-17058
> h2. Expect
> I prefer to through exception (400) explaining that one can't expect
> distributed IDF in response.
> WDYT?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
HoustonPutman commented on code in PR #2336:
URL: https://github.com/apache/solr/pull/2336#discussion_r1516795796
##
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##
@@ -192,7 +191,7 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
}
} catch (Exception e) {
/* create-core failed, cleanup the copied configset before propagating
the error. */
- PathUtils.deleteDirectory(coreInstanceDir);
+ org.apache.solr.util.FileUtils.deleteDirectory(coreInstanceDir);
Review Comment:
Unfortunately another FileUtils is used in this file as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
epugh commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-1984396468 I think I saw some problems with the `RunExampleTool` when I was trying to make it so you could run it twice, and it would reset the state on the second run.. weird things happened, so eventually I gave up and just logged a "Your example already exists so you may get werid stuff".. I may go back and take a looksee at it as it may have been related to this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
epugh commented on code in PR #2336:
URL: https://github.com/apache/solr/pull/2336#discussion_r1516792080
##
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##
@@ -192,7 +191,7 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
}
} catch (Exception e) {
/* create-core failed, cleanup the copied configset before propagating
the error. */
- PathUtils.deleteDirectory(coreInstanceDir);
+ org.apache.solr.util.FileUtils.deleteDirectory(coreInstanceDir);
Review Comment:
Should this be a fully qualified package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-16866) CachingDirectoryFactory Throwing Error When Closing
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824530#comment-17824530
]
Houston Putman commented on SOLR-16866:
---
I made a PR for this. Was seeing it in the Solr Operator integration tests.
> CachingDirectoryFactory Throwing Error When Closing
> ---
>
> Key: SOLR-16866
> URL: https://issues.apache.org/jira/browse/SOLR-16866
> Project: Solr
> Issue Type: Bug
>Affects Versions: 9.2.1
>Reporter: Stefan Pieper
>Priority: Major
> Labels: core
> Attachments: solr.blueprint_gnylctsgemcz_users.log
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Observed occasional ERROR log entries when {{CachingDirectryFactory#close()}}
> is called. The respective snippet from the log is this:
> {noformat}
> 2023-07-06 08:43:37.618 DEBUG (qtp212011969-1801) [
> blueprint_gnylctsgemcz_users] o.a.s.c.CachingDirectoryFactory Removing
> directory after core close: /var/solr/data/blueprint_gnylctsgemcz_users/data
> 2023-07-06 08:43:37.620 DEBUG (qtp212011969-1801) [
> blueprint_gnylctsgemcz_users] o.a.s.c.CachingDirectoryFactory Removing
> directory after core close:
> /var/solr/data/blueprint_gnylctsgemcz_users/data/index
> 2023-07-06 08:43:37.620 ERROR (qtp212011969-1801) [
> blueprint_gnylctsgemcz_users] o.a.s.c.CachingDirectoryFactory Error removing
> directory => java.nio.file.NoSuchFileException:
> /var/solr/data/blueprint_gnylctsgemcz_users/data/index
> java.nio.file.NoSuchFileException:
> /var/solr/data/blueprint_gnylctsgemcz_users/data/index
> {noformat}
> It seems like the order of directory removal is causing this (first parent
> dir _data_, then sub-dir _data/index_). Entries should be re-arranged or just
> the parent dir be handled.
> Full log with entries dealing with the respective core is attached.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]
HoustonPutman opened a new pull request, #2336: URL: https://github.com/apache/solr/pull/2336 https://issues.apache.org/jira/browse/SOLR-16866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
HoustonPutman commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983824945 > Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually update the 9.5 guide. Let me try. You are not mistaken! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1516376085
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHttpClient(
- SolrCore core,
- String httpBasicAuthUser,
- String httpBasicAuthPassword,
- boolean useCompression) {
+ private Http2SolrClient createHttpClient(
Review Comment:
rename to "createSolrClient" so we don't confuse a lower level httpClient
with a solrClient. Whenever I see a method/field/param name saying
"httpClient" but the type is actually "SolrClient"; it irks me. httpSolrClient
is fine if you prefer.
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHttpClient(
- SolrCore core,
- String httpBasicAuthUser,
- String httpBasicAuthPassword,
- boolean useCompression) {
+ private Http2SolrClient createHttpClient(
+ SolrCore core, String httpBasicAuthUser, String httpBasicAuthPassword,
String leaderBaseUrl) {
final ModifiableSolrParams httpClientParams = new ModifiableSolrParams();
Review Comment:
This is now unused. I'd hope that authentication stuff would be handled in
some other way (e.g. via configuration / initialization in UpdateShardHandler
creating the recoveryOnlyHttpClient) so that internal Solr code here can merely
get this pre-configured client. That client should also already have an
InstrumentedHttpListenerFactory too; no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1983485002 Test case which is failing. > ./gradlew :solr:core:test --tests "org.apache.solr.handler.TestHealthCheckHandlerLegacyMode.doTestHealthCheckWithReplication" -Ptests.jvms=2 "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=6C9BE6E7222DDA0B -Ptests.file.encoding=US-ASCII -Ptests.verbose=true And If I remove the code which is removing the ACCEPT_ENCODING header in Http2SolrClient then it works fine! `req.headers(headers -> headers.remove(HttpHeader.ACCEPT_ENCODING));` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983479315 The theory behind the guide build is that there is not supposed to be any functional change within a minor version, so any fixes pushed to `branch_9_5` are by definition bug fixes, including fixes to ref guide. This makes it safe to build the guide immediately even without a code release. We could even use this to push "Errata" entries to the guide after we discover bugs in a release that will not be fixed in an upcoming release... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983469119 I did a push, let's wait for daily build of https://ci-builds.apache.org/job/Solr/job/solr-reference-guide-official/ - I think it will kick off in an hour or so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
epugh commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983464922 If this works...I wonder if we should try an establish a stronger pattern for doc fixes going `main` --> `branch_9x` and --> `branch_9_5` ? Though it is a whole nother step -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
janhoy commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983460238 Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually update the 9.5 guide. Let me try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Make parameter descriptions consistent in faceting.adoc [solr]
epugh commented on PR #2162: URL: https://github.com/apache/solr/pull/2162#issuecomment-1983459204 hey @cdrini do you want to take another spin though this PR and finalize some of the changes? Then I'd love to merge this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
epugh commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983453157 I don't believe changes to ref guides go immediately (unlike the website changes)...We don't have a "quick push this change to productioin ref guide" that isn't tied to a release. Hopefully 9.6 will be out soon, and I don't think this will justify a 9.5.x release... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1983413759 There will be no need to add the extra code at SolrRequest level. I can just call add header for SolrRequest to add "ACCEPT_ENCODING:gzip" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-1983401595 ### Allow Compression HttpSolrClient provides feature to enable external compression that would add "ACCEPT_ENCODING: gzip" to the request headers. And we are using this feature in `IndexFetcher.class` while creating HttpSolrClient. https://github.com/apache/solr/blob/a1104bd04a799ba99cba652922bfded51d0c2d72/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java#L428-L433 Now Jetty Http client by default add "ACCEPT_ENCODING: gzip" header to all the request. However, in `Http2SolrClient2.java` we have removed that header while decorating request. https://github.com/apache/solr/blob/a1104bd04a799ba99cba652922bfded51d0c2d72/solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java#L632-L634 Added new commit that would allow users to enable external compression at request level. Now I only enabled for one request in IndexFetcher, I believe It should be added for each request. Or, we can add this functionality to Http2SolrClient which would add for all the request automatically. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824384#comment-17824384
]
Andrzej Bialecki commented on SOLR-17199:
-
I didn't see it - thanks for fixing it!
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.5.0
>Reporter: Andrzej Bialecki
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 9.6.0
>
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency com.tdunning:t-digest to v3.3 [solr]
janhoy commented on PR #2136: URL: https://github.com/apache/solr/pull/2136#issuecomment-1983316503 So turns out the Streaming tests fail consistently with this upgrade. Have not dived into it, but there must be some incompatible behavior between these versions causing this. Anyone knows why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Assigned] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-17199:
--
Assignee: Jan Høydahl
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.5.0
>Reporter: Andrzej Bialecki
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 9.6.0
>
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Resolved] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17199.
Resolution: Fixed
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.5.0
>Reporter: Andrzej Bialecki
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: 9.6.0
>
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17199:
---
Fix Version/s: 9.6.0
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.5.0
>Reporter: Andrzej Bialecki
>Priority: Major
> Fix For: 9.6.0
>
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Updated] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17199:
---
Affects Version/s: 9.5.0
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 9.5.0
>Reporter: Andrzej Bialecki
>Priority: Major
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Move EnvToSyspropMappings.properties to solrj module [solr]
janhoy commented on PR #2320: URL: https://github.com/apache/solr/pull/2320#issuecomment-1983311288 Related JIRA just opened: https://issues.apache.org/jira/browse/SOLR-17199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Commented] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824372#comment-17824372
]
Jan Høydahl commented on SOLR-17199:
Hi, did you see [https://github.com/apache/solr/pull/2320] ? Mentioned in
CHANGES, but no JIRA.
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-core
>
>
> Key: SOLR-17199
> URL: https://issues.apache.org/jira/browse/SOLR-17199
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Andrzej Bialecki
>Priority: Major
>
> Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
> its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
> been moved from solr-core to solr-solrj but the configuration resource has
> been left in solr-core.
> This unfortunately means that {{EnvUtils}} cannot be used without dependency
> on solr-core, unless user adds their own copy of the configuration resource
> to the classpath. Right now trying to use it (or using {{PropertiesUtil}} for
> property substitution) results in an exception from the static initializer:
> {code}
> Caused by: java.lang.NullPointerException
> at java.base/java.util.Objects.requireNonNull(Objects.java:209)
> at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
[jira] [Created] (SOLR-17199) EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from solr-core
Andrzej Bialecki created SOLR-17199:
---
Summary: EnvUtils in solr-solrj is missing
EnvToSyspropMappings.properties from solr-core
Key: SOLR-17199
URL: https://issues.apache.org/jira/browse/SOLR-17199
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Andrzej Bialecki
Initially in SOLR-15960 {{EnvUtils}} was located in solr-core, together with
its configuration resource {{EnvToSyspropMappings.properties}}. Then it has
been moved from solr-core to solr-solrj but the configuration resource has been
left in solr-core.
This unfortunately means that {{EnvUtils}} cannot be used without dependency on
solr-core, unless user adds their own copy of the configuration resource to the
classpath. Right now trying to use it (or using {{PropertiesUtil}} for property
substitution) results in an exception from the static initializer:
{code}
Caused by: java.lang.NullPointerException
at java.base/java.util.Objects.requireNonNull(Objects.java:209)
at org.apache.solr.common.util.EnvUtils.(EnvUtils.java:51)
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Clean up docker-faq.adoc [solr]
syats commented on PR #2277: URL: https://github.com/apache/solr/pull/2277#issuecomment-1983196506 The fact that this PR is not yet in the productive documentation https://solr.apache.org/guide/solr/latest/deployment-guide/docker-faq.html as of 2023-03-07 is a source of confusion! The current documentation does not reflect the move of the data folder! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations-jakarta to v2.2.20 [solr]
janhoy merged PR #2064: URL: https://github.com/apache/solr/pull/2064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
Re: [PR] Update org.mockito:mockito* to v5.11.0 [solr]
janhoy merged PR #2325: URL: https://github.com/apache/solr/pull/2325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
