[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099267#comment-15099267 ] ASF subversion and git services commented on TS-3478: - Commit 9c75b1e7a600c5e25cde537174b2966369225eb6 in trafficserver's branch refs/heads/6.1.x from [~masaori] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9c75b1e ] TS-3478: clang-format > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15099265#comment-15099265 ] ASF subversion and git services commented on TS-3478: - Commit 0a4e949b02fc8f31a7579859af9f36b54908ccd7 in trafficserver's branch refs/heads/6.1.x from [~rokubo] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0a4e949 ] TS-3478: Indexing header representations on HPACK encoder This closes #391 (cherry picked from commit 82ce75676f2ad614be20793b4a217308e6981e84) > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090515#comment-15090515 ] ASF subversion and git services commented on TS-3478: - Commit 770e7878c0f4dde9516f6f93490eb8b2f66a8dd2 in trafficserver's branch refs/heads/master from [~masaori] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=770e787 ] TS-3478: clang-format > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090514#comment-15090514 ] ASF subversion and git services commented on TS-3478: - Commit 82ce75676f2ad614be20793b4a217308e6981e84 in trafficserver's branch refs/heads/master from [~rokubo] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=82ce756 ] TS-3478: Indexing header representations on HPACK encoder This closes #391 > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090516#comment-15090516 ] ASF GitHub Bot commented on TS-3478: Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/391 > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090504#comment-15090504 ] ASF GitHub Bot commented on TS-3478: Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170210554 Oops, I mean TS-4092. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090503#comment-15090503 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170210430 The fixes look ok to me. @masaori335 You mean TS-4092? I'm going to refine the names and interfaces. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.2.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090438#comment-15090438 ] ASF GitHub Bot commented on TS-3478: Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-170200715 I'm fine to ship this. 1. Actually I'm not big fun of names of classes and functions in HPACK starting with 'HTTP2'. But those confusions are going to be fixed in [TS-3967](https://issues.apache.org/jira/browse/TS-3967) with others. 2. Regression tests worked. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088788#comment-15088788 ] ASF GitHub Bot commented on TS-3478: Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-169910983 @masaori335 @maskit please take another look > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085646#comment-15085646 ] Leif Hedstrom commented on TS-3478: --- [~rokubo] Should this land for 6.1.0, or should we move out to 6.2.0? > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082934#comment-15082934 ] ASF GitHub Bot commented on TS-3478: Github user syucream commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-168982622 @maskit I concern about Http2DynamicTable too. I'll add IndexingTable layer and separate Http2DynamicTable and static table. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082926#comment-15082926 ] ASF GitHub Bot commented on TS-3478: Github user syucream commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48837742 --- Diff: proxy/http2/HPACK.h --- @@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str, uint32_t &str_length, const uint int64_t encode_indexed_header_field(uint8_t *buf_start, const uint8_t *buf_end, uint32_t index); int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t *buf_end, const MIMEFieldWrapper &header, uint32_t index, -HpackFieldType type); +Http2DynamicTable &dynamic_table, HpackFieldType type); int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t *buf_end, const MIMEFieldWrapper &header, --- End diff -- I prefer `with_(indexed|new)_name`. I'll rename them. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075300#comment-15075300 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/391#issuecomment-168053932 Http2DynamicTable class is getting messy. To clarify the responsibility of Http2DynamicTable and to make the codes maintainable, it would be better to cleanup at this time. I suggest having Indexing Tables layer and accessors for Static Table instead of adding all the things into Http2DynamicTable. It would make the codes much readable. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[
https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075227#comment-15075227
]
ASF GitHub Bot commented on TS-3478:
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48617340
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field)
}
MIMEField *new_field = _mhdr->field_create(name, name_len);
+new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len);
new_field->value_set(_mhdr->m_heap, _mhdr->m_mime, value, value_len);
+mime_hdr_field_attach(_mhdr->m_mime, new_field, 1, NULL);
// XXX Because entire Vec instance is copied, Its too expensive!
_headers.insert(0, new_field);
}
}
+uint32_t
+Http2DynamicTable::get_dynamic_table_size() const
+{
+ return _current_size;
+}
+
+Http2LookupIndexResult
+Http2DynamicTable::get_index(const MIMEFieldWrapper &field) const
+{
+ Http2LookupIndexResult result;
+ int target_name_len = 0, target_value_len = 0;
+ const char *target_name = field.name_get(&target_name_len);
+ const char *target_value = field.value_get(&target_value_len);
+ const int entry_num = TS_HPACK_STATIC_TABLE_ENTRY_NUM +
get_current_entry_num();
+
+ for (int index = 1; index < entry_num; ++index) {
+const char *table_name, *table_value;
+int table_name_len = 0, table_value_len = 0;
+
+if (index < TS_HPACK_STATIC_TABLE_ENTRY_NUM) {
+ // static table
+ table_name = STATIC_TABLE[index].name;
+ table_value = STATIC_TABLE[index].value;
+ table_name_len = strlen(table_name);
+ table_value_len = strlen(table_value);
+} else {
+ // dynamic table
+ const MIMEField *m_field = get_header(index -
TS_HPACK_STATIC_TABLE_ENTRY_NUM + 1);
+ table_name = m_field->name_get(&table_name_len);
+ table_value = m_field->value_get(&table_value_len);
+}
+
+// Check whether name (and value) are matched
+if (ptr_len_casecmp(target_name, target_name_len, table_name,
table_name_len) == 0) {
+ if (ptr_len_casecmp(target_value, target_value_len, table_value,
table_value_len) == 0) {
--- End diff --
At least values must be compared with case sensitive.
> Indexing header representations on HPACK encoder
>
>
> Key: TS-3478
> URL: https://issues.apache.org/jira/browse/TS-3478
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
>Reporter: Ryo Okubo
>Assignee: Ryo Okubo
> Labels: review
> Fix For: 6.1.0
>
> Attachments: indexing.patch
>
>
> Support other header field representations on HPACK encoder.
> http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6
> Currently the encoder supports only [Literal Header Field never
> Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[
https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075174#comment-15075174
]
ASF GitHub Bot commented on TS-3478:
Github user maskit commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48614287
--- Diff: proxy/http2/HPACK.cc ---
@@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField
*field)
}
MIMEField *new_field = _mhdr->field_create(name, name_len);
+new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len);
new_field->value_set(_mhdr->m_heap, _mhdr->m_mime, value, value_len);
+mime_hdr_field_attach(_mhdr->m_mime, new_field, 1, NULL);
// XXX Because entire Vec instance is copied, Its too expensive!
_headers.insert(0, new_field);
}
}
+uint32_t
+Http2DynamicTable::get_dynamic_table_size() const
+{
+ return _current_size;
+}
+
+Http2LookupIndexResult
+Http2DynamicTable::get_index(const MIMEFieldWrapper &field) const
+{
+ Http2LookupIndexResult result;
+ int target_name_len = 0, target_value_len = 0;
+ const char *target_name = field.name_get(&target_name_len);
+ const char *target_value = field.value_get(&target_value_len);
+ const int entry_num = TS_HPACK_STATIC_TABLE_ENTRY_NUM +
get_current_entry_num();
+
+ for (int index = 1; index < entry_num; ++index) {
+const char *table_name, *table_value;
+int table_name_len = 0, table_value_len = 0;
+
+if (index < TS_HPACK_STATIC_TABLE_ENTRY_NUM) {
+ // static table
+ table_name = STATIC_TABLE[index].name;
--- End diff --
Should we care about Static Table here? It's Http2DynamicTable class.
> Indexing header representations on HPACK encoder
>
>
> Key: TS-3478
> URL: https://issues.apache.org/jira/browse/TS-3478
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
>Reporter: Ryo Okubo
>Assignee: Ryo Okubo
> Labels: review
> Fix For: 6.1.0
>
> Attachments: indexing.patch
>
>
> Support other header field representations on HPACK encoder.
> http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6
> Currently the encoder supports only [Literal Header Field never
> Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075157#comment-15075157 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48613605 --- Diff: proxy/http2/HPACK.cc --- @@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField *field) } MIMEField *new_field = _mhdr->field_create(name, name_len); +new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len); new_field->value_set(_mhdr->m_heap, _mhdr->m_mime, value, value_len); +mime_hdr_field_attach(_mhdr->m_mime, new_field, 1, NULL); // XXX Because entire Vec instance is copied, Its too expensive! _headers.insert(0, new_field); } } +uint32_t +Http2DynamicTable::get_dynamic_table_size() const --- End diff -- I prefer `get_table_size` because we know it is Dynamic Table. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075152#comment-15075152 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48613347 --- Diff: proxy/http2/HPACK.cc --- @@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField *field) } MIMEField *new_field = _mhdr->field_create(name, name_len); +new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len); new_field->value_set(_mhdr->m_heap, _mhdr->m_mime, value, value_len); +mime_hdr_field_attach(_mhdr->m_mime, new_field, 1, NULL); --- End diff -- Why don't you use `MIMEHdr::field_attach`? It's inconsistent to use the function here. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075150#comment-15075150 ] ASF GitHub Bot commented on TS-3478: Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48612923 --- Diff: proxy/http2/HPACK.cc --- @@ -263,12 +263,80 @@ Http2DynamicTable::add_header_field(const MIMEField *field) } MIMEField *new_field = _mhdr->field_create(name, name_len); +new_field->name_set(_mhdr->m_heap, _mhdr->m_mime, name, name_len); --- End diff -- It seems the field name has been set just one line above. Why is this needed? > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066002#comment-15066002 ] ASF GitHub Bot commented on TS-3478: Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/391#discussion_r48113520 --- Diff: proxy/http2/HPACK.h --- @@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str, uint32_t &str_length, const uint int64_t encode_indexed_header_field(uint8_t *buf_start, const uint8_t *buf_end, uint32_t index); int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t *buf_end, const MIMEFieldWrapper &header, uint32_t index, -HpackFieldType type); +Http2DynamicTable &dynamic_table, HpackFieldType type); int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t *buf_end, const MIMEFieldWrapper &header, --- End diff -- Those `encode_literal_header_field()` should be something like `encode_literal_header_field_with_indexed_name()` and `encode_literal_header_field_with_new_name()` ? > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15065960#comment-15065960 ] ASF GitHub Bot commented on TS-3478: GitHub user syucream opened a pull request: https://github.com/apache/trafficserver/pull/391 TS-3478: Indexing header representations on HPACK encoder https://issues.apache.org/jira/browse/TS-3478 You can merge this pull request into a Git repository by running: $ git pull https://github.com/syucream/trafficserver indexing Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/391.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #391 commit effd36180f1a3f3bbac7c8b36978ad90a7206eba Author: Ryo Okubo Date: 2015-12-13T14:42:55Z Support static/dynamic indexing to HPACK encoder > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15064240#comment-15064240 ] Leif Hedstrom commented on TS-3478: --- Yes, make it so. Please land as soon as ready, and I will cherry pick. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15063244#comment-15063244 ] Ryo Okubo commented on TS-3478: --- I've done almost of fixing conflict and I'll create a PR soon. If its no problem, I'd like to land it for 6.1.0. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15060469#comment-15060469 ] Leif Hedstrom commented on TS-3478: --- [~rokubo] [~masaori] What's the status here? Should we land this for 6.1.0? > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15046456#comment-15046456 ] Masaori Koshiba commented on TS-3478: - [~rokubo] Could you resolve conflicts and send a Pull-Request on github? > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Ryo Okubo > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14735275#comment-14735275 ] Leif Hedstrom commented on TS-3478: --- Of course, this no longer applies to master :). > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Leif Hedstrom > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3478) Indexing header representations on HPACK encoder
[ https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648735#comment-14648735 ] Leif Hedstrom commented on TS-3478: --- Cool, moving it out for 6.1.0, I'll land this after we're done with the master <-> 6.0.x cleanup. > Indexing header representations on HPACK encoder > > > Key: TS-3478 > URL: https://issues.apache.org/jira/browse/TS-3478 > Project: Traffic Server > Issue Type: Improvement > Components: HTTP/2 >Reporter: Ryo Okubo >Assignee: Leif Hedstrom > Labels: review > Fix For: 6.1.0 > > Attachments: indexing.patch > > > Support other header field representations on HPACK encoder. > http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6 > Currently the encoder supports only [Literal Header Field never > Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
