[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34826
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 05/Jan/17 20:33
Start Date: 05/Jan/17 20:33
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1092
Looks like someone else fixed this along the way. Closing.
Issue Time Tracking
---
Worklog Id: (was: 34826)
Time Spent: 1h 20m (was: 1h 10m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34825
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 05/Jan/17 20:33
Start Date: 05/Jan/17 20:33
Worklog Time Spent: 10m
Work Description: Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1092
Issue Time Tracking
---
Worklog Id: (was: 34825)
Time Spent: 1h 20m (was: 1h 10m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34064
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 22/Dec/16 17:07
Start Date: 22/Dec/16 17:07
Worklog Time Spent: 10m
Work Description: Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1092
Can you please update, so it doesn't conflict and commit it.
Issue Time Tracking
---
Worklog Id: (was: 34064)
Time Spent: 1h 10m (was: 1h)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=34061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34061
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 22/Dec/16 17:05
Start Date: 22/Dec/16 17:05
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1092
Ship it.
Issue Time Tracking
---
Worklog Id: (was: 34061)
Time Spent: 1h (was: 50m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30406
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:51
Start Date: 11/Oct/16 18:51
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1092
I'm not very familiar with this code. Was just trying to adjust the logic
to avoid the coverity found NULL error.
We could adjust to send the traffic to the else in line 2179 which appears
to be the error case handling. @SolidWallOfCode do you have an opinion.
Issue Time Tracking
---
Worklog Id: (was: 30406)
Time Spent: 50m (was: 40m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30395
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:32
Start Date: 11/Oct/16 18:32
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/1092
Is this really the right thing to do? The configuration for this
transaction said we needed to use the client address to connect to, but we
can't get it because we don't have a VC any more. This seems like an error,
rather than something we should muddle through. Why isn't the UA VC required
here?
Issue Time Tracking
---
Worklog Id: (was: 30395)
Time Spent: 40m (was: 0.5h)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30389
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:15
Start Date: 11/Oct/16 18:15
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1092
Linux build *successful*! See
https://ci.trafficserver.apache.org/job/Github-Linux/853/ for details.
Issue Time Tracking
---
Worklog Id: (was: 30389)
Time Spent: 0.5h (was: 20m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30388
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:13
Start Date: 11/Oct/16 18:13
Worklog Time Spent: 10m
Work Description: Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1092
FreeBSD build *successful*! See
https://ci.trafficserver.apache.org/job/Github-FreeBSD/961/ for details.
Issue Time Tracking
---
Worklog Id: (was: 30388)
Time Spent: 20m (was: 10m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Work logged] (TS-4948) CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30385
]
ASF GitHub Bot logged work on TS-4948:
--
Author: ASF GitHub Bot
Created on: 11/Oct/16 17:59
Start Date: 11/Oct/16 17:59
Worklog Time Spent: 10m
Work Description: GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1092
TS-4948: Adjust code to prevent NULL variable reference.
Attempting to fix a coverity warning by clearing the user_client_addr bool
when the client_addr variable cannot be reset from NULL. The later references
to uses of client_addr are covered by the use_client_addr bool.
Cannot directly run coverity, so not sure this makes the tool happy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1092.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1092
commit b04ecf7440e53764bbf0f161a9c3ec187e7cf81f
Author: Susan Hinrichs
Date: 2016-10-11T17:56:42Z
TS-4948: Adjust code to prevent NULL variable reference.
Issue Time Tracking
---
Worklog Id: (was: 30385)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117:(FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr(r);
> 2110
>CID 1364117:(FORWARD_NULL)
>Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr=
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
