Re: github code reviews
On Mon, 10 Mar 2014, Jonathan Aquilina wrote: > I have two suggestions that might help, but first let me tell you a bit > about myself. > > I am project manager for LMMS (Linux Multimedia Studio) and we recently > started using github for our version control hosting. > > With this we started using continuous integration provided free of charge > by Travis CI. It is very easy to integrate into a github repo by just > adding a YAML file if I am not mistaken. Once that is in place every > commit triggers a build on the Travis CI build machines. It as well on the > pull requests tells you if the build passes. If it does not it also alerts > the committer that the build has failed so that it can quickly be fixed. We originally looked at this for the Juju GUI but we could not use it. Travis does not support the idea of a 'landing test run'. If your code review takes a few days, the trunk that you ran in Travis could be changed enough that your code no longer passes CI. This is why we went with Jenkins and wrote the lander [2] tool. It forces a final CI pass and automates the landing to the trunk branch. I did reach out to the Travis folks and their reply was that they did not think this idea of the post-review test/land work was part of their mission and were not interested in adding support for it. I'm not sure how they have that logic myself though. [2] https://github.com/juju/jenkins-github-lander Rick -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: github code reviews
I have two suggestions that might help, but first let me tell you a bit about myself. I am project manager for LMMS (Linux Multimedia Studio) and we recently started using github for our version control hosting. With this we started using continuous integration provided free of charge by Travis CI. It is very easy to integrate into a github repo by just adding a YAML file if I am not mistaken. Once that is in place every commit triggers a build on the Travis CI build machines. It as well on the pull requests tells you if the build passes. If it does not it also alerts the committer that the build has failed so that it can quickly be fixed. If you want to take it down another router in addition to this. Libreoffice uses gerrit which is a code review system, which has a web based interface to manage the patches for review. Regards Jonathan > On Fri, Mar 7, 2014 at 4:07 PM, Nate Finch > wrote: > >> I like github. I don't like in-line diffs and one email per code review >> comment, which is all github provides. So I did a quick google, and >> this >> came up: >> >> https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml >> >> >> it looks pretty good. http://gerrithub.io/ >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> > There is also https://github.com/jarodwen/git-cl which many are claiming > to > have good luck with. It would mimic or existing work flow and continue to > use Rietveld. > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: github code reviews
On Fri, Mar 7, 2014 at 4:07 PM, Nate Finch wrote: > I like github. I don't like in-line diffs and one email per code review > comment, which is all github provides. So I did a quick google, and this > came up: > > https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml > > > it looks pretty good. http://gerrithub.io/ > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > There is also https://github.com/jarodwen/git-cl which many are claiming to have good luck with. It would mimic or existing work flow and continue to use Rietveld. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: github code reviews
On Fri, 07 Mar 2014, Nate Finch wrote: > I like github. I don't like in-line diffs and one email per code review > comment, which is all github provides. So I did a quick google, and this > came up: > > https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml > > > it looks pretty good. http://gerrithub.io/ There's a chrome extension for enabling side by side diffs I've been using as well. https://chrome.google.com/webstore/detail/octosplit/mnkacicafjlllhcedhhphhpapmdgjfbb -- Rick Harding Juju UI Engineering https://launchpad.net/~rharding @mitechie -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: github code reviews
Hi Nate, We used ReviewBoard at my last area and all the developers really liked the tool. It was very easy to review, and comment on code. ReviewBoard ( www.reviewboard.org ) allows in-line comments and according to the web page works with Bazaar and Git. I found the interface very clean and easy to understand. - Matt On Fri, Mar 7, 2014 at 3:07 PM, Nate Finch wrote: > I like github. I don't like in-line diffs and one email per code review > comment, which is all github provides. So I did a quick google, and this > came up: > > https://review.gerrithub.io/#/c/2160/2/roles/packstack/rdo/tasks/main.yml > > > it looks pretty good. http://gerrithub.io/ > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
