Re: add dependencies step to github readme?
On 4 June 2014 11:02, Nate Finch wrote: > There's an option to pass -copy=false which won't copy over the sourcecode. This *should* work, but currently doesn't because godep doesn't support some of its functionality (the sandbox box) for bzr dependencies. That should not stop it working when using godep restore, so I've submitted a PR to godep to fix that (https://github.com/tools/godep/pull/89). With that fix, godep does pretty much what we need (but see below). > I don't think we need to keep the external sourcecode in our repo, given > that all our external dependencies are controlled by canonicalers (and we > have N copies of the dependencies where N = the number of people who have > build juju recently). Agreed, mostly. All our external dependencies are not actually controlled by canonicalers, but I don't think that changes the point. For less well controlled dependencies (github.com/binary132/gojsonschema springs to mind) we should perhaps consider forking the project into github.com/juju. > Definitely we should try it out and see if it fixes any of the niggles we > have with godeps. The main niggle there AFAIK is the fact that godeps doesn't know how to download new dependencies. I could fix that, but I'd prefer to move towards using a tool that's not used by us only. Godep is by no means perfect though. It's quite slow as it updates dependencies on a package-by-package basis rather than a repo-by-repo basis. It also does not complain if one of the repositories you're restoring has local changes, which could result in some awkward situations. Hopefully I'll be able to get some PRs to godep approved that will help there. cheers, rog. -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: add dependencies step to github readme?
There's an option to pass -copy=false which won't copy over the sourcecode. I don't think we need to keep the external sourcecode in our repo, given that all our external dependencies are controlled by canonicalers (and we have N copies of the dependencies where N = the number of people who have build juju recently). Definitely we should try it out and see if it fixes any of the niggles we have with godeps. On Wed, Jun 4, 2014 at 2:16 AM, John Meinel wrote: > So there is a request up to do this, which we can move forward on, but I'm > not personally convinced. If only because it isn't actually a simple > drop-in replacement. > Specifically, Godeps defaults to copying all of the dependencies into > Godeps/_workspace, and then wants you to actually change your commands to > "godeps go test ./..." etc. > If I read it correctly, essentially Godeps wants to control your GOPATH > rather than using a shared GOPATH. > I'm not a big fan of having an extra copy of my dependencies in a hidden > directory (since then I'm not actually sure what code is being run at any > given time.) > We *can* switch, but it means we should be prepared to switch over how we > run code, deal with dependencies, etc. > > John > =:-> > > > On Wed, Jun 4, 2014 at 5:28 AM, Andrew Wilkins < > andrew.wilk...@canonical.com> wrote: > >> Agreed, we should improve that. Sounds like we're going to change over to >> using godep instead of godeps, so we should update this at the same time. >> >> Cheers, >> Andrew >> >> >> On Tue, Jun 3, 2014 at 6:33 PM, Jesse Meek >> wrote: >> >>> After running: >>> >>> go get -v github.com/juju/core/... >>> >>> >>> I got: >>> >>> ../../github.com/juju/core/testing/imports.go:17: undefined: " >>> github.com/juju/testing".FindImports >>> >>> which was resolved by updating my dependencies with godeps. Shouldn't we >>> add "godeps -u dependencies.tsv" as a step in the readme? >>> >>> -- >>> Juju-dev mailing list >>> Juju-dev@lists.ubuntu.com >>> Modify settings or unsubscribe at: >>> https://lists.ubuntu.com/mailman/listinfo/juju-dev >>> >>> >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: add dependencies step to github readme?
So there is a request up to do this, which we can move forward on, but I'm not personally convinced. If only because it isn't actually a simple drop-in replacement. Specifically, Godeps defaults to copying all of the dependencies into Godeps/_workspace, and then wants you to actually change your commands to "godeps go test ./..." etc. If I read it correctly, essentially Godeps wants to control your GOPATH rather than using a shared GOPATH. I'm not a big fan of having an extra copy of my dependencies in a hidden directory (since then I'm not actually sure what code is being run at any given time.) We *can* switch, but it means we should be prepared to switch over how we run code, deal with dependencies, etc. John =:-> On Wed, Jun 4, 2014 at 5:28 AM, Andrew Wilkins wrote: > Agreed, we should improve that. Sounds like we're going to change over to > using godep instead of godeps, so we should update this at the same time. > > Cheers, > Andrew > > > On Tue, Jun 3, 2014 at 6:33 PM, Jesse Meek > wrote: > >> After running: >> >> go get -v github.com/juju/core/... >> >> >> I got: >> >> ../../github.com/juju/core/testing/imports.go:17: undefined: " >> github.com/juju/testing".FindImports >> >> which was resolved by updating my dependencies with godeps. Shouldn't we >> add "godeps -u dependencies.tsv" as a step in the readme? >> >> -- >> Juju-dev mailing list >> Juju-dev@lists.ubuntu.com >> Modify settings or unsubscribe at: >> https://lists.ubuntu.com/mailman/listinfo/juju-dev >> >> > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
Re: add dependencies step to github readme?
Agreed, we should improve that. Sounds like we're going to change over to using godep instead of godeps, so we should update this at the same time. Cheers, Andrew On Tue, Jun 3, 2014 at 6:33 PM, Jesse Meek wrote: > After running: > > go get -v github.com/juju/core/... > > > I got: > > ../../github.com/juju/core/testing/imports.go:17: undefined: " > github.com/juju/testing".FindImports > > which was resolved by updating my dependencies with godeps. Shouldn't we > add "godeps -u dependencies.tsv" as a step in the readme? > > -- > Juju-dev mailing list > Juju-dev@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/juju-dev > > -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
add dependencies step to github readme?
After running: go get -v github.com/juju/core/... I got: ../../github.com/juju/core/testing/imports.go:17: undefined: "github.com/juju/testing".FindImports which was resolved by updating my dependencies with godeps. Shouldn't we add "godeps -u dependencies.tsv" as a step in the readme? -- Juju-dev mailing list Juju-dev@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/juju-dev
