Re: [JPP-Devel] openjump on github

[edgar . soldin]

On 1/20/2021 12:54, Eric wrote:
> Hi,
>
> On 19/01/2021 13:13, edgar.sol...@web.de wrote:
>> On 1/19/2021 9:19, Michaud Michael wrote:
>>> Hi Jumpers
>>>
>>> Thanks to Eric's guide, I could initialize openjump project on gitub 
>>> (openjump-gis/openjump) and convert it to jts 1.18.
>>>
>>> It is not perfect (I could not convert 1.5 post_release 
>>> 
>>>  tag because of the whitespace in the name :-(), but all in all, I think it 
>>> is OK.
>> tag '1.5 post_release' seems to be there with a %20, or am i missing 
>> something?
>>
>>> Please, have a look and let me know if you think so.
>> commit history seem to be identical to sf.net svn, though we're missing 
>> 2years because of an improper svn mov from /trunk/openjump to /trunk/core . 
>> just for completeness sake we should probably transfer this as into a 
>> history branch if someone wants to research changes to a specific source 
>> file.
> Would you consider creating a specific repository for these 2 years rather 
> than a branch? It would probably reduce the size of the main repository, 
> which is already quite large (~750MB).
> See these considerations: 
> https://docs.github.com/en/github/managing-large-files/what-is-my-disk-quota#file-and-repository-size-limitations

sounds perfectly reasonable. these 2 missing years are meant as an archive for 
researching purposes only anyways.

> As the OJ repository will only come larger over time, it could slow the 
> fetching process.
>
> The creation of a specific repository could probably be considered as well to 
> store the former SVN "branches", i.e. oj_stable_1_2 (updated 14 years ago by 
> Stefan Steiniger), 1.2 (updated 14 years ago by Stefan Steiniger), paustin 
> (updated 14 years ago by Paul Austin), 1.3 (updated 12 years ago by Stefan 
> Steiniger), sstein@1863 (updated 11 years ago by Larry Becker) and 
> stable%201.5 (updated 9 years ago by Michael Michaud). All the tags would 
> stay, including the ones in link with the 1.2 and 1.3 versions listed in 
> branches (were these branches some pre-release tests?).

currently we dropped those. looking like private devel/test branches to me 
which can be discarded.

>>> I could compile but I still have a problem to run maven.
>>>
>>> I did not migrate plugins at all (not sure how we must proceed yet, some 
>>> options must be discussed)
>> sure, one step after the other. no need to hurry things. generally i'd be in 
>> favour of one branch per plugin, but might be swayed otherwise.
>
> Ede, do you mean one repository per plugin rather than one branch?

indeed. no reason to keep all plugins in one plugin repo.

> If in the future, the plan is to create/add a plugin manager,

there is, since actually always ;)

>the option to create a repository per plugin could facilitate their 
>maintenance, especially if the OJ distribution can be used as a Maven 
>dependency for these plugins.

totally

>>> There are probably plenty of things to improve and fix before we start 
>>> again to add new code.
>>>
>>> I'll try to list some more precise points to discuss in a future mail.
>> ok, looking forward to it. ..ede
>
> Eric

thanks!.. ede


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] openjump on github

[Eric]

Hi,

On 19/01/2021 13:13, edgar.sol...@web.de wrote:

On 1/19/2021 9:19, Michaud Michael wrote:

Hi Jumpers

Thanks to Eric's guide, I could initialize openjump project on gitub 
(openjump-gis/openjump) and convert it to jts 1.18.

It is not perfect (I could not convert 1.5 post_release 

 tag because of the whitespace in the name :-(), but all in all, I think it is OK.

tag '1.5 post_release' seems to be there with a %20, or am i missing something?


Please, have a look and let me know if you think so.

commit history seem to be identical to sf.net svn, though we're missing 2years 
because of an improper svn mov from /trunk/openjump to /trunk/core . just for 
completeness sake we should probably transfer this as into a history branch if 
someone wants to research changes to a specific source file.
Would you consider creating a specific repository for these 2 years 
rather than a branch? It would probably reduce the size of the main 
repository, which is already quite large (~750MB).
See these considerations: 
https://docs.github.com/en/github/managing-large-files/what-is-my-disk-quota#file-and-repository-size-limitations


As the OJ repository will only come larger over time, it could slow the 
fetching process.


The creation of a specific repository could probably be considered as 
well to store the former SVN "branches", i.e. oj_stable_1_2 (updated 14 
years ago by Stefan Steiniger), 1.2 (updated 14 years ago by Stefan 
Steiniger), paustin (updated 14 years ago by Paul Austin), 1.3 (updated 
12 years ago by Stefan Steiniger), sstein@1863 (updated 11 years ago by 
Larry Becker) and stable%201.5 (updated 9 years ago by Michael Michaud). 
All the tags would stay, including the ones in link with the 1.2 and 1.3 
versions listed in branches (were these branches some pre-release tests?).



I could compile but I still have a problem to run maven.

I did not migrate plugins at all (not sure how we must proceed yet, some 
options must be discussed)

sure, one step after the other. no need to hurry things. generally i'd be in 
favour of one branch per plugin, but might be swayed otherwise.


Ede, do you mean one repository per plugin rather than one branch?

If in the future, the plan is to create/add a plugin manager, the option 
to create a repository per plugin could facilitate their maintenance, 
especially if the OJ distribution can be used as a Maven dependency for 
these plugins.



There are probably plenty of things to improve and fix before we start again to 
add new code.

I'll try to list some more precise points to discuss in a future mail.

ok, looking forward to it. ..ede


Eric



___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel

Re: [JPP-Devel] OpenJUMP migration process

[Eric]

Hi Michael, Ed,

Sorry for this late answer, schools have been closed here this year and 
I'm just back at work.


On 06/01/2021 13:51, edgar.sol...@web.de wrote:

On 1/6/2021 14:08, Michaud Michael wrote:

Hi Eric, Ede,

I started reading the migration process from Eric (very well done !).

agreed.


Thanks.


My first problem with the svn2git process was that it stopped on '(no author)'. 
I used Eric instructions to create the authors file again and saw that it lists 
a (no author) author. I added it in the repo.

Now, there is another problem with directories containing whitespace like 1.5 
post_release. Error is :

cat-file commit refs/remotes/svn/tags/1.5 post_release: command returned error: 
128

there shouldn't be any problems left that are not mentioned in Eric's 
documentation. if there are something is probably amiss.


During my attempt to migrate this white space has been automatically 
encoded using %20, so I didn't encounter any problems at this level.
See: 
https://github.com/openjump-gis/openjump-migration/tree/1.5%2520post_release



Don't know how to solve it, but before digging further, did we dicide what must 
be migrate exactly beside history. Not sure the three branches from 2007, 2010 
and 2012 need to be migrated for example.

generally agreed. we need the trunk with tags and complete history. the old 
branches can be ignored, no one needs 'em anymore.

did Eric import those? if yes, how? if no, then just ignore them i'd say.. ede


I nearly imported everything, based on the previous discussions we had, 
including the equivalent of the SVN branches.
See imported branches here: 
https://github.com/openjump-gis/openjump-migration/branches


How I did it is already written in the documentation.

The only change I would make is to use "main" rather than "master" as 
the main branch, following the default Github setup which has evolved in 
link with the BLM movement.


By the way, happy new year to everyone! I wish you all the best.
Eric


___
Jump-pilot-devel mailing list
Jump-pilot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/jump-pilot-devel