Review Request 110042: Find Qt5 version of DBusMenuQt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/ --- Review request for kdelibs. Description --- Build fix for dbusmenu qt5 changes. This appends the 5 to include path and lib dir in the find module. Also rename the whole thing to not conflict with the Qt 4 version. Diffs - CMakeLists.txt 00402d4 cmake/modules/FindDBusMenuQt.cmake 5af70ef cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110042/diff/ Testing --- Thanks, Frederik Gladhorn
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/ --- (Updated April 16, 2013, 1:26 p.m.) Review request for kdelibs. Description --- Build fix for dbusmenu qt5 changes. This appends the 5 to include path and lib dir in the find module. Also rename the whole thing to not conflict with the Qt 4 version. Diffs - CMakeLists.txt 00402d4 cmake/modules/FindDBusMenuQt.cmake 5af70ef cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110042/diff/ Testing --- Thanks, Frederik Gladhorn
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/ --- (Updated April 16, 2013, 1:26 p.m.) Review request for kdelibs. Description --- Build fix for dbusmenu qt5 changes. This appends the 5 to include path and lib dir in the find module. Also rename the whole thing to not conflict with the Qt 4 version. Diffs - CMakeLists.txt 00402d4 cmake/modules/FindDBusMenuQt.cmake 5af70ef cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110042/diff/ Testing --- Thanks, Frederik Gladhorn
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > --- > > Review request for kdelibs. > > > Description > --- > > Build fix for dbusmenu qt5 changes. > This appends the 5 to include path and lib dir in the find module. > Also rename the whole thing to not conflict with the Qt 4 version. Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a DBusMenuQt5Config.cmake into that project itself and install that. That would allow everyone to use it with CMake once the module itself is installed, without any need for a Find*.cmake module. Eike signature.asc Description: This is a digitally signed message part.
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
On Tuesday 16. April 2013 16.30.15 Rolf Eike Beer wrote: > Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/110042/ > > --- > > > > Review request for kdelibs. > > > > > > Description > > --- > > > > Build fix for dbusmenu qt5 changes. > > This appends the 5 to include path and lib dir in the find module. > > Also rename the whole thing to not conflict with the Qt 4 version. > > Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a > DBusMenuQt5Config.cmake into that project itself and install that. That > would allow everyone to use it with CMake once the module itself is > installed, without any need for a Find*.cmake module. I agree, that would make sense. If anyone is up for doing that (the code is in launchpad) feel free to do so, I will not get around to doing that. I can abandon this patch in favor of the Config.cmake file. I mostly wanted to build kdelibs-frameworks and this patch is actually pretty small (I just renamed the .cmake file for clarity's sake). Greetings Frederik > > Eike
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/#review32794 --- Ship it! Ship It! - Ian Monroe On April 16, 2013, 1:26 p.m., Frederik Gladhorn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > --- > > (Updated April 16, 2013, 1:26 p.m.) > > > Review request for kdelibs. > > > Description > --- > > Build fix for dbusmenu qt5 changes. > This appends the 5 to include path and lib dir in the find module. > Also rename the whole thing to not conflict with the Qt 4 version. > > > Diffs > - > > CMakeLists.txt 00402d4 > cmake/modules/FindDBusMenuQt.cmake 5af70ef > cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110042/diff/ > > > Testing > --- > > > Thanks, > > Frederik Gladhorn > >
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/#review32794 --- On April 16, 2013, 1:26 p.m., Frederik Gladhorn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > --- > > (Updated April 16, 2013, 1:26 p.m.) > > > Review request for kdelibs. > > > Description > --- > > Build fix for dbusmenu qt5 changes. > This appends the 5 to include path and lib dir in the find module. > Also rename the whole thing to not conflict with the Qt 4 version. > > > Diffs > - > > CMakeLists.txt 00402d4 > cmake/modules/FindDBusMenuQt.cmake 5af70ef > cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110042/diff/ > > > Testing > --- > > > Thanks, > > Frederik Gladhorn > >
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/ --- (Updated Oct. 27, 2013, 6:46 p.m.) Status -- This change has been discarded. Review request for kdelibs. Repository: kdelibs Description --- Build fix for dbusmenu qt5 changes. This appends the 5 to include path and lib dir in the find module. Also rename the whole thing to not conflict with the Qt 4 version. Diffs - CMakeLists.txt 00402d4 cmake/modules/FindDBusMenuQt.cmake 5af70ef cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110042/diff/ Testing --- Thanks, Frederik Gladhorn
Re: Review Request 110042: Find Qt5 version of DBusMenuQt
> On May 20, 2013, 2:08 a.m., Ian Monroe wrote: > > Ship It! > > Albert Astals Cid wrote: > Janitorial dude question: Has this been commited and you forgot to mark > it as submitted or it does still need submitting? > > > Frederik Gladhorn wrote: > Thanks for asking. On the (frameworks or kcd?) mailing list it was > mentioned that a much more complicated fix would be preferred. So I never > committed this since I don't have time to do the proper fix and it sounded > like this was not wanted. Ok, i'm discarding the review request based on Frederik's comment. If this is not true, please k-f people comment. - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110042/#review32794 --- On April 16, 2013, 1:26 p.m., Frederik Gladhorn wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110042/ > --- > > (Updated April 16, 2013, 1:26 p.m.) > > > Review request for kdelibs. > > > Repository: kdelibs > > > Description > --- > > Build fix for dbusmenu qt5 changes. > This appends the 5 to include path and lib dir in the find module. > Also rename the whole thing to not conflict with the Qt 4 version. > > > Diffs > - > > CMakeLists.txt 00402d4 > cmake/modules/FindDBusMenuQt.cmake 5af70ef > cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110042/diff/ > > > Testing > --- > > > Thanks, > > Frederik Gladhorn > >
