Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112991/#review67133 --- Thanks, Gilles, for letting us know, that this is covered anew by https://git.reviewboard.kde.org/r/120287/ ! Please join our discussions on MacPorts-devel and KDE-MAC mailing lists. Greets, Marko - Marko Käning On Oct. 26, 2013, 6:57 a.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112991/ --- (Updated Oct. 26, 2013, 6:57 a.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: https://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. File Attachments patch to fix compilation rules under OSX with KDE 4.11 branch https://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/644e987a-967f-44f0-a266-428f4c9b9579__compilerulesOSX-KDE411.patch Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Oct. 26, 2013, 4:57 a.m.) Review request for kde-workspace. Changes --- New patch to fix compile rules under OSX with KDE 4.11 branch Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. File Attachments (updated) patch to fix compilation rules under OSX with KDE 4.11 branch http://git.reviewboard.kde.org/media/uploaded/files/2013/10/26/644e987a-967f-44f0-a266-428f4c9b9579__compilerulesOSX-KDE411.patch Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review42169 --- Martin, KDE 4.11 or master (Qt5) _must_ compile under OSX. My current patch work fine against master and can be applied to git repository. I currently working to adjust this patch with KDE 4.11 branch. I know that most of developers work under Linux and X11 based system. But this must not be a portability limitation, especially when people provide a patch on other platform. After all, Windows is also supported by KDE-Workspace, why not OSX. My patch simply reproduce compilation rules defined by Windows to OSX. Gilles Caulier - Gilles Caulier On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Sept. 29, 2013, 5:15 p.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41886 --- The patch doesn't apply cleanly to KDE/4.11 branch - it looks reasonable to me. If you correct that patch I can double-check it builds here. - Kurt Hindenburg On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Sept. 29, 2013, 5:15 p.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41897 --- Ok, thanks for you feedback. I make patch with git/master, not KDE/4.11 branch. I will checkout this code and adapt patch accordingly Gilles Caulier - Gilles Caulier On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Sept. 29, 2013, 5:15 p.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
On Oct. 17, 2013, 5:11 p.m., Gilles Caulier wrote: Ok, thanks for you feedback. I make patch with git/master, not KDE/4.11 branch. I will checkout this code and adapt patch accordingly Gilles Caulier I make patch with git/master, not KDE/4.11 branch You are aware that master is Qt5 based and will not result in a 4.12 release? If your aim is to fix it for the next release KDE/4.11 is the better branch, for master the situation is different anyway as our basic assumption unix == X11 is no longer valid. Also it's probably too early to put any non-linux adjustments into master - the chances that it breaks is rather high given that only Linux developers are working on it right now. - Martin --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41897 --- On Sept. 29, 2013, 7:15 p.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Sept. 29, 2013, 7:15 p.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41727 --- There is nobody to review this simple complation fix for OSX ? Let's me hear if you need info relevant. Thanks in advance. Gilles Caulier - Gilles Caulier On Sept. 29, 2013, 5:15 p.m., Gilles Caulier wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Sept. 29, 2013, 5:15 p.m.) Review request for kde-workspace. Bugs: https://trac.macports.org/ticket/33780 http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Repository: kde-workspace Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- Review request for kde-workspace. Description --- This patch fix broken compilation under OSX / macports about kde-workspace. Patch do not touch implementation. Only compilation rules are changed in cmake script to follow the way way than Windows rules, where no X11 lib are available. By this way, Oxygen is compiled and installed to macport and digiKam has a suitable GUI under OSX. See my Macports bug report for details : https://trac.macports.org/ticket/33780 Gilles Caulier This addresses bug https://trac.macports.org/ticket/33780. http://bugs.kde.org/show_bug.cgi?id=https://trac.macports.org/ticket/33780 Diffs - CMakeLists.txt c37ab8b kcontrol/CMakeLists.txt a25aaa0 libs/CMakeLists.txt 9d71a03 Diff: http://git.reviewboard.kde.org/r/112991/diff/ Testing --- I tested this patch under my macbook pro, using a fresh install of Macports (KDE 4.11.1 / Qt 4.8.5) As kde-workspace macports package is broken, i checkout code from KDE git/master repository and fixed compilation rules as well. Thanks, Gilles Caulier
