Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 12:59 p.m.) Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23daa5abd5deaab986dc65cec7b9d1031e6c Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review47049 --- briefly looking at the bug - wouldn't it be better to only cause a full parent repaint when adding/removing an (fdo) icon? - Thomas Lübking On Jan. 8, 2014, 8:59 a.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Jan. 8, 2014, 8:59 a.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23daa5abd5deaab986dc65cec7b9d1031e6c > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
> On Jan. 8, 2014, 5:06 p.m., Thomas Lübking wrote: > > briefly looking at the bug - wouldn't it be better to only cause a full > > parent repaint when adding/removing an (fdo) icon? I have tried it but without success. Adding/removing/changing visibility preference of icons is done on QML side (plasma/generic/applets/systemtray/package/contents/ui/main.qml). I tried to create a Q_INVOKABLE method in Applet class which would call repaint of m_widget's parent view and call this method from QML right after the task is added/removed/visibility preference changed. It didn't work, the bug reproduced. I also tried to call the method from QML right after the height/width of the plasmoid is adjusted, still no success. I'm out of ideas, tbh (I forgot to mention in the description that other viewport update modes rather than full one also failed to fix the issue). There's "TODO" file in plasma/generic/applets/systemtray with item "Fix sizing on desktop" which seems at least related to the discussed bug. Perhaps I should email to the creator of this file to ask whether he has any ideas how to fix it properly. - Dmitry --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review47049 --- On Jan. 8, 2014, 12:59 p.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Jan. 8, 2014, 12:59 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23daa5abd5deaab986dc65cec7b9d1031e6c > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 8:25 p.m.) Review request for kde-workspace and Plasma. Changes --- Uploaded a modified working patch which is no longer a one-line addition inside FdoGraphicsWidget::paint method but a dozen of new lines setting the full viewport update mode for parent view of FdoGraphicsWidget inside its constructor. So far it is the most proper working solution I can come up with. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs (updated) - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- this would require some testing before pushing to 4.x, too delicate to just commit - Marco Martin On Gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Gen. 8, 2014, 4:25 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
> On Июль 29, 2014, 2:31 п.п., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (coming with Linux Mint updates). Could it be counted as some testing? - Dmitry --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- On Янв. 8, 2014, 8:25 п.п., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Янв. 8, 2014, 8:25 п.п.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Jan. 8, 2014, 4:25 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
> On July 29, 2014, 10:31 a.m., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit > > Dmitry Ivanov wrote: > Well, I've been living with this patch for half a year already, since > January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to > 4.13.1 (coming with Linux Mint updates). Could it be counted as some testing? ok, let's go for it - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- On Jan. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated Jan. 8, 2014, 4:25 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
> On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: > > Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- On gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > --- > > (Updated gen. 8, 2014, 4:25 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > --- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner > setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware > FullViewportUpdate has negative performance impact but I also know it > efficiently leaves out any graphical glitches happening due to no repaint of > widget when necessary (which is what the bug is about). I have tested my > solution for a couple of days: the bug no longer reproduced and I also didn't > see any noticeable performance problems. I'm still not sure what I propose is > acceptable since it may seem like a hack to more experienced developers, > however I just didn't want my patch attempt to get lost and forgotten in the > bugzilla. Please have a look and decide whether the patch is good enough to > be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > - > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp > 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > --- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package > version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can > no longer reproduce bug 317066 and I don't see any noticeable performance > problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > >
Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated July 29, 2014, 9:03 p.m.) Status -- This change has been marked as submitted. Review request for kde-workspace and Plasma. Bugs: 317066 http://bugs.kde.org/show_bug.cgi?id=317066 Repository: kde-workspace Description --- It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. Diffs - plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d Diff: https://git.reviewboard.kde.org/r/114910/diff/ Testing --- I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. Thanks, Dmitry Ivanov