Re: Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

[laurent Montel]

Hi,
I will investigate today.

Regards
Le vendredi 1 mars 2019, 20:09:54 CET Ben Cooksley a écrit :
> Hi Laurent,
> 
> 
> Thanks for taking a look - unfortunately it looks like this is still
> failing?
> 
> 
> Cheers,
> Ben

D19461: Logcat: fix dsError color with underline="0"

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  In itemData's, using `dsError` with `underline="0"` doesn't work, the text is 
underlined. 
  Therefore, dsError is changed by dsWarning.
  
  I don't know the origin of this bug, this is a temporary solution for the 
Logcat highlighter. 
  This bug isn't noticeable in the autotests files, there are no changes when 
run `make test`.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  logcat-fix-error-color

REVISION DETAIL
  https://phabricator.kde.org/D19461

AFFECTED FILES
  data/syntax/logcat.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Re: Review Request 124398: Install Kross modules to ${KDE_INSTALL_QTPLUGINDIR}

[Alexander Potashev]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124398/
---

(Updated March 2, 2019, 5:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit aef8165848ad157c81a9aa36ab1b40a0c7ec929c by Alexander 
Potashev to branch master.


Repository: kross


Description
---

All shared libraries (including modules) are loaded by KrossCore with
the use of QLibrary and searched in paths returned by
QCoreApplication::libraryPaths(). QCoreApplication::libraryPaths()
includes /plugins, therefore KDE_INSTALL_QTPLUGINDIR is
the right place to install Kross modules.


Diffs
-

  src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 


Diff: https://git.reviewboard.kde.org/r/124398/diff/1/


Testing
---


Thanks,

Alexander Potashev

[reposted from kde-devel] Building KDE statically

[Jonathan Schultz]

Hello KDE developers,

If anyone is interested, here is a brief report on something I have been 
working on in my spare time.

TLDR: Here are some scripts to build KDE frameworks and okular statically using 
gcc/musl and cross-building for mingw: https://github.com/jschultz/kde-static 
Look in the file patch-kde.sh to see the interesting stuff.

I've been working on an application based largely on okular that I would like 
to be able to deploy as simply as possible for users with no technical 
expertise. For this purpose, and despite its well-known down-sides I thought 
that a static build would be helpful.

So I started building KDE frameworks and other okular dependencies using 
kdesrc-build and working out what would need to change to make a static build. 
It turned out to be more painstaking but less complicated than I had imagined.

It all happens inside Docker containers built on voidlinux, which I chose 
because it handles musl natively and has a build process simple enough for me 
to understand. No doubt there are good reasons to use a different Linux distro 
but so be it.

Most of the patches are simply to make CMake handle static dependencies. A few 
deal with ad hoc issues that arose out of static building. The most complicated 
was linking okular's plugins statically, which involved a bit of build hacking, 
but nothing too dreadful (IMHO).

I've made all the patches backwards-compatible, ie they have no effect on a 
conventional build using shared libraries.

I took some shortcuts in working out which static libraries to include, ie 
basically all libraries are included on all link operations, and we count on 
the linker to leave out those that aren't required.

I also put in some cross-building stuff. Since kdesrc-build seems not to do a 
good job with host applications required for the building process, I just 
pre-built those and put the executables in the repository. Not all of 
frameworks cross-builds, but enough to link okular does.

What it produces:

An static okular executable with the following generator plugins: poppler, 
kimgio, dvi, tiff, xps, ooo, fb, comicbook, fax, plucker, txt is about 88MB in 
size. I understand that this might be reduced, possibly by as much as 80%, by 
using Link-Time Optimisation (LTO). Even as it is, it starts and runs 
noticeably faster than a conventional build. Cross-building, a mingw32 
okular.exe is around 58MB and a mingw64 73MB.

Still some problems: it can't save files because (if I understand correctly) 
kio uses slave processes that are also based on plugins which would need to be 
linked statically.

What's next: Cross-building for MacOS. Using craft instead of kdesrc-build.

So feel free to hit me up with suggestions, interest or if anyone is interested 
in incorporating any of this into the mainline of KDE development.

Cheers,
Jonathan

Re: Building KDE statically

[Jonathan Schultz]

Thanks I will take your suggestion and post this to frameworks-devel. I'll also 
put a quick note on okular-devel since okular is my target application for 
doing all this.

Cheers,
Jonathan

On 26/2/19 6:57 am, Albert Astals Cid wrote:

El divendres, 22 de febrer de 2019, a les 4:57:42 CET, Jonathan Schultz va 
escriure:

Hello KDE developers,

If anyone is interested, here is a brief report on something I have been 
working on in my spare time.


Since at least part of this involves frameworks, you may want to send this to 
the frameworks devel mailing list. Maybe you get some more answers/traction 
there.

Cheers,
   Albert



TLDR: Here are some scripts to build KDE frameworks and okular statically using 
gcc/musl and cross-building for mingw: https://github.com/jschultz/kde-static 
Look in the file patch-kde.sh to see the interesting stuff.

I've been working on an application based largely on okular that I would like 
to be able to deploy as simply as possible for users with no technical 
expertise. For this purpose, and despite its well-known down-sides I thought 
that a static build would be helpful.

So I started building KDE frameworks and other okular dependencies using 
kdesrc-build and working out what would need to change to make a static build. 
It turned out to be more painstaking but less complicated than I had imagined.

It all happens inside Docker containers built on voidlinux, which I chose 
because it handles musl natively and has a build process simple enough for me 
to understand. No doubt there are good reasons to use a different Linux distro 
but so be it.

Most of the patches are simply to make CMake handle static dependencies. A few 
deal with ad hoc issues that arose out of static building. The most complicated 
was linking okular's plugins statically, which involved a bit of build hacking, 
but nothing too dreadful (IMHO).

I've made all the patches backwards-compatible, ie they have no effect on a 
conventional build using shared libraries.

I took some shortcuts in working out which static libraries to include, ie 
basically all libraries are included on all link operations, and we count on 
the linker to leave out those that aren't required.

I also put in some cross-building stuff. Since kdesrc-build seems not to do a 
good job with host applications required for the building process, I just 
pre-built those and put the executables in the repository. Not all of 
frameworks cross-builds, but enough to link okular does.

What it produces:

An static okular executable with the following generator plugins: poppler, 
kimgio, dvi, tiff, xps, ooo, fb, comicbook, fax, plucker, txt is about 88MB in 
size. I understand that this might be reduced, possibly by as much as 80%, by 
using Link-Time Optimisation (LTO). Even as it is, it starts and runs 
noticeably faster than a conventional build. Cross-building, a mingw32 
okular.exe is around 58MB and a mingw64 73MB.

Still some problems: it can't save files because (if I understand correctly) 
kio uses slave processes that are also based on plugins which would need to be 
linked statically.

What's next: Cross-building for MacOS. Using craft instead of kdesrc-build.

So feel free to hit me up with suggestions, interest or if anyone is interested 
in incorporating any of this into the mainline of KDE development.

Cheers,
Jonathan

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Ben Cooksley]

bcooksley added a comment.


  Given that Baloo Widgets isn't the only project showing that class of 
failure, it's more likely to be a case of ECM getting something wrong.
  (The CI system doesn't do anything special when it comes to this part of the 
execution)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: bcooksley, #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.12/10/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 01 Mar 2019 21:38:48 +
 Build duration:
4 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

D19453: Fix repository deletion warning

[Dominik Haumann]

dhaumann accepted this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19453

To: vkrause, cullmann, dhaumann
Cc: kossebau, cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19455: [knotification] compile without deprecated methods

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without deprecated method

TEST PLAN
  autotest ok

REPOSITORY
  R289 KNotifications

BRANCH
  compile_without_deprecated_method (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19455

AFFECTED FILES
  CMakeLists.txt
  src/imageconverter.cpp
  src/kpassivepopup.cpp
  src/kstatusnotifieritem.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19453: Fix repository deletion warning

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I can confirm this results in the warnings about `Repository got deleted 
while a highlighter is still active!` no longer being shown when using D19432 
.
  
  Also no issues seen in Kate.
  
  But not enough understanding of this code to comment whether this is a good 
fix.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19453

To: vkrause, cullmann
Cc: kossebau, cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, 
ngraham, bruns, demsking, sars, dhaumann

D19453: Fix repository deletion warning

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Good catch :)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19453

To: vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D19453: Fix repository deletion warning

[Volker Krause]

vkrause created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Since 6166da75 
 the 
invalid/default Definition has a name ("None"), so
  this check also triggers on that one, all the time. Instead check the
  definition file name, that doesn't exist for an invalid Definition.
  
  See also D19432 , which triggered this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19453

AFFECTED FILES
  src/lib/abstracthighlighter.cpp

To: vkrause
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Stefan Brüns]

bruns added a comment.


  In D19268#422709 , @bcooksley 
wrote:
  
  > Sorry, I don't see where it's complaining about not finding the right 
binary?
  >  (Not finding Dr Konqi is expected, given that it's part of Plasma and not 
a dependency of baloo-widgets)
  
  
  Its complaining about not being able to execute the **right** binary, 
exception code 0xc315.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: bcooksley, #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

T10547: Make helpers in LIBEXEC testable, make LIBEXEC runtime settable

[Stefan Brüns]

bruns created this task.

TASK DESCRIPTION
  While pathes to executables (PATH) and plugins (QT_PLUGIN_PATHS) can be 
adjusted, LIBEXEC is hardcoded, see e.g.:
  
  https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs
  
  > KStandardDirs::findExe (and the use of the "exe" resource) can be ported to 
QStandardPaths::findExecutable, except when the executable comes from libexec, 
in which case the path should just be hardcoded using CMAKE_INSTALL_PREFIX "/" 
LIBEXEC_INSTALL_DIR.
  
  This makes it impossible to test any private helpers without installing them. 
Worse, this may give false positives are hide errors when running tests from 
inside the build directory.

TASK DETAIL
  https://phabricator.kde.org/T10547

To: bruns
Cc: #frameworks, bruns

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Ben Cooksley]

bcooksley added a comment.


  Sorry, I don't see where it's complaining about not finding the right binary?
  (Not finding Dr Konqi is expected, given that it's part of Plasma and not a 
dependency of baloo-widgets)

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: bcooksley, #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Stefan Brüns]

bruns added a comment.


  Actually, it is quite happy to report it can not execute the binary in 
build/bin/, which is IMHO an error in the CI setup.
  
  I don't have windows, so someone else has to look into this.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Stefan Brüns]

bruns added a subscriber: Windows.

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: #windows, domson, ashaposhnikov, astippich, spoorun, abrahams

D18601: Rewrite taglib writer to use property interface

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in taglibwriter.cpp:70
> Not sure I understand. I would like to avoid doing `file->properties();` and 
> `file->setProperties();` twice for those formats for which only the 
> PropertyMap is sufficient, e.g. Ape and Ogg, to avoid doing any unnecessary 
> work.  The beauty of Ape and Ogg in the TagLib implementation is that they 
> solely work with the PropertyMap and do not require any special handling. See 
> D18826 , Ape and Ogg do not have any 
> extra codepath at all. For writing tags, we have to be a little bit more 
> careful, though. If writing Rating information is added to 
> writeGenericProperties, for example Id3v2's "TXXX" tags will be polluted with 
> these values.

I think for **reading** it as generic as possible is fine, but for writing 
being a little bit more explicit does not hurt.

My proposal for Ape and Ogg is to split the writing for these to two different 
functions. Yes, it **is** possible to use the propertymap for both, as both use 
the same scale and the same tag name, but the implementations on the taglib 
side are completely different.

Writing the "rating" for XiphComment (Ogg) and  Ape in distinct functions (see 
my comment in D18604 ) hardly adds any 
code, but gets the Ape and Ogg code paths in line with the other file formats. 
You don't write the ASF/MP4 rating using the property interface although it 
would be possible, and IMHO thats the right thing to do,  also for Ape and Ogg.

As soon Ape and Ogg are split, you no longer rely on the PropertyMap for the 
rating, and you won't have to use `properties()`/`setProperties()` twice.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

[ANNOUNCE] CMake 3.14.0-rc3 is ready for testing

[Robert Maynard]

I am proud to announce the third CMake 3.14 release candidate.
  https://cmake.org/download/

The first two 3.14.0 release candidates included the FindOcatave
module. This has been removed in rc3 pending further development.

Documentation is available at:
  https://cmake.org/cmake/help/v3.14

Release notes appear below and are also published at
  https://cmake.org/cmake/help/v3.14/release/3.14.html

Some of the more significant changes in CMake 3.14 are:

* Support for running CMake on Windows XP and Windows Vista has been
  dropped. The precompiled Windows binaries provided on "cmake.org"
  now require Windows 7 or higher.

* CMake now supports Cross Compiling for iOS, tvOS, or watchOS using
  simple toolchain files.

* The "Visual Studio 16 2019" generator was added.  This is
  experimental and based on "Visual Studio 2019 Preview 4" because
  this version of VS has not been released.

  The VS 2019 generator differs from generators for earlier versions
  in that it does not provide variants that specify the target
  platform in the generator name.  Instead "CMAKE_GENERATOR_PLATFORM"
  must be used, e.g. through the "-A" command-line option.
  Furthermore, the default target platform (architecture) is now based
  on the *host* platform.  The VS host toolset selection is now based
  on the host architecture as well.

* The "Green Hills MULTI" generator has been updated to include Object
  Library support, support for target renaming and destination output
  control properties, and other improvements.

* A "CMAKE_BUILD_RPATH_USE_ORIGIN" variable and corresponding
  "BUILD_RPATH_USE_ORIGIN" target property were added to enable use of
  relative runtime paths (RPATHs). This helps achieving relocatable
  and reproducible builds that are invariant of the build directory.

* The "install(TARGETS)" command learned how to install to an
  appropriate default directory for a given target type, based on
  variables from the "GNUInstallDirs" module and built-in defaults, in
  lieu of a "DESTINATION" argument.

* The "install(FILES)" and "install(DIRECTORY)" commands learned a
  new set of parameters for installing files as a file type, setting
  the destination based on the appropriate variables from
  "GNUInstallDirs" and built-in defaults, in lieu of a "DESTINATION"
  argument.

* The "install(CODE)" and "install(SCRIPT)" commands learned to
  support generator expressions.  See policy "CMP0087".

* The "if()" command gained support for checking if cache variables
  are defined with the  "DEFINED CACHE{VAR}" syntax.

* A file-based api for clients to get semantic buildsystem
  information has been added.  See the "cmake-file-api(7)" manual.
  This is intended to replace the "cmake-server(7)" mode for IDEs.

* The "cmake(1)" Build Tool Mode ("cmake --build") gained "--
  verbose" and "-v" options to specify verbose build output. Some
  generators such as Xcode don't support this option currently.

* The "cmake(1)" "-E compare_files" command learned a new "--ignore-
  eol" option to specify that end-of-line differences (e.g. LF vs
  CRLF) should be ignored when comparing files.


CMake 3.14 Release Notes


Changes made since CMake 3.13 include the following.


New Features



Generators
--

* The "Visual Studio 16 2019" generator was added.  This is
  experimental and based on "Visual Studio 2019 Preview 4" because
  this version of VS has not been released.

  The VS 2019 generator differs from generators for earlier versions
  in that it does not provide variants that specify the target
  platform in the generator name.  Instead "CMAKE_GENERATOR_PLATFORM"
  must be used, e.g. through the "-A" command-line option.
  Furthermore, the default target platform (architecture) is now based
  on the *host* platform.  The VS host toolset selection is now based
  on the host architecture as well.

* The "Green Hills MULTI" generator has been updated:

  * Now supports Object Libraries.

  * Now warns on unsupported project types such as shared libraries.

  * Now generates a top-level ".top.gpj" for each
directory calling the "project()" command.  The top-level project
file "default.gpj" is no longer created.

  * Now honors target renaming and destination output control
properties such as "RUNTIME_OUTPUT_DIRECTORY" and "OUTPUT_NAME".
This also fixes support for installation rules generated by
"install()".

  * Now honors source file properties "INCLUDE_DIRECTORIES",
"COMPILE_DEFINITIONS", and "COMPILE_OPTIONS".

  * Now supports Dynamic Download Integrity Applications which did
not include Integrate Files via "GHS_INTEGRITY_APP" and setting a
target link flag of "-dynamic".

  * The contents of project files now sorts sources groups and files
by name. Set the "GHS_NO_SOURCE_GROUP_FILE" target property to
"ON" to generate a single project file for the target instead of a
project file for each source group.  Set the

D19407: ModeBase::goToPos: Ensure jump target is valid

[loh tar]

loh.tar added a comment.


  Ah, `r.toEditorRange().isValid()` is the trick, yes, would work.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19407

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19407: ModeBase::goToPos: Ensure jump target is valid

[loh tar]

loh.tar edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19407

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19407: ModeBase::goToPos: Ensure jump target is valid

[loh tar]

loh.tar added a comment.


  > Hm, who is passing an invalid range here?
  
  Does it matter? Can't remember. Want to see the bt?
  
  > Would it be the same to check r.isValid()?
  
  No. No such function :p It's a vimode range (?)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19407

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

Fwd: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build # 40 - Still Failing!

[Ben Cooksley]

Hi Laurent,

Thanks for taking a look - unfortunately it looks like this is still
failing?

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Fri, Mar 1, 2019 at 11:05 AM
Subject: KDE CI: Frameworks » kxmlgui » kf5-qt5 WindowsMSVCQt5.11 - Build #
40 - Still Failing!
To: , 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Frameworks/job/kxmlgui/job/kf5-qt5%20WindowsMSVCQt5.11/40/
Project: kf5-qt5 WindowsMSVCQt5.11
Date of build: Thu, 28 Feb 2019 22:00:58 +
Build duration: 4 min 30 sec and counting
* CONSOLE OUTPUT *
[...truncated 340 lines...]
[2019-02-28T22:05:15.668Z] * KF5WindowSystem (required version >= 5.55.0)
[2019-02-28T22:05:15.668Z] * KF5GlobalAccel (required version >= 5.55.0)
[2019-02-28T22:05:15.668Z] * Doxygen (required version >= 1.8.13)
[2019-02-28T22:05:15.668Z] Needed for API dox QCH file generation
[2019-02-28T22:05:15.668Z] * QHelpGenerator, Part of Qt5 tools
[2019-02-28T22:05:15.668Z] Needed for API dox QCH file generation
[2019-02-28T22:05:15.668Z] * Qt5Xml
[2019-02-28T22:05:15.668Z] * Qt5Test
[2019-02-28T22:05:15.668Z] * Qt5 (required version >= 5.10.0)
[2019-02-28T22:05:15.668Z]
[2019-02-28T22:05:15.668Z] -- Configuring done
[2019-02-28T22:05:17.576Z] -- Generating done
[2019-02-28T22:05:17.576Z] -- Build files have been written to:
C:/CI/workspace/Frameworks/kxmlgui/kf5-qt5 WindowsMSVCQt5.11/build
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Compiling)
[Pipeline] bat
[2019-02-28T22:05:18.675Z]
[2019-02-28T22:05:18.675Z] C:\CI\workspace\Frameworks\kxmlgui\kf5-qt5
WindowsMSVCQt5.11>call "C:/Program Files (x86)/Microsoft Visual
Studio/2017/Professional/VC/Auxiliary/Build/vcvars64.bat"
[2019-02-28T22:05:18.675Z]
**
[2019-02-28T22:05:18.675Z] ** Visual Studio 2017 Developer Command Prompt
v15.7.3
[2019-02-28T22:05:18.675Z] ** Copyright (c) 2017 Microsoft Corporation
[2019-02-28T22:05:18.675Z]
**
[2019-02-28T22:05:20.588Z] [vcvarsall.bat] Environment initialized for:
'x64'
[2019-02-28T22:05:22.592Z]
[2019-02-28T22:05:22.592Z] jom 1.1.2 - empower your cores
[2019-02-28T22:05:22.592Z]
[2019-02-28T22:05:22.592Z] jom: parallel job execution disabled for Makefile
[2019-02-28T22:05:22.592Z] Scanning dependencies of target KF5XmlGui_autogen
[2019-02-28T22:05:22.592Z] Scanning dependencies of target
ksendbugmail_autogen
[2019-02-28T22:05:22.592Z] Scanning dependencies of target KF5XmlGui_QCH
[2019-02-28T22:05:22.592Z] [ 2%] Automatic MOC for target KF5XmlGui
[2019-02-28T22:05:22.869Z] [ 1%] Automatic MOC for target ksendbugmail
[2019-02-28T22:05:22.869Z] [ 3%] Built target ksendbugmail_autogen
[2019-02-28T22:05:24.262Z] Scanning dependencies of target ksendbugmail
[2019-02-28T22:05:24.842Z] [ 6%] Built target KF5XmlGui_autogen
[2019-02-28T22:05:24.842Z] [ 3%] Generating src/KF5XmlGui.qch,
src/KF5XmlGui.tags
[2019-02-28T22:05:24.842Z] [ 5%] Building CXX object
src/ksendbugmail/CMakeFiles/ksendbugmail.dir/main.cpp.obj
[2019-02-28T22:05:24.842Z] [ 5%] Building CXX object
src/ksendbugmail/CMakeFiles/ksendbugmail.dir/smtp.cpp.obj
[2019-02-28T22:05:24.842Z] main.cpp
[2019-02-28T22:05:24.842Z] [ 6%] Building CXX object
src/ksendbugmail/CMakeFiles/ksendbugmail.dir/ksendbugmail_autogen/mocs_compilation.cpp.obj
[2019-02-28T22:05:25.803Z] [ 8%] Built target KF5XmlGui_QCH
[2019-02-28T22:05:25.803Z] [ 7%] Generating qrc_kxmlgui.cpp
[2019-02-28T22:05:25.803Z] [ 8%] Generating ui_kshortcutsdialog.h
[2019-02-28T22:05:25.803Z] [ 8%] Generating ui_kshortcutwidget.h
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(66): error
C2450: switch expression of type 'QOperatingSystemVersion' is illegal
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(66): note: No
user-defined-conversion operator available that can perform this
conversion, or the operator cannot be called
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): error
C2131: expression did not evaluate to a constant
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note:
failure was caused by non-constant arguments or reference to a non-constant
symbol
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(67): note: see
usage of 'Windows7'
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): error
C2131: expression did not evaluate to a constant
[2019-02-28T22:05:26.063Z] c:\ci\workspace\frameworks\kxmlgui\kf5-qt5
windowsmsvcqt5.11\src\ksendbugmail\../systeminformation_p.h(68): note:
failure was 

D19407: ModeBase::goToPos: Ensure jump target is valid

[Dominik Haumann]

dhaumann added a comment.


  It's FIXED-IN: 5.56...
  
  Hm, who is passing an invalid range here? Would it be the same to check 
r.isValid()?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19407

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars

D19438: Add syntax definition for Elm language to syntax-highlighting

[Dominik Haumann]

dhaumann added a comment.


  Could you elaborate what Elm is used for?
  Also, could you please provide a small test file (also MIT licensed) that we 
can use for unit testing?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D19438

To: bonghyunkim
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars

D19442: [Kfilemetada] Make it compile without foreach

[Stefan Brüns]

bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.


  This clashes with D19287 , and has to be 
rebased/merged then

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol, bruns
Cc: bruns, astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, 
michaelh, spoorun, ngraham, abrahams

D7732: Force KAuth helpers to have UTF-8 support

[Albert Astals Cid]

aacid added a comment.


  I'm not sure changing the codec for all kauth stuff is the best, but if we're 
going to do that i think we should add it to the documentation, something like 
"Forces UTF-8 text codec" or something

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D7732

To: davidedmundson
Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D19450: DocumentPrivate: Respect indention mode when block selection

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  Without this patch was in block selection mode always a tab inserted, also 
when 
  configured to use spaces on tab-key press
  
  BUG:395430
  Fixed in: 5.57

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19450

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D7732: Force KAuth helpers to have UTF-8 support

[David Edmundson]

davidedmundson updated this revision to Diff 52913.
davidedmundson added a comment.


  pedantic change

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7732?vs=52912=52913

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7732

AFFECTED FILES
  src/kauthhelpersupport.cpp

To: davidedmundson
Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D7732: Force KAuth helpers to have UTF-8 support

[David Edmundson]

davidedmundson edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D7732

To: davidedmundson
Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns

D7732: Force KAuth helpers to have UTF-8 support

[David Edmundson]

davidedmundson updated this revision to Diff 52912.
davidedmundson added a comment.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.


  Rewrote using QTextCodec

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7732?vs=19307=52912

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7732

AFFECTED FILES
  src/kauthhelpersupport.cpp

To: davidedmundson
Cc: kde-frameworks-devel, aacid, ltoscano, michaelh, ngraham, bruns, #frameworks

D19446: DocumentPrivate: Support auto bracket in block selection mode

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  ..how it should be by adding brackets to each line of the block
  
  - Encapsulate in editBegin/End
  - Reduce if/else nesting
  
  BUG:382213
  Fixed in: 5.57

TEST PLAN
  Oops?! I'm sorry the diff looks terrible. In the past were leading space 
changes ignored, so I had done these "Reduce if/else nesting" :-/
  
  - Feature or bug? Select in block mode from right->left on a single line 
after last char a block. The brackets are exchanged )( and placed at the end of 
the block
  - Code use MovingRange, old(?) similar code fumble around with backup 
cursors, I hope not for some optimizing but only because its older than 
MovingRange
  - No use of toVirtualColumn or similar. It looks so far good anyway. Only 
when you mix tabs and spaces the result may sometimes odd. But I think there is 
no solution in using toVirtualColumn in the cases I had played around
  - No call of view->slotTextInserted (will only emit signal) can't see any 
effect and isn't such signal not already emit by the doc itself?
  - Autotests looks OK, I may add some for the new feature when patch gets 
accepted so far

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19446

AFFECTED FILES
  src/document/katedocument.cpp

To: loh.tar, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D19445: Handle variant list in formatting functions

[Alexander Stippich]

astippich created this revision.
astippich added reviewers: ngraham, bruns.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.

REVISION SUMMARY
  Improve the formatting function of
  KFileMetaData such that it will also handle
  QVariantLists for each property, to make it more 
  robust

TEST PLAN
  tests pass

REPOSITORY
  R286 KFileMetaData

BRANCH
  generic_display_list

REVISION DETAIL
  https://phabricator.kde.org/D19445

AFFECTED FILES
  autotests/propertyinfotest.cpp
  src/propertyinfo.cpp

To: astippich, ngraham, bruns
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/31/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Mar 2019 16:03:31 +
 Build duration:
7 min 48 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3438/4117)47%
(5043/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(989/1017)48%
(2170/4475)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 01 Mar 2019 16:03:31 +
 Build duration:
2 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3438/4117)47%
(5043/10659)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(989/1017)48%
(2170/4475)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 25 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/25/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 01 Mar 2019 14:30:51 +
 Build duration:
5 min 50 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3437/4116)47%
(5041/10655)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(988/1016)48%
(2168/4471)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 30 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/30/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 01 Mar 2019 14:30:51 +
 Build duration:
2 min 13 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5FileMetaData-5.56.0.xmlcompat_reports/KF5FileMetaData_compat_report.htmllogs/KF5FileMetaData/5.56.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 17 test(s)Failed: projectroot.autotests.taglibextractortest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)88%
(50/57)88%
(50/57)84%
(3437/4116)47%
(5041/10655)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(17/17)100%
(17/17)97%
(988/1016)48%
(2168/4471)src76%
(19/25)76%
(19/25)80%
(1164/1452)43%
(486/1120)src.extractors100%
(13/13)100%
(13/13)79%
(1227/1563)47%
(2316/4903)src.writers100%
(1/1)100%
(1/1)98%
(58/59)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/26)0%
(0/12)

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 52901.
kossebau added a comment.


  Changes:
  
  - clip when drawing the text document, so our "page" margins stay clean
  - for that reuse vars some more
  
  Somehow the old custom margins look nicer to me, so I kept the logic in the
  code.
  Seems QTextDocument draws the text with a bit more line-spacing, but not
  sure if additional code to influence that is worth it.

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19432?vs=52899=52901

BRANCH
  addsyntaxhighlighttotextpreview

REVISION DETAIL
  https://phabricator.kde.org/D19432

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/textcreator.cpp
  thumbnail/textcreator.h

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann added a comment.


  We can not arbitrary scale the height, that must match what Qt does, else you 
get maximal ugly empty trash in-between the lines, e.g. if you partially select 
stuff or have different backgrounds for some glyphs.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   Just load the XML file from bug 404713.
  >   Before this changes here, you did overpaint the next line randomly with 
the "oversized one", now you "cut" the oversized line.
  
  I don't know where to look specifically in that huge file. I do notice that 
with the partially reverted commit some lines are very close to one another, 
possibly even certain glyphs being superimposed, and on certain of those lines 
the cursor gets decorated by what looks to be a '>'.
  
  What I do NOT see is lines being painted over by whitespace, which is worse 
in terms of readability.
  
  > Bug 328837 - Add configurable line height to katepart
  
  Apparently,
  
  > There's a problem, though: selection gets inconsistent.
  
  I haven't checked if that's the case (nor if the patch still applies).
  
  The idea is good though, and I'm a bit surpised that there could be problems 
with it given that KTE already determines the lineheight to use (and changing 
the way that's hardcoded doesn't lead to selection problems).
  
  You could even make that lineheight scale factor a per-document setting (I 
could easily imagine someone wanting lines to be more separated in code than in 
prose, for instance).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[loh tar]

loh.tar added a comment.


  Sorry when I'm wrong, but it sounds to me that this bug is somehow relatated 
or maybe a solution, there is patch offered.
  Bug 328837 - Add configurable line height to katepart

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added a comment.


  New after:
  F6646824: Screenshot_20190301_144746.png 

  
  Hm, meh, now I see that `textDocument.drawContents();` does not stay 
within the page size the document was given... let's see whether I can do some 
clipping

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 52899.
kossebau added a comment.


  use original different x & y margins, to gain more chars rendered, as before

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19432?vs=52865=52899

BRANCH
  addsyntaxhighlighttotextpreview

REVISION DETAIL
  https://phabricator.kde.org/D19432

AFFECTED FILES
  CMakeLists.txt
  thumbnail/CMakeLists.txt
  thumbnail/textcreator.cpp
  thumbnail/textcreator.h

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> vkrause wrote in textcreator.cpp:169
> I think default background color here refers to what your palette gives you. 
> The background color defined by highlighting is typically only used for small 
> text blocks like for alerts ("TODO", "HACK", etc).

@vkrause  Thanks for the comment. With that in mind and coffee in blood and in 
daylight I get the SH api dox a bit better. I might think about doing a 
proposal for improvement for the next person hitting that without coffee 
perhaps ;)

@cfeck From what I have seen, I would then stay with the hardcoded background 
color. Actually I wonder why it it not pure #fff as one has(?) with any rich 
textdocument usually. But not the intention of this very patch, so I leave that 
out.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19432

To: kossebau, broulik
Cc: vkrause, cfeck, kde-frameworks-devel, kfm-devel, alexde, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » solid » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20WindowsMSVCQt5.11/47/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Fri, 01 Mar 2019 13:00:55 +
 Build duration:
7 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 493 lines...][2019-03-01T13:08:10.668Z] device.cpp[2019-03-01T13:08:10.668Z] [ 28%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/deviceinterface.cpp.obj[2019-03-01T13:08:10.668Z] deviceinterface.cpp[2019-03-01T13:08:10.668Z] [ 28%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/devicemanager.cpp.obj[2019-03-01T13:08:10.668Z] devicemanager.cpp[2019-03-01T13:08:10.668Z] [ 30%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/genericinterface.cpp.obj[2019-03-01T13:08:10.668Z] genericinterface.cpp[2019-03-01T13:08:10.668Z] [ 32%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/networkshare.cpp.obj[2019-03-01T13:08:10.668Z] networkshare.cpp[2019-03-01T13:08:10.668Z] [ 32%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/opticaldisc.cpp.obj[2019-03-01T13:08:10.668Z] opticaldisc.cpp[2019-03-01T13:08:10.668Z] [ 34%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/portablemediaplayer.cpp.obj[2019-03-01T13:08:10.668Z] portablemediaplayer.cpp[2019-03-01T13:08:10.668Z] [ 35%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/processor.cpp.obj[2019-03-01T13:08:10.668Z] [ 36%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/storagedrive.cpp.obj[2019-03-01T13:08:10.668Z] processor.cpp[2019-03-01T13:08:10.668Z] storagedrive.cpp[2019-03-01T13:08:10.668Z] [ 38%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/storagevolume.cpp.obj[2019-03-01T13:08:10.668Z] storagevolume.cpp[2019-03-01T13:08:10.668Z] [ 38%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/ifaces/storageaccess.cpp.obj[2019-03-01T13:08:10.668Z] storageaccess.cpp[2019-03-01T13:08:10.668Z] [ 39%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/shared/rootdevice.cpp.obj[2019-03-01T13:08:10.668Z] rootdevice.cpp[2019-03-01T13:08:10.668Z] [ 41%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/shared/cpufeatures.cpp.obj[2019-03-01T13:08:10.668Z] cpufeatures.cpp[2019-03-01T13:08:10.668Z] [ 41%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakebattery.cpp.obj[2019-03-01T13:08:10.668Z] [ 43%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakeblock.cpp.obj[2019-03-01T13:08:10.668Z] fakeblock.cpp[2019-03-01T13:08:10.668Z] fakebattery.cpp[2019-03-01T13:08:10.668Z] [ 43%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakecamera.cpp.obj[2019-03-01T13:08:10.668Z] fakecamera.cpp[2019-03-01T13:08:10.668Z] [ 45%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakecdrom.cpp.obj[2019-03-01T13:08:10.668Z] fakecdrom.cpp[2019-03-01T13:08:10.668Z] [ 46%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakedevice.cpp.obj[2019-03-01T13:08:10.668Z] fakedevice.cpp[2019-03-01T13:08:10.668Z] [ 47%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakedeviceinterface.cpp.obj[2019-03-01T13:08:10.668Z] [ 49%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakegenericinterface.cpp.obj[2019-03-01T13:08:10.668Z] fakegenericinterface.cpp[2019-03-01T13:08:10.668Z] fakedeviceinterface.cpp[2019-03-01T13:08:10.668Z] [ 49%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakemanager.cpp.obj[2019-03-01T13:08:10.668Z] fakemanager.cpp[2019-03-01T13:08:10.668Z] [ 51%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakenetworkshare.cpp.obj[2019-03-01T13:08:10.668Z] fakenetworkshare.cpp[2019-03-01T13:08:10.668Z] [ 53%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakeopticaldisc.cpp.obj[2019-03-01T13:08:10.668Z] fakeopticaldisc.cpp[2019-03-01T13:08:10.668Z] [ 53%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakeportablemediaplayer.cpp.obj[2019-03-01T13:08:10.668Z] fakeportablemediaplayer.cpp[2019-03-01T13:08:10.668Z] [ 55%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakeprocessor.cpp.obj[2019-03-01T13:08:10.668Z] fakeprocessor.cpp[2019-03-01T13:08:10.668Z] [ 55%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakestorage.cpp.obj[2019-03-01T13:08:10.668Z] fakestorage.cpp[2019-03-01T13:08:10.669Z] [ 57%] Building CXX object src/solid/CMakeFiles/KF5Solid.dir/devices/backends/fakehw/fakestorageaccess.cpp.obj[2019-03-01T13:08:10.669Z] fakestorageaccess.cpp[2019-03-01T13:08:10.669Z] [ 59%] Building CXX object 

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.12 - Build # 12 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.12/12/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Fri, 01 Mar 2019 13:00:55 +
 Build duration:
4 min 4 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

D19332: KProcess compile fix for obsolete QProcess members in 5.13

[Jonathan Marten]

marten updated this revision to Diff 52898.
marten added a comment.


  Use the same condition as the Qt header uses

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19332?vs=52601=52898

REVISION DETAIL
  https://phabricator.kde.org/D19332

AFFECTED FILES
  src/lib/io/kprocess.h

To: marten, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann added a comment.


  Just load the XML file from bug 404713.
  Before this changes here, you did overpaint the next line randomly with the 
"oversized one", now you "cut" the oversized line.
  In both cases, one line is garbage.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19442: [Kfilemetada] Make it compile without foreach

[Alexander Stippich]

astippich added a comment.


  There are currently larger refactorings ongoing (D19287 
, D18826 
), could you please wait for them and 
rebase afterwards?

INLINE COMMENTS

> externalextractor.cpp:151
> +const auto lstKeys = propertiesObject.keys();
> +for(const auto  : lstKeys) {
>  if (key == QStringLiteral("typeInfo")) {

missing space: for (

> extractorplugin.cpp:140
>  list.reserve(contactStrings.count());
> -foreach(const QString& contactName, contactStrings) {
> +for(const QString& contactName : qAsConst(contactStrings)) {
>  list << contactName.trimmed();

missing space: for (

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol
Cc: astippich, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, 
spoorun, ngraham, bruns, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19442: [Kfilemetada] Make it compile without foreach

[Laurent Montel]

mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  compile without foreach

TEST PLAN
  Autotest ok

REPOSITORY
  R286 KFileMetaData

BRANCH
  compile_without_foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19442

AFFECTED FILES
  CMakeLists.txt
  src/externalextractor.cpp
  src/externalwriter.cpp
  src/extractorcollection.cpp
  src/extractorplugin.cpp
  src/extractors/office2007extractor.cpp
  src/extractors/taglibextractor.cpp
  src/writercollection.cpp
  tests/dump.cpp

To: mlaurent, dfaure
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R298:0217d5038550: Make it compile with QT_NO_CAST_FROM_ASCII 
(authored by mlaurent).

REPOSITORY
  R298 KDesignerPlugin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19430?vs=52860=52896

REVISION DETAIL
  https://phabricator.kde.org/D19430

AFFECTED FILES
  CMakeLists.txt
  src/kde.widgets
  src/kgendesignerplugin.cpp

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17302: Add test for adding properties to result

[Alexander Stippich]

astippich updated this revision to Diff 52894.
astippich added a comment.


  - mark expected fail

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17302?vs=48688=52894

BRANCH
  test_result

REVISION DETAIL
  https://phabricator.kde.org/D17302

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/resulttest.cpp
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  So it seems that the partial revert works; you lost me re: what would break 
again by doing that?
  
  F6646645: Screen Shot 2019-03-01 at 13.07.52.png 

  (background: full revert; foreground partial revert (only 
kateviewinternal.cpp))

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Thomas Schöps]

thomassc added a comment.


  > If you keep the overpainting, you will just overpaint the next line 
partially with it, that won't help that much, IMHO.
  > 
  > Take a look at bug 404713.
  
  I totally agree, but this is a different issue that is out of scope here as 
far as I see. Bugs 403868 and 403470 can and should be fixed by the proposed 
line height change. This will not fix the other bugs 404713 and 404907 though, 
which are a different issue and unaffected by this. Thus I think that the 
overpainting workaround should be kept until a better solution is found for the 
latter bugs.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[René J . V . Bertin]

rjvbb added a comment.


  >   We just can't use one fixed height for such texts.
  
  You can, but it'd have to be the maximum of all lineheights (of the entire 
document or of the visible section).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19283: try to improve painting height for text lines - bug 403868 avoid to cut _ and other parts still broken: double height things like mixed english/arab, see bug 404713

[Christoph Cullmann]

cullmann added a comment.


  If you keep the overpainting, you will just overpaint the next line partially 
with it, that won't help that much, IMHO.
  
  Take a look at bug 404713.
  
  We just can't use one fixed height for such texts.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19283

To: cullmann, dhaumann
Cc: rjvbb, loh.tar, thomassc, kwrite-devel, kde-frameworks-devel, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18601: Rewrite taglib writer to use property interface

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibwriter.cpp:70
> So **iff** the rating is updated at the same time as another property, taglib 
> has to adjust some in-memory structure twice. Obviously, for most formats 
> this poses no problem, but for Ape/Vorbis it does?
> 
> Also, this no longer applies when you use the specific tag types for Ape/Ogg.
> 
> Writing to disk only happens when calling `file->save()`...

Not sure I understand. I would like to avoid doing `file->properties();` and 
`file->setProperties();` twice for those formats for which only the PropertyMap 
is sufficient, e.g. Ape and Ogg, to avoid doing any unnecessary work.  The 
beauty of Ape and Ogg in the TagLib implementation is that they solely work 
with the PropertyMap and do not require any special handling. See D18826 
, Ape and Ogg do not have any extra 
codepath at all. For writing tags, we have to be a little bit more careful, 
though. If writing Rating information is added to writeGenericProperties, for 
example Id3v2's "TXXX" tags will be polluted with these values.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D19268: Let tests use the baloo_filemetadata_temp_extractor from the build dir

[Alexander Stippich]

astippich added a comment.


  Windows CI seems not to be happy about this
  
https://build.kde.org/job/Applications/job/baloo-widgets/job/kf5-qt5%20WindowsMSVCQt5.11

REPOSITORY
  R824 Baloo Widgets

REVISION DETAIL
  https://phabricator.kde.org/D19268

To: bruns, #frameworks, #baloo, ngraham, astippich, poboiko
Cc: domson, ashaposhnikov, astippich, spoorun, abrahams

D19430: Make it compile with QT_NO_CAST_FROM_ASCII

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R298 KDesignerPlugin

BRANCH
  compile_with_QT_NO_CAST_FROM_ASCII (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19430

To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:208
> Can you also use the same style as above, i.e. `const auto` and `for( : )`?

Oh, damn copy

> smithjd wrote in taglibextractor.cpp:195
> lstASF = asfTags->attribute("WM/Writer");
> ...
> 
> The existing code does this.

I wanted to avoid the extra querying, but apparently I already did the same for 
other special cases, so I did as you suggested

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18826

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

[Alexander Stippich]

astippich updated this revision to Diff 52890.
astippich marked 8 inline comments as done.
astippich added a comment.


  - rebase on master
  - implement review comments
  - cleanup includes

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18826?vs=52679=52890

BRANCH
  rewrite_taglib_extractor

REVISION DETAIL
  https://phabricator.kde.org/D18826

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D19385: use KPackage::fileUrl to support rcc KCMs packages

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:096d214b67b3: use KPackage::fileUrl to support rcc KCMs 
packages (authored by sitter).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19385?vs=52716=52889

REVISION DETAIL
  https://phabricator.kde.org/D19385

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: sitter, mart, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19388: improve documentation on global config cascading

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:d22f469be6fd: improve documentation on global config 
cascading (authored by sitter).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19388?vs=52725=52888

REVISION DETAIL
  https://phabricator.kde.org/D19388

AFFECTED FILES
  src/core/kconfig.h

To: sitter, kde-frameworks-devel, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19385: use KPackage::fileUrl to support rcc KCMs packages

[Harald Sitter]

sitter added a comment.


  LXR seems to show a whole bunch of these code segments 
https://lxr.kde.org/search?_filestring=&_string=package.filePath
  
  Deprecation is probably a good idea. From where I am standing an application 
can always grab the path out of an url if absolutely necessary.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19385

To: sitter, mart, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

Re: kconf_update lost its update.log in 2014

[Harald Sitter]

On Thu, Feb 28, 2019 at 8:20 PM Albert Astals Cid  wrote:
>
> El dijous, 28 de febrer de 2019, a les 12:43:07 CET, Harald Sitter va 
> escriure:
> > ...and I don't understand why
> >
> > Hi!
> >
> > this commit [1] wrapped KonfUpdate::log's update.log stream in `#if 0`
> > and thus disabling the update.log writing, replacing it with logging
> > to stderr instead. Why it does that eludes me though. It seems
> > entirely unrelated to the rest of the commit.
>
> Yep, maybe he was testing on windows, that code had issues on windows, 
> disabled it for the moment and then forgot to reenable?
>
> Sound we try CC'ing Alex Richardson in case he remembers? Or you did and it 
> got lost because he's on the list?

He's in the CC of my original mail.

> > Should the update.log writing happen? I expect this won't be super
> > reliable because I think these days the application itself forks
> > kconf_update.
>
> I don't understand what you mean with this. kconf_update has always been its 
> own application as far as i know.

I noticed KConfig::checkUpdate which would invoke the helper per
config (i.e. there could be multiple helpers running at the same time,
since checkUpdate could be called by multiple applications at the same
time) which would then cause out-of-order writes to the log from the
different inputs. Specifically it looks that the qtextstream was
buffered. After a second look checkUpdate seems to be a possibility
*in addition* to kded's global update run, my original thinking was
that the kded updating went away in favor of more atomic updating.

I find myself agreeing with Aleix that simply using QDebug is probably
the smart way to move forward.

Unfortunately I now have even more questions... namely: wouldn't every
application actually need to checkUpdate in case they are run in a
!plasma environment without kded? Otherwise kconf_update would never
get run. IOW: in a kde frameworks world order isn't the assumption
that kded is not running and therefore KConfig itself needs to run the
update?

HS

D7820: man ioslave: spurious numbers included in clang(1) man page

[Jonathan Marten]

marten added a reviewer: kfm-devel.
Herald added projects: Dolphin, Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D7820

To: marten, #plasma, kfm-devel
Cc: kde-frameworks-devel, plasma-devel, jraleigh, alexde, GB_2, feverfew, 
ragreen, Pitel, michaelh, spoorun, navarromorales, ZrenBot, firef, ngraham, 
andrebarros, bruns, emmanuelp, lesliezhai, ali-mohamed, mikesomov, 
jensreuterberg, abetts, sebas, apol, mart

D9033: man ioslave: asserts trying to display pam(8)

[Jonathan Marten]

marten added a reviewer: kfm-devel.
Herald added projects: Dolphin, Frameworks.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D9033

To: marten, #plasma, kfm-devel
Cc: kde-frameworks-devel, apol, plasma-devel, jraleigh, gennad, alexde, GB_2, 
feverfew, ragreen, Pitel, michaelh, spoorun, navarromorales, ZrenBot, firef, 
ngraham, andrebarros, bruns, skadinna, emmanuelp, lesliezhai, ali-mohamed, 
mikesomov, jensreuterberg, abetts, sebas, mart

D19439: kio_smb: Change incorrect use of QUrl::adjusted()

[Jonathan Marten]

marten created this revision.
marten added reviewers: Plasma, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
marten requested review of this revision.

REVISION SUMMARY
  Compiling this module produces a number of warnings all referring to the same 
source:
  
  kio-extras/smb/kio_smb_internal.h: In member function 'void 
SMBUrl::setFileName(const QString&)':
  kio-extras/smb/kio_smb_internal.h:96: warning: ignoring return value of 'QUrl 
QUrl::adjusted(QUrl::FormattingOptions) const', declared with attribute 
nodiscard
  
  The problem code is trying to make a URL for a partial file being 
uploaded/copied.  However, because QUrl::adjusted() does not modify the URL in 
place, the copy operation works but does not use the intended partial file 
name.  For example, if the destination file is "smb://server/dir/foobar.ext", 
the partial file name used will be 
"smb://server/dir/foobar.extfoobar.ext.part".  The complete file will 
eventually be saved under the correct name, but the name will be wrong if the 
transfer is aborted and the user wants to find the partial file.
  
  There is also the possibility of an error if the file name is long and the 
destination server has a length limit, because it effectively doubles in length.
  
  The change fixes the problem and simplifies the code by simply appending 
".part" to the supplied URL path directly.  No other part of the ioslave uses 
SMBUrl::setFileName() or SMBUrl::partUrl(), so this does not raise any 
compatibility problems.

TEST PLAN
  Built kio_smb with this change.  Observed no compiler warning messages, 
correct copying to and from SMB, and use of the correct partial file name.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D19439

AFFECTED FILES
  smb/kio_smb_internal.cpp
  smb/kio_smb_internal.h

To: marten, #plasma, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov

D19437: [knewstuff] Remove qt5.13 deprecated method

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> installation.cpp:575
> +connect(ret, static_cast QProcess::ExitStatus)>(::finished), this, [this, command](int 
> exitcode){
>  if (exitcode) {
>  qCCritical(KNEWSTUFFCORE) << "Command '" << command << "' failed 
> with code" << exitcode;

This should test the exit status too. I think that's the whole point of this 
change in Qt?

I guess the best way is

  if (status == crashed) 
 qCCritical "we crashed on the moon, good luck telling the families"
  else if (exitcode)
...

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D19437

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19436: [kservice] compile without deprecated method

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ksycocathreadtest.cpp:306
>  now = QDateTime::currentDateTime();
> -if (now.toTime_t() == ctime.toTime_t())   // truncate milliseconds
> +if (now.toMSecsSinceEpoch() == ctime.toMSecsSinceEpoch())   // 
> truncate milliseconds
>  {

This doesn't truncate milliseconds anymore

You should port toTime_t to toSecsSinceEpoch (no 'M')

REPOSITORY
  R309 KService

REVISION DETAIL
  https://phabricator.kde.org/D19436

To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns