date:20190817

D23196: have the app icon as fallback icon in Snore

2019-08-17 Thread Simon Redman

sredman accepted this revision.
sredman added a comment.
This revision is now accepted and ready to land.


  Since KNotifications on Windows is so far only used by you anyway, I say it's 
fine to merge. @broulik, any objections?

INLINE COMMENTS

> notifybysnore.cpp:157
> +notification->pixmap().save(iconPath, "PNG");
> +arguments   << QStringLiteral("-p") << iconPath;
> +} else if (!qApp->windowIcon().isNull()){

Whitespace

> notifybysnore.cpp:160
> +QIcon app_icon = qApp->windowIcon();
> +// We limit the icon size to 1024x1024 as it is the highest supported by 
> Windows
> +QPixmap pixmap = app_icon.pixmap(app_icon.actualSize(QSize(1024, 
> 1024)));

Indentation

REPOSITORY
  R289 KNotifications

BRANCH
  arcpatch-D23196

REVISION DETAIL
  https://phabricator.kde.org/D23196

To: brute4s99, #frameworks, broulik, sredman
Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

2019-08-17 Thread Simon Redman

sredman added a comment.


  In D22727#510698 , @brute4s99 
wrote:
  
  > In D22727#505540 , @dfaure wrote:
  >
  > > But, wait, this code is mixing "int permissions" (*) with the QFileDevice 
enum, that doesn't make any sense to me.
  > >
  > > (*) this comes from KIO::put, which takes unix permissions on unix, not 
sure what it takes on Windows...
  > >
  > > This doesn't match: unix permissions are octal (e.g. group read is 040 in 
octal), QFileDevice enum is hex (0x040).
  >
  >
  > Okay. I'm still unable to understand where/ how sftp::put() is called, or I 
would change everywhere it is called, to Qt way of permission extraction.
  
  
  I would recommend not making API or ABI changes. It's annoying that they're 
not compatible, but you can probably find some way to convert from Qt 
permissions to the expected values in order to not change users

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22727

To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D22144: Add kio recentlyused:/ to access KActivityStats data

2019-08-17 Thread Nathaniel Graham

ngraham added a comment.


  @ivan?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham
Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, 
fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

2019-08-17 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/14/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sun, 18 Aug 2019 00:42:14 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 26 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Aleix Pol Gonzalez

apol added a comment.


  Do you have commit rights or you need us to land it for you?

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Aleix Pol Gonzalez

apol accepted this revision.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella, apol
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23188: Fix supported OS attributes for api.kde.org

2019-08-17 Thread Aleix Pol Gonzalez

apol added inline comments.

INLINE COMMENTS

> metainfo.yaml:12
>  - name: Windows
> -- name: macOS (maintainer needed)
> +- name: MacOSX
> +  note: maintainer needed

Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to 
change elsewhere?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23188

To: vkrause, #frameworks
Cc: apol, plasma-devel, fbampaloukas, domson, dkardarakos, davidedmundson, 
mart, hein

D23205: [KProcessList] Optimize KProcessList::processInfo

2019-08-17 Thread Aleix Pol Gonzalez

apol added a comment.


  patch looks good overall.

INLINE COMMENTS

> kprocesslist_unix.cpp:157
>  const QStringList procIds = procDir.entryList();
>  if (procIds.isEmpty())
>  return rc;

checking if it's empty is unnecessary.

> kprocesslist_unix.cpp:171
> +KProcessInfo processInfo;
> +getProcessInfo(QString(QLatin1String("%1")).arg(pid), processInfo);
> +return processInfo;

Use QString::number()

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23205

To: hallas, davidedmundson, broulik
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Christoph Cullmann

cullmann added a comment.


  Jonathan, could you take a look? Thanks.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23225

To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Christoph Cullmann

cullmann reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23225

To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Andreas Sturmlechner

asturmlechner updated this revision to Diff 63954.
asturmlechner added a comment.


  Use deprecated variables as fallback if defined

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23229?vs=63952=63954

BRANCH
  kdeinstalldirs

REVISION DETAIL
  https://phabricator.kde.org/D23229

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Luigi Toscano

ltoscano added a comment.


  I can't check now, but I think the case were "the deprecated variable is set, 
but the new one is not, then the old one is used" should be  considered.

INLINE COMMENTS

> KF5DocToolsMacros.cmake:236
> +if (NOT KDE_INSTALL_MANDIR)
> +set(KDE_INSTALL_MANDIR share/man)
>  endif()

I wonder if we should consider the deprecated variable as well. It's 
deprecated, but if it has been set, and the new one is not set, the old one 
should be probably used.

> KF5DocToolsMacros.cmake:239
> +if (NOT KDE_INSTALL_DOCBUNDLEDIR)
> +set(KDE_INSTALL_DOCBUNDLEDIR share/doc/HTML)
>  endif()

Aee above.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Andreas Sturmlechner

asturmlechner added a reviewer: Frameworks.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D23229

To: asturmlechner, #frameworks
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
michaelh, ngraham, bruns, skadinna

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Andreas Sturmlechner

asturmlechner created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR
  MAN_INSTALL_DIR -> KDE_INSTALL_MANDIR
  
  BUG: 410998

TEST PLAN
  Install paths are correct by example of marble.

REPOSITORY
  R238 KDocTools

BRANCH
  kdeinstalldirs

REVISION DETAIL
  https://phabricator.kde.org/D23229

AFFECTED FILES
  KF5DocToolsMacros.cmake

To: asturmlechner
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, 
michaelh, ngraham, bruns, skadinna

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread David Faure

dfaure added a comment.


  The unittest doesn't seem to pass on CI:
  
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/
  
FAIL!  :   EmulatedCommandBarTest::EmulatedCommandBarTests() Compared 
values are not the same
Actual   (kate_document->text()): "bar\nbar\nbar"
Expected (expected_text): "foo\nfoo\nbar"
Loc: [/home/jenkins/workspace/Frameworks/ktexteditor/kf5-qt5 
SUSEQt5.12/autotests/src/vimode/emulatedcommandbar.cpp(1950)]

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23225

To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.13 - Build # 25 - Unstable!

2019-08-17 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.13/25/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Sat, 17 Aug 2019 19:56:43 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_emulatedcommandbar
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33307/48959)51%
(15803/31229)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4769/5064)49%
(1808/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5476/5516)58%
(994/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1783/3125)43%
(1166/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/848)0%
(0/220)src.document100%
(4/4)100%
(4/4)61%
(1941/3185)50%
(1598/3215)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/860)0%
(0/296)src.render100%
(7/7)100%
(7/7)77%
(949/1238)66%
(603/910)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 21 - Unstable!

2019-08-17 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/21/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 17 Aug 2019 19:56:43 +
 Build duration:
7 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_emulatedcommandbar

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 149 - Unstable!

2019-08-17 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 17 Aug 2019 19:56:43 +
 Build duration:
6 min 40 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5TextEditor-5.62.0.xmlcompat_reports/KF5TextEditor_compat_report.htmllogs/KF5TextEditor/5.62.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_emulatedcommandbar
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report79%
(22/28)88%
(260/295)88%
(260/295)68%
(33307/48959)51%
(15803/31229)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(38/38)100%
(38/38)94%
(4769/5064)49%
(1808/3662)autotests.src.vimode100%
(9/9)100%
(9/9)99%
(5476/5516)58%
(994/1710)src.buffer88%
(15/17)88%
(15/17)90%
(1708/1900)76%
(1210/1598)src.completion100%
(11/11)100%
(11/11)57%
(1783/3125)43%
(1166/2733)src.completion.expandingtree100%
(3/3)100%
(3/3)40%
(183/458)22%
(75/346)src.dialogs0%
(0/4)0%
(0/4)0%
(0/848)0%
(0/220)src.document100%
(4/4)100%
(4/4)61%
(1941/3185)50%
(1598/3215)src.export0%
(0/4)0%
(0/4)0%
(0/119)0%
(0/162)src.include.ktexteditor93%
(14/15)93%
(14/15)91%
(215/237)65%
(145/224)src.inputmode100%
(8/8)100%
(8/8)63%
(189/302)51%
(39/77)src.mode88%
(7/8)88%
(7/8)37%
(306/837)21%
(150/729)src.part0%
(0/1)0%
(0/1)0%
(0/7)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/860)0%
(0/296)src.render100%
(7/7)100%
(7/7)77%
(949/1238)66%
(603/910)src.schema29%
(2/7)29%
(2/7)1%
(20/1492)1%
(6/673)src.script100%
(16/16)100%
(16/16)68%
(731/1069)58%

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:622bd6c94803: Allow 0 in line ranges in vim mode. 
(authored by verner, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23225?vs=63943=63944

REVISION DETAIL
  https://phabricator.kde.org/D23225

AFFECTED FILES
  autotests/src/vimode/emulatedcommandbar.cpp
  src/vimode/commandrangeexpressionparser.cpp

To: verner, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Seems reasonable, thanks for taking care ;=)
  
  I you use the vi mode, we have more open vi mode bugs that need some love:
  
  
https://bugs.kde.org/buglist.cgi?bug_severity=critical_severity=grave_severity=major_severity=crash_severity=normal_severity=minor_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED_id=1655504=component%20DESC%2Cbug_status%20DESC%2Cbug_severity%2Cpriority%2Cassigned_to%2Cbug_id=frameworks-ktexteditor=kate_format=advanced
  
  (vi input component)
  
  We have some hack to fix one of them here, that needs some research: 
https://phabricator.kde.org/D19408

REPOSITORY
  R39 KTextEditor

BRANCH
  fix/vim_mode_accept_0_as_line_index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23225

To: verner, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Jonathan Verner

verner added a reviewer: cullmann.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23225

To: verner, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23225: Allow 0 in line ranges in vim mode.

2019-08-17 Thread Jonathan Verner

verner created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
verner requested review of this revision.

REVISION SUMMARY
  Vim numbers lines starting from 1. However, in command ranges such as, e.g., 
0,$s/foo/bar/g
  it accepts zero as a line number and treats it as 1. This commit implements 
the same behaviour
  for kate.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix/vim_mode_accept_0_as_line_index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23225

AFFECTED FILES
  autotests/src/vimode/emulatedcommandbar.cpp
  src/vimode/commandrangeexpressionparser.cpp

To: verner
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Nicolas Fella

nicolasfella accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu, nicolasfella
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D7446: [Places panel] Revamp the Recently Saved section

2019-08-17 Thread Méven Car

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D7446: [Places panel] Revamp the Recently Saved section

2019-08-17 Thread Méven Car

meven edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: meven, #dolphin, broulik, elvisangelaccio, markg, #vdg, #frameworks, ngraham
Cc: meven, trickyricky26, andreask, huftis, svenmauch, kde-frameworks-devel, 
spoorun, anthonyfieroni, andreaska, gregormi, markg, alexeymin, broulik, 
elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, 
feverfew, michaelh, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, mikesomov

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

meven edited the summary of this revision.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

meven edited the summary of this revision.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Pino Toscano

pino added a comment.


  In D23224#513556 , @z3ntu wrote:
  
  > I'm guessing the changed English strings will trigger a "untranslated 
string" warning in the translation software, so the translators should notice 
it, right?
  
  
  Yes.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss

z3ntu added a comment.


  I'm guessing the changed English strings will trigger a "untranslated string" 
warning in the translation software, so the translators should notice it, right?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss

z3ntu updated this revision to Diff 63935.
z3ntu added a comment.


  Don't change the translated strings

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23224?vs=63934=63935

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

AFFECTED FILES
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudplugin.json

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Roman Gilg

romangg added a comment.


  This means only change it in lines without `[..]`.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: romangg, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Pino Toscano

pino added a comment.


  Please do **not** change the translations manually -- there is an automatic 
system that takes care of extracting the English strings, and merging back the 
translators for desktop/json/xml/alike files.
  
  If the English text is correct but a translation is not: please notify the 
translators using the global coordination mailing list: 
https://mail.kde.org/mailman/listinfo/kde-i18n-doc

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D23224

To: z3ntu
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23224: Fix capitalization of Nextcloud

2019-08-17 Thread Luca Weiss

z3ntu created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
z3ntu requested review of this revision.

REVISION SUMMARY
  Nextcloud is not written like NextCloud

TEST PLAN
  There is no more instance of 'NextCloud' in the codebase.

REPOSITORY
  R495 Purpose Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23224

AFFECTED FILES
  src/plugins/nextcloud/nextcloud-upload.service.in
  src/plugins/nextcloud/nextcloudplugin.json

To: z3ntu
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

Licence of GCompris in ubuntu snaps

2019-08-17 Thread Johnny Jazeix

Hi,
I just installed a fresh ubuntu and noticed that the GCompris licence
in the snap package was "Proprietary". After some search, I think it's
because it's set to "unset" in the snap package:
https://snapcraft.io/gcompris

Does anyone know who should I contact to set it to GPLv3+? There is
also a "Is there a problem with gcompris? Report this app" button that
I can contact if nobody knows.

Thanks,

Johnny

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-17 Thread Christoph Cullmann

cullmann added a reviewer: dfaure.
cullmann added a comment.


  Could somebody try this?
  Unfortunately, neither with or without this patch I can get all kio unit 
tests running here properly :(

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8810

To: cullmann, #frameworks, kfunk, kkofler, dfaure
Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, LeGast00n, michaelh, 
bruns

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-17 Thread Christoph Cullmann

cullmann updated this revision to Diff 63931.
cullmann added a comment.


  Instead of changing the search paths, alter the kioslave binary name to 
"kioslave5" to avoid clashs with old variants.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8810?vs=22338=63931

REVISION DETAIL
  https://phabricator.kde.org/D8810

AFFECTED FILES
  src/core/slave.cpp
  src/kioslave/CMakeLists.txt
  src/kioslave/kioslave.cpp

To: cullmann, #frameworks, kfunk, kkofler
Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, LeGast00n, michaelh, 
bruns

D8810: Do not look for kioslave binary in applicationDirPath on *nix (#386859)

2019-08-17 Thread Christoph Cullmann

cullmann commandeered this revision.
cullmann edited reviewers, added: kkofler; removed: cullmann.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8810

To: cullmann, #frameworks, kfunk, kkofler
Cc: kde-frameworks-devel, dfaure, ngraham, broulik, kfunk, LeGast00n, michaelh, 
bruns

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:635cb83670f9: Use CMake find_dependency in CMake config 
file instead of find_package (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23208?vs=63914=63927

REVISION DETAIL
  https://phabricator.kde.org/D23208

AFFECTED FILES
  KF5SyntaxHighlightingConfig.cmake.in

To: daandemeyer, #framework_syntax_highlighting, dhaumann, cgiboudeaux
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D23203: Use CMake find_dependency instead of find_package in CMake config file template.

2019-08-17 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d55e0120fdc3: Use CMake find_dependency instead of 
find_package in CMake config file template. (authored by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23203?vs=63864=63926

REVISION DETAIL
  https://phabricator.kde.org/D23203

AFFECTED FILES
  KF5TextEditorConfig.cmake.in

To: daandemeyer, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, szutmael, domson, michaelh, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

2019-08-17 Thread Christoph Cullmann

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:624ba8b98dbc: SCSS: fix interpolation (#{...}) and add 
the Interpolation color (authored by jpoelen, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23195?vs=63845=63925#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23195?vs=63845=63925

REVISION DETAIL
  https://phabricator.kde.org/D23195

AFFECTED FILES
  autotests/folding/highlight.scss.fold
  autotests/html/highlight.scss.html
  autotests/html/review128925-2.scss.html
  autotests/input/highlight.scss
  autotests/reference/highlight.scss.ref
  autotests/reference/review128925-2.scss.ref
  data/syntax/scss.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

2019-08-17 Thread Christoph Cullmann

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks, let's merge that.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix_scss_interpolation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23195

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Christophe Giboudeaux

cgiboudeaux accepted this revision.

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann, cgiboudeaux
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-17 Thread David Hallas

hallas added inline comments.

INLINE COMMENTS

> meven wrote in klistopenfiles.cpp:39
> The qAsConst wrapping is missing it seems.

Yeah, I have only done this change locally ;)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

2019-08-17 Thread Volker Krause

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23217

To: dfaure, vkrause, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21760: Add KListOpenFiles::listProcessesWithOpenFiles

2019-08-17 Thread Méven Car

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in klistopenfiles.cpp:39
> Not possible, due to the removeDuplicates() line.

The qAsConst wrapping is missing it seems.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D21760

To: hallas, davidedmundson, broulik, #frameworks, dfaure, bruns, #plasma
Cc: meven, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

2019-08-17 Thread David Faure

dfaure created this revision.
dfaure added reviewers: vkrause, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  Cleaned up Q_WS_WIN usage along the way (dead code)

TEST PLAN
  Builds

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23217

AFFECTED FILES
  src/ioslaves/http/kcookiejar/kcookieserver.cpp
  src/ioslaves/http/kcookiejar/kcookiewin.cpp
  src/kpasswdserver/kpasswdserver.cpp

To: dfaure, vkrause, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

2019-08-17 Thread David Hallas

hallas added a comment.


  In D23214#513408 , @meven wrote:
  
  > In D23214#513396 , @hallas wrote:
  >
  > > Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.
  >
  >
  > Great suggestion I missed this prior diff.
  >
  > Abandoned in favor of D21760  and 
adding a KJob for this use case
  
  
  I am currently working on re-working the code to derive from KJob, will post 
an updated patch soon :) Also, please take a look at the code and come with 
review comments/suggestions :)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

2019-08-17 Thread Méven Car

meven abandoned this revision.
meven added a comment.


  In D23214#513396 , @hallas wrote:
  
  > Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.
  
  
  Great suggestion I missed this prior diff.
  
  Abandoned in favor of D21760  and adding 
a KJob for this use case

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

2019-08-17 Thread David Hallas

hallas added a comment.


  Hey @meven I have been working on the same thing D21760 
 - maybe we should consolidate our efforts? 
The code you have written looks very similar to what I have been doing :) As 
you can read in the review comments for D21760 
 the current suggestion is to look into 
doing a KJob subclass.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D23214

To: meven, davidedmundson, #frameworks
Cc: hallas, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:acbc21c15622: Add a event Spy for GtkFileChooser recent 
files (authored by meven).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63913=63915

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Daan De Meyer

daandemeyer marked an inline comment as done.

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Daan De Meyer

daandemeyer updated this revision to Diff 63914.
daandemeyer added a comment.


  Use `REQUIRED_QT_VERSION` to specifiy required Qt version.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23208?vs=63877=63914

REVISION DETAIL
  https://phabricator.kde.org/D23208

AFFECTED FILES
  KF5SyntaxHighlightingConfig.cmake.in

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

2019-08-17 Thread Volker Krause

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23215

To: dfaure, zzag, vkrause
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63913.
meven added a comment.


  Reduce the amount of included code and linked libraries

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63890=63913

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

2019-08-17 Thread David Faure

dfaure created this revision.
dfaure added a reviewer: zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.

REVISION SUMMARY
  I wish there was a method like nativeWindow() which would take care of
  both ensuring a native window and returning it, but well.

TEST PLAN
  Builds

REPOSITORY
  R311 KWallet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23215

AFFECTED FILES
  src/runtime/kwalletd/kwalletd.cpp

To: dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63911.
meven added a comment.


  Add copyright

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23214?vs=63910=63911

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23214

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/util/blockingapp.cpp
  src/lib/util/blockingapp.h
  tests/CMakeLists.txt
  tests/testblockingapp.cpp

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23214: Add a BlockinApp util class to find process blockng access

2019-08-17 Thread Méven Car

meven created this revision.
meven added reviewers: davidedmundson, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Uses lsof and kprocesslist to extract names of process blocking on the given 
files.
  
  It is a port over from ksolidnotify.h of plasma-workspace to allow broader 
use.
  
  CC D19989 

TEST PLAN
  Using testBlockingApp test

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23214

AFFECTED FILES
  src/lib/CMakeLists.txt
  src/lib/util/blockingapp.cpp
  src/lib/util/blockingapp.h
  tests/CMakeLists.txt
  tests/testblockingapp.cpp

To: meven, davidedmundson, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Ivan Čukić

ivan accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Possible to move some KF5 frameworks to invent?

2019-08-17 Thread Ben Cooksley

On Fri, Aug 16, 2019 at 6:30 AM Christoph Cullmann
 wrote:
>
> Hi,

Hi Christoph,

>
> >> perhaps this would be some good BoF at Akademy:
> >>
> >> What is needed to move frameworks development to invent.kde.org.
> >>
> >> (I assume we want to do that some when in the future anyways)
> >
> > At this point my planning expected that Frameworks would move when the
> > rest of KDE moves (which will likely be a massive migration that
> > happens in very quick succession once everything is ready).
>
> is there some timeline known when this might happen?
> And is there some help needed to handle the transition?

At the moment the timeline is dependent on three pre-requisites being fulfilled.
Those are:
1) Completion of the replacement to our anongit system
2) Completion of the Identity <-> Gitlab sync component, to ensure
changes to group (as well as people's names and email addresses)
3) Finalisation of the process to import all our existing repositories
into Gitlab

At this time, the replacement anongit system is partially written,
with some parts still left to finish. With regards to the Identity
sync, that has been fully planned, but no code has been written yet.

The importing of the repositories is the simplest of the three items
to put together, and has also been fully planned (the actual creation
of the repositories and importing their contents is part of Gitlab's
core functionality, we just have to provide an file system
representation of how the repositories are to be laid out). Part of
this also required preparing a plan on how the repositories will be
structured (layout wise) on Gitlab - which has also been completed.

>
> Btw., thanks already for all the work you and others did on improving
> our infrastructure!
>
> Greetings
> Christoph

Cheers,
Ben

>
> --
> Ignorance is bliss...
> https://cullmann.io | https://kate-editor.org

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-17 Thread Alexander Semke

asemke added inline comments.

INLINE COMMENTS

> kxmlgui_unittest.cpp:1089
>  QCOMPARE(QLocale::system().language(), QLocale::Russian);
> +QCOMPARE(QLocale::system().monthName(1), QString::fromUtf8("января"));
>  

does this test work? The name of the month is "январь" in russian, not "января".

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D23119

To: aacid
Cc: apol, kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> dfaure wrote in renamefiledialog.cpp:246
> I see you used the more complicated solution of keeping showEvent and testing 
> for spontaneous. Any reason? It didn't work from the constructor?

After some testing using !spontaneous() here is pointless.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63895.
meven added a comment.


  Call setFocus() in dialog constructor

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=63892=63895

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D23188: Fix supported OS attributes for api.kde.org

2019-08-17 Thread Volker Krause

vkrause added a reviewer: Frameworks.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D23188

To: vkrause, #frameworks
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D19620: Use a searchbar similar to the one in okular

2019-08-17 Thread Björn Feber

GB_2 added a comment.


  See https://phabricator.kde.org/D19774#inline-110882

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23108: Add KWindowSystem::setMainWindow(QWindow *) overload

2019-08-17 Thread David Faure

dfaure updated this revision to Diff 63893.
dfaure added a comment.


  Adjust documentation

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23108?vs=63597=63893

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23108

AFFECTED FILES
  src/kstartupinfo.h
  src/kwindowsystem.cpp
  src/kwindowsystem.h

To: dfaure, broulik, davidedmundson, zzag
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63892.
meven added a comment.


  Fix dialog where the private class was missing the renamed files items

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=63891=63892

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven marked 6 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17595

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D17595: Upstream Dolphin's file rename dialog

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63891.
meven added a comment.


  Emit error correctly use name() function of KFileItem

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17595?vs=63854=63891

BRANCH
  arcpatch-D17595

REVISION DETAIL
  https://phabricator.kde.org/D17595

AFFECTED FILES
  src/widgets/CMakeLists.txt
  src/widgets/renamefiledialog.cpp
  src/widgets/renamefiledialog.h

To: meven, #frameworks, #dolphin, broulik, ngraham, dfaure
Cc: dfaure, sitter, mitchell, emmanuelp, ltoscano, bruns, meven, dhaumann, 
pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham

D19620: Use a searchbar similar to the one in okular

2019-08-17 Thread Dominik Haumann

dhaumann added a comment.


  In D19620#512883 , @GB_2 wrote:
  
  > Don't use the unicode ellipsis. We use three dots everywhere.
  
  
  Interesting. @ngraham didn't you suggest to use the ellipsis recently?

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Christophe Giboudeaux

cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5SyntaxHighlightingConfig.cmake.in:4-5
> +include(CMakeFindDependencyMacro)
> +find_dependency(Qt5Core @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
> +find_dependency(Qt5Gui @Qt5Core_VERSION_MAJOR@.@Qt5Core_VERSION_MINOR@)
>  

Please use REQUIRED_QT_VERSION defined in the top CMakeLists.txt instead of 
these Qt5Core_VERSION_*

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: cgiboudeaux, kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, 
bmortimer, domson, michaelh, genethomas, ngraham, bruns, demsking, cullmann, 
vkrause, sars, dhaumann

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

meven marked 3 inline comments as done.

REPOSITORY
  R161 KActivity Manager Service

REVISION DETAIL
  https://phabricator.kde.org/D23112

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23208: Use CMake find_dependency in CMake config file instead of find_package

2019-08-17 Thread Dominik Haumann

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D23208

To: daandemeyer, #framework_syntax_highlighting, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, 
michaelh, genethomas, ngraham, bruns, demsking, cullmann, vkrause, sars, 
dhaumann

D23203: Use CMake find_dependency instead of find_package in CMake config file template.

2019-08-17 Thread Dominik Haumann

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23203

To: daandemeyer, #ktexteditor, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, szutmael, domson, michaelh, 
ngraham, bruns, demsking, head7, cullmann, kfunk, sars, dhaumann

D23112: Add a event Spy for GtkFileChooser recent files

2019-08-17 Thread Méven Car

meven updated this revision to Diff 63890.
meven added a comment.


  Ensure the log category is exported, compare only chars, variable naming fix

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23112?vs=63830=63890

BRANCH
  arcpatch-D23112

REVISION DETAIL
  https://phabricator.kde.org/D23112

AFFECTED FILES
  kactivitymanagerd.categories
  src/service/plugins/CMakeLists.txt
  src/service/plugins/gtk-eventspy/CMakeLists.txt
  src/service/plugins/gtk-eventspy/GtkEventSpy.cpp
  src/service/plugins/gtk-eventspy/GtkEventSpy.h
  src/service/plugins/gtk-eventspy/kactivitymanagerd-plugin-gtk-eventspy.json

To: meven, #frameworks, ivan
Cc: bruns, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

75 matches

Mail list logo