Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- (Updated Sept. 29, 2019, 5:41 p.m.) Status -- This change has been discarded. Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek. Repository: kio Description --- If mouse double click is done on the empty area, then go to parent directory. RR 123658 (dolphin) Diffs - src/filewidgets/kdiroperator.h 6d601f3 src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/2/ Testing --- Works fine! Thanks, Ashish Bansal
robots.txt in quickgit.kde.org
Hi everyone, "quickgit.kde.org" contains robots.txt[0] which is disallowing search engines to fetch the project repos. I just wanted to know if this is intentional or not? If I recall correctly, mirror of kde repositories on github was created just because it wasn't being indexed by the search engines. [0] https://quickgit.kde.org/robots.txt -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Re: Review Request 124794: Create one Database instance per process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 12:59 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Changes --- Fixed issues Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs (updated) - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
On Aug. 17, 2015, 7:50 p.m., Vishesh Handa wrote: autotests/unit/lib/filefetchjobtest.cpp, line 92 https://git.reviewboard.kde.org/r/124794/diff/2/?file=395729#file395729line92 What is this used for? I have removed autotests/unit/lib/db.cpp which contained these functions and was linked with this test. As global.cpp is in engine and Baloo::Engine is being linked with this test, it was giving error multiple definition of fileIndexDbPath as both of them had same function earlier. So, moved that code here. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review83960 --- On Aug. 18, 2015, 12:59 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 12:59 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
On Aug. 18, 2015, 6:26 p.m., Vishesh Handa wrote: src/tools/balooctl/main.cpp, line 125 https://git.reviewboard.kde.org/r/124794/diff/4/?file=396192#file396192line125 I think you can use the `fileIndexDbPath` function over here? Actually it ends with one extra / as it's being used in other line : QFileInfo indexInfo(path + QLatin1String(index)); Although we may can append that / in fileIndexDbPath itself. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review84011 --- On Aug. 18, 2015, 6:08 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 6:08 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
On Aug. 18, 2015, 6:46 p.m., Vishesh Handa wrote: src/tools/balooctl/main.cpp, line 127 https://git.reviewboard.kde.org/r/124794/diff/4/?file=396192#file396192line127 We just put the extra '/' over here. ah, my stupidity! - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/#review84014 --- On Aug. 18, 2015, 6:08 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 6:08 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 6:08 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Changes --- Removed path variable from extractor Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs (updated) - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Review Request 124805: Generate xml interface file using qt5_generate_dbus_interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124805/ --- Review request for Baloo, Pinak Ahuja and Vishesh Handa. Repository: baloo Description --- Use automatic generated xml interface file. Now no need to use qdbuscpp2xml manually :) Diffs - src/dbus/CMakeLists.txt 13e0ee0 src/file/CMakeLists.txt 214e60a src/file/mainhub.h e1320a6 src/file/org.kde.baloo.file.indexer.xml 0aefdac Diff: https://git.reviewboard.kde.org/r/124805/diff/ Testing --- Baloo monitor works fine Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124805: Generate xml interface file using qt5_generate_dbus_interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124805/ --- (Updated Aug. 18, 2015, 7:40 p.m.) Status -- This change has been marked as submitted. Review request for Baloo, Pinak Ahuja and Vishesh Handa. Changes --- Submitted with commit e7525dfe6a62c6931b66050fd4e55260bd34b7a2 by Ashish Bansal to branch master. Repository: baloo Description --- Use automatic generated xml interface file. Now no need to use qdbuscpp2xml manually :) Diffs - src/dbus/CMakeLists.txt 13e0ee0 src/file/CMakeLists.txt 214e60a src/file/mainhub.h e1320a6 src/file/org.kde.baloo.file.indexer.xml 0aefdac Diff: https://git.reviewboard.kde.org/r/124805/diff/ Testing --- Baloo monitor works fine Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 18, 2015, 7:32 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Changes --- Fixed issues Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs (updated) - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.h 2c1ca4e src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Review Request 124794: Create one Database instance per process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- Review request for Baloo, Bhushan Shah and Vishesh Handa. Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs - autotests/unit/lib/CMakeLists.txt 871bf8d autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 124794: Create one Database instance per process
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124794/ --- (Updated Aug. 17, 2015, 6:32 p.m.) Review request for Baloo, Bhushan Shah and Vishesh Handa. Changes --- Fixed issues Bugs: 350247 http://bugs.kde.org/show_bug.cgi?id=350247 Repository: baloo Description --- Earlier two Database instances were being created and once one of them was destroyed, it leads to invalidation of handles of other instance too. Now a global single instance is being created and is destroyed when process ends. Diffs (updated) - autotests/unit/lib/db.cpp af34025 autotests/unit/lib/filefetchjobtest.cpp 2d53c8c src/engine/CMakeLists.txt 109c19e src/engine/database.h 1556f0a src/engine/database.cpp 9dd7327 src/engine/global.h PRE-CREATION src/engine/global.cpp PRE-CREATION src/file/extractor/app.cpp 1575f05 src/file/extractor/main.cpp 3dfb28d src/file/main.cpp bd162a7 src/lib/CMakeLists.txt 7bf52e0 src/lib/db.h 4b87345 src/lib/db.cpp c9a11f2 src/lib/file.cpp 13dff88 src/lib/query.cpp 99fb91a src/lib/searchstore.cpp 0df20b9 src/lib/taglistjob.cpp 1abe071 src/tools/baloo-monitor/monitor.cpp e78e287 src/tools/balooctl/main.cpp 0736b0c src/tools/balooshow/main.cpp 02af838 autotests/unit/lib/CMakeLists.txt 871bf8d Diff: https://git.reviewboard.kde.org/r/124794/diff/ Testing --- Plasma Mediacenter works fine. Thanks, Ashish Bansal Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- (Updated May 30, 2015, 12:42 p.m.) Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek. Changes --- Fixed issue and double click only goes back if activate item on single click is enabled Repository: kio Description --- If mouse double click is done on the empty area, then go to parent directory. RR 123658 (dolphin) Diffs (updated) - src/filewidgets/kdiroperator.h 6d601f3 src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)
On May 29, 2015, 12:45 p.m., David Faure wrote: I'm not sure this is a good idea, usability wise. Miss an icon by one pixel, and the effect is to go up, making the whole set of icons disappear? Well about usability there's already discussion going on dolphin RR 123658. Single click is the way to select a directory(atleast by default). So, even if someone wants to select an directory and misses it, it won't go up. Go up behaviour is only when one would use double click :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80946 --- On May 28, 2015, 11:30 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- (Updated May 28, 2015, 11:30 p.m.) Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek. Repository: kio Description --- If mouse double click is done on the empty area, then go to parent directory. RR 123658 (dolphin) Diffs - src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/#review80962 --- src/filewidgets/kdiroperator.cpp (line 1298) https://git.reviewboard.kde.org/r/123929/#comment55464 Double click on item goes into that directory and then comes back. I'll fix it soon. - Ashish Bansal On May 28, 2015, 11:30 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- (Updated May 28, 2015, 11:30 p.m.) Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek. Repository: kio Description --- If mouse double click is done on the empty area, then go to parent directory. RR 123658 (dolphin) Diffs - src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123929/ --- Review request for Dolphin, KDE Frameworks, KDE Usability, David Faure, and Martin Klapetek. Repository: kio Description --- If mouse double click is done on the empty area, then go to parent directory. RR 123658 (dolphin) Diffs - src/filewidgets/kdiroperator.cpp 4a7ef02 Diff: https://git.reviewboard.kde.org/r/123929/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 4:46 p.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- fixed issues Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 7:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal to branch master. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 28, 2015, 2:35 p.m., David Faure wrote:
src/core/global.cpp, line 407
https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407
startsWith('.') (using the QChar overload)
Do we even need this special case, with the way the code is now? It
seems to me that removing this first if() branch would work just the same.
The first if() has been used for getting . (1).txt instead of .txt (1)
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
---
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 30, 2015, 9:05 a.m.)
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
Bugs: 341773
https://bugs.kde.org/show_bug.cgi?id=341773
Repository: kio
Description
---
For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong
name(something like filename-1 2.6.tar.gz).
Expected name: filename-1.6 (1).tar.gz
Diffs
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 28, 2015, 2:35 p.m., David Faure wrote:
src/core/global.cpp, line 407
https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407
startsWith('.') (using the QChar overload)
Do we even need this special case, with the way the code is now? It
seems to me that removing this first if() branch would work just the same.
Ashish Bansal wrote:
The first if() has been used for getting . (1).txt instead of .txt (1)
But yeah, code looks nasty with this special case. Should I remove this?
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
---
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 30, 2015, 9:05 a.m.)
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
Bugs: 341773
https://bugs.kde.org/show_bug.cgi?id=341773
Repository: kio
Description
---
For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong
name(something like filename-1 2.6.tar.gz).
Expected name: filename-1.6 (1).tar.gz
Diffs
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 30, 2015, 9:05 a.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- fixed issues Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 28, 2015, 2:38 p.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- (David) (but Arjun's patch was then reverted) -- also add bug number. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would not like suggestName to remove the dotness of file instead it should append/increment no. at end. But if you still find no. at the starting as better use case, then no problem I'll change it right away. David Faure wrote: I agree, a dot file should keep starting with a dot. Martin Klapetek wrote: Indeed. I'd suggest .(1).txt maybe to also keep the file extension in tact? Yeah that sounds good. Changed it to . (1).txt :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 25, 2015, 7:42 p.m., David Faure wrote: src/core/global.cpp, line 397 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359785#file359785line397 Why do you assemble a list, and then only look at the last element? You just need an int and a QMimeType, if only the last element matters. Also, why loop over every character? Is the goal to handle .foo.txt vs .tar.gz? There's API for that in QMimeDatabase, it can return the mimetype and even the known suffix without any iteration needed, see QMimeDatabase::suffixForFileName. Ah sorry, I didn't know that QMimeDatabase::suffixForFileName can handle .foo.txt vs .tar.gz :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79509 --- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Changes --- fixed issues Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: Just a question - why is the current suggested name wrong? In name filename-1.6.tar.gz, 1.6 denotes package version and new suggested name changes it to filename-1 2.6.tar.gz. It should add 1 after the package version and should not increment package name from 1.6 to 2.6. If i keep calling suggestName, it changes it further to 3.6, 4.6 and so on. So, I hope that explains the current suggested name is wrong :) On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? imho if my any file starts with ., that's my dot file and I would not like suggestName to remove the dotness of file instead it should append/increment no. at end. But if you still find no. at the starting as better use case, then no problem I'll change it right away. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OAuth in KDE
On Sun, Oct 26, 2014 at 11:35 PM, Daniel Vratil dvra...@redhat.com wrote: On Saturday 25 of October 2014 17:09:02 Ashish Bansal wrote: Hey everyone, Is there any implementation of OAuth for Google Account in KDE? I was working on Plasma Media Center bug in which I need to make it support Two-Step Authentication for Google Account. Hi, we have implementation for Google's OAuth in LibKGAPI (the library that implements some Google REST APIs, used mostly by KDE PIM). Alternatively I think that Martin Klapetek is working on the new SSO mechanism (it is called KAccounts I think) that would support this too. In both cases you just ask the library for account credentials, the library does all the dancing and hands you the OAuth tokens in the end. Yeah I have checked their api and these libraries are really awesome. Thanks!! Regards, Daniel *Regards,* *Ashish Bansal* *http://ashish-bansal.in http://ashish-bansal.in/* * http://ashish-bansal.in* -- Daniel Vrátil | dvra...@redhat.com | dvratil on #kde-devel, #kontact, #akonadi Software Engineer - KDE Desktop Team, Red Hat Inc. GPG Key: 0xC59D614F6F4AE348 Fingerprint: 4EC1 86E3 C54E 0B39 5FDD B5FB C59D 614F 6F4A E348 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
OAuth in KDE
Hey everyone, Is there any implementation of OAuth for Google Account in KDE? I was working on Plasma Media Center bug in which I need to make it support Two-Step Authentication for Google Account. *Regards,* *Ashish Bansal* *http://ashish-bansal.in http://ashish-bansal.in/* * http://ashish-bansal.in* Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe
