D24003: kwaylandScanner produce version enum per class

2019-09-20 Thread Frederik Gladhorn
gladhorn marked an inline comment as done.
gladhorn added inline comments.

INLINE COMMENTS

> zzag wrote in generator.cpp:431
> Is it correct thogugh? Can you provide some test input so it's easier to see 
> the problem?

run kwaylandScanner on 
/usr/share/wayland-protocols/unstable/primary-selection/primary-selection-unstable-v1.xml
 and see that it produces something that doesn't compile. With this change it 
compiles.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24003

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24004: Teach kwaylandscanner about PrimarySelection

2019-09-20 Thread Frederik Gladhorn
gladhorn added subscribers: zzag, romangg, davidedmundson.
gladhorn added a comment.


  @romangg and @davidedmundson  any comments? I think @zzag  prefers the class 
names without the V1. I'd like to progress on this step by step and the 
generator at least gives a good starting point.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24004

To: gladhorn, #kwin
Cc: davidedmundson, romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D24002: Sort files alphabetically in cmake list

2019-09-17 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6c8f110f3a22: Sort files alphabetically in cmake list 
(authored by gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24002?vs=66278=66279

REVISION DETAIL
  https://phabricator.kde.org/D24002

AFFECTED FILES
  src/server/CMakeLists.txt

To: gladhorn, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24003: kwaylandScanner produce version enum per class

2019-09-17 Thread Frederik Gladhorn
gladhorn added a comment.


  The unstable primary selection v1 protocol produces code that doesn't 
compile, after this change it does compile - since it expects the version enums 
for three classes, but only the first one is actually written into the file.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24003

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24002: Sort files alphabetically in cmake list

2019-09-17 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 66278.
gladhorn added a comment.


  Actually sort all files

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24002?vs=66254=66278

BRANCH
  arcpatch-D24002

REVISION DETAIL
  https://phabricator.kde.org/D24002

AFFECTED FILES
  src/server/CMakeLists.txt

To: gladhorn, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24004: Teach kwaylandscanner about PrimarySelection

2019-09-16 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  This allows generating the skeleton classes for the primary selection 
protocol.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24004

AFFECTED FILES
  src/tools/mapping.txt

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24003: kwaylandScanner produce version enum per class

2019-09-16 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Otherwise it only creates the enum for the first class encountered.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24003

AFFECTED FILES
  src/tools/generator.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24002: Sort files alphabetically in cmake list

2019-09-16 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Adding further files is confusing, since the list is almost alphabetical.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24002

AFFECTED FILES
  src/server/CMakeLists.txt

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23915: Improve documentation

2019-09-15 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6388d550e3a2: Improve documentation (authored by 
gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=66078=66150

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D23586: Improve code that detects useful elements in an Svg file

2019-09-14 Thread Frederik Gladhorn
gladhorn added inline comments.

INLINE COMMENTS

> svg.cpp:103
>  while (!reader.atEnd()) {
> -if (reader.readNext() == QXmlStreamReader::StartElement &&
> +const auto t = reader.readNext();
> +if (t == QXmlStreamReader::StartElement) {

Maybe use "element" instead of "t" as variable name?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23586

To: apol, #plasma, #frameworks
Cc: gladhorn, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23915: Improve documentation

2019-09-14 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 66078.
gladhorn retitled this revision from "Improve documentation

Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.

That DataDevice is for copy..." to "Improve documentation".
gladhorn edited the summary of this revision.
gladhorn added a comment.


  Thank you arc for messing up my commit message XD

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=66026=66078

BRANCH
  arcpatch-D23915_1

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D23917: Use const_iterator

2019-09-14 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:28841048d555: Use const_iterator (authored by gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=66021=66027

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

2019-09-14 Thread Frederik Gladhorn
gladhorn added inline comments.

INLINE COMMENTS

> romangg wrote in dpms.h:44
> Yea, maybe just write that this class is meant to create the DPMS object 
> below only. You already have the information you provided here there then.

I agree. The first two lines are actually repetitions and they don't say what 
the class is good for at all. I'll update this.

REPOSITORY
  R127 KWayland

BRANCH
  arcpatch-D23915

REVISION DETAIL
  https://phabricator.kde.org/D23915

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D23915: Improve documentationSome of the documentation did not say what the purpose of therespective class was, but rather gave a tautology.For people new to the code base it helps to mention thatDPMS

2019-09-14 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 66026.
gladhorn retitled this revision from "Add some docstrings" to "Improve 
documentation

Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.

That DataDevice is for copy...".
gladhorn edited the summary of this revision.
gladhorn added a comment.


  Updating D23915: Improve documentation
  ==
  
  Some of the documentation did not say what the purpose of the
  respective class was, but rather gave a tautology.
  For people new to the code base it helps to mention that
  DPMS is power management.
  
  That DataDevice is for copy...

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23915?vs=65941=66026

BRANCH
  arcpatch-D23915

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/datadevice_interface.h
  src/server/dpms_interface.h

To: gladhorn, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D23917: Use const_iterator

2019-09-14 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 66021.
gladhorn edited the summary of this revision.
gladhorn removed subscribers: broulik, zzag.
gladhorn added a comment.


  Fixed two missing spots

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=65946=66021

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns, broulik, 
zzag


D23917: Use const_iterator

2019-09-14 Thread Frederik Gladhorn
gladhorn added a comment.


  Yes, for me always using constBegin/constEnd makes reading the code slightly 
easier.

INLINE COMMENTS

> zzag wrote in registry.cpp:879
> constEnd

Thanks!

> zzag wrote in output_interface.cpp:119
> constEnd

Thanks!

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23917

To: gladhorn, #kwin
Cc: broulik, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D23917: Use const_iterator

2019-09-12 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 65946.
gladhorn added a comment.


  fixup

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23917?vs=65945=65946

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23917: Use const_iterator

2019-09-12 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When trivial, replace iterators with the const versrion.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23917

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/registry.cpp
  src/server/keyboard_interface.cpp
  src/server/output_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp
  tests/pasteclient.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23916: Remove capture of this in lambda

2019-09-12 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:858d9255f722: Remove capture of this in lambda (authored 
by gladhorn).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23916?vs=65943=65944

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp

To: gladhorn, #kwin, zzag, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23916: Remove capture of this in lambda

2019-09-12 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 65943.
gladhorn added a comment.


  Remove more lambda this captures

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23916?vs=65942=65943

BRANCH
  arcpatch-D23916

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/outputdevice_interface.cpp
  src/server/seat_interface.cpp

To: gladhorn, #kwin, zzag, broulik
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23916: Remove capture of this in lambda

2019-09-12 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When this is not used, there is no point in capturing it.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23916

AFFECTED FILES
  src/server/seat_interface.cpp

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23915: Add some docstrings

2019-09-12 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  When first reading the KWayland code, some explanations
  help getting around.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23915

AFFECTED FILES
  src/client/datadevice.h
  src/client/dpms.h
  src/server/dpms_interface.h

To: gladhorn, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


Re: libqaccessibilityclient now in kdereview

2019-03-07 Thread Frederik Gladhorn
On torsdag 7. mars 2019 14:45:50 CET Jonathan Riddell wrote:
> On Thu, 7 Mar 2019 at 05:20, Friedrich W. H. Kossebau  
wrote:
> > Soon it will be 2 years that libqaccessibilityclient entered kdereview,
> > and I just found it seems to be still in that state, at least by what
> > repo-metadata claims and given no emails to the thread which sonud like
> > review done I came across it when compiling kmag myself, where the
> > optional dep on this exists.
> 
> Thanks for your fixes.  I just spoke to Frederik on IRC who says I can
> the beaurocracy forward so I've filed a sysadmin ticket to move to
> extragear/libs and I guess I'll make a 0.4.0 change once that happens
> and try to get it onto build.kde.org.
> 

Thanks to all of you! I'm sorry for being so negligent here, I just don't find 
the time these days.

Cheers,
Frederik


> Jonathan






D14240: Improve API docs a bit

2018-07-20 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:9dd578b12d40: Improve API docs a bit (authored by 
gladhorn).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14240?vs=38116=38145

REVISION DETAIL
  https://phabricator.kde.org/D14240

AFFECTED FILES
  src/kdeclarative/qmlobject.h

To: gladhorn, #plasma, dhaumann, apol
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns


D14240: Improve API docs a bit

2018-07-20 Thread Frederik Gladhorn
gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  Some typos and make some sentences easier to read

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14240

AFFECTED FILES
  src/kdeclarative/qmlobject.h

To: gladhorn, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D14118: Improve "Remove this [widget]" text

2018-07-17 Thread Frederik Gladhorn
gladhorn accepted this revision.
gladhorn added a comment.
This revision is now accepted and ready to land.


  I'd say make the casing consistent, otherwise it's a clear improvement in my 
opinion.

INLINE COMMENTS

> containment.cpp:127
>  if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1", title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1 widget", title()));
>  }

The translation help says applet, is widget or applet the better word? But 
actually the "add new" dialog in plasma says widget, so I'm for that for 
consistency reasons.

> applet_p.cpp:124
>  if (closeApplet) {
> -closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1", q->title()));
> +closeApplet->setText(i18nc("%1 is the name of the applet", "Remove 
> this %1 Widget", q->title()));
>  }

This (Widget) is upper case (above it's lower case, which I prefer a tiny bit).

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-this-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14118

To: ngraham, #plasma, #vdg, gladhorn
Cc: gladhorn, kde-frameworks-devel, michaelh, ngraham, bruns


Re: libqaccessibilityclient now in kdereview

2017-07-26 Thread Frederik Gladhorn
Hi all,

On onsdag 26. juli 2017 08.11.18 CEST Ben Cooksley wrote:
> On Wed, Jul 26, 2017 at 9:18 AM, Mario Fux  wrote:
> > Am Dienstag, 25. Juli 2017, 14:55:42 CEST schrieb Albert Astals Cid:
> > 
> > Morning Albert
> 
> Hi Mario,
> 
> >> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell
> >> va
> >> 
> >> escriure:
> >> > libqaccessibilityclient is now in kdereview.  It's in a git repo
> >> > called libkdeaccessibilityclient but we filed a sysadmin request to
> >> > rename it.
> >> > 
> >> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released
> >> > in stable some years ago).
> >> 
> >> Do we really have to keep the Qt4 compatibility or can we kill it?
> > 
> > Please keep it for now as the next Simon release (0.5.0 which is on its
> > way) is still Qt4 based.
> 
> Simon is (for the moment at least) prohibited from depending on
> libqaccessibilityclient, because Extragear (as well as Plasma and
> Applications module) applications are not allowed to depend on code
> which is in Playground or KDE Review.

It's indeed completely optional and I'm not sure if the code in Simon is ready 
for prime time. Peter wrote it as an experiment (and it seems to more or less 
work), but I'm not sure how stable it actually is.

Cheers,
Frederik


> 
> > Thx
> > Mario
> 
> Cheers,
> Ben
> 
> >> Cheers,
> >> 
> >>   Albert
> >>   
> >> > What is it?
> >> > 
> >> > Since it's hard to grasp all the bits related to accessibility, I'll
> >> > try
> >> > to
> >> > explain what the lib is for.
> >> > Most of the stack is part of Qt 5, so nothing to worry about, that's
> >> > the
> >> > part that lets applications expose their UI over DBus for AT-SPI, so
> >> > they
> >> > work nicely with assisitve tools (e.g. Orca). In accessibility
> >> > language,
> >> > the applications act as "servers" and the screen reader for example is
> >> > a
> >> > client.
> >> > 
> >> > This library is for writing clients, so applications that are
> >> > assistive,
> >> > such as screen readers. It currently has two users: KMag and Simon.
> >> > KMag can use it to follow the focus (e.g. when editing text, it can
> >> > automatically magnify the part of the document where the cursor is.
> >> > 
> >> > For Simon Listens, the use is to be able to let the user trigger menus
> >> > and
> >> > buttons by voice input.




Re: libqaccessibilityclient now in kdereview

2017-07-25 Thread Frederik Gladhorn
On tirsdag 25. juli 2017 14.47.44 CEST Albert Astals Cid wrote:
> El dimarts, 25 de juliol de 2017, a les 13:25:39 CEST, Jonathan Riddell va
> 
> escriure:
> > libqaccessibilityclient is now in kdereview.  It's in a git repo
> > called libkdeaccessibilityclient but we filed a sysadmin request to
> > rename it.
> > 
> > We just released 0.2.0 in unstable (for some reason 0.1.1 was released
> > in stable some years ago).
> 
> What's your target? Frameworks? KDE Applications? Independent release?

It's closest to being a framework, considering that it's a tiny helper lib.

> 
> 
> It seems to have autotests but they are not run by either of these
>   ctest
>   make check
>   make test

Will look into that, thanks for the feedback!

Cheers,
Frederik

> 
> 
> 
> 
> AccessibleObject seems like a dumping group, having functions like
>   double maximumValue() const;
> and
> QString imageDescription() const;
> that if you read the description seems to me like they apply to "different
> types" of objects. Is it because it is mimic-ing the ATSPI API? Is there a
> way to have these things more split so they are grouped together more
> logically?
> 
> 
> 
> Interfaces supportedInterfaces() const;
> documentation is wrong, it says "return QStringList"
> 
> 
> Can we remove the commented functions, i.e. managesDescendants, isRequired,
> etc.?
> 
> 
> Thanks for pushing this forward :)
> 
> 
> Cheers,
>   Albert
> 
> > What is it?
> > 
> > Since it's hard to grasp all the bits related to accessibility, I'll try
> > to
> > explain what the lib is for.
> > Most of the stack is part of Qt 5, so nothing to worry about, that's the
> > part that lets applications expose their UI over DBus for AT-SPI, so they
> > work nicely with assisitve tools (e.g. Orca). In accessibility language,
> > the applications act as "servers" and the screen reader for example is a
> > client.
> > 
> > This library is for writing clients, so applications that are assistive,
> > such as screen readers. It currently has two users: KMag and Simon.
> > KMag can use it to follow the focus (e.g. when editing text, it can
> > automatically magnify the part of the document where the cursor is.
> > 
> > For Simon Listens, the use is to be able to let the user trigger menus and
> > buttons by voice input.




D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
This revision was automatically updated to reflect the committed changes.
Closed by commit R243:802d106c8e81: Add Conan files (authored by gladhorn).

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17127=17153

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn, dfaure
Cc: dfaure, apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 17127.
gladhorn marked an inline comment as done.
gladhorn added a comment.


  fix url

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17126=17127

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn marked 3 inline comments as done.
gladhorn added inline comments.

INLINE COMMENTS

> apol wrote in conanfile.py:5
> Can we re-use the version from the `CMakeLists.txt`?

The goal is to generate it.

> apol wrote in conanfile.py:7
> Re-use from metainfo.yml?

For now we consider this as a proof of concept.

> apol wrote in conanfile.py:9
> I don't understand what this means :(

building shared libs or static ones.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D6877

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 17126.
gladhorn added a comment.


  Updated according to comments

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17124=17126

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 17124.
gladhorn added a comment.


  remove -git from the version

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17118=17124

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 17118.
gladhorn added a comment.


  Fix license

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17116=17118

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn updated this revision to Diff 17116.
gladhorn added a comment.


  Remove private test stuff

REPOSITORY
  R243 KArchive

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6877?vs=17115=17116

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: apol, cfeck, #frameworks


D6877: Add Conan files

2017-07-24 Thread Frederik Gladhorn
gladhorn created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Conan is a C++ package manager. This is an experiment to make KF5
  frameworks available on Conan to make building KDE applications easier.
  See also https://conan.io/ .
  
  TODO:
  
  - detect version number automatically

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D6877

AFFECTED FILES
  conanfile.py
  test_package/CMakeLists.txt
  test_package/conanfile.py
  test_package/example.cpp

To: gladhorn
Cc: #frameworks


D6624: do not crash qaccessible by causing a resize in a resize event

2017-07-14 Thread Frederik Gladhorn
gladhorn added a comment.


  Considering that the Qt bug will not be fixed in the next few days (I hope to 
get around to it, but it's involved), this makes sense.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D6624

To: sitter, gladhorn
Cc: cfeck, anthonyfieroni, #frameworks


Re: Product versions on bugs.kde.org

2016-03-31 Thread Frederik Gladhorn
On Saturday, March 26, 2016 12:05:55 PM David Faure wrote:
> On Sunday 20 March 2016 18:43:04 Alexander Potashev wrote:
> > 2016-03-09 1:09 GMT+03:00 Kevin Funk <kf...@kde.org>:
> > > Added all versions from 5.5.0 to 5.19.0.
> > 
> > 5.20.0 is out, could you please add it to Bugzilla as well?
> 
> I have now integrated Jonathan's script into release-tools, and I ran it for
> 5.20.0. Works well.
> 
> There's just one issue: the bugzilla product for attica is called attica and
> not frameworks-attica, unlike all other frameworks.
> Should we rename the product in bugzilla, or adjust the script?

I think it's fine to rename the product.
 
> PS: we still have no official attica maintainer in metainfo.yaml,
> but the bugzilla component is assigned to Frederik Gladhorn.
> Frederik, can I write you down in metainfo.yaml as well?

I have been really inactive, if anyone else would be up for taking it, I'd be 
happy. I won't manage to work on attica realistically.

Cheers,
Frederik




Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-15 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122918/#review77498
---


Without testing anything, I think that this will break QWidget's file dialog 
when set to modal. Iirc this breaks for example the open dialogs in qt creator.

- Frederik Gladhorn


On March 12, 2015, 1:19 p.m., Marco Martin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122918/
 ---
 
 (Updated March 12, 2015, 1:19 p.m.)
 
 
 Review request for KDE Frameworks and Frederik Gladhorn.
 
 
 Bugs: 345002
 https://bugs.kde.org/show_bug.cgi?id=345002
 
 
 Repository: frameworkintegration
 
 
 Description
 ---
 
 Not sure it's the right approach, but right now, the FileDialog 
 QtQuickControls will be broken in the kde interqation if set as modal, see
 https://bugs.kde.org/show_bug.cgi?id=345002
 
 the commit 2ee76f0 makes show() not do anything in that case, and the 
 FileDialog QML bindings seems to assume to call only show()
 
 
 Diffs
 -
 
   src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 
 
 Diff: https://git.reviewboard.kde.org/r/122918/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Marco Martin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

2015-02-13 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122555/#review76006
---



src/notifybyktts.h
https://git.reviewboard.kde.org/r/122555/#comment52450

I have no idea how this is used, should it be i18n'ed? And Text to Speech


- Frederik Gladhorn


On Feb. 13, 2015, 3:11 a.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122555/
 ---
 
 (Updated Feb. 13, 2015, 3:11 a.m.)
 
 
 Review request for KDE Frameworks and Frederik Gladhorn.
 
 
 Repository: knotifications
 
 
 Description
 ---
 
 Add optional dependency on Qt5TextToSpeech for speech notifications.
 
 
 Diffs
 -
 
   CMakeLists.txt 208fd02153a0607e4cfbc02e4b289ef835cedbfd 
   src/CMakeLists.txt 6a3d81707a0e27e2d7bbfbf7f3924852ab737bf9 
   src/knotification.h c85621699793436442090b7f94ea82ef10c45b89 
   src/knotificationmanager.cpp affb6a673468bf6585cbda6fafdd008beb445cd9 
   src/kstatusnotifieritem.h 113dad513c320ef97f59b221b3541ca2f388693e 
   src/notifybyktts.h 43756f776678bd7700a77a3357577363b36d2542 
   src/notifybyktts.cpp a2a15a9c77089527f54dfc63f13699d44336dda1 
   src/notifybyspeech.cpp PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/122555/diff/
 
 
 Testing
 ---
 
 As I said in the knotifyconfig review something at runtime isn't 
 refreshing/reloading the config when it is changed. Otherwise this works fine 
 when QtSpeech is available.
 
 QtSpeech is still in development, so this change is added as an optional 
 dependency.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Frederik Gladhorn


 On Feb. 13, 2015, 11:49 a.m., Aleix Pol Gonzalez wrote:
  +1
  
  What's the status of QtSpeech?
 
 Jeremy Whiting wrote:
 I'll blog about it shortly.

I think QtSpeech is Qt 5.6 material realistically. It's usable on most 
platforms but needs cleanup and API review and a couple of features are not 
done on all platforms.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/#review75983
---


On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122554/
 ---
 
 (Updated Feb. 13, 2015, 7:42 p.m.)
 
 
 Review request for KDE Frameworks and Frederik Gladhorn.
 
 
 Repository: knotifyconfig
 
 
 Description
 ---
 
 Change config from KTTS to Speech.
 If QtSpeech is available when building return true from have_speech static 
 method.
 Otherwise return false.
 Could also add a check to see if there are any backend errors later on.
 
 
 Diffs
 -
 
   CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 
   src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 
   src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 
   src/knotifyconfigactionswidgetbase.ui 
 cbe647b70eb41ba540b7bf6d87f519b3246973a1 
   src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 
   src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b 
   src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 
 
 Diff: https://git.reviewboard.kde.org/r/122554/diff/
 
 
 Testing
 ---
 
 It builds, the config widget shows, the icon for speech is properly showing 
 when that configuration is enabled. Speech from konversation's new message 
 notifications are spoken.
 
 Something strange here:
 After enabling this notification, no messages are spoken until restarting the 
 application with the notifications (konversation in my test case).
 Similarly, after disabling this notification, messages are still spoken until 
 restarting the application.
 I checked and the konversation.notifyrc file is getting updated, but for some 
 reason the changes aren't taking effect imediately yet.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

2015-02-13 Thread Frederik Gladhorn


 On Feb. 13, 2015, 12:17 p.m., Martin Klapetek wrote:
  src/knotifyconfigactionswidgetbase.ui, line 141
  https://git.reviewboard.kde.org/r/122554/diff/1/?file=348626#file348626line141
 
  Is Jovie still used in QtSpeech? If not, it should be removed from here

I tend to agree to TTS or even better Text to Speech/Text-To-Speech.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122554/#review75987
---


On Feb. 13, 2015, 7:42 p.m., Jeremy Whiting wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/122554/
 ---
 
 (Updated Feb. 13, 2015, 7:42 p.m.)
 
 
 Review request for KDE Frameworks and Frederik Gladhorn.
 
 
 Repository: knotifyconfig
 
 
 Description
 ---
 
 Change config from KTTS to Speech.
 If QtSpeech is available when building return true from have_speech static 
 method.
 Otherwise return false.
 Could also add a check to see if there are any backend errors later on.
 
 
 Diffs
 -
 
   CMakeLists.txt f5aa0e78d89a4c14c3acfd9384b100e507e30067 
   src/knotifyconfigactionswidget.h 88b341a909d466b8eaf065c5220ac05f8c963697 
   src/knotifyconfigactionswidget.cpp 27012e3b803ef0a99d5bafcebea270e2d7419d62 
   src/knotifyconfigactionswidgetbase.ui 
 cbe647b70eb41ba540b7bf6d87f519b3246973a1 
   src/knotifyconfigelement.h 703952d23d1622e4b6214acc52461ea75b480254 
   src/knotifyconfigelement.cpp 5a1ac57fa5a4139682327d14c55a489450ea956b 
   src/knotifyeventlist.cpp 148bca7d33c722a4aeecabac45286a5e501c81b3 
 
 Diff: https://git.reviewboard.kde.org/r/122554/diff/
 
 
 Testing
 ---
 
 It builds, the config widget shows, the icon for speech is properly showing 
 when that configuration is enabled. Speech from konversation's new message 
 notifications are spoken.
 
 Something strange here:
 After enabling this notification, no messages are spoken until restarting the 
 application with the notifications (konversation in my test case).
 Similarly, after disabling this notification, messages are still spoken until 
 restarting the application.
 I checked and the konversation.notifyrc file is getting updated, but for some 
 reason the changes aren't taking effect imediately yet.
 
 
 Thanks,
 
 Jeremy Whiting
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Projects for Students wanted!

2014-09-11 Thread Frederik Gladhorn
On Tuesday, September 09, 2014 10:57:44 AM Stefan Derkits wrote:
 Hey all,
 
 I'm a Teaching assistant for the course Advanced Software Engineering at
 the Vienna University of Technology.
 
 It is a course for master students in Software Engineering. In this
 course the students have to run a project in a group of 4 - 6 people. As
 they can choose freely what project they want to do (if the scope is big
 enough) I was thinking of showing them some projects they could do in
 KDE, because most of the self choosen projects are actually pretty boring ;)
 
 The scope of the project is the following:
 -) one to three distinct bigger features should be added to an
 application (like in GSoC or SoK)
 -) ideally these features would include every layer of the application
 (so not only backend or GUI)
 -) enough for 4 - 6 Students to work a total of 140 hours per student
 (including project managment) between October and January
 -) some students may have experience with C++/Qt, some not. But we
 anyways offer a C++  Qt crashcourse for another Bachelor level course.
 -) they already have good programming knowledge (mostly Java) and
 attended a basic Software Engineering course where they did a
 preselected project
 
 What do I need from you?
 
 You have a project that could need some help? You can make or already
 have a small description of your feature? The project fits into the
 scope described above? Either you or someone else in your project can
 mentor (like the GSoC or SoK mentors) the students?
 
 Then write me with the following data:
 
 -) Small Description of the project (all of them will be presented to
 students in the preliminary discussion)
 -) Mentor for this project

Hi Stefan,

there are some exciting projects of various difficulties for the accessibility 
project. I just wrote about them. Let me know if you/your students are 
interested.

https://forum.kde.org/viewtopic.php?f=216t=122808

Cheers,
Frederik


 
 If you have any questions, feel free to contact me (HorusHorrendus @
 IRC, personally @ Akademy in the hacking room)
 
 Stefan


 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 


Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

2014-03-26 Thread Frederik Gladhorn
Hello,

we will have a Qt Contributors' Summit again.

The event is invite only, but I think many people on these lists qualify for 
the event. Especially if you have lately been submitting patches through 
gerrit or otherwise been involved with Qt developement consider joining.

This is a great chance to influence many things in Qt directly with great 
discussions. Also a great start to getting deeper involved of course ;)

See the forwarded mail for details.

-- 
Best regards,
Frederik Gladhorn
Senior Software Engineer - Digia, Qt
Visit us on: http://qt.digia.com
---BeginMessage---
Hello,

Qt Contributors' Summit is coming!
This year the summit will be organized in the Estrel Convention center in 
Berlin on 10-11th June.

Please see the event wiki for details: 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki

Participation to the event is limited and based on merit in the Qt project. 
Priority is given to Maintainers and Approvers, but everyone who has 
contributed to the success of the project in any way can apply for an 
invitation.

To request an invitation to the event, please use the following form:  
https://www.webropolsurveys.com/S/7CB14527039843C9.par
Be sure to fill in why you should be invited. The request page will be open 
through April and after closing the form, we will send out invitations as soon 
as possible.

Best regards,
Tero Kojo
Qt Online Community Manager, Digia
QtCS 2014 event coordinator

P.S. If your company would like to help make the event even better by 
sponsoring, see the wiki sponsoring page 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki/Sponsorship and 
contact me (Tero Kojo) for details.
___
Development mailing list
developm...@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
---End Message---
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Fwd: [Development] Qt Contributors' Summit 2014 in Berlin 10-11th June

2014-03-25 Thread Frederik Gladhorn
Hello,

we will have a Qt Contributors' Summit again.

The event is invite only, but I think many people on these lists qualify for 
the event. Especially if you have lately been submitting patches through 
gerrit or otherwise been involved with Qt developement consider joining.

This is a great chance to influence many things in Qt directly with great 
discussions. Also a great start to getting deeper involved of course ;)

See the forwarded mail for details.

-- 
Best regards,
Frederik Gladhorn
Senior Software Engineer - Digia, Qt
Visit us on: http://qt.digia.com
---BeginMessage---
Hello,

Qt Contributors' Summit is coming!
This year the summit will be organized in the Estrel Convention center in 
Berlin on 10-11th June.

Please see the event wiki for details: 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki

Participation to the event is limited and based on merit in the Qt project. 
Priority is given to Maintainers and Approvers, but everyone who has 
contributed to the success of the project in any way can apply for an 
invitation.

To request an invitation to the event, please use the following form:  
https://www.webropolsurveys.com/S/7CB14527039843C9.par
Be sure to fill in why you should be invited. The request page will be open 
through April and after closing the form, we will send out invitations as soon 
as possible.

Best regards,
Tero Kojo
Qt Online Community Manager, Digia
QtCS 2014 event coordinator

P.S. If your company would like to help make the event even better by 
sponsoring, see the wiki sponsoring page 
http://qt-project.org/groups/qt-contributors-summit-2014/wiki/Sponsorship and 
contact me (Tero Kojo) for details.
___
Development mailing list
developm...@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
---End Message---


Re: KSpeech

2014-03-10 Thread Frederik Gladhorn
Torsdag 6. mars 2014 20.34.05 skrev Christoph Feck:
 On Thursday 06 March 2014 17:13:19 Jeremy Whiting wrote:
  On Thu, Mar 6, 2014 at 6:43 AM, Frederik Gladhorn gladh...@kde.org
 
 wrote:
   Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting:
   3. user configurability (As a user I can't set up which voice I
   would like all speech-using applications to use)
   
   As with other Qt libs, this is more for the platform to set up.
   Currently qtspeech uses whatever voice is selected system wide
   (aka the default). I think that is the right approach - follow
   what we get from the platform. For KDE I'd thus suggest creating
   a configuration module which lets the user choose the platform
   defaults.
  
  Yeah, each platform could have its own configuration of the
  defaults sure, the only part missing is a real-time configuration
  change. For example if Jovie is reduced to a kcm to configure
  speech-dispatcher's default voice and I start listening to a pdf
  from okular or something and decide I need the pitch to be lower,
  changing the default voice wont change the voice that
  speech-dispatcher is already using to read the pdf.  Maybe that
  could be fixed with a patch to speech-dispatcher to accept
  immediate default changes though, I'll have to think about that.
 
 Let me refer to http://www.w3.org/TR/2011/WD-css3-speech-20110419/
 which defines attributes a web page can use to influence speech. Would
 be nice if we had API supporting web speech.

This is interesting in that different synths have already some sort of support 
for this.

 
 Regarding voice selection, it would be very useful to allow the
 application to specify female/male/child voice via API (in addition to
 the ability to let the user reconfigure actual voices). Similar to
 letting the application request Sans, Sans Serif, and Monospaced font.

 For example, when generating different voices while reading out e-book
 stories.


Makes sense. I'd like to get an overview over the native APIs first.
Let's collect their capabilities and then try to come up with a sensible 
compromise.
Feel free to gather data here:
http://qt-project.org/wiki/QtSpeech

Cheers,
Frederik

 
 Christoph Feck (kdepepo)

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: KSpeech

2014-03-06 Thread Frederik Gladhorn
Onsdag 5. mars 2014 23.04.12 skrev Jeremy Whiting:
 Took a quick read through that just now and it looks pretty promising
 from what I saw. I guess I don't know my way around gerrit very well
 because I couldn't see a place to comment on the code like
 reviewboard.
 Really the only difference between jovie and that class are the following:
 1. jovie has some old code and ui to control jobs at a fine grain that
 spd doesn't expose really well, so I left it out when I ported ktts to
 spd.

I would like to expose voices and languages in a sensible fashion. This is 
tricky to get right cross-platform. I started with something on Linux but 
decided to implement other backends first before attempting to implement voice 
selection.
For language/locale I think qtspeech should default to the system locale and 
let the user select a different one.

 2. user defined filters with some sane/useful defaults (if we were to
 use QtSpeech for kde notifications, set konvi to speak all messages,
 there's not a way to let the user say change jpwhiting fregl: you
 rock into jpwhiting says fregl you rock)

Maybe. I'd rather keep qtspeech very simple. My goals where to make it a tiny 
library that is lean, fast and async by using signals and slots.
I want it to be good enough to be used in apps that use voice navigation, but 
also when writing a screen reader. Some level of configuration is required in 
any case. Let's come up with a good api that makes sense across platforms, 
then I'm in.

 3. user configurability (As a user I can't set up which voice I would
 like all speech-using applications to use)

As with other Qt libs, this is more for the platform to set up. Currently 
qtspeech uses whatever voice is selected system wide (aka the default). I 
think that is the right approach - follow what we get from the platform. 
For KDE I'd thus suggest creating a configuration module which lets the user 
choose the platform defaults.

 4. dbus, though this isn't as important if each application that uses
 speech links to the library and speech-dispatcher or the system apis
 do the async for us already anyway as you said.
I don't see a point in adding dbus into the mix indeed. One thing that is 
interesting though is what kind of effect you get when opening the speech 
backend from two apps at the same time.

 Items 1 and 4 will be irrelevant in a KF5 world but I'm wondering how
 2 and 3 could be added either to qtspeech itself or as a kspeech
 library that wraps qtspeech for kde applications to use.
 
 Any thoughts on that? I would be pretty interested in helping with
 qtspeech if it greatly simplifies or even deprecates jovie as it looks
 like it could do possibly.

I'd be more than happy to get contributions of course. I cannot promise much 
from my side, of course I'd like to continue working on this project as time 
permits (so far it really is a spare time thing).

Greetings,
Frederik


 Jeremy
 
 On Wed, Mar 5, 2014 at 12:29 PM, Frederik Gladhorn gladh...@kde.org wrote:
  On Tuesday 4. March 2014 16.43.10 Jeremy Whiting wrote:
  Hello all, I've realized a bit ago that kspeech was not included in
  
  the kdelibs split (probably because it was in staging at the time and
  
  didn't conform to the other framework policies yet). I've cleaned it
  
  up a bit and put it in my scratch space, but have some architectural
  
  questions about it before I make it a proper framework.
  
  
  
  1. The KSpeech dbus interface is old and showing its age. Many of the
  
  methods are no longer implemented in the application itself since it
  
  was ported to speech-dispatcher. One thing I would definitely like to
  
  do is clean up/remove methods that aren't implemented currently (and
  
  possibly re add some later on if speech-dispatcher gets better/more
  
  support for job control, etc.) So the question about this is is KF5
  
  time a good time to drop/clean up the dbus interface?
  
  
  
  2. The KSpeech interface that was in kdelibs/interfaces is just that a
  
  dbus interface only. I would like to make it a proper
  
  library/framework with a QObject based class for talking to Jovie (the
  
  application that implements the KSpeech dbus interface) and wonder if
  
  other things such as what's currently in jovie/libkttsd should be in
  
  the kspeech library also. If I move code from jovie into libkspeech
  
  (or merge kspeech interface into libkttsd and make libkttsd a
  
  framework likely renamed to libkspeech since libkttsd isn't a public
  
  library anyway and has the old ktts name) what's the best way to
  
  preserve the history of both the kspeech interface and libkttsd
  
  sources. Didn't the plasma or kde-workspaces split do something fancy
  
  with git where old history pointed to the old git repo somehow?
  
  Along with this, if libkspeech is defining the kspeech dbus interface
  
  and has a class to talk to that interface, does the interface still
  
  need to be in servicetypes like

Re: kf5 alpha 1 : attica?

2014-02-05 Thread Frederik Gladhorn
On Thursday 6. February 2014 00.29.45 David Faure wrote:
 Frederik wrote:
  From my point of view, please just go ahead and change it as you think is
  sensible.
 
 OK, thanks for the green lights, I went ahead:
 
 * Qt4 support for attica is now in the qt4 branch
 
 * Attica master is now qt5 only, and requires ECM.
 
 * It gained all the bells and whistles of being a proper framework:
 camelcase forwarding headers, version upgrade to 4.96.0, .pri file, etc.
 And, being released together with the other frameworks.
 
 
 The only thing that makes attica an odd duck compared to the other
 frameworks is that we can't yet move it under the frameworks/ hierarchy
 because that would break the Qt4 build scripts.
 
 So, all KF5 hackers, please note that whenever making a change across all
 frameworks you should also remember attica, outside your frameworks/
 subdir.

Thanks a lot, I really appreciate it.

Greetings,
Frederik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Please review QAccessibilityClient

2014-01-13 Thread Frederik Gladhorn
Mandag 13. januar 2014 02.24.30 skrev Albert Astals Cid:
 El Divendres, 3 de gener de 2014, a les 22:09:04, Frederik Gladhorn va
 
 escriure:
  Hi,
  
  Mario Fux asked if I could make a release of libqaccessibilityclient. When
  I started this little lib it was seemingly KDE only but with a bit of
  help, mostly from Sebastian Sauer it became a nice little Qt only lib.
 
 FWIW I gave it a look last week and from my I know nothing about the
 domain, it looks good.

Thanks, I'll make a release the next days, we can always bump the major 
version number later.

If someone feels like helping out rolling tarballs or testing them that would 
be appreciated.

Greetings
Frederik


 
 Cheers,
   Albert
 
  It makes writing accessibility tools easy by providing a convenient API
  over the rather tedious DBus AT-SPI standard. That means it works with
  Gnome, KDE/Qt apps and potentially others. Simon started to depend on it
  and the KWin focus tracking works with it as well.
  
  There is a fun example app that comes with the lib, it demonstrates a bit
  what the library provides. There are two classes Registry to provide the
  subscription to changes and AccessibleObject which represents one
  widget.
  Together they give a lot of information about running apps and are a nice
  basis for further helpful technology.
  
  The code can be found here:
  git://anongit.kde.org/libkdeaccessibilityclient
  
  I haven't had much time to work on it, but spent a bit of time cleaning it
  up today. The functions are generally documented and I'd be very happy
  about feedback/reviews.
  
  If there are no major blockers/improvement suggestions I'd like to make a
  release soon. If someone is looking for a fun and interesting new task, I
  would be happy with some help to get this baby out.
  
  Greetings,
  Frederik



Please review QAccessibilityClient

2014-01-03 Thread Frederik Gladhorn
Hi,

Mario Fux asked if I could make a release of libqaccessibilityclient. When I 
started this 
little lib it was seemingly KDE only but with a bit of help, mostly from 
Sebastian 
Sauer it became a nice little Qt only lib.

It makes writing accessibility tools easy by providing a convenient API over 
the rather 
tedious DBus AT-SPI standard. That means it works with Gnome, KDE/Qt apps and 
potentially others. Simon started to depend on it and the KWin focus tracking 
works 
with it as well.

There is a fun example app that comes with the lib, it demonstrates a bit what 
the 
library provides. There are two classes Registry to provide the subscription 
to 
changes and AccessibleObject which represents one widget.
Together they give a lot of information about running apps and are a nice basis 
for 
further helpful technology.

The code can be found here:
git://anongit.kde.org/libkdeaccessibilityclient

I haven't had much time to work on it, but spent a bit of time cleaning it up 
today. 
The functions are generally documented and I'd be very happy about 
feedback/reviews.

If there are no major blockers/improvement suggestions I'd like to make a 
release 
soon. If someone is looking for a fun and interesting new task, I would be 
happy with 
some help to get this baby out.

Greetings,
Frederik




Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-10-27 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated Oct. 27, 2013, 6:46 p.m.)


Status
--

This change has been discarded.


Review request for kdelibs.


Repository: kdelibs


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn



Review Request 110042: Find Qt5 version of DBusMenuQt

2013-04-16 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn



Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-04-16 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated April 16, 2013, 1:26 p.m.)


Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn



Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-04-16 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110042/
---

(Updated April 16, 2013, 1:26 p.m.)


Review request for kdelibs.


Description
---

Build fix for dbusmenu qt5 changes.
This appends the 5 to include path and lib dir in the find module.
Also rename the whole thing to not conflict with the Qt 4 version.


Diffs
-

  CMakeLists.txt 00402d4 
  cmake/modules/FindDBusMenuQt.cmake 5af70ef 
  cmake/modules/FindDBusMenuQt5.cmake PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110042/diff/


Testing
---


Thanks,

Frederik Gladhorn



Re: Review Request 110042: Find Qt5 version of DBusMenuQt

2013-04-16 Thread Frederik Gladhorn
On Tuesday 16. April 2013 16.30.15 Rolf Eike Beer wrote:
 Am Dienstag 16 April 2013, 13:26:23 schrieb Frederik Gladhorn:
  ---
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/110042/
  ---
  
  Review request for kdelibs.
  
  
  Description
  ---
  
  Build fix for dbusmenu qt5 changes.
  This appends the 5 to include path and lib dir in the find module.
  Also rename the whole thing to not conflict with the Qt 4 version.
 
 Since DBusMenuQt5 is obviously a rather new thing I would vote for putting a
 DBusMenuQt5Config.cmake into that project itself and install that. That
 would allow everyone to use it with CMake once the module itself is
 installed, without any need for a Find*.cmake module.

I agree, that would make sense. If anyone is up for doing that (the code is in 
launchpad) feel free to do so, I will not get around to doing that. I can 
abandon this patch in favor of the Config.cmake file.

I mostly wanted to build kdelibs-frameworks and this patch is actually pretty 
small (I just renamed the .cmake file for clarity's sake).

Greetings
Frederik

 
 Eike

Re: Review LibKdeAccessibilityClient

2012-10-15 Thread Frederik Gladhorn
Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf:
 On Thursday 04 October 2012, Frederik Gladhorn wrote:
  Hi,
  
  so after we took the time to hack a bit more on the library in Randa,
  I would be happy about more comments.
 
 Why does it use KDEPIMLIBS_INSTALL_DIR ?
 
 macro(MAKE_INSTALL_PATH_ABSOLUTE out in)
if (IS_ABSOLUTE ${in})# IS_ABSOLUTE is new since cmake 2.4.8
   set(${out} ${in})
else()
   set(${out} \${KDEPIMLIBS_INSTALL_DIR}/${in})
endif()
 endmacro(MAKE_INSTALL_PATH_ABSOLUTE out in)
 
 
 I would have expected ${CMAKE_INSTALL_PREFIX}.
Thanks, fixed.

Greetings
Frederik

 
 Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review LibKdeAccessibilityClient

2012-10-15 Thread Frederik Gladhorn
Søndag 7. oktober 2012 21.45.17 skrev Alexander Neundorf:
 On Thursday 04 October 2012, Frederik Gladhorn wrote:
  Hi,
  
  so after we took the time to hack a bit more on the library in Randa,
  I would be happy about more comments.
 
 Why does it use KDEPIMLIBS_INSTALL_DIR ?
 
 macro(MAKE_INSTALL_PATH_ABSOLUTE out in)
if (IS_ABSOLUTE ${in})# IS_ABSOLUTE is new since cmake 2.4.8
   set(${out} ${in})
else()
   set(${out} \${KDEPIMLIBS_INSTALL_DIR}/${in})
endif()
 endmacro(MAKE_INSTALL_PATH_ABSOLUTE out in)
 
 
 I would have expected ${CMAKE_INSTALL_PREFIX}.
Thanks, fixed.

Greetings
Frederik

 
 Alex


Re: Review LibKdeAccessibilityClient

2012-10-04 Thread Frederik Gladhorn
Hi,

so after we took the time to hack a bit more on the library in Randa,
I would be happy about more comments.

The plan is to use it for our tools (currently Simon and Magnifier),
so the only thing I didn't do is to change it to depend on ECM.

I find the CMake part is quite nice now, it doesn't even require the tedious 
FindFoo.cmake files, instead it uses the target-exporting feature of cmake 
that Alex suggested (good stuff indeed).

After realizing it was Qt only, we were bold enough to rename it to 
QAccessibilityClient.

Especially Peter reviewing and using it for Simon makes me feel relatively 
good about the lib, since it confirms its usefullness. The manual test in 
there is turning into a full accessibility debugging tool, another thing 
turning out better than I initially expected :) Give it a look when bored, 
it's fun to play with and works with Gnome and KDE apps (assuming you have qt-
at-spi and libatspi2).

Greetings
Frederik

On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote:
 Hello,
 
 On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote:
  Feedback is much appreciated.
 
 If you aim at releasing with KDE Frameworks, I would like to see the
 following happening:
  * Stick to the new CMake ways we use in KDE Frameworks (means depending
 on CMake 2.8.9 and ECM 0.0.5 for now);
  * Fix the issues raised by Alex (obviously);
  * Change the name to kaccessibilityclient to be more aligned with how we're
 naming the other frameworks.
 
 The first point could be a problem I guess if you aim at releasing before
 KDE Frameworks 5.0 as ECM is not widespread in distros yet.
 
 My 0.02€
 
 Regards.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review LibKdeAccessibilityClient

2012-10-04 Thread Frederik Gladhorn
Hi,

so after we took the time to hack a bit more on the library in Randa,
I would be happy about more comments.

The plan is to use it for our tools (currently Simon and Magnifier),
so the only thing I didn't do is to change it to depend on ECM.

I find the CMake part is quite nice now, it doesn't even require the tedious 
FindFoo.cmake files, instead it uses the target-exporting feature of cmake 
that Alex suggested (good stuff indeed).

After realizing it was Qt only, we were bold enough to rename it to 
QAccessibilityClient.

Especially Peter reviewing and using it for Simon makes me feel relatively 
good about the lib, since it confirms its usefullness. The manual test in 
there is turning into a full accessibility debugging tool, another thing 
turning out better than I initially expected :) Give it a look when bored, 
it's fun to play with and works with Gnome and KDE apps (assuming you have qt-
at-spi and libatspi2).

Greetings
Frederik

On Thursday 23. August 2012 22.41.46 Kevin Ottens wrote:
 Hello,
 
 On Thursday 16 August 2012 09:29:27 Frederik Gladhorn wrote:
  Feedback is much appreciated.
 
 If you aim at releasing with KDE Frameworks, I would like to see the
 following happening:
  * Stick to the new CMake ways we use in KDE Frameworks (means depending
 on CMake 2.8.9 and ECM 0.0.5 for now);
  * Fix the issues raised by Alex (obviously);
  * Change the name to kaccessibilityclient to be more aligned with how we're
 naming the other frameworks.
 
 The first point could be a problem I guess if you aim at releasing before
 KDE Frameworks 5.0 as ECM is not widespread in distros yet.
 
 My 0.02€
 
 Regards.


Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-09-22 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review19320
---

Ship it!


We just discussed and Aman will push the change now. It is working for several 
people and should not incur any penalty for users not using accessibility. 
Further work will happen as incremental changes.

- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-09-22 Thread Frederik Gladhorn
Hello Frank,

On Sunday 23. September 2012 00.10.38 Frank Reininghaus wrote:
 Hi everyone,
 
 2012/9/22 Frederik Gladhorn:
  This is an automatically generated e-mail. To reply, visit:
  http://git.reviewboard.kde.org/r/105972/
  
  Ship it!
 
 in my opinion, the Ship It! button should be pressed only by the
 maintainer or another core developer of the application. I have
 clearly stated in my review that some parts of the request are not
 acceptable in the current form, in particular adding the public
 function KItemListView::layouter().
I forgot this was an open point. We will look into this tomorrow, maybe we can 
find a solution that you will find acceptable.

 I have offered to test the new
 feature and then change the public API of the affected classes in a
 better way, but nobody bothered to comment on my statement that the
 build system of KMag, which is required to test the feature, is broken
 and that I can't build it. Maybe you expected me to fix KMag myself. I
 could have done this, of course, but I really don't have much time for
 working on Dolphin, and I prefer to spend it working on the items on
 my own (very long) TODO-list.
 
 What I find even more unfortunate than the unacceptable unautorised
 push is the way the changes show up in the history now. I actually
 like tools like git log, git blame, and qgit a lot, I like it when
 the history looks clean, and I always thought that the main point of
 review requests is to bring the proposed change in a form that can be
 included in one, or maybe a few, logically structured commits. But the
 history is now a big ugly mess. Having commits like, e.g.,
 
 https://projects.kde.org/projects/kde/kde-baseapps/repository/revisions/e6d4
 a935c8d03dcfda65e0b2f92d243b18a411e3/diff
 
 in the repository is really pointless. I know that this commit has
 been done after comments from me, but the version of the files that
 did not respect the coding style should not have been pushed to the
 public repository in the first place. The space that these dozens of
 pointless commits take up in the repository is maybe not a big concern
 nowadays, but they make examining the history (which I sometimes do to
 find the cause of a regression) very, very painful.

I completely agree. Sorry for the big mess, we'll be more careful to rebase 
and squash the next time.

 
 Well, the damage has been done, and there is no way to fix it now. But
 I kindly ask you not to do any major changes in Dolphin code, in
 particular changes in header files, ever again without discussing this
 with the Dolphin core maintainers and getting approval. Thanks for
 your understanding.
Sorry again.

 
 Another point that we have not discussed yet is who will maintain the
 accessibility classes in the future. If this code is included in
 Dolphin, I want to know who will take care of any bugs that users will
 find.
I assume Amandeep will keep an eye on this area. I will try to fix bugs when it 
comes to accessibility myself as much as I can, so please ask me to fix 
regressions in the code.

Greetings
Frederik


 
 Frank


Review Request: Only show the screen config changed message once.

2012-08-26 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106212/
---

Review request for KDE Base Apps and Alex Fiestas.


Description
---

The dialog from the kded would show up once for each event (eg unpluggin and 
pluggin in again) related to monitor changes.
I wonder what the #warning Modal dialog, stupid, fix. was supposed to fix.
The dialog was redone since it's actually not very easy to re-use KMessageBox 
in a non-modal way.


Diffs
-

  kcontrol/randr/module/randrmonitor.h 057c991 
  kcontrol/randr/module/randrmonitor.cpp 32d0d0a 

Diff: http://git.reviewboard.kde.org/r/106212/diff/


Testing
---


Thanks,

Frederik Gladhorn



Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-08-23 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17923
---



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14142

You are right.


- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-08-21 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17795
---



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14034

The spaces are weird in this line.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14035

I think increasing by one is wrong here.
eg 9 items in 3 rows and 3 columns would return 4 here.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment14036

Sibling is not very important. It will be removed in Qt 5 and can be 
ignored. But you can leave it for now.


- Frederik Gladhorn


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-08-21 Thread Frederik Gladhorn


 On Aug. 14, 2012, 3:44 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.h, line 143
  http://git.reviewboard.kde.org/r/105972/diff/3/?file=77712#file77712line143
 
  This class isn't needed any more, is it?
 
 Amandeep Singh wrote:
 This class is needed since the accessibility interface tree, as is shown 
 by Accerciser in dolphin will then never expand upto the Table Interface we 
 wrote. Basically QAI is present for the QWidgets and a11y clients can 
 navigate their children. 
 
 Since the KItemListView is a QGraphicsWidget, so accerciser is unable to 
 reach it directly. The class in question, KItemListContainerA11y provides 
 this connection to KItemListView.
 
 Frank Reininghaus wrote:
 OK, but then I wonder if my previous statement that the changes you had 
 proposed in KItemListContainer in the first version of your patch are not 
 needed is correct. I'm not familiar with QAccessible, but I can't see how any 
 code is supposed to construct or call methods of a 
 KItemListContainerAccessible (which is required if I understand you correctly 
 because the QAccessible framwork cannot reach KItemListViewAccessible 
 directly) in the current version of your patch. But maybe I got something 
 wrong.
 
 In other words: have you checked that the current version of the patch is 
 still working correctly?

The way the accessible objects are constructed is in 
QAccessible::queryAccessibleInterface. There are factories (and this patch adds 
a new one for the KItemListContainerA11y and KItemListViewAccessible) that get 
queried. It works by using QObject introspection and comparing the class name 
to what the factories support.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17396
---


On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 17, 2012, 11:20 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt afc190f 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




Review LibKdeAccessibilityClient

2012-08-16 Thread Frederik Gladhorn
Hi,
a few of us trying to improve accessibility of KDE worked on a little library, 
LibKdeAccessibilityClient.

What it does is making the AT-SPI over DBus protocol easy to use for KDE apps. 
This is the accessibility framework that we share with Gnome. It enables two 
way communication between apps and assistive tools. The first users for it 
would be the magnifiers in KWin and KMag - they can follow the focus with it. 
Further users will be screen readers and Simon with the AT-SPI plugin to 
dynamically create vocabulary for the running application's actions.

I'd like to ask for initial review in order to move this tiny lib to 
kdesupport/frameworks. It's Qt-only and actually only consists of two public 
classes. Due to the underlying AT-SPI being Linux-only it's not cross platform 
in the sense that a windows implementation would need a completely different 
backend (IAccessible(2) or UIA). At this time there is not much sense in that 
since accessibility tools on Windows are more advanced at the moment and not 
something we are interested in providing at this time.

We'll be writing up a nice tutorial on techbase the next days, for now the 
library comes with a few auto-tests and one example application that lets one 
browse the running applications accessibility interfaces.

Some of the improvements in that library were made by Amandeep as part of his 
summer of code project (with Sebastian mentoring).

Feedback is much appreciated.

Greetings
Frederik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-08-14 Thread Frederik Gladhorn


 On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.h, line 16
  http://git.reviewboard.kde.org/r/105972/diff/2/?file=77302#file77302line16
 
  On the other hand, I see lots of QModelIndex and friends here, which is 
  something I don't particularly like. After all, the basic idea of the new 
  view engine is to get rid of Qt's itemviews.
  
  Is there an easy way to do it without Qt's itemviews?
 
 Frederik Gladhorn wrote:
 This is a very good point. For Qt 4 there is no way to avoid QModelIndex 
 since it's in the public API. I will look into this for Qt 5 since it's 
 definitively something we don't want to rely on.
 
 Frank Reininghaus wrote:
 It would be nice if the Qt itemviews dependency could be dropped with Qt 
 5.
 
 Concerning the public API: the Qt docs don't seem to contain anything 
 about QAccessibleTable2Interface and QAccessibleObjectEx, or am I missing 
 something?

I just checked, Qt 5 doesn't have QModelIndex in the API any more, we actually 
cleaned that up.
Regarding documentation: We never officially committed to the IAccessible2 like 
interfaces for Qt 4, so they are marked as internal, you can find some 
documentation in src/gui/qaccessible2.cpp (a little in Qt 4 and some more up to 
date one in Qt 5). Currently our plan is to make it official in Qt 5.1. This 
implementation is actually very good to validate what is problematic with the 
APIs, thus I'm happy for the feedback.


 On Aug. 13, 2012, 2:50 p.m., Frank Reininghaus wrote:
  dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 67
  http://git.reviewboard.kde.org/r/105972/diff/2/?file=77303#file77303line67
 
  I think this will fail when grouping is enabled.
 
 Frederik Gladhorn wrote:
 Frank, maybe you can give some guidance here. I didn't have time to 
 carefully read the KItemListView etc code, but for me the row/column 
 count/positions etc were a bit off. I wonder if there is a general problem in 
 the code or maybe just an off-by-one somewhere.
 
 Frank Reininghaus wrote:
 You're right, the rowCount issue is more tricky than it looks at first 
 sight, at least when grouping is enabled. Just leave it as it is at the 
 moment, I will look into that.
 
 About the row/column positions that are a bit off: the 
 QAccessible::updateAccessibility() calls always add 1 to the current index, 
 that looks strange and might be the cause of an off-by-one error. Or is there 
 a reason why 1 has to be added?

Yes, the +1 is one of the really ugly sides in Qt 4 accessibility. It's 
required, because we index children 1-based (0 is the item itself, 1 the first 
child). In Qt 5 this has been removed and the API is a lot more intuitive. For 
the time being this will have to stay this way though. I will happily do the Qt 
5 port in the near future.


- Frederik


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17313
---


On Aug. 13, 2012, 5:50 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 13, 2012, 5:50 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt 5c1a6da 
   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




Re: Review Request: Adding Accessibility Interfaces for Dolphin Views Widgets

2012-08-13 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17304
---



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13465

missing #ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13464

I agree with Jose, remove the removeFactory.



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13468

#ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13466

Why do you send LocationChanged here? I don't think it's right or relevant. 
We generally don't send geometry updates.



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13469

#ifndef QT_NO_ACCESSIBIILTY



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13467

Remove LocationChanged



dolphin/src/kitemviews/kitemlistcontainer.cpp
http://git.reviewboard.kde.org/r/105972/#comment13470

#ifndef QT_NO_ACCESSIBIILTY and remove LocationChanged everywhere.



dolphin/src/kitemviews/kitemlistselectionmanager.cpp
http://git.reviewboard.kde.org/r/105972/#comment13471

not needed, revert the whole file.



dolphin/src/kitemviews/kitemlistview.cpp
http://git.reviewboard.kde.org/r/105972/#comment13472

I agree, you should only have one factory for all classes. Missing #ifndef 
QT_NO_ACCESSIBIILTY here again.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13474

Qt itemview headers should not be needed here.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13477

Doesn't make sense, you could have itemviews ng without the traditional 
itemviews.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13475

use the same style of comment everywhere (either capitalize or not, either 
space after // or not)



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13476

Having the protected keyword twice doesn't make much sense.



dolphin/src/kitemviews/kitemlistviewaccessible.h
http://git.reviewboard.kde.org/r/105972/#comment13478

Weird style (two spaces), parenthesis with extra spaces etc, see kde libs 
coding style.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13473

dtor not needed, I'd prefer to remove it.



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13479

Never use  for an empty string. You want QString().



dolphin/src/kitemviews/kitemlistviewaccessible.cpp
http://git.reviewboard.kde.org/r/105972/#comment13480

Actually I don't think there is much to fix. The model change can be 
ignored, it's a broken concept that got into QAccessible from IAccessible2. 
Rather add a comment that it's ignored on purpose (and will be gone in Qt 5).


- Frederik Gladhorn


On Aug. 13, 2012, 5:50 a.m., Amandeep Singh wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105972/
 ---
 
 (Updated Aug. 13, 2012, 5:50 a.m.)
 
 
 Review request for Dolphin, KDE Base Apps and KDE Accessibility.
 
 
 Description
 ---
 
 Added Accessibility Interfaces for Dolphin Views  Widgets, to make it 
 accessible.
 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that 
 contain the three new classes.
 
 
 Diffs
 -
 
   dolphin/src/CMakeLists.txt 5c1a6da 
   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
   dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f 
   dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d 
   dolphin/src/kitemviews/kitemlistview.h 5723b9a 
   dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 
   dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION 
   dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION 
   dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d 
   dolphin/src/tests/CMakeLists.txt 3f906d1 
 
 Diff: http://git.reviewboard.kde.org/r/105972/diff/
 
 
 Testing
 ---
 
 Focus-tracking tested with KMag / KWin. 
 
 
 Thanks,
 
 Amandeep Singh
 




KDE Accessibility Docmentation

2012-01-20 Thread Frederik Gladhorn
Hi,

after a few requests, I spent some time today trying to provide a some 
documentation for KDE accessibility.
Keep in mind that this is such a broad topic that I can only hope to see the 
tip of the iceberg.
I am currently in A Coruña at the Gnome accessibility hackfest in order to 
learn and cooperate.

I put the documentation in two places, trying to give it some structure but I 
know it needs some help and polish.
If you spot errors or think that it can be improved, please do so.

The user documentation can be found here:
http://userbase.kde.org/Accessibility

My request to people testing kde applications with screen readers would be to 
record your experiences. Especially when an application is almost useable, send 
a mail to the kde-accessibil...@kde.org list and maybe put a few notes in the 
list of applications 
(http://userbase.kde.org/Accessibility/Application_Overview).
Yes, I think it is about time to start testing. I know there are a few open 
bugs, we put a first round into Qt 4.8.1 today.

For developers, I tried to summarize some things here:
http://techbase.kde.org/Development/Tutorials/Accessibility

It would be great if people with actual knowledge of what needs to be done for 
good experiences with screen readers and other accessibility needs could add to 
the checklist.

If you would like to help with this effort, please let me know.
I'm looking for help with moving the good contents that may lurk on 
accessibility.kde.org over to the wikis.
If you can generally check/proofread/improve the documentation, that would be 
fabulous.

I have some work for applications started, an unfinished Kate patch for 
example, but we need feedback, which appliations you would like to be 
accessible.
On the other hand, I'm more than happy for every developer that is interested 
in fixing their application or doing some general work in this area.
And finally we need people to help test all this, best if you want an 
application to be usefull to you. Feedback appreciated!

Join #kde-accessibility on freenode.

Cheers
Frederik




Re: Releasing qt-at-spi

2012-01-05 Thread Frederik Gladhorn
Hi,

Onsdag 4. januar 2012 17.37.50 skrev ext Christoph Feck:
 On Wednesday 04 January 2012 16:23:10 Frederik Gladhorn wrote:
  I would like to announce the availability of the Qt AT-SPI bridge
  0.1.1. Since I think this is a nice number and I don't know of any
  major bugs in there at the moment, I consider it released.
 
 Thanks, accessibility is a requirement for many agencies, and getting
 KDE in the boat is a nice addition.
 
  Feedback what works is appreciated. I know most KDE applications
  don't work good enough but now everyone can start testing and
  improving things :)
 
 Is there a list/guide what KDE application developers can do to
 improve accessibility-awareness? How can the KDE quality team test
 which applications fail to work good enough and suggest
 improvements?

There are some general points that I'll rehash without thinking about it too 
much, these should be known:
- The usual HIG apply: make sure that the application is keyboard accessible 
(try seeing if the tab key gets you through all widgets in a sensible order) 
is quite important.
(Using a mouse is more troublesome when you can't see where you're pointing 
than moving a focus for example, different kinds of motorical issues etc...)

- Check for color scheme compliance and font settings taking effect.


More advanced would be the usage of assistive technology. I think we need to 
learn from people with actual need of these technologies in order to get a 
good grasp of the issues. I can try to write down some issues I know about.

1 Get Orca to work in general - just grab the gnome-orca package that should 
be in pretty much any distro and try it with some gtk app. Test that it reacts 
to focus changes.
2 Make sure it's using dbus. That means having libatspi 2.0 (package name may 
vary, see also the settings here: 
http://labs.qt.nokia.com/2011/08/23/accessibility-on-linux/)
3 Have Qt 4.8 and the qt-at-spi bridge.
4 export QT_ACCESSIBILITY=1 (this is needed for Qt 4, fixed in Qt 5)
5 Run the KDE/Qt application you want to test with the Qt version for which 
you have the bridge installed. (This works even with Qt built separately in 
the home directory and the bridge installed there.)

Once you have an application running with the screen reader:
Make sure Orca says something intelligible for all elements. When it reads a 
gui element it should say the label and type, eg: File, Menu or OK, 
Button.
When you have a button that does not have a label, maybe because it shows a 
picture only, that's something to fix. Try navigating the more troublesome 
elements - comboboxes and lists and such. Trees need a bit of love in the 
bridge still.

Apart from the bridge probably still lacking features and having a few bugs, I 
think now it's mostly time to fix up the small missing bits.

Fixing stuff: the good news is that it's really easy usually, no heavy C++ 
skills required.
There are two important properties that every QWidget has: AccessibleName and 
AccessibleDescription.
The name is a short label, for example the label on a button. It should always 
be short. The description on the other hand is the more verbose this button 
does foo and then bar.
Fire up Qt designer if the app uses .ui files, you'll find the properties and 
can type the name/description right in.
If the widget is managed in code, just find the right place and set them:
button-setAccessibleName(i18n(Open));
button-setAccessibleDescription(i18n(Opens a file dialog to select a new 
foo));

Sometimes you also want to override the label for a different reason. One of my 
test apps was the calculator example from Qt. It has a memory recall button 
labelled MR. Orca will insist on this being the Mister button, unless told 
otherwise. Of course I couldn't fix that one since it made me smile every 
single time ;)

I bet there's more, but this is a beginning. In the end it would be great to 
build up a bit of a community that starts using these applications on a 
regular basis.

Should we gather these and extend them on some wiki? I'd love to have some 
accessibility testing going on some time in the future.

Greetings
Frederik

(I put kde-accessibility into cc so the info goes there as well.)


 
 Christoph Feck (kdepepo)
 KDE Quality Team

 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 


Re: KDE at the Qt Contributors Summit

2011-06-10 Thread Frederik Gladhorn
Hi,
this is for attendants of the Qt Contributors Summit.


Make sure that all the info from the KDE wiki pages is also on the dev net 
wiki!

In other words: take your session proposal and put it into the schedule.

All topics should be listed here:
http://developer.qt.nokia.com/groups/qt_contributors_summit/wiki/Topic_List

and have a slot reserved here:
http://developer.qt.nokia.com/groups/qt_contributors_summit/wiki/Schedule

The earlier you do it, the better the slots you get!

Cheers
Frederik



 
 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe 


Accessibility and KDE Sessions

2011-05-10 Thread Frederik Gladhorn
Hi,
currently there is good stuff happening when it comes to Accessibility and KDE.

I have lately spend some time improving the qt-at-spi bridge and it is getting 
a lot better, I hope we will have something sensibly working with Qt 4.8 and 
correspondingly one of the next KDE releases.

On thing that came up with the Gnome accessibility people is how we enable 
accessibility in a cross-desktop way. There are two sides to this: 1) when 
should Qt load the accessibility plugins on Linux and 2) how to make a KDE 
session accessible on log in.

1) Making Qt load accessibility plugins:
One possible solution is to query a X-Atom to check if the accessibility dbus 
is running. The downside is that this only works for newly started 
applications. It requires no changes to the existing infra structure and can 
be handled inside Qt with no changes in other places.
(for comparison, on Windows we get a system call NotifyWinEvent which signifies 
that now the accessibility should be activated... the current reality is that 
you need to have QT_ACCESSIBILITY=1 set in your environment when starting a Qt 
app)

2) Activating accessibility for a KDE Session
I have no idea about how to handle this in KDM.
For KDE in general, we could again persue a similar way to what Gnome does.
There is the at-spi-dbus-bus.desktop file included in at-spi-2-core which takes 
care of starting a dbus registry and setting up the session as needed 
(starting Orca for example)
The desktop file checks for a gconf setting. [1] I guess there is some 
equivalent way to do this in KDE and the maintainers are happy to extend this 
for us.

I would be interested to get feedback how to tackle these issues and making 
them a cross desktop standard. I bet there are nicer solutions than what I 
posted above.

Cheers,
Frederik


[1]
[Desktop Entry]
Type=Application
Name=AT SPI D-Bus Bus
Exec=/usr/libexec/at-spi-bus-launcher --launch-immediately
OnlyShowIn=GNOME;
NoDisplay=true
AutostartCondition=GSETTINGS org.gnome.desktop.interface toolkit-accessibility
X-GNOME-AutoRestart=true


Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6410/#review9696
---

Ship it!


Looks good to me, please commit.

- Frederik


On Jan. 23, 2011, 6:06 p.m., Martin Blumenstingl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://svn.reviewboard.kde.org/r/6410/
 ---
 
 (Updated Jan. 23, 2011, 6:06 p.m.)
 
 
 Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting.
 
 
 Summary
 ---
 
 Currently it is not possible to uninstall entries via some self-written code.
 
 This patch simply adds an uninstall method to the DownloadManager - which is 
 used like the install method.
 
 
 Diffs
 -
 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.h 1216491 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.cpp 1216491 
 
 Diff: http://svn.reviewboard.kde.org/r/6410/diff
 
 
 Testing
 ---
 
 -
 
 
 Thanks,
 
 Martin
 




Re: Review Request: KNewStuff3: allow uninstalling an entry via DownloadManager

2011-01-23 Thread Frederik Gladhorn

---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6410/#review9697
---


Please add the @since tag for the right version (4.6 if you backport it).

- Frederik


On Jan. 23, 2011, 6:06 p.m., Martin Blumenstingl wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://svn.reviewboard.kde.org/r/6410/
 ---
 
 (Updated Jan. 23, 2011, 6:06 p.m.)
 
 
 Review request for kdelibs, Frederik Gladhorn and Jeremy Whiting.
 
 
 Summary
 ---
 
 Currently it is not possible to uninstall entries via some self-written code.
 
 This patch simply adds an uninstall method to the DownloadManager - which is 
 used like the install method.
 
 
 Diffs
 -
 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.h 1216491 
   /trunk/KDE/kdelibs/knewstuff/knewstuff3/downloadmanager.cpp 1216491 
 
 Diff: http://svn.reviewboard.kde.org/r/6410/diff
 
 
 Testing
 ---
 
 -
 
 
 Thanks,
 
 Martin
 




Re: KNewStuff questions (uninstalling/providers)

2011-01-22 Thread Frederik Gladhorn
Martin wrote:

 Hi,
 
 currently I'm trying to add KNewStuff3 support in yakuake.
 Unfortunately I've come to a point where I need some help.
 
 My first problem is that we want to validate the entries after
 installing them.
 Since there's not entryInstalled() signal in KNS3::DownloadWidget we
 agreed to validate all installed entries after the dialog/widget was
 closed. I implemented that, but it seems that it's not possible to
 uninstall an entry via code after it's been installed.
 The user would have to manually uninstall it via the UI.

It would be easy to extend this class to also allow uninstalling:

http://api.kde.org/4.x-api/kdelibs-
apidocs/knewstuff/html/classKNS3_1_1DownloadManager.html

 
 The main problem here is that the KNS3::Engine header is not installed
 [0]. Having it installed would solve my problem.
 Do you think the header could be installed (plus having that fix
 backported to the 4.6 branch), since it does not break anything (but add
 something useful instead)?
 I'm not sure what would speak against it, as the KNS2::Engine header is
 already installed.

With knewstuff2 we hat huge trouble to improve anything since everything was 
exported. This led to me being cautious in kns3.
Actually one pending issue is making the engine shared accross threads which 
will be fixable thanks to not exporting it.

 
 My second problem is the provider configuration.
 I'm not sure what I'm doing wrong, since calling the opendesktop API
 directly ([1]) only lists one entry.
 But when using knewstuff4 and the knsrc file (see [2]) it lists quite a
 few entries, which are in different categories.
 Is there something wrong with my knsrc file or is there some other
 configuration (maybe on the opendesktop.org side?) required for the
 Yakuake Skins category (this category is available on kde-look.org:
 [3]).

This really seems like a bug, I don't know when I'll find the time to look 
into it though.

Cheers,
Frederik



 
 
 Thanks in advance
 Regards,
 Martin
 
 PS: Please keep me CC'ed as I'm not subscribed to the list.
 
 
 [0] http://api.kde.org/4.x-api/kdelibs-
 apidocs/knewstuff/html/classKNS3_1_1Engine.html
 [1] http://api.opendesktop.org/v1/content/data?categories=87
 [2] http://paste.kde.org/2050/
 [3] http://kde-look.org/index.php?xcontentmode=87
  
 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
 unsubscribe 
 
 Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe