Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Dienstag, 13. Oktober 2020 09:03:01 CEST Dag wrote:
> mandag den 12. oktober 2020 21.02.31 CEST skrev Johnny Jazeix:
> > Hi,
> >
> > issue is there:
> > https://invent.kde.org/graphics/kdiagram/-/blob/2.7/src/KChart/CMakeLists.
> > txt#L126 qt5_wrap_cpp(KChart kchart_LIB_SRCS KChartEnums.h) should be
> > qt5_wrap_cpp(kchart_LIB_SRCS KChartEnums.h)
> >
> > I'm fixing it.
>
> Thanks for spoting it, my eyesight is ok but my brain takes no notice...
> Mvh Dag
In general, consider enabling all of the CMAKE_AUTO{MOC,RCC,UI} variables and
then stop using the manual qt5_wrap macros.
Cheers
--
Milian Wolff
m...@milianw.de
http://milianw.de
signature.asc
Description: This is a digitally signed message part.
Re: KDiagram - Persistent FTBFS for stable branch on Windows
mandag den 12. oktober 2020 21.02.31 CEST skrev Johnny Jazeix: Hi, issue is there: https://invent.kde.org/graphics/kdiagram/-/blob/2.7/src/KChart/CMakeLists.txt#L126 qt5_wrap_cpp(KChart kchart_LIB_SRCS KChartEnums.h) should be qt5_wrap_cpp(kchart_LIB_SRCS KChartEnums.h) I'm fixing it. Thanks for spoting it, my eyesight is ok but my brain takes no notice... Mvh Dag Johnny Le lun. 12 oct. 2020 à 16:32, Milian Wolff a écrit : On Montag, 12. Oktober 2020 14:04:06 CEST Dag wrote: ... -- Mvh Dag
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Tue, 13 Oct 2020, 8:03 am Johnny Jazeix, wrote: > Hi, > Hi all, > issue is there: > https://invent.kde.org/graphics/kdiagram/-/blob/2.7/src/KChart/CMakeLists.txt#L126 > qt5_wrap_cpp(KChart kchart_LIB_SRCS KChartEnums.h) should be > qt5_wrap_cpp(kchart_LIB_SRCS KChartEnums.h) > > I'm fixing it. > Thanks to everyone who took a look into this issue - it now appears to be resolved and CI service is fully back to normal. Cheers, Ben > Johnny > > > Le lun. 12 oct. 2020 à 16:32, Milian Wolff a écrit : > >> On Montag, 12. Oktober 2020 14:04:06 CEST Dag wrote: >> > mandag den 12. oktober 2020 12.58.36 CEST skrev Dag: >> > > mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff: >> > >> On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: >> > >>> On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff >> > >>> wrote: ... >> > >> >> > >> Thanks, but that's looking worse then I expected. I guess >> > >> backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth >> > >> a shot. >> > >> >> > >> @Dag: what do you say, should that be safe enough to do? >> > > >> > > No, it will not apply cleanly. I'll do it. >> > >> > Done, but made no difference, still fails. >> > Also tried qt_wrap_cpp -> qt5_wrap_cpp w/o sucess. >> > >> > I'm clueless on windows and can't run any virtual on my machine. >> > >> > Afaics we have this situation, please comment if wrong: >> > - The windows build worked earlier, prior to move to invent. >> > - There has been no changes to the stable branch between the successful >> > build and the failed build. >> > - At the first failing build of stable (oct 6), the code that seems to >> > trigger the failure was the same in stable and unstable except for the >> > qt5_wrap_cpp. >> > - There has been some modernization of unstable, mostly Q_FOREACH() -> >> > for() >> > >> > I'm at loss of even where to start to look, so I hope somebody can >> point a >> > finger in the right direction. >> >> Try to add a src/KChart/KChartEnums.cpp file - I actually wonder how this >> compiles at all on non-windows platforms :) >> >> Also add this line to the .h: >> >> ``` >> ~KChartEnums(); >> ``` >> >> and then this in the .cpp: >> >> ``` >> #include "KChartEnums.h" >> >> KChartEnums::~KChartEnums() = default; >> ``` >> >> This should ensure that moc knows where to put the include for the >> generated >> code (into KChartEnums.cpp). >> >> Cheers >> -- >> Milian Wolff >> m...@milianw.de >> http://milianw.de > >
Re: KDiagram - Persistent FTBFS for stable branch on Windows
Hi, issue is there: https://invent.kde.org/graphics/kdiagram/-/blob/2.7/src/KChart/CMakeLists.txt#L126 qt5_wrap_cpp(KChart kchart_LIB_SRCS KChartEnums.h) should be qt5_wrap_cpp(kchart_LIB_SRCS KChartEnums.h) I'm fixing it. Johnny Le lun. 12 oct. 2020 à 16:32, Milian Wolff a écrit : > On Montag, 12. Oktober 2020 14:04:06 CEST Dag wrote: > > mandag den 12. oktober 2020 12.58.36 CEST skrev Dag: > > > mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff: > > >> On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: > > >>> On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff > > >>> wrote: ... > > >> > > >> Thanks, but that's looking worse then I expected. I guess > > >> backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth > > >> a shot. > > >> > > >> @Dag: what do you say, should that be safe enough to do? > > > > > > No, it will not apply cleanly. I'll do it. > > > > Done, but made no difference, still fails. > > Also tried qt_wrap_cpp -> qt5_wrap_cpp w/o sucess. > > > > I'm clueless on windows and can't run any virtual on my machine. > > > > Afaics we have this situation, please comment if wrong: > > - The windows build worked earlier, prior to move to invent. > > - There has been no changes to the stable branch between the successful > > build and the failed build. > > - At the first failing build of stable (oct 6), the code that seems to > > trigger the failure was the same in stable and unstable except for the > > qt5_wrap_cpp. > > - There has been some modernization of unstable, mostly Q_FOREACH() -> > > for() > > > > I'm at loss of even where to start to look, so I hope somebody can point > a > > finger in the right direction. > > Try to add a src/KChart/KChartEnums.cpp file - I actually wonder how this > compiles at all on non-windows platforms :) > > Also add this line to the .h: > > ``` > ~KChartEnums(); > ``` > > and then this in the .cpp: > > ``` > #include "KChartEnums.h" > > KChartEnums::~KChartEnums() = default; > ``` > > This should ensure that moc knows where to put the include for the > generated > code (into KChartEnums.cpp). > > Cheers > -- > Milian Wolff > m...@milianw.de > http://milianw.de
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Montag, 12. Oktober 2020 14:04:06 CEST Dag wrote: > mandag den 12. oktober 2020 12.58.36 CEST skrev Dag: > > mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff: > >> On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: > >>> On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff > >>> wrote: ... > >> > >> Thanks, but that's looking worse then I expected. I guess > >> backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth > >> a shot. > >> > >> @Dag: what do you say, should that be safe enough to do? > > > > No, it will not apply cleanly. I'll do it. > > Done, but made no difference, still fails. > Also tried qt_wrap_cpp -> qt5_wrap_cpp w/o sucess. > > I'm clueless on windows and can't run any virtual on my machine. > > Afaics we have this situation, please comment if wrong: > - The windows build worked earlier, prior to move to invent. > - There has been no changes to the stable branch between the successful > build and the failed build. > - At the first failing build of stable (oct 6), the code that seems to > trigger the failure was the same in stable and unstable except for the > qt5_wrap_cpp. > - There has been some modernization of unstable, mostly Q_FOREACH() -> > for() > > I'm at loss of even where to start to look, so I hope somebody can point a > finger in the right direction. Try to add a src/KChart/KChartEnums.cpp file - I actually wonder how this compiles at all on non-windows platforms :) Also add this line to the .h: ``` ~KChartEnums(); ``` and then this in the .cpp: ``` #include "KChartEnums.h" KChartEnums::~KChartEnums() = default; ``` This should ensure that moc knows where to put the include for the generated code (into KChartEnums.cpp). Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Monday, 12 October 2020 10:47:12 BST Stefan Brüns wrote: > On Montag, 12. Oktober 2020 11:37:10 CEST Harald Sitter wrote: > > On 12.10.20 11:23, Milian Wolff wrote: > > > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > > >> Hi KDiagram Developers, > > >> > > >> The stable branch of KDiagram has been persistently failing to build > > >> from > > >> source now on Windows for a period greater than 5 days. > > > > > > Hey Ben, > > > > > > can you link me to such a CI failure? Then I could try to blind-fix it, > > > as > > > I don't have a KDE-on-windows setup here. But maybe it's simple enough > > > to > > > fix even without that. > > > > Just FTR for everyone's benefit: > > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Windows# > > Vi rtual_Machines > > "You may use the software in the virtual hard disk image only to demonstrate > and internally evaluate it. You may not use the software for commercial > purposes. You may not use the softwarein a live operating environment." > > Using it as a development platform, even for trivial bugfixes is very likely > not covered by theses terms? > > Since when are we actively encouraging copyright infringements? > > Regards, Stefan I would argue that this case comes under "internally evaluate" -- we're only using it to test its compatibility with our software, and not as a platform for development in general. I think the preinstalled development tools strongly imply that's an intended use-case; what would be the point otherwise? In any case, I'd generally look at the Windows build log or backtrace but then make the actual code changes from Linux because I've got all the tools set up nicely there. The question is less clear for people paid to work on KDE software, where the "commercial purposes" clause might apply. Even then, the chain from testing on a Windows image to any particular commercial purpose is pretty tortuous. -- Francis H [not a lawyer] signature.asc Description: This is a digitally signed message part.
Re: KDiagram - Persistent FTBFS for stable branch on Windows
Hi everyone, On 12.10.20 14:04, Dag wrote: I'm at loss of even where to start to look, so I hope somebody can point a finger in the right direction. Looking at the build log, it appears that the methods qt_metacall, qt_metacast and metaObject as well as the staticMetaObject of the KChartEnums class are not found by the linker. This suggests there are moc issues with this class. Regards, Chris
Re: KDiagram - Persistent FTBFS for stable branch on Windows
mandag den 12. oktober 2020 12.58.36 CEST skrev Dag: mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff: On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff wrote: ... Thanks, but that's looking worse then I expected. I guess backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth a shot. @Dag: what do you say, should that be safe enough to do? No, it will not apply cleanly. I'll do it. Done, but made no difference, still fails. Also tried qt_wrap_cpp -> qt5_wrap_cpp w/o sucess. I'm clueless on windows and can't run any virtual on my machine. Afaics we have this situation, please comment if wrong: - The windows build worked earlier, prior to move to invent. - There has been no changes to the stable branch between the successful build and the failed build. - At the first failing build of stable (oct 6), the code that seems to trigger the failure was the same in stable and unstable except for the qt5_wrap_cpp. - There has been some modernization of unstable, mostly Q_FOREACH() -> for() I'm at loss of even where to start to look, so I hope somebody can point a finger in the right direction. -- Mvh Dag
Re: KDiagram - Persistent FTBFS for stable branch on Windows
mandag den 12. oktober 2020 12.04.04 CEST skrev Milian Wolff: On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff wrote: ... Thanks, but that's looking worse then I expected. I guess backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth a shot. @Dag: what do you say, should that be safe enough to do? No, it will not apply cleanly. I'll do it. -- Mvh Dag
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Montag, 12. Oktober 2020 11:28:45 CEST Ben Cooksley wrote: > On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff wrote: > > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > > > Hi KDiagram Developers, > > > > > > The stable branch of KDiagram has been persistently failing to build > > > from > > > source now on Windows for a period greater than 5 days. > > > > Hey Ben, > > Hi Milian, > > > can you link me to such a CI failure? Then I could try to blind-fix it, as > > I > > don't have a KDE-on-windows setup here. But maybe it's simple enough to > > fix > > even without that. > > I suspect the fix just needs cherry picking - hopefully it isn't too > complicated to fix. > > The failure log is at > https://build.kde.org/job/Calligra/job/kdiagram/job/stable-kf5-qt5%20Windows > MSVCQt5.15/4/consoleText More recent builds can be found at > https://build.kde.org/job/Calligra/job/kdiagram/job/stable-kf5-qt5%20Windows > MSVCQt5.15/ Thanks, but that's looking worse then I expected. I guess backporting `35e86e964908ee906dde4f0678c16a838e4712dd` is worth a shot. @Dag: what do you say, should that be safe enough to do? Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Montag, 12. Oktober 2020 11:37:10 CEST Harald Sitter wrote: > On 12.10.20 11:23, Milian Wolff wrote: > > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > >> Hi KDiagram Developers, > >> > >> The stable branch of KDiagram has been persistently failing to build from > >> source now on Windows for a period greater than 5 days. > > > > Hey Ben, > > > > can you link me to such a CI failure? Then I could try to blind-fix it, as > > I don't have a KDE-on-windows setup here. But maybe it's simple enough to > > fix even without that. > > Just FTR for everyone's benefit: > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Windows#Vi > rtual_Machines "You may use the software in the virtual hard disk image only to demonstrate and internally evaluate it. You may not use the software for commercial purposes. You may not use the softwarein a live operating environment." Using it as a development platform, even for trivial bugfixes is very likely not covered by theses terms? Since when are we actively encouraging copyright infringements? Regards, Stefan -- Stefan Brüns / Bergstraße 21 / 52062 Aachen phone: +49 241 53809034 mobile: +49 151 50412019 signature.asc Description: This is a digitally signed message part.
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On 12.10.20 11:23, Milian Wolff wrote: > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: >> Hi KDiagram Developers, >> >> The stable branch of KDiagram has been persistently failing to build from >> source now on Windows for a period greater than 5 days. > > Hey Ben, > > can you link me to such a CI failure? Then I could try to blind-fix it, as I > don't have a KDE-on-windows setup here. But maybe it's simple enough to fix > even without that. Just FTR for everyone's benefit: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Windows#Virtual_Machines Ever so useful to have if one deals with windows breakage more than once a year ;) HS signature.asc Description: OpenPGP digital signature
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Mon, Oct 12, 2020 at 10:24 PM Milian Wolff wrote: > On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > > Hi KDiagram Developers, > > > > The stable branch of KDiagram has been persistently failing to build from > > source now on Windows for a period greater than 5 days. > > Hey Ben, > Hi Milian, > > can you link me to such a CI failure? Then I could try to blind-fix it, as > I > don't have a KDE-on-windows setup here. But maybe it's simple enough to > fix > even without that. > I suspect the fix just needs cherry picking - hopefully it isn't too complicated to fix. The failure log is at https://build.kde.org/job/Calligra/job/kdiagram/job/stable-kf5-qt5%20WindowsMSVCQt5.15/4/consoleText More recent builds can be found at https://build.kde.org/job/Calligra/job/kdiagram/job/stable-kf5-qt5%20WindowsMSVCQt5.15/ > > Cheers > Cheers, Ben > > > It would be appreciated if you could please remedy this situation without > > delay, as your failure prevents the CI system from operating services > > correctly for the following projects: > > - KStars > > - Konversation > > - Skrooge > > - Okteta > > - KDiff3 > > - Alkimia > > - KMyMoney > > - KRename > > -- > Milian Wolff > m...@milianw.de > http://milianw.de
Re: KDiagram - Persistent FTBFS for stable branch on Windows
On Montag, 12. Oktober 2020 11:11:22 CEST Ben Cooksley wrote: > Hi KDiagram Developers, > > The stable branch of KDiagram has been persistently failing to build from > source now on Windows for a period greater than 5 days. Hey Ben, can you link me to such a CI failure? Then I could try to blind-fix it, as I don't have a KDE-on-windows setup here. But maybe it's simple enough to fix even without that. Cheers > It would be appreciated if you could please remedy this situation without > delay, as your failure prevents the CI system from operating services > correctly for the following projects: > - KStars > - Konversation > - Skrooge > - Okteta > - KDiff3 > - Alkimia > - KMyMoney > - KRename -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.
KDiagram - Persistent FTBFS for stable branch on Windows
Hi KDiagram Developers, The stable branch of KDiagram has been persistently failing to build from source now on Windows for a period greater than 5 days. It would be appreciated if you could please remedy this situation without delay, as your failure prevents the CI system from operating services correctly for the following projects: - KStars - Konversation - Skrooge - Okteta - KDiff3 - Alkimia - KMyMoney - KRename Regards, Ben
