Re: May 10: Removing l10n support for kde4 playground-* repos
Zoltan Padrah ezt írta (időpont: 2019. máj. 2., Cs, 17:51): > > Yes, I have started the conversion to KF5 manually. > > I had tried one of the scripts (convert-to-k4aboutdata.pl ?) and it just > messed up the code badly, so I have given up on the scripts. Without > reading the documentation (and learning some Pearl) they have not looked > useful for me. > > Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it > crashes immediately. > > Hi, I've switched KTechLab's master branch to KF5. Now it builds and runs for me (it still has several issues). So KTechLab's master branch can be set as KF5 version and things related to KDE4 can be cleared up more. The previous state of the code is now available in the branch master-kde4. Best regards, Zoltan
Re: ktechlab KF5 - was - Re: May 10: Removing l10n support for kde4 playground-* repos
Albert Astals Cid ezt írta (időpont: 2019. máj. 16., Cs, 1:08): > > > > > > > Bessdes that there's some missing libraries (i.e. gui uses khtml_part.h > > > but doesn't link to KF5::Html) > > > and there's also a weird loop in which stuff in src/gui/ uses stuff > from > > > just src/ and that is bad given how src/gui wants to be its own static > > > library. > > > > > > > > Around building `src/gui` is a lot of breakage, not just because of > > circular dependencies, but also because the generated headers from Qt .ui > > files are included in other directories and cmake fails to detect > > dependencies between the generated headers and the files from other > > directories which include them. For KDE4 I've just made a script which > > generated headers from `src/gui` first and run make only after that; the > > same issue still happens in KF5 but I want to fix it somehow. My best > idea > > is to move files around, remove circular dependencies and modify files to > > do not include generated files in different directories / static > > libraries... > > My suggestion would be not to use that many static libraries if you're > having trouble with the circular dependencies between them. > > Just start by building everything into a big blob, and once you have it > building, see if you can chop it in different pieces. > > Done. Thanks for the hint, now the dependencies on generated .h files are fixed. I've tested it on KDE Neon User Edition and it compiled and ran (with some issues). > Cheers, > Albert > > > > > > > > > > Cheers, > > > Albert > > > > > > > > Best regards, > > > > Zoltan > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Ciao > > > > > -- > > > > > Luigi > > > > > > > > > > > > > > > > > > > > > >
Re: ktechlab KF5 - was - Re: May 10: Removing l10n support for kde4 playground-* repos
El dilluns, 13 de maig de 2019, a les 22:06:44 CEST, Zoltan Padrah va escriure: > Albert Astals Cid ezt írta (időpont: 2019. máj. 12., V, > 22:31): > > > El dijous, 2 de maig de 2019, a les 16:51:46 CEST, Zoltan Padrah va > > escriure: > > > Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it > > > crashes immediately. > > > > Doesn't compile for me. > > > > There's at least some includes for files that don't exist anymore (see > > attached patch). > > > > > Thanks for looking into this. As soon as I have some time I will apply more > fixes to the code. > > I assume that the code compiles for me and not for you because I still have > the kdelibs4-dev packages installed, thus the headers are found from KDE4. > > Your patch looks good to me, feel free to apply it. Done > > > > Bessdes that there's some missing libraries (i.e. gui uses khtml_part.h > > but doesn't link to KF5::Html) > > and there's also a weird loop in which stuff in src/gui/ uses stuff from > > just src/ and that is bad given how src/gui wants to be its own static > > library. > > > > > Around building `src/gui` is a lot of breakage, not just because of > circular dependencies, but also because the generated headers from Qt .ui > files are included in other directories and cmake fails to detect > dependencies between the generated headers and the files from other > directories which include them. For KDE4 I've just made a script which > generated headers from `src/gui` first and run make only after that; the > same issue still happens in KF5 but I want to fix it somehow. My best idea > is to move files around, remove circular dependencies and modify files to > do not include generated files in different directories / static > libraries... My suggestion would be not to use that many static libraries if you're having trouble with the circular dependencies between them. Just start by building everything into a big blob, and once you have it building, see if you can chop it in different pieces. Cheers, Albert > > > > > Cheers, > > Albert > > > > > Best regards, > > Zoltan > > > > > > > > > > > > > > > > > > > > > > > Ciao > > > > -- > > > > Luigi > > > > > > > > > > > >
Re: ktechlab KF5 - was - Re: May 10: Removing l10n support for kde4 playground-* repos
Albert Astals Cid ezt írta (időpont: 2019. máj. 12., V, 22:31): > El dijous, 2 de maig de 2019, a les 16:51:46 CEST, Zoltan Padrah va > escriure: > > Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it > > crashes immediately. > > Doesn't compile for me. > > There's at least some includes for files that don't exist anymore (see > attached patch). > > Thanks for looking into this. As soon as I have some time I will apply more fixes to the code. I assume that the code compiles for me and not for you because I still have the kdelibs4-dev packages installed, thus the headers are found from KDE4. Your patch looks good to me, feel free to apply it. > Bessdes that there's some missing libraries (i.e. gui uses khtml_part.h > but doesn't link to KF5::Html) > and there's also a weird loop in which stuff in src/gui/ uses stuff from > just src/ and that is bad given how src/gui wants to be its own static > library. > > Around building `src/gui` is a lot of breakage, not just because of circular dependencies, but also because the generated headers from Qt .ui files are included in other directories and cmake fails to detect dependencies between the generated headers and the files from other directories which include them. For KDE4 I've just made a script which generated headers from `src/gui` first and run make only after that; the same issue still happens in KF5 but I want to fix it somehow. My best idea is to move files around, remove circular dependencies and modify files to do not include generated files in different directories / static libraries... > Cheers, > Albert > > Best regards, Zoltan > > > > > > > > > > > > > > Ciao > > > -- > > > Luigi > > > > > > >
ktechlab KF5 - was - Re: May 10: Removing l10n support for kde4 playground-* repos
El dijous, 2 de maig de 2019, a les 16:51:46 CEST, Zoltan Padrah va escriure:
> Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it
> crashes immediately.
Doesn't compile for me.
There's at least some includes for files that don't exist anymore (see attached
patch).
Bessdes that there's some missing libraries (i.e. gui uses khtml_part.h but
doesn't link to KF5::Html)
and there's also a weird loop in which stuff in src/gui/ uses stuff from just
src/ and that is bad given how src/gui wants to be its own static library.
Cheers,
Albert
>
>
>
>
> >
> > Ciao
> > --
> > Luigi
> >
>
diff --git a/src/flowparts/pinmapping.cpp b/src/flowparts/pinmapping.cpp
index a7ea9ea5..52bf895a 100644
--- a/src/flowparts/pinmapping.cpp
+++ b/src/flowparts/pinmapping.cpp
@@ -21,7 +21,6 @@
#include
#include
-#include
#include
#include
diff --git a/src/gui/programmerdlg.cpp b/src/gui/programmerdlg.cpp
index 9effc713..63fd88f2 100644
--- a/src/gui/programmerdlg.cpp
+++ b/src/gui/programmerdlg.cpp
@@ -21,7 +21,6 @@
#include
#include
-#include
class ProgrammerWidget : public QWidget, public Ui::ProgrammerWidget {
diff --git a/src/ktechlab.cpp b/src/ktechlab.cpp
index 9aec209d..e64ead51 100644
--- a/src/ktechlab.cpp
+++ b/src/ktechlab.cpp
@@ -47,7 +47,6 @@
#include
#include
-#include
#include
#include
#include
Re: May 10: Removing l10n support for kde4 playground-* repos
Luigi Toscano ezt írta (időpont: 2019. máj. 2., Cs, 14:21): > Zoltan Padrah ha scritto: > > > > > > Albert Astals Cid mailto:aa...@kde.org>> ezt írta > (időpont: > > 2019. ápr. 24., Sze, 23:40): > > > [1] > > https://cgit.kde.org/ktechlab.git/tree/?h=wip-kf5-try1 > > > > Anything in particular you're stuck with? > > > > > > I had quite some headaches with setting up the include directories. > After > > reading the documentation I assume that if I set up the > target_link_libraries > > correctly for targets, the include directories will be automatically > added to > > the compiler command-line. Will see the results when I try to make the > > application compile... > > Did you start the conversion manually? > I usually start with adapt_cmakelists_file.pl from > https://cgit.kde.org/kde-dev-scripts.git/tree/kf5, with some manual > tuning > until it compiles, and then I use the other scripts with some manual > tuning > for the complex part of the porting which can't be fully automated (KUrl, > for > example). > > Yes, I have started the conversion to KF5 manually. I had tried one of the scripts (convert-to-k4aboutdata.pl ?) and it just messed up the code badly, so I have given up on the scripts. Without reading the documentation (and learning some Pearl) they have not looked useful for me. Meanwhile: the latest code I've pushed to the KF5 branch compiles, but it crashes immediately. > > Ciao > -- > Luigi >
Re: May 10: Removing l10n support for kde4 playground-* repos
Zoltan Padrah ha scritto: Albert Astals Cid mailto:aa...@kde.org>> ezt írta (időpont: 2019. ápr. 24., Sze, 23:40): [1] https://cgit.kde.org/ktechlab.git/tree/?h=wip-kf5-try1 Anything in particular you're stuck with? I had quite some headaches with setting up the include directories. After reading the documentation I assume that if I set up the target_link_libraries correctly for targets, the include directories will be automatically added to the compiler command-line. Will see the results when I try to make the application compile... Did you start the conversion manually? I usually start with adapt_cmakelists_file.pl from https://cgit.kde.org/kde-dev-scripts.git/tree/kf5, with some manual tuning until it compiles, and then I use the other scripts with some manual tuning for the complex part of the porting which can't be fully automated (KUrl, for example). Ciao -- Luigi
Re: May 10: Removing l10n support for kde4 playground-* repos
Albert Astals Cid ezt írta (időpont: 2019. ápr. 24., Sze, 23:40): > I guess we can let the kde4 master branch live a bit more. > > Ok, thanks. What's the name of your KF5 branch? Maybe we can help with the porting :) > > The work-in-progress KF5 branch is "wip-kf5-try1" [1]. It's in the first stage of porting, the buildsystem needs to be fixed in order to make the application (and tests) compile. [1] https://cgit.kde.org/ktechlab.git/tree/?h=wip-kf5-try1 > Anything in particular you're stuck with? > > I had quite some headaches with setting up the include directories. After reading the documentation I assume that if I set up the target_link_libraries correctly for targets, the include directories will be automatically added to the compiler command-line. Will see the results when I try to make the application compile... Best regards, Zoltan > Cheers, > Albert > > >
Re: May 10: Removing l10n support for kde4 playground-* repos
El dimarts, 23 d’abril de 2019, a les 12:59:21 CEST, Zoltan Padrah va escriure: > Albert Astals Cid ezt írta (időpont: 2019. ápr. 23., K, > 1:17): > > > El dilluns, 22 d’abril de 2019, a les 21:11:12 CEST, Zoltan Padrah va > > escriure: > > > Can you delay its removal from l10n support until the first KF5 release? > > > > Are you going to do another kde4 release? Hope not, so then we can just > > track the KF5 branch and that's it? > > > > > > Hopefully there will be no need for another KDE4 release -- I can only > imagine it happening if there is a critical issue which needs to be fixed. > So for now I'm comfortable to say that there will be no next KDE4 release. > > In the long term I want to have KF5 in master; currently there is just a > work-in-progress branch for KF5, which doesn't even compile. Do you prefer > to track that branch or disable l10n for KTechLab for now and I will ask > for re-enabling it when master will build with KF5? I guess we can let the kde4 master branch live a bit more. What's the name of your KF5 branch? Maybe we can help with the porting :) Anything in particular you're stuck with? Cheers, Albert > > > > > > Cheers, > > Albert > > > > > > > > Best regards, > > > > > > Zoltan > > > > > > > > > > > > > >
Re: May 10: Removing l10n support for kde4 playground-* repos
Albert Astals Cid ezt írta (időpont: 2019. ápr. 23., K, 1:17): > El dilluns, 22 d’abril de 2019, a les 21:11:12 CEST, Zoltan Padrah va > escriure: > > Can you delay its removal from l10n support until the first KF5 release? > > Are you going to do another kde4 release? Hope not, so then we can just > track the KF5 branch and that's it? > > Hopefully there will be no need for another KDE4 release -- I can only imagine it happening if there is a critical issue which needs to be fixed. So for now I'm comfortable to say that there will be no next KDE4 release. In the long term I want to have KF5 in master; currently there is just a work-in-progress branch for KF5, which doesn't even compile. Do you prefer to track that branch or disable l10n for KTechLab for now and I will ask for re-enabling it when master will build with KF5? > Cheers, > Albert > > > > > Best regards, > > > > Zoltan > > > > > > >
Re: May 10: Removing l10n support for kde4 playground-* repos
El dilluns, 22 d’abril de 2019, a les 21:11:12 CEST, Zoltan Padrah va escriure: > Albert Astals Cid ezt írta (időpont: 2019. ápr. 21., V, > 13:48): > > > We have a huge list of playground kde4 repos that are being processed for > > l10n. > > > > This takes some resources that make no sense since you should really not > > be developing for KDE4 anymore, and if you really really really need it, it > > shouldn't be in playground. > > > > So on May 10 i'll make sure scripty doesn't waste CPU on them. > > > > Cheers, > > Albert > > > > P.S: Anyone interested in the list https://ghostbin.com/paste/823jo > > > > > > > Hi, > > as I see KTechLab ( playground-devtools_ktechlab ) is in that list. Its > latest release still depends on KDE4 and its KF5 port is still work in > progress. > > Can you delay its removal from l10n support until the first KF5 release? Are you going to do another kde4 release? Hope not, so then we can just track the KF5 branch and that's it? Cheers, Albert > > Best regards, > > Zoltan >
Re: May 10: Removing l10n support for kde4 playground-* repos
Albert Astals Cid ezt írta (időpont: 2019. ápr. 21., V, 13:48): > We have a huge list of playground kde4 repos that are being processed for > l10n. > > This takes some resources that make no sense since you should really not > be developing for KDE4 anymore, and if you really really really need it, it > shouldn't be in playground. > > So on May 10 i'll make sure scripty doesn't waste CPU on them. > > Cheers, > Albert > > P.S: Anyone interested in the list https://ghostbin.com/paste/823jo > > > Hi, as I see KTechLab ( playground-devtools_ktechlab ) is in that list. Its latest release still depends on KDE4 and its KF5 port is still work in progress. Can you delay its removal from l10n support until the first KF5 release? Best regards, Zoltan
Re: May 10: Removing l10n support for kde4 playground-* repos
El diumenge, 21 d’abril de 2019, a les 17:47:47 CEST, Luigi Toscano va escriure:
> Christoph Feck ha scritto:
> > On 04/21/19 12:47, Albert Astals Cid wrote:
> >> We have a huge list of playground kde4 repos that are being processed for
> >> l10n.
> >>
> >> This takes some resources that make no sense since you should really not
> >> be
> >> developing for KDE4 anymore, and if you really really really need it, it
> >> shouldn't be in playground.
> >>
> >> So on May 10 i'll make sure scripty doesn't waste CPU on them.
> >>
> >> Cheers,
> >> Albert
> >>
> >> P.S: Anyone interested in the list https://ghostbin.com/paste/823jo
>
> Maybe we could move the code of everything-nepomuk and everything-plasma 4 to
> unmaintained.
My immediate goal is not to waste CPU power processing old code every day for
no reason, but yes, that probably makes sense too.
Cheers,
Albert
>
> >
> > https://cgit.kde.org/smaragd.git/tree/CMakeLists.txt says that
> > playground-artwork_smaragd is a KF5 repo. Where does the KDE4 detection
> > come
> > from?
>
> trunk/l10n-kde4 tracks the "0.0" branch:
>
> {"stable": "none", "trunk": "0.0", "stable_kf5": "none", "trunk_kf5":
> "master"}
>
> Happy Easter too!
>
> Ciao
>
Re: May 10: Removing l10n support for kde4 playground-* repos
Christoph Feck ha scritto:
On 04/21/19 12:47, Albert Astals Cid wrote:
We have a huge list of playground kde4 repos that are being processed for l10n.
This takes some resources that make no sense since you should really not be
developing for KDE4 anymore, and if you really really really need it, it
shouldn't be in playground.
So on May 10 i'll make sure scripty doesn't waste CPU on them.
Cheers,
Albert
P.S: Anyone interested in the list https://ghostbin.com/paste/823jo
Maybe we could move the code of everything-nepomuk and everything-plasma 4 to
unmaintained.
https://cgit.kde.org/smaragd.git/tree/CMakeLists.txt says that
playground-artwork_smaragd is a KF5 repo. Where does the KDE4 detection come
from?
trunk/l10n-kde4 tracks the "0.0" branch:
{"stable": "none", "trunk": "0.0", "stable_kf5": "none", "trunk_kf5": "master"}
Happy Easter too!
Ciao
--
Luigi
Re: May 10: Removing l10n support for kde4 playground-* repos
On 04/21/19 12:47, Albert Astals Cid wrote: We have a huge list of playground kde4 repos that are being processed for l10n. This takes some resources that make no sense since you should really not be developing for KDE4 anymore, and if you really really really need it, it shouldn't be in playground. So on May 10 i'll make sure scripty doesn't waste CPU on them. Cheers, Albert P.S: Anyone interested in the list https://ghostbin.com/paste/823jo https://cgit.kde.org/smaragd.git/tree/CMakeLists.txt says that playground-artwork_smaragd is a KF5 repo. Where does the KDE4 detection come from? Thanks, and Happy Easter, Christoph Feck
May 10: Removing l10n support for kde4 playground-* repos
We have a huge list of playground kde4 repos that are being processed for l10n. This takes some resources that make no sense since you should really not be developing for KDE4 anymore, and if you really really really need it, it shouldn't be in playground. So on May 10 i'll make sure scripty doesn't waste CPU on them. Cheers, Albert P.S: Anyone interested in the list https://ghostbin.com/paste/823jo
